[01:45:18] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/8fs2uA [01:45:18] 13WikibaseDataModel/06master 147384216 15Gordon P. Hemsley: Make exception error message style more uniform. [01:45:19] 13WikibaseDataModel/06master 14dfff6fc 15Jeroen De Dauw: Merge pull request #276 from GPHemsley/exceptions... [03:22:21] (03CR) 10Jeroen De Dauw: [C: 031] Don't load the full entity into Lua to get labels/ sitelinks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [03:31:40] [13WikibaseDataModel] 15GPHemsley opened pull request #277: Fix copy pasta. (06master...06typos) 02http://git.io/xNkDHQ [03:49:45] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #277: Fix copy pasta. (06master...06typos) 02http://git.io/xNkDHQ [04:25:57] (03CR) 10Jeroen De Dauw: [C: 031] "o_O touching the holy CSS!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172027 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [07:02:18] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/tntecw [07:02:18] 13WikibaseDataModel/06master 14978eea1 15jeroendedauw: Remove undefined var [07:11:01] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14978eea1: @filbertkm Please to run the tests locally before submitting. For this component its totally trivial.... 02http://git.io/NFvt5g [08:19:10] (03PS7) 10Henning Snater: Removed focus smartness from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 [08:25:17] [13WikibaseDataModel] 15Tpt closed pull request #275: Makes EntityDocument implement Comparable (06master...06EntityDocumentImplementsComparable) 02http://git.io/nWbClA [08:41:17] [13ValueView] 15snaterlicious pushed 2 new commits to 06caseInsensitive: 02http://git.io/AEV5Fw [08:41:17] 13ValueView/06caseInsensitive 145a54f30 15Thiemo Mättig: caseInsensitive default to true [08:41:17] 13ValueView/06caseInsensitive 14d942282 15snaterlicious: Merge branch 'caseInsensitive' of git://github.com/wmde/ValueView into caseInsensitive [08:43:31] [13ValueView] 15snaterlicious pushed 1 new commit to 06caseInsensitive: 02http://git.io/R8GuWg [08:43:31] 13ValueView/06caseInsensitive 149c31e96 15snaterlicious: Added documentation/version bump [08:45:59] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/10 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/172208 [08:49:21] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/11/10 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/172208 (owner: 10Tobias Gritschacher) [08:51:27] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/11/10 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/172208 (owner: 10Tobias Gritschacher) [09:24:20] Henning_WMDE: can you have a look at beta? [09:24:27] "Uncaught Error: Entity constructor data has to be a plain object" [09:24:46] not sure how long this happens already.. [09:24:53] just noticed it [09:25:09] the build is from today [09:25:24] Henning_WMDE: e.g. http://wikidata.beta.wmflabs.org/wiki/Q17122 [09:26:09] strangely http://wikidata.beta.wmflabs.org/wiki/Q17122?debug=true works [09:26:39] Do I need to do something special? Not receiving an error. [09:27:08] Henning_WMDE: really? with debug=false? [09:27:13] hm.. [09:27:30] Are you logged in? [09:29:37] Henning_WMDE: yes. but just tried logging out. the eror is still there.. I do not get it in firefox.. hm.. and not in incognito mode.. ok, going to clear all of my browser cache now [09:30:46] The error message appears to be from the old JS data model code. [09:31:02] [13WikibaseDataModel] 15thiemowmde comment on pull request #276 147384216: To what does "object" refer to? Why the odd capitalization in "propertyId"?... 02http://git.io/q3cFYg [09:32:12] Henning_WMDE: ok, cleared all of the data from chrome now. [09:32:17] now it's ok :) [09:32:32] just cache, cookies and stuff was not ok [09:32:38] not enough [09:32:57] Where is the Tobi_WMDE_SW_NA [09:33:00] had to use the dev console to clear app data, session storage, and stuff too [09:33:58] Henning_WMDE: also with debug=false, the css glitch isn't happening anymore.. [09:34:07] however with debug=true it's there.. [09:34:16] JeroenDeDauw: evil foreign country [09:34:19] ;) [09:34:25] back tomorrows again [09:34:46] [13WikibaseDataModel] 15thiemowmde comment on pull request #276 147384216: Personally I find these additional `gettype` outputs overkill. That's what a debugger should do. I don't know who started this. I'm aware you just copied that. 02http://git.io/QLltUA [09:35:56] [13WikibaseDataModel] 15thiemowmde comment on pull request #276 147384216: That's why I prefer to not repeat variable names in messages. 02http://git.io/Qou_Aw [09:37:07] [13WikibaseDataModel] 15thiemowmde comment on pull request #276 147384216: Again, why the odd capitalization? That's neither a class nor a variable name. 02http://git.io/4bzGhQ [09:44:07] Tobi_WMDE_SW_NA: eviiiiil [09:47:14] Henning_WMDE: if time, could you have a look at the gadget breakage? http://wikidata.beta.wmflabs.org/wiki/Q12480?debug=true [09:47:29] mainSnak = statement.getMainSnak() seems not to work anymore.. [09:48:19] That's what we talked about recently... statement.getClaim().getMainSnak() [10:25:18] hmmm I can link only one wikinews item to an entry on WikiData ... but most items appear more then just once in the news, right? [10:27:45] a wikinews item should by a Wikidata element by itself (with "instance of" → "Wikinews article") [10:28:10] yeah ... it appears to be used in a different way then I expected [10:28:28] so how do I link a WIkiNews item about Jerry Brown to the person? [10:30:23] or is that a stupid question, in a technical point of view? [10:31:13] mmh, not too sure. I never done it... I have a couple of ideas on how to do it, though, just give me some minutes to look for the name of the properties in English ^^' [10:32:19] I'm here for at least four more hours ;-) [10:34:09] I guess I'd use https://www.wikidata.org/wiki/Property:P921 on the item for the Wikinews element [10:36:04] yeah ... the same link, but the other way around [10:36:38] another way to do it would be, on the Jerry Brown item, to add P793 (significant event) for the event itself, and then use a qualifier P805 (subject of) to link to the Wikinews article [10:37:03] not sure which way is the best, or if any of these are the good way to do it. [10:39:25] the P921 method makes the article show up in the reasonator ... [10:42:06] yes. It's also "bot-fixable" if it appears afterwards that it was not the good property (a bot can check for all item that have "instance of" → "Wikinews article" and "main subject" → and replace "main subject" by the appropriate property...) [10:43:21] * hoo waves [10:43:29] * Lydia_WMDE waves @ hoo [10:43:42] DanielK_WMDE_: Tobi_WMDE_SW_NA: are yxou joining via hangout? [10:44:41] Lydia_WMDE: I'm on mobile currently, so no. Sorry. [10:45:04] k [10:54:55] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c6 (10Jan Zerebecki) NEW does not prevent analysis. https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle says about UNCONFIRMED: "The status is changed to NEW whe... [11:05:55] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c7 (10Dereckson) To hijack the bug process for policies making and use a life cycle designed for technical issues will of course create this divergence of reading. Please also r... [11:21:52] * hoo going to leave in a moment [11:22:09] would be nice if someone could review all the stuffs I have in gerrit right now [11:27:56] 3MediaWiki extensions / 3WikidataClient: Unit tests for ExternalRecentChange - 10https://bugzilla.wikimedia.org/43198 (10Lydia Pintscher) [11:30:41] 3MediaWiki extensions / 3WikidataRepo: Maintenance script for summary - 10https://bugzilla.wikimedia.org/45150#c3 (10Lydia Pintscher) 5NEW>3RESO/WON Let's be realistic. Not happening... [11:31:25] 3MediaWiki extensions / 3WikidataRepo: wbsearchentities should return the datatype for properties - 10https://bugzilla.wikimedia.org/43069 (10Lydia Pintscher) [11:34:25] 3MediaWiki extensions / 3WikidataRepo: Do not rerender whole page when only sitelinks are updated - 10https://bugzilla.wikimedia.org/42783 (10Lydia Pintscher) s:5enhanc>3normal [11:34:40] 3MediaWiki extensions / 3WikidataRepo: Do not rerender whole page when only sitelinks are updated - 10https://bugzilla.wikimedia.org/42783 (10Lydia Pintscher) [11:35:40] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c8 (10Jan Zerebecki) AFAIK generally consensus in Wikimedia is to have stuff on gerrit.wikimedia.org (and mirror that to github). Do you agree? Maybe there was some special deci... [11:38:56] 3MediaWiki extensions / 3WikidataClient: Have filter option to view wikidata changes only - 10https://bugzilla.wikimedia.org/45853 (10Lydia Pintscher) p:5Normal>3Low s:5normal>3minor [11:38:56] 3MediaWiki extensions / 3WikidataClient: More specific filtering for recent changes on the client - 10https://bugzilla.wikimedia.org/42289 (10Lydia Pintscher) [11:39:19] heeelooooo [11:39:40] 3MediaWiki extensions / 3WikidataRepo: Make injecting entity labels into links more efficient. - 10https://bugzilla.wikimedia.org/43780#c1 (10Lydia Pintscher) 5NEW>3RESO/INV Dupe of several others. [11:40:35] (03PS4) 10Henning Snater: Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 [11:40:40] (03PS4) 10Henning Snater: Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 [11:40:40] hey lazowik [11:40:45] (03PS3) 10Henning Snater: Use wb.datamodel.Term in descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171878 [11:40:48] hey hey [11:41:25] 3MediaWiki extensions / 3WikidataRepo: Tests for PropertyDiff etc need refactoring - 10https://bugzilla.wikimedia.org/41106 (10Lydia Pintscher) [11:42:05] Lydia_WMDE: I've got a late birthday present [11:42:10] mych nyanz [11:42:11] https://www.youtube.com/watch?v=mghhLqu31cQ [11:42:25] 3MediaWiki extensions / 3WikidataRepo: updater fails if db tables missing but entities already present. - 10https://bugzilla.wikimedia.org/42716#c1 (10Lydia Pintscher) 5NEW>3RESO/WON Let's be realistic. Not going to happen... [11:42:31] *much [11:42:37] :D [11:43:34] Henning_WMDE: I remember.. thx! [11:43:40] 3MediaWiki extensions / 3WikidataRepo: Clean up Claims::getDiff() - 10https://bugzilla.wikimedia.org/44967 (10Lydia Pintscher) [11:44:09] 3MediaWiki extensions / 3WikidataRepo: Rename CachingSQLStore to LocalMirrorStore - 10https://bugzilla.wikimedia.org/45567 (10Lydia Pintscher) [11:45:25] 3MediaWiki extensions / 3WikidataRepo: Special:ItemByTitle search ignores Wikipedia redirection - 10https://bugzilla.wikimedia.org/42224 (10Lydia Pintscher) [11:45:26] 3Wikimedia / 3Wikidata: Wikidata search problems (tracking) - 10https://bugzilla.wikimedia.org/44529 (10Lydia Pintscher) [11:45:40] 3MediaWiki extensions / 3WikidataRepo: Special:ItemByTitle search ignores Wikipedia redirection - 10https://bugzilla.wikimedia.org/42224 (10Lydia Pintscher) s:5enhanc>3minor [11:45:48] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=46384 can be closed? [11:46:41] 3MediaWiki extensions / 3WikidataRepo: Cleanup PID code in Utils - 10https://bugzilla.wikimedia.org/42433#c1 (10Lydia Pintscher) Still relevant? [11:47:10] 3MediaWiki extensions / 3WikidataRepo: For wikibase entities, the Content-Language header should contain the user language. - 10https://bugzilla.wikimedia.org/41806 (10Lydia Pintscher) [11:47:55] 3MediaWiki extensions / 3WikidataRepo: Links in "In other languages" broken when language is an alias or out of use - 10https://bugzilla.wikimedia.org/45820 (10Lydia Pintscher) [11:49:10] 3MediaWiki extensions / 3WikidataRepo: Use HTMLForm in the special pages - 10https://bugzilla.wikimedia.org/46248 (10Lydia Pintscher) [11:49:58] Lydia_WMDE: since we have no test wiki (only beta), yes :) [11:50:03] and beta does that already [11:50:40] 3MediaWiki extensions / 3WikidataRepo: Configure test wikis to use manual localisation cache rebuild - 10https://bugzilla.wikimedia.org/46384 (10Lydia Pintscher) 5NEW>3RESO/FIX [11:56:04] Hi everyone [11:56:40] I’m preparing a workshop for this friday and I am interested in the complete list of properties: https://www.wikidata.org/wiki/Wikidata:List_of_properties/all [11:57:08] but i get a lot of script errors (The time allocated for running scripts has expired.) [11:57:26] does the list work? [12:17:12] Hola, buenos dias [12:38:45] [13WikibaseDataModel] 15GPHemsley comment on pull request #276 147384216: My reading on the code suggested that it's impossible to know what type of object was being handled, or else I would have named it specifically.... 02http://git.io/AntIAA [12:39:39] [13WikibaseDataModel] 15GPHemsley comment on pull request #276 147384216: Debugging can be a very tedious process if you don't know what you're looking for. Giving this information in the exception message helps you narrow your search much more quickly. 02http://git.io/FqEOFQ [12:39:49] [13WikibaseDataModel] 15GPHemsley comment on pull request #276 147384216: I don't see this as an issue. 02http://git.io/OjbbPA [12:41:05] [13WikibaseDataModel] 15GPHemsley comment on pull request #276 147384216: Well, it's the variable name within that method. But if you have a better suggestion, I'm open to it. I had to make decisions based only on the code. 02http://git.io/_-2QiA [12:54:53] aude: Lydia_WMDE: think we're ready to tag the new versions of propertySuggester and propertySuggester-python. [12:55:34] do you think we should make a 2.0 release of both components, or should we go with 1.2 (python) and 1.2 (suggester)? [12:56:03] after we decided on this, I can merge the pending PRs and tag the components. [13:00:07] aude: Lydia_WMDE: another thing, we do not have experimental features enabled on beta. is there any reason to not have it? it would at least be nice to be able to test them before we enable them. [13:04:36] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/YOkl1A [13:04:36] 13WikidataBrowserTests/06master 144a5b7a3 15Tobias Gritschacher: Update Gemfile.lock [13:12:12] it's a Tobi_WMDE_SW_NA ! [13:12:27] experimental features on beta would be ok [13:12:50] property suggester tag, ok although don't know if we should use it yet int he build [13:13:04] need to see what, if anything, we need to do (e.g. update the data) [13:13:16] Tobi_WMDE_SW_NA: what does this release include as new stuff? suggestions based on correlation to values, right? in that case 2.0 makes sense to me [13:13:40] Tobi_WMDE_SW_NA: we didn't enable experimental on beta to have somethign that is as close to production as possible [13:13:44] oh [13:13:45] wait [13:13:49] beta [13:13:53] there it is fine i'd say [13:13:53] we have test.wikidata [13:13:56] right [13:15:13] aude: ok. can you enable exp. features on beta then? [13:15:27] we do it in the build [13:15:35] or can [13:15:43] or can in the settings [13:16:42] Lydia_WMDE: aude: the new versions of property suggester would include (1) classifying properties and (2) using the json dumps for analysis [13:17:54] good for a 2.0 imho [13:18:01] but i am not opposing 1.2 [13:18:37] we would need to update the data together with deploying the new version of the suggester, as the new code only works with data generated with the updated python code! moritz pointed that out very clearly in his last email, so this is important to consider [13:20:14] Tobi_WMDE_SW_NA: we can still tag (2.0 imho) [13:20:29] just don't update it in the bulid until we update the data [13:20:37] aude: ok [13:20:46] i would put that in the next sprint [13:21:02] and we should also think about automating it more [13:21:06] Lydia_WMDE: can you give me (or probably aude can) merge-rights for https://github.com/Wikidata-lib/PropertySuggester-Python [13:21:12] i can't [13:21:23] I have rights for the other repository but not for the python one [13:21:25] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c9 (10Andre Klapper) Re: UNCONF vs NEW: Topic will be fully obsolete in two weeks in Phab anyway. (In reply to Jan Zerebecki from comment #8) > Maybe there was some special deci... [13:21:26] and thiemo should be added [13:21:42] Tobi_WMDE_SW_NA: https://gerrit.wikimedia.org/r/#/c/172239/ [13:22:00] Lydia_WMDE! Yo yo yo! Got some easy Wikidata tasks for Google Code-in? Or anybody else? Research/Outreach tasks especially welcome. :) [13:22:11] aaaah [13:22:13] i might [13:22:22] need to ask Lydia_WMDE [13:22:41] (03CR) 10Daniel Kinzler: [C: 04-1] "Looks pretty good now, but the test writes a user record to the live database." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [13:22:49] Lydia_WMDE: how about https://bugzilla.wikimedia.org/show_bug.cgi?id=72704 for code in? [13:23:03] Tobi_WMDE_SW_NA: k [13:23:21] it would probably take me 1-2 hours to figure out how to convert these [13:23:33] aude: andre__: ok [13:23:38] seems suitable [13:24:03] yay [13:24:09] they can use vagrant wikidata role [13:24:18] if that makes it easier to setup (i think so) [13:24:33] and then ask us or anomie what to do [13:24:34] could you put that into https://www.mediawiki.org/wiki/Google_Code-in_2014#Mentors.27_corner ? or maybe I can later today... [13:24:44] ok [13:26:10] andre__: under https://www.mediawiki.org/wiki/Google_Code-in_2014#Proposed_tasks ? [13:26:25] andre__: https://lists.wikimedia.org/pipermail/wikidata-l/2014-May/003861.html <- would be awesome to have but probably too much? [13:26:26] aude, yesh :) [13:26:37] also nothing i can mentor on the technical side [13:26:49] Lydia_WMDE, could you break that down into subtasks? :) [13:26:54] yeah. need mentor :-/ [13:27:20] Lydia_WMDE: are you able to give me the rights for PropertySuggester-Python or do I need to ask someone else? [13:27:20] but we still have twenty days to come up with more tasks before it starts, so if I somehow can keep stuff on your radar that would be awesome :) [13:29:05] Tobi_WMDE_SW_NA: working on it [13:29:11] :) [13:29:19] andre__: *nod* will think more [13:30:03] Tobi_WMDE_SW_NA: should be done now [13:30:38] Lydia_WMDE: works! thx. while you're on it, please also add thiemo for both of the repos [13:30:50] he has an outstanding invitation for it [13:32:58] aaaaah [13:33:09] * aude put it in the user interface section [13:33:20] (03CR) 10Daniel Kinzler: [C: 04-1] "Please don't add more cruft to ClientHooks, pull the repo notification related stuff out into a separate class following the pattern set b" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [13:36:10] 3Wikimedia / 3Wikidata: Add featured portal badge - 10https://bugzilla.wikimedia.org/73193 (10Lydia Pintscher) p:5Unprio>3High [13:36:40] 3MediaWiki extensions / 3WikidataRepo: old revisions show expanded reference sections - 10https://bugzilla.wikimedia.org/73168 (10Lydia Pintscher) p:5Unprio>3High [13:36:55] 3Wikimedia / 3Wikidata: Add featured portal badge - 10https://bugzilla.wikimedia.org/73193 (10Lydia Pintscher) [13:42:55] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: hook up Lua functions to record entity usage - 10https://bugzilla.wikimedia.org/71288#c1 (10Daniel Kinzler) 5RESO/FIX>3REOP Reopened since I0d342700 does not, indeed, handle this. I must have dreamed writing that code... [13:43:11] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: hook up Lua functions to record entity usage - 10https://bugzilla.wikimedia.org/71288 (10Daniel Kinzler) 5REOP>3ASSI [13:43:23] Lydia_WMDE: oops, sorry --^ [13:43:48] ;-) no [13:43:49] It's not hard to do, but it conflicts with some of the work Hoo is currently doing. Will coordinate with him. [13:43:51] problem [13:43:55] cool [13:47:41] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, untested." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [13:50:10] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c10 (10Dereckson) The problem you're trying to solve is a divergence of opinion about the more convenient and best platform do do outreach and be open to the world. GitHub allow... [13:50:17] Lydia_WMDE: we should pick that up asap though. [13:51:12] DanielK_WMDE_: k will put it on the list for tomorrow [13:51:27] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c11 (10Dereckson) (That should be red alert for you of the need to open a discussion) [13:57:36] (03PS8) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [14:12:45] Tobi_WMDE_SW_NA: https://bugzilla.wikimedia.org/show_bug.cgi?id=70335 can be closed? [14:13:57] Lydia_WMDE: yes [14:14:04] thx [14:14:06] closed it [14:14:09] thx [14:14:12] 3MediaWiki extensions / 3WikidataRepo: adapt entity suggester to new dump format - 10https://bugzilla.wikimedia.org/70335 (10tobias.gritschacher) 5PATC>3RESO/FIX [14:18:00] !nyan [14:18:00] ~=[,,_,,]:3 [14:21:58] aude: where is this evil hoo person hiding? [14:25:11] 3MediaWiki extensions / 3WikidataRepo: Enable instant edit-mode for empty term input boxes - 10https://bugzilla.wikimedia.org/72021 (10Lydia Pintscher) [14:25:26] 3MediaWiki extensions / 3WikidataRepo: Implement new SiteLink UI - 10https://bugzilla.wikimedia.org/68903 (10Lydia Pintscher) [14:38:12] (03PS1) 10Aude: Remove unused newSnakFormatter method in WikibaseClient [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172247 [14:48:25] 3MediaWiki extensions / 3WikidataClient: track entity usage on client pages - 10https://bugzilla.wikimedia.org/47288 (10Lydia Pintscher) [14:48:40] 3MediaWiki extensions / 3WikidataRepo: populate entity usage table during database schema update - 10https://bugzilla.wikimedia.org/73220 (10Lydia Pintscher) p:5Unprio>3Normal [14:51:55] 3MediaWiki extensions / 3WikidataRepo: populate entity usage table during database schema update - 10https://bugzilla.wikimedia.org/73220 (10Lydia Pintscher) [14:54:16] Henning_WMDE: aude: adding references and qualifiers is broken on beta. just found out why.. -_- [14:54:19] https://github.com/Wikidata-lib/PropertySuggester/pull/108 [14:54:24] aaaaa [14:54:36] the propertySuggester needs to be adjusted to the new version of DM JS [14:54:55] this is going to break all the gadgets? [14:55:02] the js data model change [14:55:14] (03PS1) 10Daniel Kinzler: Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) [14:55:33] Henning_WMDE: can you check the pull request (it's trivial) but also check if there is another spot in the code that needs to be adjusted.. you know better what changed [14:55:45] aude: yes, I've sent an email about that already some days ago [14:56:01] Tobi_WMDE_SW_NA: hmmmm, ok [14:56:25] aude: http://wikidata.beta.wmflabs.org/w/index.php?title=MediaWiki%3AGadget-AuthorityControl.js&diff=66837&oldid=65516 is the fix [14:56:27] 3MediaWiki extensions / 3WikidataRepo: remove the exclusive edit mode behaviour - 10https://bugzilla.wikimedia.org/73221 (10Lydia Pintscher) p:5Unprio>3Normal [14:56:27] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Lydia Pintscher) [14:56:27] 3MediaWiki extensions / 3WikidataRepo: IE11: Empty label/description input box loses focus after typing first character - 10https://bugzilla.wikimedia.org/72027 (10Lydia Pintscher) [14:56:36] but is not compatible with the old code AFAIK [14:56:40] 3MediaWiki extensions / 3WikidataRepo: click edit for aliases (there are none yet) and it doesn't auto-focus on the input box - 10https://bugzilla.wikimedia.org/72691 (10Lydia Pintscher) [14:56:41] Tobi_WMDE_SW_NA: probably other gadgets are affected [14:57:07] I'm only aware of authority control that has a selenium test [14:57:17] so, not able to test the rest [14:57:28] it's the most important one [14:59:45] Tobi_WMDE_SW_NA: PR seems to be ok. [15:00:49] (03CR) 10jenkins-bot: [V: 04-1] Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:04:06] wow, we are running a lot of travis builds for the suggester [15:04:31] Lydia_WMDE: http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page [15:06:14] (03CR) 10Aude: Track usage via Lua (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:07:19] aude: what's the currently deployed version of the suggester? is it 1.1.4? [15:07:58] I'm going to make a hotfix-release, otherwise stuff will break if we don't deploy the new version 2.0 [15:08:40] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393#c8 (10Lydia Pintscher) 5NEW>3RESO/FIX Fixed on beta now. [15:09:25] 1.1.4 i think [15:11:26] Tobi_WMDE_SW_NA: are you fixing the typo? else i can and then merge [15:11:45] * aude can ignore typo that is not in the first line but wants to fix this [15:14:07] aude: fixed [15:14:15] ok [15:14:24] aude: I'm going to tag a 1.1.5 release based on this commit: https://github.com/Wikidata-lib/PropertySuggester/compare/1.1.4...adjust_dmjs [15:14:31] ok [15:14:41] it is based on the 1.1.4 tag and contains only the hotfix [15:15:29] aude: https://github.com/Wikidata-lib/PropertySuggester/releases/tag/1.1.5 [15:15:36] hope that was the only issue.. :) [15:15:42] * aude hope so [15:17:07] aude: can 1.1.5 be included in the next build that goes to beta? tomorrow or so.. [15:17:14] sure [15:17:26] then we'll see if at least the tests run through again [15:17:35] cool thx [15:17:52] we are making a branch tomorrow or probably wednesday morning [15:18:06] composer update pulled the change in [15:19:28] aude: ok. great! [15:19:44] Tobi_WMDE_SW_NA: we also need a tag of data model [15:19:56] includes fix for issue with setting rank (only) [15:20:20] and i think nothing else that would be a problem to have in a tagged version [15:21:24] the statement list provider would be nice to have to use in wikibase [15:23:26] (03CR) 10Daniel Kinzler: "This extracts a bunch of code from EntityContent, which is a good thing - but it doesn't address the issue we have with the order of initi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [15:24:27] (03CR) 10Aude: "@daniel already doing :) probably would be a follow up patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [15:24:27] 3MediaWiki extensions / 3WikidataRepo: give indication when description gets too long - 10https://bugzilla.wikimedia.org/73225 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Our descriptions sometimes get too long to be useful to show in search results in the suggester and so on. We sh... [15:24:40] 3MediaWiki extensions / 3WikidataRepo: give indication when description gets too long - 10https://bugzilla.wikimedia.org/73225 (10Lydia Pintscher) p:5Unprio>3Normal [15:25:55] DanielK_WMDE_: do you want to merge and then have follow up patch with EntityViewFactory? [15:26:00] or want a chain of patches? [15:26:12] and then merge or squash [15:27:48] !nyan [15:27:48] ~=[,,_,,]:3 [15:31:35] (03PS2) 10Daniel Kinzler: Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) [15:34:20] aude: ok, I think you can go ahead and tag the DM [15:35:01] (03CR) 10Daniel Kinzler: Track usage via Lua (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:35:14] ok [15:37:25] (03CR) 10jenkins-bot: [V: 04-1] Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:39:35] grrr [15:39:56] jzerebecki: I replied to https://gerrit.wikimedia.org/r/#/c/168126/ [15:40:01] what exactly is the -1 for? [15:40:14] yes, the code is horrible... i'm not going to fix it :)( [15:40:19] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06claimMess from 14d6191c4 to 1462e353e: 02http://git.io/z2aTgQ [15:40:19] 13WikibaseDataModel/06claimMess 1462e353e 15Thiemo Mättig: Stop Statement requiring a Claim [15:42:24] DanielK_WMDE_: it was mainly that I didn't know reverting the global was automatic. [15:43:44] DanielK_WMDE_: you added 3 phpcs warnings/errors. but *sigh* whatever. [15:43:45] jzerebecki: merge it, then :) [15:44:08] DanielK_WMDE_: i would but, no +2 on core [15:44:14] so i added my +1 [15:44:42] thanks :) [15:44:52] yea, it's hard to write clean code in the middle of such a mess... [15:45:32] oh ffs. [15:45:59] jzerebecki: on an unrelated note... any idea what's wrong with https://gerrit.wikimedia.org/r/#/c/172248/ ? [15:46:03] I can't reproduce the failure. [15:46:10] hm... maybe with Lua disabled... [15:53:16] (03CR) 10JanZerebecki: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:53:27] ok, can reproduce it now. bah. initialization order. [15:54:07] heh then that recheck was unneccessary [15:54:23] the engine is there, but it doesnh't have a parser yet. need to defer initialization a bit more [16:02:32] Tobi_WMDE_SW_NA: http://wikidata.beta.wmflabs.org/wiki/Property:P116 has statements (although the js doesn't work, so can't edit) [16:03:39] and no statements https://www.wikidata.org/wiki/Property:P421 (for example), so didn't accidentally enable it there :) [16:06:40] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907 (10Andre Klapper) p:5Unprio>3Lowest [16:06:54] 3MediaWiki extensions / 3WikidataRepo: IE11: Empty label/description input box loses focus after typing first character - 10https://bugzilla.wikimedia.org/72027 (10Andre Klapper) [16:22:36] Hi [16:23:10] aude: Tobi_WMDE_SW_NA: you want rel of DM? [16:25:25] JeroenDeDauw: yes! [16:27:48] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Confirmed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172247 (owner: 10Aude) [16:28:37] aude: will make one now [16:28:44] thanks! :) [16:28:57] only bug fixes afaik and the statement list provider [16:29:35] aude: making non-breaking releases is cheap, so whatever [16:29:42] yeah [16:30:50] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ZLCpFw [16:30:50] 13WikibaseDataModel/06master 145077367 15jeroendedauw: Version 2.2.0 [16:31:13] [13WikibaseDataModel] 15JeroenDeDauw tagged 062.2.0 at 06master: 02http://git.io/7YbIYw [16:31:19] yay! [16:32:15] (03PS3) 10Daniel Kinzler: Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) [16:33:19] (03Merged) 10jenkins-bot: Remove unused newSnakFormatter method in WikibaseClient [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172247 (owner: 10Aude) [16:39:15] (03PS9) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [16:46:59] DanielK_WMDE_: around? [16:49:04] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Code looks good. Just some comments which can be tackled in a later patch." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [16:52:33] wmde/WikibaseDataModel/2.2.0/5077367 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/40559638 [16:56:25] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c12 (10Jan Zerebecki) Thank you, Andre for the related bug. (In reply to Dereckson from comment #10) > Please note for example you're totally ignored by Wikidata developers afte... [17:05:27] (03PS10) 10Thiemo Mättig (WMDE): Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [17:05:29] (03PS1) 10Thiemo Mättig (WMDE): Narrow EntityParserOutputGeneratorFactory interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 [17:16:18] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Some small things, mainly mistake in the documentation/missing documentation. Code looks good overall." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [17:37:13] [13WikibaseDataModelJavaScript] 15thiemowmde created 06remoteExtPathParts (+1 new commit): 02http://git.io/bQ_QtQ [17:37:13] 13WikibaseDataModelJavaScript/06remoteExtPathParts 146d29061 15Thiemo Mättig: Simplify remoteExtPath regex [17:40:31] [13WikibaseDataModelJavaScript] 15thiemowmde opened pull request #18: Simplify remoteExtPath regex (06master...06remoteExtPathParts) 02http://git.io/VZZGwQ [17:48:40] [13WikibaseSerializationJavaScript] 15thiemowmde created 06remoteExtPath (+1 new commit): 02http://git.io/FxnrvQ [17:48:40] 13WikibaseSerializationJavaScript/06remoteExtPath 14f654ea0 15Thiemo Mättig: Simplify remoteExtPath regex [17:49:15] [13WikibaseSerializationJavaScript] 15thiemowmde opened pull request #9: Simplify remoteExtPath regex (06master...06remoteExtPath) 02http://git.io/bI3PRw [17:52:43] [13DataValuesJavascript] 15thiemowmde created 06remoteExtPath (+1 new commit): 02http://git.io/066R9w [17:52:43] 13DataValuesJavascript/06remoteExtPath 14e4151c0 15Thiemo Mättig: Simplify remoteExtPath regex [17:53:01] [13DataValuesJavascript] 15thiemowmde opened pull request #55: Simplify remoteExtPath regex (06master...06remoteExtPath) 02http://git.io/i20OSA [17:54:12] 3Wikimedia / 3Wikidata: move git repositories that are dependencies of wikidata to gerrit - 10https://bugzilla.wikimedia.org/72907#c13 (10Dereckson) s/you/your current request [17:58:42] (03PS1) 10Thiemo Mättig (WMDE): Simplify remoteExtPath regex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172289 [18:04:42] [13DataTypes] 15thiemowmde created 06remoteExtPath (+1 new commit): 02http://git.io/0P693Q [18:04:42] 13DataTypes/06remoteExtPath 1429c64bd 15Thiemo Mättig: Simplify remoteExtPath regex [18:05:42] [13DataTypes] 15thiemowmde opened pull request #24: Simplify remoteExtPath regex (06master...06remoteExtPath) 02http://git.io/P8lBsw [18:19:50] wmde/DataTypes/remoteExtPath/29c64bd : Thiemo Mättig The build passed. http://travis-ci.org/wmde/DataTypes/builds/40569475 [20:33:54] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Almost +2, but uh, there is a little mistake." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172027 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [20:43:23] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Code looks good but I don't fully understand what's going on in this patch, unfortunately. Is this fixing an actual bug? How to test it? P" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 (owner: 10Henning Snater) [20:49:11] I wish I was also a crosswiki sockpuppeter so I could own a Wikidata item https://www.wikidata.org/w/index.php?search=Suspected+Wikipedia+sockpuppets+of+&title=Special%3ASearch&fulltext=Search&uselang=en [20:50:55] (03CR) 10Daniel Kinzler: "If you follow my suggestion, I'm not sure much would be left of EntityParserOutputGeneratorFactory. Do you think it would still be useful?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [20:52:11] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395#c4 (10denny vrandecic) Here is how the UI should work as long as we support only proleptic Gregorian (G) and proleptic Julian (J) calendars: - when entering... [20:52:53] (03CR) 10Daniel Kinzler: Implement EntityParserOutputGeneratorFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [20:59:01] ebraminio: that's kind of a wrong incentive [20:59:11] why not allow all users to be wikidata items? [21:02:09] dennyvrandecic: well in current situation however cross wiki sockpuppeter have more chance than us on having one :) [21:02:37] ebraminio: ah well, they get a category page that depends on them [21:02:43] there is not really an item about them [21:02:54] even if we allowed all users, it would be about their accounts [21:03:18] or else we would have issues with the topic page and the user page (eg for people who are wikipedians and wikipedia topics) [21:17:07] dennyvrandecic: if we add user items on Wikidata, we can also add a property for linking our dear sockpuppeters to their real item (is sockpuppet of) :) (what I really think is these should be removed altogether and their interwikis should be moved to local wikis instead) [21:17:46] ebraminio: I don't see the advantage of managing interwikis locally? [21:19:31] dennyvrandecic: Wikidata is intended to be free and reusable database I believe. Such information is not reusable outside Wikimedia at least [21:22:35] ebraminio: we have plenty of data which is kinda wikimedia internal [21:22:38] dennyvrandecic: for example on https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/Interwiki_links_for_subpages a lot of wiki related items just removed [21:23:06] for example /testcases was one real useful ones IMO [21:23:46] we also have items for things like village pump [21:23:55] you could argue that's also wikimedia specific [21:24:08] dennyvrandecic: Yes, you are right [21:24:33] wikidata contains data about wikimedia specific things, not only about general knowledge. that's a face. i know that DanielK_WMDE_ was a strong fan for marking those differently [21:24:49] but it didn't happen yet, so that's what we have to live it for now [21:28:00] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Restoring my +1. Henning?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) (owner: 10Hoo man)