[00:22:40] JeroenDeDauw: I'm still not clear on what code I'm supposed to be auditing for incorrect Entity assumptions. [00:23:20] GPHemsley: everything in Wikibase.git that type hints against Entity :) [00:23:44] Ok, that's what I wasn't sure about. There are a lot of different repos for various parts of Wikibase/Wikidata. [04:31:34] (03PS1) 10Aude: Remove PropertyNotFoundExceptionTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171196 [04:33:25] [13WikibaseDataModel] 15filbertkm created 06propertynotfound (+1 new commit): 02http://git.io/m-fv_w [04:33:25] 13WikibaseDataModel/06propertynotfound 14b667320 15aude: Update namespace for PropertyNotFoundExceptionTest... [04:35:51] wmde/WikibaseDataModel/propertynotfound/b667320 : aude The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/40026066 [04:43:05] (03CR) 10Aude: "@jeroen is PropertyNotFoundException not the right thing to use here?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [04:44:18] [13WikibaseDataModel] 15filbertkm opened pull request #273: Update namespace for PropertyNotFoundExceptionTest (06master...06propertynotfound) 02http://git.io/4YVbuQ [04:46:11] 3MediaWiki extensions / 3WikidataRepo: ChangeOpClaim using obsolete Entity::setClaims causes stack trace when adding statement on Property page - 10https://bugzilla.wikimedia.org/72671#c5 (10Aude) 5PATC>3RESO/FIX this particular issue is fixed, although it's probably not possible to remove statements on... [05:33:39] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/80s4Uw [05:33:39] 13WikibaseDataModel/06master 14da84795 15Marius Hoch: Merge pull request #273 from wmde/propertynotfound... [07:38:31] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/Cg_Sew [07:38:31] 13WikibaseDataModelJavaScript/06master 14373d72f 15snaterlicious: Bump version to 1.0 [07:40:06] [13WikibaseDataModelJavaScript] 15snaterlicious tagged 061.0 at 06master: 02http://git.io/t9NH2g [07:42:46] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/jFz43Q [07:42:46] 13WikibaseSerializationJavaScript/06master 14291598d 15snaterlicious: Bump version to 2.0 [07:43:37] [13WikibaseSerializationJavaScript] 15snaterlicious tagged 062.0 at 06master: 02http://git.io/draLzQ [07:48:54] (03PS12) 10Henning Snater: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [07:51:34] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [09:05:46] Adrian_WMDE: browsertests job succeeded the first time ever yesterday! \o/ https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/ [09:06:56] 133 scenarios (133 passed) 1518 steps (1518 passed) [09:07:21] no mystery failures. that was luck.. :) [09:11:43] Wow, I didn't realize they never ever pass completely [09:15:02] (03CR) 10Adrian Lang: [C: 032] $.wikibase.entitysearch: Confine minimum width [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169324 (owner: 10Henning Snater) [09:15:48] Adrian_WMDE: yeah, there was this reference-save-button "bug" that failed for 20 times or so.. [09:15:59] Ah, sure [09:16:00] otherwise they would have passed before [09:16:11] But the claimview statementview thing will break stuff again [09:16:24] also there are almost every time some timeouts or other mysieries [09:16:30] mysteries [09:16:32] Nothing we have browser tests for, though [09:16:50] Adrian_WMDE: what is going to break? [09:17:34] aude already found one thing: with this change, it seems now when i edit a url snak value, then click save, the url becomes linked (even if it is invalid) and never finishes saving. [09:17:55] Adrian_WMDE: ouch [09:18:18] should be trivial to write a test for this [09:18:38] more or less a copy-paset of the statement_string.feature [09:18:54] with an additional check for the url [09:20:22] (03Merged) 10jenkins-bot: $.wikibase.entitysearch: Confine minimum width [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169324 (owner: 10Henning Snater) [09:23:58] (03PS13) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) [09:24:09] (03CR) 10Daniel Kinzler: [C: 032] Add getLanguageAwareRendererFromCode to PropertyClaimsRendererFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148672 (owner: 10Aude) [09:24:59] (03CR) 10Daniel Kinzler: [C: 032] Add more in-process caching for property parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171007 (owner: 10Aude) [09:26:28] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [09:26:46] (03CR) 10Daniel Kinzler: "hm... it's an improvement, but if it's undone in a follow-up, how show we go about getting the entire chain merged? I coudl approve this, " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [09:28:08] (03CR) 10Adrian Lang: "Packagist still has the old versions cached." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [09:33:41] (03CR) 10Daniel Kinzler: [C: 031] "Seems fine to me. Nearly +2, would like some more feedback, and need to look at follow-ups." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [09:34:42] (03CR) 10Daniel Kinzler: [C: 032] Add @todo in LanguageAwareRenderer regarding PropertyId resolving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149004 (owner: 10Aude) [09:38:32] (03CR) 10Daniel Kinzler: [C: 031] "Still not sure what a "runner" is supposed to be in this context..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171008 (owner: 10Aude) [09:39:46] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/171220 [09:41:03] (03CR) 10Daniel Kinzler: [C: 04-1] Check if property exists in PropertyIdResolver (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [09:49:54] [13ValueView] 15snaterlicious created 06oomenucustomitem (+1 new commit): 02http://git.io/b8JqtQ [09:49:54] 13ValueView/06oomenucustomitem 14c3b9d90 15snaterlicious: $.ui.ooMenu.CustomItem: Added setters... [09:50:36] [13ValueView] 15snaterlicious opened pull request #127: $.ui.ooMenu.CustomItem: Added setters (06master...06oomenucustomitem) 02http://git.io/SwmFEw [09:57:55] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/1CshLQ [09:57:55] 13WikibaseDataModelJavaScript/06master 14b39074d 15snaterlicious: Using DataValues JavaScript 0.6.0 [09:59:26] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/f89Jgw [09:59:26] 13WikibaseDataModelJavaScript/06master 143df772e 15snaterlicious: Update README.md [09:59:52] [13WikibaseDataModelJavaScript] 15snaterlicious tagged 061.0.1 at 06master: 02http://git.io/TOqdeg [10:06:22] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/O_vwDQ [10:06:22] 13WikibaseSerializationJavaScript/06master 147b683c0 15snaterlicious: Fixed data-mode-javascript require [10:07:28] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/DeFdMQ [10:07:28] 13WikibaseSerializationJavaScript/06master 14aa973b1 15snaterlicious: Update README.md [10:07:51] [13WikibaseSerializationJavaScript] 15snaterlicious tagged 062.0.1 at 06master: 02http://git.io/tpHmVA [10:24:56] (03PS1) 10Henning Snater: Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 [10:25:04] (03CR) 10jenkins-bot: [V: 04-1] Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 (owner: 10Henning Snater) [10:27:19] (03PS2) 10Henning Snater: Added suggestions placeholder to $.wikibase.entitysearch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171226 [10:27:56] 3MediaWiki extensions / 3WikidataRepo: fix the issue of people not seeing the suggestion in the main search box - 10https://bugzilla.wikimedia.org/53476#c15 (10Henning) 5REOP>3PATC https://gerrit.wikimedia.org/r/#/c/171226/ [10:33:36] [13ValueView] 15thiemowmde comment on pull request #127 14c3b9d90: So `null` is visible? Makes sense, just asking to be sure. 02http://git.io/JCQSCA [10:34:54] [13ValueView] 15thiemowmde 04deleted 06oomenucustomitem at 14c3b9d90: 02http://git.io/-PeFXA [10:39:55] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #136 146d2de3a: I hope the `exists` bit (feature detection) is a temporary solution. 02https://github.com/wmde/WikibaseQueryEngine/pull/136#discussion_r19865419 [10:45:20] (03PS2) 10Daniel Kinzler: Extract change coalescing logic from ChangeHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 [10:46:05] (03CR) 10Aude: Check if property exists in PropertyIdResolver (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [10:46:29] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #136 146d2de3a: Getting rid of one of these "Claim" wrappers, yea! :-) 02http://git.io/8UnR5A [10:46:42] (03CR) 10Aude: "do you have a better suggestion? i can't think of one" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171008 (owner: 10Aude) [10:47:08] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #136 146d2de3a: Why no `instanceof`? Just asking, I don't think I have a preference. 02http://git.io/Pn_TOw [10:47:56] (03CR) 10Aude: "i could try to rebase (or squash stuff), but think it's better just to stick with what's in the chain" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [10:51:11] 3MediaWiki extensions / 3WikidataRepo: description edit button is misaligned - 10https://bugzilla.wikimedia.org/72375#c4 (10Henning) Checking the version that should be deployed on beta, it seems updating of the css was/is being missed somehow. Although the version that should be deployed contains the curren... [11:09:40] 3MediaWiki extensions / 3WikidataRepo: Batch term-lookups - 10https://bugzilla.wikimedia.org/72627#c1 (10Daniel Kinzler) Clarification: this refers to using a batched lookup of labels in EntityView. [11:09:41] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c14 (10Andre Klapper) Questions are asked when something is unclear, for example steps to reproduce, expected outcome, actual outcome. [11:11:26] 3MediaWiki extensions / 3WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - 10https://bugzilla.wikimedia.org/62724#c2 (10Daniel Kinzler) *** Bug 72627 has been marked as a duplicate of this bug. *** [11:11:26] 3MediaWiki extensions / 3WikidataRepo: Batch term-lookups - 10https://bugzilla.wikimedia.org/72627#c2 (10Daniel Kinzler) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 62724 *** [11:12:47] Tobi_WMDE_SW: --^ [11:12:55] 3MediaWiki extensions / 3WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - 10https://bugzilla.wikimedia.org/62724#c3 (10Daniel Kinzler) 5PATC>3ASSI Picked this up instead of the dupe, bug 72627. [11:14:34] (03PS1) 10Adrian Lang: Better error reporting for invalid site link page ids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 [11:17:29] (03CR) 10Adrian Lang: [C: 04-1] "Is there a bug report asking for this? Sounds quite strange to me to remove controls just because they are empty." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 (owner: 10Henning Snater) [11:19:17] (03CR) 10jenkins-bot: [V: 04-1] Better error reporting for invalid site link page ids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 (owner: 10Adrian Lang) [11:20:19] (03CR) 10Adrian Lang: "From my recent experiences with statementview/claimview, I suppose this is going to be problematic. How does this behave with pressing esc" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) (owner: 10Henning Snater) [11:20:55] 3MediaWiki extensions / 3WikidataRepo: snakview.variations.Value.draw() does not specify dropValue parameter of jQuery.valueview.stopEditing() - 10https://bugzilla.wikimedia.org/70337 (10Adrian Lang) [11:21:09] 3MediaWiki extensions / 3WikidataRepo: Unify view-implementations in JS frontend - 10https://bugzilla.wikimedia.org/72666 (10Adrian Lang) [11:21:49] (03PS2) 10Daniel Kinzler: Determin update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 [11:23:03] (03CR) 10Henning Snater: "Allows smooth interaction in regards to https://gerrit.wikimedia.org/r/#/c/168293/." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 (owner: 10Henning Snater) [11:23:10] (03CR) 10Adrian Lang: "This does not fix Bug 72622, but just works around it, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [11:24:13] (03PS3) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 [11:24:34] Tobi_WMDE_SW: i am making a new deployment branch that is same as the old one, except the patch that changes our template namespace in js [11:24:39] just fyi [11:27:25] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf7/bd11aff : Henning Snater The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/40050126 [11:27:35] (03PS1) 10Aude: Renamed template function name [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171234 [11:29:54] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c15 (10Lydia Pintscher) Let's take it easy folks. No need to be upset :) I will talk the bug through with Thiemo tomorrow. I think I know what's going on. [11:31:47] DanielK_WMDE: ok. thx! [11:32:26] nothing interesting in the error logs... no issues reported on project chat or contact the development team page [11:32:31] :) [11:32:49] (03CR) 10jenkins-bot: [V: 04-1] Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (owner: 10Daniel Kinzler) [11:34:10] (03CR) 10jenkins-bot: [V: 04-1] Renamed template function name [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171234 (owner: 10Aude) [11:34:16] aaaat [11:34:17] h [11:34:31] (03CR) 10Henning Snater: "I regard that being a fix since the value is not overwritten anymore. There is no way to suppress the "selected" event because that is wha" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [11:35:12] (03PS1) 10Aude: Provide config when constructing WikiImporter in RepoHooksTest [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171235 [11:35:51] (03PS3) 10Adrian Lang: Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [11:38:36] (03PS3) 10Henning Snater: Added snakview.variations.Value.start/stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) [11:41:25] (03PS2) 10Adrian Lang: Better error reporting for invalid site link page ids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 [11:44:40] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c16 (10tobias.gritschacher) The patch from https://github.com/DataValues/Geo/pull/19 is contained in the 1.1.0 version of data-values/geo. We are not using this version in Wikibase yet. So this cannot b... [11:50:08] (03CR) 10Adrian Lang: [V: 04-1] "Does not change anything for me :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [11:50:58] (03PS14) 10Tobias Gritschacher: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [11:51:13] Adrian_WMDE: did you see my comment in https://gerrit.wikimedia.org/r/#/c/167782/ [11:51:31] can anyone else confirm the issue? [11:51:44] * aude has authority control gadget so maybe that somehow interferes [11:51:45] aude: I read that, yes [11:51:51] ok [11:52:06] This is the kind of failures we expected, so I wouldn't doubt your setup too much [11:52:16] (03PS4) 10Henning Snater: Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) [11:52:18] ok [11:53:38] it gets treated as a wikilink , linking to page on my wiki with that value [11:54:02] (03CR) 10Adrian Lang: "I don't get the idea, but maybe this makes sense in a specific ui context." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 (owner: 10Henning Snater) [11:55:08] aude: Adrian_WMDE can confirm [11:55:14] ok [11:55:15] I can confirm [12:00:23] (03CR) 10Adrian Lang: [C: 032] "Doesn't look nice, but at least maintains usability in all cases. So, if this is fine with design and product management …" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170020 (https://bugzilla.wikimedia.org/72755) (owner: 10Henning Snater) [12:02:58] (03CR) 10Adrian Lang: Use back-end parser for "commons" and "url" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169672 (https://bugzilla.wikimedia.org/62193) (owner: 10Henning Snater) [12:05:49] (03Merged) 10jenkins-bot: Initialize copyright tooltip on toolbar container [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170020 (https://bugzilla.wikimedia.org/72755) (owner: 10Henning Snater) [12:13:19] (03PS1) 10Henning Snater: $.wikibase.entityselector: Added "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171239 [12:14:28] (03PS5) 10Henning Snater: Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) [12:15:55] (03CR) 10Henning Snater: "Added missing change as dependency to this change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [12:19:43] aaaaaah, whenever i see // --------------------------------------------------------------------- in the code [12:20:36] (03CR) 10Adrian Lang: [C: 04-1] $.wikibase.entityselector: Added "caseInsensitive" option (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171239 (owner: 10Henning Snater) [12:20:46] aude: ack [12:22:07] (03PS1) 10Adrian Lang: Remove outdated comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171241 [12:22:15] (03CR) 10Aude: [C: 032] Provide config when constructing WikiImporter in RepoHooksTest [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171235 (owner: 10Aude) [12:23:26] JeroenDeDauw: Where should I start? There's a lot of places where Entity is used. And there are places, like the API, where things are called Entity, but if the Entity is not an Item, it throws. [12:28:15] (03PS3) 10Adrian Lang: Remove wb.RepoApi.{get,post} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 [12:28:31] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 (owner: 10Adrian Lang) [12:29:08] (03PS7) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [12:35:20] (03Merged) 10jenkins-bot: Provide config when constructing WikiImporter in RepoHooksTest [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171235 (owner: 10Aude) [12:37:08] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf7/590a8f5 : Tobias Gritschacher The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/40055101 [12:44:45] (03PS2) 10Aude: Renamed template function name [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171234 [12:45:01] (03CR) 10Mwjames: "Just get rid of the notice in the WikiImporter then you don't have to pull a dependency of the Config class (which somewhat silly) because" [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171235 (owner: 10Aude) [13:00:54] (03CR) 10Aude: [C: 032] Renamed template function name [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171234 (owner: 10Aude) [13:02:48] (03PS6) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 [13:03:11] (03PS1) 10Adrian Lang: Merge commit 'd8243d81c716b462b7e79e6b67af50201921b7e7' into HEAD [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171246 [13:03:13] (03PS1) 10Adrian Lang: Remove unnecessary message from RepoApiError [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171247 [13:03:26] (03PS4) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 [13:03:38] (03CR) 10Adrian Lang: [C: 04-2] "Never merge." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171246 (owner: 10Adrian Lang) [13:04:40] (03PS1) 10Henning Snater: Moved snakview event handlers to statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171248 [13:05:11] (03PS2) 10Henning Snater: (hotfix) Moved snakview event handlers to statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171248 [13:08:40] (03PS2) 10Tobias Gritschacher: New Wikidata Build - 2014/11/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/171220 [13:13:08] (03PS2) 10Henning Snater: $.wikibase.entityselector: Added "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171239 [13:16:36] (03CR) 10Daniel Kinzler: [C: 04-1] "minor issues" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 (owner: 10Adrian Lang) [13:17:41] 3MediaWiki extensions / 3WikidataRepo: Adapt notifications to work with floating toolbars - 10https://bugzilla.wikimedia.org/72755 (10Henning) 5PATC>3RESO/FIX [13:18:17] (03Merged) 10jenkins-bot: Renamed template function name [extensions/Wikibase] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171234 (owner: 10Aude) [13:22:27] (03CR) 10Daniel Kinzler: "I'd probably take ParserFunctionRegistrant and the Runner thingy and combine them into a hook handler class, following the pattern of Side" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171008 (owner: 10Aude) [13:23:55] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c4 (10Adrian Lang) From my point of view, the module could look like the following: wikibase.api = { __namespace FormatValueCaller getLocationAgnosticMwApi ParseValueCaller... [13:24:11] (03PS1) 10Tobias Gritschacher: Require 1.x version of data-values/geo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171249 [13:24:29] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/11/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/171220 (owner: 10Tobias Gritschacher) [13:24:31] (03PS1) 10Adrian Lang: Fix comment in ApiErrorReporter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171250 [13:24:41] (03CR) 10Tobias Gritschacher: [V: 032] New Wikidata Build - 2014/11/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/171220 (owner: 10Tobias Gritschacher) [13:25:02] (03PS1) 10Adrian Lang: Remove unused resource dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171251 [13:25:12] (03CR) 10Adrian Lang: [C: 032] (hotfix) Moved snakview event handlers to statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171248 (owner: 10Henning Snater) [13:25:22] (03CR) 10Daniel Kinzler: [C: 032] Move property id resolving code for parser function into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [13:27:11] (03CR) 10Tobias Gritschacher: [C: 04-1] "we should require version 1.x / 2.x of the components." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [13:31:46] (03PS3) 10Tobias Gritschacher: Added removeError() to fingerprintgroupview and sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170293 (owner: 10Henning Snater) [13:32:24] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c5 (10Henning) I would not go for message dependencies across module borders--I would opt for duplicating the message. Will there ever be something like wikibase.api.ClientApi and a... [13:32:47] (03CR) 10Tobias Gritschacher: [C: 032] Added removeError() to fingerprintgroupview and sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170293 (owner: 10Henning Snater) [13:33:06] (03PS4) 10Tobias Gritschacher: fingerprintgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170294 (https://bugzilla.wikimedia.org/72311) (owner: 10Henning Snater) [13:36:50] (03PS3) 10Adrian Lang: Better error reporting for invalid site link page ids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 [13:36:59] (03CR) 10Adrian Lang: Better error reporting for invalid site link page ids (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 (owner: 10Adrian Lang) [13:40:05] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/ZHgUEg [13:40:05] 13WikibaseQueryEngine/06master 1440f1724 15thiemowmde: Merge pull request #136 from wmde/fold... [13:40:40] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c6 (10Adrian Lang) I thought the "Repo" would refer to the fact that it works on the API of the Repo. [13:42:08] (03PS15) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) [13:42:40] (03CR) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [13:43:56] (03PS24) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [13:49:20] (03Merged) 10jenkins-bot: (hotfix) Moved snakview event handlers to statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171248 (owner: 10Henning Snater) [13:49:23] (03Merged) 10jenkins-bot: Move property id resolving code for parser function into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [13:51:09] (03Merged) 10jenkins-bot: Rename Renderer interface to PropertyClaimsRenderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [13:53:31] (03PS4) 10Henning Snater: Added snakview.variations.Value.start/stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) [13:53:50] (03PS25) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [13:54:06] (03CR) 10Henning Snater: [V: 031] "Verified key-press/click behaviour manually." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) (owner: 10Henning Snater) [13:59:36] (03CR) 10Aude: Replacing ItemUsageIndex with UsageLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:00:30] (03CR) 10Aude: "appears to work if i don't touch the setting (e.g. use the default) and change site links." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:00:55] (03Merged) 10jenkins-bot: Add getLanguageAwareRendererFromCode to PropertyClaimsRendererFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148672 (owner: 10Aude) [14:03:52] (03CR) 10JanZerebecki: [C: 032] Require 1.x version of data-values/geo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171249 (owner: 10Tobias Gritschacher) [14:05:33] (03PS1) 10Adrian Lang: Replace invalid type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171256 [14:05:35] (03PS1) 10Adrian Lang: Improve no-such-sitelink message, use it for error.info [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171257 [14:10:07] (03PS26) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [14:11:40] (03PS1) 10Henning Snater: Removed key handling from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171258 [14:11:42] (03Merged) 10jenkins-bot: Move PropertyIdResolver to DataAccess namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149002 (owner: 10Aude) [14:12:21] (03Merged) 10jenkins-bot: Add @todo in LanguageAwareRenderer regarding PropertyId resolving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149004 (owner: 10Aude) [14:12:38] (03Merged) 10jenkins-bot: Add more in-process caching for property parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171007 (owner: 10Aude) [14:13:02] (03PS2) 10Henning Snater: Removed key handling from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171258 [14:15:03] (03CR) 10Aude: [C: 032] "looks ready to merge :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:17:56] 3MediaWiki extensions / 3WikidataRepo: jQuery.wikibase.***view widgets should not switch between edit modes on their own - 10https://bugzilla.wikimedia.org/54021#c6 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/171258/ This seems to be the only (or last) place key handling was done in some *... [14:18:37] (03Merged) 10jenkins-bot: Added removeError() to fingerprintgroupview and sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170293 (owner: 10Henning Snater) [14:26:32] (03CR) 10Adrian Lang: [C: 032] $.wikibase.entityselector: Added "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171239 (owner: 10Henning Snater) [14:27:43] (03CR) 10Adrian Lang: [C: 032] Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [14:28:02] (03CR) 10Aude: [C: 04-1] "seems okay now." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [14:28:52] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf7/3173fd2 : Henning Snater The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/40058842 [14:31:12] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c7 (10Jeroen De Dauw) > * wikibase // For the namespace Where is that defined? If in wb.git, then we'll have a circular dependency no? > I would not go for message dependencies ac... [14:31:13] (03CR) 10Adrian Lang: [C: 032] Added snakview.variations.Value.start/stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) (owner: 10Henning Snater) [14:32:04] (03Merged) 10jenkins-bot: Require 1.x version of data-values/geo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171249 (owner: 10Tobias Gritschacher) [14:34:40] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c8 (10Adrian Lang) Yes, right now we have circular dependencies with all our Wikibase JS components, because ›wikibase‹ is not just a namespace right now and can't be created on dem... [14:35:03] (03Merged) 10jenkins-bot: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:35:05] (03CR) 10Aude: Inject ReferencedPageFinder into ChangeHandler (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162837 (owner: 10Daniel Kinzler) [14:35:29] (03Merged) 10jenkins-bot: $.wikibase.entityselector: Added "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171239 (owner: 10Henning Snater) [14:36:44] (03CR) 10Adrian Lang: [C: 032] "My comment was wrong, this code is alright as it is." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169672 (https://bugzilla.wikimedia.org/62193) (owner: 10Henning Snater) [14:37:02] (03PS1) 10Aude: Update Wikidata, fix conflict in mw.templates [extensions/Wikidata] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171262 [14:39:57] (03Merged) 10jenkins-bot: Added snakview.variations.Value.start/stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) (owner: 10Henning Snater) [14:40:56] (03CR) 10Aude: [C: 032] "the cache key and such doesn't need to change" [extensions/Wikidata] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171262 (owner: 10Aude) [14:41:10] 3MediaWiki extensions / 3WikidataRepo: snakview.variations.Value.draw() does not specify dropValue parameter of jQuery.valueview.stopEditing() - 10https://bugzilla.wikimedia.org/70337 (10Henning) 5PATC>3RESO/FIX [14:41:36] (03PS6) 10Henning Snater: Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) [14:42:13] (03Merged) 10jenkins-bot: Use back-end parser for "commons" and "url" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169672 (https://bugzilla.wikimedia.org/62193) (owner: 10Henning Snater) [14:42:56] (03Merged) 10jenkins-bot: Update Wikidata, fix conflict in mw.templates [extensions/Wikidata] (wmf/1.25wmf7) - 10https://gerrit.wikimedia.org/r/171262 (owner: 10Aude) [14:43:55] 3MediaWiki extensions / 3WikidataRepo: Use backend parser for commons - 10https://bugzilla.wikimedia.org/62193 (10Henning) 5PATC>3RESO/FIX [14:44:10] 3MediaWiki extensions / 3WikidataRepo: Use backend parser for URL - 10https://bugzilla.wikimedia.org/62192 (10Henning) 5PATC>3RESO/FIX [14:45:40] 3MediaWiki extensions / 3WikidataRepo: Getting rid of direct API calls from within jQuery.wikibase.***view widgets - 10https://bugzilla.wikimedia.org/56246 (10Adrian Lang) 5PATC>3RESO/FIX [14:45:46] (03CR) 10Adrian Lang: [C: 032] Removed key handling from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171258 (owner: 10Henning Snater) [14:48:25] 3MediaWiki extensions / 3WikidataRepo: Move repo-specific JS code from lib to repo - 10https://bugzilla.wikimedia.org/66417 (10Adrian Lang) [14:48:28] 3MediaWiki extensions / 3WikidataRepo: Move JS and PHP view code to separate repo - 10https://bugzilla.wikimedia.org/73020 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs This should include templates, everything using wfTemplate and all jquery.wikibase widgets from lib/. [14:52:19] (03PS15) 10Aude: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [14:52:25] (03Merged) 10jenkins-bot: Removed key handling from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171258 (owner: 10Henning Snater) [14:52:46] (03CR) 10Aude: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [14:54:40] 3MediaWiki extensions / 3WikidataRepo: jQuery.wikibase.***view widgets should not switch between edit modes on their own - 10https://bugzilla.wikimedia.org/54021 (10Henning) 5PATC>3RESO/FIX [15:05:17] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #136 146d2de3a: I did this to avoid binding to the class names. You can now use a different implementation of item if you want, and stuff will not break if the classes where to be moved. Those are very minor points, and I basically mainly want to get an idea of how this will actually hold up in the future. I don't expect any real difference compared to the instanceof approach. 02 [15:06:21] [13WikibaseDataModelJavaScript] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/6lO4xw [15:06:21] 13WikibaseDataModelJavaScript/06master 14d40a02d 15Jeroen De Dauw: Update README.md [15:07:27] (03CR) 10Aude: Introduce EntityParserOutputGeneratorFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [15:07:30] [13WikibaseSerializationJavaScript] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/z-NqyA [15:07:30] 13WikibaseSerializationJavaScript/06master 14c290740 15Jeroen De Dauw: Fixing a grammar [15:08:36] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06propertynotfound at 14b667320: 02http://git.io/1Z2r-g [15:12:10] it's a JeroenDeDauw [15:12:19] you're invisible? [15:17:28] (03CR) 10Daniel Kinzler: Inject ReferencedPageFinder into ChangeHandler (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162837 (owner: 10Daniel Kinzler) [15:17:46] Thiemo_WMDE: review plz? https://gerrit.wikimedia.org/r/#/c/162837/ and follow-ups [15:20:21] aude: Henning_WMDE: it seems we broke AuthorityControl gadget: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-SmokeTests-linux-firefox-sauce/41/testReport/ [15:20:34] how? [15:20:35] http://wikidata.beta.wmflabs.org/wiki/Q12480?debug=true [15:21:03] aude: not sure.. probably the claimview/statementview changes? [15:21:08] * aude has authority control and found an issue with the statementview patch that i told adrian [15:21:14] wasn't sure if they were related though [15:21:22] aude: see http://wikidata.beta.wmflabs.org/wiki/Q12480?debug=true [15:21:27] ok [15:22:21] the problem is, it seems the error breaks all of the JS on the page [15:22:30] so not only the gadget [15:22:38] or there is something else [15:23:52] Tobi_WMDE_SW: well that looks like a different issue [15:24:19] Tobi_WMDE_SW: yeah, of course [15:24:52] (03PS27) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [15:25:49] (03CR) 10Daniel Kinzler: Record usage info from ParserOutput to the database. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [15:26:51] Tobi_WMDE_SW: if i try to add a statement on http://wikidata.beta.wmflabs.org/wiki/Q790 [15:26:54] already purged [15:27:13] http://snag.gy/tLSBm.jpg [15:27:45] lots of statements http://snag.gy/Mlqq7.jpg [15:27:53] idk if the css is the issue [15:29:43] (03CR) 10Aude: [C: 04-1] "restore due to to previous comments, still not addressed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [15:40:13] aude: fix for the gadget: http://wikidata.beta.wmflabs.org/w/index.php?title=MediaWiki%3AGadget-AuthorityControl.js&diff=65516&oldid=63535 [15:40:36] Tobi_WMDE_SW: ok [15:41:31] Tobi_WMDE_SW: https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js [15:41:56] just add a message there and use {{editprotected}} [15:42:03] template and link to the diff on beta [15:43:23] aude: ? [15:43:29] should I do this? [15:43:34] sure [15:50:34] (03CR) 10Aude: [C: 032] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [15:52:05] aude: https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#Fix_for_upcoming_breakage [15:52:10] hope that's correct [15:52:44] * aude trusts you :) [15:53:15] just {{editprotected}} (i fixed) [15:53:25] {{tl|editprotected}} is for when the request is done [15:53:38] template puts it in https://www.wikidata.org/wiki/Category:Wikidata_protected_edit_requests [15:55:32] (03CR) 10Daniel Kinzler: "meh" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [15:55:59] (03Merged) 10jenkins-bot: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [15:56:26] 3MediaWiki extensions / 3WikidataClient: Proposal transform the "Close dialog and reload page" dialog to notification bar - 10https://bugzilla.wikimedia.org/59156#c7 (10Henning) Just wondering whether it would actually be a hassle to just asynchronously regenerate the list of interlanguage links? They all se... [16:06:46] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #136 146d2de3a: Makes sense. Thanks. 02http://git.io/b5jDvA [16:09:19] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove PropertyNotFoundExceptionTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171196 (owner: 10Aude) [16:14:53] (03Merged) 10jenkins-bot: Remove PropertyNotFoundExceptionTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171196 (owner: 10Aude) [16:17:09] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/170294/ [16:23:59] (03PS5) 10Henning Snater: fingerprintgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170294 (https://bugzilla.wikimedia.org/72311) [16:26:41] (03CR) 10Aude: Introduce EntityParserOutputGeneratorFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [16:28:55] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 141c98b17: I'm open to alternative suggestions.... 02http://git.io/CvYGQA [16:37:59] [13Geo] 15tobijat comment on pull request #28 148b341e3: >>The {0} syntax is deprecated in PHP 6.... 02http://git.io/FNlnHg [16:41:20] (03CR) 10Tobias Gritschacher: "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168833 (owner: 10Aude) [16:41:48] oh noes [16:42:49] appears obsolete [16:47:24] (03Abandoned) 10Aude: Use Title::quickUserCan in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168833 (owner: 10Aude) [16:47:46] (03CR) 10Aude: "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168840 (owner: 10Aude) [16:48:34] [13Geo] 15JeroenDeDauw comment on pull request #28 148b341e3: lolwat... I had no idea you could do `$str[$int]` 02http://git.io/LfVVCw [16:49:14] [13Geo] 15JeroenDeDauw closed pull request #28: Replace deprecated character access syntax (06master...06charAt) 02http://git.io/mTPxOA [16:59:41] (03CR) 10Aude: [C: 032] Remove outdated comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171241 (owner: 10Adrian Lang) [17:06:41] (03Merged) 10jenkins-bot: Remove outdated comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171241 (owner: 10Adrian Lang) [17:08:06] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 141c98b17: > Yes either we need to change all places [ ... ] or add an option ::ALLOW_INFERRED [ ... ]... 02http://git.io/MmTc_Q [17:15:03] !nyan [17:15:03] ~=[,,_,,]:3 [17:15:09] aude is obsolete? [17:59:37] aude: Are you bumping this week? :) [17:59:59] Reedy: yes [18:00:18] cool [18:00:21] it only actually contains compatiblity changes for mediawiki core [18:00:26] not branching yet, just doing some enquiries [18:00:30] ok [18:15:55] (03CR) 10Daniel Kinzler: [C: 032] Better error reporting for invalid site link page ids (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 (owner: 10Adrian Lang) [18:16:56] (03CR) 10Daniel Kinzler: [C: 032] Replace invalid type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171256 (owner: 10Adrian Lang) [18:17:39] (03CR) 10Daniel Kinzler: [C: 032] Improve no-such-sitelink message, use it for error.info [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171257 (owner: 10Adrian Lang) [18:26:21] (03Merged) 10jenkins-bot: Better error reporting for invalid site link page ids [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171232 (owner: 10Adrian Lang) [18:26:23] (03Merged) 10jenkins-bot: Replace invalid type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171256 (owner: 10Adrian Lang) [18:26:25] (03Merged) 10jenkins-bot: Improve no-such-sitelink message, use it for error.info [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171257 (owner: 10Adrian Lang) [19:12:12] aude: In the meantime, I just killed the on disk cache that make-wmf-branch uses [19:12:26] Not sure if/how much it'll help [19:19:21] Reedy: probably not since the make-wmf-branch script also generates the special version info [20:33:59] is there someone understanding russian or japanese please? [20:39:53] no one? [20:52:04] Harmonia_Amanda: pretty late there... [20:52:41] ah, yes, I'm in France, it's only 21:52 pm... [20:52:48] I'll try tomorrow [21:07:40] DanielK_WMDE_: Any more concerns about https://gerrit.wikimedia.org/r/170528 ? [21:07:55] Would be nice to get htat merged/ into a mergeable state in the next few days [21:36:24] hoo|away: poke me tomorrow... [21:39:59] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 141c98b17: > > Yes either we need to change all places [ ... ] or add an option ::ALLOW_INFERRED [ ... ]... 02http://git.io/vSSiNg [22:09:43] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 141c98b17: > This would require for the deserializer to be able to know if it may construct inferred objects.... 02http://git.io/4l98zQ [22:11:57] DanielK_WMDE_: Ok, I'll be working tomorrow anyway, probably [22:12:16] as I wont be able to (physically) make it to university... -.- [22:16:48] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 141c98b17: Would you find adding bool isInferred() to Term and TermFallback to be an acceptable solution? Do you have better suggestions?... 02http://git.io/R-90-w [22:21:51] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 141c98b17: If the deserializer that you get from the factory can always create inferred objects, how would you prevent that? (E.g. when the serialized form comes in from the api.) 02http://git.io/JgNBMw [22:35:07] "evilMediaWikiBootstrap" is totally broken afais [22:35:13] does anything actually use it? [22:35:30] nope