[03:11:27] (o; [07:20:22] [13DataValuesJavascript] 15snaterlicious created 06jshinterrors (+1 new commit): 02http://git.io/-HM-EQ [07:20:22] 13DataValuesJavascript/06jshinterrors 14746d2ae 15snaterlicious: Fixed JSHint issues [07:20:32] [13DataValuesJavascript] 15snaterlicious opened pull request #52: Fixed JSHint issues (06master...06jshinterrors) 02http://git.io/MAsFyQ [08:27:25] [13WikibaseDataModel] 15snaterlicious created 06statementequals (+1 new commit): 02http://git.io/uVhnUA [08:27:25] 13WikibaseDataModel/06statementequals 1493e3ee7 15snaterlicious: Added rank comparison to Statement::equals... [08:31:34] [13WikibaseDataModel] 15snaterlicious opened pull request #269: Added rank comparison to Statement::equals (06master...06statementequals) 02http://git.io/W1wo2A [08:31:56] 3MediaWiki extensions / 3WikidataRepo: rank changes are not saved - 10https://bugzilla.wikimedia.org/71554#c3 (10Henning) 5NEW>3PATC https://github.com/wmde/WikibaseDataModel/pull/269 [08:45:11] 3MediaWiki extensions / 3WikidataRepo: rank changes are not saved - 10https://bugzilla.wikimedia.org/71554#c4 (10Aude) 5PATC>3RESO/FIX merged, though still need to tag data model. [09:28:12] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059 (10Thiemo Mättig) 5PATC>3RESO/FIX [09:31:54] Thiemo_WMDE: git show df457f38 includes/api/ApiMain.php [09:31:58] in core [09:33:13] And git show ae5cfdb1 [09:42:30] Adrian_WMDE: https://gerrit.wikimedia.org/r/#/c/160798/14/includes/api/ApiMain.php [10:09:57] [13WikidataBrowserTests] 15adrianlang closed pull request #20: Add tag to tests that test what is defined in local config.yml (06master...06local_config_tag) 02http://git.io/SmpM3w [10:11:38] [13WikidataBrowserTests] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/_6kjjg [10:11:38] 13WikidataBrowserTests/06master 14d68be64 15Adrian Lang: Fix travis [10:12:46] (03PS13) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [10:12:55] (03CR) 10jenkins-bot: [V: 04-1] Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [10:15:41] (03PS14) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [10:16:32] (03CR) 10Adrian Lang: "Statement creation fixed, browser tests pass for me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [10:20:26] (03CR) 10Tobias Gritschacher: [C: 032] Apply ValueView 0.8.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170706 (owner: 10Henning Snater) [10:20:29] (03PS4) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [10:20:31] (03PS9) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) [10:21:10] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [10:26:04] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [10:26:06] (03CR) 10jenkins-bot: [V: 04-1] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [10:29:09] (03Merged) 10jenkins-bot: Apply ValueView 0.8.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170706 (owner: 10Henning Snater) [10:36:00] (03CR) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [10:36:21] (03PS5) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [10:36:23] (03PS10) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) [10:41:13] (03CR) 10jenkins-bot: [V: 04-1] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [10:41:16] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [10:52:46] Adrian_WMDE: https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions&component=WikidataRepo [11:17:21] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/04 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170901 [11:28:35] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/11/04 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170901 (owner: 10Tobias Gritschacher) [11:29:26] 3MediaWiki extensions / 3WikidataRepo: Highlighting is completely missing - 10https://bugzilla.wikimedia.org/66433 (10tobias.gritschacher) 5PATC>3RESO/FIX [11:29:27] 3MediaWiki extensions / 3WikidataRepo: Suggester box to small - 10https://bugzilla.wikimedia.org/66435 (10tobias.gritschacher) 5PATC>3RESO/FIX [11:30:13] [13DataValuesJavascript] 15tobijat closed pull request #52: Fixed JSHint issues (06master...06jshinterrors) 02http://git.io/MAsFyQ [11:30:30] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/11/04 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170901 (owner: 10Tobias Gritschacher) [11:31:19] wmde/DataValuesJavascript/add_jshint/e57d70e : Tobias Gritschacher The build was broken. http://travis-ci.org/wmde/DataValuesJavascript/builds/39853266 [11:34:32] [13DataValuesJavascript] 15tobijat 04force-pushed 06add_jshint from 14e57d70e to 140e3a41c: 02http://git.io/q29CNA [11:34:32] 13DataValuesJavascript/06add_jshint 140e3a41c 15Tobias Gritschacher: Run jshint on TravisCI [11:35:39] wmde/DataValuesJavascript/add_jshint/0e3a41c : Tobias Gritschacher The build is still failing. http://travis-ci.org/wmde/DataValuesJavascript/builds/39935065 [11:52:53] [13DataValuesJavascript] 15tobijat 04force-pushed 06add_jshint from 140e3a41c to 140e5cd67: 02http://git.io/q29CNA [11:52:53] 13DataValuesJavascript/06add_jshint 140e5cd67 15Tobias Gritschacher: Run jshint on TravisCI [11:52:57] 3MediaWiki extensions / 3WikidataRepo: Make parse errors in wbparsevalue have the same structure as normal api errors - 10https://bugzilla.wikimedia.org/72947 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs wbparsevalue returns an array of results, each possibly representing an error. The f... [11:53:56] Henning_WMDE: can be merged now: https://github.com/wmde/DataValuesJavascript/pull/51 [11:54:12] will add it to the other js repos as well [11:55:31] <6A4AAC4WL> [13DataValuesJavascript] 15snaterlicious closed pull request #51: Run jshint on TravisCI (06master...06add_jshint) 02http://git.io/dErLGA [11:55:31] <1JTAAVVSF> [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/P3PpCQ [11:55:31] <1JTAAVVSF> 13DataValuesJavascript/06master 14756de0b 15snaterlicious: Merge pull request #51 from wmde/add_jshint... [11:55:36] [13DataValuesJavascript] 15snaterlicious 04deleted 06add_jshint at 140e5cd67: 02http://git.io/hSpOBg [11:55:58] Tobi_WMDE_SW: https://github.com/wmde/DataValuesJavascript/pull/50 [11:56:35] Henning_WMDE: ah, yeah, will have a look [11:56:41] JeroenDeDauw: Which is the code I'm supposed to be auditing for bad Entity assumptions? [11:59:07] (03PS2) 10Adrian Lang: Clean up API-based parsing code in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170068 [11:59:09] (03PS3) 10Adrian Lang: Move datavalue parsing to ApiBasedValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170069 [11:59:32] (03PS1) 10Thiemo Mättig (WMDE): Refactor UrlSchemeValidators and allow more schemes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 [11:59:45] (03CR) 10jenkins-bot: [V: 04-1] Refactor UrlSchemeValidators and allow more schemes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 (owner: 10Thiemo Mättig (WMDE)) [12:00:14] (03CR) 10Adrian Lang: "ParseValueCaller now rejects with Errors, mostly RepoApiErrors. I also moved the documentation about API errors to RepoApiError." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170068 (owner: 10Adrian Lang) [12:01:44] [13ValueView] 15tobijat created 06add_travis (+1 new commit): 02http://git.io/1hmazg [12:01:44] 13ValueView/06add_travis 145fb2034 15Tobias Gritschacher: Run JSHint on TravisCI [12:02:00] [13ValueView] 15tobijat opened pull request #124: Run JSHint on TravisCI (06master...06add_travis) 02http://git.io/N2P8qg [12:02:05] (03PS2) 10Thiemo Mättig (WMDE): Refactor UrlSchemeValidators and allow more schemes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 (https://bugzilla.wikimedia.org/72924) [12:02:19] wmde/ValueView/add_travis/5fb2034 : Tobias Gritschacher The build failed. http://travis-ci.org/wmde/ValueView/builds/39936639 [12:03:05] (03CR) 10Adrian Lang: "Henning, Thiemo: Can we make the releases?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [12:04:10] [13ValueView] 15tobijat 04force-pushed 06add_travis from 145fb2034 to 14f6ad960: 02http://git.io/_80bWQ [12:04:10] 13ValueView/06add_travis 14f6ad960 15Tobias Gritschacher: Run JSHint on TravisCI [12:05:42] wmde/ValueView/add_travis/f6ad960 : Tobias Gritschacher The build is still failing. http://travis-ci.org/wmde/ValueView/builds/39936936 [12:06:02] Henning_WMDE: https://github.com/wmde/ValueView/pull/124 [12:06:06] DanielK_WMDE: https://gerrit.wikimedia.org/r/168276/ bump [12:06:16] (03CR) 10Aude: "yay for improving this! :) one nitpick comment" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 (https://bugzilla.wikimedia.org/72924) (owner: 10Thiemo Mättig (WMDE)) [12:08:08] [13DataValuesJavascript] 15tobijat 04deleted 06phantomtestrunner at 148bd6130: 02http://git.io/Q8R_7A [12:09:23] Tobi_WMDE_SW: Will have a look at the JSHint issues in ValueView. [12:14:26] 3MediaWiki extensions / 3WikidataRepo: Test coverage of JavaScript QUnit tests - 10https://bugzilla.wikimedia.org/40656#c3 (10Adrian Lang) blanket.js does not easily work with ResourceLoader. CompletenessTest is quite ugly, but I guess we have to work with that. [12:14:51] * aude love test.wikidata.... [12:14:54] Warning: You are naughty ;) [12:14:58] so i am told [12:17:04] Tobi_WMDE_SW_NA: Could we take https://bugzilla.wikimedia.org/show_bug.cgi?id=72184 into the sprint? [12:18:23] Adrian_WMDE: Henning_WMDE is there anything in https://gerrit.wikimedia.org/r/#/c/169668/ (what we are deploying) that you think requires clearing the parser cache? [12:18:38] * aude thinks test.wikidata has been fine without doing so [12:18:49] so not needed [12:20:15] aude: getLoadingSpinnerInlineScript in https://gerrit.wikimedia.org/r/#/c/169668/1/extensions/Wikibase/repo/includes/EntityView.php,cm might be an issue [12:20:42] what does that do? or what might happen? [12:21:04] just when loading the page? [12:21:10] I have no idea [12:21:18] https://gerrit.wikimedia.org/r/#/c/169668/1/extensions/Wikibase/repo/includes/View/ClaimsView.php,cm should definitely need a purge, [12:21:22] Henning_WMDE: right? [12:21:28] hmmm, ok :/ [12:22:18] all the items on test.wikidata seem small enough that i don't see the spinner [12:23:15] Looks like it should be purged... https://gerrit.wikimedia.org/r/#/c/169668/1/extensions/Wikibase/repo/includes/View/SectionEditLinkGenerator.php [12:23:23] ok [12:23:50] * aude doesn't want this to be a habit except suppose when redesign stuff is happening [12:24:17] e.g. would not be an option to do on wikipedia [12:28:24] Adrian_WMDE: if there is nothing left in the sprint that you could do, feel free to start working on it. It should not block other people. Otherwise I've it on my list for next sprint already. [12:31:43] Tobi_WMDE_SW_NA: I don't know if I can do it, but I might learn it (would be fun) [12:32:04] Jan would do it, but it would take him away from other items, of course [12:33:32] [13ValueView] 15snaterlicious created 06jshinterrors (+1 new commit): 02http://git.io/sbZF9A [12:33:32] 13ValueView/06jshinterrors 14a4a19fd 15snaterlicious: Fixed JSHint errors [12:33:52] [13ValueView] 15snaterlicious opened pull request #125: Fixed JSHint errors (06master...06jshinterrors) 02http://git.io/2ex9Vg [13:01:06] [13WikibaseDataModel] 15filbertkm created 06statement-equals (+1 new commit): 02http://git.io/FLzslw [13:01:06] 13WikibaseDataModel/06statement-equals 14b13dad8 15aude: Add tests for Statement::equals [13:01:31] [13WikibaseDataModel] 15filbertkm opened pull request #270: Add tests for Statement::equals (06master...06statement-equals) 02http://git.io/AOf5fg [13:04:28] wmde/WikibaseDataModel/statement-equals/b13dad8 : aude The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39940689 [13:04:30] [13WikibaseDataModel] 15thiemowmde comment on pull request #270 14b13dad8: Did you missed the $message parameter here? 02http://git.io/Ab-thw [13:04:45] aaaah [13:06:19] [13WikibaseDataModel] 15filbertkm pushed 1 new commit to 06statement-equals: 02http://git.io/IcvNrw [13:06:19] 13WikibaseDataModel/06statement-equals 140818e2b 15aude: Fix $message param in Statement not equals test [13:06:51] [13WikibaseDataModel] 15thiemowmde comment on pull request #270 140818e2b: Looks so familiar. Did you copied my ItemTest::notEqualsProvider? Just wondering. 02http://git.io/pjsHZQ [13:07:28] (03PS6) 10Adrian Lang: Move property id resolving code for parser function into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [13:07:40] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [13:07:41] [13WikibaseDataModel] 15filbertkm comment on pull request #270 140818e2b: nope, did not see that. suppose there are only so many ways to do these tests ;) 02http://git.io/hRL4-w [13:10:19] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/xF1oDw [13:10:19] 13WikibaseDataModel/06master 14a4abc7b 15thiemowmde: Merge pull request #270 from wmde/statement-equals... [13:13:29] (03PS4) 10Adrian Lang: Rename Renderer interface to PropertyClaimsRenderer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [13:13:45] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [13:14:01] aaaah, all the ancient patches [13:14:01] [13WikibaseDataModel] 15thiemowmde comment on pull request #265 14c637664: So we will also add `newFromMainSnakAndQualifiers` as well as `newFromMainSnakQualifiersAndReferences`? That's what optional parameters are for. That's what constructors are for. Introducing more of these static method(s) means we will replace all `new Statement( ... )` calls with static `Statement::new...( ... )`. I don't see how this makes the overall situation better. 02 [13:14:29] * aude needs to rebase or resubmit on top of daniel's usage tracking stuff [13:19:53] aude: I'm doing that now [13:20:28] Adrian_WMDE: ok [13:20:33] do you want to actually work on it? [13:20:53] I think we should just rebase and merge them [13:21:13] From what I've seen comments are mostly nitpicks [13:21:25] maybe [13:21:31] i'd have to take a look again [13:22:10] these patches would be needed or otherwise conflict with injecting the snak formatter there [13:22:19] Rebasing is quite straightforward [13:22:21] which is needed for using the label lookup [13:22:26] good :) [13:22:45] Then we should get them in beforehands [13:22:57] !nyan [13:22:57] ~=[,,_,,]:3 [13:22:57] I mean, they don't get better over time :) [13:23:10] true [13:29:12] deployed! [13:29:22] (03PS3) 10Adrian Lang: Add getLanguageAwareRendererFromCode to PropertyClaimsRendererFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148672 (owner: 10Aude) [13:29:25] Wow [13:29:30] Let the bugs roll in [13:29:37] Henning_WMDE: Thiemo_WMDE do yoi think https://github.com/wmde/DataValuesJavascript/pull/48 can go in? [13:29:45] * aude hopes not and think snot [13:29:48] thinks* [13:30:11] aude: \o/ yay [13:30:14] Tobi_WMDE_SW_NA: I already said yes. please merge. [13:30:22] Tobi_WMDE_SW: What is going on here: https://travis-ci.org/wmde/ValueView/builds/39938887 [13:31:49] Henning_WMDE: the patch where I'm adding the .tryvis.yml needs to be merged first [13:32:07] travis service is active but no travis.yml present [13:32:23] so travis just guesses what is in the repository and runs "something" [13:32:37] So, we need to merge one probably broken change? ;) [13:32:48] Henning_WMDE: what is broken? [13:33:46] Tobi_WMDE_SW: do you see the error message on https://travis-ci.org/wmde/ValueView/builds/39938887 ??? [13:34:00] what is this? [13:34:07] seems unrelated to the change. [13:34:16] Thiemo_WMDE: just explained it to henning [13:34:26] explanation seems unrelated. [13:34:49] Thiemo_WMDE: ? [13:35:18] Could not find .travis.yml, using standard configuration. [13:35:37] so, if you merge https://github.com/wmde/ValueView/pull/124 it is fine [13:35:47] because this patch adds .travis.yml [13:36:39] ok, got it. [13:36:54] Henning_WMDE: Thiemo_WMDE: or if you are reluctant, then rebase https://github.com/wmde/ValueView/pull/125 on top of https://github.com/wmde/ValueView/pull/124 [13:37:07] [13ValueView] 15thiemowmde 04deleted 06add_travis at 14f6ad960: 02http://git.io/DfFUKQ [13:38:06] wmde/ValueView/master/c3b014b : thiemowmde The build is still failing. http://travis-ci.org/wmde/ValueView/builds/39943482 [13:38:12] [13ValueView] 15snaterlicious 04force-pushed 06jshinterrors from 14a4a19fd to 14341e7b3: 02http://git.io/bjl_Ag [13:38:12] 13ValueView/06jshinterrors 14341e7b3 15snaterlicious: Fixed JSHint errors [13:39:15] (03PS2) 10Adrian Lang: Move PropertyIdResolver to DataAccess namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149002 (owner: 10Aude) [13:40:59] (03PS2) 10Adrian Lang: Add @todo in LanguageAwareRenderer regarding PropertyId resolving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149004 (owner: 10Aude) [13:41:37] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/RehOmA [13:41:37] 13ValueView/06master 146fad229 15Tobi Gritschacher: Merge pull request #125 from wmde/jshinterrors... [13:42:17] thx Henning_WMDE and Thiemo_WMDE ! [13:43:34] I think some wikidata servers are having some problems... it's ~15' that I often receive 500s errors while using APIs [13:44:09] link? [13:45:10] aude: the one I'm calling? [13:45:32] yes [13:45:44] i don't see any issues myself, but then i am using hhvm [13:45:48] * aude tries without [13:46:42] or you say, api requests? [13:46:45] aude: http://www.wikidata.org/w/api.php?action=wbgetentities&format=json&ids=Q2902195 <-- sometimes it works, sometimes it returns 500 [13:47:03] ah [13:47:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=70345 [13:48:34] aude: not sure that that is the problem, since I'm requesting a single object [13:48:36] it should work, but suppose we need to investigate more, knowing it is still an issue [13:48:44] * aude nods [13:49:10] are you using hhvm beta feature? [13:49:28] aude: I don't think so... what is hhvm? [13:49:33] a beta feature [13:49:39] seems it doesn't matter for me [13:50:16] aude: I'm doing http requests to that url as unlogged user, so I think it whould be the most straight-forward scenario [13:50:45] (that url and other urls that are the same but with different Qvalues) [13:51:23] Thiemo_WMDE, Adrian_WMDE, jzerebecki: http://joomlacode.org/gf/project/joomla/scmsvn/l4%20%3E%3E%20joomlacode.orgjoomlacode.org/gf/project/joomla/scmsvn/?action=browse&path=/development/trunk/libraries/joomla/document/html/html.php&annotate=23145#l477 [13:51:34] Thiemo_WMDE: you think my code uses too much "magic"?... [13:52:00] think i see the issue [13:52:43] aude: do you have access to logs? I can tell you another url that just failed [13:53:12] fale: i do and am asking ops to fix this [13:53:26] Base lambda function for closure not found at /srv/mediawiki/php-1.25wmf6/extensions/Wikidata/extensions/Wikibase/lib/config/WikibaseLib.default.php on line 18 [13:53:43] * aude wants to remove the closure [13:54:00] aude: that was a fast debug! [13:54:14] this is not a new issue but happens only sometimes / rarely [13:54:42] I see [13:54:45] DanielK_WMDE: Speaking of procrastination: http://www.theatlantic.com/business/archive/2014/11/the-art-of-not-working-at-work/382121/?single_page=true [13:55:11] fale: thanks for poking [13:55:57] aude: thanks to you :) [13:57:49] aude: I don't know if I can ask you, but maybe you can give some help on this: I really sould like to see the numbers with units on wikidata and I'm willing to help toward this. Can I do something? What can I do about it? [13:58:58] (03PS3) 10Thiemo Mättig (WMDE): Refactor UrlSchemeValidators and allow more schemes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 (https://bugzilla.wikimedia.org/72924) [14:07:08] (03PS1) 10Thiemo Mättig (WMDE): Remove "bad http" and "mailto url" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170916 [14:07:15] (03PS1) 10Aude: Eliminate settings closure in WikibaseLib.default.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) [14:10:21] fale: probably need to ask DanielK_WMDE or lydia about units [14:10:31] aude: thanks :) [14:11:12] i think if we want full support for converting units, then it's more involved and takes more time to implement [14:11:41] maybe we want and are happy without that... i think is the question and not one i can answer [14:12:02] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Just restoring the previous +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [14:12:02] fale: we are thinking about enabling *very* basic unit support soon. We have long hasitated because we wanted to "do it reight" from the start, but at least i'm starting to feel that we have waited long enough, if not too long. [14:12:11] aude: yes, indeed. there's no definite decision on that yet [14:12:14] or* [14:12:18] unit conversion is not magic, but a bit of work [14:12:23] DanielK_WMDE: I agree with this :) [14:12:33] units without conversion are a lot less useful. but i think still better than nothing [14:13:47] (03PS2) 10Aude: Eliminate settings closure in WikibaseLib.default.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) [14:13:49] DanielK_WMDE: the problem currently is that anything that requires a measure (like: length, weigth, speed, radio frequencies) can not be putted in WikiData so, I think, evena "basic" support would help a lot [14:16:45] (03PS6) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [14:16:47] (03PS11) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) [14:16:49] (03PS15) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [14:19:57] (03CR) 10Henning Snater: [C: 032] Clean up API-based parsing code in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170068 (owner: 10Adrian Lang) [14:21:30] (03CR) 10jenkins-bot: [V: 04-1] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [14:21:48] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [14:23:31] (03CR) 10Henning Snater: [C: 032] Move datavalue parsing to ApiBasedValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170069 (owner: 10Adrian Lang) [14:28:20] (03Merged) 10jenkins-bot: Clean up API-based parsing code in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170068 (owner: 10Adrian Lang) [14:29:46] (03Merged) 10jenkins-bot: Move datavalue parsing to ApiBasedValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170069 (owner: 10Adrian Lang) [14:35:30] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Mainly questions. Not sure if thats enough to block this patch. All the problems I have can be fixed in later patches. Therefor my +1 and " (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [14:36:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Restoring my +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149002 (owner: 10Aude) [14:44:25] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c6 (10JulesWinnfield-hu) 5RESO/FIX>3REOP Not working: https://www.wikidata.org/w/index.php?title=Q1912804&diff=170553993&oldid=170551126 The cause is that the precision is 0.01667 instead of 0.01666... [14:45:14] (03PS1) 10Adrian Lang: Use RepoApiError in API-based formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170922 [14:46:30] (03PS2) 10Adrian Lang: Use RepoApiError in API-based formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170922 [14:49:50] (03CR) 10Henning Snater: [C: 032] Use RepoApiError in API-based formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170922 (owner: 10Adrian Lang) [14:52:35] (03CR) 10Jeroen De Dauw: Eliminate settings closure in WikibaseLib.default.php (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) (owner: 10Aude) [14:54:25] (03CR) 10Daniel Kinzler: Eliminate settings closure in WikibaseLib.default.php (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) (owner: 10Aude) [14:55:21] (03Merged) 10jenkins-bot: Use RepoApiError in API-based formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170922 (owner: 10Adrian Lang) [14:57:00] hello peepz [14:57:31] 1m g0nn4 h4ck th1s sh1t [14:57:45] good luck [14:58:01] th4nks [14:58:55] [13DataValuesJavascript] 15thiemowmde created 06ieee (+1 new commit): 02http://git.io/rS-F9g [14:58:55] 13DataValuesJavascript/06ieee 1470b2f35 15Thiemo Mättig: Don't compare floats without epsilon [15:00:51] [13DataValuesJavascript] 15thiemowmde opened pull request #53: Don't compare floats without epsilon (06master...06ieee) 02http://git.io/bM399w [15:01:49] lol [15:10:56] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c7 (10Andre Klapper) (In reply to tobias.gritschacher from comment #5) > Should be included in https://github.com/DataValues/Geo/releases/tag/1.1.0 > already (according to the readme) (In reply to Jule... [15:13:15] [13ValueView] 15thiemowmde created 06coordPrecision (+1 new commit): 02http://git.io/Kmky-A [15:13:15] 13ValueView/06coordPrecision 14bd7bcd1 15Thiemo Mättig: Round coordinate precision to 6 decimal places [15:13:26] (03PS1) 10Adrian Lang: Remove unused error messages from RepoApiError [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170929 [15:14:04] (03PS1) 10Adrian Lang: Remove unused mw reference in RepoApi, expand alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170930 [15:16:51] (03PS2) 10Adrian Lang: Remove unused error messages from RepoApiError [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170929 [15:18:08] (03PS3) 10Aude: Eliminate settings closure in WikibaseLib.default.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) [15:18:56] (03CR) 10Aude: Eliminate settings closure in WikibaseLib.default.php (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) (owner: 10Aude) [15:19:41] [13ValueView] 15thiemowmde opened pull request #126: Round coordinate precision to 6 decimal places (06master...06coordPrecision) 02http://git.io/STAs_Q [15:23:26] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c8 (10Thiemo Mättig) 5REOP>3PATC (In reply to Andre Klapper from comment #7) > Special:Version says "DataValues Geo 1.0" I'm afraid this is actually a bug, but in an other component, see https://gi... [15:28:03] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06languageFallBack from 14cb90082 to 14a3b21be: 02http://git.io/Fm47wA [15:28:03] 13WikibaseDataModel/06languageFallBack 14a3b21be 15Jan Zerebecki: Add TermFallBack and Inferred. [15:29:14] [13WikibaseDataModel] 15JanZerebecki comment on commit 14cb90082: I want to have the parts that what will use this done first. And yes, also tests. 02http://git.io/7I3Cpg [15:31:26] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183#c2 (10Jan Zerebecki) Additional requirement: We want to have a facility that can test if an object has inferred information like language fall back and thus should not be... [15:37:25] (03CR) 10Jeroen De Dauw: [C: 032] Eliminate settings closure in WikibaseLib.default.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) (owner: 10Aude) [15:42:34] (03Merged) 10jenkins-bot: Eliminate settings closure in WikibaseLib.default.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170917 (https://bugzilla.wikimedia.org/71565) (owner: 10Aude) [15:44:26] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c9 (10JulesWinnfield-hu) (In reply to Thiemo Mättig from comment #8) I'm afraid you do not use the Wikidata UI. The coordinates gadget has many issues. Once, before it was ported to backend I think, it... [15:48:36] Thiemo_WMDE: Henning_WMDE: should I create releases for DM JS and serialization JS? [15:48:56] Yeah [15:49:02] Tobi_WMDE_SW: No [15:49:04] oh, it's still an Adrian_WMDE [15:49:12] Henning_WMDE: awww [15:49:19] Ok, then do it [15:49:38] Henning_WMDE: are you planning to do more work there? [15:49:45] pull requests are empty [15:50:07] It's just, we do not need them before https://gerrit.wikimedia.org/r/#/c/167782/ - and until that is merged, we could still apply changes easily. [15:50:39] Henning_WMDE: it's just, I see comments like "Code looks good so far. But I need to review (and test) this in more detail as soon as the tests succeed." [15:50:51] which won't happen if there are no releases [15:51:18] But you also need the corresponding Wikibase change [15:51:43] Henning_WMDE: that comment was from the corresponding wikibase change [15:52:29] I do not really care OK, but as long as the dependency is not [15:52:36] and what's with https://gerrit.wikimedia.org/r/#/c/167782 [15:52:52] ... merged [15:53:11] that is what I mentioned [15:53:16] yeah, are there remaining issues with that? [15:53:29] Well, yes - and no [15:53:41] seems the issue i mentioned was fixed [15:53:46] and I see no further comments [15:53:50] OK, feel free to merge... [15:54:02] (03CR) 10Jeroen De Dauw: [C: 032] Remove unused mw reference in RepoApi, expand alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170930 (owner: 10Adrian Lang) [15:54:27] (03CR) 10Jeroen De Dauw: [C: 031] Remove unused error messages from RepoApiError [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170929 (owner: 10Adrian Lang) [15:54:40] Henning_WMDE: no +1? [15:54:59] I'll leave it on 0 [15:55:14] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c10 (10Thiemo Mättig) (In reply to JulesWinnfield-hu from comment #9) > I'm afraid you do not use the Wikidata UI. Are you aware I'm a Wikibase frontend developer? Please don't talk to me like this. Th... [15:55:21] Henning_WMDE: why? [15:55:33] I cannot read minds.. ;) [15:55:50] (03CR) 10Jeroen De Dauw: [C: 031] Remove "bad http" and "mailto url" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170916 (owner: 10Thiemo Mättig (WMDE)) [15:56:35] It's a mess stirred up [15:56:44] how to fix? [15:56:56] Adrian_WMDE: ? [15:57:13] Just merge, it's not much more of a mess than it was before. [15:57:35] it is not better? [15:57:35] (03PS23) 10Jeroen De Dauw: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [15:57:41] so why do it then? [15:57:58] Because it would not work with the new JS data model. [15:58:24] ok, so it is necessary [15:58:54] Necessary evil [15:59:16] well no, but it would be a lot of effort to do all the clean-up right away [15:59:26] hm, so to not need evilness the DM would have to change again? [15:59:41] we do not want that [15:59:43] Tobi_WMDE_SW: Our views look like they would implement the same interfaces, but they all behave very differently [15:59:58] Claimview was able to save and handle edit mode, statementview wasnt, etc [16:00:22] yeah [16:02:23] (03CR) 10Tobias Gritschacher: [C: 032] Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [16:02:53] Thumbs up, Tobi_WMDE_SW! [16:03:01] ;) [16:03:02] (03CR) 10jenkins-bot: [V: 04-1] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [16:03:06] Yeah [16:03:20] (03CR) 10Jeroen De Dauw: Add getPermissionForTitle method to use in ViewEntityAction (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168832 (owner: 10Aude) [16:06:59] Tobi_WMDE_SW: Are you about to make the releases or shall I? [16:07:27] (03Merged) 10jenkins-bot: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [16:16:50] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14cb90082: Why not start with a PR? That's what people tend to do. If it is a draft or should not be merged yet, you can make this clear in the title. The benefits are both visibility / easy of finding the thing and more continuous discussion. I posted at least one comment on a "different version" of this commit, which cannot be seen here now. 02http://git.io/TnP_fg [16:25:16] 3MediaWiki extensions / 3WikidataRepo: Make statement view use claimview instead of inherit - 10https://bugzilla.wikimedia.org/72312 (10Henning) 5PATC>3RESO/FIX [16:32:05] [13WikibaseDataModel] 15JeroenDeDauw created 06InterfaceInterface (+1 new commit): 02http://git.io/cPWhwg [16:32:05] 13WikibaseDataModel/06InterfaceInterface 1431dd540 15jeroendedauw: Implement much needed unification of interfaces [16:32:23] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #271: Implement much needed unification of interfaces (06master...06InterfaceInterface) 02http://git.io/aoPK_w [16:40:34] [13WikibaseDataModel] 15JanZerebecki opened pull request #272: [WIP] Add requirements for language fall backs. (06master...06languageFallBack) 02http://git.io/kKxPEg [16:41:45] [13WikibaseDataModelSerialization] 15JanZerebecki opened pull request #97: [WIP] Add requirements for language fall backs. (06master...06languageFallBack) 02http://git.io/0bOepg [16:44:33] wmde/WikibaseDataModel/InterfaceInterface/31dd540 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39961209 [17:36:12] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 14a3b21be: The wording here is too specific. "should never be persisted" is better. Though that is still not correct, since there might well be cases where one wants to store inferred information. (Which we are doing in Wikibase Repo for several things.) 02http://git.io/gaHKDQ [17:37:31] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 14a3b21be: So does this mean the entire TermFallback should not be persisted, or just the information not present in it's parent? In case of the former you have an LSP violation, and in case of the later the meaning of the interface is quite fuzzy. 02http://git.io/jcJYqQ [17:40:09] (03PS5) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 [17:40:11] (03PS1) 10Daniel Kinzler: Determin update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 [17:46:06] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 14a3b21be: Also, since this is being written for serialization purposes, I wonder how that's going to be implemented. With an `if ( instanceof TermFallback )` check? 02http://git.io/N3PyXQ [17:49:05] (03CR) 10jenkins-bot: [V: 04-1] Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (owner: 10Daniel Kinzler) [17:49:07] (03CR) 10jenkins-bot: [V: 04-1] Determin update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (owner: 10Daniel Kinzler) [17:58:11] [13WikibaseQueryEngine] 15JeroenDeDauw created 06rdcc (+1 new commit): 02http://git.io/bLJPmg [17:58:11] 13WikibaseQueryEngine/06rdcc 146b04b1a 15jeroendedauw: Remove dead code [17:58:26] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #135: Remove dead code (06master...06rdcc) 02http://git.io/eeLkYw [18:05:35] jzerebecki: easy review is very easy https://github.com/wmde/WikibaseQueryEngine/pull/135 [18:12:45] wmde/WikibaseQueryEngine/rdcc/6b04b1a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/39970113 [18:18:14] (03PS1) 10Daniel Kinzler: Move ChangeHandler and friends to new namespace. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170967 [18:35:55] [13WikibaseQueryEngine] 15JanZerebecki pushed 1 new commit to 06master: 02http://git.io/d2ruBA [18:35:55] 13WikibaseQueryEngine/06master 149553860 15Jan Zerebecki: Merge pull request #135 from wmde/rdcc... [18:36:05] [13WikibaseQueryEngine] 15JanZerebecki 04deleted 06rdcc at 146b04b1a: 02http://git.io/nS30kA [18:37:20] * aude cries.... [18:37:30] has to disable BetaFeatures and Translate extensions again [18:38:19] :O [18:39:43] they cause problems when running wikibase tests [18:50:24] [13WikibaseQueryEngine] 15JeroenDeDauw created 06fold (+1 new commit): 02http://git.io/Q4yiLw [18:50:24] 13WikibaseQueryEngine/06fold 146d2de3a 15jeroendedauw: Join some classes together... [18:50:44] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #136: Join some classes together (06master...06fold) 02http://git.io/24O_4Q [18:51:26] jzerebecki: more lines and complexity killed, though a bit less easy to review: https://github.com/wmde/WikibaseQueryEngine/pull/136 [19:00:14] wmde/WikibaseQueryEngine/fold/6d2de3a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/39975156 [19:12:48] (03PS1) 10Daniel Kinzler: Extract change coalescing logic from ChangeHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 [19:15:07] (03CR) 10Daniel Kinzler: [C: 032] Refactor UrlSchemeValidators and allow more schemes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 (https://bugzilla.wikimedia.org/72924) (owner: 10Thiemo Mättig (WMDE)) [19:16:30] DanielK_WMDE: so... https://gerrit.wikimedia.org/r/170528 want to remove your -1? [19:20:23] (03CR) 10jenkins-bot: [V: 04-1] Extract change coalescing logic from ChangeHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [19:21:00] (03Merged) 10jenkins-bot: Refactor UrlSchemeValidators and allow more schemes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170906 (https://bugzilla.wikimedia.org/72924) (owner: 10Thiemo Mättig (WMDE)) [19:28:48] (03CR) 10Daniel Kinzler: [C: 032] Fix for statements on properties in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170576 (https://bugzilla.wikimedia.org/72671) (owner: 10Aude) [19:32:02] (03PS1) 10Aude: Add more in-process caching for property parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171007 [19:32:04] (03PS1) 10Aude: More descriptive names for property parser function classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171008 [19:32:06] (03PS1) 10Aude: Check if property exists in PropertyIdResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 [19:36:43] (03CR) 10Aude: Move property id resolving code for parser function into own class (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [19:37:59] aude: Just out of curiosity... could you vote in the midterms (via letter or so)? [19:39:07] (03CR) 10Aude: "note that i now think this is not a good idea. "PropertyClaims" is a bit vague, imho. renamed this in a follow up." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude) [19:39:32] (03Merged) 10jenkins-bot: Fix for statements on properties in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170576 (https://bugzilla.wikimedia.org/72671) (owner: 10Aude) [19:40:14] (03CR) 10Aude: "@daniel see https://gerrit.wikimedia.org/r/#/c/171007/ for additional in-process caching and improved initialization of the objects" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148672 (owner: 10Aude) [19:41:08] hoo: sort of, yes [19:42:17] have to leave all the local / state stuff blank, so vote for one thing only out of pages of stuff [19:42:25] and snail mail it [19:42:59] Yeah, that makes sense [19:43:01] :) [19:43:20] so, vote for congress ;) [19:43:28] but when i was a DC resident, couldn't do that [19:43:37] very strange [19:43:44] You couldn't vote for congress? [19:43:57] https://en.wikipedia.org/wiki/District_of_Columbia_voting_rights [19:43:58] nope [19:44:17] it's been quite some time since i could vote for everything :( [19:45:02] but qualify for https://en.wikipedia.org/wiki/Uniformed_and_Overseas_Citizens_Absentee_Voting_Act [19:45:59] I'm not even sure I could vote remote... I can vote in advance via letter (had to do that last year... cause I was in Berlin with you people), but not sure about remote [19:46:42] for the first time, i could download the ballot :) [19:46:50] omg, technology ... [19:47:30] But they're fast with voting machines... [19:48:07] that depends [19:48:22] Florida and some other states I think [19:48:40] * hoo never read anything good about them [19:52:02] (03CR) 10Aude: "in favor of this change but not reviewed closely yet. just noticed a typo" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (owner: 10Daniel Kinzler) [19:59:13] (03CR) 10Aude: [C: 04-1] "think we need to use a different exception for property not found here and make sure to use a localizer for it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [20:03:48] https://twitter.com/wikidata/status/529723778558083074 :D [20:04:09] \o/ [20:04:55] * aude guesses https://twitter.com/opencorporates/status/529721444549550080 is the other award [20:06:11] so we have both? :) [20:06:20] yeah [20:06:23] http://summit.theodi.org/awards/ [20:06:25] awesome [20:06:35] :) [20:08:41] hope the awards get a nice place in the office :D [20:10:25] aude: Where is that? [20:10:45] London, somehwere I think [20:11:09] London Arup, 8 Fitzroy Street / BFI, Southbank / Museum of London [20:14:46] hoo: Museum of London, that's a nice location :-0 [20:15:21] (03CR) 10Aude: Add getPermissionForTitle method to use in ViewEntityAction (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168832 (owner: 10Aude) [20:15:49] * aude thinks at least one should go to magnus :) [20:15:57] maybe other at the office [20:16:27] * aude see when lydia gets back [20:16:52] (03PS2) 10Aude: Use Title::quickUserCan in EntityPermissionChecker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170694 [20:16:54] (03PS4) 10Aude: Add getPermissionForTitle method to use in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168832 [20:16:56] (03PS2) 10Aude: Remove $parserOptions->setEditSection code in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170695 [20:16:58] (03PS2) 10Aude: Adjust getPermissionForTitle method to getEditPermissionForTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170693 [20:17:22] alright, lots of stuff to review! [20:48:38] (03CR) 10Aude: [C: 032] Remove "bad http" and "mailto url" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170916 (owner: 10Thiemo Mättig (WMDE)) [20:53:45] (03Merged) 10jenkins-bot: Remove "bad http" and "mailto url" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170916 (owner: 10Thiemo Mättig (WMDE)) [20:55:04] (03CR) 10Aude: "with this change, it seems now when i edit a url snak value, then click save, the url becomes linked (even if it is invalid) and never fin" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [20:56:56] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c11 (10JulesWinnfield-hu) (In reply to Thiemo Mättig from comment #10) Right now the UI is broken. You can see it at the supplied link. Just two things, 44°38'60"N, 25°19'60"E and 0.01667 Is anybody the... [22:27:57] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c12 (10Andre Klapper) Questions still unanswered: Did you use the API? Or UI? What "old function" - do you imply there was no such issue a while ago? If so, when was that? (And if you're frustrated, yo... [22:49:16] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06languageFallBack from 14a3b21be to 141c98b17: 02http://git.io/Fm47wA [22:49:16] 13WikibaseDataModel/06languageFallBack 141c98b17 15Jan Zerebecki: Add TermFallBack and Inferred. [22:49:31] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 14753da5a to 148de82c1: 02http://git.io/0KqFLw [22:49:31] 13WikibaseDataModelSerialization/06languageFallBack 148de82c1 15Jan Zerebecki: Support TermFallBack.... [22:49:48] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 141c98b17: Done. 02http://git.io/szPonw [22:50:30] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 141c98b17: Done. 02http://git.io/YCxR5A [22:55:09] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 141c98b17: Yes. 02http://git.io/7AtB0Q [23:02:46] wmde/WikibaseDataModelSerialization/languageFallBack/8de82c1 : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/40003775 [23:44:11] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c13 (10JulesWinnfield-hu) (In reply to Andre Klapper from comment #12) I used the UI. The UI worked well in January 2014 https://www.wikidata.org/w/index.php?title=Q516668&diff=97804713&oldid=92709157 N... [23:45:40] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c12 (10Marius Hoch) 5REOP>3RESO/FIX Seems to no longer be an issue. [23:46:15] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #272 141c98b17: Well, that does not work then. You'd need to modify all code persists terms or entities. All of a sudden you are no longer able to do `persist( $serializer->serialize( $entity ) )`. I'm already highly dubious about the `Inferred` interface without the LSP violation being there. 02http://git.io/Rup5Ow [23:47:48] (03CR) 10Jeroen De Dauw: [C: 032] Add getPermissionForTitle method to use in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168832 (owner: 10Aude) [23:48:28] (03CR) 10Jeroen De Dauw: [C: 032] Adjust getPermissionForTitle method to getEditPermissionForTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170693 (owner: 10Aude) [23:49:19] (03CR) 10Jeroen De Dauw: [C: 032] Use Title::quickUserCan in EntityPermissionChecker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170694 (owner: 10Aude) [23:49:47] aude: I think you better put some of that stuff in a single commit. Now I reviewed changes that did not matter, since the code got removed [23:50:11] (03CR) 10Jeroen De Dauw: [C: 032] Remove $parserOptions->setEditSection code in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170695 (owner: 10Aude) [23:52:14] (03CR) 10Jeroen De Dauw: "I do hope we are not creating one exception class per error message?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude)