[08:58:47] (03PS1) 10Henning Snater: Added removeError() to fingerprintgroupview and sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170293 [08:58:49] (03PS1) 10Henning Snater: fingerprintgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170294 [08:59:56] 3MediaWiki extensions / 3WikidataRepo: Reset edit-mode when error occurs during a request-queue - 10https://bugzilla.wikimedia.org/72311#c2 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/170294/ [09:00:24] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/IKREWA [09:00:24] 13WikidataBrowserTests/06master 1446ec34a 15Tobias Gritschacher: Re-arrange tags [09:06:14] (03CR) 10jenkins-bot: [V: 04-1] Added removeError() to fingerprintgroupview and sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170293 (owner: 10Henning Snater) [09:06:36] (03CR) 10jenkins-bot: [V: 04-1] fingerprintgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170294 (owner: 10Henning Snater) [09:32:18] [13WikibaseDataModel] 15thiemowmde closed pull request #263: Improve naming in StatementListDifferTest (06master...06rename) 02http://git.io/CEu-ng [09:34:08] [13WikibaseDatabase] 15thiemowmde closed pull request #57: Move QueryInterface into package root NS (06master...06mvc) 02http://git.io/nOxIhw [09:50:14] (03PS3) 10Tobias Gritschacher: $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (owner: 10Henning Snater) [09:50:22] (03CR) 10jenkins-bot: [V: 04-1] $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (owner: 10Henning Snater) [09:52:23] (03PS4) 10Tobias Gritschacher: Remove sitelinkview when hitting backspace in first input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 (owner: 10Henning Snater) [09:55:38] (03PS4) 10Henning Snater: $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 [09:57:54] [13WikibaseQuery] 15thiemowmde 04force-pushed 06dm20again from 14a1fc2c6 to 147788ba3: 02http://git.io/q-MPDA [09:57:54] 13WikibaseQuery/06dm20again 14dcb763c 15Thiemo Mättig: Fix composer update [09:57:54] 13WikibaseQuery/06dm20again 147788ba3 15Thiemo Mättig: Fix tests [09:59:47] (03CR) 10jenkins-bot: [V: 04-1] Remove sitelinkview when hitting backspace in first input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 (owner: 10Henning Snater) [10:00:51] (03CR) 10jenkins-bot: [V: 04-1] $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (owner: 10Henning Snater) [10:01:24] wmde/WikibaseQuery/dm20again/7788ba3 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/39580357 [10:05:50] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration from 14c4f7b45 to 14521d789: 02http://git.io/bcVHHg [10:05:50] 13WikibaseQueryEngine/06dvintegration 14521d789 15Thiemo Mättig: BooleanHandlerIntegrationTest [10:09:30] wmde/WikibaseQueryEngine/dvintegration/521d789 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/39580843 [10:11:10] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration from 14521d789 to 14d467367: 02http://git.io/bcVHHg [10:11:10] 13WikibaseQueryEngine/06dvintegration 14d467367 15Thiemo Mättig: BooleanHandlerIntegrationTest [10:16:21] wmde/WikibaseQueryEngine/dvintegration/d467367 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/39581192 [10:19:11] (03PS1) 10Tobias Gritschacher: Provide config when constructing WikiImporter in RepoHooksTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170298 [10:25:03] (03PS5) 10Henning Snater: $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 [10:30:33] (03PS3) 10Thiemo Mättig (WMDE): Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 [10:33:40] (03CR) 10jenkins-bot: [V: 04-1] $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (owner: 10Henning Snater) [10:33:50] (03PS5) 10Thiemo Mättig (WMDE): Clean up entityChangers tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168271 [10:40:15] (03CR) 10jenkins-bot: [V: 04-1] Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 (owner: 10Thiemo Mättig (WMDE)) [10:40:45] (03CR) 10jenkins-bot: [V: 04-1] Clean up entityChangers tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168271 (owner: 10Thiemo Mättig (WMDE)) [11:01:29] 3MediaWiki extensions / 3WikidataClient: Page should not be reloaded if the user press ESC to close the "Link with page" popup - 10https://bugzilla.wikimedia.org/72807 (10Helder) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs On https://pt.wikipedia.org/wiki/Template:Country_flag_IOC_alias_IRQ?uselang=en... [11:03:21] oh noes, RepoHooks Importer test depends on settings! [11:04:59] (03CR) 10Aude: [C: 032] Provide config when constructing WikiImporter in RepoHooksTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170298 (owner: 10Tobias Gritschacher) [11:10:02] (03Merged) 10jenkins-bot: Provide config when constructing WikiImporter in RepoHooksTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170298 (owner: 10Tobias Gritschacher) [11:10:36] (03CR) 10Henning Snater: [C: 032] Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 (owner: 10Thiemo Mättig (WMDE)) [11:10:43] 3MediaWiki extensions / 3WikidataClient: Add a keyboard shortcut to "Add links" - 10https://bugzilla.wikimedia.org/72808 (10Helder) [11:10:44] 3MediaWiki extensions / 3WikidataClient: Add a keyboard shortcut to "Add links" - 10https://bugzilla.wikimedia.org/72808 (10Helder) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs I miss a shortcut like ALT+SHIFT+ for the "Add links" feature, similar to the ALT+SHIFT+r which is available for the... [11:12:13] (03PS2) 10Tobias Gritschacher: Added removeError() to fingerprintgroupview and sub-components [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170293 (owner: 10Henning Snater) [11:12:19] (03PS2) 10Tobias Gritschacher: fingerprintgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170294 (owner: 10Henning Snater) [11:12:29] (03PS6) 10Tobias Gritschacher: Clean up entityChangers tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168271 (owner: 10Thiemo Mättig (WMDE)) [11:12:43] (03PS5) 10Tobias Gritschacher: Remove sitelinkview when hitting backspace in first input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 (owner: 10Henning Snater) [11:12:48] (03PS6) 10Tobias Gritschacher: $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (owner: 10Henning Snater) [11:22:43] (03PS7) 10Henning Snater: Clean up entityChangers tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168271 (owner: 10Thiemo Mättig (WMDE)) [11:25:15] (03Merged) 10jenkins-bot: Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 (owner: 10Thiemo Mättig (WMDE)) [11:25:20] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/10/31 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170306 [11:25:53] (03CR) 10Henning Snater: [C: 032] Clean up entityChangers tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168271 (owner: 10Thiemo Mättig (WMDE)) [11:31:05] [13ValueView] 15snaterlicious 04force-pushed 06valueviewlang from 14e0520af to 14a03ec01: 02http://git.io/Bh9f3w [11:31:05] 13ValueView/06valueviewlang 14a03ec01 15snaterlicious: Added "language" option to valueview widget [11:34:09] (03Merged) 10jenkins-bot: Clean up entityChangers tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168271 (owner: 10Thiemo Mättig (WMDE)) [11:38:44] (03PS4) 10Thiemo Mättig (WMDE): Much more clean up in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 [11:39:32] (03CR) 10Aude: [C: 04-1] "mostly nitpicks about variable naming, etc." (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [11:40:27] (03CR) 10Tobias Gritschacher: [V: 032] New Wikidata Build - 2014/10/31 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170306 (owner: 10Tobias Gritschacher) [11:40:51] (03CR) 10Aude: "also, i get a fatal error when running the tests:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [11:41:00] (03PS1) 10Thiemo Mättig (WMDE): [WIP] Replace useless IDatabase type in ConnectionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170307 [11:43:09] (03CR) 10Aude: "nevermind about the class not found..." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [11:43:13] Food options? [11:43:35] * aude is going to the post office [11:43:44] something near there? [11:46:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace useless IDatabase type in ConnectionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170307 (owner: 10Thiemo Mättig (WMDE)) [11:51:24] (03CR) 10Aude: Replacing ItemUsageIndex with UsageLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [11:52:26] (03CR) 10Henning Snater: [C: 04-1] "There has been little documentation about what error formats are expected and the change drops the few lines of documentation in getApiBas" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170068 (owner: 10Adrian Lang) [11:54:20] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/10/31 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170306 (owner: 10Tobias Gritschacher) [11:54:56] (03PS3) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [11:57:02] (03PS7) 10Tobias Gritschacher: $.wikibase.sitelinklistview: Implemented dynamic input elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (https://bugzilla.wikimedia.org/72023) (owner: 10Henning Snater) [11:59:53] (03PS2) 10Henning Snater: Move datavalue parsing to ApiBasedValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170069 (owner: 10Adrian Lang) [12:04:48] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [12:13:47] (03PS3) 10Tobias Gritschacher: fingerprintgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170294 (https://bugzilla.wikimedia.org/72311) (owner: 10Henning Snater) [12:14:56] (03PS2) 10Tobias Gritschacher: Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 (https://bugzilla.wikimedia.org/66715) (owner: 10Henning Snater) [12:15:51] (03PS2) 10Tobias Gritschacher: Added snakview.variations.Value.start/stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 (https://bugzilla.wikimedia.org/70337) (owner: 10Henning Snater) [12:16:48] (03PS2) 10Tobias Gritschacher: Initialize copyright tooltip on toolbar container [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170020 (https://bugzilla.wikimedia.org/72755) (owner: 10Henning Snater) [12:17:17] (03PS2) 10Tobias Gritschacher: Re-added highlighting to siteselector and pagesuggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169729 (https://bugzilla.wikimedia.org/66433) (owner: 10Henning Snater) [12:19:54] (03PS2) 10Tobias Gritschacher: Adapt to ValueView 0.8.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169682 (https://bugzilla.wikimedia.org/63059) (owner: 10Henning Snater) [12:20:34] (03PS2) 10Tobias Gritschacher: Initialize statements on property pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169681 (https://bugzilla.wikimedia.org/68379) (owner: 10Henning Snater) [12:21:16] (03PS2) 10Tobias Gritschacher: Use back-end parser for "commons" and "url" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169672 (https://bugzilla.wikimedia.org/62193) (owner: 10Henning Snater) [13:12:59] Thiemo_WMDE: "Oh wow, this was confusing." nice start of a commit message! [13:17:31] (03CR) 10Jeroen De Dauw: Much more clean up in SqlUsageTracker (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 (owner: 10Thiemo Mättig (WMDE)) [13:18:14] (03CR) 10Jeroen De Dauw: "> An $entities array should always contain Entity objects, not something else." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 (owner: 10Thiemo Mättig (WMDE)) [13:23:13] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06dm20again: 02http://git.io/lw-Ang [13:23:13] 13WikibaseQuery/06dm20again 14722b8cc 15Jeroen De Dauw: Update composer.json [13:23:22] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/i9GJCw [13:23:22] 13WikibaseQuery/06master 14523e427 15Jeroen De Dauw: Merge pull request #55 from wmde/dm20again... [13:25:20] aude's computer right now: http://xkcd.com/1172/ [13:25:50] lol [13:27:06] wmde/WikibaseQuery/dm20again/722b8cc : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/39595843 [13:30:29] wmde/WikibaseQuery/master/523e427 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/39595876 [13:38:31] Thiemo_WMDE: aude :D [13:44:52] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/e9CQUQ [13:44:52] 13WikibaseDataModel/06master 1441183e8 15jeroendedauw: Fix @since tag [13:48:07] (03PS4) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [13:49:30] [13WikibaseDataModel] 15JeroenDeDauw created 06newFromMainSnak (+1 new commit): 02http://git.io/ExTjuQ [13:49:30] 13WikibaseDataModel/06newFromMainSnak 14c637664 15jeroendedauw: Add Statement::newFromMainSnak... [13:49:38] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #265: Add Statement::newFromMainSnak (06master...06newFromMainSnak) 02http://git.io/A8erAQ [13:50:39] * hoo|phone has a power outage [13:50:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/RJpRPg [13:50:59] 13WikibaseDataModel/06master 145683f0b 15jeroendedauw: Update links to original DataModel document [13:51:14] [13WikibaseDataModel] 15filbertkm comment on commit 14c637664: aaaaaah, still has new Claim() here.... 02http://git.io/AVt62A [13:51:32] Lydia_WMDE, ^^ [13:51:41] hoo|phone: omg! [13:51:43] Need zo delay the meeting [13:51:46] why, how [13:52:00] thought that's impossible in germany :P [13:52:22] Guess it's related to the construction work in front of my house [13:52:26] wmde/WikibaseDataModel/newFromMainSnak/c637664 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39598103 [13:52:27] aaaa [13:52:52] But all the construction workers left [13:52:53] * aude thought it only happens in america [13:52:54] Wtf [13:53:13] :D [13:53:50] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [13:57:35] People in warning vests arriving... Guess I'm back soonish [13:58:35] Oh... My servers uptime is ruined now :D [13:59:39] hmmm, $jenkins_job_name hack no longer works to force tests in debug mode? :( [14:01:41] ah, i see [14:02:17] (03PS5) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:02:33] The workers left now [14:02:47] That's not like good :/ [14:02:54] :( [14:03:44] 3MediaWiki extensions / 3WikidataClient: Add mw.wikibase.getEntityObject by site link (title) Lua function - 10https://bugzilla.wikimedia.org/72815 (10JulesWinnfield-hu) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Please add mw.wikibase.getEntityObject by site link (title) Lua function just like https:... [14:03:58] 3MediaWiki extensions / 3WikidataClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - 10https://bugzilla.wikimedia.org/47930 (10JulesWinnfield-hu) [14:04:29] (03PS1) 10Aude: Remove unset( $jenkins_job_name ) from entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170322 [14:09:38] [13WikibaseDataModel] 15JanZerebecki created 06languageFallBack (+1 new commit): 02http://git.io/GeQ8AQ [14:09:38] 13WikibaseDataModel/06languageFallBack 14dd79ac5 15Jan Zerebecki: Add TermFallBack. [14:10:54] [13WikibaseDataModel] 15filbertkm comment on commit 14dd79ac5: no camel case please for "fallback" .... $fallbackLanguageCode 02http://git.io/ojgaBA [14:11:05] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:14:10] wmde/WikibaseDataModel/languageFallBack/dd79ac5 : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39600061 [14:15:18] (03PS6) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:17:18] (03CR) 10Aude: Replacing ItemUsageIndex with UsageLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:20:09] (03CR) 10Aude: [C: 04-1] "14:19:37 Starting test 'Wikibase\Client\Tests\Usage\Sql\SiteLinkUsageLookupTest::testGetUsageForPage'." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:21:24] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:21:53] (03PS7) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:22:57] (03PS8) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:23:07] (03CR) 10Jeroen De Dauw: [C: 032] "This looks like clean up of legacy code :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 (owner: 10Thiemo Mättig (WMDE)) [14:25:17] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06languageFallBack from 14dd79ac5 to 1455e5c2c: 02http://git.io/Fm47wA [14:25:17] 13WikibaseDataModel/06languageFallBack 1455e5c2c 15Jan Zerebecki: Add TermFallBack. [14:27:39] * hoo|powerOutage ... Meh [14:29:09] wmde/WikibaseDataModelSerialization/languageFallBack/910138c : Jan Zerebecki The build failed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/39601587 [14:30:56] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:31:43] Will call them [14:32:27] (03PS9) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:32:37] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06languageFallBack from 1455e5c2c to 14beb27a3: 02http://git.io/Fm47wA [14:32:37] 13WikibaseDataModel/06languageFallBack 14beb27a3 15Jan Zerebecki: Add TermFallBack. [14:33:46] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 14910138c to 14753da5a: 02http://git.io/0KqFLw [14:33:46] 13WikibaseDataModelSerialization/06languageFallBack 14753da5a 15Jan Zerebecki: [WIP] Support TermFallBack. [14:36:27] wmde/WikibaseDataModelSerialization/languageFallBack/753da5a : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/39602552 [14:38:03] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:38:41] aaaaa [14:45:37] (03PS10) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:49:26] Ok, will take a bit... [14:51:03] * aude rages..... why can't i search on github by commit hash (like i can do in gerrit) [14:51:31] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:51:44] bah, wtf? [14:51:54] DanielK_WMDE: investigating [14:51:55] aude: we are about done, will look into this in a minute [14:52:19] the one thing i fixed was use of some new phpunit method that probably is not in the version jenkins has [14:52:25] now, what....... [14:54:59] ok, i think i see [14:56:54] (03PS11) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:57:02] ah , never mind [15:00:53] ... Waiting... :/ [15:01:56] (03CR) 10Aude: "15:01:14 Starting test 'Wikibase\Test\DirectSqlStoreTest::testGetters with data set #6 ('getUsageTracker', 'Wikibase\\Client\\Usage\\Usage" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [15:02:49] Haha... This the only house that's cut off [15:02:57] Neighbours are fine [15:03:02] (03CR) 10Aude: [C: 04-1] "also note, with manually testing with the dispatcher, the changes don't appear in recent changes nor reflect when i simply reload the page" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [15:03:14] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [15:03:14] hoo|powerOutage: go steal power from the neighbors [15:03:22] and internets [15:08:08] Heh, not sure people like sharing Internet [15:10:17] * aude fails to see where UsageLookup::getUsagesForPage is defined [15:12:47] aaaaaaaaaaaaaaaaa [15:12:52] * aude rage at thiemo [15:20:53] (03PS12) 10Aude: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [15:22:32] (03CR) 10Aude: [C: 04-1] "per comments in earlier patches and still doesn't seem to update client pages any more nor recent changes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [15:26:01] The day, the routers died... [15:26:19] https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/7298/console \o/ [15:26:47] Still waiting [15:26:53] :( [15:27:23] at least you are not snowed in or such [15:27:34] Lydia_WMDE: I don't think we can do the meeting thing today :/ [15:27:43] * aude was snowed in with now power for 1-2 days [15:27:45] no* [15:27:55] That's awful [15:27:58] snow? :O [15:28:07] yeah, and cold [15:28:10] Being snowed in [15:28:18] Oh, I bet [15:28:49] during snowmaggedon ;) [15:29:38] Someone arrived [15:29:43] yay [15:30:38] hoo|powerOutage: yeah no problem. things are crazy here too anyway [15:30:49] it's a Lydia_WMDE ! [15:30:55] hey aude :) [15:30:58] it is! [15:31:09] how are things? [15:31:25] we miss you [15:31:31] awwww [15:31:40] i will be back in the office on monday for 1 day [15:31:46] ah [15:31:53] and then again on wednesday or thursday [15:32:06] and then bring back the open data award :P [15:32:19] :D [15:32:25] magnus and me will do our best! [15:32:29] :) [15:33:33] :) [15:33:41] Still powerless [15:37:04] back [15:37:04] ! [15:37:12] yay! [15:37:36] Ok... will warm up some food now etc. [15:37:42] be back later [15:37:49] ok [15:46:33] * aude cries..... looking at ChangeOpClaimTest [16:10:23] (03PS1) 10Aude: Add test case for statements on property in ChangeOps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170342 [16:11:56] and we also have ChangeOpClaimRemove :( [16:12:16] and ClaimChangeOpFactory [16:12:39] not to mention all the claim api modules [16:49:04] (03CR) 10Daniel Kinzler: "Uh, why do we still need this file at all? it doesn't do anything... how does the jenkins magic work these days?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170322 (owner: 10Aude) [16:51:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I remember a very, very similar patch. Wasn't the same test fixed multiple times? Hm, strange." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169692 (owner: 10Henning Snater) [16:52:54] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Checking for missing page does not need content object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168831 (owner: 10Aude) [16:55:11] (03CR) 10Daniel Kinzler: "Argument 4 passed to Wikibase\Repo\Specials\SpecialEntitiesWithoutPage::__construct() must be an instance of Wikibase\EntityPerPage, insta" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [17:04:08] (03PS2) 10Aude: Fix fatal error in ChangeOpClaim for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170342 (https://bugzilla.wikimedia.org/72671) [17:13:55] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14c637664: wtf? What is the issue with that? Of course it has a `new Claim` here? 02http://git.io/8moLvg [17:14:13] (03CR) 10Aude: [C: 04-2] "still has stuff like $entity->getClaims() which returns empty array on properties!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170342 (https://bugzilla.wikimedia.org/72671) (owner: 10Aude) [17:14:44] [13ValueView] 15thiemowmde closed pull request #122: Added "language" option to valueview widget (06master...06valueviewlang) 02http://git.io/sFvnog [17:15:56] [13WikibaseDataModel] 15thiemowmde comment on commit 14dd79ac5: That's an odd equals. Only 2 of 4 properties are compared. Why? 02http://git.io/_faUkw [17:16:26] [13WikibaseDataModel] 15thiemowmde comment on commit 14dd79ac5: The order of these parameters is a bit odd. Better move the actual term to the front. 02http://git.io/bMUPrA [17:16:34] [13WikibaseDataModel] 15filbertkm comment on commit 14c637664: wouldn't it be better if a Statement had all the components of a claim, instead of having the Claim?... 02http://git.io/3Et5QA [17:17:37] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14dd79ac5: 2.2.0? 02http://git.io/MRHRGA [17:18:24] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14dd79ac5: It's matching the order of the parent 02http://git.io/FTgGNg [17:19:05] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14dd79ac5: Incorrect. That you missed it does indicate the parent::equals call should be on its own line 02http://git.io/8DWXMw [17:19:06] (03CR) 10Thiemo Mättig (WMDE): "A question, see comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169681 (https://bugzilla.wikimedia.org/68379) (owner: 10Henning Snater) [17:25:48] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14c637664: If we want to optimize `Statement`, I doubt this single object creation is the thing to start with.... 02http://git.io/rEmJ9g [17:28:29] (03Merged) 10jenkins-bot: Fixed fingerprintview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169692 (owner: 10Henning Snater) [17:28:34] (03Merged) 10jenkins-bot: Checking for missing page does not need content object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168831 (owner: 10Aude) [18:10:59] !merge https://github.com/Wikidata-lib/PropertySuggester/pull/107 [18:10:59] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/https://github.com/Wikidata-lib/PropertySuggester/pull/107/ [18:11:05] aude: ^ :D [18:11:35] hoo: good usage of the bot. I approve [18:11:50] lolwat [18:11:57] hoo: scrap that. You failed [18:12:17] It's the bot's fault... clearly :D [18:12:42] JeroenDeDauw: Merge anyway? [18:14:12] hoo: I don't have the permission to do that apparently [18:14:33] hoo: find me a good solution for http://stackoverflow.com/questions/26680909/splitting-php-generators and I'll have a look ;p [18:15:29] :P [18:16:26] 3MediaWiki extensions / 3WikidataClient: Infinite recursion in WikibaseLuaBindings::renumber (leading to OOM) when trying to get Q30 - 10https://bugzilla.wikimedia.org/72242#c2 (10Marius Hoch) 5NEW>3RESO/FIX Looks like Katie's https://github.com/wmde/WikibaseDataModel/commit/05bd532e3ce6f5b9e31259b70acbc... [18:24:26] 3MediaWiki extensions / 3WikidataRepo: Review and tag new version of PropertySuggester - 10https://bugzilla.wikimedia.org/72632#c1 (10Marius Hoch) Would also like to have: https://github.com/Wikidata-lib/PropertySuggester/pull/107 [18:27:09] (03CR) 10Hoo man: [C: 04-1] "I agree with Thiemo" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169681 (https://bugzilla.wikimedia.org/68379) (owner: 10Henning Snater) [18:28:26] (03PS3) 10Hoo man: Use factory class to construct SpecialEntitiesWithoutPage instances [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [18:32:06] (03PS4) 10Hoo man: Use factory class to construct SpecialEntitiesWithoutPage instances [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [18:32:40] (03CR) 10Hoo man: "Fixed EntityPerPage use (has been moved into another NS)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [18:32:51] (03CR) 10Hoo man: [C: 032] "Per Jan on PS2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [18:36:29] class with 3 small methods [18:36:34] 6 incorrect PHPStrom warnings [18:36:36] *sigh* [18:41:06] (03Merged) 10jenkins-bot: Use factory class to construct SpecialEntitiesWithoutPage instances [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [18:42:56] (03CR) 10Hoo man: [C: 032] "Per Daniel: I think we should delete the file... eventually we can later reuse the name for a generic set up file. (Although everything wi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170322 (owner: 10Aude) [18:48:13] (03Merged) 10jenkins-bot: Remove unset( $jenkins_job_name ) from entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170322 (owner: 10Aude) [18:51:14] (03CR) 10Hoo man: [C: 032] "trivial, doesn't break b/c with 0.7.0" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169682 (https://bugzilla.wikimedia.org/63059) (owner: 10Henning Snater) [18:57:02] (03Merged) 10jenkins-bot: Adapt to ValueView 0.8.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169682 (https://bugzilla.wikimedia.org/63059) (owner: 10Henning Snater) [19:00:53] wikimedia/mediawiki-extensions-Wikibase/master/c22391c : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/39629828 [19:01:20] * hoo onoes [19:02:06] hooonoes. Remove the space and that is the best word ever... [19:11:59] (03PS1) 10Hoo man: Add @group medium to WikiPageEntityRevisionLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170377 [19:20:14] (03CR) 10Hoo man: "This requires ValueView 0.8 to be tagged and made use of" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169729 (https://bugzilla.wikimedia.org/66433) (owner: 10Henning Snater) [19:22:22] Gimmeh ALL of the upvotes! http://stackoverflow.com/questions/26680909/splitting-php-generators [19:23:02] * hoo doesn't have an account there [19:24:12] hoo: make one then you lazy person! [19:24:45] JeroenDeDauw: I want to make an account just to downvote [19:28:19] (03PS2) 10Hoo man: Refactor ClientHooks::onBeforePageDisplayAddJsConfig [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169674 (owner: 10Thiemo Mättig (WMDE)) [19:32:56] (03CR) 10Hoo man: [C: 032] Refactor ClientHooks::onBeforePageDisplayAddJsConfig [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169674 (owner: 10Thiemo Mättig (WMDE)) [19:38:40] that's why python has yield from [19:38:59] (03Merged) 10jenkins-bot: Refactor ClientHooks::onBeforePageDisplayAddJsConfig [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169674 (owner: 10Thiemo Mättig (WMDE)) [19:40:39] (03CR) 10Hoo man: "With dir="" this does not even work, will amend." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167409 (owner: 10Ebrahim) [19:43:18] (03PS3) 10Hoo man: Remove extra dir=auto to fix directionallity problem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167409 (owner: 10Ebrahim) [19:44:30] (03CR) 10Hoo man: "@Ebrahim: Is this (my new patch set) ok with you? It seems to work fine, but I'm not an rtl expert." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167409 (owner: 10Ebrahim)