[00:26:55] (03PS1) 10Hoo man: Include property data types in Lua output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169973 [00:30:31] (03PS2) 10Hoo man: Include property data types in Lua entity output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169973 [00:31:37] 1:30 oO [00:31:40] damn :D [00:31:44] * hoo calls it a day [01:13:15] 3MediaWiki extensions / 3WikidataClient: Create Wikidata API module that is queryable from the local wiki - 10https://bugzilla.wikimedia.org/72729 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Extend MediaWiki API Query module to support basic Wikidata data retrieval locally. This would... [08:06:28] (03PS1) 10Henning Snater: snakview: Re-set previous snak value when toggling the snak type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169997 [08:07:44] 3MediaWiki extensions / 3WikidataRepo: Value gets lost when setting the snak type - 10https://bugzilla.wikimedia.org/67380#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/169997/ [09:01:25] (03PS8) 10Henning Snater: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [09:09:49] (03PS9) 10Henning Snater: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [09:12:27] (03CR) 10Henning Snater: [C: 031] Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [09:14:56] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/10/30 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169998 [09:17:23] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/E3myQg [09:17:23] 13WikidataBrowserTests/06master 1420d50df 15Tobias Gritschacher: Update Gemfile.lock [09:23:13] (03PS6) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [09:35:47] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/10/30 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169998 (owner: 10Tobias Gritschacher) [09:37:53] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/10/30 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169998 (owner: 10Tobias Gritschacher) [09:51:27] 3MediaWiki extensions / 3WikidataRepo: ChangeOpClaim using obsolete Entity::setClaims causes stack trace when adding statement on Property page - 10https://bugzilla.wikimedia.org/72671 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major [09:51:28] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10tobias.gritschacher) [10:02:36] 3MediaWiki extensions / 3WikidataRepo: disable enter key for entity selector in searchbox - 10https://bugzilla.wikimedia.org/53476#c12 (10Thiemo Mättig) Oh wow, this is complicated. I finally understood what Lydia and you expect. The problem is, this can't and will never work, at least not so easily. In Wiki... [10:03:42] 3MediaWiki extensions / 3WikidataRepo: Floating toolbar for edit-sections - 10https://bugzilla.wikimedia.org/72022#c3 (10tobias.gritschacher) We decided to not implement the sticky notification bar yet (would only make sense together with the layout change) and re-position the existing notification bubble in... [10:04:02] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) [10:04:14] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) 5ASSI>3NEW [10:04:33] 3MediaWiki extensions / 3WikidataRepo: UI: Create specifications for sticky notification bar - 10https://bugzilla.wikimedia.org/72614 (10tobias.gritschacher) 5ASSI>3NEW [10:05:43] 3MediaWiki extensions / 3WikidataRepo: Adapt notifications to work with floating toolbars - 10https://bugzilla.wikimedia.org/72755 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [10:05:43] 3MediaWiki extensions / 3WikidataRepo: Adapt notifications to work with floating toolbars - 10https://bugzilla.wikimedia.org/72755 (10tobias.gritschacher) [10:05:44] 3MediaWiki extensions / 3WikidataRepo: Floating toolbar for edit-sections - 10https://bugzilla.wikimedia.org/72022 (10tobias.gritschacher) [10:09:37] (03CR) 10Henning Snater: [C: 04-1] "Excuse me for reverting the +1. The tests showed that key handling is broken, i.e. hitting the ESC key on a pending, completely new statem" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [10:14:46] 3MediaWiki extensions / 3WikidataRepo: Update Wikibase to use version 1.0 of DM-JS and Serialization-JS - 10https://bugzilla.wikimedia.org/72757 (10tobias.gritschacher) p:5Unprio>3High [10:15:45] 3MediaWiki extensions / 3WikidataRepo: Update Wikibase to use version 1.0 of DM-JS and Serialization-JS - 10https://bugzilla.wikimedia.org/72757 (10tobias.gritschacher) 5NEW>3ASSI [10:16:00] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10tobias.gritschacher) [10:43:29] Henning_WMDE: http://wikidata.beta.wmflabs.org/wiki/Q24426?debug=true [10:58:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make getLocationAgnosticMwApi work if both APIs are on the same domain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [11:01:46] [13WikibaseDatabase] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/GOylPA [11:01:47] 13WikibaseDatabase/06master 14f729df0 15thiemowmde: Merge pull request #56 from wmde/mv... [11:03:26] [13WikibaseDatabase] 15thiemowmde comment on pull request #57 14b46ed9d: `use Wikibase\Database\QueryInterface;`, right? 02http://git.io/bifOsQ [11:03:50] (03Merged) 10jenkins-bot: Make getLocationAgnosticMwApi work if both APIs are on the same domain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [11:05:02] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/CzCxow [11:05:02] 13WikibaseQueryEngine/06master 14a873185 15thiemowmde: Merge pull request #133 from wmde/rdc... [11:25:29] 3Wikimedia / 3Wikidata: Wrong info on Special:Version - 10https://bugzilla.wikimedia.org/72759 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The wrong version of the wikidata build is shown on https://test.wikidata.org/wiki/Special:Version and https://www.wikidata.org/wiki/Special... [11:25:43] 3Wikimedia / 3Wikidata: Wrong info on Special:Version - 10https://bugzilla.wikimedia.org/72759 (10tobias.gritschacher) p:5Unprio>3Normal [11:35:19] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #17 144a00760: Tags should be sorted alphabetically. 02http://git.io/lvETvg [11:43:20] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #17 144a00760: I think this could be done something like this:... 02http://git.io/WyXyYQ [11:44:08] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #17 144a00760: I think this could be done something like this:... 02http://git.io/128Xdw [11:56:44] [13WikibaseQuery] 15thiemowmde 04force-pushed 06dm20again from 141ea7661 to 14a1fc2c6: 02http://git.io/q-MPDA [11:56:45] 13WikibaseQuery/06dm20again 14a1fc2c6 15Thiemo Mättig: Fix composer update [11:57:23] [13WikibaseQuery] 15thiemowmde 04deleted 06scrutinizer at 147ae9947: 02http://git.io/NeDw2A [11:58:30] [13WikidataBrowserTests] 15zeljkofilipin created 06rubocop (+1 new commit): 02http://git.io/gdWQNA [11:58:30] 13WikidataBrowserTests/06rubocop 14f9773f0 15Željko Filipin: Fixed Lint/BlockAlignment RuboCop offense... [11:59:21] [13WikidataBrowserTests] 15zeljkofilipin opened pull request #18: Fixed Lint/BlockAlignment RuboCop offense (06master...06rubocop) 02http://git.io/AnF6bA [12:01:47] [13WikidataBrowserTests] 15zeljkofilipin pushed 1 new commit to 06rubocop: 02http://git.io/XnzjPw [12:01:47] 13WikidataBrowserTests/06rubocop 141d4e54d 15Željko Filipin: Fixed Lint/DeprecatedClassMethods RuboCop offense... [12:03:31] [13WikidataBrowserTests] 15tobijat created 06rubocop_travis (+1 new commit): 02http://git.io/p-1Utw [12:03:31] 13WikidataBrowserTests/06rubocop_travis 14cd531a7 15Tobias Gritschacher: Run Rubocop on Travis [12:04:35] [13WikidataBrowserTests] 15tobijat opened pull request #19: Run Rubocop on Travis (06master...06rubocop_travis) 02http://git.io/tk00Bw [12:05:58] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration from 14ddbf6a6 to 14045f2f8: 02http://git.io/bcVHHg [12:05:58] 13WikibaseQueryEngine/06dvintegration 14045f2f8 15Thiemo Mättig: BooleanHandlerIntegrationTest [12:09:37] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop_travis: 02http://git.io/2q19rA [12:09:37] 13WikidataBrowserTests/06rubocop_travis 1430782b2 15Tobias Gritschacher: Trigger TravisCI [12:12:56] Henning_WMDE: Site links, clicking save, getting an error, again clicking save does not work [12:13:43] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/K87L5A [12:13:43] 13WikibaseQueryEngine/06master 147dc9405 15thiemowmde: Merge pull request #134 from wmde/entitydocument... [12:16:57] [13WikidataBrowserTests] 15zeljkofilipin closed pull request #19: Run Rubocop on Travis (06master...06rubocop_travis) 02http://git.io/tk00Bw [12:17:15] [13WikidataBrowserTests] 15zeljkofilipin 04deleted 06rubocop_travis at 1430782b2: 02http://git.io/kLa17A [12:17:46] (03PS1) 10Henning Snater: Renamed template function name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 [12:18:05] aude: Tobi_WMDE_SW ^ [12:18:31] aude: jzerebecki Yesterday Hoo made us panic for no good reason. The classmap autoloader (which is the one used when optimizing the autoloading), does not double load [12:18:33] https://github.com/JeroenDeDauw/DoubleLoad [12:19:20] Which of course does not mean we should not push for a better way to deploy our stuff [12:20:52] (03CR) 10Aude: Renamed template function name (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 (owner: 10Henning Snater) [12:22:11] [13WikidataBrowserTests] 15zeljkofilipin pushed 1 new commit to 06rubocop: 02http://git.io/THWZwA [12:22:11] 13WikidataBrowserTests/06rubocop 140185052 15Željko Filipin: Fixed Lint/UnusedBlockArgument RuboCop offense... [12:28:08] (03CR) 10Henning Snater: Renamed template function name (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 (owner: 10Henning Snater) [12:33:02] (03CR) 10Aude: "looks ok to me, at a glance." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 (owner: 10Henning Snater) [12:36:29] 3MediaWiki extensions / 3WikidataRepo: Update Wikibase to use version 1.0 of DM-JS and Serialization-JS - 10https://bugzilla.wikimedia.org/72757 (10tobias.gritschacher) [12:36:42] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10tobias.gritschacher) 5PATC>3RESO/FIX [12:41:10] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/pSZ_bQ [12:41:10] 13WikidataBrowserTests/06rubocop 1475a8e6f 15Tobias Gritschacher: Merge branch 'master' into rubocop [12:44:05] (03CR) 10Adrian Lang: [C: 032] "Necessary for compat with core master." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 (owner: 10Henning Snater) [12:50:24] (03Merged) 10jenkins-bot: Renamed template function name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 (owner: 10Henning Snater) [12:52:01] (03PS7) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [12:55:39] (03PS8) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [12:58:12] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10Adrian Lang) [12:58:13] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10Adrian Lang) [12:58:27] 3MediaWiki extensions / 3WikidataRepo: Make statement view use claimview instead of inherit - 10https://bugzilla.wikimedia.org/72312 (10Adrian Lang) [12:58:43] 3MediaWiki extensions / 3WikidataRepo: Update Wikibase to use version 1.0 of DM-JS and Serialization-JS - 10https://bugzilla.wikimedia.org/72757 (10Adrian Lang) [12:59:12] 3MediaWiki extensions / 3WikidataRepo: Make statement view use claimview instead of inherit - 10https://bugzilla.wikimedia.org/72312 (10Adrian Lang) [13:00:43] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169 (10tobias.gritschacher) 5ASSI>3RESO/FIX [13:01:29] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169#c3 (10tobias.gritschacher) https://gerrit.wikimedia.org/r/169330 [13:07:55] (03PS1) 10Henning Snater: Initialize copyright tooltip on toolbar container [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170020 [13:09:02] (03PS9) 10Henning Snater: Implemented jquery.sticknode plugin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167193 [13:09:41] 3MediaWiki extensions / 3WikidataRepo: Adapt notifications to work with floating toolbars - 10https://bugzilla.wikimedia.org/72755#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/170020/ [13:11:53] (03CR) 10Tobias Gritschacher: "oh, Adrian was faster.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170008 (owner: 10Henning Snater) [13:20:38] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/pEHLzg [13:20:38] 13WikidataBrowserTests/06rubocop 145779e25 15Tobias Gritschacher: Refcator single line while loop [13:25:28] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/N3K3ew [13:25:28] 13WikidataBrowserTests/06rubocop 1412ecc23 15Tobias Gritschacher: Use && instead of 'and' [13:27:30] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/hZxSpQ [13:27:30] 13WikidataBrowserTests/06rubocop 14842a647 15Tobias Gritschacher: Use only ASCII chars in comments [13:29:24] (03PS10) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [13:30:09] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [13:42:16] (03CR) 10Henning Snater: "Personally, I regard the self-closing style looking more sane--in the end, we are not developing for particular IDEs. Practically, there i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167175 (owner: 10Thiemo Mättig (WMDE)) [13:42:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Cool, love it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169997 (owner: 10Henning Snater) [13:48:02] (03Merged) 10jenkins-bot: snakview: Re-set previous snak value when toggling the snak type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169997 (owner: 10Henning Snater) [13:48:43] (03PS11) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [13:49:16] (03CR) 10Adrian Lang: "Should fix the issue described by Henning." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [13:50:40] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/btrI3g [13:50:40] 13WikidataBrowserTests/06rubocop 142c5fd65 15Tobias Gritschacher: Remove bracktes for methods that don't have parameters [13:50:56] 3MediaWiki extensions / 3WikidataRepo: Value gets lost when setting the snak type - 10https://bugzilla.wikimedia.org/67380 (10Henning) 5PATC>3RESO/FIX [13:52:21] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/M_4E2A [13:52:21] 13WikidataBrowserTests/06rubocop 140899f98 15Tobias Gritschacher: Remove empty lines around body [13:52:45] Thiemo_WMDE: jzerebecki: we would not be running into this again and again if we could work against stable versions of MW and WB.git [13:53:42] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/4KGNZw [13:53:42] 13WikidataBrowserTests/06rubocop 147a6eda6 15Tobias Gritschacher: Use literals [13:57:49] (03PS2) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [13:57:51] (03PS6) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [13:57:56] (03CR) 10jenkins-bot: [V: 04-1] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [13:58:01] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [13:58:58] 3Wikimedia / 3Wikidata: integrate wikidata (composer) built with mediawiki/vendor - 10https://bugzilla.wikimedia.org/72703#c1 (10Jan Zerebecki) Oops we yesterday in all the discussions forgot that the autoloader does not try to load a class again that is already loaded. And the next autoloader is only tried... [13:59:36] (03PS3) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [13:59:38] (03PS7) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [13:59:40] (03PS12) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [13:59:55] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/zriRvw [13:59:55] 13WikidataBrowserTests/06rubocop 1405e9efc 15Tobias Gritschacher: Fix intendation and whitespaces [14:00:30] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [14:00:31] Thiemo_WMDE: that would only delay the integration (failure) [14:00:43] err that was for JeroenDeDauw [14:01:36] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06mvc: 02http://git.io/7n4NGQ [14:01:36] 13WikibaseDatabase/06mvc 1423f97bf 15Jeroen De Dauw: Update MediaWikiQueryInterface.php [14:01:48] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #57 1423f97bf: Added 02http://git.io/4vZ0HQ [14:02:38] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/Oi7Q8g [14:02:38] 13WikidataBrowserTests/06rubocop 140b16a38 15Tobias Gritschacher: Use correct hash syntax [14:03:58] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/SuglEw [14:03:58] 13WikidataBrowserTests/06rubocop 147698261 15Tobias Gritschacher: Add missing parentheses for method with parameters [14:05:07] (03CR) 10jenkins-bot: [V: 04-1] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [14:05:13] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [14:05:18] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/IORq2w [14:05:18] 13WikidataBrowserTests/06rubocop 145a3b5b4 15Tobias Gritschacher: Use 'unless' instead of negated if [14:06:09] jzerebecki: this indeed does not remove the need to update your code. It however allows you to do so when this suits you, rather then being forced to do it when you want to make some unrelated change [14:06:19] Kinda surprised you provide that argument [14:07:14] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rubocop: 02http://git.io/YzfPGA [14:07:14] 13WikidataBrowserTests/06rubocop 14759817d 15Tobias Gritschacher: Remove redundant return and self statements [14:10:52] (03PS1) 10Hoo man: Run composer install for core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170028 [14:10:55] aude: ^ [14:11:04] FIIIiiiiiiiiiiiiixxxx traviss!!!!! :D [14:11:36] huh [14:11:47] if you're ok, I'll do the same for the other components needing MW [14:11:48] not that again :P [14:11:56] aude: see https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/39490942 :P [14:11:59] * aude got them to fix it for jenkins [14:12:02] :D [14:12:25] hurray we don't maintain our own jenkins but we do maintain our own travis :/ [14:12:50] (03CR) 10Aude: [C: 032] Run composer install for core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170028 (owner: 10Hoo man) [14:12:52] Yeah :/ [14:13:04] But it's fairly trivial to keep it [14:13:06] going [14:13:11] sure [14:13:22] so not a huge problem [14:13:59] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/KnksFg [14:13:59] 13WikidataBrowserTests/06master 14d76dda5 15Tobi Gritschacher: Merge pull request #18 from wmde/rubocop... [14:14:26] [13WikidataBrowserTests] 15tobijat 04deleted 06rubocop at 14759817d: 02http://git.io/J-IHqw [14:16:22] [13WikidataBrowserTests] 15tobijat comment on pull request #17 144a00760: will do that in a separate change as it is wrong in all files. 02http://git.io/6JtcWw [14:17:51] [13WikibaseDatabase] 15thiemowmde comment on pull request #57 1423f97bf: Erm, not add, just fix the broken line. `Wikibase\Database\Exception` doesn't exist. 02https://github.com/wmde/WikibaseDatabase/pull/57#discussion_r19606956 [14:18:59] (03Merged) 10jenkins-bot: Run composer install for core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170028 (owner: 10Hoo man) [14:19:45] JeroenDeDauw: for depeloping I would not argue (i.e. before continous integration runs, before review), but during ci it means if you were to defer testing with the new core that might contain breaking changes, it means hiding the fact that you are not in deployable state. i provide that argument, because I was mainly thinking from the view of deploying the whole wikimedia stack. a better way would be to detect the problem even earlier before the [14:20:56] so poeple who introduce breaking changes were encouraged to fix the breakage before their change is merged or at least in near sync. [14:21:04] 161 161 » » } [14:22:04] (03CR) 10Aude: [C: 032] Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169712 (owner: 10Aude) [14:24:14] [13WikidataBrowserTests] 15tobijat comment on pull request #17 144a00760: That does not work:... 02http://git.io/b6VyJg [14:24:24] [13WikibaseQuery] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/ma9LUg [14:24:24] 13WikibaseQuery/06master 14b247154 15Marius Hoch: Fix MediaWiki install on travis [14:24:56] [13WikidataBrowserTests] 15tobijat comment on pull request #17 144a00760: it is probably a different syntax. but I'll figure that out in a separate change. 02http://git.io/0QkDXw [14:25:06] [13WikidataBrowserTests] 15tobijat comment on pull request #17 144a00760: see comment above 02http://git.io/cfauag [14:27:10] (03Merged) 10jenkins-bot: Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169712 (owner: 10Aude) [14:28:46] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/10/30 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170034 [14:31:53] (03PS1) 10Aude: Update Wikidata, fix aliases edit button [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170036 [14:31:56] hope I got all components [14:32:22] ? [14:32:26] only Wikibase Query? [14:32:41] apparently [14:32:44] not sure [14:32:48] ok [14:32:50] there's also stuff in the builder [14:33:02] we will find out if there is something else [14:33:38] yep :D [14:33:50] it's not running for https://travis-ci.org/wikimedia/mediawiki-extensions-Wikidata [14:34:05] even though there is a .travis.yml file [14:34:26] needs to be activated by someone with admin on wikimedia [14:34:28] * hoo is not [14:34:29] yep [14:34:33] I think JeroenDeDauw can do that [14:35:59] Tobi_WMDE_SW: Did you see the failing tests? [14:36:08] Adrian_WMDE: I do [14:36:10] (03CR) 10Aude: [C: 032] Update Wikidata, fix aliases edit button [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170036 (owner: 10Aude) [14:36:17] Tobi_WMDE_SW: unable to locate element, using {:css=>"div.wb-claim-mainsnak input.ui-entityselector-input", :tag_name=>"input or textarea", :type=>"(any text type)"} (Watir::Exception::UnknownObjectException) [14:36:30] unable to locate element, using {:css=>"div.wikibase-aliasesview span.wikibase-toolbar-button-save:not(.wikibase-toolbarbutton-disabled) > a"} (Watir::Exception::UnknownObjectException) [14:37:38] Could that be a hiccup? [14:37:52] Browser tests ran fine for me in the last days [14:37:56] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration from 14045f2f8 to 14c4f7b45: 02http://git.io/bcVHHg [14:37:56] 13WikibaseQueryEngine/06dvintegration 14c4f7b45 15Thiemo Mättig: BooleanHandlerIntegrationTest [14:38:05] (03Merged) 10jenkins-bot: Update Wikidata, fix aliases edit button [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/170036 (owner: 10Aude) [14:38:21] aude: deploy today? [14:38:30] swat, yes [14:38:35] I see [14:38:44] probably not going to be around later on [14:38:51] Adrian_WMDE: checking.. [14:38:53] clicking "add" for aliases takes you to the special page, since js is not initialized [14:38:58] if there are no aliases [14:38:59] :S [14:39:02] what [14:39:12] I think I only used that on Wikidata like yesterday [14:39:22] might be that I'm misremembering [14:39:29] hoo:? [14:39:31] It's basically a PHP issue, though :P [14:39:31] only on test.wikidata [14:39:49] ah ok, nevermind, then [14:40:27] ok... would need parser cache purge [14:40:34] Yeah [14:40:34] but it's not on WD so should be fine [14:40:41] No, it's not [14:40:49] The old HTML is still there [14:41:02] JS just stopped gracefully handling it [14:41:08] but it's only an issue on test, right? [14:41:21] But the HTML is on production, too [14:41:22] yep [14:41:27] :S [14:41:43] So... cache epoch bump needed? That's ugly... [14:41:44] (03PS1) 10Henning Snater: Added snakview.variations.Value.start/stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170038 [14:41:49] Adrian_WMDE: issue with the tests is that there is a broken version deployed on beta [14:41:51] no not [14:41:58] we bump on tuesday [14:42:00] not compatible with core [14:42:08] the mw.template thing [14:42:10] Yeah [14:42:12] aude: But does the fix is not yet out, right? [14:42:14] I'll merge the new build [14:42:17] So the new caches aren't good either [14:42:20] Tobi_WMDE_SW: Thanks [14:42:30] * newly cached entities [14:42:30] the swat thing... people can purge pages on test.wikidata [14:42:37] good enough imho [14:42:55] ok, might work [14:42:56] 3MediaWiki extensions / 3WikidataRepo: snakview.variations.Value.draw() does not specify dropValue parameter of jQuery.valueview.stopEditing() - 10https://bugzilla.wikimedia.org/70337#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/170038/ [14:43:04] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/10/30 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170034 (owner: 10Tobias Gritschacher) [14:43:11] do we have parser cache hit/ miss statistics, btw? [14:43:18] where? [14:43:22] where do we see those [14:43:34] If I knew that, I wouldn't ask :P [14:43:59] would be nice to know [14:44:19] from clicking random, seems we have a lot of items that nobody looks at :/ [14:44:36] since they worked on tuesday w/o cache bump [14:45:08] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/10/30 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/170034 (owner: 10Tobias Gritschacher) [14:45:10] Yeah, that's because of high language fragmentation [14:45:38] yep, and soooooo many items [14:45:41] I even wonder whether it's worth to cache in say languages not in the top 20 [14:45:52] (I mean not in the top 20 used languages) [14:45:55] for more popular items, maybe [14:46:32] would be nice to know [14:46:47] I guess we could add a debug log for that including language and hit/miss? [14:46:51] * hoo really curious [14:47:04] probbly [14:47:07] probably* [14:48:39] Adrian_WMDE: ok, build is merged. not sure how long until it is deployed [14:49:03] will be at tonight's SWAT [14:49:11] if I understood aude correctls [14:49:27] Tobi_WMDE_SW: Thanks [14:49:32] hoo: ? [14:49:35] it's in 10 minutes [14:49:37] hoo: do you mean me? no, I'm talking about beta..;) [14:49:49] oh right [14:50:00] thought we missed the early swat by an hour [14:50:05] but well, time zones... [14:55:47] * hoo leaving [14:55:49] cu tomorrow [14:55:56] ok [15:07:53] aude: we broke the gadget again it seems.. http://wikidata.beta.wmflabs.org/wiki/Q12480 [15:08:04] already [15:08:09] :) [15:08:28] aude: oh, ok [15:08:30] wait [15:08:39] no, it seems to work after a reload [15:08:40] Tobi_WMDE_SW: that has to be the Wikidata Development Team motto - 'We broke the gadgets... again...' :p [15:08:54] hm.. sometimes it doesnt but after a reload [15:09:07] aude: could it be caching? [15:09:15] that's odd [15:09:34] aude: probably it's my local cahe [15:09:37] *cache [15:09:42] no, i can reproduce [15:09:48] aude: ok [15:10:28] * aude also notes https://bugzilla.wikimedia.org/show_bug.cgi?id=72691 which affects aliases [15:10:41] something i noticed on test.wikidata [15:11:08] oh, on wikidata also [15:11:25] aude: I think that isn't working for longer [15:11:33] perhaps [15:11:36] nothing new [15:11:37] is a nuisance [15:11:45] not horrible broken though [15:12:18] for the gadget, it might be the order / speed things are loaded [15:12:36] maybe a there is some additional dependency that needs to be specified [15:12:47] hm [15:12:50] might be [15:12:57] or http://wikidata.beta.wmflabs.org/wiki/MediaWiki:Gadget-AuthorityControl.js [15:13:11] initialization code [15:13:12] I can remember Thiemo_WMDE having a similar problem some time ago where sometimes an old version of the gadget got loaded [15:13:20] if ( mw.loader.getState( 'wikibase.ui.entityViewInit' ) === 'ready' && $( '.wb-entity-spinner' ).length === 0 ) { [15:13:46] i doubt that is the problem [15:14:34] in debug mode it works [15:15:56] aude: in any case we need the tests for the gadget, I'm merging them now after zeljkof reviewed them today [15:16:05] ok [15:16:22] [13WikidataBrowserTests] 15tobijat 04deleted 06authoritycontrol at 144a00760: 02http://git.io/QxGrEw [15:17:19] (03PS1) 10Henning Snater: Added missing message to jquery.wikibase.linkitem resource module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170047 [15:26:45] (03CR) 10Hoo man: [C: 032] "Trivial change is trivial" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170047 (owner: 10Henning Snater) [15:32:09] (03Merged) 10jenkins-bot: Added missing message to jquery.wikibase.linkitem resource module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170047 (owner: 10Henning Snater) [15:32:57] 3MediaWiki extensions / 3WikidataClient: Missing text for interwiki link error message: "Error $1" - 10https://bugzilla.wikimedia.org/71751#c4 (10Henning) 5UNCO>3RESO/FIX Trying to link a page twice results in a proper notification. That appears not to have caused the error. However, scanning through th... [15:35:19] (03CR) 10Aude: [C: 032] Include property data types in Lua entity output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169973 (owner: 10Hoo man) [15:36:53] jzerebecki: Thanks (qunit, jenkins) [15:37:21] Adrian_WMDE: you are welcome [15:39:13] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) 5PATC>3RESO/FIX [15:39:56] (03PS8) 10Tobias Gritschacher: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [15:41:01] (03Merged) 10jenkins-bot: Include property data types in Lua entity output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169973 (owner: 10Hoo man) [15:41:44] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (https://bugzilla.wikimedia.org/72757) (owner: 10Adrian Lang) [15:43:16] (03PS6) 10Aude: Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 [15:43:28] (03CR) 10Aude: "rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [15:46:49] (03CR) 10jenkins-bot: [V: 04-1] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [15:58:19] (03CR) 10Tobias Gritschacher: [C: 04-1] "Wrong behavior:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [16:13:22] (03PS1) 10Henning Snater: Applied case-insensitivity to snakview property selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170064 [16:14:11] 3MediaWiki extensions / 3WikidataRepo: snakview always overwrites property label in edit mode - 10https://bugzilla.wikimedia.org/72622#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/170064/ [16:15:13] 3MediaWiki extensions / 3WikidataRepo: Suggester is case-sensitive but shouldn't - 10https://bugzilla.wikimedia.org/66715#c2 (10Henning) 5NEW>3PATC Should directly be fixed along with https://gerrit.wikimedia.org/r/#/c/170064/. [16:18:23] (03PS1) 10Adrian Lang: Clean up API-based parsing code in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170068 [16:18:25] (03PS1) 10Adrian Lang: Move datavalue parsing to ApiBasedValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170069 [16:29:31] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Manually tested. Works as expected." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168565 (owner: 10Henning Snater) [16:37:06] (03Merged) 10jenkins-bot: sitelinkgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168565 (owner: 10Henning Snater) [19:41:26] DanielK_WMDE: https://gerrit.wikimedia.org/r/170129 :) [19:41:31] We're nearly there, finally! [21:25:00] legoktm: How long does the logo needs to stay? [21:25:20] forever ^.^ [21:26:07] I think last year I removed it on Nov 1st [21:26:46] https://www.wikidata.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=83018812 [21:27:03] hm [21:41:10] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06mvc: 02http://git.io/cOcfOQ [21:41:10] 13WikibaseDatabase/06mvc 143ffc995 15Jeroen De Dauw: Update MediaWikiQueryInterface.php [21:41:30] [13WikibaseDatabase] 15JeroenDeDauw comment on pull request #57 143ffc995: ugh wtf... 02http://git.io/g_ftBQ [21:55:40] [13WikibaseQueryEngine] 15JanZerebecki closed pull request #132: Add PSR-3 logger interface (06master...06logger) 02http://git.io/Fe8NRA [22:04:21] Can anybody please block https://www.wikidata.org/wiki/Special:Contributions/John95541234 ? [22:07:33] * legoktm looks [22:08:03] week+ old vandalism - not really worth it. [22:08:16] aharoni: blocked. [22:15:54] legoktm: thanks