[01:31:46] uhhh [01:31:58] Lydia_WMDE: it's Oct 29 UTC? [01:35:15] legoktm: i will do it tomorrow morning sf time [01:35:23] that's good enough [01:35:26] ok [01:35:31] also the text isn't finished :D [01:35:42] I just had a commons admin protect it, so it's ready to go whenever :) [01:35:50] cool [03:07:17] test [07:30:56] [13ValueView] 15snaterlicious 04force-pushed 06highlightsubstring from 148dba504 to 14d6c5549: 02http://git.io/mU9Row [07:30:56] 13ValueView/06highlightsubstring 14d6c5549 15snaterlicious: Replaced $.util.highlightMatchingCharacters with util.highlightSubstring [07:47:53] 3MediaWiki extensions / 3WikidataRepo: Trim spaces around statements of string type - 10https://bugzilla.wikimedia.org/45925#c4 (10Henning) At the time of writing, the current behaviour seems to be: When a value with a leading space character is submitted, the back-end parser will return a "malformed input"... [08:29:40] 3MediaWiki extensions / 3WikidataClient: 0 padding on years when formatting dates - 10https://bugzilla.wikimedia.org/72662 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs the item https://www.wikidata.org/wiki/Q975291 has the date 28 February 256 Gregorian. when used on German Wikipedia, the date... [08:33:08] 3MediaWiki extensions / 3WikidataClient: 0 padding on years when formatting dates - 10https://bugzilla.wikimedia.org/72662#c1 (10Aude) here is the value and the lua #invoke in the sandbox: https://www.wikidata.org/wiki/Q4115189 https://de.wikipedia.org/wiki/Wikipedia:Wikidata/Wikidata_Spielwiese same issu... [08:47:38] 3MediaWiki extensions / 3WikidataRepo: wbformatvalue called twice when creating statement - 10https://bugzilla.wikimedia.org/71100#c2 (10Henning) Investigated on that: The problem occurs only when adding a new statement via the "global" "add" button--in contrast to adding a statement to an existing statement... [08:59:54] 3MediaWiki extensions / 3WikidataRepo: Possibility to enter new sitelink instantly when editing sitelink-section - 10https://bugzilla.wikimedia.org/72023 (10tobias.gritschacher) [09:02:09] 3MediaWiki extensions / 3WikidataRepo: Browsertests: Adjust/write new tests for dynamic input elements for sitelinks - 10https://bugzilla.wikimedia.org/72663 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [09:02:23] 3MediaWiki extensions / 3WikidataRepo: Possibility to enter new sitelink instantly when editing sitelink-section - 10https://bugzilla.wikimedia.org/72023 (10tobias.gritschacher) [09:04:08] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) [09:04:24] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251 (10tobias.gritschacher) 5NEW>3ASSI [09:05:40] 3MediaWiki extensions / 3WikidataRepo: Browsertests for statements on properties - 10https://bugzilla.wikimedia.org/72664 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Some basic smoketests to check that statements on properties work. [09:06:09] 3MediaWiki extensions / 3WikidataRepo: Browsertests for statements on properties - 10https://bugzilla.wikimedia.org/72664 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [09:12:54] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10tobias.gritschacher) 5NEW>3ASSI [09:13:49] Adrian_WMDE: did you already create a task for "unifying view implementations" you mentioned yesterday? if not, can you please create one? [09:14:22] we decided to not pick it up this sprint, but if you have time you can always start working on it [09:17:24] 3MediaWiki extensions / 3WikidataRepo: Unify view-implementations in JS frontend - 10https://bugzilla.wikimedia.org/72666 (10tobias.gritschacher) p:5Unprio>3Normal [09:33:12] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06fingerprint: 02http://git.io/G_YlIg [09:33:12] 13WikibaseDataModelJavaScript/06fingerprint 14608a661 15snaterlicious: Re-instantiated EntityId [09:38:14] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "This was meant as a draft/discussion item. I would love to hear the opinion of the rest of the team members." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167175 (owner: 10Thiemo Mättig (WMDE)) [09:39:33] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/10/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169663 [09:40:17] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06multilingualunserializer: 02http://git.io/zzdYoA [09:40:17] 13WikibaseSerializationJavaScript/06multilingualunserializer 141da3523 15snaterlicious: Removed unnecessary EntityIdSerializer/Deserializer [10:21:12] [13ValueView] 15snaterlicious created 06valueviewlang (+1 new commit): 02http://git.io/G3CyvQ [10:21:12] 13ValueView/06valueviewlang 1414faeb5 15snaterlicious: Added "language" option to valueview widget [10:22:45] [13ValueView] 15snaterlicious opened pull request #122: Added "language" option to valueview widget (06master...06valueviewlang) 02http://git.io/sFvnog [10:28:52] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf6/0cbf92e : Ebrahim Byagowi The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/39364930 [10:33:10] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06grunt: 02http://git.io/_Zruew [10:33:10] 13WikidataBuildResources/06grunt 145ac8965 15Katie Filbert: Add details to readme about deployment config generated... [10:34:46] (03PS1) 10Aude: New deployment build - wmf/1.25wmf6 [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169668 [10:37:35] * aude is going to merge https://github.com/wmde/WikidataBuildResources/pull/9 today if no one wants to review it [10:38:17] everything there has worked great for more than month now [10:40:38] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059#c2 (10Henning) https://github.com/wmde/ValueView/pull/122 ^ Requires adaption in Wikibase. [10:41:18] aude: :) [10:41:28] [13WikidataBuildResources] 15tobijat 04deleted 06grunt at 145ac8965: 02http://git.io/f3YqdA [10:41:33] yay! :D [10:41:44] I've just missed it [10:44:51] stuff is hiding on github [10:45:19] it would have been bad for someone to use master of that, since it doesn't do all the settings [10:45:28] now it's good [10:59:44] (03PS1) 10Henning Snater: Use back-end parser for "commons" and "url" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169672 [11:00:23] 3MediaWiki extensions / 3WikidataRepo: Use backend parser for commons - 10https://bugzilla.wikimedia.org/62193#c3 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/169672/ [11:00:38] 3MediaWiki extensions / 3WikidataRepo: Use backend parser for URL - 10https://bugzilla.wikimedia.org/62192#c3 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/169672/ [11:05:25] Hi, maybe you answered this question for hundred times, but it seems to me that I have problem link entry on Commons with Wikidata. E.g. when I try to add interwiki on Commons to the entry [[:commons:Category:Strašínská jeskyně]] (link to [[cs:wiki:Strašínská jeskyně]] nothing happened. Does somebody know why? It normally works for months... [11:06:10] hm, no active bot here, so https://commons.wikimedia.org/wiki/Category:Strašínská_jeskyně and https://cs.wikipedia.org/wiki/Stra%C5%A1%C3%ADnsk%C3%A1_jeskyn%C4%9B [11:11:56] (03PS3) 10Thiemo Mättig (WMDE): Always show link to wikibase item in toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) (owner: 10Hoo man) [11:11:58] (03PS1) 10Thiemo Mättig (WMDE): Refactor ClientHooks::onBeforePageDisplayAddJsConfig [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169674 [11:22:57] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Confirmed, works. Not sure how to add a unit test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) (owner: 10Hoo man) [11:28:07] (03Merged) 10jenkins-bot: Always show link to wikibase item in toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) (owner: 10Hoo man) [11:29:45] aaaaah, i can't purge https://vi.wikipedia.org/wiki/Venezia [11:30:34] something about sites ... [11:31:55] 3MediaWiki extensions / 3WikidataClient: Fatal error: Site::unserialize() [site.unserialize]: Nesting level too deep - 10https://bugzilla.wikimedia.org/72670 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs because of this, i can't purge the page Fatal error: Site::u... [11:32:07] 3MediaWiki extensions / 3WikidataClient: Fatal error: Site::unserialize() [site.unserialize]: Nesting level too deep - 10https://bugzilla.wikimedia.org/72670 (10Aude) p:5Unprio>3High s:5normal>3critic [11:38:23] 3MediaWiki extensions / 3WikidataClient: "Data item" link in sidebar disappears in classic edit mode - 10https://bugzilla.wikimedia.org/61768 (10Marius Hoch) 5PATC>3RESO/FIX [11:38:40] Chmee2: i can reproduce that problem [11:41:07] 3MediaWiki extensions / 3WikidataClient: "Data item" link in sidebar disappears in classic edit mode - 10https://bugzilla.wikimedia.org/61768#c5 (10Quim Gil) Big Thank You! [11:42:53] 3MediaWiki extensions / 3WikidataClient: Fatal error: Site::unserialize() [site.unserialize]: Nesting level too deep - 10https://bugzilla.wikimedia.org/72670#c1 (10Aude) i think this sites data has been saved with hhvm and i can't purge with php zend. if i switch to hhvm, i ca... [11:44:02] jzerebecki: thanks to let me know, so it is not only problem of my laptop :) don't you know why is it so? [11:45:21] Chmee2: it throws an javascript error. Thiemo_WMDE is looking at it now. [11:45:42] great, thankls [11:46:55] (if this will help, I can observe this error from yesterday) [11:51:17] (03PS1) 10Henning Snater: Initialize statements on property pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169681 [11:51:52] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379#c4 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/169681/ [11:53:11] i get "Uncaught Error: Required parameters not specified properly " [11:56:40] 3MediaWiki extensions / 3WikidataRepo: ChangeOpClaim using obsolete Entity::setClaims causes stack trace when adding statement on Property page - 10https://bugzilla.wikimedia.org/72671 (10Henning) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Causes stack trace when trying to set a statement via the UI o... [12:02:38] Chmee2: do we have a bug number for this? i found it and fixed it. [12:03:35] Thiemo_WMDE: I have no idea :) I wrote this bug just here and even don't know that it was possible write somewhere else [12:03:39] but thanks for fixing! :) [12:03:57] (03PS1) 10Henning Snater: Adapt to ValueView 0.8.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169682 [12:15:23] 3MediaWiki extensions / 3WikidataClient: 0 padding on years when formatting dates - 10https://bugzilla.wikimedia.org/72662#c2 (10Thiemo Mättig) 5NEW>3RESO/INV The padding is pointless and should not be done. But it doesn't hurt to have it. The zeros are just meaningless. The formatting of this date is d... [12:15:57] (03PS1) 10Thiemo Mättig (WMDE): Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169684 [12:16:53] aude: this bug is live on Commons, please backport. https://gerrit.wikimedia.org/r/#/c/169684/ [12:32:10] (03CR) 10Adrian Lang: [C: 032] Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169684 (owner: 10Thiemo Mättig (WMDE)) [12:32:22] aude: https://www.wikidata.org/wiki/Q3418411?uselang=fa yesterday issue is back :( seems the hot patch got lost somehow [12:32:30] what? [12:32:32] caching? [12:33:00] it looks ok to me [12:38:38] (03Merged) 10jenkins-bot: Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169684 (owner: 10Thiemo Mättig (WMDE)) [12:42:13] (03PS1) 10Aude: Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169686 [12:42:26] (03PS1) 10Aude: Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169687 [12:43:12] aude: Hmm, I tried Ctrl+Shift+R several times, not available when I am log out. It was resolved yesterday for me, probably it is just a temporary issue on wgHostname = "mw1171" [12:43:32] i can take a look there [12:43:56] Thank you [12:44:01] (03PS1) 10Henning Snater: $.wikibase.toolbarbutton: Fixed misspelled event name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169688 [12:44:25] (03CR) 10Adrian Lang: [C: 032 V: 032] $.wikibase.toolbarbutton: Fixed misspelled event name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169688 (owner: 10Henning Snater) [12:45:03] ebraminio: your fix is there [12:54:04] (03Merged) 10jenkins-bot: $.wikibase.toolbarbutton: Fixed misspelled event name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169688 (owner: 10Henning Snater) [13:04:42] why on earth would the network connection manager of Xfce lstat my network fileshare [13:04:53] which then hangs, because the network was down [13:05:09] that's why I wanted to open said network manager... [13:05:56] It's like 50% of the time I use strace I go straight to "wtf" [13:06:13] what is Xfce? [13:06:19] sounds evil [13:06:34] the desktop environment I have on my netbook [13:06:46] ooooh [13:07:13] took me a bit to figure why the network manager hung up all the time :P [13:07:17] * aude assumes it has something to do with kde and thus rages to lydia :P [13:07:34] Nope, KDE is much better [13:07:40] i see [13:08:07] But this hting only has 2gb ram, so not really an option here [13:08:22] I guess I'll try to install Lxde or so over here to see whether it's less stupid [13:08:43] I still don't get why on earth a network manager would lstat directories it doesn't even remotely need to touch [13:10:06] I seriously consider replacing this thing with a new ultrabook [13:10:16] back then I bought it, ultrabook weren't out, yet [13:10:58] * ultrabooks [13:13:04] (03PS1) 10Henning Snater: Fixed fingerprintview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169692 [13:13:16] [13ValueView] 15thiemowmde comment on pull request #120 146aaac7d: Don't we just do `if( !this.options.confineMinWidthTo )` in JS? 02http://git.io/_Tavpw [13:14:11] [13ValueView] 15thiemowmde comment on pull request #120 146aaac7d: "the width of the width". ;-) 02http://git.io/MJjpvg [13:14:48] [13ValueView] 15thiemowmde comment on pull request #120 146aaac7d: So `undefined` is a valid type and should be listed. 02http://git.io/iD4ZVA [13:16:18] [13ValueView] 15thiemowmde comment on pull request #120 146aaac7d: If it's a string and not a JSON identifier you should write `'min-width'`. 02http://git.io/4ZSeWw [13:17:35] [13ValueView] 15thiemowmde comment on commit 14d6c5549: That's not `jQuery` any more, right? 02http://git.io/QwKFTg [13:17:45] [13ValueView] 15snaterlicious comment on pull request #120 146aaac7d: We use brackets to denote that options/parameters can be left undefined. 02http://git.io/R1Lx-A [13:23:00] [13ValueView] 15thiemowmde comment on commit 14d6c5549: There are rare edge cases in Unicode where this approach will fail. You should use a RegExp for case-insensitive search. But this can be done in a follow up if it turns out to be a problem. 02http://git.io/ajCTkg [13:25:25] [13ValueView] 15snaterlicious 04force-pushed 06suggesterminwidth from 146aaac7d to 14b8d8f1c: 02http://git.io/wBelkQ [13:25:25] 13ValueView/06suggesterminwidth 14b8d8f1c 15snaterlicious: $.ui.suggester: Added option to confine suggestion list minimum width [13:26:52] [13ValueView] 15thiemowmde comment on pull request #120 14b8d8f1c: Right, stupid me. 02http://git.io/9hH5fg [13:28:46] [13ValueView] 15snaterlicious 04force-pushed 06highlightsubstring from 14d6c5549 to 143ad566c: 02http://git.io/mU9Row [13:28:46] 13ValueView/06highlightsubstring 143ad566c 15snaterlicious: Replaced $.util.highlightMatchingCharacters with util.highlightSubstring [13:28:53] [13ValueView] 15thiemowmde 04deleted 06suggesterminwidth at 14b8d8f1c: 02http://git.io/s0Xvqg [13:31:39] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/10/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169663 (owner: 10Tobias Gritschacher) [13:33:39] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/10/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169663 (owner: 10Tobias Gritschacher) [13:33:53] [13ValueView] 15snaterlicious 04force-pushed 06highlightsubstring from 143ad566c to 148517a0d: 02http://git.io/mU9Row [13:33:53] 13ValueView/06highlightsubstring 148517a0d 15snaterlicious: Replaced $.util.highlightMatchingCharacters with util.highlightSubstring [13:34:20] * hoo|rage leaving... battery running out [13:34:25] :( [13:34:31] will be back in maybe 2hours or so [13:34:45] maybe I'll take my big notebook with me tomorrow [13:35:33] [13ValueView] 15snaterlicious 04force-pushed 06valueviewlang from 1414faeb5 to 14e0520af: 02http://git.io/Bh9f3w [13:35:33] 13ValueView/06valueviewlang 14e0520af 15snaterlicious: Added "language" option to valueview widget [13:36:53] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059#c3 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/169682/ [13:50:44] aude: did you just keep the very basic properties here? http://wikidata.beta.wmflabs.org/wiki/MediaWiki:Gadget-AuthorityControl.js [13:50:54] or how did you choose them? [13:52:36] Tobi_WMDE_SW: the gadget page was made in june [13:52:56] i added imdb and commons category, to match properties on beta [13:53:15] others, i don't know if they match properties but probably [13:53:25] coordinates works [13:53:53] aude: ok [13:54:00] others probably work [13:54:09] how would updating the gadget work? [13:54:14] ? [13:54:16] if it changes on wikidata.org [13:54:17] like how? [13:54:23] (03CR) 10Henning Snater: "For me, the line height is increased--in particular due to the margin added." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169503 (owner: 10Thiemo Mättig (WMDE)) [13:54:24] these are independent of wikidata [13:54:30] these are properties on beta [13:54:40] ok, so we would need to manually keep track of changes [13:54:49] if code changes [13:54:53] not the properties [13:54:56] if the actual code changes, we would have to update [13:55:01] ok [13:55:15] the gadget would have to separate the properties definitions / config [13:55:35] so, what version of the gadget is this then? [13:55:39] the most recent? [13:55:43] from today, with the fix [13:55:52] ah, ok [13:55:58] I was wondering why it worked [13:56:03] yeah [13:56:06] ok. I'll create some tests then [13:56:13] great [13:57:53] Hehe, so these repos have one commit adding a gitignore file and two release branches https://git.wikimedia.org/summary/?r=mediawiki/extensions/WikibaseRepo.git [13:57:55] silly [14:00:16] (03CR) 10Aude: [C: 032] New deployment build - wmf/1.25wmf6 [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169668 (owner: 10Aude) [14:00:24] (03CR) 10Aude: [C: 032] Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169687 (owner: 10Aude) [14:00:30] (03CR) 10Aude: [C: 032] Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169686 (owner: 10Aude) [14:02:40] (03Merged) 10jenkins-bot: New deployment build - wmf/1.25wmf6 [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169668 (owner: 10Aude) [14:09:14] (03Merged) 10jenkins-bot: Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169687 (owner: 10Aude) [14:09:17] (03Merged) 10jenkins-bot: Fix broken option in jquery.wikibase.linkitem.js [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169686 (owner: 10Aude) [14:10:01] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Drwessam link https://www.mediawiki.org/w/index.php?diff=1245664 edit summary: [+3973] [14:10:57] (03PS1) 10Aude: Update Wikidata, fix "add links" widget js error [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169699 [14:16:23] (03PS1) 10Aude: Update Wikidata, fix "add links" widget js error [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169700 [14:16:54] (03CR) 10Aude: [C: 032] Update Wikidata, fix "add links" widget js error [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169699 (owner: 10Aude) [14:18:54] (03Merged) 10jenkins-bot: Update Wikidata, fix "add links" widget js error [extensions/Wikidata] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169699 (owner: 10Aude) [14:21:44] (03CR) 10Aude: [C: 032] Update Wikidata, fix "add links" widget js error [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169700 (owner: 10Aude) [14:23:43] (03Merged) 10jenkins-bot: Update Wikidata, fix "add links" widget js error [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169700 (owner: 10Aude) [14:24:18] (03PS5) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [14:24:20] (03PS7) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [14:24:23] (03PS1) 10Adrian Lang: Fix entityview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169705 [14:24:25] (03PS1) 10Adrian Lang: Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 [14:25:31] (03CR) 10Henning Snater: [C: 032] Fix entityview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169705 (owner: 10Adrian Lang) [14:27:08] (03CR) 10Thiemo Mättig (WMDE): "It's possible that this causes side effects I haven't seen. Comparison screenshots would be helpful." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169503 (owner: 10Thiemo Mättig (WMDE)) [14:29:02] (03PS2) 10Henning Snater: Fixed fingerprintview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169692 [14:29:23] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/0x52ug [14:29:23] 13ValueView/06master 14b28aa8d 15thiemowmde: Merge pull request #121 from wmde/highlightsubstring... [14:30:16] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [14:32:13] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/tON-ag [14:32:13] 13WikidataBrowserTests/06master 14b4ff1ff 15Tobias Gritschacher: Remove check for initialized JS from performance test... [14:34:28] (03CR) 10jenkins-bot: [V: 04-1] Add statementview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169706 (owner: 10Adrian Lang) [14:34:53] (03PS1) 10Henning Snater: Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169709 [14:35:13] Tobi_WMDE_SW: ^ [14:36:07] (03PS2) 10Adrian Lang: Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169709 (owner: 10Henning Snater) [14:36:51] merge!!! [14:36:53] :D [14:37:38] 3MediaWiki extensions / 3WikidataClient: Fatal error: Site::unserialize() [site.unserialize]: Nesting level too deep - 10https://bugzilla.wikimedia.org/72670#c2 (10Aude) p:5High>3Normal s:5critic>3normal this seems to work now, with or without hhvm / zend. i was able t... [14:38:12] Do not hesitate, I assume some PHP HTML output unit test will fail... [14:41:25] 3MediaWiki extensions / 3WikidataRepo: disable enter key for entity selector in searchbox - 10https://bugzilla.wikimedia.org/53476#c10 (10Thiemo Mättig) 5NEW>3RESO/INV (In reply to Helder from comment #9) > Not if the field used to be have a "Go" button Not sure what you mean. There is no "Go" button in... [14:42:26] (03Merged) 10jenkins-bot: Fix entityview tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169705 (owner: 10Adrian Lang) [14:47:23] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06sld from 14b2920c2 to 143a1f586: 02http://git.io/EIUQFw [14:47:23] 13WikibaseDataModel/06sld 143a1f586 15jeroendedauw: Remove usage of Claims fro StatementListDiffer [14:48:20] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #262: Remove usage of Claims fro StatementListDiffer (06master...06sld) 02http://git.io/JXI-gw [14:49:47] (03CR) 10Adrian Lang: [C: 032] "Needs purge." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169709 (owner: 10Henning Snater) [14:50:30] aaaaaah, purge! [14:50:39] I'm sorry [14:51:06] suppose we do this anyway [14:51:17] wmde/WikibaseDataModel/sld/3a1f586 : jeroendedauw The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39388051 [14:51:44] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/ReAl_g [14:51:44] 13WikidataBrowserTests/06master 14c968286 15Tobias Gritschacher: Add missing browser tags [14:53:04] Adrian_WMDE: do we need to backport that? (i assume so) [14:54:04] No, it broke yesterday [14:54:32] we made a branch today for test.wikidata [14:54:37] so, i say yes [14:54:38] Ah oh sorry [14:54:54] (03PS1) 10Aude: Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169712 [14:54:56] there [14:55:14] (03Merged) 10jenkins-bot: Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169709 (owner: 10Henning Snater) [15:00:24] (03PS1) 10Adrian Lang: Fix wrongly enabled save button for references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169713 [15:01:22] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #16 14608a661: An `inArray` check in a loop is not so nice perfomance-wise. Could be refactored using a map instead. But not a reason to not merge this patch. 02http://git.io/GsEQTQ [15:03:31] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #16 14608a661: Will we ever get rid of numeric ids? :-( 02http://git.io/nv1cCg [15:04:08] [13WikibaseDataModelJavaScript] 15adrianlang comment on pull request #16 14608a661: We could just use `jQuery.map` and `jQuery.unique`. Probably faster. 02http://git.io/4tGsAw [15:04:34] [13WikibaseDataModelJavaScript] 15JeroenDeDauw comment on pull request #16 14608a661: Would be nice to actually get data on that. I remember seeing some website where you could easily compare such things - can't find it now though 02http://git.io/OT3zmg [15:05:16] [13WikibaseDataModelJavaScript] 15adrianlang comment on pull request #16 14608a661: We can write our own test on http://jsperf.com/. 02http://git.io/9z19Wg [15:07:26] https://gerrit.wikimedia.org/r/#/c/169714/ :) [15:07:57] (03CR) 10Jeroen De Dauw: [C: 031] Always use "edit" as aliases edit toolbar button label [extensions/Wikibase] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169712 (owner: 10Aude) [15:08:12] JeroenDeDauw: you can +2 [15:08:17] if you want [15:08:29] (03CR) 10Jeroen De Dauw: [C: 031] Fix wrongly enabled save button for references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169713 (owner: 10Adrian Lang) [15:08:30] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #16 14608a661: Ping @snaterlicious. 02http://git.io/EjsI_g [15:12:12] [13WikibaseDataModelJavaScript] 15snaterlicious comment on pull request #16 14608a661: jQuery.unique only works on DOM elements. 02http://git.io/zmkoiA [15:12:24] 3MediaWiki extensions / 3WikidataRepo: disable enter key for entity selector in searchbox - 10https://bugzilla.wikimedia.org/53476#c11 (10Helder) (In reply to Thiemo Mättig from comment #10) > (In reply to Helder from comment #9) > > Not if the field used to be have a "Go" button > > Not sure what you mean.... [15:12:46] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #16 14608a661: Some classes use `return this.length === 0`, others use `return !this.length`. Would be nice to be consistent. 02http://git.io/Y67poQ [15:16:36] Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/169714/ :) [15:16:48] assuming ori etc. is good with that [15:17:14] aude: yay! [15:17:28] aude: well, I can't technically, and I should also not, since I'm not sure it is correct [15:17:42] i know there have been some other (unrelated to us) issues with hhvm memory [15:18:13] [13WikibaseDataModelJavaScript] 15adrianlang comment on pull request #16 14608a661: Oh, right. `_.uniq` would work, but we don't have underscore. 02http://git.io/MVDE3g [15:18:31] so need to check with ori to be sure [15:18:43] JeroenDeDauw: ok [15:18:51] [13WikibaseDataModelJavaScript] 15adrianlang closed pull request #16: General update (06master...06fingerprint) 02http://git.io/_h73LQ [15:19:01] [13WikibaseDataModelJavaScript] 15adrianlang 04deleted 06fingerprint at 14608a661: 02http://git.io/_VDQLA [15:19:55] [13WikibaseSerializationJavaScript] 15thiemowmde comment on pull request #6 141da3523: Why `` and not backticks? 02http://git.io/X1No2Q [15:20:37] [13WikibaseDataModelJavaScript] 15JeroenDeDauw comment on pull request #16 14608a661: Looks like this PR does not really change that. You are right though that this is not good, and should be fixed (outside this PR). We had the same situation in the PHP DM, and almost entirely got rid of the issues there. 02http://git.io/F_Pb6g [15:21:31] [13WikibaseSerializationJavaScript] 15thiemowmde comment on pull request #6 141da3523: Upper case variable names are odd. 02http://git.io/Iq6PhA [15:23:31] Thiemo_WMDE: now you can submit >9000 PRs that address all the nitpicks you have :) [15:27:44] Thiemo_WMDE: you first need to review this though https://github.com/wmde/WikibaseDataModel/pull/262/files [15:28:13] Removed a third of the code in that class, and over half of the complexity, plus the usage of the deprecated class [15:28:25] And the binding to the diff ops... [15:28:27] (03CR) 10Tobias Gritschacher: [C: 032] Fix wrongly enabled save button for references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169713 (owner: 10Adrian Lang) [15:29:08] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06sld from 143a1f586 to 14745e538: 02http://git.io/EIUQFw [15:29:08] 13WikibaseDataModel/06sld 14745e538 15jeroendedauw: Remove usage of Claims from StatementListDiffer [15:31:28] [13WikibaseDataModel] 15JeroenDeDauw created 06rename (+1 new commit): 02http://git.io/AYosfA [15:31:28] 13WikibaseDataModel/06rename 14402d9cb 15jeroendedauw: Improve naming in StatementListDifferTest [15:31:42] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #263: Improve naming in StatementListDifferTest (06master...06rename) 02http://git.io/CEu-ng [15:32:13] aude: can you amend https://gerrit.wikimedia.org/r/#/c/169330/ so this can be merged? [15:32:40] aude: if you want I can also do that, but only if you agree [15:32:56] 3MediaWiki extensions / 3WikidataRepo: json dumps have duplicate items (one for the redirect, one for the target) - 10https://bugzilla.wikimedia.org/72678 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs from project chat: https://www.wikidata.org/wiki/Wikidata:Project_chat#JSON_dump_has_duplicate... [15:33:02] (03PS2) 10Jeroen De Dauw: Remove bad dependency from NoBadDependencyUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169360 [15:33:17] Tobi_WMDE_SW: https://gerrit.wikimedia.org/r/#/c/169360/ [15:33:43] (That needs to go for splitting the repo) [15:33:53] JeroenDeDauw: probably after i get home [15:34:11] evil summer time thing has deployments an hour earlier today [15:34:31] I'll be around [15:34:36] yay [15:34:37] aude: summer time is the only valid time :D [15:34:42] heh [15:35:09] evil americans.... more daylight for the children on halloween :P [15:35:09] food :D [15:35:19] So summer time starts at 13:00 and ends at 02:00? [15:35:20] why the heck anyone things that's a good idea... [15:35:39] Thiemo_WMDE: jzerebecki DanielK_WMDE omnomnomnom??? [15:35:52] no, thanks. have something left. [15:36:17] It's a Tpt [15:36:58] JeroenDeDauw: Hi! [15:37:21] Tpt: we want to switch to using the new serialization component of which you wrote most for the WB web API as well [15:37:29] Tpt: still some blockers though https://github.com/wmde/WikibaseDataModelSerialization/milestones/WikibaseLib%20feature%20parity [15:37:35] Tpt: any chance you could help with those? [15:38:27] (03Merged) 10jenkins-bot: Fix wrongly enabled save button for references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169713 (owner: 10Adrian Lang) [15:38:46] JeroenDeDauw: I'll be very busy in the comming weeks so I'm afraid I won't be able to help [15:39:21] Hello, everyone. Why oh why is it that I have to make all links of a given item editable just to edit one? [15:40:43] I shouldn't have to make 200+ things editable just to edit one and have to have it cycle through all of them when saving my itsy bitsy changes... [15:41:42] I mean, perhaps I'm not qualified to say such things, but you know... [15:42:21] ... getting hit in the face with unresponsive script messages just isn't fun. [15:43:24] And yes, I am indeed being serious, in case you were wondering. [15:44:48] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 86.177.109.20 link https://www.mediawiki.org/w/index.php?diff=1245726 edit summary: [-3933] Undo revision 1245664 by [[Special:Contributions/Drwessam|Drwessam]] ([[User talk:Drwessam|talk]]) looks like something added to wrong page [15:52:34] [13WikibaseDataModel] 15thiemowmde closed pull request #262: Remove usage of Claims from StatementListDiffer (06master...06sld) 02http://git.io/JXI-gw [15:53:11] wmde/WikibaseDataModel/rename/402d9cb : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39394455 [16:03:41] (03PS1) 10Henning Snater: Re-added highlighting to siteselector and pagesuggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169729 [16:04:09] Thiemo_WMDE: now I wonder how we find out if people will get totally mad or not [16:04:23] 3MediaWiki extensions / 3WikidataRepo: Highlighting is completely missing - 10https://bugzilla.wikimedia.org/66433#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/169729/ [16:09:54] Thiemo_WMDE: ah, look indeed https://packagist.org/explore/popular [16:17:21] [13WikibaseDatabase] 15JeroenDeDauw created 06rtf (+1 new commit): 02http://git.io/EuU2-Q [16:17:21] 13WikibaseDatabase/06rtf 140b84313 15jeroendedauw: Remove TableNameFormatter interface [16:17:31] [13WikibaseDatabase] 15JeroenDeDauw opened pull request #54: Remove TableNameFormatter interface (06master...06rtf) 02http://git.io/q8ucXg [16:19:37] [13WikibaseDatabase] 15JeroenDeDauw created 06rmtb (+1 new commit): 02http://git.io/k39zGQ [16:19:37] 13WikibaseDatabase/06rmtb 147f0ab43 15jeroendedauw: Remove MediaWikiTableBuilder... [16:25:56] legoktm: ready for the switch? [16:27:10] wmde/WikibaseDatabase/rtf/0b84313 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/39399602 [16:36:33] [13WikidataBrowserTests] 15tobijat created 06authoritycontrol (+1 new commit): 02http://git.io/oX6cow [16:36:33] 13WikidataBrowserTests/06authoritycontrol 144a00760 15Tobias Gritschacher: Add tests for authority control gadget on beta... [16:37:13] [13WikidataBrowserTests] 15tobijat opened pull request #17: Add tests for authority control gadget on beta (06master...06authoritycontrol) 02http://git.io/-iP-xQ [16:37:38] 3MediaWiki extensions / 3WikidataRepo: Create browsertests for AuthorityControl gadget on beta - 10https://bugzilla.wikimedia.org/66251#c1 (10tobias.gritschacher) 5ASSI>3PATC https://github.com/wmde/WikidataBrowserTests/pull/17 [16:37:40] Tobi_WMDE_SW: Did Katie talk to you about client (linkitem) tests? [16:38:38] (03CR) 10Tobias Gritschacher: [C: 032] "seems ironic enough." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169360 (owner: 10Jeroen De Dauw) [16:39:01] legoktm: 10 mins before 11 would be ideal [16:39:05] hoo: no, not yet. [16:39:19] I've just created some tests for the authority control gadget [16:39:43] Lydia_WMDE: What are you switching? :P [16:40:00] I have still tests for the new behavior of sitelinkview and some smoke tests from statements on properties on the list. [16:40:07] Tobi_WMDE_SW: Ok, would be nice to have at least all the old pre-cucumber tests ported [16:40:19] hoo: secrets!!! [16:40:22] because this client stuff tends to break a lot [16:40:38] and can't really be Qunit tested :/ [16:40:44] hoo: but I'll put that on my list, if everything goes smooth tomorrow and there is not too much distraction I probably can do that [16:41:01] Lydia_WMDE: Evil cabal! :D [16:41:08] yes yes yes [16:41:09] :D [16:43:53] [13WikibaseDatabase] 15thiemowmde closed pull request #54: Remove TableNameFormatter interface (06master...06rtf) 02http://git.io/q8ucXg [16:44:14] [13WikibaseDatabase] 15thiemowmde closed pull request #55: Remove MediaWikiTableBuilder (06master...06rmtb) 02http://git.io/wTOQ8A [16:44:24] [13WikibaseDatabase] 15thiemowmde 04deleted 06rmtb at 147f0ab43: 02http://git.io/VRoAHg [16:45:32] (03Merged) 10jenkins-bot: Remove bad dependency from NoBadDependencyUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169360 (owner: 10Jeroen De Dauw) [16:55:37] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 143dd5504: What.. really? >_> 02http://git.io/P_fTTQ [17:05:33] It's Lydia_WMDE that will do a talk in 2 hours [17:05:38] Lydia_WMDE: no stress of course [17:05:45] :P [17:05:46] Lydia_WMDE: only the entire internets will look [17:09:05] anyone able to help me with a bit of wikitext foo? [17:10:33] Lydia_WMDE: I can [17:10:40] hoo: ok query [17:14:00] legoktm: poke poke poke? :D [17:20:00] hoo: Harmonia_Amanda wants to know how to get a list of all items with a certain property but with no French label [17:20:08] (probably would be done by API) [17:20:33] That's not possible with our API, sorry :( [17:20:36] well, not yet [17:20:52] oh [17:21:02] well, I can't stop searching, then [17:21:10] I'll do it manually ^^ [17:21:32] Well, you could hack it up in various ways [17:21:45] but there's no single api call or special page you can use right now [17:36:56] 3MediaWiki extensions / 3WikidataClient: Popup is poorly positioned, causing unnecessary scrolling - 10https://bugzilla.wikimedia.org/72687 (10Helder) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Created attachment 16944 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16944&action=edit Screencast... [17:37:28] Lydia_WMDE: hey [17:37:45] legoktm: hey :) [17:37:53] ready to do it in 1 hour 10 mins? [17:38:03] sure! [17:38:10] sweet [17:42:55] legoktm: actually in 10 minutes [17:42:58] i am being confused :D [17:43:13] okay! [17:43:51] Time zones :D [17:43:59] :D [17:44:43] 10 minutes! [17:45:34] Yet another soft earthquake I didn't notice [17:46:31] hoo: they're a fact of life over here near the office [17:47:37] I'm quite not near the office :P [17:47:52] You can get them anywhere in the world ;) [17:47:55] Third earthquake over here this year... but I only felt one :P [17:48:16] but that was way more heavy then now-ish [17:48:38] You're obviously just not very sensitive :P [17:49:08] It's the house's fault... it always shakes when there's a bus or so passing by [17:49:48] but I did notice when my bottles fell that one time... :P [17:51:20] * Reedy decides it's time to branch [17:52:17] legoktm: go [17:52:49] * hoo grabs popcorn :D [17:55:38] Lydia_WMDE: done, it'll take ~5 min to show up for everyone [17:55:46] legoktm: \o/ [17:55:48] you're the best [17:55:57] :) [17:56:50] woot [17:56:53] The cake is not a lie! :D [18:08:16] Lydia_WMDE: any reason why i shouldn't add it to the news page? [18:08:33] jzerebecki: no please do [18:08:38] :) [18:09:08] 3MediaWiki extensions / 3WikidataRepo: Make Wikibase compatible with HHVM - 10https://bugzilla.wikimedia.org/64415#c4 (10Jan Zerebecki) AFAIK all the actual problems we know of under HHVM were fixed. The dependent bugs are only about cleanups and automated tests. [18:09:48] the error logs look quiet :) [18:10:09] awesome [18:10:28] there still are a bunch of log files like "183710.log" [18:10:37] current ones? [18:10:40] I'll look in a bit [18:10:41] "baseLuaBindings.php(112):.log" [18:10:55] oh, that doesn't look good [18:11:05] * aude hopes they go away with this deploy [18:11:20] ah right, the old branch was still active [18:11:26] * is, even [18:11:27] all renumber [18:16:53] hmmmm, founds a ui bug [18:16:58] aaaa [18:17:12] huh? [18:17:45] if i click edit for aliases, it doesn't autofocus on the alias input box [18:17:53] i have to click in it [18:18:00] * aude see if it happens on master [18:18:32] it also says "edit" while on master it says "add" since there are none yet [18:19:43] happens on master, and also think "add" is only in non-js [18:23:40] 3MediaWiki extensions / 3WikidataRepo: click edit for aliases (there are none yet) and it doesn't auto-focus on the input box - 10https://bugzilla.wikimedia.org/72691 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I am on an item that has no aliases yet. I click "edit" and it should autofocus on... [18:23:53] 3MediaWiki extensions / 3WikidataRepo: click edit for aliases (there are none yet) and it doesn't auto-focus on the input box - 10https://bugzilla.wikimedia.org/72691#c1 (10Aude) this happens on master, as well as on wikidata... [18:27:29] * jzerebecki is now confused: https://www.wikidata.org/w/index.php?title=Special:RecentChanges&tagfilter=HHVM shows edits before https://gerrit.wikimedia.org/r/#/c/169714/1 was merged [18:28:44] jzerebecki: i think it's been possible to use hhvm with the cookie [18:28:48] yep [18:29:02] but the cookie is being unset now, I think [18:29:08] not sure that is deployed yet [18:29:16] everyone should use the beta feature [18:30:08] * aude pretends not to see if someone used the cookie :p [18:31:11] jzerebecki: a lot of people like me put the cookie in their global.js to have HHVM everywhere [18:31:38] at that level of use, probably was ok [18:31:54] at one's own risk [18:34:53] hi guys. first: happy birthday! *throws confetti* [18:36:15] next: I am working on Q18347222. I would like to denote him as an emigrant. How can I connect him with Q187668? [18:38:27] (oh, and hi Q5223_Stryn !) [18:39:16] oh, hi WikiGnom :) [18:39:31] this channel is full of awesome people, I should come more often. [18:39:46] Q12068060 WikiGnom [18:40:40] :D [18:41:03] Lydia_WMDE: I hope you're not in the office! [18:41:30] Q170484: :D [18:41:44] WikiGnom: in SF in the office [18:42:25] Lydia_WMDE: cool, please say hi to the legal folks from me! [18:42:26] Pharos: = Q43244 ? [18:43:24] oh noes https://www.wikidata.org/w/index.php?title=Q179976&diff=159682242&oldid=159682233 :/ [18:43:43] Q4115331: yup, that's me [18:44:18] Lydia_WMDE: Q8479203 [18:44:18] Happy Birthday! We are sending more work to you as a little gift: https://www.wikidata.org/wiki/Wikidata:Project_chat#Birthday_gift:_Missing_Wikipedia_language_links [18:44:22] Pharos: :) [18:45:13] aude: :) [18:46:00] dennyvrandecic: I should have a look how big the database is again [18:46:06] hoo: hahaha [18:46:34] Reedy: I don't think these 35k links will do anything bad to the size od the DB :) [18:46:47] dennyvrandecic: More the 2 year anniversary :) [18:47:25] lol https://www.wikidata.org/w/index.php?title=Q179976&diff=6742739&oldid=662639 [18:47:29] hoo: reverted xP [18:48:27] Q170484: shouldn't your nick be :p [18:48:44] meh [18:49:07] db size [18:49:07] http://p.defau.lt/?3HxbFc_aj0_bSITmEYwy3g [18:49:40] JohnLewis: change your nick to Q1918981 ;) [18:49:45] Reedy: run it for enwiki so we can compare? [18:50:11] JohnLewis: you have some to choose from https://www.wikidata.org/w/index.php?title=Special%3ASearch&profile=default&search=+%22john+f.+lewis%22+OR+%22john+lewis%22&fulltext=Search&uselang=en [18:50:14] :P [18:51:00] Q1918981 is a good choice ;) [18:51:29] indeed [18:51:55] enwiki [18:51:55] http://p.defau.lt/?0KLuXvW4KMArvpt9nPutMA [18:52:18] Reedy: now work out how many wikidatawikis enwiki is :D [18:52:29] (because I am too lazy to do it myself) [18:52:31] JohnLewis: The query I use for the overall size is broken for some reason [18:52:40] Hm [18:52:47] * Reedy debugs [18:53:27] wow, logging is our biggest table? [18:53:46] aude: I think it's been like that a long time [18:53:47] yep, always was [18:54:48] Why doesn't https://www.wikidata.org/wiki/Special:EntityData/Q1.rdf have properties but .json does? [18:55:04] .xml does too [18:55:07] JohnLewis: 8.3241679 times wikidata is enwiki by revision data size [18:55:08] oh, fscking wordpress [18:55:15] lol enwiki has article_feedback. [18:55:27] jzerebecki: lovely :p [18:55:28] enwiki is 1206.437881469727GB [18:55:57] but that _revision_old probably skews it [18:56:04] wikidata is 257.506011962891 [18:56:08] dewiki is 284.208908081055 [18:56:16] still not as big as dewiki ;) [18:56:38] Reedy: only a matter of time! [18:56:53] I guess that query doesn't include external storage either [18:57:17] 39772996399 bytes are all items [18:57:20] current versions only [18:57:27] a stored in the DB [18:57:45] (that's about 37GiB) [18:58:44] Q170484ktm: there is no code to output properties as rdf yet, its more work than straigt printing it out, there is a paper about how to do it though (i think with actual code to transform a dump to rdf)... [18:59:05] jzerebecki: you want Q4115331 :P [18:59:57] Q170484ktm: dat name [19:00:13] Does phase III have a planned date? [19:00:23] arg, autocompletion in irssi is crap [19:00:28] Q4115331: yeah, 1.5 years ago [19:04:22] JeroenDeDauw: really? [19:05:13] that was the "planned date" :P [19:05:25] Q4115331: right now we are busy with removing usage of Doctrine DBAL, which apparently is not good enough to be deployed on WMF servers [19:05:25] but I think the phase terminology was dropped a while back [19:05:29] oh it seems https://www.wikidata.org/wiki/Q2013 has wrong P571 [19:06:39] Reedy: this wikidata DB is growing indeed quite fast. do we now at what size it will be a problem? >enwiki? [19:07:00] dennyvrandecic: depends what you mean by "problem" I guess.. :) [19:07:14] db too big :) [19:07:49] I doubt that's going to be a problem mid-term, if we don't "explode" (size-wise) [19:07:56] https://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&c=MySQL+eqiad&h=db1058.eqiad.wmnet&tab=m&vn=&hide-hf=false&m=cpu_report&sh=1&z=small&hc=4&host_regex=&max_graphs=0&s=by+name [19:07:57] that is the master [19:08:04] How does Wikidata DB size compare to freebase and dbpedia? [19:08:05] replacing external storage is interesting, though [19:08:13] https://ganglia.wikimedia.org/latest/graph_all_periods.php?c=MySQL%20eqiad&h=db1058.eqiad.wmnet&r=hour&z=small&jr=&js=&st=1414609651&v=24.6&m=part_max_used&vl=%25&ti=Maximum%20Disk%20Space%20Used&z=large [19:08:23] It's using about 25% of the space on the server with dewiki too [19:08:24] :) [19:08:29] Think we're ok for a while ;) [19:08:30] Q4115331: that's not comparable. what is comparable would be the number of triples, e.g. [19:08:37] Reedy: yay! [19:08:45] Yep... especially as those dbs are meta-data only [19:08:54] the actual item jsons are on different boxes [19:09:18] the DB is still minuscule IIRC [19:09:51] * Nemo_bis clicks the birthday gift [19:10:02] changed my nick too [19:10:17] oh no [19:10:20] My autocompletion hates you [19:10:32] :D [19:10:33] Q4m816u17y [19:10:49] Nemo_bis: Wait... you don't have the label lookup plugin in your IRC client? :D [19:13:06] I thought everyone had the label lookup plugin. [19:14:03] * aude yawns.... boring deployment :p [19:14:34] * hoo goes to break some stuff to make aude happy :D [19:14:49] heh [19:15:12] With hhvm I can view the biggest version of Q183 ... and with Thiemo's no JS for old revisions patch it's not even browser breaking! [19:15:57] Sorry for asking again: I am working on Q18347222 (Wenzel Goldbaum, a person). I would like to denote him as an emigrant. How can I connect him with Q187668 (Emigration)? [19:16:28] WikiGnom: probably not. Is there no item for "Emigrant" instead? [19:16:43] hoo: what? Q183 is available again? Wohoo! :) [19:16:51] No, it can be viewed [19:16:57] like before [19:17:06] (well, but doesn't fatal now) [19:17:17] but still wont work with Zend PHP (non hhvm) [19:17:18] ah, but no editing yet [19:18:19] Q16275497: the "Emigration" item has "Emigrant" as an alias in German and Italian, so apparently it's used that way [19:18:27] oh [19:18:28] WikiGnom: uh :S I guess you could say he was part of an emigration event [19:18:40] nah [19:18:47] I still wouldn't use it that way [19:19:08] you could use the citizen property with time qualifiers [19:19:08] rather make a new item for emigrant, if there is none [19:19:23] remove the aliases "Emigrant" from emigration [19:19:24] and use that [19:19:35] Q16275497: I wonder if you can make us another gift... I'd love if https://en.wikipedia.org/wiki/Knowledge_Graph had a complete timeline of new language releases [19:20:54] WikiGnom: https://www.wikidata.org/wiki/Q4989857 ? [19:20:56] Nemo_bis: well, I shouldn't be editing that page [19:21:09] Nemo_bis: also, it would constitute original research [19:21:30] https://commons.wikimedia.org/wiki/File:QuickStart_banners.png [19:21:53] Q16275497: of course you wouldn't edit it directly :) but why is there no info about it anywhere? :[ [19:22:11] !nyan | Q* [19:22:12] Q*: ~=[,,_,,]:3 [19:22:17] I've been following the google search blog (and several others) for many months now but nowadays they don't even announce new languages [19:22:18] * JeroenDeDauw wants wilcards [19:23:10] Nemo_bis: sorry, can't comment on that [19:23:40] JeroenDeDauw: scared of wildcats? [19:23:57] hoo: phew... thanks anyway! [19:24:30] Q16275497: I understand :) [19:24:42] :) [19:25:22] I HATE FUNDRAISING [19:25:31] go bankrupt, you birthday boycotters [19:25:35] sob [19:25:49] I'll have to wait for Magnus I guess [19:25:57] ? [19:26:02] hoo: no Émigré is subclass of emigrant [19:26:03] https://commons.wikimedia.org/wiki/File:QuickStart_banners.png [19:26:18] jzerebecki: Well, in that specific case it might make sense [19:26:25] ouch [19:26:31] ah ok didn't check [19:26:44] at least after a quick glance at the WP article [19:43:13] ROFLMAO http://www.geonames.org/712754/botar.html links to http://en.wikipedia.org/wiki/Bandits_of_the_Acoustic_Revolution ;-) [19:46:53] [13WikibaseQueryEngine] 15JeroenDeDauw created 06logger (+1 new commit): 02http://git.io/IVofiw [19:46:53] 13WikibaseQueryEngine/06logger 142bc3b42 15jeroendedauw: Add PSR-3 logger interface... [19:46:55] sounds legit [19:47:03] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #132: Add PSR-3 logger interface (06master...06logger) 02http://git.io/Fe8NRA [19:47:14] jzerebecki: you want us to use PSR-3! https://github.com/wmde/WikibaseQueryEngine/pull/132 [19:48:11] more external dependencies? [19:48:18] How many loc are that? [19:50:57] hoo: oh yeah, evil external dependencies [19:50:59] panic [19:51:32] JeroenDeDauw: Well, I would like to see that deployed at some point, and we both know the process [19:51:52] hoo: which is why I'm using only PSR-3 and not Monolog as well [19:52:55] hoo: also, core depends on this interface anyway, since 28 minutes ago. You really ought to keep yourself up to date! [19:52:58] if the logging thing is already included in core, then in the query thing.... [19:53:12] is that a problem to require it both places? [19:53:44] aude: Yep, will break [19:53:59] because php will fatal about it already being declared [19:54:05] yeah [19:54:19] but if query engine depends on core anyway it's not even needed [19:54:27] the dependency [19:54:28] it does not [19:54:33] eventually this is going to happen with two extensions or things needing the same thing [19:54:36] and I'm not so sure it will break [19:54:44] aude: We knew that :S [19:54:55] yep [19:55:04] hoo: why would it load the second definition? [19:55:09] JeroenDeDauw: It will... as we pack stuff statically and composer is not really invoked... we just have two static repos with those classes in [19:55:24] >_> [19:55:41] Well yeah [19:55:45] We indeed knew this [19:55:50] mh... if the autoloader is smart, it might not break [19:55:52] One single "build" is needed [19:55:59] but it will if the other file is being loaded anyway [19:56:26] but it's not nice anyway [19:57:35] aude: do you think it is feasable to have WMF not deploy the vendor repo and our build, but instead a build that has both the vendor repo and everything else using Composer? [19:58:37] JeroenDeDauw: i think feasible [19:58:49] don't know how easy to set that up though [19:59:10] uhhh [19:59:19] aude: can you start raging to people, so this is done by the time we need it? [19:59:23] not going to be much fun [19:59:29] Lydia_WMDE: I just did your homework as no one apparently bothered to ;) [19:59:41] i don't know how quick [19:59:45] hoo: and the better alternative is? [20:00:07] I don't say there's one [20:00:15] I just say that it's not going to be fast [20:00:29] as stuff will need to be done with more WMF involvement [20:00:45] Which is why we should start pushing for it now and not when we need it in a week [20:00:46] but very inevitable that it will happen that two extensions will use the same dependency [20:00:57] True :S [20:00:58] needed to figure this out sooner or later [20:00:58] Indeed [20:01:03] Yeah [20:01:04] before we have a surprise [20:01:13] let's try to figure [20:01:17] needs an RfC? [20:01:22] oh god [20:01:32] heh.... [20:01:38] not so bad anymore [20:01:41] This is a WMF issue [20:01:45] Not a MW one... [20:01:49] JeroenDeDauw: Next week is not going to likely... [20:01:58] - going to [20:02:03] Sure [20:02:14] It's going to take us weeks before this stuff can be deployed anyway [20:02:31] So if this change in the build process also takes weeks, that's fine [20:02:48] aude: hoo: We should probably involve Bryan Davis in this [20:02:51] aude: Mh... we might want to set up a conference call with wmf over this or so? [20:02:57] or Ams. hackathon? [20:03:04] idk [20:03:05] (with prior appointment) [20:03:39] It's going to be a month until I'm in Berlin again, btw... we moved the date [20:03:48] * bd808 sees an idirect ping [20:03:49] :/ [20:03:52] *indirect [20:04:23] bd808: See scrollback [20:04:25] bd808: meh, thought you where not in the channel. Evil obfuscated handle you have! [20:04:54] extensions/composerstuff/... [20:04:55] :P [20:05:23] making plans to use the mediawiki/vendor repo to manage things would be good [20:05:39] That was my hope when I got it started [20:05:50] bd808: so put our extensions there? [20:05:52] if we could somehow merge our composer file with other ones [20:05:56] And not have a new place for all the composer things? [20:06:01] when making deployment stuff [20:06:11] [13WikibaseQueryEngine] 15JeroenDeDauw created 06rdc (+1 new commit): 02http://git.io/89yj_A [20:06:11] 13WikibaseQueryEngine/06rdc 1403b2d7b 15jeroendedauw: Remove dead code [20:06:33] Wikidata is a bit of a special flower :) [20:06:43] Yep... most extensions are [20:06:54] but we're the only ones using composer AFAIK [20:07:00] bd808: really? I thought that honour goes to WMF :) [20:07:43] I don't think that WMF ops would like to see all extensions installed via composer, but for wikidata and SMW it might be the right thing for us to do [20:08:05] Technically I don't think it would be difficult [20:08:38] bd808: I guess we just need a composer-deployment repo with one composer.json which just includes all the things we need [20:08:43] Well, doing that would of course get rid of the weirdness we have now [20:08:49] bd808: well, i't like what we do now [20:08:53] and then we need to integrate that with the deployment (just make it an extensions... huh?) [20:08:56] but have to merge the composer files [20:09:12] install and then upload everything to gerrit [20:09:18] and then both core and whatever extension can be in there [20:09:22] (if really need be, we can have our own satis) [20:09:34] satis? [20:09:48] hoo: our own packagist [20:09:49] Not even that I think, we would just add Wikidata and SMW as dependencies in the mediawiki/vendor composer.json right? [20:09:52] if they really freak out [20:09:57] but don't think it's needed [20:10:12] bd808: That would work [20:10:18] with some changes to how stuff is loaded [20:10:26] mediawiki/vendor is basically us doing what you do to make your deploy branches now [20:10:30] bd808: yeah, think it can work [20:10:30] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/N0IWdA [20:10:30] 13WikibaseDatabase/06master 140cd05fb 15jeroendedauw: Remove unused class [20:10:44] we have some additional build "resources" [20:11:08] have to figure out where to put them, but solveable [20:11:42] aude: don't forget https://gerrit.wikimedia.org/r/#/c/169330/ [20:11:43] bd808: Is that deployed as a submodule as well? [20:11:55] Never had to change it, so dunno [20:11:58] it is a submodule [20:12:03] hoo: yes. and tagged and branched with core [20:12:07] JeroenDeDauw: i know, doing :) [20:12:55] aude: Could we do it the same way we added wikidata to mediawiki-vagrant? [20:13:07] or is there something that misses? [20:13:34] [13WikibaseDatabase] 15JeroenDeDauw created 06mv (+1 new commit): 02http://git.io/etdJgw [20:13:34] 13WikibaseDatabase/06mv 1410325f2 15jeroendedauw: Move MW specific classes into MW NS [20:13:49] Hallo. [20:14:04] hi aharoni [20:14:07] The film https://www.wikidata.org/wiki/Q161678 is based on (P144) the novel https://www.wikidata.org/wiki/Q46758 . [20:14:15] bd808: probably would work [20:14:25] Is there any kind of backlink from the novel to the film? [20:14:34] Something like "is adapted as"? [20:15:33] (03PS6) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [20:15:52] (03CR) 10Aude: "just a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [20:16:18] aharoni: Not according to https://www.wikidata.org/wiki/Wikidata:List_of_properties/Works [20:16:24] (03CR) 10jenkins-bot: [V: 04-1] Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [20:18:16] JeroenDeDauw, aude, hoo: I'm going to have my hands full with the psr-3/monolog rollout for a bit but once that settles down I'd love to help with trying to deploy wikidata via mediawiki/vendor. I was actually planning to try that with SMW so we can get wikitech on a modern version. [20:19:35] bd808: Ok... can we maybe track this as a bug? [20:19:38] GerardM-: Heb je al door dat je een uitglijder hebt gemaakt? [20:19:39] Will you be in Ams. btw? [20:19:47] [13WikibaseDatabase] 15JeroenDeDauw created 06mvc (+1 new commit): 02http://git.io/XmCocQ [20:19:47] 13WikibaseDatabase/06mvc 14b46ed9d 15jeroendedauw: Move QueryInterface into package root NS... [20:21:18] hoo: I won't be :( It's probably too late to try and get there (and my wife is tired of me traveling this year) [20:21:24] bd808: note that SMW and Wikibase share some dependencies. Stuff will go bad if you do a seperate composer install for each [20:21:37] JeroenDeDauw: good to know [20:22:20] aude: you broke your commit by rebasing it! :<0 [20:22:30] Let's start a bug to track the idea and maybe send some email ideas around [20:22:44] I linked an article in the Hebrew Wikipedia main namespace to a page in English Wikipedia's Draft namespace. [20:22:45] Indeed [20:22:52] I wonder whether this violated any content policy :) [20:23:08] https://www.wikidata.org/wiki/Q18192306 [20:23:10] aharoni: Probably [20:23:35] People go crazy at such things [20:24:22] I usually respect all editing communities and I don't like to complain about "ZOMG all those crazy deletionist content policies!!!", but it's a case where ther English Wikipedia is fighting with its own rules ;) [20:25:12] aaaaah [20:26:33] (And in case anybody wondered why am I bothering to link this movie, then it's because Denny's mega-awesome email about Google's heuristic linking suggestion.) [20:26:53] awesome... [20:26:53] Interface 'Psr\Log\LoggerInterface' not found in /mnt/jenkins-workspace/workspace/mwext-Wikibase-repo-tests/includes/debug/logger/Logger.php on line 46 [20:27:08] bd808: is jenkins broken? [20:27:55] aude: arg. what job? [20:28:09] https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests/7214/console [20:28:22] The PSR-3 patch landed today and it would cause that [20:28:24] could be one of the slave scripts [20:29:08] It needs hashar's fancy multi-repo checkout script [20:29:44] You need to clone mediawiki/vendor now to get the PSR-3 classes [20:30:59] * hoo|away will be back [20:31:04] aharoni: denny here :) [20:31:18] linking to the draft namespace, yay! :D [20:33:14] oh dear [20:33:29] bd808: so I need to update >9000 TravisCI build scripts now [20:33:31] \o/ [20:34:19] Or not - guess most will still work since they run composer install in the root already [20:34:26] JeroenDeDauw: That's what JJB is for. Antoine did it for all of the jobs I thought but apparently these got missed. [20:34:37] JJB? [20:34:47] bd808: TravisCI, not Jenkins [20:34:48] But yeah if you run composer install for mediawiki/core that will do it too [20:35:08] doh. yeah sorry [20:35:12] change is hard [20:35:39] we probably do something special for the wikibase jobs [20:35:50] i don't know exactly what is configured where now :/ [20:36:02] http://git.wikimedia.org/blob/integration%2Fconfig.git/9b2737cea07ea3e1d7d19d3e39b104b3588ea9e1/jjb%2Fwikidata.yaml maybe [20:36:33] aude: Yeah I think that's the file [20:36:39] tyring to find what needs to change [20:36:43] *trying [20:36:56] Q16275497: Yo. Should I bother reporting bugs in that tool? [20:37:12] Oh is a quick simply throwaway thing? [20:37:25] we might reuse other configs for mw install [20:37:26] aharoni: assume the latter [20:37:31] then our stuff [20:37:46] but then other non-wikibase patches would fail on jenkins now [20:37:47] Q16275497: no problem, nothing horrible. [20:37:47] aharoni: but it's open source, people can take it and extend it [20:37:56] and seems that's not the case [20:37:58] aude: I think you need something like this -- https://github.com/wikimedia/integration-config/blob/master/jjb/mediawiki.yaml#L137-L141 [20:38:27] yeah [20:39:16] aude: I think that really the get-mw-core macro needs to be fixed [20:39:57] That job gets core via -- https://github.com/wikimedia/integration-config/blob/master/jjb/macro.yaml#L75-L84 [20:40:09] That is no longer sufficient [20:41:34] aude: And apparently documented as deprecated -- https://github.com/wikimedia/integration-config/blob/master/jjb/macro.yaml#L444-L456 [20:42:15] Q16275497: it's really surprising that articles about pretty important topics are not linked. [20:42:21] Like [[Basic Law for the Federal Republic of Germany]. [20:42:24] aude: wikidata.yaml seems to be the only use of mw-setup-extension left in the config files [20:42:30] [13WikibaseQueryEngine] 15JeroenDeDauw created 06entitydocument (+1 new commit): 02http://git.io/WY3iuA [20:42:30] 13WikibaseQueryEngine/06entitydocument 1414366a8 15jeroendedauw: Use EntityDocument instead of Entity [20:42:38] Not sure why hashar didn't change those too [20:42:49] https://github.com/wikimedia/integration-jenkins/blob/master/bin/mw-core-get.sh [20:42:50] aharoni: are you implying we removed those links first so we can have more of them? :D [20:43:35] of course not, even though that would be VERY FUN for those of us who are on the farther edge of the OCD spectrum :) [20:43:41] :D [20:43:53] you mean, like most wikidata editors... [20:44:13] pretty much [20:54:02] aude: I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=72700 for the broken JJB configuration [20:57:41] bd808: thanks [20:57:55] * aude too tired to work on tht right now [20:59:13] greg-g just asked Krinkle to look into it. I fear my patch may be reverted. :( [20:59:37] bd808: likely yes. There are 100s of unrelates jobs all using the 'get-mw-core' scripts which does a mere git checkout [20:59:41] it doesn't add vendor or anything [21:17:00] 3Wikimedia / 3Wikidata: integrate wikidata (composer) built with mediawiki/vendor - 10https://bugzilla.wikimedia.org/72703 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Integrate wikidata (composer) built with mediawiki/vendor . Otherwise stuff will break as soon as core and wikidata sh... [21:38:45] 3MediaWiki extensions / 3WikidataRepo: add i18n for api modules help - 10https://bugzilla.wikimedia.org/72704 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs since https://gerrit.wikimedia.org/r/#/c/161093/ in core, api module help documentation can now be internationalized. we need to do this fo... [21:43:56] (03PS7) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [21:44:56] (03CR) 10jenkins-bot: [V: 04-1] Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [21:46:03] (03CR) 10Aude: Implement LabelLookup (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [22:17:18] Evil Q16275497! [22:18:14] :D [22:18:14] * hoo wishes for an item label lookup... for HexChat :D [22:19:42] (03CR) 10Aude: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [22:19:52] (03CR) 10Hoo man: "This rather trivial patch is lying around for a whole week now :S" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [22:28:06] (03PS3) 10Hoo man: [WIP] Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) [22:28:42] 3MediaWiki extensions / 3WikidataRepo: add i18n for api modules help - 10https://bugzilla.wikimedia.org/72704#c1 (10Aude) see https://www.mediawiki.org/wiki/API/Architecture_work/i18n [22:29:29] 3MediaWiki extensions / 3WikidataClient: ENTER should submit the "Link with page" popup when adding a new site links from client - 10https://bugzilla.wikimedia.org/72712 (10Helder) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Currently, if I go to a Wikipedia article and then 1. Click on "Add links" 2.... [22:30:52] !nyan [22:30:52] ~=[,,_,,]:3 [22:31:30] http://bots.wmflabs.org/dump/%23wikidata.htm [22:31:30] @info [22:31:49] !evil JeroenDeDauw [22:31:49] JeroenDeDauw is eeeeeevil >:( [22:32:14] !evil !evil [22:32:14] !evil is eeeeeevil >:( [22:32:23] oh, it's not recursive :D [22:32:46] hoo: it was coded good unlike your bots ;) [22:33:12] 3MediaWiki extensions / 3WikidataRepo: add i18n for api modules help - 10https://bugzilla.wikimedia.org/72704 (10Andre Klapper) [22:33:19] JohnFLewis: Hey, I only operate one bot right now... and it works perfect most of the time: All the time! [22:33:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [22:33:35] hoo: is it recursive? :p [22:33:45] 3MediaWiki extensions / 3WikidataRepo: Make Wikibase compatible with HHVM - 10https://bugzilla.wikimedia.org/64415#c5 (10Aude) 5REOP>3RESO/FIX enabled hhvm again on wikidata as a beta feature and don't see any issues [22:34:13] JohnFLewis: No, it's a rather dump collection of shell scripts, php and python [22:34:16] (yes, all of that) [22:34:39] hoo: well - it is poorly coded by your standards if it can't recurse [22:34:42] :D [22:34:57] It is poorly coded by every sane persons standards :P [22:35:03] (03CR) 10Jeroen De Dauw: [C: 032] Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [22:35:08] But it only took me a few hours to get it done, so... :D [22:35:13] (03PS5) 10Jeroen De Dauw: Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [22:35:15] 3MediaWiki extensions / 3WikidataRepo: Make Wikibase compatible with HHVM - 10https://bugzilla.wikimedia.org/64415#c6 (10Aude) 5RESO/FIX>3REOP aaaha, this still depends on things that are still open. i think this bug is fixed and doesn't depend on the other ones, imho, though [22:35:26] It wasn't supposed to run for more than maybe three months [22:35:32] it's 9 months now [22:35:34] or so [22:35:38] (03CR) 10Jeroen De Dauw: "Why CR-2?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [22:36:11] * 10 [22:36:39] hoo's scripts - now with 3.3 times durable than he planned [22:36:46] (03CR) 10Aude: "i am sure jenkins says no to this, since it needs to be reworked with the latest version." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [22:36:50] *durability [22:37:08] Like the Voyagers :) [22:37:20] Q16275497: oh what have you done, I've been fixing links all evening because of that missing links guessing tool :) [22:37:33] :D [22:37:54] did more than half of the English-Hebrew pair [22:37:59] wohooo! [22:38:11] * Reedy looks for an "oooh shiny" barnstar for aharoni [22:38:11] did you actually go and fix them, or just tell the tool they are OK? [22:38:14] empty( $template->get( 'language_urls' ) ) [22:38:20] I so much hate php for that not working [22:38:34] Q16275497: went and fixed, and said yes or no in the tool [22:38:46] wow, that's dedication :) [22:38:50] some required manual intervention [22:39:01] makes sense [22:40:34] (03CR) 10jenkins-bot: [V: 04-1] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [22:41:39] jzerebecki: aaaaaaaah [22:41:41] rage [22:41:56] ? [22:42:35] jzerebecki: logger in QueryEngine [22:42:40] what, Q183 bug depends on making wikibase compatible with hhvm? [22:42:43] (03Merged) 10jenkins-bot: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [22:42:47] :D [22:42:53] That's one way of fixing it [22:42:59] (well 100% hhvm that is) [22:43:02] sure that helps but we aren't magically going to make wikidata hhvm only yet [22:43:07] yep [22:43:16] also then the problem will hit us again in 3 months [22:43:21] and sure there is more to it than that [22:43:21] or maybe 6 [22:43:25] yeah [22:45:33] $title->resetArticleID( 9638 ); [22:45:34] wtf [22:45:47] huh? [22:45:50] JeroenDeDauw: do you have a better idea than to first fix the lack of unified build? [22:45:53] In a test [22:45:57] not saved to the DB it seems [22:45:59] so harmless [22:46:10] wtf? [22:46:17] RepoItemLinkGeneratorTest [22:46:35] will try to remove it while doing my other changes [22:48:01] meh [22:54:05] jzerebecki: did you not see my reply? [22:54:26] yes replied just now [22:59:02] aude: Got it: it's needed to make sure Title::exists() -> true [22:59:07] without it actually existing [22:59:50] hoo: you know i recently added a hook to do that in a clean way? [23:00:56] jackmcbarn: No, I don't [23:01:12] but hooks aren't very convenient for test usage [23:01:19] should probably use a mock actually [23:01:42] hoo: https://gerrit.wikimedia.org/r/#/c/160546/ [23:02:13] it's probably better than what you're doing now, and the purpose of it is for titles that exist but aren't in the database (the original use case was Extension:TemplateSandbox) [23:02:24] will have a look, thanks [23:07:13] jzerebecki: double rage all the way accross the sky [23:28:41] m( [23:29:06] https://gerrit.wikimedia.org/r/167251 hit me once again [23:30:50] i wish my trivial patches only laid around for a week :P [23:31:25] jackmcbarn: I don't see any wikibase patches open [23:31:39] at least not on the dash [23:31:40] board [23:31:41] not to wikibase [23:31:49] to mediawiki/core [23:31:51] but still [23:34:19] (03PS4) 10Hoo man: Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) [23:38:59] (03PS5) 10Hoo man: Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391)