[00:21:21] Feedback welcome: https://www.wikidata.org/wiki/User:GPHemsley/Wiktionary [06:47:23] 3MediaWiki extensions / 3WikidataRepo: Allow middle click on suggester - 10https://bugzilla.wikimedia.org/69908 (10Henning) 5PATC>3RESO/FIX [06:59:22] 3MediaWiki extensions / 3WikidataRepo: Autocompletion in linked page suggester missing - 10https://bugzilla.wikimedia.org/66437#c3 (10Henning) So, which authority is going to make a decision, finally? I can identify three options: - no auto-completion (current state) - "hard" auto-completion (old state) Aut... [07:06:53] 3MediaWiki extensions / 3WikidataRepo: disable enter key for entity selector in searchbox - 10https://bugzilla.wikimedia.org/53476#c8 (10Henning) Can we close this ticket, please? It is more than half a year old and altough that would not be a major change, I doubt anyone wants to be blamed for having implem... [07:57:06] [13ValueView] 15snaterlicious created 06suggesterminwidth (+1 new commit): 02http://git.io/aBu3ug [07:57:06] 13ValueView/06suggesterminwidth 146aaac7d 15snaterlicious: $.ui.suggester: Added option to confine suggestion list minimum width [07:58:43] [13ValueView] 15snaterlicious opened pull request #120: $.ui.suggester: Added option to confine suggestion list minimum width (06master...06suggesterminwidth) 02http://git.io/nqM9sw [08:03:22] (03PS1) 10Henning Snater: $.wikibase.entitysearch: Confine minimum width [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169324 [08:05:11] 3MediaWiki extensions / 3WikidataRepo: Suggester box to small - 10https://bugzilla.wikimedia.org/66435#c3 (10Henning) https://github.com/wmde/ValueView/pull/120 [08:06:55] 3MediaWiki extensions / 3WikidataRepo: Suggester box to small - 10https://bugzilla.wikimedia.org/66435#c4 (10Henning) 5REOP>3PATC https://gerrit.wikimedia.org/r/#/c/169324/ [08:27:24] 3MediaWiki extensions / 3WikidataRepo: Floating toolbar for edit-sections - 10https://bugzilla.wikimedia.org/72022 (10tobias.gritschacher) [08:27:25] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) [08:34:37] 3MediaWiki extensions / 3WikidataRepo: Implement structure to store entity image - 10https://bugzilla.wikimedia.org/72524#c2 (10Henning) Thanks for pointing out one of the worst possible solutions again. :-/ Still wondering how users are supposed to understand that mechanism. [08:37:18] (03PS2) 10Thiemo Mättig (WMDE): Drop pointless comments from special page code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168557 [08:41:14] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Merging duplicate code, yea!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168076 (owner: 10Henning Snater) [08:48:48] (03Merged) 10jenkins-bot: Optimized sitelinkgroupview toolbar definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168076 (owner: 10Henning Snater) [08:49:09] (03Merged) 10jenkins-bot: Added $.wikibase.sitelinkview.isEmpty() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168081 (owner: 10Henning Snater) [09:00:37] 3MediaWiki extensions / 3WikidataRepo: Unbalanced padding in suggester drop-down - 10https://bugzilla.wikimedia.org/66436#c1 (10Henning) Is that still an issue? Tried with various browsers on Windows without experiencing any undesired effect. [09:07:08] 3MediaWiki extensions / 3WikidataRepo: in javascript wb.entity does not contain any aliases - 10https://bugzilla.wikimedia.org/62442#c3 (10Adrian Lang) I removed wb.entity in 1beb1c8fa873fa4c549c703859ee1dc459b92bf7 as part of the effort to remove global state and coupling of page / wb context to a single en... [09:07:55] [13WikibaseDataModel] 15thiemowmde created 06iterSerialize (+1 new commit): 02http://git.io/NhmOQA [09:07:55] 13WikibaseDataModel/06iterSerialize 14c4efb02 15Thiemo Mättig: Optimize ReferenceList::serialize [09:08:15] [13WikibaseDataModel] 15thiemowmde opened pull request #261: Optimize ReferenceList::serialize (06master...06iterSerialize) 02http://git.io/s8glIQ [09:11:33] wmde/WikibaseDataModel/iterSerialize/c4efb02 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39241612 [09:12:22] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/rjLAGA [09:12:22] 13WikibaseDataModel/06master 14fe7a420 15Marius Hoch: Merge pull request #261 from wmde/iterSerialize... [09:12:53] 3MediaWiki extensions / 3WikidataRepo: Unbalanced padding in suggester drop-down - 10https://bugzilla.wikimedia.org/66436#c2 (10Thiemo Mättig) 5NEW>3RESO/FIX Can not reproduce any more. Probably fixed with the jQuery update. [09:14:23] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10tobias.gritschacher) p:5Unprio>3High [09:14:38] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10tobias.gritschacher) [09:15:31] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Ok, thanks for the explanation. Want to give Daniel some time to have a look. Otherwise I will merge this the next days." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168831 (owner: 10Aude) [09:20:11] (03CR) 10Adrian Lang: "I'd like to do the renaming in a follow-up, since I don't trust gerrit to display file renames correctly. I could do the renaming in the c" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) (owner: 10Adrian Lang) [09:20:18] (03PS4) 10Adrian Lang: Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 [09:20:20] (03PS5) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [09:24:12] (03PS5) 10Adrian Lang: Remove reindexEntityIds from SqlUsageTracker and UsageTableUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165194 [09:24:21] (03CR) 10jenkins-bot: [V: 04-1] Adapt to new JavaScript datamodel and serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167206 (owner: 10Adrian Lang) [09:24:23] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) [09:24:23] 3MediaWiki extensions / 3WikidataRepo: UI: Create mockup for sticky notification bar - 10https://bugzilla.wikimedia.org/72614 (10tobias.gritschacher) p:5Unprio>3High [09:24:30] (03PS2) 10Adrian Lang: Make SqlStore::rebuildPropertyInfo non-static [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168276 [09:24:38] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) p:5Unprio>3Normal [09:27:54] (03PS6) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [09:28:24] 3MediaWiki extensions / 3WikidataRepo: Widget says errors "will be displayed as '...'" - 10https://bugzilla.wikimedia.org/64331#c2 (10tobias.gritschacher) 5NEW>3RESO/FIX That was fixed some time ago. [09:29:45] (03PS2) 10Adrian Lang: Remove wb.RepoApi.{get,post} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 [09:32:16] (03CR) 10Adrian Lang: "You can grep for RepoApi, that should be fairly simple. Actually, you already did that and I talked about addressing them in my mails with" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 (owner: 10Adrian Lang) [09:32:18] (03CR) 10jenkins-bot: [V: 04-1] Make SqlStore::rebuildPropertyInfo non-static [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168276 (owner: 10Adrian Lang) [09:32:38] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: implement the service - 10https://bugzilla.wikimedia.org/64587 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:32:53] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: design database schema for service that registers where data is used - 10https://bugzilla.wikimedia.org/64586 (10tobias.gritschacher) 5PATC>3RESO/FIX [09:42:22] (03CR) 10Tobias Gritschacher: [C: 031] "looks ok" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168825 (owner: 10Aude) [09:45:31] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove reindexEntityIds from SqlUsageTracker and UsageTableUpdater (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165194 (owner: 10Adrian Lang) [09:49:28] (03CR) 10Thiemo Mättig (WMDE): "Not so sure." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168825 (owner: 10Aude) [09:51:38] 3MediaWiki extensions / 3WikidataRepo: Possibility to enter new sitelink instantly when editing sitelink-section - 10https://bugzilla.wikimedia.org/72023#c2 (10tobias.gritschacher) Browsertests need adjustments. [09:51:39] (03Merged) 10jenkins-bot: Remove reindexEntityIds from SqlUsageTracker and UsageTableUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165194 (owner: 10Adrian Lang) [09:52:26] (03CR) 10Tobias Gritschacher: [V: 04-1] "Browsertests need adjustments." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168293 (owner: 10Henning Snater) [10:09:07] (03PS3) 10Thiemo Mättig (WMDE): Much more clean up in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 [10:15:23] (03CR) 10jenkins-bot: [V: 04-1] Much more clean up in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 (owner: 10Thiemo Mättig (WMDE)) [10:18:05] (03CR) 10Adrian Lang: [C: 04-1] "DatabaseUpdater tries to log the update that happened; for that, it serializes the update definition. Defining it on an instance instead o" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168276 (owner: 10Adrian Lang) [10:20:54] 3MediaWiki extensions / 3WikidataRepo: adapt entity suggester to new dump format - 10https://bugzilla.wikimedia.org/70335 (10tobias.gritschacher) 5NEW>3PATC [10:26:59] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Manually tested. Does what it's supposed to do." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168825 (owner: 10Aude) [10:36:53] (03Merged) 10jenkins-bot: Remove code in ViewEntityAction, duplicating Article::isCurrent() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168825 (owner: 10Aude) [10:36:55] (03Merged) 10jenkins-bot: Split ViewEntityAction labelText code into several methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168830 (owner: 10Aude) [10:38:50] (03Draft1) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [10:40:12] (03CR) 10Aude: [C: 04-1] "this is more how daniel wants this..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [10:42:40] (03CR) 10Aude: Remove code in ViewEntityAction, duplicating Article::isCurrent() (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168825 (owner: 10Aude) [10:43:23] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/10/28 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169342 [10:43:48] (03Draft1) 10Aude: Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 [10:46:39] [13ValueView] 15snaterlicious created 06highlightsubstring (+1 new commit): 02http://git.io/-tAhoQ [10:46:39] 13ValueView/06highlightsubstring 148dba504 15snaterlicious: Replaced $.util.highlightMatchingCharacters with $.util.highlightSubstring [10:47:06] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06iterSerialize at 14c4efb02: 02http://git.io/1b8n7Q [10:49:05] [13ValueView] 15snaterlicious opened pull request #121: Replaced $.util.highlightMatchingCharacters with $.util.highlightSubstring (06master...06highlightsubstring) 02http://git.io/1J7YMA [11:03:56] (03PS1) 10Adrian Lang: Revert "Revert "Actually put wb.client.getMwApiForRepo in wb.client"" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 [11:04:51] (03CR) 10Adrian Lang: "@aude I need this in the branch, because I want to direct people to this, and it should be in the right namespace so we don't have to chan" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:05:39] Adrian_WMDE: but it didn't work [11:05:54] I fixed it, was trivial [11:05:58] ok [11:07:12] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/10/28 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169342 (owner: 10Tobias Gritschacher) [11:07:34] (03CR) 10Hoo man: "I'd suggest waiting for another week, this is IMO not worth a deploy on its own." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:09:13] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/10/28 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/169342 (owner: 10Tobias Gritschacher) [11:10:16] (03CR) 10Adrian Lang: "Yes, it should be, but right now the branch breaks wb.RepoApi usage and this is part of the migration path I want to give out to the users" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:19:43] (03CR) 10Aude: [C: 031] "works ok now. @hoo it's not too much trouble to get this in the branch and think it makes the migration path easier.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:20:50] (03CR) 10Hoo man: "Ok," (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:21:17] (03CR) 10Hoo man: [C: 04-1] "didn't know that... in that case I'm ok with this, but please fix the commit message." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:29:05] (03PS2) 10Adrian Lang: Actually put wb.client.getMwApiForRepo in (the newly created) wb.client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 [11:29:54] (03PS3) 10Hoo man: Actually put wb.client.getMwApiForRepo in (the newly created) wb.client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:30:07] (03CR) 10Hoo man: [C: 032] Actually put wb.client.getMwApiForRepo in (the newly created) wb.client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:35:06] (03PS1) 10Aude: Actually put wb.client.getMwApiForRepo in (the newly created) wb.client [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169345 [11:36:07] 3MediaWiki extensions / 3WikidataRepo: disable enter key for entity selector in searchbox - 10https://bugzilla.wikimedia.org/53476#c9 (10Helder) (In reply to Thiemo Mättig from comment #7) > Why not? Isn't being sent to a search results page what you expect when > hitting enter in a search field? Not if the... [11:40:05] (03Merged) 10jenkins-bot: Actually put wb.client.getMwApiForRepo in (the newly created) wb.client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169343 (owner: 10Adrian Lang) [11:45:33] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06fingerprint: 02http://git.io/MVuWPA [11:45:33] 13WikibaseDataModelJavaScript/06fingerprint 14412b2da 15snaterlicious: (Re-)implemented LegacyEntityId [12:15:32] !nyan [12:15:32] ~=[,,_,,]:3 [12:33:27] The stats for Wikidata have run again ... https://tools.wmflabs.org/wikidata-todo/stats.php?reverse [12:33:29] (03CR) 10Aude: [C: 032 V: 032] Actually put wb.client.getMwApiForRepo in (the newly created) wb.client [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169345 (owner: 10Aude) [12:39:30] (03PS1) 10Aude: Update Wikidata, fix for js api code in client [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169348 [12:46:27] (03CR) 10Aude: [C: 032] Update Wikidata, fix for js api code in client [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169348 (owner: 10Aude) [12:48:20] (03Merged) 10jenkins-bot: Update Wikidata, fix for js api code in client [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169348 (owner: 10Aude) [12:55:25] 3MediaWiki extensions / 3WikidataRepo: snakview always overwrites property label in edit mode - 10https://bugzilla.wikimedia.org/72622 (10Henning) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When selecting a property in the snakview, the property label is re-set as soon as the entityselector's "selecte... [12:56:37] 3MediaWiki extensions / 3WikidataRepo: Suggester is case-sensitive but shouldn't - 10https://bugzilla.wikimedia.org/66715#c1 (10Henning) First off, this bug seems to be about the entityselector. The suggester itself does not care about letter case. Restoring case insensitivity in the entityselector would be... [12:56:52] 3MediaWiki extensions / 3WikidataRepo: snakview always overwrites property label in edit mode - 10https://bugzilla.wikimedia.org/72622 (10Henning) [13:02:39] aude: >_> SO I tagged DM without updating the PHP constant [13:02:40] aggggggggggggggggggggg [13:02:52] aaaaaaa [13:04:32] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ApdPXw [13:04:32] 13WikibaseDataModel/06master 14ddb7d18 15jeroendedauw: Update version number [13:04:53] [13WikibaseDataModel] 15JeroenDeDauw tagged 062.1.1 at 06master: 02http://git.io/EQgFig [13:07:37] aude: you can haz tag with correct version number [13:07:49] wmde/WikibaseDataModel/2.1.1/ddb7d18 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39260730 [13:07:56] :) [13:08:30] (03PS3) 10Henning Snater: Remove sitelinkview when hitting backspace in first input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168294 [13:16:33] (03PS1) 10Thiemo Mättig (WMDE): Refactor another big method in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169352 [13:19:22] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419#c3 (10Adrian Lang) After a good amount of code restructuring, I now want to start on determining what actually belongs to this soon-to-be API module. [13:30:25] 3MediaWiki extensions / 3WikidataRepo: Make statement view use claimview instead of inherit - 10https://bugzilla.wikimedia.org/72312 (10Adrian Lang) [13:30:25] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10Adrian Lang) [13:36:49] [13WikibaseQuery] 15thiemowmde created 06jsDoc (+1 new commit): 02http://git.io/a6L4lw [13:36:49] 13WikibaseQuery/06jsDoc 14c6af810 15Thiemo Mättig: Fix JSDoc comments [13:37:01] [13WikibaseQuery] 15thiemowmde opened pull request #56: Fix JSDoc comments (06master...06jsDoc) 02http://git.io/6aZWnA [13:38:13] wmde/WikibaseQuery/jsDoc/c6af810 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/39263707 [13:40:34] (03PS1) 10Jeroen De Dauw: Remove bad dependency from NoBadDependencyUsageTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169360 [13:43:53] Thiemo_WMDE: mergeeeeeeeeeeee https://gerrit.wikimedia.org/r/#/c/169360/ [13:44:07] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "In my manual test on my machine all "add" buttons are gone. Not sure why. There is no error message in the JS console." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [13:44:13] That obviously fails when you split the git repo [13:46:30] (03CR) 10Thiemo Mättig (WMDE): "Ouch. It's not this patch. All "edit" buttons (sorry, I said "add" but meant "edit") are gone in the current master." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [13:52:58] [13WikibaseQuery] 15mariushoch 04deleted 06jsDoc at 14c6af810: 02http://git.io/OgKpYA [13:54:25] [13ValueView] 15mariushoch closed pull request #119: Fix minor code smell issues (06master...06jsCodeSmell) 02http://git.io/WJd5Tg [13:55:24] wmde/WikibaseQuery/master/097e83e : Marius Hoch The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/39265194 [13:57:35] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Darn, I was in the wrong repo. It's this patch. All "edit" buttons are gone." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [14:04:22] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379#c3 (10Adrian Lang) jquery.wikibase.entityview, line 103. [14:08:19] (03PS1) 10Thiemo Mättig (WMDE): Fix horrible typo in Wikibase.hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 [14:09:36] (03CR) 10Aude: [C: 032] "omg!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 (owner: 10Thiemo Mättig (WMDE)) [14:10:03] (03CR) 10Thiemo Mättig (WMDE): "Introduced in I9de1c73." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 (owner: 10Thiemo Mättig (WMDE)) [14:11:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Manually tested. Works. Love it. Thanks!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168989 (owner: 10Henning Snater) [14:12:28] (03PS1) 10Aude: Fix horrible typo in Wikibase.hooks [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169379 [14:13:09] (03CR) 10Aude: "sure i had fixed that already.... how did this get unfixed?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 (owner: 10Thiemo Mättig (WMDE)) [14:14:30] (03CR) 10Aude: [C: 032] Fix horrible typo in Wikibase.hooks [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169379 (owner: 10Aude) [14:24:46] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration from 142121907 to 14ddbf6a6: 02http://git.io/bcVHHg [14:24:46] 13WikibaseQueryEngine/06dvintegration 14ddbf6a6 15Thiemo Mättig: BooleanHandlerIntegrationTest [14:33:10] wmde/WikibaseQueryEngine/dvintegration/ddbf6a6 : Thiemo Mättig The build was broken. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/39268995 [14:38:38] (03CR) 10Aude: [V: 032] Fix horrible typo in Wikibase.hooks [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169379 (owner: 10Aude) [14:39:51] (03CR) 10Henning Snater: "I can confirm the statement "edit" buttons not being there, but all others do exist." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [14:40:40] (03PS1) 10Aude: Fix typo in Wikibase hooks [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169491 [14:41:51] (03CR) 10Thiemo Mättig (WMDE): "Yes, that's what I meant. Thanks for checking." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [14:42:16] (03CR) 10Aude: [C: 032] Fix typo in Wikibase hooks [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169491 (owner: 10Aude) [14:52:33] (03PS5) 10Henning Snater: Suppress redrawing when initializing toolbar on existing nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 [14:56:23] (03CR) 10Aude: [V: 032] Fix typo in Wikibase hooks [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169491 (owner: 10Aude) [14:58:39] is possible to extract all pages with a property equal to a value from the APIs? [14:58:58] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Suppress redrawing when initializing toolbar on existing nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [15:04:22] [13WikibaseDataModel] 15JeroenDeDauw created 06sld (+1 new commit): 02http://git.io/NEa-2A [15:04:22] 13WikibaseDataModel/06sld 14b2920c2 15jeroendedauw: WIP - Remove usage of Claims [15:11:23] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10tobias.gritschacher) [15:11:39] 3MediaWiki extensions / 3WikidataRepo: Floating toolbar for edit-sections - 10https://bugzilla.wikimedia.org/72022 (10tobias.gritschacher) [15:11:53] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169 (10tobias.gritschacher) [15:12:08] 3MediaWiki extensions / 3WikidataRepo: Move JS WikibaseAPI code into its own component - 10https://bugzilla.wikimedia.org/66419 (10tobias.gritschacher) [15:12:23] 3MediaWiki extensions / 3WikidataClient: Usage Tracking: hook up property parser function to record usage - 10https://bugzilla.wikimedia.org/64588 (10tobias.gritschacher) [15:12:53] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [15:16:50] wmde/WikibaseDataModel/sld/b2920c2 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/39274206 [15:18:23] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [15:20:15] (03CR) 10Aude: Fix horrible typo in Wikibase.hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 (owner: 10Thiemo Mättig (WMDE)) [15:20:21] (03CR) 10Aude: [C: 032] Fix horrible typo in Wikibase.hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 (owner: 10Thiemo Mättig (WMDE)) [15:20:46] (03PS1) 10Thiemo Mättig (WMDE): Reduce line-height in qualifiers list view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169503 [15:21:28] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=72310 is that the right task for the batching-stuff? [15:21:40] can you make an estimation then? [15:21:51] no [15:22:20] we need to make a batching term lookup [15:22:29] 2) use it in the entity id label formatter [15:22:52] 3) investigate / implement to use it for watchlist / recent changes [15:22:59] which is this bug [15:23:44] is possible to extract all pages with a property equal to a value from the APIs? [15:23:59] aude: ok, then I think there is no bug yet? [15:24:07] fale: you have to use magnus' query tool [15:24:35] aude: or did you create one already? [15:24:38] Tobi_WMDE_SW: don't know, not tha ti know [15:24:46] ok [15:25:02] aude: then I'll create one [15:25:03] creating batchign look up is easy (3pt) [15:25:10] aude: thanks a lot :) [15:25:17] using it is harder but i suppose part of #72036 [15:25:25] fale: do you need a link? [15:25:37] aude: google told me http://wdq.wmflabs.org/wdq/ :) [15:25:42] aude: can you make an estimation for doing the batched term-lookup? [15:25:47] at some point, we will have such capabilities in wikidata itself (e.g. to use the results in wikipedia) [15:25:55] Tobi_WMDE_SW: 3 points, maybe 5? [15:26:03] 5 then [15:26:06] i already have a draft actually [15:26:37] fale: yep, that's it [15:26:41] (03Merged) 10jenkins-bot: Fix horrible typo in Wikibase.hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169367 (owner: 10Thiemo Mättig (WMDE)) [15:26:46] aude: thanks a lot :) [15:26:47] (03Merged) 10jenkins-bot: $.wikibase.entitysearch: Set/Update link of "containing" item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168989 (owner: 10Henning Snater) [15:26:50] sure [15:27:08] 3MediaWiki extensions / 3WikidataRepo: Batch term-lookups - 10https://bugzilla.wikimedia.org/72627 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [15:27:38] 3MediaWiki extensions / 3WikidataRepo: Right/middle click on "containing..." still triggers the search - 10https://bugzilla.wikimedia.org/66432 (10Henning) 5PATC>3RESO/FIX [15:37:36] (03Merged) 10jenkins-bot: Suppress redrawing when initializing toolbar on existing nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 (owner: 10Henning Snater) [15:47:24] 3MediaWiki extensions / 3WikidataRepo: [UI] Lightweight toolbars to initialize full toolbars - 10https://bugzilla.wikimedia.org/60342#c2 (10Henning) 5PATC>3RESO/FIX Just one note: As of https://gerrit.wikimedia.org/r/#/c/167177/, some toolbars (e.g. the statement "edit" toolbars) are not rendered in the... [16:08:37] 3MediaWiki extensions / 3WikidataRepo: Wrong parsing of centuries and millennia - 10https://bugzilla.wikimedia.org/71459#c3 (10Henning) This is an issue of the back-end parser. Submitting "20. century" to the parser results in returning {"time":"+0000000000002000-00-00T00:00:00Z","timezone":0,"before":0,"aft... [16:10:26] (03PS2) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [16:12:22] gah [16:13:16] (03CR) 10jenkins-bot: [V: 04-1] Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [16:14:54] (03PS3) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [16:14:56] (03PS2) 10Aude: Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 [16:17:39] 3MediaWiki extensions / 3WikidataRepo: time formatting issues with some precisions - 10https://bugzilla.wikimedia.org/67604#c8 (10Henning) 5PATC>3RESO/FIX Seems like it has been forgotten to set the ticket to "fixed" (at the end, it is just high/major anyway... ;) ). Since the change has been merged, I j... [16:19:47] (03CR) 10Aude: [C: 04-2] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [16:20:12] (03PS4) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [16:20:14] (03PS3) 10Aude: Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 [16:23:37] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395#c2 (10Henning) We basically have two bugs about the same issue (the other one being #70398). This one is high/major, the other one highest/major (the only on... [16:25:44] (03CR) 10jenkins-bot: [V: 04-1] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [16:28:02] (03CR) 10jenkins-bot: [V: 04-1] Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [16:35:09] (03CR) 10Aude: "see I420df6 for new approach based on feedback." (0316 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167755 (owner: 10Aude) [16:35:19] (03Abandoned) 10Aude: Initial implementation TermLookup [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167755 (owner: 10Aude) [16:38:57] (03PS5) 10Aude: Implement LabelLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 [16:38:59] (03PS4) 10Aude: Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 [16:45:05] (03CR) 10jenkins-bot: [V: 04-1] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [17:22:22] DanielK_WMDE_: I think I remember you were working on something to make page_props queryable by the property value, did that ever happen? [17:22:38] 3MediaWiki extensions / 3WikidataRepo: Make statement view use claimview instead of inherit - 10https://bugzilla.wikimedia.org/72312 (10tobias.gritschacher) [17:22:44] legoktm: i think it's in core, but i'm not sure the schema chaneg got deployed [17:22:57] $wgPagePropsHaveSortkey is set to true on production [17:23:23] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10tobias.gritschacher) [17:23:38] 3MediaWiki extensions / 3WikidataRepo: Update JavaScript datamodel and serialization code - 10https://bugzilla.wikimedia.org/72418 (10tobias.gritschacher) [17:24:37] I'm trying to figure out a good way to be able to make API requests on a client site to get info about the page associated with a Q## I have, without having to make an API request to the repo wiki. I was thinking about using the page_props table to do a query on what the value for wikibase_item is [17:26:09] 3MediaWiki extensions / 3WikidataRepo: UI: Create specifications for sticky notification bar - 10https://bugzilla.wikimedia.org/72614#c1 (10tobias.gritschacher) 5NEW>3ASSI Specifications how sticky notification should work with the current UI. Can be extended by some mockups. [17:26:15] but doing a basic query for that on labs (using pp_value as opposed to pp_sortkey) took 30 seconds :/ [17:27:47] should wikibase_item be setting a pp_sortkey value? [17:28:38] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) [17:28:54] 3MediaWiki extensions / 3WikidataRepo: UI: Implement sticky notification bar - 10https://bugzilla.wikimedia.org/72419 (10tobias.gritschacher) 5NEW>3ASSI [17:29:23] 3MediaWiki extensions / 3WikidataRepo: Reset edit-mode when error occurs during a request-queue - 10https://bugzilla.wikimedia.org/72311 (10tobias.gritschacher) [17:31:54] 3MediaWiki extensions / 3WikidataRepo: Review and tag new version of PropertySuggester - 10https://bugzilla.wikimedia.org/72632 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Support JSON dumps: https://github.com/Wikidata-lib/PropertySuggester-Python/pull/13 Consider classifying... [17:32:08] 3MediaWiki extensions / 3WikidataRepo: Review and tag new version of PropertySuggester - 10https://bugzilla.wikimedia.org/72632 (10tobias.gritschacher) 5NEW>3ASSI [17:32:38] 3MediaWiki extensions / 3WikidataRepo: Review and tag new version of PropertySuggester - 10https://bugzilla.wikimedia.org/72632 (10tobias.gritschacher) p:5Unprio>3Normal [17:35:38] 3MediaWiki extensions / 3WikidataRepo: Set "language"-parameter when doing API calls from the UI - 10https://bugzilla.wikimedia.org/72633 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [17:35:54] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393 (10tobias.gritschacher) [17:37:53] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393 (10tobias.gritschacher) [17:37:54] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059 (10tobias.gritschacher) [17:38:38] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059 (10tobias.gritschacher) p:5High>3Normal [17:39:08] 3MediaWiki extensions / 3WikidataRepo: Set "language"-parameter when doing API calls from the UI - 10https://bugzilla.wikimedia.org/72633#c1 (10tobias.gritschacher) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 63059 *** [17:39:24] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059#c1 (10tobias.gritschacher) *** Bug 72633 has been marked as a duplicate of this bug. *** [17:39:38] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393 (10tobias.gritschacher) [17:39:39] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059 (10tobias.gritschacher) [17:39:53] 3MediaWiki extensions / 3WikidataRepo: wbparsevalue API calls are missing the lang option - 10https://bugzilla.wikimedia.org/63059 (10tobias.gritschacher) 5NEW>3ASSI [17:39:53] Tobi_WMDE_SW: spam spam spam [17:40:01] aude: "stuffing a LanguageFallbackChain" :D [17:40:25] (03CR) 10Jeroen De Dauw: "I approve of the wording in the commit message :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [17:40:28] JeroenDeDauw: not me. that's the stupid bot [17:40:48] Tobi_WMDE_SW: sure, blame the robots [17:41:02] it's always the robots! [17:45:01] Tobi_WMDE_SW: you will regret saying that when the singularity comes! ;p [17:45:07] (03CR) 10Daniel Kinzler: [C: 032] Refactor another big method in ViewEntityAction (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169352 (owner: 10Thiemo Mättig (WMDE)) [17:45:09] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement LabelLookup (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [17:48:20] (03CR) 10Jeroen De Dauw: Implement LabelLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [17:50:20] (03Merged) 10jenkins-bot: Refactor another big method in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169352 (owner: 10Thiemo Mättig (WMDE)) [17:51:28] (03CR) 10Jeroen De Dauw: Implement LabelLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [17:56:28] (03CR) 10Jeroen De Dauw: "Generally like what this commit does - just some easy to fix issues need tackling" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169330 (owner: 10Aude) [18:35:14] dennyvrandecic: Thanks for fixing the notes in etherpad :) [20:26:57] (03PS2) 10JanZerebecki: Use factory class to construct SpecialEntitiesWithoutPage instances [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [20:31:12] (03CR) 10JanZerebecki: [C: 032] Use factory class to construct SpecialEntitiesWithoutPage instances [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [20:33:55] (03CR) 10jenkins-bot: [V: 04-1] Use factory class to construct SpecialEntitiesWithoutPage instances [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [20:38:50] (03CR) 10JanZerebecki: "PS2 was just a manual rebase because the deleted files had some changes. I'm not looking into the build failure today anymore." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162903 (owner: 10Bene) [21:31:25] 3MediaWiki extensions / 3WikidataClient: After new release for RTL languages claims disappear - 10https://bugzilla.wikimedia.org/72647 (10reza1615) 3NEW p:3Unprio s:3normal a:3Wikidata bugs After new release for RTL languages claims disappear! they move to left and disappear http://www.wikidata.org/... [21:31:52] 3MediaWiki extensions / 3WikidataClient: After new release for RTL languages claims disappear - 10https://bugzilla.wikimedia.org/72647 (10reza1615) p:5Unprio>3High s:5normal>3major [21:33:53] 3MediaWiki extensions / 3WikidataClient: After new release for RTL languages claims disappear - 10https://bugzilla.wikimedia.org/72647#c1 (10reza1615) Created attachment 16935 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16935&action=edit empty claim [21:48:25] 3MediaWiki extensions / 3WikidataClient: Added Statements will be shown in english - 10https://bugzilla.wikimedia.org/72648 (10reza1615) 3NEW p:3Unprio s:3normal a:3Wikidata bugs I use Farsi as setlang When I add a Statement it will be shown in English after refreshing the page it will be switch to f... [21:49:07] 3MediaWiki extensions / 3WikidataClient: Added Statements will be shown in english - 10https://bugzilla.wikimedia.org/72648#c1 (10reza1615) Created attachment 16936 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16936&action=edit English statment [21:53:08] 3MediaWiki extensions / 3WikidataClient: Added Statements will be shown in english - 10https://bugzilla.wikimedia.org/72648#c2 (10Aude) 5NEW>3RESO/DUP this is a known issue :/ and something we are looking into. *** This bug has been marked as a duplicate of bug 72393 *** [21:53:08] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393#c5 (10Aude) *** Bug 72648 has been marked as a duplicate of this bug. *** [22:17:48] Hi. I just created a new Wikipedia article about a person. Now I would like to add some info on Wikidata as well. Do I need to create a new item or was that already done automatically when I created the Wikipedia page? [22:18:10] (I'm talking about [[:de:Wenzel Goldbaum]]) [22:18:21] sorry for the unintended smiley [22:18:56] No, it's not done automatically [22:19:18] https://www.wikidata.org/w/index.php?search=Wenzel+Goldbaum&title=Special%3ASearch&fulltext=Search [22:20:32] thanks, Reedy! [22:20:48] I think there's probably bots that will create it eventually [22:20:57] But you can just do it yourself easily enough [22:22:36] (03PS1) 10Ebrahim: Choose right side for positioning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169609 (https://bugzilla.wikimedia.org/72648) [22:27:45] (03PS2) 10Ebrahim: Choose correct side for positioning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169609 (https://bugzilla.wikimedia.org/72647) [22:31:38] 3MediaWiki extensions / 3WikidataRepo: property values formatted in english when entering them in non-english - 10https://bugzilla.wikimedia.org/72393#c6 (10Calak) *** Bug 72648 has been marked as a duplicate of this bug. *** [22:31:38] 3MediaWiki extensions / 3WikidataClient: Added Statements will be shown in english - 10https://bugzilla.wikimedia.org/72648#c4 (10Calak) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 72393 *** [22:33:52] How to hot patch Wikidata? Patching operations/mediawiki-config or extensions/Wikidata? [22:34:15] aude: Can you help on ^? [22:38:24] ebraminio: what are you trying to patch? [22:39:20] JohnLewis: not now but when https://gerrit.wikimedia.org/r/169609 landed it should be done on live Wikidata [22:40:02] IMO, because it is severe issue, we can not see type of claim even on our language [22:40:32] Lydia_WMDE can help you :p [22:41:56] The patch fix the issue on my test wiki http://tools.wmflabs.org/ebraminio-dev/w/index.php?title=Item:Q2&uselang=fa compare it with http://www.wikidata.org/wiki/Q4795114?setlang=fa [22:42:46] ebraminio: aude and hoo should have a look [22:42:48] thanks for patching [22:42:49] (a bit scroll on http://www.wikidata.org/wiki/Q4795114?setlang=fa with mouse) [22:44:10] Sorry, what's broken? [22:48:44] hoo: https://gerrit.wikimedia.org/r/169609 [22:49:35] hoo: Open http://www.wikidata.org/wiki/Q4795114?setlang=fa scroll a bit with mouse, property name will moved to left and can not be seen [22:49:46] ebraminio: Ok, just saw taht [22:49:48] very awry [22:50:18] patch looks ok to me, although i like to test it locally [22:50:26] (03CR) 10Hoo man: [C: 032] Choose correct side for positioning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169609 (https://bugzilla.wikimedia.org/72647) (owner: 10Ebrahim) [22:50:34] arlight :) [22:50:44] :P [22:50:57] quick, we can get it into swat :) [22:51:04] Feel free to test more... I tested it very briefly and it looks ok [22:51:21] ok [22:51:26] swat is in 9 minutes.... [22:51:33] :S [22:51:37] Can you take care maybe? [22:51:46] I have to get up at 6am tomorrow [22:51:47] :S [22:51:57] sure, either in 9 minute or otherwise tomorrow [22:52:03] probably tonight [22:52:07] \o/ [22:52:15] * hoo hands aude some chocolate [22:52:32] :) [22:53:08] (03PS1) 10Aude: Choose correct side for positioning [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169618 (https://bugzilla.wikimedia.org/72647) [22:53:43] Leaving then... good night ;) [22:54:13] thanks aude! [22:54:31] good night [22:57:24] (03Merged) 10jenkins-bot: Choose correct side for positioning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169609 (https://bugzilla.wikimedia.org/72647) (owner: 10Ebrahim) [23:01:41] (03CR) 10Aude: [C: 032] Choose correct side for positioning [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169618 (https://bugzilla.wikimedia.org/72647) (owner: 10Aude) [23:05:35] (03CR) 10Aude: [V: 032] "manually verified and jenkins already approves" [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169618 (https://bugzilla.wikimedia.org/72647) (owner: 10Aude) [23:07:26] (03PS1) 10Aude: Update Wikidata, fix rtl issue in statements js [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169620 [23:08:02] (03CR) 10Aude: [C: 032] Update Wikidata, fix rtl issue in statements js [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169620 (owner: 10Aude) [23:10:04] (03Merged) 10jenkins-bot: Update Wikidata, fix rtl issue in statements js [extensions/Wikidata] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/169620 (owner: 10Aude) [23:13:40] ebraminio: deployed! [23:13:46] looks good to me but do you want to check? [23:14:14] aude: Works great, thank you :) [23:14:19] yay [23:14:34] * aude thinks this is record quick to get a patch out :) [23:14:40] normally not this quick [23:14:51] thanks for the patch! [23:16:10] aude: :D [23:22:37] 3MediaWiki extensions / 3WikidataClient: After new release for RTL languages claims disappear - 10https://bugzilla.wikimedia.org/72647 (10Calak) 5PATC>3RESO/FIX