[06:11:52] hi. I have a question about the Wikidata RDF dumps [06:13:08] I'm getting an error: illegal escape sequence value: " (0x22) when I try to load it (into Jena) [06:13:17] org.apache.jena.riot.RiotException: [line: 142128, col: 121] illegal escape sequence value: " (0x22) [06:13:39] line 142128 looks like this: . [06:14:00] Reading the RDF spec http://www.w3.org/TR/n-triples/#n-triples-grammar [06:14:17] I see [9] STRING_LITERAL_QUOTE ::= '"' ([^#x22#x5C#xA#xD] | ECHAR | UCHAR)* '"' [06:14:49] To me that looks like "R might be an illegal sequence? [06:17:35] hmm.. no one around? [06:17:57] nloth the latest ones are all corrupted due to a change in the JSON format [06:18:11] they did not fix it. I am not aware that they know how to [06:18:37] The RDF dumps are corrupted coz of a change in the JSON format? [06:18:39] both for the future dumps and for the ones that exist [06:18:57] ok well that explains it :( [06:19:27] thanks [06:21:45] yeo [06:21:45] yep [06:22:14] as a result there are no latest statistics for Wikidata [07:40:16] [13Geo] 15thiemowmde comment on pull request #28 144051ae0: The `{0}` syntax is deprecated in PHP 6. It was never a good idea to use it. It's so confusing to use curly brackets for array access.... 02http://git.io/ZqQmuw [07:41:16] [13Geo] 15thiemowmde pushed 1 new commit to 06charAt: 02http://git.io/eiHorA [07:41:16] 13Geo/06charAt 148b341e3 15thiemowmde: Reset version [07:47:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Obvious copy and paste error from Article.php which happens to have the exact same line." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168383 (https://bugzilla.wikimedia.org/72441) (owner: 10Aude) [07:48:08] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Flow\Content\Content::onShowMissingArticle() must be an instance of Article, instance of Wikibase\ViewItemAction in Content.php - 10https://bugzilla.wikimedia.org/72441 (10Thiemo Mättig) 5PATC>3RESO/FIX [07:53:25] (03Merged) 10jenkins-bot: Provide Article object for ShowMissingArticle hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168383 (https://bugzilla.wikimedia.org/72441) (owner: 10Aude) [07:53:54] 3MediaWiki extensions / 3WikidataRepo: Wikidata properties linking media should show up in GlobalUsage - 10https://bugzilla.wikimedia.org/46358#c18 (10Maarten Dammers) (In reply to Aude from comment #17) > https://gerrit.wikimedia.org/r/#/c/155896/ is the patch > > I am not sure about doing a purge but mayb... [08:19:24] (03CR) 10Thiemo Mättig (WMDE): Fix code smell issues/drop unused PHP code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [09:09:58] (03PS1) 10Thiemo Mättig (WMDE): Drop pointless comments from special page code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168557 [09:18:53] 3MediaWiki extensions / 3WikidataRepo: Possibility to enter new sitelink instantly when editing sitelink-section - 10https://bugzilla.wikimedia.org/72023#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/168293/ [09:22:09] 3MediaWiki extensions / 3WikidataRepo: Can't save sitelinks after i add one, then click add to add another - 10https://bugzilla.wikimedia.org/72447#c1 (10Henning) 5NEW>3PATC The behaviour is the expected current behaviour of the UI. Will change with bug #72023. Referring to the same change set: https://g... [09:29:25] 3MediaWiki extensions / 3WikidataRepo: Badge selector not recognizing badges currently set while fetching their data - 10https://bugzilla.wikimedia.org/72472 (10Henning) 3NEW p:3Unprio s:3normal a:3Wikidata bugs After stopping edit mode on a site link group, missing data for badges is fetched via the... [09:30:07] (03PS1) 10Henning Snater: $.wikibase.badgeselector: Display placeholder badges while fetching badge data [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168561 [09:30:34] (03CR) 10JanZerebecki: [C: 04-1] "Sorry, this git repository only contains the build result, so this change would be undone on the next one." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/168399 (https://bugzilla.wikimedia.org/71928) (owner: 10Southparkfan) [09:30:54] 3MediaWiki extensions / 3WikidataRepo: Badge selector not recognizing badges currently set while fetching their data - 10https://bugzilla.wikimedia.org/72472#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/168561/ [09:41:23] 3MediaWiki extensions / 3WikidataRepo: description edit button is misaligned - 10https://bugzilla.wikimedia.org/72375#c2 (10Henning) I suppose https://gerrit.wikimedia.org/r/#/c/161453/ is not deployed (at least that is what the CSS is telling me)? I am aware that this was broken but it should be fixed along... [09:43:19] (03PS1) 10Henning Snater: Make section heading use full width [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168564 [09:43:53] 3MediaWiki extensions / 3WikidataRepo: statement add button is misplaced /aligned on item with no statements yet - 10https://bugzilla.wikimedia.org/72446#c1 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/168564/ [09:48:30] (03PS1) 10Henning Snater: sitelinkgroupview: Reset edit mode when an error occurs while saving [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168565 [09:50:54] 3MediaWiki extensions / 3WikidataRepo: Reset edit-mode when error occurs during a request-queue - 10https://bugzilla.wikimedia.org/72311#c1 (10Henning) 5NEW>3ASSI https://gerrit.wikimedia.org/r/#/c/168565/ There will be an additional change set for the fingerprint. [09:57:14] (03CR) 10Daniel Kinzler: [C: 032] Don't use BasicEntityIdParser in WikiPageEntityRevisionLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168125 (owner: 10Aude) [09:59:51] (03PS1) 10Southparkfan: Fix file permissions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168568 (https://bugzilla.wikimedia.org/71928) [09:59:52] 3MediaWiki extensions / 3WikidataRepo: aliases save button not disabled when clicking edit but not entering or changing anything yet - 10https://bugzilla.wikimedia.org/72440#c1 (10Henning) Unable to reproduce locally. Does that occur after https://gerrit.wikimedia.org/r/#/c/161453/? What is the last commit? [10:02:20] (03Merged) 10jenkins-bot: Don't use BasicEntityIdParser in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168125 (owner: 10Aude) [10:03:12] (03CR) 10Hoo man: [C: 032] Fix file permissions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168568 (https://bugzilla.wikimedia.org/71928) (owner: 10Southparkfan) [10:05:39] Thiemo_WMDE: another look at https://gerrit.wikimedia.org/r/#/c/161487/19 ? [10:08:17] (03Merged) 10jenkins-bot: Fix file permissions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168568 (https://bugzilla.wikimedia.org/71928) (owner: 10Southparkfan) [10:11:02] (03PS20) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) [10:13:08] (03PS18) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [10:13:42] (03CR) 10Daniel Kinzler: [C: 04-1] "rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [10:20:17] (03CR) 10jenkins-bot: [V: 04-1] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [10:34:21] [13DataTypes] 15Southparkfan opened pull request #22: Fix file permissions (06master...06patch-1) 02http://git.io/lhJ2dQ [10:37:24] (03CR) 10Southparkfan: "Hi," [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/168399 (https://bugzilla.wikimedia.org/71928) (owner: 10Southparkfan) [10:37:39] 3MediaWiki extensions / 3WikidataRepo: Maintain order: Have API return and accept lists instead of maps - 10https://bugzilla.wikimedia.org/72297#c2 (10Henning) Of course, the front-end needs to be able to submit order changes to the API as well. At the moment, this can be done by submitting a plain "index" p... [10:37:47] haha sauspanfan [10:37:51] wat [10:38:04] je naam in deze chat haha [10:38:08] haha ja [10:40:49] hahaha... I just saw I had @wikimedia.org in my email reply-to :P [10:41:13] At least those that I sent using evolution in the past few days (maybe one or two) [10:41:55] [13DataTypes] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/DIdFRg [10:41:55] 13DataTypes/06master 148244e1e 15Southparkfan: Fix file permissions... [10:41:55] 13DataTypes/06master 14b4e99fe 15Marius Hoch: Merge pull request #22 from Southparkfan/patch-1... [10:44:36] [13WikibaseDataModel] 15thiemowmde created 06int32loss (+1 new commit): 02http://git.io/PpJjlw [10:44:36] 13WikibaseDataModel/06int32loss 146c30d35 15Thiemo Mättig: [Regression] 32 bit compatibility for numeric ids [10:47:22] wmde/WikibaseDataModel/int32loss/6c30d35 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38914203 [10:50:33] [13WikibaseDataModel] 15thiemowmde opened pull request #258: [Regression] 32 bit compatibility for numeric ids (06master...06int32loss) 02http://git.io/c6r16g [10:50:45] mh... can we run unit tests on 32bit php with travis? [10:52:17] [13WikibaseDataModel] 15thiemowmde created 06siteLinkDeprecations (+1 new commit): 02http://git.io/CDdfCA [10:52:17] 13WikibaseDataModel/06siteLinkDeprecations 14f9c62b4 15Thiemo Mättig: Reduce usage of deprecated SiteLink methods [10:53:42] [13WikibaseDataModel] 15thiemowmde opened pull request #259: Reduce usage of deprecated SiteLink methods (06master...06siteLinkDeprecations) 02http://git.io/nyFOaQ [10:55:02] wmde/WikibaseDataModel/siteLinkDeprecations/f9c62b4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38914961 [11:05:23] 3MediaWiki extensions / 3WikidataRepo: Enable instant edit-mode for empty term input boxes - 10https://bugzilla.wikimedia.org/72021#c1 (10Henning) How is that supposed to behave? Do you have an edit mode without being in edit mode? Do you trigger edit mode for all labels and descriptions when starting to typ... [11:05:38] 3MediaWiki extensions / 3WikidataClient: File permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71928#c3 (10Southparkfan) 5PATC>3RESO/FIX Fixed in https://gerrit.wikimedia.org/r/#/c/168568/, https://github.com/wmde/DataTypes/pull/22 and https://github.com/Wikidata-lib/PropertySuggeste... [11:13:27] (03Abandoned) 10Hoo man: Fix file permissions [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/168399 (https://bugzilla.wikimedia.org/71928) (owner: 10Southparkfan) [11:47:57] (03PS1) 10Thiemo Mättig (WMDE): Remove broken options.api check, now in EntityChangersFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168575 [11:50:19] (03CR) 10Henning Snater: [C: 032] Remove broken options.api check, now in EntityChangersFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168575 (owner: 10Thiemo Mättig (WMDE)) [11:57:11] (03Merged) 10jenkins-bot: Remove broken options.api check, now in EntityChangersFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168575 (owner: 10Thiemo Mättig (WMDE)) [12:02:07] * hoo kills zend php with a rusty knife [12:02:36] * hoo is clueless about https://bugzilla.wikimedia.org/show_bug.cgi?id=72242 now [12:03:12] * aude rage about https://bugzilla.wikimedia.org/show_bug.cgi?id=71479 [12:03:20] though i can actually reproduce it now [12:04:18] I can't [12:04:25] the serialization looks totally ok [12:04:34] :( [12:04:43] no idea how it can go crazy about that [12:04:48] until we hit a php bug [12:04:51] which I guess we do [12:04:55] * unless [12:04:59] wouldn't be surprised if the 2 bugs are related [12:05:12] possible [12:05:26] i am polluting data model with debugging [12:05:26] I also saw it trying to renumber a Exception [12:05:35] and see a lot of Wikibase\DataModel\Statement\Statement:getHash then getValueHash [12:05:41] although the function itself tests is_array before calling again [12:05:42] (from reference list) [12:06:20] with a small item, i can load undo for a change involving a reference [12:06:34] but not for a big one? [12:06:40] with bigger item, i get the error and the 'value' of snak list is a varies [12:09:11] and i think no amount of fancy term lookup or cutting memory / time in other areas will fix this [12:09:20] since it's a memory leak or such [12:09:31] ewk [12:09:36] which php version do you run? [12:09:54] suspect we hit https://bugs.php.net/bug.php?id=65967 [12:10:06] i have 5.3 (what the foundation has) [12:10:19] bug is open [12:10:52] in the warning logs i see stuff about gc [12:11:48] aude: that bug talks about a property named "\x00gcdata" only. no other garbage or corruption. [12:12:46] or maybe there is another bug [12:13:05] I've seen php acting up in the past on nested arrays [12:13:22] especially passing by references seems to be somewhat unstable [12:14:07] there are a ton of gc related crash bugs that were fixed in newer php versions [12:14:30] yes [12:15:01] most of the segfaults we see in production happen in code paths that changed fundamentally since then [12:15:20] (much of the low level stuff around zvals changed) [12:16:22] * hoo would be so happy if we could have moved to a new zend version before going for hhvm [12:16:37] cause hhvm probably wont happen fast enough for us [12:17:01] * aude sure hhvm has new issues (although easier to get fixed) [12:17:30] hhvm is higher quality in general... and they're much more responsive on scary bugs [12:17:34] ops just need to reinstall all the app servers ;) [12:17:37] yep [12:17:53] Reedy: Going to php 5.5 would have been easier than that [12:18:07] we had that discussion before on ops-l or so [12:18:10] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Reuse static toolbar button DOM nodes (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 (owner: 10Henning Snater) [12:18:18] hoo: 5.3.3 good enough? ;) [12:18:35] we're on 5.3.10 now :P [12:18:39] legoktm: There are still users stuck on PHP 4.4.9... you can't ignore them!!11 [12:19:15] * Reedy breaks the sad news to hoo that MW doesn't support PHP 4 [12:20:21] * hoo will try some undos on his large test item [12:20:34] but I have 5.5.17 [12:21:41] (03PS4) 10Henning Snater: Reuse static toolbar button DOM nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 [12:21:52] (03PS5) 10Henning Snater: Reuse static toolbar button DOM nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 [12:22:00] install a precise vm? [12:22:21] mh, that works great [12:22:48] legoktm: :S Then I would have to set up everything [12:22:56] also I guess I'm outgrowing my home, again [12:23:08] * hoo has to resize it every now and then... :P [12:23:19] No planning permission? [12:23:20] it took me ~15 min to install mediawiki on lucid yesterday [12:23:31] lol [12:23:55] Reedy: :D [12:24:18] Hi all, on https://www.wikidata.org/wiki/Wikidata:Bots#All_bots it's written that you must "Be able to set a limit for maximum edits per minute" but I couldn't find some advice on the limit. Any clue ? [12:24:19] aude: Can you come up with some test case hack? [12:24:35] Eg. two revision where undoing the second one will also fail? [12:24:48] i think any references [12:24:56] add referenec then try to undo [12:24:59] aude: Ok, that just worked for me on 5.5 [12:25:07] symac: like, 10 edits per minute is a good speed [12:25:13] reproduced the bug? [12:25:19] aude: Nope, it went just fine [12:25:21] oh [12:25:23] if you go too fast, someone will complain :) [12:25:26] has to be a very big item [12:25:27] yep [12:25:33] no more than 3k edits/ min please [12:25:47] cause that's the point where stuff starts to fail [12:26:11] more seriously: Only do so many that you can a) Keep an eye on and b) undo if stuff goes bad [12:26:38] Ok, will leave the default of pywikibot for now. [12:26:46] aude: 25kb is not enough, I guess? [12:26:58] no [12:27:03] :S [12:27:07] How much do you have? [12:27:07] * aude has ~150kb [12:27:09] oh [12:27:19] not quite germany [12:27:46] probably less would still result in the bug [12:28:14] ok [12:28:25] Not sure how I could get that much data easily [12:28:26] i have a lot of xdebug stuff enabled [12:28:35] that somewhat slows things for me [12:28:40] a script? [12:28:45] pywikibot [12:29:26] i am trying to undo the item on old wikibase (mw1.24-wmf19) and it's timing out [12:30:16] but faster now? [12:30:25] no [12:30:47] i actually thing all the little changes we have done, according to xdebug, result in ~%20 faster [12:30:53] think* [12:31:00] they are in the next branch, right? [12:31:04] yes [12:31:09] :) [12:31:15] won't help with germany (i think) [12:31:16] enough* [12:31:22] Probably not, no [12:31:43] even the slightly larger two versions I tried exploded [12:31:49] probably the same bug here is a problem for germany item [12:31:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Yay!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 (owner: 10Henning Snater) [12:32:21] (03CR) 10JanZerebecki: "Looks good except one small comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [12:32:39] (03CR) 10JanZerebecki: [C: 04-1] Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [12:36:56] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Tests for WikibaseDataModel on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69525#c4 (10Marius Hoch) 5PATC>3RESO/FIX https://travis-ci.org/wmde/WikibaseDataModel :) [12:36:56] 3MediaWiki extensions / 3WikidataClient: Infinite recursion in WikibaseLuaBindings::renumber (leading to OOM) when trying to get Q30 - 10https://bugzilla.wikimedia.org/72242#c1 (10Marius Hoch) Update: This only seems to happen sometimes (in job runners mostly AFAIS), also I checked the data per hand and the... [12:37:24] (03PS5) 10Thiemo Mättig (WMDE): Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 [12:37:31] wow... that comment is more than half an hour old [12:37:48] (03CR) 10JanZerebecki: [C: 032] Drop pointless comments from special page code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168557 (owner: 10Thiemo Mättig (WMDE)) [12:38:34] (03CR) 10JanZerebecki: [C: 032] Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [12:40:02] * aude can load the diff using mw1.24-wmf17 [12:40:15] the undo* [12:40:19] mh [12:40:36] electrician arrived, be back later [12:40:42] ok [12:42:21] (03Merged) 10jenkins-bot: Reuse static toolbar button DOM nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 (owner: 10Henning Snater) [12:44:23] (03CR) 10jenkins-bot: [V: 04-1] Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [12:54:01] [13ValueView] 15thiemowmde closed pull request #93: Boost exact matches in suggestions (06master...06boost) 02http://git.io/EqlKDg [13:12:13] (03PS1) 10Daniel Kinzler: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 [13:17:58] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [13:25:48] (03PS19) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [13:27:08] (03PS2) 10Daniel Kinzler: Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 [13:34:15] (03CR) 10jenkins-bot: [V: 04-1] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [13:34:17] (03CR) 10jenkins-bot: [V: 04-1] Replacing ItemUsageIndex with UsageLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168579 (owner: 10Daniel Kinzler) [14:10:57] (03PS20) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [14:16:11] (03CR) 10jenkins-bot: [V: 04-1] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [14:21:49] (03PS4) 10Daniel Kinzler: Inject ReferencedPageFinder into ChangeHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162837 [14:24:44] (03CR) 10Daniel Kinzler: [C: 04-1] "rebase needs more love. postpone until more usage tracking patches are merged." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162837 (owner: 10Daniel Kinzler) [14:25:43] aude: any idea what is wrong here? https://gerrit.wikimedia.org/r/#/c/168579/ [14:25:48] can't reproduice the issue locally [14:27:07] (03CR) 10jenkins-bot: [V: 04-1] Inject ReferencedPageFinder into ChangeHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162837 (owner: 10Daniel Kinzler) [14:38:14] hoo: https://gerrit.wikimedia.org/r/#/c/168583/ [14:39:07] ah, nice :) [14:39:18] DanielK_WMDE_: https://gist.githubusercontent.com/filbertkm/0ddfa37fb8295611b35b/raw/0b802615c8520d21957675b3b09cc53a0d3900d2/gistfile1.xml [14:39:26] and he runs away..... [14:39:47] i don' tknow if xml is helpful for anyone and cna be imported [14:39:50] aude: Pursuit! [14:40:14] full of property ids, so nope :( [14:41:02] on mw1.24-wmf19, it goes up to 77594624 in memory usage (at least) [14:41:42] that's ok-ish compared to what we saw in production [14:42:06] on master, it goes up to ~60000000 then is corrupt and get a fatal [14:42:38] ok... does it matter where the memory is being reserved? [14:42:56] idk [14:43:05] how do i find out? [14:43:52] goes up to 62390272 and dies [14:44:32] dies as in corrupts memory? [14:45:01] fatal error [14:45:19] ah, I see [14:45:26] value of snaks is not of expected type [14:45:29] if it hits the memory limit, bump that maybe? [14:45:36] Prod. has 256MiB now AFAIR [14:45:41] no it doesn't [14:45:41] or even 300 something? [14:46:15] * aude has 1gb [14:48:03] 'wmgMemoryLimit' => array( [14:48:03] 'default' => 300 * 1024 * 1024, // 300MB [14:48:43] aude: So... how does it die? Can't be out of memory then... time out? [14:48:53] value of snaks is not of expected type [14:50:42] does that happen if you disable gc? [14:50:49] let's seee [14:53:40] it loads with gc off [14:53:46] hah! [14:54:08] {{php rant}} [14:55:33] Can we temporarily disable gc for such actions? [14:55:50] Hi [14:56:58] why are we triggering gc? [14:57:08] and not in mw1.24-wmf19 [14:57:09] Widar isn't working :/ [14:57:35] aude: Not that is probably more or less random [14:57:38] 3MediaWiki extensions / 3WikidataRepo: wbgetentities needs more parameter validation - 10https://bugzilla.wikimedia.org/53038#c3 (10Marius Hoch) 5ASSI>3RESO/FIX All of these are checked now (language, props and sites). Closing. [14:57:52] Any suggestions? [14:57:53] not sure how php decides when to invoke it... might be after n cycles or whatever [14:57:59] or x mallocs [14:58:00] or something [14:58:05] doesn't seem random at all [14:58:18] ok [14:58:32] always happens on my item with master [14:58:37] can you (as a test) wrap the undo code in disable/enable qc calls? [14:58:40] never with old wikibase [14:58:48] ok, mh [14:58:50] sure [14:59:17] Yep, it's definately not working :/ [14:59:40] George_Edward_C: Sorry :( But widar is not maintained by us... you might have luck dropping Magnus an email or so [14:59:48] K [14:59:54] he's no on IRC often (at all?) [14:59:57] Wait [15:00:11] It's working now :D [15:00:13] Strange [15:00:24] or twitter [15:01:20] why does no one close bugs after merging stuff? :P [15:01:23] 3MediaWiki extensions / 3WikidataRepo: Label/Description uniqueness constraint is not enforced by Special:NewItem, leading to duplicates. - 10https://bugzilla.wikimedia.org/72085 (10Marius Hoch) 5PATC>3RESO/FIX [15:01:27] Ok, I forgot that often as well... [15:04:25] 3MediaWiki extensions / 3WikidataRepo: Special:NewProperty gives wrong error message when trying to add property with a label that is already associated with another property - 10https://bugzilla.wikimedia.org/71915#c3 (10Marius Hoch) 5PATC>3RESO/FIX I guess Daniel's patch fixed this entirely? If not, pl... [15:12:38] aude: FYI: "Therefore, it is probably wise to call gc_collect_cycles() just before you call gc_disable() to free up the memory that could be lost through possible roots that are already recorded in the root buffer. This then leaves an empty buffer so that there is more space for storing possible roots while the cycle collecting mechanism is turned off." [15:13:39] * aude nods [15:14:02] if i disable gc in Statement::getHash() then things work [15:14:19] awesome... well more or less [15:14:25] no need to collect cycles, although i am aware of that [15:14:36] i'm seeing if i can narrow it further [15:15:04] would be awesome if we could come up with something that can actually be applied to the branch at least [15:15:28] yes [15:18:38] 3MediaWiki extensions / 3WikidataRepo: Implement terms-lookup based on terms-table - 10https://bugzilla.wikimedia.org/71169#c2 (10Marius Hoch) The requirements over here IMO aren't clear enough... but I'm fairly sure that TermSqlIndex wont fit (also it's uncached). [15:19:21] hoo: we'll have to batch the term lookup [15:20:04] aude: Do we want to get a Fingerprint object? [15:20:10] nooooooooooooo [15:20:17] just labels for now, imho [15:20:27] the bug totally isn't clear enough [15:20:30] yeah [15:20:39] it says term lookup... [15:20:45] i want ot solve the immediate problem that entityidlabelformatter needs labels [15:21:26] that class is horrible [15:21:27] not sure yet how/if/what caching we want but it would be fetched during parse [15:21:32] +9000 [15:21:56] I had massive problems making use of it AFAIR as it requires an entity lookup [15:22:03] and that's just not present in some code paths [15:22:10] so tehre's still more hacks at some places [15:22:18] ugh [15:23:02] might be that we fixed that since, but property id formatting in some places is very bad [15:23:35] alright, if i put gc_disable around $entityDiff = $fromEntity->getDiff( $toEntity ); in EntityContent::getDiff(), that works [15:23:41] i'm not totally sure about getHash yet [15:24:56] yep, ClaimsView still manually makes entity links [15:25:06] but at least its not doing entity lookups [15:25:12] $propertyLabel = $entityInfoLabel['value']; [15:25:24] when finding referenced snaks, we loop through them at that point [15:25:33] then we have a list of all "used" entityids [15:25:43] that's the time to get the labels from term lookup [15:25:53] then make an in-memory lable lookup [15:26:00] and somehow has to be injected into the formatters [15:26:08] last part is the tricky part [15:26:25] and then see how it is performance-wise adn think what/if caching we should ahve [15:26:47] also would be good to have in the client [15:28:54] Yeah, probably [15:29:33] I guess the termlookup (well, label lookup) should just cache itemid -> json (languages -> labels) [15:30:42] perhaps [15:34:26] 3Wikimedia / 3Wikidata: WikimediaBadges and Wikidata.org extension description messages missing on [[d:Special:Version]] - 10https://bugzilla.wikimedia.org/70804#c5 (10Marius Hoch) 5REOP>3RESO/FIX Looks fixed to me... translating is a whole other issue (especially on github :S) [15:41:25] 3MediaWiki extensions / 3WikidataClient: pencil icon for "Edit links" should use wikifont - 10https://bugzilla.wikimedia.org/65527#c7 (10Marius Hoch) (In reply to Jared Zimmerman (WMF) from comment #6) > Just looked at the icon in that context at 10px and 12px, both seem fine. > > your screenshot shows the... [16:06:28] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/pT-Xog [16:06:28] 13WikibaseDataModel/06master 1426f7af5 15Jeroen De Dauw: Merge pull request #259 from wmde/siteLinkDeprecations... [16:07:44] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/PQgr9g [16:07:44] 13WikibaseDataModel/06master 1428c4eab 15Jeroen De Dauw: Merge pull request #258 from wmde/int32loss... [16:10:13] [13Geo] 15JeroenDeDauw comment on pull request #28 148b341e3: > The {0} syntax is deprecated in PHP 6.... 02http://git.io/Zr1eiQ [16:27:55] aude: just making sure you saw my email re the change in deploy train time on Tuesdays (and the move of the THur deploy to WEd) [16:28:04] hoo: ^ [16:28:26] yep [16:28:57] Sure :) [16:29:14] having more time to fix test.wikidata is good, in event it has a bug (hopefully never!) [16:30:17] [13WikibaseDatabase] 15JeroenDeDauw 04deleted 06rmescp at 149c9fdf4: 02http://git.io/gprXag [16:31:30] yikes [16:31:51] changing stuff in client is a pain with code spread over so many places :S [16:32:04] shock! [16:32:24] Trying to reduce the amount of JS rendering in client [16:32:31] :) [16:38:45] doh [16:38:46] :P [16:38:58] text attribute on :D [16:43:20] I am #1 in a game! :D http://tools.wmflabs.org/wikidata-game/#mode=stats [16:45:18] (03PS1) 10Thiemo Mättig (WMDE): Upper case SiteLink in UsageAccumulators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168612 [16:45:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Collect usage tracking info in ParserOutput. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [16:47:06] (03PS6) 10Thiemo Mättig (WMDE): Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 [16:53:28] * hoo rages [16:53:47] just fallen over https://gerrit.wikimedia.org/r/167251 again [16:55:02] oh, actually not even, I think [16:55:12] stuff is broken in another way on master, probably [16:55:14] * hoo cries [16:56:17] (03CR) 10jenkins-bot: [V: 04-1] Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [16:56:19] (03Merged) 10jenkins-bot: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [18:15:23] 3MediaWiki extensions / 3WikidataClient: pencil icon for "Edit links" should use wikifont - 10https://bugzilla.wikimedia.org/65527#c8 (10Jared Zimmerman (WMF)) If you don't like the look of the icon at that size, I'd recommend we remove the icon and adjust the padding accordingly. [18:20:19] (03PS1) 10Hoo man: [WIP] Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) [18:25:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [18:30:12] (03PS1) 10Hoo man: Revert "Actually put wb.client.getMwApiForRepo in wb.client" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168634 [18:30:55] (03PS2) 10Hoo man: Revert "Actually put wb.client.getMwApiForRepo in wb.client" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168634 [18:31:26] (03PS1) 10Hoo man: Revert "Actually put wb.client.getMwApiForRepo in wb.client" [extensions/Wikibase] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168635 [18:31:55] aude: ^ :( [18:39:55] (03CR) 10Hoo man: [C: 032] Revert "Actually put wb.client.getMwApiForRepo in wb.client" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168634 (owner: 10Hoo man) [18:45:06] (03Merged) 10jenkins-bot: Revert "Actually put wb.client.getMwApiForRepo in wb.client" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168634 (owner: 10Hoo man) [18:46:52] (03PS2) 10Hoo man: [WIP] Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) [18:48:58] I thought we had selenium tests for that? [18:49:04] We used to, at lesat [18:50:17] * hoo leaves [18:52:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create add links link in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [22:22:49] [13WikidataBuildResources] 15addshore created 06mwGithubDownloadLoc from 06master (+0 new commits): 02http://git.io/KeCQkg [22:23:38] [13WikidataBuildResources] 15addshore pushed 1 new commit to 06mwGithubDownloadLoc: 02http://git.io/jh_sXw [22:23:38] 13WikidataBuildResources/06mwGithubDownloadLoc 147cc4fff 15addshore: Adopt to changes in github's codedownload zip [22:23:48] [13WikidataBuildResources] 15addshore opened pull request #10: Adopt to changes in github's codedownload zip (06master...06mwGithubDownloadLoc) 02http://git.io/dCnt0A [22:24:43] [13WikidataBuilder] 15addshore created 06mwGithubDownloadLoc from 06master (+0 new commits): 02http://git.io/q7HThw [22:24:56] [13WikidataBuilder] 15addshore pushed 1 new commit to 06mwGithubDownloadLoc: 02http://git.io/WVJSJA [22:24:56] 13WikidataBuilder/06mwGithubDownloadLoc 14593541f 15addshore: Adopt to changes in github's codedownload zip [22:25:08] [13WikidataBuilder] 15addshore opened pull request #31: Adopt to changes in github's codedownload zip (06master...06mwGithubDownloadLoc) 02http://git.io/R4CSWg [22:28:30] wmde/WikidataBuilder/mwGithubDownloadLoc/593541f : addshore The build passed. http://travis-ci.org/wmde/WikidataBuilder/builds/38975720 [22:28:54] wmde/WikidataBuilder/mwGithubDownloadLoc/859632b : Marius Hoch The build passed. http://travis-ci.org/wmde/WikidataBuilder/builds/38975718 [23:07:21] [13WikidataBuilder] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/4Sn_3Q [23:07:22] 13WikidataBuilder/06master 14816d299 15Jeroen De Dauw: Merge pull request #31 from wmde/mwGithubDownloadLoc... [23:08:17] [13WikidataBuilder] 15JeroenDeDauw 04deleted 06mwGithubDownloadLoc at 14593541f: 02http://git.io/hgKb3A