[00:16:32] (03PS3) 10Hoo man: Make getLocationAgnosticMwApi work if both APIs are on the same domain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 [00:17:17] (03CR) 10Hoo man: "Addressed my own comment from PS2" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [00:20:07] (03PS4) 10Hoo man: Make getLocationAgnosticMwApi work if both APIs are on the same domain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 [00:20:29] (03CR) 10Hoo man: Make getLocationAgnosticMwApi work if both APIs are on the same domain (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [00:21:17] (03CR) 10Hoo man: "Also addressed Krinkle's comment from PS2 (sorry, forgot about that)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [07:18:22] [13WikibaseDataModel] 15thiemowmde comment on pull request #251 14b619f5d: `$iterator` is not an iterator. 02http://git.io/JtY_jQ [07:31:22] (03CR) 10Adrian Lang: "Why is this not used to replace getLanguageNameByCode usages in fingerpintview, fingerprintlistview, entityview?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [07:32:43] (03CR) 10Adrian Lang: "Also, how does this work for anon users?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [07:38:20] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I checked and yes, Adrian is right. Almost all usages of getLanguageNameByCode in the views should be replaced with this new method. Pleas" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [07:45:19] (03CR) 10Adrian Lang: [C: 032] Fixed wrong checks for undefined in QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167570 (owner: 10Henning Snater) [07:47:56] (03PS2) 10Adrian Lang: Introduce basic test for entityview, fix wrong template usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167204 [07:48:40] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove no longer needed wikibase.getSite*/hasSite wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166448 (owner: 10Hoo man) [07:53:33] (03CR) 10Henning Snater: [C: 032] Introduce basic test for entityview, fix wrong template usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167204 (owner: 10Adrian Lang) [07:53:45] (03PS2) 10Henning Snater: Fixed wrong checks for undefined in QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167570 [07:58:39] [13Diff] 15thiemowmde comment on commit 1452f8eed: +4!... 02http://git.io/LnwYVA [07:59:59] (03PS3) 10Henning Snater: Improve claimgrouplabelscroll code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [08:00:18] (03Merged) 10jenkins-bot: Remove no longer needed wikibase.getSite*/hasSite wrapper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166448 (owner: 10Hoo man) [08:00:22] (03CR) 10Henning Snater: "Patch set 3: Rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [08:00:33] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/ZkyQbw [08:00:33] 13ValueView/06master 14c477cb4 15thiemowmde: Merge pull request #116 from wmde/exttype... [08:02:12] (03CR) 10Henning Snater: [C: 032] Improve claimgrouplabelscroll code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [08:06:02] (03Merged) 10jenkins-bot: Introduce basic test for entityview, fix wrong template usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167204 (owner: 10Adrian Lang) [08:07:06] wikimedia/mediawiki-extensions-Wikibase/master/eec40ea : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38578699 [08:12:16] (03Merged) 10jenkins-bot: Improve claimgrouplabelscroll code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [08:12:33] wikimedia/mediawiki-extensions-Wikibase/master/42aaccc : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38579203 [08:13:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Jeroen, I think your +2 was an accident. I removed it. You are right, this code does have so many problems." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [08:52:04] (03Draft1) 10Aude: Initial implementation TermLookup [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167755 [09:06:37] State of Wikibase: http://xkcd.com/1428/ [09:18:05] museum curator, lol. [09:23:23] (03CR) 10Aude: [C: 04-2] Initial implementation TermLookup [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167755 (owner: 10Aude) [09:35:52] [13Geo] 15thiemowmde pushed 1 new commit to 06release: 02http://git.io/oG_t-A [09:35:52] 13Geo/06release 14e9310a0 15thiemowmde: Update README.md [09:36:02] [13Geo] 15thiemowmde closed pull request #27: Release 1.1.1 (06master...06release) 02http://git.io/GAH-xg [09:36:47] [13Geo] 15JanZerebecki tagged 061.1.1 at 06master: 02http://git.io/Zr48GQ [09:43:09] [13WikibaseDataModel] 15thiemowmde 04deleted 06hhvm-workarounds at 14b619f5d: 02http://git.io/XwdWsQ [09:58:11] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: What does "simple" mean in this context? can you come up with a more descriptive name? 02http://git.io/2fbjyw [10:01:42] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: Don't you think it may be worth keeping this to be able to implement a more efficient update strategy some day (instead of the current simple delete & insert one)? 02http://git.io/teR08A [10:03:47] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #128 143aa331d: This is not needed. 02http://git.io/Dm1leg [10:15:55] 3MediaWiki extensions / 3WikidataRepo: Maintain order: Have API return and accept lists instead of maps - 10https://bugzilla.wikimedia.org/72297 (10Henning) 3NEW p:3Unprio s:3major a:3Wikidata bugs The structures returned by the API are optimized for "raw" API usage (e.g. via Bots). Statements groupe... [10:18:08] 3MediaWiki extensions / 3WikidataRepo: Maintain order: Have API return and accept lists instead of maps - 10https://bugzilla.wikimedia.org/72297 (10Henning) [10:18:23] 3MediaWiki extensions / 3WikidataRepo: changes to ordering don't persist under certain condition - 10https://bugzilla.wikimedia.org/58180 (10Henning) [10:18:23] 3MediaWiki extensions / 3WikidataRepo: Ensure normalized ordering of claims and snaks in the API - 10https://bugzilla.wikimedia.org/57666 (10Henning) [10:19:54] 3MediaWiki extensions / 3WikidataRepo: Get rid of class aliases usage in data-values/geo - 10https://bugzilla.wikimedia.org/72035#c1 (10tobias.gritschacher) 5ASSI>3RESO/FIX https://github.com/DataValues/Geo/commit/48b046410c43f1eb62eefa7b44e428201a908f9b [10:20:38] 3MediaWiki extensions / 3WikidataRepo: Make EntitySuggester compatible with DataModel 2.0 - 10https://bugzilla.wikimedia.org/72139#c1 (10tobias.gritschacher) 5NEW>3RESO/FIX https://github.com/Wikidata-lib/PropertySuggester/releases/tag/1.1.3 [10:21:30] aude: can this be closed? https://bugzilla.wikimedia.org/show_bug.cgi?id=71508 [10:22:03] yes! [10:26:17] :) [10:26:21] [13WikibaseDataModel] 15thiemowmde created 06dontCount (+1 new commit): 02http://git.io/Zh9tvw [10:26:21] 13WikibaseDataModel/06dontCount 14727a392 15Thiemo Mättig: Don't expect count() to work on objects [10:26:54] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to LegacyClaimDeserializer::setRank() must be an instance of Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Statement\Statement - 10https://bugzilla.wikimedia.org/71508 (10tobias.gritschacher) 5PATC>3RESO/FIX [10:27:06] [13WikibaseDataModel] 15thiemowmde opened pull request #253: Don't expect count() to work on objects (06master...06dontCount) 02http://git.io/PVfmXQ [10:29:05] wmde/WikibaseDataModel/dontCount/727a392 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38589680 [10:29:44] aude: and these two? https://bugzilla.wikimedia.org/show_bug.cgi?id=71509 and https://bugzilla.wikimedia.org/show_bug.cgi?id=71510 [10:39:08] Tobi_WMDE_SW: probably [10:45:31] aude: ok. :) then let's keep them open until we know for sure the errors are not happening anymorwe [10:45:48] with the class aliases gone, i think we can close them [10:46:53] 3MediaWiki extensions / 3WikidataRepo: link to item in error message when item with same label and description already exists - 10https://bugzilla.wikimedia.org/46073 (10Lucie Kaffee) [10:47:23] 3MediaWiki extensions / 3WikidataRepo: link to item in error message when item with same label and description already exists - 10https://bugzilla.wikimedia.org/46073#c3 (10Lucie Kaffee) Still open. [10:51:43] aude: that's true [10:53:39] 3MediaWiki extensions / 3WikidataRepo: Argument 1 passed to Wikibase\TermSqlIndex::getTermsOfEntity() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given - 10https://bugzilla.wikimedia.org/71509#c1 (10tobias.gritschacher) 5NEW>3RESO/FIX Should not happen anymore since https:/... [10:53:55] 3MediaWiki extensions / 3WikidataRepo: Argument 3 passed to Wikibase\LabelDescriptionDuplicateDetector::detectTermConflicts() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given - 10https://bugzilla.wikimedia.org/71510#c1 (10tobias.gritschacher) 5NEW>3RESO/FIX Should not happ... [10:56:37] 3MediaWiki extensions / 3WikidataRepo: Special:ItemDisambiguation should include aliases in search, not just labels. - 10https://bugzilla.wikimedia.org/43962 (10Lucie Kaffee) [11:01:32] [13WikibaseDataModel] 15JanZerebecki created 06nitpick (+1 new commit): 02http://git.io/NA2ITA [11:01:32] 13WikibaseDataModel/06nitpick 1412d298c 15Jan Zerebecki: Use better variable names in test. [11:01:52] [13WikibaseDataModel] 15JanZerebecki opened pull request #254: Use better variable names in test. (06master...06nitpick) 02http://git.io/3A3nBg [11:06:06] wmde/WikibaseDataModel/nitpick/12d298c : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38592217 [11:14:33] (03CR) 10Daniel Kinzler: [C: 04-1] Initial implementation TermLookup [WIP] (0321 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167755 (owner: 10Aude) [11:19:00] tao10topitw [11:27:39] 3MediaWiki extensions / 3WikidataRepo: Floating toolbar for edit-sections - 10https://bugzilla.wikimedia.org/72022#c2 (10tobias.gritschacher) 5ASSI>3PATC https://gerrit.wikimedia.org/r/167193 [11:30:24] Tobi_WMDE_SW: any chance https://bugzilla.wikimedia.org/show_bug.cgi?id=71536 is also fixed? [11:30:33] aude: ^ [11:34:55] Lydia_WMDE: probably not [11:35:02] k [11:35:29] it's germany [11:35:40] memory corruption [11:36:49] (03CR) 10Daniel Kinzler: [C: 032] "Having the change from setClaim to getStatements()->addStatement() mixed in with the namespace/use cleanup is really surprising and potent" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166966 (owner: 10Thiemo Mättig (WMDE)) [11:38:10] (03CR) 10Daniel Kinzler: [C: 032] Optimize/add missing use clauses in Client after DM 2.0 switch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166956 (owner: 10Thiemo Mättig (WMDE)) [11:46:55] (03CR) 10Daniel Kinzler: Check label/description constraint for new items. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) (owner: 10Daniel Kinzler) [11:47:00] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 143aa331d: BasicEntityRemover? Can't think of a much more descriptive name. 02http://git.io/SRb3XA [11:47:49] (03Merged) 10jenkins-bot: Optimize/add missing use clauses in Lib after DM 2.0 switch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166966 (owner: 10Thiemo Mättig (WMDE)) [11:47:58] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 143aa331d: I considered that and figured it makes more sense to introduce that when the situation warrants it more. 02http://git.io/0Ch-rA [11:48:01] (03Merged) 10jenkins-bot: Optimize/add missing use clauses in Client after DM 2.0 switch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166956 (owner: 10Thiemo Mättig (WMDE)) [11:48:33] [13WikibaseQueryEngine] 15JeroenDeDauw comment on pull request #128 143aa331d: Yes it is, it nulls the parent constructor. 02http://git.io/AXDC9w [11:50:24] 3MediaWiki extensions / 3WikidataClient: Wikidata's Watchlist in wikipedia are like read Watchlist - 10https://bugzilla.wikimedia.org/48684 (10Lucie Kaffee) [11:52:39] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06dontCount at 14727a392: 02http://git.io/zfNAHg [11:55:22] (03CR) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [11:56:07] (03PS1) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 [11:58:23] [13WikibaseDataModel] 15thiemowmde 04deleted 06nitpick at 1412d298c: 02http://git.io/0ofUdg [11:59:40] (03CR) 10Thiemo Mättig (WMDE): "All changes you describe as "unrelated" are strongly related to the DM 2.0 switch. Could have split, sure, but why?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166966 (owner: 10Thiemo Mättig (WMDE)) [12:00:12] (03PS11) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [12:00:20] (03CR) 10jenkins-bot: [V: 04-1] Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [12:40:23] 3MediaWiki extensions / 3WikidataRepo: [editedit] link - 10https://bugzilla.wikimedia.org/63565#c1 (10Lucie Kaffee) I couldn't reproduce this bug. Neither in firefox nor in chrome. Any chance this got accedently fixed? [12:46:47] (03Abandoned) 10Hoo man: Don't recurse indefinitely in WikibaseLuaBindings::renumber [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167454 (owner: 10Hoo man) [12:53:19] [13Serialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/eSSO3w [12:53:19] 13Serialization/06master 142539db0 15Jeroen De Dauw: Update Serializer.php [12:55:56] (03CR) 10Ebrahim: "> Why is this not used to replace getLanguageNameByCode usages in fingerpintview, fingerprintlistview, entityview?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [12:56:31] [13Serialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/yt6RLA [12:56:31] 13Serialization/06master 14de27c6c 15Jeroen De Dauw: Update Deserializer.php [12:56:39] 3MediaWiki extensions / 3WikidataRepo: Possibility to enter new sitelink instantly when editing sitelink-section - 10https://bugzilla.wikimedia.org/72023 (10Lydia Pintscher) [13:14:23] 3MediaWiki extensions / 3WikidataRepo: wbgetentities needs more parameter validation - 10https://bugzilla.wikimedia.org/53038#c1 (10Lucie Kaffee) Now the queries return a "Unrecognized value for parameter 'props': boohoo". Do you think the result should rather be an error? [13:18:52] 3MediaWiki extensions / 3WikidataRepo: wbgetentities needs more parameter validation - 10https://bugzilla.wikimedia.org/53038 (10Lucie Kaffee) [13:20:47] (03PS1) 10Ladsgroup: [WIP] Rewrite SpecialUnconnectedPages to use QueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 [13:26:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Rewrite SpecialUnconnectedPages to use QueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167795 (owner: 10Ladsgroup) [13:27:05] (03PS19) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityTermLookup to be used in Entity formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/117424 (https://bugzilla.wikimedia.org/62724) [13:39:55] (03CR) 10Adrian Lang: Introduce entityChangers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [13:43:58] (03Draft2) 10Aude: Rewrite NamespaceUtils to be non-static and use one instance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167781 [13:44:41] (03PS1) 10Thiemo Mättig (WMDE): Always use native language name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 [13:45:37] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "For some strange reason I can not reproduce the correct ULS behavior in my local setup. But it works on wikidata.org. Please review my fol" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [13:45:43] (03CR) 10jenkins-bot: [V: 04-1] Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [13:52:54] (03PS12) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [13:56:35] (03PS18) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) [13:56:42] (03CR) 10jenkins-bot: [V: 04-1] Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [13:56:51] (03PS15) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [13:56:57] (03CR) 10jenkins-bot: [V: 04-1] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [13:57:23] 3MediaWiki extensions / 3WikidataRepo: Maintain order: Have API return and accept lists instead of maps - 10https://bugzilla.wikimedia.org/72297#c1 (10Adrian Lang) Currently we get our data from wbEntity, too, so that would have to have this grouping, too. [13:58:50] (03PS21) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) [13:59:05] (03CR) 10Daniel Kinzler: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [13:59:24] (03PS7) 10Daniel Kinzler: Factor connection management into separate class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 [14:02:15] (03PS6) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) [14:02:17] (03PS4) 10Adrian Lang: Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 [14:02:19] (03PS4) 10Adrian Lang: Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 [14:02:21] (03PS3) 10Adrian Lang: Remove wikibase.getRevisionStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 [14:03:38] 3MediaWiki extensions / 3WikidataRepo: wbgetentities needs more parameter validation - 10https://bugzilla.wikimedia.org/53038 (10Lucie Kaffee) 5NEW>3ASSI [14:04:23] 3MediaWiki extensions / 3WikidataRepo: Implement a label lookup based on entity info - 10https://bugzilla.wikimedia.org/72307 (10tobias.gritschacher) p:5Unprio>3Normal [14:04:30] (03PS6) 10Ebrahim: Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 [14:04:55] 3MediaWiki extensions / 3WikidataRepo: Inject term lookup into formatters - 10https://bugzilla.wikimedia.org/72308 (10tobias.gritschacher) p:5Unprio>3Normal [14:05:08] 3MediaWiki extensions / 3WikidataRepo: Inject term lookup into formatters - 10https://bugzilla.wikimedia.org/72308 (10tobias.gritschacher) [14:05:35] (03PS7) 10Ebrahim: Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 [14:06:54] (03CR) 10Ebrahim: "Merge issue resolved" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [14:06:55] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [14:08:19] (03PS19) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) [14:11:56] (03PS5) 10Adrian Lang: Simplify and generalize array handling in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 [14:15:03] (03PS16) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [14:16:38] 3MediaWiki extensions / 3WikidataRepo: Investigate how prefetching labels would work for watchlist and recent changes - 10https://bugzilla.wikimedia.org/72309 (10tobias.gritschacher) p:5Unprio>3Normal [14:17:23] (03PS1) 10Thiemo Mättig (WMDE): Don't use full qualified class names if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167808 [14:19:09] 3MediaWiki extensions / 3WikidataRepo: Batched label query for watchlists and recent changes - 10https://bugzilla.wikimedia.org/72310 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Split this up if it turns out that the implementation for watchlist and recent changes differs a lot. [14:19:38] 3MediaWiki extensions / 3WikidataRepo: Investigate how prefetching labels would work for watchlist and recent changes - 10https://bugzilla.wikimedia.org/72309 (10tobias.gritschacher) [14:19:39] 3MediaWiki extensions / 3WikidataRepo: Investigate how prefetching labels would work for watchlist and recent changes - 10https://bugzilla.wikimedia.org/72309 (10tobias.gritschacher) [14:19:40] 3MediaWiki extensions / 3WikidataRepo: Batched label query for watchlists and recent changes - 10https://bugzilla.wikimedia.org/72310 (10tobias.gritschacher) p:5Unprio>3Normal [14:19:40] 3MediaWiki extensions / 3WikidataRepo: Batched label query for watchlists and recent changes - 10https://bugzilla.wikimedia.org/72310 (10tobias.gritschacher) [14:22:01] (03Merged) 10jenkins-bot: Use wgULSLanguages for retrieving language names on users' UI language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166209 (owner: 10Ebrahim) [14:22:22] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c4 (10JulesWinnfield-hu) 5RESO/WOR>3REOP New pages in https://hu.wikipedia.org/wiki/Kateg%C3%B3ria:Parancsf%C3%A1jlhib%C3%A1t_okoz%C3%B3_lapok [14:24:27] [13WikidataBrowserTests] 15zeljkofilipin created 0669245 (+1 new commit): 02http://git.io/tC3l9Q [14:24:27] 13WikidataBrowserTests/0669245 14494ff7a 15Željko Filipin: Prepare repository for running RuboCop after every push to Gerrit... [14:26:36] [13WikidataBrowserTests] 15zeljkofilipin opened pull request #16: Prepare repository for running RuboCop after every push to Gerrit (06master...0669245) 02http://git.io/srr-wg [14:34:10] 3MediaWiki extensions / 3WikidataRepo: Reset edit-mode when error occurs during a request-queue - 10https://bugzilla.wikimedia.org/72311 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs At the moment whenever an error occurs during a request-queue, the UI turns into an undefined stat... [14:34:23] 3MediaWiki extensions / 3WikidataRepo: Reset edit-mode when error occurs during a request-queue - 10https://bugzilla.wikimedia.org/72311 (10tobias.gritschacher) p:5Unprio>3Normal [14:36:23] 3MediaWiki extensions / 3WikidataRepo: Make statement view inherit from claimview - 10https://bugzilla.wikimedia.org/72312 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3High [14:36:52] 3MediaWiki extensions / 3WikidataRepo: wbgetentities needs more parameter validation - 10https://bugzilla.wikimedia.org/53038 (10Lucie Kaffee) [14:37:52] [13Diff] 15thiemowmde created 06betterCode (+1 new commit): 02http://git.io/g1OA7A [14:37:52] 13Diff/06betterCode 1456eba84 15Thiemo Mättig: Fix multiple code style warnings [14:40:02] [13Diff] 15thiemowmde opened pull request #16: Fix multiple code style warnings (06master...06betterCode) 02http://git.io/AoFE5Q [14:46:59] wmde/Diff#71 (betterCode - 56eba84 : Thiemo Mättig): The build passed. [14:46:59] Change view : https://github.com/wmde/Diff/commit/56eba8452c17 [14:46:59] Build details : http://travis-ci.org/wmde/Diff/builds/38612038 [14:50:55] (03PS1) 10Thiemo Mättig (WMDE): Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 [14:51:38] (03PS1) 10Thiemo Mättig (WMDE): Fix code smell issues in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167815 [14:54:05] (03CR) 10Jeroen De Dauw: [C: 032] Fix code smell issues in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167815 (owner: 10Thiemo Mättig (WMDE)) [14:55:55] 3MediaWiki extensions / 3WikidataRepo: Rollout of statements on properties with old serialization code - 10https://bugzilla.wikimedia.org/72314 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Check if we could roll out statements on properties with the old serialization code in lib.... [14:56:09] 3MediaWiki extensions / 3WikidataRepo: Rollout of statements on properties with old serialization code - 10https://bugzilla.wikimedia.org/72314 (10tobias.gritschacher) p:5Unprio>3Normal [14:57:24] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10tobias.gritschacher) [14:57:38] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10tobias.gritschacher) [14:57:38] 3MediaWiki extensions / 3WikidataRepo: Allow adding references for statements on properties in the UI - 10https://bugzilla.wikimedia.org/68379 (10tobias.gritschacher) [14:58:08] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10tobias.gritschacher) [14:58:23] 3MediaWiki extensions / 3WikidataRepo: Rollout of statements on properties with old serialization code - 10https://bugzilla.wikimedia.org/72314 (10tobias.gritschacher) [14:59:41] (03CR) 10jenkins-bot: [V: 04-1] Fix code smell in JS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 (owner: 10Thiemo Mättig (WMDE)) [15:00:49] (03PS1) 10Thiemo Mättig (WMDE): Fix code smell issues/drop unused PHP code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 [15:04:02] (03CR) 10Jeroen De Dauw: [C: 032] Don't use full qualified class names if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167808 (owner: 10Thiemo Mättig (WMDE)) [15:04:08] (03Merged) 10jenkins-bot: Fix code smell issues in PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167815 (owner: 10Thiemo Mättig (WMDE)) [15:05:43] (03CR) 10Henning Snater: [C: 04-1] Fix code smell in JS (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167814 (owner: 10Thiemo Mättig (WMDE)) [15:06:40] 3MediaWiki extensions / 3WikidataRepo: Add Aliases Field to Special:NewItem - 10https://bugzilla.wikimedia.org/72316 (10merl) 3NEW p:3Unprio s:3enhanc a:3Wikidata bugs On dewiki my bot creates links to prepopulated forms, so that making wikidata changes is much easier. http://de.wikipedia.org/wiki/W... [15:07:36] (03CR) 10Jeroen De Dauw: Simplify and generalize array handling in SqlUsageTracker (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [15:13:32] (03CR) 10Jeroen De Dauw: Fix code smell issues/drop unused PHP code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167816 (owner: 10Thiemo Mättig (WMDE)) [15:31:42] (03CR) 10Jeroen De Dauw: Rewrite NamespaceUtils to be non-static and use one instance (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167781 (owner: 10Aude) [15:32:10] (03CR) 10Jeroen De Dauw: [C: 032] Rewrite NamespaceUtils to be non-static and use one instance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167781 (owner: 10Aude) [15:32:14] aude: indent fail at https://gerrit.wikimedia.org/r/#/c/167781/ [15:32:32] (03PS2) 10Jeroen De Dauw: Always use native language name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [15:32:41] 3MediaWiki extensions / 3WikidataClient: add possibility to generate proper phpunit coverage reports of Wikibase.git - 10https://bugzilla.wikimedia.org/72318 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Add possibility to generate proper (whitelisting files, strict) phpunit coverage re... [15:32:47] oh noes [15:33:08] 3MediaWiki extensions / 3WikidataClient: Code coverage extremely low - technical debt - 10https://bugzilla.wikimedia.org/42510 (10Jan Zerebecki) [15:33:08] 3MediaWiki extensions / 3WikidataClient: add possibility to generate proper phpunit coverage reports of Wikibase.git - 10https://bugzilla.wikimedia.org/72318 (10Jan Zerebecki) [15:40:21] (03PS2) 10Adrian Lang: Make statementview have a claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167782 (https://bugzilla.wikimedia.org/72312) [15:40:23] 3MediaWiki extensions / 3WikidataRepo: Make statement view use claimview instead of inherit - 10https://bugzilla.wikimedia.org/72312 (10Adrian Lang) [15:40:57] [13Diff] 15JeroenDeDauw comment on pull request #16 1456eba84: Huh? Why? 02http://git.io/5dUetQ [15:44:30] [13Diff] 15JeroenDeDauw 04deleted 06betterCode at 1456eba84: 02http://git.io/MqOqDw [15:45:00] [13WikidataBrowserTests] 15JeroenDeDauw 04deleted 0669245 at 14494ff7a: 02http://git.io/YM3kKA [15:58:11] (03CR) 10Adrian Lang: [C: 031] "Seems legit." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167251 (owner: 10Hoo man) [16:03:05] (03CR) 10Adrian Lang: "Just because of alphabet." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130335 (owner: 10Adrian Lang) [16:20:31] [13Wikidata.org] 15filbertkm created 06namespaceutils (+1 new commit): 02http://git.io/oc8z2w [16:20:31] 13Wikidata.org/06namespaceutils 14e001c5a 15aude: Replace use of NamespaceUtils... [16:21:08] [13Wikidata.org] 15filbertkm opened pull request #16: Replace use of NamespaceUtils (06master...06namespaceutils) 02http://git.io/I8OkrA [16:37:30] (03PS3) 10Daniel Kinzler: Inject ReferencedPageFinder into ChangeHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162837 [17:28:38] 3MediaWiki extensions / 3WikidataRepo: [editedit] link - 10https://bugzilla.wikimedia.org/63565 (10Lydia Pintscher) 5NEW>3RESO/WOR [17:32:13] "Lua error a(z) Modul:Pozíciós_térkép modulban a(z) 283. sorban: The second value "- 20" provided for latitude is not valid." [17:32:15] * hoo wtfs [17:37:40] oh, that is some other module [17:45:38] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c5 (10Marius Hoch) I can't see anything like that on any of the pages linked there, also nothing obvious in the error logs. Could you maybe provide a screenshot of said error message (includi... [17:45:42] hi Lydia_WMDE. I self-invited myself to this channel. I think I should live here for some time. :-) [17:46:30] leila: hehe that's cool. it's an open channel [17:46:37] welcome [17:52:55] thanks, Lydia_WMDE! :-) [18:30:47] (03CR) 10JanZerebecki: [C: 04-1] "Didn't yet finish my review, but wanted to sent first comment. See inline." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [18:37:59] (03CR) 10Daniel Kinzler: Rewrite label/description conflict detection. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [18:38:20] jzerebecki: oops :) [18:39:21] (03PS7) 10Daniel Kinzler: Rewrite label/description conflict detection. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) [18:39:24] fixed! [19:25:36] I've never experienced this before, but the edit links on this page are off by one: https://www.wikidata.org/wiki/Help:Statements [19:28:35] BTW, is there a policy on making statements that are subsets/supersets of other statements? [19:28:45] Thiemo_WMDE: Around? [19:29:04] (i.e. implications or transitive statements) [19:30:06] (e.g. "foo is an instance of baz bar", "baz bar is an instance of bar", "foo is an instance of bar") [21:28:55] 3MediaWiki extensions / 3WikidataClient: Number of changes loaded mismatches the number of change IDs provided - 10https://bugzilla.wikimedia.org/72333 (10Aaron Schulz) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Seeing lots of these kind of exceptions from job runners: Warning: Number of changes load... [21:46:25] 3MediaWiki extensions / 3WikidataClient: Catchable fatal error: Argument 1 passed to Wikibase\EntityChange::setMetadata() must be an array, null given - 10https://bugzilla.wikimedia.org/72335 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs on master, when trying to run jobs on my client wiki: War... [22:13:37] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c6 (10JulesWinnfield-hu) https://hu.wikipedia.org/wiki/Als%C3%B3mocsol%C3%A1d https://hu.wikipedia.org/wiki/K%C3%A9ked Search for "Failed". [22:16:22] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c7 (10JulesWinnfield-hu) Created attachment 16834 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16834&action=edit screenshot [22:18:37] 3MediaWiki extensions / 3WikidataRepo: Lua error: Failed to serialize data. - 10https://bugzilla.wikimedia.org/71918#c8 (10Marius Hoch) The links look fine to me (both logged in and out) :/ Thanks for the screenshot, that gives me more of an idea of what is going on here. I'll investigate more in the next c...