[00:06:46] (03CR) 10Hoo man: "Ok, I poked some more... we also need: https://gerrit.wikimedia.org/r/167521" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167367 (https://bugzilla.wikimedia.org/72040) (owner: 10Hoo man) [00:29:29] mariushoch/mediawiki-extensions-Wikibase/hhvmWikibaseMaster/f352f1d : Translation updater bot The build passed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/38448943 [00:30:06] And they ran in 13m total... and not 35m+ :) [00:31:25] (03CR) 10Hoo man: [C: 031] "This was merged now, so we are good to go here." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167367 (https://bugzilla.wikimedia.org/72040) (owner: 10Hoo man) [00:33:08] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Travis is failing for Wikibase tests on HHVM - 10https://bugzilla.wikimedia.org/72040#c4 (10Marius Hoch) 5PATC>3RESO/FIX With https://gerrit.wikimedia.org/r/167521 merged those problems are gone, Wikibase test run much faster now (also with Zend) and hhvm pas... [00:44:26] wikidata [00:44:49] Yes! [01:32:08] (03PS2) 10Hoo man: No longer allow HHVM to fail on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167367 (https://bugzilla.wikimedia.org/72040) [07:33:52] 3MediaWiki extensions / 3WikidataClient: Other projects sidebar should show badges if applicable - 10https://bugzilla.wikimedia.org/71887#c1 (10Andyrom75) It should be enough to apply the same code that allow to do the same task for the interlingual link. For example, look at https://it.wikivoyage.org/wiki/S... [08:21:08] (03Draft2) 10Aude: Use same TestUser for all WikibaseApiTestCase tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167391 [08:29:37] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 20/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167538 [08:36:20] [13WikibaseQueryEngine] 15JeroenDeDauw created 06rd (+1 new commit): 02http://git.io/vdljkQ [08:36:20] 13WikibaseQueryEngine/06rd 148df1694 15jeroendedauw: Remove dead code [08:40:15] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 20/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167538 (owner: 10Tobias Gritschacher) [08:41:47] wmde/WikibaseQueryEngine/rd/8df1694 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/38473828 [08:42:17] (03Merged) 10jenkins-bot: New Wikidata Build - 20/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167538 (owner: 10Tobias Gritschacher) [08:43:37] (03CR) 10Tobias Gritschacher: [C: 032] No longer allow HHVM to fail on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167367 (https://bugzilla.wikimedia.org/72040) (owner: 10Hoo man) [08:44:56] DanielK_WMDE_: https://www.wikidata.org/wiki/User:GPHemsley/Wiktionary [08:46:23] 3MediaWiki extensions / 3WikidataRepo: Adjust Browsertests to toolbar refactoring - 10https://bugzilla.wikimedia.org/72029 (10tobias.gritschacher) 5ASSI>3RESO/FIX [08:49:42] (03Merged) 10jenkins-bot: No longer allow HHVM to fail on travis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167367 (https://bugzilla.wikimedia.org/72040) (owner: 10Hoo man) [09:03:07] yay! https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase [09:03:52] Tobi_WMDE_SW: https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-getentities-api-tests/1387/console [09:04:16] I think we should run the getentities tests with the other api ones now [09:04:35] it take several minutes to set stuff up (composer...), but the tests run in 11s now [09:04:44] (no longer in 2-3 minutes) [09:05:20] hoo: fully agree [09:05:31] should I make a chane? [09:05:35] *change? [09:05:38] Go ahead :) [09:06:05] hoo: really impressive what you did [09:06:22] not really what you did, but the effect of it. :D [09:06:55] I knew we waste quite a bit of time hashing and doing several thousand useless DB updtes... but I didn't know it was that much [09:08:12] [13WikibaseQueryEngine] 15mariushoch 04deleted 06rd at 148df1694: 02http://git.io/bXK6dw [09:11:15] (03PS3) 10Hoo man: Use same TestUser for all WikibaseApiTestCase tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167391 (owner: 10Aude) [09:12:06] hoo: https://gerrit.wikimedia.org/r/#/c/167540/ [09:12:06] (03CR) 10Hoo man: [C: 032] "As we don't mess with the test user, we can safely use just one instance :) Let's make our tests even faster!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167391 (owner: 10Aude) [09:12:34] Tobi_WMDE_SW: Awesome :) [09:12:45] hoo: you cannot +2, right? [09:12:54] will poke hashar later [09:13:17] No... I also don't know how to deploy this zuul stuffs [09:13:48] Maybe I could get +2, I wanted... but would have to learn that first [09:13:59] hoo: I think I can deploy it [09:16:29] I think you need production shell to do that [09:17:24] hoo: nope, it worked: https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-api-tests/jobConfigHistory/showDiffFiles?timestamp1=2014-08-28_10-05-44×tamp2=2014-10-20_09-17-01 [09:18:06] hoo: I think I need to remove the getentities job by hand. but I'll do that after the change got merged [09:19:07] Doing that beforehand might break stuff [09:19:13] hashar will know [09:20:46] Tobi_WMDE_SW: hoo good morning :] [09:21:08] (03Merged) 10jenkins-bot: Use same TestUser for all WikibaseApiTestCase tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167391 (owner: 10Aude) [09:24:05] breakfast! [09:24:21] yes removing it before zuul config got deployed and reloaded would break tests for gerrit [09:30:26] hashar: good morning [09:33:13] Tobi_WMDE_SW: the zuul part is missing in that patch [09:33:27] jzerebecki: thx! saw your comment [09:34:43] hashar: can you check https://gerrit.wikimedia.org/r/#/c/167540/? [09:53:46] Tobi_WMDE_SW: sure [09:54:04] Tobi_WMDE_SW: should I just deploy it so Zuul get updated so ? [09:54:32] hashar: yes, please [09:54:47] +2 ed :-) [10:02:48] jzerebecki: Tobi_WMDE_SW deployed :-] [10:06:14] thx [10:09:51] I am heading back home be back later [10:14:41] * hoo will also be back later [10:16:45] (03CR) 10Daniel Kinzler: [C: 031] "Code looks fine, but I haven't tested, and there is no unit test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167233 (https://bugzilla.wikimedia.org/61768) (owner: 10Hoo man) [10:19:07] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Tests for WikibaseDataModel on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69525#c2 (10Thiemo Mättig) I counted the dots in https://travis-ci.org/wmde/WikibaseDataModel/jobs/37964434 and compared to a local test run. There... [10:24:58] [13WikibaseDataModel] 15thiemowmde created 06killacat (+1 new commit): 02http://git.io/GpEquw [10:24:58] 13WikibaseDataModel/06killacat 144de9411 15Thiemo Mättig: Kill the cat [10:26:07] nooooooooooo [10:27:39] wmde/WikibaseDataModel/killacat/4de9411 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38482762 [10:28:26] [13WikibaseDataModel] 15thiemowmde opened pull request #249: Kill the cat (06master...06killacat) 02http://git.io/4WA-0g [10:39:31] anyone who can answer http://www.mediawiki.org/w/index.php?title=Extension_talk:Wikibase_Repository&offset=20141012223708&lqt_mustshow=49208#Wikibase_extension_error_-_failed_to_deserialize_on_EntityFactor.php_49208 ? [10:39:58] Lydia_WMDE, DanielK_WMDE: I'm here if you want to discuss things. [10:40:46] GPHemsley: hey :) thanks for the proposal! i have not had a chance to look into it in detail yet but getting positive comments from denny is good [10:41:08] Lydia_WMDE: :) I'm still working on it and actively considering feedback. [10:41:15] [13Geo] 15JanZerebecki created 06release (+1 new commit): 02http://git.io/dRV70g [10:41:15] 13Geo/06release 149482d20 15Jan Zerebecki: Release 1.1.1 [10:41:18] cool [10:41:27] [13Geo] 15JanZerebecki opened pull request #27: Release 1.1.1 (06master...06release) 02http://git.io/GAH-xg [10:41:36] Thiemo_WMDE: ^^ [11:08:18] (03PS1) 10Henning Snater: Added missing dependency to edittoolbar ResourceLoader module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167544 [11:18:09] (03CR) 10Tobias Gritschacher: [C: 032] Added missing dependency to edittoolbar ResourceLoader module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167544 (owner: 10Henning Snater) [11:21:46] [13Geo] 15JeroenDeDauw comment on pull request #27 149482d20: 1.1.1? 02http://git.io/g_bFcw [11:23:19] (03Merged) 10jenkins-bot: Added missing dependency to edittoolbar ResourceLoader module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167544 (owner: 10Henning Snater) [11:23:38] [13Geo] 15JeroenDeDauw comment on pull request #27 149482d20: Also need to update the branch aliases in `composer.json` 02http://git.io/6hwYbw [11:27:42] (03PS1) 10Tobias Gritschacher: New Wikidata Build 20/10/2014 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167547 [11:34:47] Tobi_WMDE_SW: too late for ordering onigiri? [11:35:15] DanielK_WMDE_: yeah, ordered already.. [11:36:11] damn [11:36:52] 3MediaWiki extensions / 3WikidataClient: Infinite recursion in WikibaseLuaBindings::renumber (leading to OOM) when trying to get Q30 - 10https://bugzilla.wikimedia.org/72242 (10Lydia Pintscher) p:5Unprio>3High [11:38:52] 3MediaWiki extensions / 3WikidataClient: Create widget to edit site links in the client - 10https://bugzilla.wikimedia.org/72178 (10Lydia Pintscher) p:5Low>3High [11:39:01] aude: can https://bugzilla.wikimedia.org/show_bug.cgi?id=72158 be closed? [11:39:17] probably not [11:39:27] no [11:39:53] did we fix echo yet? (for example) [11:40:38] Lydia_WMDE: can it be changed to assigned and given some points? [11:40:38] likely not. can you post in the bug what's missing still? [11:43:22] 3MediaWiki extensions / 3WikidataRepo: Special:ItemByTitle - add documentation - 10https://bugzilla.wikimedia.org/66745 (10Lydia Pintscher) 5UNCO>3NEW [11:44:53] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity is made when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158#c7 (10Aude) 5PATC>3ASSI what's still missing? "a deep copy "of Entity is made whenever calling Revision::getContent(). the deep copy is done with "unserialize(... [11:45:10] we could make subtasks if you want [11:45:38] for each of the 3 possible actions: https://bugzilla.wikimedia.org/show_bug.cgi?id=72158#c7 [11:46:07] hi all. Does anyone know if redirects are counted double in the http://dumps.wikimedia.org/other/pagecounts-ez/ data? E.g. "Moving_statue" redirects to "Moving_statues". Does both get a visit when someone visits "Moving_Statue" which redirects? [11:48:30] jonascj: http://www.opensym.org/os2014-files/proceedings/p604.pdf [11:48:53] it should be somewhere in there [11:49:26] [13Geo] 15JanZerebecki 04force-pushed 06release from 149482d20 to 1448b0464: 02http://git.io/BgFaqw [11:49:26] 13Geo/06release 1448b0464 15Jan Zerebecki: Release 1.1.1 [11:51:38] hmmm maybe mako didn't add it to the final paper? [11:51:45] i remember him talking about this in his talk [11:54:40] (03PS1) 10Aude: Add @group Database to AvailableBadgesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167554 [11:55:31] jonascj: i do not actually know, but as far as i understand, the coutns are based on http logs. that is, un the url visited. [11:55:43] so redirects would not be counted twice [11:56:30] could be wrong, though :) [11:58:25] DanielK_WMDE_: yeah, most http servers don't log redirects, so you are probably right [11:59:20] jonascj: wikipedia redirects are not implemented as http redirects. the server *cannot* log them. [11:59:33] they ouwld have to be resolved in post-processing [11:59:46] that's actually what is described in Table 2 in Mako's paper [12:00:17] DanielK_WMDE_: ah, yes, excelent point. [12:00:32] jonascj: if you want effectove page views for page X, you have to find and add all views counted for redirects to page X [12:01:40] (actually, the URL in the browser's address bar is now adjusted to match the redirect target's title. this is JS magic, not an http redirect. i just checked with wget) [12:02:00] DanielK_WMDE_: yeah, and that is a hard problem since it requires a list of redirects. That could be constructed by requesting all pages, but that is a bit elaborate [12:02:16] DanielK_WMDE_: I was just testing myself to see if a redirect http status was sent [12:03:48] jonascj: a list of redirects can easily be queried from the API. [12:04:20] DanielK_WMDE_: I'll have to look into the API (some wiki api that I do not know of) - thanks! [12:07:58] DanielK_WMDE_: like this you mean? http://en.wikipedia.org/w/api.php?action=query&titles=Moving_statue&redirects it seems to indicate that there is a single redirect for "Moving statue", namely to "Moving statues" [12:13:38] (03CR) 10Tobias Gritschacher: [C: 032] "@Thiemo: these tests are covered by browsertests. I've just verified that they are passing. So things are fine I guess." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166589 (owner: 10Henning Snater) [12:16:05] (03CR) 10Tobias Gritschacher: [C: 032] fingerprint(list)view: Queue calls to stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166590 (https://bugzilla.wikimedia.org/72020) (owner: 10Henning Snater) [12:22:38] (03Merged) 10jenkins-bot: label-/description-/aliasesview: Support setting state via option() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166589 (owner: 10Henning Snater) [12:23:05] (03Merged) 10jenkins-bot: fingerprint(list)view: Queue calls to stopEditing() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166590 (https://bugzilla.wikimedia.org/72020) (owner: 10Henning Snater) [12:28:49] (03PS2) 10Tobias Gritschacher: New Wikidata Build 20/10/2014 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167547 [12:32:09] aude: want to merge https://gerrit.wikimedia.org/r/#/c/167547/ ? [12:32:26] should fix dependency issue and edit-conflicts [12:32:29] self merge is ok for the build [12:32:33] ok [12:32:35] :) [12:32:38] :) [12:32:52] just don't want it to do too often [12:33:04] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build 20/10/2014 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167547 (owner: 10Tobias Gritschacher) [12:33:21] unit-tests for the build are running in 2 minutes now [12:33:27] it's all been code reviewed already [12:33:40] (was 8 minutes before) [12:33:40] and jenkins approves [12:34:02] it seems to still be using bcrypt for some api tests [12:34:23] [13WikibaseDataModelJavascript] 15snaterlicious pushed 4 new commits to 06fingerprint: 02http://git.io/RaCHbA [12:34:23] 13WikibaseDataModelJavascript/06fingerprint 14cd0314a 15snaterlicious: Consolidated Set tests [12:34:23] 13WikibaseDataModelJavascript/06fingerprint 14e913fb6 15snaterlicious: Renamed Set.removeByKey to Set.removeItemByKey [12:34:23] 13WikibaseDataModelJavascript/06fingerprint 14afc3b78 15snaterlicious: Implemented Map [12:35:07] (03Merged) 10jenkins-bot: New Wikidata Build 20/10/2014 - 2 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167547 (owner: 10Tobias Gritschacher) [12:40:08] 3MediaWiki extensions / 3WikidataRepo: Queue requests when editing multiple terms - 10https://bugzilla.wikimedia.org/72020 (10tobias.gritschacher) 5PATC>3RESO/FIX [12:44:53] 3MediaWiki extensions / 3WikidataRepo: coordinate precision issue - 10https://bugzilla.wikimedia.org/64820#c5 (10tobias.gritschacher) 5PATC>3RESO/FIX Should be included in https://github.com/DataValues/Geo/releases/tag/1.1.0 already (according to the readme) [12:47:55] [13WikibaseDataModelJavascript] 15snaterlicious pushed 1 new commit to 06fingerprint: 02http://git.io/EnTBrA [12:47:55] 13WikibaseDataModelJavascript/06fingerprint 140c48abd 15snaterlicious: Renamed Map._map to Map._items to stay consistent with Set and List [13:03:14] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 3 new commits to 06multilingualunserializer: 02http://git.io/jafw3w [13:03:14] 13WikibaseSerializationJavaScript/06multilingualunserializer 1402a6af5 15snaterlicious: Adapted TermMap and MultiTermMap... [13:03:14] 13WikibaseSerializationJavaScript/06multilingualunserializer 149298ac7 15snaterlicious: Updated DataModelJavaScript dependency to 1.0 [13:03:14] 13WikibaseSerializationJavaScript/06multilingualunserializer 1474ff57d 15snaterlicious: Reevaluated ResourceLoader modules [13:21:59] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06multilingualunserializer: 02http://git.io/Qf1r1w [13:21:59] 13WikibaseSerializationJavaScript/06multilingualunserializer 14bd23703 15snaterlicious: Renamed reference to UnDeserializableValue to UnUnserializableValue [13:25:35] (03CR) 10Jeroen De Dauw: "Adrian, if you want to take responsibility to +2 this, then go ahead. I'm not -2, though do think commits such as these are a big part of " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [13:26:19] (03CR) 10Jeroen De Dauw: [C: 032] Add @group Database to AvailableBadgesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167554 (owner: 10Aude) [13:28:11] (03CR) 10Jeroen De Dauw: "Might this not simply hide the problem and cause parts of the thing to not be renumbered?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167454 (owner: 10Hoo man) [13:29:04] DanielK_WMDE__: can you point me to this entity content performance thing you mentioned in the daily? [13:29:39] benestar|cloud: Rebaseeee https://gerrit.wikimedia.org/r/#/c/158641/ else no merge ;p [13:31:36] (03CR) 10Jeroen De Dauw: Refactor RepoHooks::onOutputPageBodyAttributes (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [13:31:56] aude: Thiemo_WMDE: the shed should be green https://gerrit.wikimedia.org/r/#/c/167187/ [13:38:05] (03PS1) 10Henning Snater: Fixed wrong checks for undefined in QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167570 [13:38:11] (03CR) 10Aude: Refactor RepoHooks::onOutputPageBodyAttributes (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [13:42:43] (03CR) 10Henning Snater: Introduce entityChangers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [13:46:06] [13WikibaseDataModel] 15thiemowmde created 06testNs (+1 new commit): 02http://git.io/cVDhEQ [13:46:06] 13WikibaseDataModel/06testNs 14e4beee2 15Thiemo Mättig: Fix wrong diff tests namespace [13:46:23] [13WikibaseDataModel] 15thiemowmde opened pull request #250: Fix wrong diff tests namespace (06master...06testNs) 02http://git.io/aNRBEQ [13:46:30] hi, I wanna find all current member of the german bundestag, but CLAIM[39:1939555]{BETWEEN[582,2014-10-20,]} gives me an empty result? [13:50:49] <17SAANTYA> [13WikibaseDataModel] 15JanZerebecki pushed 1 new commit to 06master: 02http://git.io/Wzlqeg [13:50:49] <17SAANTYA> 13WikibaseDataModel/06master 14e447f90 15Jan Zerebecki: Merge pull request #250 from wmde/testNs... [13:50:50] <18VABBTX3> [13WikibaseDataModel] 15JanZerebecki closed pull request #250: Fix wrong diff tests namespace (06master...06testNs) 02http://git.io/aNRBEQ [13:50:54] [13WikibaseDataModel] 15JanZerebecki 04deleted 06testNs at 14e4beee2: 02http://git.io/3PTxbg [13:51:44] wmde/WikibaseDataModel/testNs/e4beee2 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38498721 [13:59:23] (03CR) 10Jeroen De Dauw: [C: 031] "I did not see the introduction of SqlUsageTrackerSchemaUpdate. With that I'll +1 the change, though my objections against the approach tak" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [14:05:23] (03CR) 10Aude: "since this is not used anywhere, then I assume wikibase still works ok w/o the schema update? (since it might not happen at exact time of " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [14:28:03] (03CR) 10Thiemo Mättig (WMDE): Introduce usage tracking service. (0336 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [14:29:30] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/L8bQCw [14:29:30] 13WikidataBrowserTests/06master 14a9b9e96 15Tobias Gritschacher: Fix check if JS has been initialized [14:50:15] (03PS2) 10Thiemo Mättig (WMDE): Refactor RepoHooks::onOutputPageBodyAttributes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 [14:51:15] (03CR) 10Thiemo Mättig (WMDE): "An OutputPage actually is an IContextSource. Thats why I picked "Context". Whatever. Changed it to OutputPage." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [14:53:45] (03Draft2) 10Aude: Use one TestUser instance and not use bcrypt [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167576 [15:02:20] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/XPg25w [15:02:20] 13WikidataBrowserTests/06master 146d4a9f2 15Tobias Gritschacher: Fix accessor to add-claim button after toolbar refactoring [15:10:28] (03CR) 10Aude: [C: 032] Refactor RepoHooks::onOutputPageBodyAttributes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [15:10:39] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mmhptQ [15:10:39] 13WikibaseDatabase/06master 14961fbaf 15jeroendedauw: Update release notes [15:13:36] wmde/WikibaseDatabase/master/961fbaf : jeroendedauw The build was broken. http://travis-ci.org/wmde/WikibaseDatabase/builds/38507018 [15:18:48] (03Merged) 10jenkins-bot: Refactor RepoHooks::onOutputPageBodyAttributes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167187 (owner: 10Thiemo Mättig (WMDE)) [15:21:43] (03CR) 10Daniel Kinzler: Introduce usage tracking service. (0334 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [15:23:16] [13WikibaseDatabase] 15JeroenDeDauw created 06rmescp (+1 new commit): 02http://git.io/QJVlgg [15:23:16] 13WikibaseDatabase/06rmescp 1489ec538 15jeroendedauw: Remove escaper code [15:29:38] [13WikibaseDatabase] 15JeroenDeDauw 04deleted 06extraValidation at 144603061: 02http://git.io/2xreEg [15:29:49] it seems trigger_error in hhvm under phpunit has the effect of exit example: https://github.com/wmde/WikibaseDataModel/blob/master/src/Entity/Diff/EntityDiff.php#L69 from test: https://github.com/wmde/WikibaseDataModel/blob/master/tests/unit/Entity/Diff/ItemDiffTest.php#L268 [15:30:52] any ideas how to work around that? [15:30:58] wmde/WikibaseDatabase/rmescp/89ec538 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDatabase/builds/38508487 [15:31:15] oh not that trigger_error again [15:31:30] It's triggering errors alright [15:50:45] heh convertNoticesToExceptions to true in phpunit.xml makes it work [15:51:19] (03PS1) 10Thiemo Mättig (WMDE): Clean up introduction of usage tracking service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 [15:51:56] (03CR) 10Thiemo Mättig (WMDE): "Fixed most (but not all, especially not the documentation) in Ie3b539c." (0315 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [15:52:08] like setting it to false under hhvm somehow makes phpunits exception/error handling fail [15:55:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Factor connection management into separate class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 (owner: 10Daniel Kinzler) [15:58:06] [13WikibaseDataModel] 15JanZerebecki created 06hhvm-workarounds (+2 new commits): 02http://git.io/5sA12g [15:58:06] 13WikibaseDataModel/06hhvm-workarounds 140c4274c 15Jan Zerebecki: Change test to not compare the implementation with itself.... [15:58:06] 13WikibaseDataModel/06hhvm-workarounds 14c9e800b 15Jan Zerebecki: Change phpunit convertNoticesToExceptions to true.... [16:00:33] [13WikibaseDataModel] 15JanZerebecki opened pull request #251: HHVM workarounds (06master...06hhvm-workarounds) 02http://git.io/t21RGA [16:00:55] DanielK_WMDE__: want something to do? [16:01:00] we call getEntity twice in https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/actions/ViewEntityAction.php#L175-L197 [16:01:20] both in case if !$content->isRedirect() [16:01:57] this could use some improvement :) [16:03:28] wmde/WikibaseDataModel/hhvm-workarounds/c9e800b : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/38512116 [16:07:08] aude: with my DeferredDeserialization patch, it wouldn't matter :) [16:21:53] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06hhvm-workarounds from 14c9e800b to 143dd5504: 02http://git.io/EjQvig [16:21:53] 13WikibaseDataModel/06hhvm-workarounds 143dd5504 15Jan Zerebecki: Change phpunit convertNoticesToExceptions to true.... [16:26:59] [13WikibaseDataModel] 15JanZerebecki pushed 1 new commit to 06hhvm-workarounds: 02http://git.io/XIlN8A [16:26:59] 13WikibaseDataModel/06hhvm-workarounds 14b619f5d 15Jan Zerebecki: Change travis configuration to not allow HHVM failures. [16:44:56] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Tests for WikibaseDataModel on Travis are failing (due to PHPUnit version used) - 10https://bugzilla.wikimedia.org/69525#c3 (10Jan Zerebecki) 5ASSI>3PATC https://github.com/wmde/WikibaseDataModel/pull/251 [16:56:09] (03PS20) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) [16:56:56] (03PS6) 10Daniel Kinzler: Factor connection management into separate class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165260 [16:58:00] (03PS17) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) [17:02:46] (03PS14) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [17:08:41] (03CR) 10jenkins-bot: [V: 04-1] Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [17:10:26] (03CR) 10jenkins-bot: [V: 04-1] Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) (owner: 10Daniel Kinzler) [17:17:30] (03CR) 10Hoo man: [C: 032] "Makes sense :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167576 (owner: 10Aude) [17:18:38] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=72242 [17:18:48] do we have a nice way to get the serialization array? [17:19:02] So that we can look where it's weird and then fix the root cause? [17:19:21] eval.php ? [17:19:22] My "don't recurse to much"-patch is a rather ugly workaround [17:19:37] Yeah... but that involves a lot of steps :S [17:20:12] what do you think i did for debugging Q183 and Q72? :/ [17:20:33] meh [17:20:34] was super annoying [17:20:39] do you have the snippet you used? [17:21:18] do you just need the serialization array, pre lua? [17:22:31] aude: Yep, that should hopefully have that I want to see [17:22:40] https://gist.github.com/filbertkm/f5ed21df62e18022c17a [17:22:51] that part is easy [17:23:06] Awesome! [17:23:10] it's getting at all the parts of entity view that are annoying [17:23:22] bene has a patch to make a factory object for some of that which would help [17:23:39] Don't need that... we just use the serialization and stuff it into the function which then OOMs [17:23:47] yep [17:23:54] we have fallback chain stuff set, but I hope that doesn't matter [17:24:04] * hoo doesn't understand how our fallback stuffs works [17:24:15] https://gerrit.wikimedia.org/r/#/c/158641/ needs rebase [17:24:47] essentially came up with all that to run on terbium :( [17:25:06] Yikes [17:25:11] (03Merged) 10jenkins-bot: Use one TestUser instance and not use bcrypt [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167576 (owner: 10Aude) [17:27:38] * hoo will poke at the Q30 issue later on [17:28:10] Branch tomorrow? [17:30:24] probably wednesday [17:30:43] * aude going home [17:31:02] good enough :) [17:38:34] does magnus frequent the IRC chat and if so, what's his nick? [17:39:06] Sometimes I think.... [17:39:17] A tweet is faster. ;) [17:41:28] pff. these modern communication models. [18:08:23] sjoerddebruin: when I was young I had to use CompuServe. In the Winter. Uphill. Both ways. [18:08:34] :O [18:11:34] lolol [18:11:54] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Ok for me. Just some comments, probably no reason to amend. Will merge this the next days if nobody objects." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) (owner: 10Daniel Kinzler) [18:12:56] we didn't even have a Commons. Not like the young folks today, with their centralized databases and stuff. we had to point the portraits into the Wikipedia articles by hand. using ASCII art. [18:13:12] *paint [18:14:43] and whenever the server was down - and that was often back in those days - we first had to use a magnet to push the bits in the config files into the right position before we could reboot it [18:15:06] (03CR) 10JanZerebecki: [C: 032] Do not show year "minus zero" as fallback [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167313 (owner: 10Thiemo Mättig (WMDE)) [18:15:12] * Lydia_WMDE notes dennyvrandecic had a hard life back then :P [18:15:54] is there a bureaucrat here to give her admin status to Harmonia_Amanda ? https://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Administrator/Harmonia_Amanda [18:21:57] (03Merged) 10jenkins-bot: Do not show year "minus zero" as fallback [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167313 (owner: 10Thiemo Mättig (WMDE)) [18:29:01] dennyvrandecic: we had to knit our magnetic-core memories from magnetized and unmagnetized cores back then. [18:29:08] beat that. [18:29:11] ;) [18:31:55] Thiemo_WMDE: at least you had unmagnetized cores! we had to first smelt the magnetized ones and turning the hot metal while it was liquid to unmagnetize them. [18:32:23] uh. ok, can't beat that. [18:32:46] Vogone: there's some work for you ^^ [18:33:09] woot? that was too easy :D [18:35:16] Herb Simon (Turinh Award and Nobel prize), in 1955 on his xmas break, had no access to computers, but had an idea for an algorithm [18:35:45] So he used his children as registers and had them switch cards they held in 'memory' based on the rules he told them [18:35:50] to verify it works [18:35:57] *Turing [18:37:46] Stryn: if you do the rest … I'm busy [18:38:07] well, I was just gonna leave, but trying.. [18:39:01] (03CR) 10Thiemo Mättig (WMDE): "Pretty much ok for me. Just some small details that may be adresed in this patch or an following one." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [18:39:36] I've got a report of this error: [18:39:38] "Error: [Exception... "" nsresult: "0x805e006 ()" location: "JS frame :: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=jquery,mediawiki&only=scripts&skin=vector&version=20141016T200718Z :: .send :: line 140" data: no]" [18:50:14] helpful... [18:50:32] sjoerddebruin: is there any more details on the error message? [18:50:58] legoktm: No, the user seems to have connection issues with IRC. [18:51:09] :\ [19:05:53] 3MediaWiki extensions / 3WikidataClient: pencil icon for "Edit links" should use wikifont - 10https://bugzilla.wikimedia.org/65527#c6 (10Jared Zimmerman (WMF)) Just looked at the icon in that context at 10px and 12px, both seem fine. your screenshot shows the old raster icon rather than the new svg. I'm... [22:08:33] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/38525449 :S