[00:02:53] [13WikibaseQueryEngine] 15JeroenDeDauw created 06ingroup (+1 new commit): 02http://git.io/rc9seQ [00:02:53] 13WikibaseQueryEngine/06ingroup 145411922 15jeroendedauw: Remove @ingroup tags [00:07:07] wmde/WikibaseQueryEngine/kittens/3601ce1 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/38105677 [00:14:20] wmde/WikibaseQueryEngine/ingroup/5411922 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/38106000 [00:39:40] [13WikibaseQueryEngine] 15JeroenDeDauw pushed 1 new commit to 06kittens: 02http://git.io/sg-eaQ [00:39:40] 13WikibaseQueryEngine/06kittens 14f213b5c 15jeroendedauw: Add can$action methods to the writer strategies [01:52:16] (03PS1) 10Jackmcbarn: Fix Special:Version [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/166934 [02:22:19] ̧̞̭̙̀͘ȩ̟͓̝᷄ͯ̏l̶᷂̲̙᷊̓̕l̡̛̲̹̩̯ͅ ̳̫᷂͎̂ͪ̈́h̺̰̜͒̎ͫ̊e͈̙ͭ́᷄̈᷆l̥᷂͖ͥ̏᷅͝l̸͙᷈̉̍̅᷉o͗̎͡ ͣ̉͋̆̓ͬ̕t͍᷊̬ͧͫ̕͟ḩ̶͙͓̓᷈͢ẽ̠̼̺ͧ̑͑r͎͉͇̃̚͟͡e̵͎̪͌ͩ᷄̊ [02:22:23] haha [04:49:41] (03CR) 10Legoktm: [C: 032] Fix Special:Version [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/166934 (owner: 10Jackmcbarn) [04:52:06] (03Merged) 10jenkins-bot: Fix Special:Version [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/166934 (owner: 10Jackmcbarn) [07:13:37] (03CR) 10Adrian Lang: "oops." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166536 (owner: 10Henning Snater) [07:24:09] (03CR) 10Adrian Lang: Refactored toolbars (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [07:29:54] (03CR) 10Adrian Lang: Introduce entityChangers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [07:33:31] (03PS1) 10Adrian Lang: Make sure list item prototypes have a value method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166955 [07:33:54] (03CR) 10Adrian Lang: "Done in I92cda5e43f1c49deecee21169d732a307dfc3e93." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165183 (owner: 10Adrian Lang) [07:34:40] (03PS1) 10Thiemo Mättig (WMDE): Optimize/add missing use clauses in Client after DM 2.0 switch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166956 [07:47:48] (03PS1) 10Thiemo Mättig (WMDE): Clean up Scribunto code in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166958 [07:50:22] hello [07:50:38] Hi hashar [07:51:08] I am going to upgrade PHPUnit in integration/phpunit.git bumping it from 3.7.28 to 3.7.37 [07:51:41] the instances used to run your tests will eventually be updated via puppet iirc :D [07:51:54] Cool [07:54:48] hashar: let's hope so. [07:55:26] mediawiki/core release branches and master pass at least :-] [07:56:45] (03CR) 10jenkins-bot: [V: 04-1] Clean up Scribunto code in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166958 (owner: 10Thiemo Mättig (WMDE)) [08:03:39] Thiemo_WMDE: this might also happen with other datavalues besides time-value, no? https://bugzilla.wikimedia.org/show_bug.cgi?id=71289 [08:03:59] so not sure if we should keep it still open [08:19:18] (03PS9) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [09:07:01] (03CR) 10Tobias Gritschacher: "Some of our public documentation pages still refer to the old name. That should be fixed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165905 (owner: 10Hoo man) [09:11:21] [13WikidataBrowserTests] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/WT68rQ [09:11:21] 13WikidataBrowserTests/06master 14048676a 15Adrian Lang: Merge pull request #14 from wmde/api... [09:14:17] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 87.138.110.76 link https://www.mediawiki.org/w/index.php?diff=1226293 edit summary: [+78] Use $wgWBClientSettings instead of $wgWBSettings [09:28:16] (03PS1) 10Thiemo Mättig (WMDE): Optimize/add missing use clauses in Lib after DM 2.0 switch [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166966 [09:38:54] 3MediaWiki extensions / 3WikidataClient: Q161192 gives an error in lua on wikidata.org - 10https://bugzilla.wikimedia.org/72124 (10snaevar) 3UNCO p:3Unprio s:3normal a:3Wikidata bugs mw.wikibase.getEntityObject(Q161192) gives an nil as an output on wikidata.org, even though visiting that item [[d:Q16... [09:51:57] (03PS10) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [09:58:52] 3MediaWiki extensions / 3WikidataRepo: Label/Description uniqueness constraint is not enforced by Special:NewItem, leading to duplicates. - 10https://bugzilla.wikimedia.org/72085 (10Lydia Pintscher) [09:59:38] Adrian_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=72075 [09:59:43] Thiemo_WMDE: ^ [10:01:37] was the same bug in both mails, never mind. [10:01:51] ok cool [10:01:53] (03CR) 10jenkins-bot: [V: 04-1] Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [10:09:26] (03PS11) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [10:12:33] aude: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#France_item_seems_big [10:13:47] oh noes [10:15:06] Lydia_WMDE: looks like they were able to undo https://www.wikidata.org/w/index.php?title=Q142&action=history [10:15:19] ok [10:15:22] but think we've seen this in the logs [10:15:29] the item is not *that* big [10:17:11] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=71479#c9 [10:17:12] and https://bugzilla.wikimedia.org/show_bug.cgi?id=71479#c22 [10:17:15] about undo [10:18:41] [13WikidataBrowserTests] 15tobijat created 06adjust_to_toolbarrefactoring (+1 new commit): 02http://git.io/Wb3LKw [10:18:41] 13WikidataBrowserTests/06adjust_to_toolbarrefactoring 14239e22d 15Tobias Gritschacher: Adjust buttons for labels and descriptions [10:20:24] 3MediaWiki extensions / 3WikidataRepo: monolingual text does not accept sr-cyrl as language code - 10https://bugzilla.wikimedia.org/72126 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs It is possible to select sr-cyrl as a language code for a monolingual text value. However it is not p... [10:25:27] (03CR) 10Henning Snater: "Patch set 9: Rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [10:25:52] 3MediaWiki extensions / 3WikidataRepo: monolingual text does not accept sr-cyrl as language code - 10https://bugzilla.wikimedia.org/72126 (10Lydia Pintscher) p:5Unprio>3Normal [10:29:57] (03PS1) 10Adrian Lang: Fix floating of property name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166971 (https://bugzilla.wikimedia.org/72075) [10:31:01] (03PS1) 10Adrian Lang: Improve claimgrouplabelscroll code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 [10:31:28] (03PS1) 10Thiemo Mättig (WMDE): JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 [10:31:57] (03PS1) 10Adrian Lang: Actually put wb.client.getMwApiForRepo in wb.client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166974 [10:43:45] (03CR) 10Adrian Lang: [C: 04-1] "Some issues." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [10:46:47] (03CR) 10jenkins-bot: [V: 04-1] JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [10:55:43] (03CR) 10Henning Snater: [C: 04-1] JS and CSS clean up based on static code analysis (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [11:17:24] (03CR) 10Adrian Lang: "This might be broken with rtl." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166972 (owner: 10Adrian Lang) [11:24:59] (03PS1) 10Adrian Lang: Avoid some TypeErrors in strict mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166978 [11:34:55] (03CR) 10Adrian Lang: [C: 04-1] "Broken in Firefox." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [11:36:16] (03CR) 10Adrian Lang: "newFor does not really matter from my point of view, since we have wikibase.client.getMwApiForRepo now, which can and should be used publi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [11:52:48] (03CR) 10Adrian Lang: [C: 032] "Worked in firefox after some aggressive purging of resources. Improves performance, also. I couldn't run browser tests, though, since they" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [11:53:57] (03PS2) 10Henning Snater: Manage "save" button state when changing referenceview state [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161914 [11:54:10] (03PS3) 10Henning Snater: Initialize toolbars on existing DOM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 [11:54:15] (03PS3) 10Henning Snater: Deferred edittoolbar tooltip init to when switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161927 [11:55:11] (03CR) 10Adrian Lang: "Why should this have a deprecation stage but Inject configured mwApi into RepoApi not? I think it would be enough if I provide a migration" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 (owner: 10Adrian Lang) [11:57:14] (03CR) 10Adrian Lang: "Needs purging, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 (owner: 10Henning Snater) [12:02:02] is there a mirror for the actual json dump anywhere? dumps.wikimedia is very slow at the moment [12:03:33] (03PS2) 10Henning Snater: Implemented singlebuttontoolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161937 [12:04:00] (03CR) 10Adrian Lang: Replace wb.fetchedEntities with wb.store.EntityStore (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/107554 (https://bugzilla.wikimedia.org/54082) (owner: 10Adrian Lang) [12:05:25] (03PS4) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) [12:09:55] (03PS2) 10Henning Snater: Reuse static toolbar button DOM nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 [12:14:12] (03PS3) 10Henning Snater: Reuse static toolbar button DOM nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161949 [12:15:41] (03PS5) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) [12:15:43] (03PS3) 10Adrian Lang: Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 [12:15:45] (03PS3) 10Adrian Lang: Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 [12:15:47] (03PS2) 10Adrian Lang: Remove wikibase.getRevisionStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 [12:16:28] (03CR) 10Adrian Lang: "Rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 (owner: 10Adrian Lang) [12:16:33] (03CR) 10Adrian Lang: "Rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 (owner: 10Adrian Lang) [12:16:39] (03CR) 10Adrian Lang: "Rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (https://bugzilla.wikimedia.org/56246) (owner: 10Adrian Lang) [12:16:47] (03CR) 10Adrian Lang: "Rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 (owner: 10Adrian Lang) [12:17:11] (03PS2) 10Henning Snater: Suppress redrawing when initializing toolbar on existing nodes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161959 [12:19:00] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06adjust_to_toolbarrefactoring: 02http://git.io/LOo28Q [12:19:00] 13WikidataBrowserTests/06adjust_to_toolbarrefactoring 14e456c92 15Tobias Gritschacher: Adjusted buttons for aliases [12:19:54] (03Merged) 10jenkins-bot: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [12:21:55] wikimedia/mediawiki-extensions-Wikibase/master/4379ffe : Henning Snater The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38149468 [12:22:03] (03CR) 10Adrian Lang: [C: 032] Manage "save" button state when changing referenceview state [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161914 (owner: 10Henning Snater) [12:28:05] [13WikimediaBadges] 15filbertkm 04deleted 06featuredlist at 14c24fb6f: 02http://git.io/ViZh3Q [12:31:28] (03PS1) 10Aude: Update Wikidata, add/fix badges css [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/166988 [12:35:46] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/166988 (owner: 10Aude) [12:36:41] hmmmm wdjenkins not found [12:43:45] (03Merged) 10jenkins-bot: Manage "save" button state when changing referenceview state [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161914 (owner: 10Henning Snater) [12:44:38] (03PS1) 10Aude: Update Wikidata, add/fix badges css [extensions/Wikidata] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166991 [12:45:03] (03Abandoned) 10Aude: Update Wikidata, add/fix badges css [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/166988 (owner: 10Aude) [12:45:55] wikimedia/mediawiki-extensions-Wikibase/master/4d1d8d8 : Henning Snater The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38151221 [12:47:43] (03CR) 10Adrian Lang: [C: 032] Initialize toolbars on existing DOM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 (owner: 10Henning Snater) [12:48:42] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166991 (owner: 10Aude) [12:57:53] (03CR) 10Aude: [C: 032] Update Wikidata, add/fix badges css [extensions/Wikidata] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166991 (owner: 10Aude) [12:58:20] (03Merged) 10jenkins-bot: Initialize toolbars on existing DOM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161924 (owner: 10Henning Snater) [12:59:05] (03PS1) 10Henning Snater: fingerprint-/sitelinkgroupview: Fixed event handler parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166993 [12:59:18] (03PS1) 10Adrian Lang: Remove legacy jshintignore file and fix hidden jshint errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166994 [13:00:25] wikimedia/mediawiki-extensions-Wikibase/master/a09d648 : Henning Snater The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38152728 [13:01:20] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06adjust_to_toolbarrefactoring: 02http://git.io/pW2L8w [13:01:20] 13WikidataBrowserTests/06adjust_to_toolbarrefactoring 14d83972e 15Tobias Gritschacher: Adjust buttons in reference/statements/sitelinks tests [13:01:50] Tobi_WMDE_SW: https://gerrit.wikimedia.org/r/#/c/166993/ [13:03:19] [13WikidataBrowserTests] 15tobijat opened pull request #15: Adjust tests to toolbarrefactoring (06master...06adjust_to_toolbarrefactoring) 02http://git.io/HcphHg [13:07:04] (03Merged) 10jenkins-bot: Update Wikidata, add/fix badges css [extensions/Wikidata] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/166991 (owner: 10Aude) [13:07:08] DanielK_WMDE: https://packagist.org/packages/phpunit/phpunit-dom-assertions which is WIP and uses symfony stuff [13:08:48] DanielK_WMDE: if you do not like the symfony variant: https://github.com/FluentDOM/FluentDOM [13:10:31] Lydia_WMDE: please invite me to the org https://github.com/DataValues [13:11:46] jzerebecki: this seems simpler: https://github.com/phpunit/phpunit-dom-assertions [13:12:33] jzerebecki: it actually uses symphony [13:13:08] which i don't think is a problem to have in wikibase, as long as we don't execute the code in production [13:13:16] make it a dev dependency [13:13:39] and might be also desired in core [13:15:24] jzerebecki: FluentDOM with Carica/PhpCss is only a replacement for the selection not for the assertion, so yes phpunit-dom-assertions seems like a better fit [13:15:34] (03PS3) 10Daniel Kinzler: Check label/description constraint for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) [13:17:00] (03PS2) 10Thiemo Mättig (WMDE): JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 [13:17:06] (03CR) 10jenkins-bot: [V: 04-1] JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [13:17:10] (03CR) 10Thiemo Mättig (WMDE): JS and CSS clean up based on static code analysis (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [13:25:15] (03CR) 10jenkins-bot: [V: 04-1] Check label/description constraint for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) (owner: 10Daniel Kinzler) [13:33:48] [13WikibaseQueryEngine] 15addshore closed pull request #127: Remove @ingroup tags (06master...06ingroup) 02http://git.io/tNU9nA [13:34:06] [13WikibaseQueryEngine] 15addshore 04deleted 06dv1 at 1448c4cc9: 02http://git.io/KqSnIw [13:40:05] (03PS1) 10Henning Snater: claimview edittoolbar definition: Register all events by default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166998 [13:45:12] (03PS3) 10Thiemo Mättig (WMDE): JS and CSS clean up based on static code analysis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 [14:03:02] DanielK_WMDE: is that a bug or can i remove the argument $precision?: https://scrutinizer-ci.com/g/DataValues/Geo/issues/master/files/src/Formatters/GeoCoordinateFormatter.php?orderField=path&order=asc [14:07:21] how is this possible? [[Q9854593]] and [[Q16300253]] both contain the same link [14:07:28] to Romanian [14:08:13] shouldn't that be impossible? [14:08:17] FakirNL: might have been a race condition or something [14:08:23] yes it should not be possible [14:08:34] race condition? [14:08:51] like two people trying to add the link at the exact same time [14:09:23] anyway - just remove it from one and it's fine :) [14:10:18] the second item was created a year after the first [14:10:25] but i'll remove one and merge the items [14:11:10] strange [14:11:47] jzerebecki: it'S not a bug, and the parameter should stay. [14:12:14] jzerebecki: the parameter list declares what info is available to that method. it should not depend on the current implementation [14:12:24] for private methods, this is arguably not really important. [14:12:25] DanielK_WMDE: it is only a private function? [14:12:59] it's still nice to declare what info is available, don't you think? [14:13:02] and it doesn't hurt [14:13:10] (03PS2) 10Thiemo Mättig (WMDE): Clean up Scribunto code in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166958 [14:13:11] it's only the silly sniffers that complain about this. [14:13:51] :) [14:15:18] (03PS2) 10Thiemo Mättig (WMDE): Add TimeFormatterParserRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166748 [14:17:21] [13WikibaseDataModel] 15thiemowmde created 06ranks (+1 new commit): 02http://git.io/ICIfvw [14:17:21] 13WikibaseDataModel/06ranks 14ddce0b1 15Thiemo Mättig: Stop using deprecated ranks [14:18:13] [13WikibaseDataModel] 15thiemowmde opened pull request #245: Stop using deprecated ranks (06master...06ranks) 02http://git.io/fDTGjw [14:26:15] (03PS2) 10Henning Snater: claimview edittoolbar definition: Register all events by default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166998 [14:26:17] (03PS2) 10Henning Snater: fingerprint-/sitelinkgroupview: Fixed event handler parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166993 [14:26:19] (03PS1) 10Henning Snater: referencveview edittoolbar definition: Fixed $container length detection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167002 [14:30:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix floating of property name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166971 (https://bugzilla.wikimedia.org/72075) (owner: 10Adrian Lang) [14:34:03] [13Wikidata.org] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/Sclxbg [14:34:03] 13Wikidata.org/06master 14d11539d 15thiemowmde: Merge pull request #15 from wmde/featuredlist... [14:40:29] (03CR) 10Tobias Gritschacher: [C: 032] fingerprint-/sitelinkgroupview: Fixed event handler parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166993 (owner: 10Henning Snater) [14:40:43] (03CR) 10Tobias Gritschacher: [C: 032] claimview edittoolbar definition: Register all events by default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166998 (owner: 10Henning Snater) [14:40:59] (03CR) 10Tobias Gritschacher: [C: 032] referencveview edittoolbar definition: Fixed $container length detection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167002 (owner: 10Henning Snater) [14:42:08] 3MediaWiki extensions / 3WikidataRepo: Possibility to enter new sitelink instantly when editing sitelink-section - 10https://bugzilla.wikimedia.org/72023 (10Lydia Pintscher) s:5normal>3major [14:43:24] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Ok for me. Makes sense. Daniel?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166869 (owner: 10Hoo man) [14:44:26] Henning_WMDE: https://github.com/wmde/WikidataBrowserTests/pull/15 [14:45:18] [13WikidataBrowserTests] 15snaterlicious closed pull request #15: Adjust tests to toolbarrefactoring (06master...06adjust_to_toolbarrefactoring) 02http://git.io/HcphHg [14:45:52] 3MediaWiki extensions / 3WikidataRepo: Add move gadget to Wikibase core - 10https://bugzilla.wikimedia.org/72019#c1 (10Lydia Pintscher) Should get some input from Henning on interaction and design. I am not sure we want this to be in the core. This seems like one of those power-user features that are best d... [14:46:00] (03PS4) 10Daniel Kinzler: Check label/description constraint for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166786 (https://bugzilla.wikimedia.org/43734) [14:49:23] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/UHmu5A [14:49:23] 13WikibaseQueryEngine/06master 14ca9dde2 15thiemowmde: Merge pull request #126 from wmde/kittens... [14:50:21] (03Merged) 10jenkins-bot: Fix floating of property name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166971 (https://bugzilla.wikimedia.org/72075) (owner: 10Adrian Lang) [14:55:28] (03Merged) 10jenkins-bot: fingerprint-/sitelinkgroupview: Fixed event handler parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166993 (owner: 10Henning Snater) [14:55:52] (03CR) 10Hoo man: [C: 032] Clean up Scribunto code in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166958 (owner: 10Thiemo Mättig (WMDE)) [14:55:56] wikimedia/mediawiki-extensions-Wikibase/master/52a3a36 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38164954 [14:56:33] (03Merged) 10jenkins-bot: claimview edittoolbar definition: Register all events by default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166998 (owner: 10Henning Snater) [14:56:46] aude: is it possible to have a new build deployed to beta? [14:57:21] after the change I just +2ed was merged? [14:57:46] or anytime today? otherwise browsertests will continue failing [14:58:05] (03Merged) 10jenkins-bot: referencveview edittoolbar definition: Fixed $container length detection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167002 (owner: 10Henning Snater) [14:59:37] 3MediaWiki extensions / 3WikidataRepo: property names in long statements don't float anymore when scrolling - 10https://bugzilla.wikimedia.org/72075 (10Lydia Pintscher) 5PATC>3RESO/FIX [15:02:07] wikimedia/mediawiki-extensions-Wikibase/master/020af45 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38165443 [15:03:21] Anyone about for auds SWAT request? [15:04:04] (03Merged) 10jenkins-bot: Clean up Scribunto code in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166958 (owner: 10Thiemo Mättig (WMDE)) [15:06:54] wikimedia/mediawiki-extensions-Wikibase/master/fba8f06 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38165532 [15:08:46] (03CR) 10Hoo man: [C: 04-1] JS and CSS clean up based on static code analysis (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [15:09:27] ah [15:09:39] aude, hoo ^^? [15:09:58] i am there [15:10:26] k [15:10:31] Tobi_WMDE_SW: if you want to make a build, git clone Wikidata.git [15:10:36] npm install [15:10:47] grunt uninstall (clean) && grunt install [15:10:53] or i can do it in a bit [15:11:01] [13WikibaseQuery] 15thiemowmde created 06dm20 (+1 new commit): 02http://git.io/F9mILQ [15:11:01] 13WikibaseQuery/06dm20 14a7ea6be 15Thiemo Mättig: Update to DataModel 2.0 [15:11:36] aude: I think I tried that some days ago and I failed.. will have to have a closer look. would be great if you can make it today. [15:11:44] ok [15:11:47] not necessary to do it right now [15:11:54] [13WikibaseQuery] 15thiemowmde opened pull request #54: Update to DataModel 2.0 (06master...06dm20) 02http://git.io/p5oRkg [15:11:59] i can sit with you sometime to have you do it [15:12:01] anytime this evening or even tomorrow morning would be ok [15:12:01] * aude can do this time [15:12:22] only if build resources is updated, do we need to use that to make a build from scratch [15:14:34] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06Phpunit from 14b96b3e6 to 141b180da: 02http://git.io/iY6uGA [15:14:34] 13WikibaseQueryEngine/06Phpunit 14323e438 15Thiemo Mättig: Lowercase phpunit folder [15:14:34] 13WikibaseQueryEngine/06Phpunit 141b180da 15Thiemo Mättig: Update bootstrap [15:16:10] wmde/WikibaseQuery/dm20/a7ea6be : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/38166974 [15:16:38] [13WikibaseQueryEngine] 15thiemowmde closed pull request #85: Accept GlobeCoordinateValue in LatLongHandler (06master...06this-math) 02http://git.io/GMWDyw [15:22:44] (03CR) 10Thiemo Mättig (WMDE): "A -1 because of a something unrelated I did _not_ changed? Come on." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166973 (owner: 10Thiemo Mättig (WMDE)) [15:28:08] [13Geo] 15thiemowmde created 06parseReturn (+1 new commit): 02http://git.io/pYWDbg [15:28:08] 13Geo/06parseReturn 1490520d8 15Thiemo Mättig: Fix return type in GeoCoordinateParserBase [15:28:22] [13Geo] 15thiemowmde opened pull request #22: Fix return type in GeoCoordinateParserBase (06master...06parseReturn) 02http://git.io/kO9Zpg [15:31:34] [13Geo] 15thiemowmde 04force-pushed 06parseReturn from 1490520d8 to 14f4ba825: 02http://git.io/px9FMg [15:31:34] 13Geo/06parseReturn 14f4ba825 15Thiemo Mättig: Fix return type in GeoCoordinateParserBase [15:42:25] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 [15:42:42] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 (owner: 10Tobias Gritschacher) [15:43:54] aude: thin I managed to build https://gerrit.wikimedia.org/r/#/c/167008/ [15:44:01] *think [15:44:40] yay, but why does jenkins say no ? :( [15:45:44] namespaces... [15:45:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 (owner: 10Tobias Gritschacher) [15:46:33] aude: hmmm [15:46:40] why are they wrong [15:49:07] * aude is looking into why search (cirrus) now only finds properties [15:49:19] we changed the config, it looks correct in production [15:51:11] [13Geo] 15thiemowmde created 06killGeo (+1 new commit): 02http://git.io/30xzZQ [15:51:11] 13Geo/06killGeo 1462c261f 15Thiemo Mättig: Stop calling LatLong stuff GeoCoordinate [15:53:15] [13Geo] 15thiemowmde opened pull request #23: Stop calling LatLong stuff GeoCoordinate (06master...06killGeo) 02http://git.io/ILAFVw [16:00:31] [13Geo] 15thiemowmde created 06latLongTest (+1 new commit): 02http://git.io/kFvxpQ [16:00:31] 13Geo/06latLongTest 147f7840b 15Thiemo Mättig: Remove broken LatLongValueTest cases [16:01:49] Lydia_WMDE: Tobi_WMDE_SW anyone can you try searchingon wikidata https://www.wikidata.org/wiki/Special:Search [16:02:08] tell me which checkboxes are checked and if you can find items and/or properties [16:02:11] [13Geo] 15thiemowmde opened pull request #24: Remove broken LatLongValueTest cases (06master...06latLongTest) 02http://git.io/_CuSCA [16:02:26] please log in [16:03:43] aude: I'm logged in and searched for "Graz" [16:04:00] found several items [16:04:03] [13Geo] 15JanZerebecki created 06cleanup (+5 new commits): 02http://git.io/I5U6gQ [16:04:03] 13Geo/06cleanup 144722c3a 15Jan Zerebecki: Use original class name instead of alias. [16:04:03] 13Geo/06cleanup 14be86ebb 15Jan Zerebecki: Remove instanceof check as the argument is already of that type. [16:04:03] 13Geo/06cleanup 141f80ec7 15Jan Zerebecki: Test GeoCoordinateFormatter with wrong target type. [16:04:20] don't see any checkboxes [16:05:10] oh, wow [16:05:12] ok [16:06:39] [13Geo] 15thiemowmde 04force-pushed 06latLongTest from 147f7840b to 14ba6e2c7: 02http://git.io/s7QAbw [16:06:39] 13Geo/06latLongTest 14ba6e2c7 15Thiemo Mättig: Fix broken LatLongValueTest cases [16:07:39] aude: http://oi58.tinypic.com/21no9w4.jpg [16:07:46] tobijat ? [16:08:01] aude: ? [16:08:05] where? [16:08:14] is that you? logged in? [16:08:49] aude: that is my private user [16:08:51] i see ~400 users with the same preference as i have [16:08:58] ok [16:09:08] did the search with User:Tobias Gritschacher (WMDE) [16:09:09] anyway, need to investigate why [16:09:22] 3MediaWiki extensions / 3WikidataRepo: IE11: Empty label/description input box loses focus after typing first character - 10https://bugzilla.wikimedia.org/72027 (10Lydia Pintscher) p:5Unprio>3High [16:09:24] your privat account is affected :/ [16:09:29] ah, ok [16:09:32] I'll try [16:09:55] no clue why, except guessing maybe there used to be a preference and now it's removed from preferences [16:10:21] aude: works also with User:tobijat [16:11:02] huh [16:11:09] and i have searchNs0 | (null) [16:11:10] on enwiki [16:11:21] maybe a gadget [16:11:55] could be [16:12:05] try disable JS [16:12:17] doing [16:12:37] wokrs fine if i login as my bot [16:12:42] or logged out [16:13:29] [13Geo] 15thiemowmde 04force-pushed 06latLongTest from 14ba6e2c7 to 145a627e3: 02http://git.io/s7QAbw [16:13:29] 13Geo/06latLongTest 145a627e3 15Thiemo Mättig: Fix broken LatLongValueTest cases [16:14:38] 3MediaWiki extensions / 3WikidataRepo: Find a way to make global item ids - 10https://bugzilla.wikimedia.org/71996 (10Lydia Pintscher) p:5Unprio>3Normal [16:15:37] 3MediaWiki extensions / 3WikidataClient: Q161192 gives an error in lua on wikidata.org - 10https://bugzilla.wikimedia.org/72124 (10Lydia Pintscher) p:5Unprio>3High [16:17:57] (03PS2) 10Tobias Gritschacher: New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 [16:18:09] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 (owner: 10Tobias Gritschacher) [16:21:10] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 (owner: 10Tobias Gritschacher) [16:21:20] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167008 (owner: 10Tobias Gritschacher) [16:21:39] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167013 [16:23:51] now i see "Remember selection for future searches" on the search page [16:24:17] if i check and uncheck stuff then it works again [16:26:55] [13Geo] 15JeroenDeDauw 04deleted 06latLongTest at 145a627e3: 02http://git.io/jYg9Bw [16:27:56] [13Geo] 15JeroenDeDauw comment on pull request #23 1462c261f: Unless you intent this thing to be tagged right after this commit, this should be `2.0 alpha` 02http://git.io/VKIjZQ [16:30:36] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 16/10/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167013 (owner: 10Tobias Gritschacher) [16:34:17] [13Geo] 15JanZerebecki 04force-pushed 06parseReturn from 14f4ba825 to 14c9c09d9: 02http://git.io/px9FMg [16:34:17] 13Geo/06parseReturn 14c9c09d9 15Thiemo Mättig: Fix return type in GeoCoordinateParserBase [16:35:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/167013 (owner: 10Tobias Gritschacher) [16:36:21] [13Geo] 15JeroenDeDauw closed pull request #22: Fix return type in GeoCoordinateParserBase (06master...06parseReturn) 02http://git.io/kO9Zpg [16:40:26] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #245: Stop using deprecated ranks (06master...06ranks) 02http://git.io/fDTGjw [16:41:59] [13Geo] 15JanZerebecki 04force-pushed 06cleanup from 140e07e16 to 1470ab4bc: 02http://git.io/B6N7Ug [16:41:59] 13Geo/06cleanup 140a85a06 15Jan Zerebecki: Use original class name instead of alias. [16:41:59] 13Geo/06cleanup 14009a169 15Jan Zerebecki: Remove instanceof check as the argument is already of that type. [16:41:59] 13Geo/06cleanup 14942bce7 15Jan Zerebecki: Test GeoCoordinateFormatter with wrong target type. [16:48:18] [13Geo] 15thiemowmde pushed 1 new commit to 06killGeo: 02http://git.io/h_HxjA [16:48:18] 13Geo/06killGeo 14add554e 15thiemowmde: Update Geo.php [16:55:57] (03CR) 10Jeroen De Dauw: "Yay, one step closer to getting rid of the lib settings. Only been busy with this for two years, so ought to be rid of it in another 3 or " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165905 (owner: 10Hoo man) [17:00:36] Thiemo_WMDE: Still in here? Take a look at https://ru.wikipedia.org/wiki/%D0%9A%D0%B2%D0%B8%D0%BD%D1%82_%D0%9A%D1%83%D1%80%D1%86%D0%B8%D0%B9_%D0%A0%D1%83%D1%84 [17:00:44] That gives a nice red error with a current time [17:02:04] multichill: oh, thanks. [17:02:31] It gives a stack trace [17:02:36] not sure if this helps. the templates and lus modules are pretty advanced. that red error is from some community maintained lua code, it seems. [17:04:10] Thiemo_WMDE: End of the trace is mw.lua:497: [17:04:17] found it. it says the error is in [[:ru:Модуль:RomanNumber]] [17:04:21] Any idea where to find that? [17:04:53] Love the stack trace function btw :-) [17:05:02] mw.lua is part of the scribunto extension, .../Scribunto/engines/LuaCommon/lualib/mw.lua [17:05:26] but i think this will not help you, it's to deep in the trace. [17:05:26] Thiemo_WMDE: that is https://ru.wikipedia.org/wiki/%D0%9C%D0%BE%D0%B4%D1%83%D0%BB%D1%8C:RomanNumber [17:05:45] err that was for multichill [17:06:00] yea, assert((n_number >= 1) and (n_number <= 3999)), thats it. [17:06:27] Yeah, that fails because it's an unformated string [17:06:54] +00000000000-01-01T00:00:00Z is the input [17:08:05] thats a valid time value. [17:08:22] the template and lua code should not assume it gets just a number. [17:08:31] it should check this before doing something with it. [17:08:58] btw, this guy does not have a known birth date/year. [17:09:02] it seems. [17:09:18] Thiemo_WMDE: Yes, look at the precision [17:09:44] aude: https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension/84/console [17:09:53] He died somewhere around 1, somewhere precision of a century Thiemo_WMDE [17:10:02] I think the "Cannot find site build84 in sites table" is something we had already some time ago [17:10:31] ah, ok, see what you did.which is 1. century BCE? [17:10:32] and the other fatal suggests that we might want to update the PropertySuggester [17:11:02] so basically make it compatible with dm 2.0 [17:11:23] Thiemo_WMDE: https://www.wikidata.org/w/index.php?title=Q5959&diff=164392008&oldid=164388782 <- no, someone messed it up [17:11:24] multichill: fixed. [17:11:40] thats me. [17:12:00] Now you're saying that person was born after he died [17:12:08] no, why? [17:12:11] 1. century. [17:12:16] 00000000100-01-01T00:00:00Z [17:12:38] precision century. doesnt matter what the numbers say. [17:13:05] Tobi_WMDE_SW: ok [17:13:21] type "1. century" and save. the formatter will show "1. century". [17:13:27] sites thing is just a notice and can be ignored, thogh would be nice to eliminate it [17:13:46] Thiemo_WMDE: Hmmmm [17:13:48] aude: makes the build fail though [17:13:51] dob should be < dod [17:13:55] 3MediaWiki extensions / 3WikidataRepo: Make EntitySuggester compatible with DataModel 2.0 - 10https://bugzilla.wikimedia.org/72139 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs From https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension/84/console 16:30:34 PHP Fata... [17:14:39] article now says: Дата рождения: I век Дата смерти: 53[1]. is this wrong? [17:15:24] 3MediaWiki extensions / 3WikidataRepo: Make EntitySuggester compatible with DataModel 2.0 - 10https://bugzilla.wikimedia.org/72139 (10tobias.gritschacher) p:5Unprio>3High [17:15:24] 3MediaWiki extensions / 3WikidataRepo: [HHVM] Get rid of class aliases - 10https://bugzilla.wikimedia.org/71295 (10tobias.gritschacher) [17:15:31] have to go, sorry. [17:15:32] Thiemo_WMDE: Changed it to https://www.wikidata.org/w/index.php?title=Q5959&diff=164393816&oldid=164392008 so it's at least small [17:15:35] *er [17:15:40] I don't understand Russian at all [17:15:46] Thanks for your help [17:15:53] Office hour in 45 minutes [17:15:55] multichill: we are aware of a bug with the internal numbers when using century. please ignore the wrong number for now. [17:16:21] Great, it even uses my reference :-) [17:19:54] (03PS4) 10Daniel Kinzler: Rewrite lable/description conflict detection. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) [17:20:52] (03PS5) 10JanZerebecki: Rewrite label/description conflict detection. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:34:14] (03CR) 10Aude: Rewrite label/description conflict detection. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:35:46] (03CR) 10Daniel Kinzler: Rewrite label/description conflict detection. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:39:35] (03CR) 10Aude: Rewrite label/description conflict detection. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:45:27] (03CR) 10Daniel Kinzler: Rewrite label/description conflict detection. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:49:38] (03CR) 10Hoo man: "I like how TermSqlIndex::getLabelConflicts got split up" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [17:51:30] for me, the badges doesn't work in clients: e.g. this https://en.wikipedia.org/w/index.php?title=List_of_number-one_digital_songs_of_2010_%28U.S.%29&diff=prev&oldid=629685911 [17:51:56] Amir1: What do you mean? That they don't show up? [17:52:16] yes, they pt interwiki doesn't have the badge [17:52:22] *the [17:52:27] Amir1: It does, but the CSS for that is not yet deployed [17:52:36] it is ready for deployment though [17:52:44] * hoo only just came home, so no real clue what the state is [17:52:45] (03CR) 10Daniel Kinzler: [C: 032] "Looks good. Seems to work in light manual testing." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166869 (owner: 10Hoo man) [17:52:45] aude: ^ [17:52:53] I asked yesterday and I was told it's done [17:53:06] ok [17:53:13] The config is done and the icons are there on master [17:53:21] but the icon CSS is not yet deployed [17:53:37] do you have a time for deployment? [17:53:53] hoo: which patch? [17:53:56] (03CR) 10Daniel Kinzler: [C: 032] Add TimeFormatterParserRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166748 (owner: 10Thiemo Mättig (WMDE)) [17:54:15] aude: The two CSS ones that enable the icons for featured lists [17:54:19] both were merged today [17:54:22] (to master) [17:54:37] link? [17:54:53] https://github.com/wmde/WikimediaBadges/pull/14 [17:54:56] for client [17:55:13] we deployed that already [17:55:13] https://github.com/wmde/Wikidata.org/pull/15 and for WD.org [17:55:18] woot [17:55:18] in swat [17:55:24] does it not work? [17:55:33] i see stars for featured lists on wikipedia [17:55:42] a purge might be required [17:56:04] https://en.wikipedia.org/wiki/List_of_International_Space_Station_expeditions (see dewiki link) [17:56:11] ah, works after purge [17:56:12] :) [17:56:32] I should try to get email notifications on Wikidata deploy set up :P [17:57:20] aude: did you also branch today? [17:57:34] yes and no [17:57:43] make a wmf3 branch with badges added [17:57:55] we'll make branch next week with all the new stuff [17:58:07] Ok... what about backports? [17:58:10] made* (so jenkins runs with newer mediawiki) [17:58:17] which? [17:58:37] The IE11 fix and maybe the change to newer ApiBase/ ApiFormatBase behavior [17:58:49] hmmm, sure [17:58:59] not done yet, I guess? [17:59:00] wmf4 branch [17:59:03] not yet [18:00:12] cherry pick those to the wikibase branch [18:00:58] yay it works for me too [18:01:02] I'm re-running it [18:01:13] Amir1: :) [18:01:29] aude: Ok... so a new WB branch on the base of the last one and then do the few backports? That's fine with me [18:01:59] sorry these days I don't have very much time to work on wikidata because of university [18:02:30] i would just put the wikibase changes in wmf1 (yes confusing) [18:02:52] mh, yeah [18:03:01] then make wmf4 branch of wikidata with the hash of the curretn wmf3 branch [18:03:13] then update wikidata in there [18:03:15] Would be awesome if github could stop changing the layout of it's zip file dumps [18:03:16] :( [18:03:21] suppose i can do this [18:03:44] i always base the new branches on the old deployment branch [18:03:58] then git review with new stuff and we can see the diff + jenkins does stuff [18:04:21] we can make wmf4 wikibase branch based on wmf1 if we want [18:04:39] (03Merged) 10jenkins-bot: Also show redirect header html in user language [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166869 (owner: 10Hoo man) [18:04:47] (03Merged) 10jenkins-bot: Add TimeFormatterParserRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166748 (owner: 10Thiemo Mättig (WMDE)) [18:04:48] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikidata/refs%2Fheads%2Fwmf%2F1.25wmf4 [18:05:13] :) [18:05:20] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase/refs%2Fheads%2Fwmf%2F1.25wmf4 [18:05:30] nothing new except cherry picks [18:07:02] wikimedia/mediawiki-extensions-Wikibase/master/607a114 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38183724 [18:07:05] (03PS1) 10Hoo man: Adopt to changes in github's codedownload zip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167033 [18:07:10] aude: ^ fix travis [18:07:22] ok [18:08:47] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf4/a427cbc : Marius Hoch The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38183794 [18:10:13] (03CR) 10Aude: [C: 032] Adopt to changes in github's codedownload zip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167033 (owner: 10Hoo man) [18:12:14] (03CR) 10Aude: Rewrite label/description conflict detection. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166618 (https://bugzilla.wikimedia.org/71915) (owner: 10Daniel Kinzler) [18:16:58] [13Geo] 15JanZerebecki pushed 3 new commits to 06cleanup: 02http://git.io/_Y4ilw [18:16:58] 13Geo/06cleanup 14bb1a18a 15Jan Zerebecki: Resolve bool vs int type conflict. [18:16:58] 13Geo/06cleanup 14f459d7f 15Jan Zerebecki: Remove overriding method that changes nothing. [18:16:58] 13Geo/06cleanup 14d8d06dc 15Jan Zerebecki: Remove unused argument from private function. [18:17:36] Hi all. I'm trying to see the list of properties here (http://www.wikidata.org/wiki/Wikidata:List_of_properties/all) but some (for example date of death) are missing. Does anyone know why? Am I looking at a wrong page? [18:21:08] (03Merged) 10jenkins-bot: Adopt to changes in github's codedownload zip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167033 (owner: 10Hoo man) [18:25:28] bmansuro_: That page apparently is incomplete because the script that is supposed to create it keeps timing out [18:25:49] https://www.wikidata.org/wiki/Wikidata:List_of_properties/Person will give you what you need [18:25:58] See https://www.wikidata.org/wiki/Special:AllPages/Property: for a truly complete list [18:26:00] hoo: thank you [19:50:24] [13Geo] 15JanZerebecki opened pull request #25: Some cleanups (06master...06cleanup) 02http://git.io/-xEVrA [20:00:44] [13Geo] 15thiemowmde comment on pull request #25 14d8d06dc: Lolwhat? 02http://git.io/chAZ0g [20:02:16] [13Geo] 15JanZerebecki 04deleted 06cleanupComments at 143e2416b: 02http://git.io/FPzCRA [20:04:01] [13Geo] 15thiemowmde comment on pull request #25 14d8d06dc: Forgot the spaces. Also interesting to see this style. Doing the comparison this way around is not necessary if you have a good static code analysis. ;-) 02http://git.io/4vQJFw [20:04:55] [13Geo] 15thiemowmde comment on pull request #25 14d8d06dc: Whats a target type? 02http://git.io/Y75QXA [20:08:54] [13Geo] 15thiemowmde comment on pull request #25 14d8d06dc: Personally I prefer a bool cast here just because it's more intuitive. Most people assume preg_match returns a bool. A `1 === true` comparison will confuse these people. 02http://git.io/YAUVJA [20:13:06] [13Geo] 15JanZerebecki comment on pull request #25 14d8d06dc: That confusion hopefully makes those think a bit longer, thus hopefully making less errors. Seems like a feature to me. 02http://git.io/f0OmQw [20:16:36] [13Geo] 15JanZerebecki 04force-pushed 06cleanup from 14d8d06dc to 14947a523: 02http://git.io/B6N7Ug [20:16:36] 13Geo/06cleanup 14a910917 15Jan Zerebecki: Resolve bool vs int type conflict. [20:16:36] 13Geo/06cleanup 14a5dcdc9 15Jan Zerebecki: Remove overriding method that changes nothing. [20:16:36] 13Geo/06cleanup 14947a523 15Jan Zerebecki: Remove unused argument from private function. [20:18:11] [13Geo] 15JanZerebecki comment on pull request #25 14947a523: output format 02http://git.io/TQB6kw [21:10:53] wikimedia/mediawiki-extensions-WikibaseQuery/master/9e954c8 : Translation updater bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/38201288 [21:42:49] aude: Around? [21:45:53] [13WikibaseQuery] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/Dvp3Kw [21:45:53] 13WikibaseQuery/06master 141742c00 15Marius Hoch: Fix .travis.sh after MediaWiki github mirror repo rename [21:47:13] https://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds :S [21:47:43] JeroenDeDauw: ^ do you update that with changes from github [21:48:07] or shall we completely remove travis stuff from it, if it's only used to collect i18n json [21:48:15] wmde/WikibaseQuery/master/1742c00 : Marius Hoch The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/38204913 [22:06:42] (03PS1) 10Hoo man: Get rid of ORMTable::getFieldPrefix [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167111 [22:08:50] aude: ping [22:15:41] (03CR) 10jenkins-bot: [V: 04-1] Get rid of ORMTable::getFieldPrefix [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167111 (owner: 10Hoo man) [22:16:26] oh screw that [22:16:35] no one else around, really? :/ [22:19:10] (03PS1) 10Hoo man: Fix and enhance RecentChangesFilterOptionsTest [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167112 [22:19:21] (03PS1) 10Hoo man: Only redraw in descriptionview/labelview if necessary [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167113 (https://bugzilla.wikimedia.org/71665) [22:19:50] https://gerrit.wikimedia.org/r/166524 doesn't merge cleanly :S [22:20:20] ? [22:20:33] aude: ORM change is flooding exception logs [22:20:39] so I'd like to backport that [22:20:41] omg [22:20:44] ok [22:20:58] And would also like to fix tests on the branch and have the IE11 fix [22:21:07] sure [22:21:34] ok, let me manually rebase that Api change then [22:23:36] (03PS1) 10Hoo man: Adopt to changes in ApiBase/ ApiFormatBase [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167115 [22:23:53] aude: ^ please force merge if fine with you [22:24:00] needs other test cherry-pick to pass jenkins [22:24:36] all that I want to have is in gerrit now :) [22:24:56] (03CR) 10Hoo man: [C: 032 V: 032] "Test only change, per master" [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167112 (owner: 10Hoo man) [22:25:09] (03PS2) 10Hoo man: Get rid of ORMTable::getFieldPrefix [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167111 [22:25:19] now it should actually pass jenkins :) [22:26:45] (03CR) 10jenkins-bot: [V: 04-1] Only redraw in descriptionview/labelview if necessary [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167113 (https://bugzilla.wikimedia.org/71665) (owner: 10Hoo man) [22:26:59] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf4/64176d7 : Marius Hoch The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38208237 [22:27:44] (03CR) 10Aude: [C: 032] Adopt to changes in ApiBase/ ApiFormatBase [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167115 (owner: 10Hoo man) [22:28:37] 3MediaWiki extensions / 3WikidataRepo: unable to edit empty label and description in IE 11 - 10https://bugzilla.wikimedia.org/71665 (10Marius Hoch) 5PATC>3RESO/FIX [22:28:50] edit warring gerrit bot... :P [22:31:44] (03CR) 10jenkins-bot: [V: 04-1] Adopt to changes in ApiBase/ ApiFormatBase [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167115 (owner: 10Hoo man) [22:31:51] uh [22:32:17] oh wait, I rebased the wrong change m( [22:32:20] (03PS2) 10Hoo man: Adopt to changes in ApiBase/ ApiFormatBase [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167115 [22:41:19] (03CR) 10jenkins-bot: [V: 04-1] Get rid of ORMTable::getFieldPrefix [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167111 (owner: 10Hoo man) [22:43:24] (03CR) 10jenkins-bot: [V: 04-1] Adopt to changes in ApiBase/ ApiFormatBase [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167115 (owner: 10Hoo man) [22:45:06] grrr [22:45:11] now it fails on the ORM error [22:45:28] (03CR) 10Hoo man: [V: 032] Adopt to changes in ApiBase/ ApiFormatBase [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167115 (owner: 10Hoo man) [22:46:06] (03CR) 10Hoo man: [C: 032 V: 032] "Trivial, per master" [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167111 (owner: 10Hoo man) [22:46:29] (03PS2) 10Hoo man: Only redraw in descriptionview/labelview if necessary [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167113 (https://bugzilla.wikimedia.org/71665) [22:46:43] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167113 (https://bugzilla.wikimedia.org/71665) (owner: 10Hoo man) [22:46:49] This is going to really pass jenkins now [22:47:07] hoo: waiting for the V:-1 :p [22:47:28] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf4/84ff857 : Marius Hoch The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38209876 [22:47:37] aaaah [22:48:16] right well night once I remove some bans [22:49:27] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf4/8c42623 : Hoo man The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/38209915 [22:49:39] You don't say :D [22:55:54] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs a deep copy "of Entity is made whenever calling Revision::getContent(). the deep copy is done with "unserialize(... [22:56:07] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity is done when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158 (10Aude) [22:56:22] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity is made when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158 (10Aude) [22:57:37] 3MediaWiki extensions / 3WikidataClient: Calling mw.wikibase.entity.formatPr opertyValues on Property fails with wikibase-error-invalid-enti ty-id - 10https://bugzilla.wikimedia.org/72124#c1 (10Marius Hoch) The actual problem is something like: mw.log(mw.wikibase.getEntityObject('P447'):formatPropertyValues... [22:58:04] * hoo waits for jenkins [23:01:37] 3MediaWiki extensions / 3WikidataRepo: deep copy of Entity is made when calling Revision::getContent() - 10https://bugzilla.wikimedia.org/72158#c1 (10Aude) with corrected indentation: 5x - WikiPage::getContent * 1x - WikiPage::doEditContent * 1x - WikiPage::prepareContentForEdit * 1x - RepoHooks::onNewRevis... [23:03:23] (03CR) 10jenkins-bot: [V: 04-1] Only redraw in descriptionview/labelview if necessary [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167113 (https://bugzilla.wikimedia.org/71665) (owner: 10Hoo man) [23:04:00] 22:56:10 Failed to fake very old serialization format based on oldish serialization format. [23:04:05] that needs another backport [23:04:08] * hoo cries [23:04:21] (03PS2) 10Aude: Remove duplicate getContentForRequest call in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167116 (https://bugzilla.wikimedia.org/72158) [23:04:40] :( [23:14:08] (03PS1) 10Hoo man: Backport EntityHandlerTest changes from 7645915b31 [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167121 [23:14:36] aude: ^ [23:14:45] Wouldn't have done that for a none-test [23:16:17] (03PS2) 10Hoo man: Backport EntityHandlerTest changes from 7645915b31 [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167121 [23:16:23] forgot to rebase [23:16:51] aude: Can you +2 if ok with you? :) [23:20:40] sure [23:20:47] (03PS1) 10Aude: Don't try to fetch non-existing extension data from ParserOutput [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167123 [23:21:16] why is there var_dump($veryVeryOldBlob,$veryOldBlob); ? [23:21:27] aude: Probably debug output [23:21:35] I just copied the diff 1:1 from Adrian's patch [23:22:05] can remove if you want... but it's only a test, so would be enough to do that on master [23:22:24] true [23:22:45] (03CR) 10Aude: [C: 032] Backport EntityHandlerTest changes from 7645915b31 [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167121 (owner: 10Hoo man) [23:23:59] (03PS1) 10Aude: Remove var_dump debugging from EntityHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167124 [23:25:13] (03CR) 10Hoo man: [C: 032] Remove var_dump debugging from EntityHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167124 (owner: 10Aude) [23:36:26] Yay, passed jenkins :) [23:38:12] (03Merged) 10jenkins-bot: Backport EntityHandlerTest changes from 7645915b31 [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167121 (owner: 10Hoo man) [23:38:36] (03PS3) 10Hoo man: Only redraw in descriptionview/labelview if necessary [extensions/Wikibase] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167113 (https://bugzilla.wikimedia.org/71665) [23:39:21] (03Merged) 10jenkins-bot: Remove var_dump debugging from EntityHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167124 (owner: 10Aude) [23:43:34] (03PS1) 10Aude: Don't getContent in OutputPageBodyAttributes handler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167127 (https://bugzilla.wikimedia.org/72158) [23:46:10] [13Geo] 15JeroenDeDauw comment on pull request #25 14947a523: Something like testGivenInvalidFormattingOption_formatThrowsException 02http://git.io/hazOxg [23:47:17] [13Geo] 15JeroenDeDauw comment on pull request #25 14947a523: ![wtfisthisshit](https://cloud.githubusercontent.com/assets/146040/4672391/b8b8dc10-558e-11e4-8a5a-cab25206e142.jpg)... 02http://git.io/Daz1GA [23:47:54] [13Geo] 15JeroenDeDauw comment on pull request #25 14947a523: Somewhat silly to use the FQNs here to begin with... 02http://git.io/xjviYA [23:48:27] (03PS1) 10Hoo man: Some minor style changes in the scribunto code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167128 [23:52:12] * hoo will make the build etc. in a bit [23:52:22] (just to make sure we only do it once this time :P) [23:54:26] (03CR) 10Hoo man: [C: 031] "Using the JS config vars here is a somewhat ugly hack... but seems ok to me given the potential advantages." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167127 (https://bugzilla.wikimedia.org/72158) (owner: 10Aude) [23:54:56] we could put it in extenstion data, like i originally did [23:55:16] but that was suggested to use the config vars since they get passed automatically [23:56:52] Yeah, seems good enough to me [23:57:15] but want to give others a chance to comment [23:57:39] sure [23:57:50] more patches coming in next day(s) [23:58:46] Wikidata]$ git log 9f74662..8183058 [23:58:47] wtf [23:58:50] aude: ^ [23:58:52] why is that [23:58:58] (pull before doing that) [23:59:35] 9f74662..8183058 REL1_22 -> origin/REL1_22