[06:38:00] 3MediaWiki extensions / 3WikidataRepo: Uncaught exception if a badge id does not exist - 10https://bugzilla.wikimedia.org/69536#c3 (10Bene*) *** Bug 71232 has been marked as a duplicate of this bug. *** [06:38:01] 3MediaWiki extensions / 3WikidataRepo: Special:SetSiteLink broken on beta - 10https://bugzilla.wikimedia.org/71232#c1 (10Bene*) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69536 *** [06:39:00] 3MediaWiki extensions / 3WikidataRepo: Special:SetSiteLink broken on beta - 10https://bugzilla.wikimedia.org/71232#c2 (10Bene*) Note that this won't affect wikidata unless we add a wrong configuration there. However, the config on the beta cluster should be fixed. [06:50:48] (03CR) 10Bene: "Re Thiemo" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) (owner: 10Bene) [13:21:58] (03PS2) 10Bene: Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) [13:25:43] (03CR) 10jenkins-bot: [V: 04-1] Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) (owner: 10Bene) [13:26:22] (03PS3) 10Bene: Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) [13:29:59] (03CR) 10jenkins-bot: [V: 04-1] Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) (owner: 10Bene) [13:34:38] [13WikibaseDataModel] 15Benestar 04force-pushed 06addreference from 14beac925 to 141222a7a: 02http://git.io/fBpqew [13:34:38] 13WikibaseDataModel/06addreference 14871196f 15Bene: Create convenience method [13:34:38] 13WikibaseDataModel/06addreference 1451d75b3 15Bene: Update release notes [13:34:38] 13WikibaseDataModel/06addreference 14e748f19 15Bene: Add addNewReference to ReferenceList [13:35:28] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06addreference: 02http://git.io/tSdvvw [13:35:28] 13WikibaseDataModel/06addreference 14f6d6609 15Bene: Clean up [13:38:22] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06addreference: 02http://git.io/N_POOA [13:38:22] 13WikibaseDataModel/06addreference 144ac4d96 15Bene: Fix StatementTest [13:38:51] aude: is it just me or is jenkins broken again? [13:46:47] wmde/WikibaseDataModel/addreference/1222a7a : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/37743908 [13:48:25] wmde/WikibaseDataModel/addreference/f6d6609 : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/37743939 [13:51:08] [13WikibaseDataModel] 15Benestar created 06removereferencesinterface (+1 new commit): 02http://git.io/hlvjJQ [13:51:08] 13WikibaseDataModel/06removereferencesinterface 14467f12d 15Bene: Remove References interface... [13:51:23] [13WikibaseDataModel] 15Benestar opened pull request #232: Remove References interface (06master...06removereferencesinterface) 02http://git.io/EnUDaw [13:51:42] JeroenDeDauw: are you around??? [14:03:00] wmde/WikibaseDataModel/removereferencesinterface/467f12d : Bene The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37744719 [14:10:29] [13WikibaseDataModel] 15Benestar created 06newstatementconstructor (+1 new commit): 02http://git.io/HlxBZg [14:10:29] 13WikibaseDataModel/06newstatementconstructor 14b468a13 15Bene: Use new version of Statement constructor [14:10:59] [13WikibaseDataModel] 15Benestar opened pull request #233: Use new version of Statement constructor (06master...06newstatementconstructor) 02http://git.io/LSJWRA [14:12:12] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06removereferencesinterface: 02http://git.io/sa80wA [14:12:12] 13WikibaseDataModel/06removereferencesinterface 145e6c7ef 15Bene: Fix StatementTest (silly netbeans) [14:16:56] [13WikibaseDataModel] 15Benestar created 06breakstatementconstructor (+1 new commit): 02http://git.io/vMu4kQ [14:16:56] 13WikibaseDataModel/06breakstatementconstructor 14f65409e 15Bene: Remove old Statement constructor [14:18:47] [13WikibaseDataModel] 15Benestar opened pull request #234: Remove old Statement constructor (06master...06breakstatementconstructor) 02http://git.io/ZOiOGw [14:20:11] benestar: maybe [14:20:51] \o/ [14:21:17] JeroenDeDauw: so you can merge my pull requests? :D [14:21:24] hi hoo :-) [14:21:56] hi benestar :) [14:22:05] * hoo not around for long [14:22:06] wmde/WikibaseDataModel/newstatementconstructor/b468a13 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37745708 [14:22:25] hoo: no problem, JeroenDeDauw is already here for merging my evil stuff [14:23:01] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/TF9uaQ [14:23:01] 13WikibaseDataModel/06master 140a07b8d 15Jeroen De Dauw: Merge pull request #233 from wmde/newstatementconstructor... [14:25:21] wmde/WikibaseDataModel/removereferencesinterface/5e6c7ef : Bene The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37745810 [14:30:38] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #232: Remove References interface (06master...06removereferencesinterface) 02http://git.io/EnUDaw [14:31:06] benestar: that depends, what bribes do you offer? [14:32:16] JeroenDeDauw: implementing the changes in Wikibase.git ;-) [14:32:33] wmde/WikibaseDataModel/breakstatementconstructor/f65409e : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37746051 [14:33:30] benestar: if you add in annoying Lydia_WMDE once, then we have a deal [14:34:52] JeroenDeDauw: deal :D [14:35:21] * Lydia_WMDE blinks [14:35:23] :P [14:36:24] Lydia_WMDE: Is redirection also supposed to work for properties? Or just for Q items? [14:36:45] multichill: only items work as far as i know [14:37:09] conceptually it is a bit weird for properties [14:37:23] they might change datatype for example [14:37:39] I know. Filing some bugs to add things to Pywikibot [14:37:54] cool [14:38:07] I don't really feel like doing https://www.wikidata.org/wiki/User:Multichill/To_redirect by hand ;-) [14:38:15] :D [14:38:21] understandable [14:38:29] About 4600 items that were merged, but not redirected [14:38:32] hoo|away had something for this possibly? [14:38:41] ah [14:38:41] ok [14:38:47] then that is different from what hoo had [14:39:03] addshore then maybe [14:39:14] he wanted to do something like that at least [14:39:18] no idea if he already has code [14:39:35] It's pretty straightforward to implement in Pywikibot [14:39:39] ok [14:39:54] Someone just needs to feel like doing it ;-) [14:39:57] :D [14:42:01] It's always a two step rocket. We have the low level stuff in the DataSite object and the functions wrapping around that in WikibasePage / ItemPage [14:44:36] Lydia_WMDE: Good week? [14:44:46] multichill: yes [14:44:49] but exhausting [14:45:04] but i think we got a lot of important discussions done [14:45:07] so that's good [14:45:13] It sure is! [14:50:17] (03PS1) 10Bene: Use the new Statement constructor everywhere [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166285 [14:53:34] [13WikibaseDataModel] 15Benestar 04force-pushed 06breakstatementconstructor from 14f65409e to 14f4cc317: 02http://git.io/C983UQ [14:53:34] 13WikibaseDataModel/06breakstatementconstructor 14f4cc317 15Bene: Remove old Statement constructor [14:53:47] (03CR) 10jenkins-bot: [V: 04-1] Use the new Statement constructor everywhere [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166285 (owner: 10Bene) [14:54:50] (03PS2) 10Bene: Use the new Statement constructor everywhere [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166285 [15:05:51] wmde/WikibaseDataModel/breakstatementconstructor/f4cc317 : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/37748142 [15:07:06] [13WikibaseDataModel] 15Benestar pushed 2 new commits to 06breakstatementconstructor: 02http://git.io/D96eEg [15:07:06] 13WikibaseDataModel/06breakstatementconstructor 1405ca852 15Bene: Add serialization compat test [15:07:06] 13WikibaseDataModel/06breakstatementconstructor 140afd2e5 15Bene: Fix Statement constructor [15:07:47] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06breakstatementconstructor: 02http://git.io/5r66Yw [15:07:47] 13WikibaseDataModel/06breakstatementconstructor 14c299343 15Bene: add serialization compat test (again) [15:18:35] [13WikibaseDataModel] 15Benestar 04force-pushed 06ranktostatement from 141cd229b to 149cb86e8: 02http://git.io/U01DAQ [15:18:35] 13WikibaseDataModel/06ranktostatement 14d420bd6 15Bene: Move ranks to statement [15:18:35] 13WikibaseDataModel/06ranktostatement 144940fa3 15Bene: Don't redeclare values and deprecate whole enum [15:18:35] 13WikibaseDataModel/06ranktostatement 149cb86e8 15Bene: Fix @since tags [15:18:43] wmde/WikibaseDataModel/breakstatementconstructor/0afd2e5 : Bene The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37748778 [15:19:51] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06ranktostatement: 02http://git.io/7_NiPQ [15:19:51] 13WikibaseDataModel/06ranktostatement 146f78794 15Bene: Add default value for [15:21:11] wmde/WikibaseDataModel/breakstatementconstructor/c299343 : Bene The build is still failing. http://travis-ci.org/wmde/WikibaseDataModel/builds/37748826 [15:21:22] JeroenDeDauw: arrrrgh... -.- [15:21:23] https://travis-ci.org/wmde/WikibaseDataModel/jobs/37748827 [15:31:52] wmde/WikibaseDataModel/ranktostatement/9cb86e8 : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/37749394 [15:32:43] (03PS1) 10Bene: Use ReferenceList instead of References [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166286 [15:38:48] benestar: https://insight.sensiolabs.com/projects/3a077cfe-7a8e-4534-af6d-d1581903c336 [15:39:02] A lot of the issues this thing is finding are wrong though [15:41:01] JeroenDeDauw: Interfaces names should end with "Interface" o.O [15:41:10] no, scrutinizer is way better [15:50:54] why has the move gadget been disabled? it was a useful add-on [15:55:52] benestarafk: lolwat, it says that?! [15:56:46] benestarafk: Scrutinizer is indeed way better [15:56:50] Thiemo_WMDE: it's a Thiemo_WMDE! [15:56:58] partly. [15:57:40] somebody joining me for cinema this evening? [16:00:00] heck, "Lucy" is not playing any more. [16:03:30] uh, "Interstellar" is coming. excited. [16:06:17] Thiemo_WMDE: when and what movie? [16:06:43] Also, what cinema? The one that costs 3 times the yearly wage of your average third world person? [16:06:51] not much to choose from. :( want to see the german hacker film, but its german, obviously. [16:07:16] i think its better to do it tomorrow, not today. [16:08:14] uh, potsdamer platz still playing "Lucy". nice. [16:09:46] cant find a cinema playing it in english. dang. [16:11:40] Thiemo_WMDE: i might be up for cinema [16:11:44] already saw lucy though [16:12:03] Lydia_WMDE: uh, hi. you mean today or tomorrow? [16:12:10] either is fine [16:13:47] ... uh, the radio literally quotes wikipedia. ;) [16:14:10] Lydia_WMDE: lets ask the office tomorrow if somebody joins the german hacker movie, ok? [16:14:27] this is the Wikidata-channel right? [16:14:29] why has the move gadget been disabled? it was a useful add-on [16:14:42] FakirNL: yes,sorry for being offtopic. [16:15:01] FakirNL: it probably still needs to be adapted to the latest interface changes [16:15:21] Can I turn back to the layout of last month, because I don't really like the new ones [16:15:47] no that's not possible. we'll however improve the current one [16:15:56] it is high prio [16:16:01] FakirNL: sorry. we know its not exactly pretty at the moment. it will change more and be pretty again. [16:16:03] when you want to remove one item from a long list, first go up to edit then down to remove then up again to save [16:16:15] yes [16:16:30] it's not quite an improvement if you ask me [16:16:46] FakirNL: it is for small lists. not for long ones. thats right. [16:17:05] FakirNL: we are aware. it is an intermediate step that is not nice [16:17:17] will change [16:18:05] well, thanks for being helpful [16:18:16] sure [16:18:25] and good luck (Viel Erfolg) with all the necessary changes [16:18:31] ;-) [16:18:34] thx [16:21:11] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Ok, I'm fine with the change but there is a little mistake now. Also why do the tests fail???" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) (owner: 10Bene) [16:32:40] Hi [16:32:47] There's a lot of people in IRC o.o [16:35:57] Loads of people in chat... No activity [16:35:59] Lol [16:38:45] GeorgeEdwardC_: are you a bot? [16:39:05] Course :P [16:39:07] Jk [16:39:27] Why? [16:49:55] Sorry someone turned offf my Internet by accident [16:50:15] *off [16:52:14] no problem [16:53:20] Why isn't there a Wikidata for Wiktionary? [16:53:23] Just wondering [16:54:17] As there's fields for WikiVoyage, WikiQuote, WikiNews and WikiSource [16:54:22] hasn't been turned on yet [16:54:22] https://www.wikidata.org/wiki/Wikidata:Development_plan [16:56:40] Oh ok, fair enough [17:21:32] (03PS4) 10Bene: Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) [17:54:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) (owner: 10Bene) [18:04:30] (03Merged) 10jenkins-bot: Catch exceptions on SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163351 (https://bugzilla.wikimedia.org/69536) (owner: 10Bene) [18:16:30] 3MediaWiki extensions / 3WikidataRepo: write script that touches every item and thereby updates database tables - 10https://bugzilla.wikimedia.org/64600 (10Lydia Pintscher) 5PATC>3NEW [18:19:30] 3MediaWiki extensions / 3WikidataRepo: run phpunit (on jenkins) on EditFilterMergedContent handling code in EditEntity - 10https://bugzilla.wikimedia.org/65727 (10Lydia Pintscher) 5PATC>3NEW [18:20:00] 3MediaWiki extensions / 3WikidataRepo: Uncaught exception if a badge id does not exist - 10https://bugzilla.wikimedia.org/69536 (10Lydia Pintscher) 5PATC>3RESO/FIX [18:20:33] aude: hoo|away: can https://bugzilla.wikimedia.org/show_bug.cgi?id=71479 be closed? [18:21:30] 3MediaWiki extensions / 3WikidataRepo: Browser smoke test for property - 10https://bugzilla.wikimedia.org/71516 (10Lydia Pintscher) 5PATC>3RESO/FIX [18:22:30] 3MediaWiki extensions / 3WikidataRepo: Inconsistent behavior of enter key in site-link UI - 10https://bugzilla.wikimedia.org/39318 (10Lydia Pintscher) 5PATC>3RESO/FIX [18:23:01] 3MediaWiki extensions / 3WikidataRepo: API action=wbsearchentities should have an option to return sitelinks too - 10https://bugzilla.wikimedia.org/56748 (10Lydia Pintscher) 5PATC>3NEW [18:24:13] aude: can https://bugzilla.wikimedia.org/show_bug.cgi?id=71508 be closed? [18:25:00] 3MediaWiki extensions / 3WikidataRepo: Wikidata's badge icons are all blue (regression) - 10https://bugzilla.wikimedia.org/71684 (10Lydia Pintscher) 5PATC>3RESO/FIX [18:27:30] (03CR) 10Jeroen De Dauw: [C: 032] Use the new Statement constructor everywhere [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166285 (owner: 10Bene) [18:28:15] (03CR) 10Jeroen De Dauw: [C: 032] Use ReferenceList instead of References [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166286 (owner: 10Bene) [18:37:38] (03CR) 10Jeroen De Dauw: "Daniel: as I told you, I think it'd have been better if you had developed this code top down, rather than bottom up. Unfortunately this is" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [18:47:35] (03Merged) 10jenkins-bot: Use ReferenceList instead of References [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166286 (owner: 10Bene) [18:52:02] 3MediaWiki extensions / 3WikidataClient: File permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71928 (10Andre Klapper) p:5Unprio>3Low s:5minor>3enhanc [19:56:13] (03CR) 10Jeroen De Dauw: [C: 031] Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [20:03:58] Lydia_WMDE: most bugs for badges are tackled :D [20:04:20] JeroenDeDauw: did you check the serialization test? [20:04:26] benestar: i saw! awesome :) [20:05:17] Lydia_WMDE: only tracking is still missing but I think this is not ready yet from your side [20:05:32] you = your devs ;) [20:05:54] yeah i think so [20:06:13] did daniel look at your question? [20:06:30] yeah but it wasn't really an answer [20:06:36] rather some thoughts [20:17:10] benestar: I have not yet [20:57:45] [13WikibaseDataModel] 15JeroenDeDauw created 06remdup (+1 new commit): 02http://git.io/hw5wpg [20:57:45] 13WikibaseDataModel/06remdup 147199392 15jeroendedauw: Remove not needed exception duplication [20:58:59] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #235: Remove not needed exception duplication (06master...06remdup) 02http://git.io/VrBdyA [20:59:06] benestar: why have you not merged my latest PR yet? https://github.com/wmde/WikibaseDataModel/pull/235 [21:06:11] [13WikibaseDataModel] 15Benestar comment on pull request #235 147199392: Even more easy ;-)... 02http://git.io/KkVQzw [21:07:39] benestar: *easier [21:08:00] Vogone: I wanted to stress the *more* [21:08:12] still wrong [21:08:24] PHP fatal [21:09:05] wmde/WikibaseDataModel/remdup/7199392 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37772034 [21:09:29] why are the bots here incapable of idling? [21:09:46] What fatals? [21:11:08] [13WikibaseDataModel] 15Benestar 04force-pushed 06addreference from 144ac4d96 to 14542d25d: 02http://git.io/fBpqew [21:11:08] 13WikibaseDataModel/06addreference 146d94bea 15Bene: Create convenience method [21:11:08] 13WikibaseDataModel/06addreference 1405ac6f0 15Bene: Update release notes [21:11:08] 13WikibaseDataModel/06addreference 14b1c7a63 15Bene: Add addNewReference to ReferenceList [21:11:24] Vogone: because effort on everyone's behalf [21:11:53] JohnFLewis: these join/part messages are actually kinda annoying :p [21:12:25] -n and don't have them join :p [21:14:00] !ghmerge [21:14:05] !mergegithub [21:14:08] !githubmerge [21:14:11] !commands [21:14:13] I know: add, channellist, commands, configure, drop, grant, grantrole, help, info, instance, join, language, notify, optools-off, optools-on, optools-permanent-off, optools-permanent-on, part, reload, restart, revoke, revokerole, seen, seen-off, seen-on, seenrx, suppress-off, suppress-on, system-rm, traffic-off, traffic-on, translate, trustadd, trustdel, trusted, verbosity--, verbosity++, whoami [21:14:13] @commands [21:14:28] !benestarisannoying [21:14:30] !ghreview [21:14:33] heh :P [21:14:36] !evil JohnFLewis [21:14:36] JohnFLewis is eeeeeevil >:( [21:14:58] http://bots.wmflabs.org/dump/%23wikidata.htm [21:14:58] @info [21:15:11] benestar: ^ [21:15:21] thx [21:15:34] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/8Y89hw [21:15:34] 13WikibaseDataModel/06master 1438e99c8 15Jeroen De Dauw: Merge pull request #185 from wmde/ranktostatement... [21:15:46] !github-review WikibaseDataModel 187 | JeroenDeDauw [21:15:46] JeroenDeDauw: https://github.com/wmde/WikibaseDataModel/pull/187 [21:16:10] !m JohnFLewis benestar [21:16:10] benestar merge merge merge MERGEEEEEEEEEEEEE JohnFLewis [21:17:14] xD [21:17:22] made my day ;) [21:17:43] :o [21:17:51] :O [21:18:20] JohnFLewis: feelin' merged now? [21:18:23] benestar: you must have a bad life if your highlight is merging me :p [21:18:27] [13WikibaseDataModel] 15Benestar 04force-pushed 06addreference from 14542d25d to 14edfb9cd: 02http://git.io/fBpqew [21:18:27] 13WikibaseDataModel/06addreference 1424828b0 15Bene: Create convenience method [21:18:27] 13WikibaseDataModel/06addreference 14fdca462 15Bene: Update release notes [21:18:27] 13WikibaseDataModel/06addreference 1445b1e76 15Bene: Add addNewReference to ReferenceList [21:18:30] sry, day is almost over :P [21:20:13] hi [21:21:06] JohnFLewis: you impersonate me? [21:21:27] freaky [21:22:31] JohnDolly: please gimme shelter, I need to escape these redirect/delete discussions on Wikidata somehow ... [21:22:37] * JohnFLewis [21:22:53] kthxbai [21:25:17] JohnFLewis: so please close https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/Redirect_vs._deletion ;) [21:25:28] the outcome is quite clear [21:26:13] benestar: will do soon [21:26:47] JohnFLewis: just modify https://www.wikidata.org/wiki/Help:Redirects slightly [21:27:02] or I will do already [21:32:30] benestar: why close it so early? [21:32:50] Vogone: hmm, we should run it for 3 months instead? :P [21:32:53] there's stil no way to easily create redirects without gadgets [21:33:01] *still [21:33:46] Vogone: so you want a checkbox to create a redirect here? https://www.wikidata.org/wiki/Special:MergeItems [21:33:56] most people use gadgets for merging [21:34:18] benestar: either that or let the page automatically leave a redirect after merge [21:34:48] yeah, this would be best [21:34:58] but for such a software change we first need community consensus ;) [21:35:06] hä? [21:35:38] why? [21:35:41] it's trivial [21:35:51] hmm, if it is we don't :D [21:36:53] Software changes require consensus only if the developer was nice enough to put them behind a configuration setting, everyone knows that [21:38:18] benestar: of course you could also add a checkbox "Do not leave a redirect after merge" if you feel more comfortable with it, but I can hardly imagine a case where that would be needed ... and even if it was, one could still MW delete the page [21:40:43] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #235 147199392: This puts two entirely different conditions together. That makes it harder to step through the code with a debugger. Also, like this the error condition block is not named at all. And it's nicer to have it at the end. 02http://git.io/Chg3QQ [21:41:49] [13WikibaseDataModel] 15Benestar comment on pull request #235 147199392: > And it's nicer to have it at the end.... 02http://git.io/OAbaEQ [21:44:04] [13WikibaseDataModel] 15Benestar 04force-pushed 06breakstatementconstructor from 14c299343 to 14e40eb29: 02http://git.io/C983UQ [21:44:04] 13WikibaseDataModel/06breakstatementconstructor 14d500785 15Bene: Remove old Statement constructor [21:44:04] 13WikibaseDataModel/06breakstatementconstructor 1457aad68 15Bene: Add serialization compat test [21:44:04] 13WikibaseDataModel/06breakstatementconstructor 145935048 15Bene: Fix Statement constructor [21:51:24] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #235 147199392: > LOL... 02http://git.io/sgnBaw [21:52:26] JeroenDeDauw: will you report it to Lydia_WMDE? :P [21:53:01] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06addreference at 14edfb9cd: 02http://git.io/PQF3sw [21:55:32] wmde/WikibaseDataModel/breakstatementconstructor/e40eb29 : Bene The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37775120 [22:00:08] benestar: he won't. Lydia won't care about serious cr work :p [22:14:12] (03CR) 10Hoo man: "I'm surprised that people still use this :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165905 (owner: 10Hoo man) [22:17:40] [13WikibaseDataModel] 15JeroenDeDauw created 06ssl (+1 new commit): 02http://git.io/pk4bpg [22:17:40] 13WikibaseDataModel/06ssl 14a3082a1 15jeroendedauw: Also remove the SimpleSiteLink class alias [22:17:50] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #236: Also remove the SimpleSiteLink class alias (06master...06ssl) 02http://git.io/KdzkvA [22:29:20] wmde/WikibaseDataModel/ssl/a3082a1 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37776899 [22:32:36] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Hm, there is no bug number and no explanation. Why are the (very few) labels on the special page a problem?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166180 (owner: 10Bene) [22:36:48] * hoo eyes aude [23:17:44] [13WikibaseDataModel] 15mzmcbride comment on pull request #235 147199392: Poe's law. :-) 02http://git.io/6JNHhw