[01:53:27] I ran initSiteStats on wikidata [01:53:33] Counting total edits...162404602 [01:53:33] Counting number of articles...12572769 [01:53:33] Counting total pages...16451560 [01:53:33] Counting number of users...1372842 [01:53:33] Counting number of images...0 [01:53:35] Updating site statistics...done. [06:19:24] https://www.wikidata.org/wiki/Q17057727 is not editable ... no clue why [06:26:31] GerardM-: just tried and it worked.. [06:38:22] Tobi_WMDE_SW: thanks now it does [06:39:59] he is dead [06:41:27] (03CR) 10Ebrahim: "Double checked" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165700 (owner: 10Thiemo Mättig (WMDE)) [07:51:10] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Ok, but: This is a breaking change, right? It will, for example, mess up my local setup because I'm using this in my LocalSettings. I thin" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165905 (owner: 10Hoo man) [07:51:58] [13Serialization] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/RIR5cg [07:51:58] 13Serialization/06master 14f51978a 15thiemowmde: Merge pull request #7 from DataValues/102... [08:15:51] [13WikibaseDataModel] 15thiemowmde created 06property-equals (+1 new commit): 02http://git.io/z3YFlw [08:15:51] 13WikibaseDataModel/06property-equals 1414c98eb 15Thiemo Mättig: Add more equals tests for Property [08:18:15] [13WikibaseDataModel] 15thiemowmde opened pull request #224: Add more equals tests for Property (06master...06property-equals) 02http://git.io/X8L8aQ [08:20:49] [13WikibaseDataModel] 15Benestar comment on pull request #224 1414c98eb: Could also test different statements 02http://git.io/u_LbTQ [08:21:31] [13WikibaseDataModel] 15thiemowmde comment on pull request #224 1414c98eb: Thats already tested below. 02http://git.io/-uC6JA [08:24:06] [13WikibaseDataModel] 15Benestar comment on pull request #224 1414c98eb: Ok, so either the test below should be moved into the data provider or the data provider should be split into single test methods. Otherwise this is a bit confusing imo. 02http://git.io/Yp-yvw [08:29:00] wmde/WikibaseDataModel/property-equals/14c98eb : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37577005 [08:42:01] (03PS14) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [08:42:14] (03PS10) 10Bene: Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [08:45:26] Hey guys, can this https://gerrit.wikimedia.org/r/#/c/164743/ and https://gerrit.wikimedia.org/r/#/c/164757/ get a bit more attention? [08:45:55] I just checked them locally and can see that to everyone likes to reviee [08:46:21] (03PS16) 10Bene: [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 [08:47:13] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #14 1405c123e: Is there a reason gems are not sorted alphabetically? It makes it easier to see duplicates (not in such a small file, but they tend to grow). 02http://git.io/sLxk5A [08:48:48] aude: Can you have a look at please? [08:51:10] (03CR) 10Bene: [C: 031] "Looks good, some nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [08:51:31] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #14 1405c123e: Typo: doinf > doing 02http://git.io/44Ey2A [08:51:50] #wikipedia-nobel [08:53:51] (03PS3) 10Ebrahim: Make descriptionview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [08:55:00] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #14 1405c123e: Is there a reason you are using `"strings"` for keys here instead of `:symbols`?... 02http://git.io/exGF2g [08:56:28] (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 (owner: 10Bene) [08:57:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 (owner: 10Bene) [08:59:21] (03PS4) 10Ebrahim: Make descriptionview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [09:02:24] (03PS1) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 [09:12:20] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [09:16:43] [13WikidataBrowserTests] 15tobijat pushed 2 new commits to 06api: 02http://git.io/qT9JUw [09:16:43] 13WikidataBrowserTests/06api 1437db343 15Tobias Gritschacher: Adressed @zeljkofilipin's comments [09:16:43] 13WikidataBrowserTests/06api 1451ca5b4 15Tobias Gritschacher: Don't use symbols as keys yet. [09:17:15] [13WikidataBrowserTests] 15tobijat comment on pull request #14 1451ca5b4: Don't want to do that in this change as all the users of this would need to be updated as well. Can do it in a separate change. 02http://git.io/1zp02A [09:17:27] [13WikidataBrowserTests] 15tobijat comment on pull request #14 1451ca5b4: done. 02http://git.io/b9HHMw [09:17:45] (03PS6) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [09:18:11] (03PS7) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [09:18:32] (03CR) 10Adrian Lang: "7 is a rebase, 6 is a change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [09:19:44] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Restoring my +1. Please note that we have a getLanguageDirection method in wikibase.Site.js. Which can't be used here, I think. Just to le" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [09:20:04] (03PS2) 10Bene: Refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 [09:22:23] (03CR) 10Bene: [C: 031] Make descriptionview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [09:22:33] (03CR) 10Bene: [C: 031] Make labelview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164743 (owner: 10Ebrahim) [09:24:44] [13WikibaseDataModel] 15thiemowmde comment on pull request #224 1414c98eb: You are right, but the test below does a little bit more than the data provider could do. I think this is good enough as it is and did not wanted to waste more time. Please note that we added the `testPropertiesWithDifferentStatementsAreNotEqual` because of an actual bug we once had. 02http://git.io/xD267Q [09:27:59] [13WikibaseDataModel] 15Benestar comment on pull request #224 1414c98eb: item? o.O 02http://git.io/DQHC2A [09:29:12] [13WikibaseDataModel] 15Benestar comment on pull request #224 1414c98eb: > You are right, but the test below does a little bit more than the data provider could do.... 02http://git.io/j8JGVQ [09:32:09] (03PS5) 10Adrian Lang: Add a lot of missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 [09:32:21] (03CR) 10jenkins-bot: [V: 04-1] Refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [09:35:51] (03CR) 10jenkins-bot: [V: 04-1] Add a lot of missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 (owner: 10Adrian Lang) [09:44:30] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06property-equals from 1414c98eb to 14e8f2eb3: 02http://git.io/8JNWFQ [09:44:30] 13WikibaseDataModel/06property-equals 14e8f2eb3 15Thiemo Mättig: Add more equals tests for Property [09:48:37] [13WikibaseDataModel] 15thiemowmde comment on pull request #224 14e8f2eb3: Whooo. Fixed. 02http://git.io/yhCC0Q [09:53:36] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06property-equals from 14e8f2eb3 to 143afd789: 02http://git.io/8JNWFQ [09:53:36] 13WikibaseDataModel/06property-equals 143afd789 15Thiemo Mättig: Add more equals tests for Property [09:55:56] [13WikibaseDataModel] 15thiemowmde comment on pull request #224 143afd789: Ok, merged the tests. (By the way, doing the equals check both directions made me find an actual bug, wohoo!) And yes, I missed the type. Thanks. 02http://git.io/9a3Bgw [10:02:22] [13WikibaseDataModel] 15Benestar comment on pull request #224 143afd789: good catch 02http://git.io/iMXTZA [10:07:50] [13WikibaseDataModel] 15Benestar closed pull request #224: Add more equals tests for Property (06master...06property-equals) 02http://git.io/X8L8aQ [11:20:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Aude, are you going to do the follow up you mentioned?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165487 (owner: 10Aude) [11:31:06] (03Merged) 10jenkins-bot: Add dir="auto" for labelview and alias list items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165487 (owner: 10Aude) [11:38:34] (03PS1) 10Thiemo Mättig (WMDE): More clean up in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 [11:43:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Interesting. Like it. I realized you already renamed most of the confusing variable names but missed some. See my follow up." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165194 (owner: 10Adrian Lang) [11:49:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Fine, besides some variable names which I tackled in my follow up." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [12:11:35] [13WikibaseDataModel] 15thiemowmde created 06badgepatch2 (+1 new commit): 02http://git.io/o_PeDw [12:11:35] 13WikibaseDataModel/06badgepatch2 1417bfa37 15Thiemo Mättig: Fix undefined index 'badges' in SiteLinkListPatcher [12:14:24] [13WikibaseDataModel] 15thiemowmde opened pull request #225: Fix undefined index 'badges' in SiteLinkListPatcher (06master...06badgepatch2) 02http://git.io/Z3UNIg [12:18:23] [13WikibaseDataModel] 15thiemowmde 04deleted 06badgepatch at 142278185: 02http://git.io/gkrNSA [12:20:30] [13WikibaseDataModel] 15thiemowmde created 06badgesnull at 14ae21de7 (+0 new commits): 02http://git.io/kBuLoQ [12:22:03] [13WikibaseDataModel] 15thiemowmde created 06optionalbadges (+1 new commit): 02http://git.io/Yv8mOA [12:22:03] 13WikibaseDataModel/06optionalbadges 14aa50457 15Thiemo Mättig: Consistent type hints for badges [12:22:57] [13WikibaseDataModel] 15thiemowmde opened pull request #226: Consistent type hints for badges (06master...06optionalbadges) 02http://git.io/Mk1Q_A [12:23:30] [13WikibaseDataModel] 15thiemowmde 04deleted 06badgesnull at 14ae21de7: 02http://git.io/aAXLZg [12:23:35] wmde/WikibaseDataModel/badgepatch2/17bfa37 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37593743 [12:30:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove unused destroy event from listview, improve destroy method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165181 (owner: 10Adrian Lang) [12:33:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Do not use second parameter to jQuery constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165184 (owner: 10Adrian Lang) [12:35:33] wmde/WikibaseDataModel/optionalbadges/aa50457 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37594522 [12:40:36] (03Merged) 10jenkins-bot: Remove unused destroy event from listview, improve destroy method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165181 (owner: 10Adrian Lang) [12:43:48] (03Merged) 10jenkins-bot: Do not use second parameter to jQuery constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165184 (owner: 10Adrian Lang) [12:43:50] (03PS1) 10Thiemo Mättig (WMDE): Remove unused use Content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166013 [12:48:17] [13Serialization] 15JeroenDeDauw tagged 061.0.2 at 06master: 02http://git.io/5dT1pA [12:50:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Replace widgetBaseClass in wbtooltip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165182 (owner: 10Adrian Lang) [12:53:27] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/glgggQ [12:53:27] 13WikibaseDataModel/06master 14d20c584 15jeroendedauw: Fix branch alias and version number [12:57:30] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ZjzN7A [12:57:30] 13WikibaseDataModel/06master 14ddb317b 15jeroendedauw: Up rel notes [12:58:44] (03Merged) 10jenkins-bot: Replace widgetBaseClass in wbtooltip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165182 (owner: 10Adrian Lang) [13:00:07] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove listview.liValue and unused listview.prefixedClass [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165183 (owner: 10Adrian Lang) [13:04:21] (03PS8) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [13:04:23] (03PS1) 10Adrian Lang: Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 [13:04:25] (03PS1) 10Adrian Lang: Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 [13:04:27] (03PS1) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 [13:08:15] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/224 [13:14:02] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #224 143afd789: yeah. It's the code that is wrong though, not the comment. (well, the comment is also wrong in that it says "item" rather than "property")... 02http://git.io/jKwi7Q [13:18:52] [13WikibaseDataModel] 15JeroenDeDauw created 06propequals (+1 new commit): 02http://git.io/Gi3NNA [13:18:52] 13WikibaseDataModel/06propequals 147514b58 15jeroendedauw: Restore Property::equals behaviour [13:19:49] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #227: Restore Property::equals behaviour (06master...06propequals) 02http://git.io/lAIklw [13:21:21] (03Merged) 10jenkins-bot: Remove listview.liValue and unused listview.prefixedClass [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165183 (owner: 10Adrian Lang) [13:22:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/MzHNcA [13:22:59] 13WikibaseDataModel/06master 14cbf31bd 15Jeroen De Dauw: Merge pull request #226 from wmde/optionalbadges... [13:23:48] (03CR) 10Daniel Kinzler: Simplify and generalize array handling in SqlUsageTracker (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [13:24:28] (03CR) 10Daniel Kinzler: "i'd prefer to keep explicit checks as close as possible to the db queries." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [13:25:32] (03CR) 10jenkins-bot: [V: 04-1] Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 (owner: 10Adrian Lang) [13:25:39] (03CR) 10Daniel Kinzler: "fine with me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166006 (owner: 10Thiemo Mättig (WMDE)) [13:31:20] wmde/WikibaseDataModel/propequals/7514b58 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37599314 [13:46:19] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/_kQVzg [13:46:19] 13WikibaseDataModel/06master 14a0e026b 15jeroendedauw: Update release notes [13:46:19] 13WikibaseDataModel/06master 14daa3e63 15jeroendedauw: Merge branch 'master' of github.com:wmde/WikibaseDataModel [13:48:11] [13WikibaseDataModel] 15JeroenDeDauw created 06entityid20 (+1 new commit): 02http://git.io/1DymZg [13:48:11] 13WikibaseDataModel/06entityid20 144f151b6 15jeroendedauw: Simplify EntityId class further [13:49:19] anybody had this before? https://bugzilla.wikimedia.org/show_bug.cgi?id=71914 [13:49:26] is it a "feature"? [13:51:00] Thiemo_WMDE: DanielK_WMDE__ ^^ [13:51:32] Bug [13:55:39] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #228: Simplify EntityId class further (06master...06entityid20) 02http://git.io/Ko69Sw [13:56:20] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #221: Draft of how we can change EntityId (06master...06entityid2) 02http://git.io/20vCsA [13:56:59] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06entityid20 from 144f151b6 to 14c2dd35f: 02http://git.io/PJCVdA [13:56:59] 13WikibaseDataModel/06entityid20 14c2dd35f 15jeroendedauw: Simplify EntityId class further [14:00:52] wmde/WikibaseDataModel/entityid20/4f151b6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37601958 [14:12:50] wmde/WikibaseDataModel/entityid20/c2dd35f : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37602811 [14:13:16] Tobi_WMDE_SW: yes, bug. noticed it on test.wikidata.org the other day [14:13:46] DanielK_WMDE__: not sure how long it's been there.. [14:19:38] don't know either, properties are not deleted that often [14:19:42] we should fix this, though [14:19:48] it's probably not hard to do [14:21:29] DanielK_WMDE__: I noted it down to discuss for the next sprint [14:26:59] DanielK_WMDE__: what the most problematic thing about this is, you cannot create a new property with the same label the deleted had.. [14:27:33] Tobi_WMDE_SW: yes. i noticed :) [14:27:57] and Special:NewProperty behaves really weird in that case.. [14:28:06] it probably needs one hour to find, ten minutes to fix, and hald an hour for review... [14:28:22] oh, it does? that's another bug, then [14:31:39] DanielK_WMDE__: indeed. that's a different bug.. will create one. [14:32:31] Tobi_WMDE_SW: https://bugzilla.wikimedia.org/show_bug.cgi?id=71784 [14:32:48] that was my report of the issue when deleting properties [14:32:54] pick one to keep :) [14:33:13] DanielK_WMDE__: it works for items though [14:33:22] i didn't try/notice that [14:33:29] curious [14:33:30] I tried [14:33:42] yea. just close mine as a dupe or something [15:26:33] [13WikibaseDataModel] 15thiemowmde comment on pull request #224 143afd789: `Comparable` doesn't talk about this. I really wonder. It's not a real `equals` if it ignores a (very relevant) property. Didn't we talked about this weeks ago? Can't remember what the conclusion was. 02http://git.io/o0KprQ [15:27:38] [13WikibaseDataModel] 15thiemowmde 04deleted 06propequals at 147514b58: 02http://git.io/l6jtFw [15:34:09] [13WikibaseDataModel] 15thiemowmde created 06differentids (+1 new commit): 02http://git.io/_v0Ygw [15:34:09] 13WikibaseDataModel/06differentids 14dfe2caa 15Thiemo Mättig: Define behaviour for different ids [15:36:50] Lydia_WMDE: ahhhhhh! my mom says the internet is broken. Chromium no longer appears, only in the bar at the bottom. Might that be a virus? [15:36:51] ughhhhh [15:37:15] -_- [15:37:17] [13WikibaseDataModel] 15thiemowmde opened pull request #229: Define behaviour for different ids (06master...06differentids) 02http://git.io/5tUnvA [15:39:10] JohnLewis: I didn't know you wrote about the cold war! http://www.goodreads.com/book/show/28436.Strategies_of_Containment [15:39:49] JeroenDeDauw: How could you not know! [15:49:30] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #224 143afd789: Heh - I thought I checked `Comparable` and saw the doc there. Looked again now and no doc. wtf?... 02https://github.com/wmde/WikibaseDataModel/pull/224#discussion_r18713684 [15:50:36] wmde/WikibaseDataModel/differentids/dfe2caa : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37612909 [16:16:30] Lydia_WMDE: the virus has been found... "Yesterday I used the BIG SCREEN.... So you can GUESS now were THE INTERNET was hiding" [16:25:44] (03PS2) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 [16:53:43] (03CR) 10Adrian Lang: [C: 032] Remove unused use Content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166013 (owner: 10Thiemo Mättig (WMDE)) [16:54:49] (03CR) 10Adrian Lang: [C: 04-1] "Waht? Please split up and explain. Moving stuff into View namespace seems to be a good idea, though." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [16:57:14] (03CR) 10Adrian Lang: "Good thing. Thiemo, Why do you think wikibase.Site can't be used here? Seems to make sense to use it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [16:58:26] (03CR) 10Adrian Lang: "Great, but same question: Could wikibase.Site be used here? I'd like to keep the ULS dependency contained." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164743 (owner: 10Ebrahim) [17:02:48] (03Merged) 10jenkins-bot: Remove unused use Content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166013 (owner: 10Thiemo Mättig (WMDE)) [17:28:06] JeroenDeDauw: haha, my mom has the same virus! [17:29:19] hi JeroenDeDauw and Tobi_WMDE_SW_NA :D [17:30:24] (03CR) 10Bene: "Sorry, this was meant to be a draft to reorder the patches. However, I still need some ideas how to split the whole thing best." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [17:37:14] [13WikibaseDataModel] 15Benestar 04deleted 06entityid20 at 14c2dd35f: 02http://git.io/mct9SQ [18:02:55] benestar: any breaking changes you want to make in DM? [18:03:10] Better make them now, or wait till 3.0 [18:03:42] Thiemo_WMDE: I can haz test for https://github.com/wmde/WikibaseDataModel/pull/225 so this can be merged? [18:05:06] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #216: Call getQualifiers and getReferences outside of iterator_to_array (06master...06getallsnaks) 02http://git.io/oZKI8w [18:08:29] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06statement_ from 148ce9df0 to 146faeb9b: 02http://git.io/LULRMg [18:08:29] 13WikibaseDataModel/06statement_ 146faeb9b 15jeroendedauw: Enhance docs of Statement constructor and add alternate constructors [18:09:11] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06statement_ from 146faeb9b to 140013a9d: 02http://git.io/LULRMg [18:09:11] 13WikibaseDataModel/06statement_ 140013a9d 15jeroendedauw: Enhance docs of Statement constructor and add alternate constructors [18:10:28] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06badgepatch2 from 1417bfa37 to 140678f7b: 02http://git.io/b6sqQA [18:10:28] 13WikibaseDataModel/06badgepatch2 14b10a628 15Thiemo Mättig: Fix undefined index 'badges' in SiteLinkListPatcher [18:10:28] 13WikibaseDataModel/06badgepatch2 140678f7b 15Thiemo Mättig: Add test [18:10:43] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06statement_ from 140013a9d to 141725717: 02http://git.io/LULRMg [18:10:43] 13WikibaseDataModel/06statement_ 141725717 15jeroendedauw: Enhance docs of Statement constructor and add alternate constructors [18:10:58] benestar: https://github.com/wmde/WikibaseDataModel/pull/205 [18:11:15] wmde/WikibaseDataModel/statement_/6faeb9b : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/37626520 [18:16:22] wmde/WikibaseDataModel/statement_/0013a9d : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/37626594 [18:17:03] [13WikibaseDataModel] 15thiemowmde created 06okthen (+1 new commit): 02http://git.io/zCYH0A [18:17:03] 13WikibaseDataModel/06okthen 146fa1fff 15Thiemo Mättig: Add missing equals tests [18:17:24] [13WikibaseDataModel] 15thiemowmde opened pull request #230: Add missing equals tests (06master...06okthen) 02http://git.io/3pUMTw [18:19:57] [13WikibaseDataModel] 15thiemowmde closed pull request #229: Define behaviour for different ids (06master...06differentids) 02http://git.io/5tUnvA [18:22:03] [13WikidataBrowserTests] 15adrianlang comment on pull request #14 1451ca5b4: This throws for me:... 02http://git.io/OK8ndQ [18:24:13] (03CR) 10Adrian Lang: "Hm, apparently this is already barely anything but moving files. Bad gerrit for making this look so complicated." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [18:25:03] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06badgepatch2 at 140678f7b: 02http://git.io/e7yJUQ [18:25:53] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #230: Add missing equals tests (06master...06okthen) 02http://git.io/3pUMTw [18:26:27] (03PS3) 10Adrian Lang: Introduce SiteLinksChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166018 [18:26:29] (03PS2) 10Adrian Lang: Introduce LabelsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166017 [18:26:31] (03PS2) 10Adrian Lang: Introduce DescriptionsChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166016 [18:26:33] (03PS9) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [18:26:35] (03PS1) 10Adrian Lang: Remove wikibase.getRevisionStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/166077 [18:29:32] Thiemo_WMDE: huh wtf [18:29:49] If you run the whole dir it again does not fail [18:30:00] same here. [18:30:42] i get the notice plus a real error because array_map expects an array but doesnt get one. [18:35:23] Thiemo_WMDE: you want to fix this? [18:36:46] wmde/WikibaseDataModel/okthen/6fa1fff : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/37627255 [18:36:57] JeroenDeDauw: what is this thing? [18:38:33] Thiemo_WMDE: the warnings not shown in DM during the tests [18:38:40] Thiemo_WMDE: if not I will have a go at it [18:38:47] But we should not both do that [18:39:09] [13WikibaseDataModel] 15thiemowmde created 06errorreporting (+1 new commit): 02http://git.io/fCYwlg [18:39:09] 13WikibaseDataModel/06errorreporting 14db076c4 15Thiemo Mättig: Remove broken error_reporting code [18:40:14] JeroenDeDauw: https://github.com/wmde/WikibaseDataModel/pull/231 [18:40:22] [13WikibaseDataModel] 15thiemowmde opened pull request #231: Remove broken error_reporting code (06master...06errorreporting) 02http://git.io/rkSRUQ [18:40:39] i wonder wha daniel wrote this. it doesnt make any sense. [18:41:08] suppress a warning in the test? ok. but there is not warning. it think there never was one. [18:41:36] Thiemo_WMDE: even if there was, this is not how you set the error level [18:41:43] And it's set to the wrong value as well [18:43:30] (03CR) 10Bene: "So perhaps the best thing is to move the classes back to their original namespaces and then do the namespace clean up in a follow up." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [18:44:29] I wonder who merged that [18:44:38] Was on Gerrit, but repo was deleted, so can't see [18:47:08] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06errorreporting: 02http://git.io/tzHINA [18:47:08] 13WikibaseDataModel/06errorreporting 14fdde19d 15Jeroen De Dauw: Still need this part [18:53:07] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06errorreporting: 02http://git.io/9DfA2w [18:53:07] 13WikibaseDataModel/06errorreporting 147388723 15Thiemo Mättig: Raise level [18:54:45] wmde/WikibaseDataModel/errorreporting/db076c4 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37628804 [18:58:09] (03CR) 10Thiemo Mättig (WMDE): "Sure, it _can_ be used, when adding it to the dependency graph. :-) But this would be confusing. Why should a descriptionview depend on si" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [19:03:26] wmde/WikibaseDataModel/errorreporting/fdde19d : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37629450 [19:13:39] wmde/WikibaseDataModel/errorreporting/7388723 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37630043 [19:15:12] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06errorreporting at 147388723: 02http://git.io/p8ovuw [19:39:43] (03PS2) 10Thiemo Mättig (WMDE): Small refactoring for ReferencedEntitiesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156042 [19:59:19] JeroenDeDauw: rofl [20:27:44] !nyan | Lydia_WMDE [20:27:45] Lydia_WMDE: ~=[,,_,,]:3 [20:27:57] it's a lazowik [20:28:12] lazowik: want to help with all of the open bugs? :P [20:28:27] yeah, all of them :p [20:28:28] ya know [20:28:35] just started studies [20:28:42] now I have even more free time ofc. [20:28:50] \o/ [20:29:34] Lydia_WMDE: If you have to ask volunteers to do the work your devs should be doing; someone is doing their job wrong ;) [20:29:52] JohnLewis: but they are all busy with the same thing! [20:29:57] * lazowik coughs gently looking at JohnLewis [20:30:17] if one can "cough gently" [20:30:20] Lydia_WMDE: Get more devs or more productive devs :p [20:30:38] JohnLewis: but but but volunteer devs are awesome too [20:30:41] i want more of them [20:30:57] pay them to volunteer :D [20:31:07] haha [20:31:10] lol [20:31:20] i think JohnLewis is misunderstanding the meaning of volunteer [20:31:21] ;-) [20:31:24] therefore defeating the purpose and making more want to volunteer for pay but don't pay them! A trap :D [20:35:00] Lydia_WMDE ^ genius right? [20:35:07] totally! [20:35:15] i will get right on it ;-) [20:35:23] when i found those millions of dollars [20:36:18] ask for funding of WMDE :p 'to test the next generation of volunteering practises for Wikimedia' :D [20:36:22] *off [20:37:53] hehe [20:59:33] (03CR) 10Bene: [C: 031] "just a nitpick, if you don't care I can merge" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156042 (owner: 10Thiemo Mättig (WMDE)) [21:47:32] (03CR) 10Thiemo Mättig (WMDE): Small refactoring for ReferencedEntitiesFinder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156042 (owner: 10Thiemo Mättig (WMDE))