[00:25:09] [16:54:07] kaldari|2: I thought Wikidata.org was a Wikibase client of itself? <-- it is. [00:25:47] kaldari|2: things on wikidata.org itself are usually WikidataRepo (should be WikibaseRepo) or Wikimedia --> Wikidata [04:06:56] is there any way to find classes in Wikidata apart from checking composer/autoload_classmap.php? [07:33:24] (03CR) 10Nikerabbit: [C: 031] Make Wikibase diff table to match user language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165465 (owner: 10Ebrahim) [08:01:53] Tobi_WMDE_SW_NA: thx re investigation [08:13:10] (03CR) 10Adrian Lang: Introduce usage tracking service. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [08:52:32] (03PS1) 10Thiemo Mättig (WMDE): Cleanup EntityContentDiffView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165700 [08:53:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Double checked. Good catch! Thanks for the additional explanation, this was really helpful." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165465 (owner: 10Ebrahim) [09:05:09] (03Merged) 10jenkins-bot: Make Wikibase diff table to match user language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165465 (owner: 10Ebrahim) [09:14:25] (03PS3) 10Adrian Lang: Simplify and generalize array handling in SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 [09:14:27] (03PS3) 10Adrian Lang: Remove reindexEntityIds from SqlUsageTracker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165194 [09:14:37] (03CR) 10Adrian Lang: Simplify and generalize array handling in SqlUsageTracker (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165193 (owner: 10Adrian Lang) [09:21:06] hello [09:21:20] I'm on the trail of 71519 [09:21:52] is there a reason that Wikibase\DataModel\HashArray::unserialize() returns a value? [09:21:53] thanks for looking into it TimStarling [09:21:59] DanielK_WMDE__: ^ [09:22:12] JeroenDeDauw: ^ [09:22:13] docs for Serializable::unserialize() indicate that it should return void [09:23:02] when you return a value from it, the return value is immediately deleted, which my gdb work is indicating as a possible cause of the dangling pointer [09:23:21] I suppose that case is not often tested [09:49:17] TimStarling: thanks for digging in! can you add that info on bugzilla? we should also probably report it upstream. [09:50:18] Lydia_WMDE, JeroenDeDauw: can we get rid of everything that depends on ArrayObject and other SPL stuff? That stuff seems to be unstable/buggy, and it behaves oh so slightly differently in hhvm... [09:50:20] maybe I was a bit premature -- I tried patching it out but it still segfaulted [09:50:45] but it is a code quality issue anyway [09:50:48] hm, bummer. though we shouldn't return a value if it's documented to return void. [09:50:49] nothing seems to use the return value [09:52:55] the doc for ArrayObject sais: @return void The unserialized ArrayObject. [09:52:58] wtf does that mean? [09:55:18] found at least one more unserialize() implementations that return something [09:55:28] filing issues on github [09:56:09] was it Diff\DiffOp\Diff\Diff? [09:56:18] funny name for a class [09:59:23] it's the base class for structural (nested array) diffs. [09:59:26] yes, it's a funny name. [09:59:40] TimStarling: https://github.com/wmde/Diff/issues/14 and https://github.com/wmde/WikibaseDataModel/issues/217 [10:17:17] here is where I am at: calling getSerialized() adjusts the reference count on a certain SnakList object 33 times [10:17:25] the net effect is to decrement by 1 [10:18:14] the number of reference count adjustments should be even, not odd, it should add to zero [10:18:34] so either it should be 34 times, i.e. something is missing, or 32 times, i.e. a reference count adjustment is omitted [11:34:02] (03PS1) 10Adrian Lang: Add missing Wikibase\DataModel\Entity\Item uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 [11:38:10] (03CR) 10jenkins-bot: [V: 04-1] Add missing Wikibase\DataModel\Entity\Item uses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 (owner: 10Adrian Lang) [12:11:27] (03PS1) 10Tobias Gritschacher: Specify PARAM_TYPE and PARAM_REQUIRED for "continue" in wbsearchentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165711 (https://bugzilla.wikimedia.org/71877) [13:11:38] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06api: 02http://git.io/2NgRYw [13:11:38] 13WikidataBrowserTests/06api 14eda2249 15Tobias Gritschacher: Use new WikidataAPI gem everywhere and remove wikibase_api_module.rb [13:27:41] (03PS2) 10Adrian Lang: Add a lot if missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 [13:28:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Specify PARAM_TYPE and PARAM_REQUIRED for "continue" in wbsearchentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165711 (https://bugzilla.wikimedia.org/71877) (owner: 10Tobias Gritschacher) [13:33:32] (03PS3) 10Adrian Lang: Add a lot of missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 [13:33:34] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06api: 02http://git.io/buNZ_g [13:33:34] 13WikidataBrowserTests/06api 1405c123e 15Tobias Gritschacher: Update Gemfile.lock [13:38:19] [13WikidataBrowserTests] 15tobijat opened pull request #14: Use mediawiki_api-wikidata gem for interaction with Wikidata API (06master...06api) 02http://git.io/HNQd9w [13:38:29] (03CR) 10jenkins-bot: [V: 04-1] Add a lot of missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 (owner: 10Adrian Lang) [13:39:07] (03Merged) 10jenkins-bot: Specify PARAM_TYPE and PARAM_REQUIRED for "continue" in wbsearchentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165711 (https://bugzilla.wikimedia.org/71877) (owner: 10Tobias Gritschacher) [13:40:16] [13Diff] 15thiemowmde created 06unserialize (+1 new commit): 02http://git.io/FuaYVg [13:40:16] 13Diff/06unserialize 14e40283e 15Thiemo Mättig: Do not return stuff on unserialize [13:41:22] Adrian_WMDE: https://github.com/wmde/WikidataBrowserTests/pull/14 [13:43:16] [13Diff] 15thiemowmde opened pull request #15: Do not return stuff on unserialize (06master...06unserialize) 02http://git.io/uTf9_g [13:45:16] Tobi_WMDE_SW: Won't look at it for a week [13:45:34] Adrian_WMDE: panic! [13:46:54] Adrian_WMDE: will ask zeljkof to have look at it too.. [13:52:01] wmde/Diff#67 (unserialize - e40283e : Thiemo Mättig): The build passed. [13:52:01] Change view : https://github.com/wmde/Diff/commit/e40283ed7807 [13:52:01] Build details : http://travis-ci.org/wmde/Diff/builds/37501069 [14:03:26] (03PS1) 10Thiemo Mättig (WMDE): Stop using aliases outside Wikibase namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165720 [14:12:19] [13WikibaseDataModel] 15thiemowmde created 06wbaliases (+1 new commit): 02http://git.io/PJDhNg [14:12:19] 13WikibaseDataModel/06wbaliases 140a0d1ae 15Thiemo Mättig: Drop aliases in Wikibase main namespace [14:16:41] [13WikibaseDataModel] 15thiemowmde opened pull request #218: Drop aliases in Wikibase main namespace (06master...06wbaliases) 02http://git.io/FUTe0w [14:18:02] (03PS4) 10Thiemo Mättig (WMDE): Add a lot of missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 (owner: 10Adrian Lang) [14:22:16] (03CR) 10jenkins-bot: [V: 04-1] Add a lot of missing use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 (owner: 10Adrian Lang) [14:24:23] wmde/WikibaseDataModel/wbaliases/0a0d1ae : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37503857 [14:27:56] [13WikibaseDataModel] 15thiemowmde created 06setid (+1 new commit): 02http://git.io/tUO0mA [14:27:57] 13WikibaseDataModel/06setid 142e1b2d1 15Thiemo Mättig: More efficient EntityId construction [14:32:11] [13WikibaseDataModel] 15thiemowmde opened pull request #219: More efficient EntityId construction (06master...06setid) 02http://git.io/n7MIvA [14:44:16] [13WikibaseDataModel] 15thiemowmde created 06returnvoid (+1 new commit): 02http://git.io/Pi7PqA [14:44:16] 13WikibaseDataModel/06returnvoid 14cb5119d 15Thiemo Mättig: Do not return stuff on unserialize [14:45:44] [13WikibaseDataModel] 15thiemowmde opened pull request #220: Do not return stuff on unserialize (06master...06returnvoid) 02http://git.io/Zz79Yw [14:49:38] Thiemo_WMDE: will have a look at the PRs you made [14:50:11] JeroenDeDauw: not urgent at all. just code-sanity. [14:51:10] Thiemo_WMDE: it was insane before? :) [14:52:56] wait. thats a false friend. sanitary? [14:53:00] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #219: More efficient EntityId construction (06master...06setid) 02http://git.io/n7MIvA [14:53:16] a false friend? [14:53:49] when translating the german "clean" and picking a word that sound alike. [14:54:42] Thiemo_WMDE: I'm thinking that for EntityId construction, we can possibly avoid some of the code being called when a derivative is constructed [14:54:51] Right now ItemId and PropertyId call the base class constrcutor [14:55:05] Which needs to do extra checking, that is not needed in that case [14:55:07] oh. good point. i can have a look. [14:55:38] Also, I wonder how close we are to being able to make the EntityId constructor protected [14:55:56] huhwait [14:56:18] wmde/WikibaseDataModel/returnvoid/cb5119d : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37506964 [14:56:20] It already is... [14:56:39] So I guess the constructor is only there because we needed to support unserialize( $entityId ) [14:57:00] oh... i see... [14:57:18] If we no longer have instances of EntityId (rather than a derivative) that we deserialize, we can drop all that stuff and have very simple constructors in ItemId and PropertyId [14:57:31] yea. [14:57:44] As far as DM is concrned this can happen of course, the question is what the state of WB.git is [14:58:36] why does that matter? if the constructor is protected the only relevant caller left is unserialize. [15:03:30] Thiemo_WMDE: the derivatives are also calling it [15:03:39] Thiemo_WMDE: also, look at the fields [15:05:37] Thiemo_WMDE: I will have a go at this and put it on a branch that should not be merged yet (since this will be a breaking change) [15:19:29] [13WikibaseDataModel] 15JeroenDeDauw created 06entityid2 (+1 new commit): 02http://git.io/KKvYDA [15:19:29] 13WikibaseDataModel/06entityid2 1403bd17c 15jeroendedauw: Draft of how we can change EntityId [15:19:54] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #221: Draft of how we can change EntityId (06master...06entityid2) 02http://git.io/20vCsA [15:20:17] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/221 [15:22:32] Thiemo_WMDE: did you tackle this yet? https://github.com/wmde/WikibaseDataModel/issues/217 [15:22:43] nvm [15:22:45] found [15:23:09] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #220: Do not return stuff on unserialize (06master...06returnvoid) 02http://git.io/Zz79Yw [15:23:39] [13Diff] 15JeroenDeDauw closed pull request #15: Do not return stuff on unserialize (06master...06unserialize) 02http://git.io/uTf9_g [15:25:01] Thiemo_WMDE: aude: there are also a bunch of class aliases in Diff: https://github.com/wmde/Diff/blob/master/Diff.php [15:25:19] [13WikibaseDataModel] 15thiemowmde opened pull request #222: Optimize all EntityId::unserialize (06master...06betterUnserialize) 02http://git.io/N0qKug [15:25:20] Would be great if we could update WB.git so that these can be dropped in the next rel [15:25:41] Suspect very few usages of the old names remain [15:25:44] JeroenDeDauw: possible duplicate work, sorry: https://github.com/wmde/WikibaseDataModel/pull/222 [15:26:55] uh, my change keeps compatibility and can be merged before your proposal. ;) [15:27:06] Thiemo_WMDE: yeah, nice [15:27:53] [13WikibaseDataModel] 15thiemowmde comment on pull request #221 1403bd17c: I'm not sure about this. In my opinion the strtoupper is only needed in unserialize. 02http://git.io/nzAgNA [15:28:06] My change is basically to illustrate what we can do once we no longer care about EntityId instantiation [15:28:40] Furthger things that could be done on top would be optimization of the serialization (right now it contains a no longer needed entity type) [15:30:52] but we still care about unserialize, don#t we? [15:31:58] Thiemo_WMDE: of ItemId and PropertyId for sure (look at my change, the Serializable interface is still implemented) [15:32:05] Not sure about the EntityId one [15:32:17] We should get rid of all code using that [15:32:20] And might already have [15:32:54] [13WikibaseDataModel] 15thiemowmde comment on pull request #222 14200bfbf: Uh, is it ok to remove this and have a default (public) constructor? Or add an empty private constructor instead? 02http://git.io/BuCWbQ [15:33:47] wmde/WikibaseDataModel/entityid2/03bd17c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37510931 [15:34:18] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #221 1403bd17c: That behaviour was not changed in this commit. If we do what you suggest, then `new ItemId( 'q1' )` and `new ItemId( 'Q1' )` will no longer be the same. 02http://git.io/G2hqsg [15:46:58] wmde/WikibaseDataModel/betterUnserialize/200bfbf : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37511383 [15:49:58] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #222 14200bfbf: If you can turn this into an empty private constructor, that'd be nice. 02http://git.io/-PkrtQ [15:52:26] (03CR) 10Jeroen De Dauw: [C: 032] Stop using aliases outside Wikibase namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165720 (owner: 10Thiemo Mättig (WMDE)) [15:58:29] [13WikibaseQueryEngine] 15JeroenDeDauw created 06ClaimList (+1 new commit): 02http://git.io/lrvt5A [15:58:29] 13WikibaseQueryEngine/06ClaimList 14f658742 15jeroendedauw: Remove initial ClaimList class [15:58:46] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #121: Remove initial ClaimList class (06master...06ClaimList) 02http://git.io/UK8KMQ [16:03:13] [13WikibaseQueryEngine] 15JeroenDeDauw created 06entitydoc (+1 new commit): 02http://git.io/gtHylQ [16:03:13] 13WikibaseQueryEngine/06entitydoc 14bab5082 15jeroendedauw: The methods in QueryStoreWriter now accept `EntityDocument` rather than just `Entity` [16:04:54] wmde/WikibaseQueryEngine/ClaimList/f658742 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/37515095 [16:10:09] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06wbaliases from 140a0d1ae to 14fc61c68: 02http://git.io/VRxeZg [16:10:09] 13WikibaseDataModel/06wbaliases 14fc61c68 15Thiemo Mättig: Drop aliases in Wikibase main namespace [16:11:08] wmde/WikibaseQueryEngine/entitydoc/bab5082 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/37515640 [16:15:21] (03PS2) 10Thiemo Mättig (WMDE): Workaround for invalid ParserAfterParse hook call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165440 (https://bugzilla.wikimedia.org/71772) [16:27:29] [13WikibaseDataModel] 15Benestar comment on pull request #221 1403bd17c: I agree with Jeroen that `strtoupper` should stay there. 02http://git.io/Ano8BQ [16:28:19] wmde/WikibaseDataModel/wbaliases/fc61c68 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseDataModel/builds/37516533 [16:30:57] [13Geo] 15brightbyte pushed 1 new commit to 06FixPrecisionInFormatter: 02http://git.io/ZWNx_A [16:30:57] 13Geo/06FixPrecisionInFormatter 1457d5443 15daniel: No fatal on wrong type [16:33:05] [13Geo] 15brightbyte pushed 1 new commit to 06master: 02http://git.io/2jmXWA [16:33:05] 13Geo/06master 14c56ea3c 15Daniel Kinzler: Merge pull request #8 from DataValues/augmentParseException... [17:09:27] Lydia_WMDE: heyho, I'm back :D [17:10:44] Hello. why wikipedia used template {{wikidata}} and comparison with the substitution of the category is processed in the module, rather than using the magic words in the template as here https://test2.wikipedia.org/w/index.php?title=Template:Wikidata&diff=prev&oldid=49535 ? Did a lot of requests to the module will be more optimal (the server load?) Than using the magic words? [17:23:52] benestar: hey! [17:23:56] good to have you back ;-) [17:58:24] aude: No bump this week? [17:59:17] else hoo or anyone :P [17:59:43] Not branched yet [17:59:53] * hoo has no idea [18:00:02] been hardly working much this week except of firefighting [18:00:14] * Reedy imagines hoo with a fire fighters hat on [18:01:05] I don't see a branch, so I guess there isn't [18:01:10] Or at least, not till tuesday [18:01:29] Reedy: no branch [18:01:36] ook :) [18:01:43] we are busy with multimedia folks + firefighting [18:02:46] [13Geo] 15JeroenDeDauw 04deleted 06augmentParseException at 14fdd8d53: 02http://git.io/m-oCdA [18:04:11] (03CR) 10Jeroen De Dauw: "yay \o/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165707 (owner: 10Adrian Lang) [18:08:23] aude, you're working on structured image data? :] [18:08:55] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/GAqlCA [18:08:55] 13Geo/06master 1430266e8 15jeroendedauw: Fix version number [18:09:28] (03CR) 10Aude: [C: 032] Workaround for invalid ParserAfterParse hook call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165440 (https://bugzilla.wikimedia.org/71772) (owner: 10Thiemo Mättig (WMDE)) [18:09:44] MaxSem: we are! :) [18:09:49] weeee [18:10:31] (03CR) 10Aude: [C: 032] Workaround for invalid ParserAfterParse hook call [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165488 (https://bugzilla.wikimedia.org/71772) (owner: 10Aude) [18:11:09] oh ffs [18:11:21] json dumps keep failing and we don't have logs :S [18:11:28] we don't?? [18:11:33] I'll need to kick them of per hand to see what's up [18:11:36] thought they were just somewhere i can't access [18:11:46] I don't think I made them log somewhere [18:12:44] Bad think that ops wont fullfil my access request [18:12:48] * thing [18:12:49] :S [18:12:56] JeroenDeDauw: I searched for classes that use EntityId and contain (un)serialize calls. found some candidates but none of them uses the two together. [18:14:08] hoo: :( [18:14:42] Thiemo_WMDE: You can try copying the deserialization code into ItemId and PropertyId, add an exception throw in the EntityId one, and run the WB.git tests [18:14:49] aude: I can still hack stuff up to get the logs... but I can't regenerate the dumps myself [18:16:31] [13WikibaseDataModel] 15Benestar pushed 14 new commits to 06bypropertyidarrayrewrite: 02http://git.io/c4Uu2Q [18:16:31] 13WikibaseDataModel/06bypropertyidarrayrewrite 147cd36ba 15Bene: Create rewrite of ByPropertyIdArray [18:16:31] 13WikibaseDataModel/06bypropertyidarrayrewrite 14c18f729 15Bene: Add comments [18:16:31] 13WikibaseDataModel/06bypropertyidarrayrewrite 1453b799e 15Bene: Rename methods in ByPropertyIdGrouper [18:16:55] aude: Backport today? [18:17:11] one thing, yes [18:17:35] aude: Can I hijack that with another fix? [18:17:39] When do you plan to deploy? [18:17:41] quite polluting the logs, at least yesterday and day before [18:17:47] swat? [18:18:03] Ok... I guess I can be up a bit longer today [18:18:06] [13Common] 15JeroenDeDauw created 06023 (+1 new commit): 02http://git.io/YQ9RyQ [18:18:06] 13Common/06023 14ab84576 15jeroendedauw: Allow installation with DataValues 1.x, bump to 0.2.3 [18:18:09] don't have to be up so early tomorrow [18:19:33] * aude is tired [18:19:45] Ok, I can do it, then :) [18:19:48] i might rest and come back at swat time [18:19:59] or you can handle it, even better [18:20:15] * aude has been up wee hours to chat with tim etc. [18:20:32] then up early to go to the office, etc. [18:20:41] Same here early this week [18:20:47] although I had to be up for university [18:20:48] :/ [18:21:02] [13WikibaseDataModel] 15Benestar 04force-pushed 06bypropertyidarrayrewrite from 144ed0df7 to 145935c7d: 02http://git.io/TUtb0Q [18:21:10] if you want to add something to backport, fine with me [18:21:32] [13Common] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/ZfSnPg [18:21:32] 13Common/06master 14c9f4dfd 15thiemowmde: Merge pull request #11 from DataValues/023... [18:22:11] [13Common] 15JeroenDeDauw tagged 060.2.3 at 06master: 02http://git.io/FgaD7w [18:22:31] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06bypropertyidarrayrewrite: 02http://git.io/n0HZ0A [18:22:31] 13WikibaseDataModel/06bypropertyidarrayrewrite 141fb0e96 15Bene: Remove new classes [18:22:51] (03Merged) 10jenkins-bot: Workaround for invalid ParserAfterParse hook call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165440 (https://bugzilla.wikimedia.org/71772) (owner: 10Thiemo Mättig (WMDE)) [18:22:56] (03Merged) 10jenkins-bot: Workaround for invalid ParserAfterParse hook call [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165488 (https://bugzilla.wikimedia.org/71772) (owner: 10Aude) [18:23:31] [13Number] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/PF5a7A [18:23:31] 13Number/06master 14e9e77db 15Jeroen De Dauw: Update .scrutinizer.yml [18:24:10] [13Number] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/q2iA0w [18:24:10] 13Number/06master 14bedfbd5 15Jeroen De Dauw: Update README.md [18:24:39] [13Serialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/MpcZkg [18:24:39] 13Serialization/06master 14c7c52dd 15Jeroen De Dauw: Update README.md [18:24:49] (03PS1) 10Hoo man: Fix dumpJson class not found fatal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165768 [18:24:53] aude: ^ easy CR [18:24:57] [13Iri] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/C-0H1w [18:24:57] 13Iri/06master 14203ed68 15Jeroen De Dauw: Update README.md [18:25:03] oh wait, didn't link the bug [18:25:07] [13Iri] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/NOmnUA [18:25:07] 13Iri/06master 143205ac4 15Jeroen De Dauw: Update .scrutinizer.yml [18:25:27] (03PS2) 10Hoo man: Fix dumpJson class not found fatal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165768 (https://bugzilla.wikimedia.org/71871) [18:25:30] now [18:25:37] [13Validators] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/oa8AEw [18:25:37] 13Validators/06master 14c4f2535 15Jeroen De Dauw: Update README.md [18:25:47] spam spam spam [18:25:53] [13Time] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/C_FbsQ [18:25:53] 13Time/06master 14ea880ac 15Jeroen De Dauw: Update README.md [18:26:19] aaaah [18:26:27] easy chocoloate though [18:26:44] (03CR) 10Aude: [C: 032] Fix dumpJson class not found fatal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165768 (https://bugzilla.wikimedia.org/71871) (owner: 10Hoo man) [18:26:48] * hoo needs a remote candy bowl :D [18:27:13] heh [18:27:35] hoo: I'm imagining our public budget report to include a line "remote candy bowl" now [18:27:42] added us to https://wikitech.wikimedia.org/wiki/Deployments#Week_of_October_6th [18:29:06] wmde/WikibaseDataModel/bypropertyidarrayrewrite/4ed0df7 : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/37527547 [18:29:59] Awesome, thanks :) [18:30:09] Will do the build etc. in a bit [18:31:56] i can update it [18:31:58] mh... would be nice to have some generic test that looks whether all classes referenced in files can actually be located [18:32:12] +1 [18:32:12] not sure how that would look like though [18:32:48] although dumpJson is doing way too much w/o tests [18:33:00] does it have any tests? the maintenance script class? [18:33:15] No, it's supposed to be a thin wrappe [18:33:16] r [18:33:19] but that's not the case [18:33:25] a integration test would be nice [18:33:28] exactly [18:33:29] *a n [18:34:13] (03PS1) 10Aude: Fix dumpJson class not found fatal [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165777 (https://bugzilla.wikimedia.org/71871) [18:34:23] Ok, so you're doing it :) [18:34:29] sure [18:34:32] [13Geo] 15JeroenDeDauw created 06101 (+1 new commit): 02http://git.io/SRW8PA [18:34:32] 13Geo/06101 14928fcec 15jeroendedauw: Make installable with DV 1.x and bump to 1.0.1 [18:34:36] already prepared [18:34:48] [13Geo] 15JeroenDeDauw opened pull request #20: Make installable with DV 1.x and bump to 1.0.1 (06master...06101) 02http://git.io/Y1F8tw [18:34:50] not that tired yet [18:36:02] :) [18:37:47] by the way, I made some imrovements to the Wikidata Vagrant role, your comments will be appreciated: https://gerrit.wikimedia.org/r/165359 [18:38:11] MaxSem: great [18:38:40] * hoo doesn't have vagrant around atm, so can't really test it [18:38:45] but I can have a look of course [18:39:29] what i had vagrant do was the bare minimum to have it work and have a client [18:39:32] [13Geo] 15JeroenDeDauw 04force-pushed 06101 from 14928fcec to 1419e391f: 02http://git.io/7q_CIA [18:39:32] 13Geo/06101 1419e391f 15jeroendedauw: Make installable with DV 1.x and bump to 1.1 [18:39:36] much more could be done to improve [18:39:58] [13Geo] 15JeroenDeDauw pushed 5 new commits to 06master: 02http://git.io/d0q6tQ [18:39:58] 13Geo/06master 14351d8c0 15daniel: The procision options is given in degrees, not digits.... [18:39:58] 13Geo/06master 14548398a 15daniel: Pass precision from Globe*Formatter to Geo*Formatter... [18:39:58] 13Geo/06master 14961eb0d 15daniel: Add round trip tests for Globe and Geo [18:40:19] it works for me, I even almost done GeoData integration with it:P [18:40:23] I yesterday set up apache, MediaWiki and Wikibase on my netbook... went quite fine, but the netbook is quite slow :S [18:40:47] they don't issue MBPs at WMDE? [18:40:54] but the hhvm package facebook has up for Fedora 20 is like ancient, so used Zend [18:41:01] MaxSem: MBPs? [18:41:13] mac book pro [18:41:14] MaxSem: yay [18:41:34] MaxSem: Well, I of course have this more beefy box for real work [18:41:49] the netbook is more of a thing I can use in train or so [18:41:56] (as a volunteer) [18:42:05] MaxSem: for eswiki etc? [18:42:14] which i think gets coordinates from wikidata now [18:42:28] (03Merged) 10jenkins-bot: Fix dumpJson class not found fatal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165768 (https://bugzilla.wikimedia.org/71871) (owner: 10Hoo man) [18:42:49] * aude had geodata + wikibase work with solr, at one point, but experimental only [18:42:50] it pulls primary coordinates from WD unless verridden locally [18:42:56] yep [18:43:11] so that spatial search works even if GeoData is not set up locally [18:43:30] * aude nods [18:44:14] (03CR) 10Aude: [C: 032] Fix dumpJson class not found fatal [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165777 (https://bugzilla.wikimedia.org/71871) (owner: 10Aude) [18:44:20] [13Number] 15JeroenDeDauw created 06041 (+1 new commit): 02http://git.io/rLjqsg [18:44:20] 13Number/06041 14798637c 15jeroendedauw: Allow installation with DV 1.x and bump to 0.4.1 [18:46:18] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf1/ff54614 : Thiemo Mättig The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/37528197 [18:46:42] yay, travis is unbroken today [18:53:33] aude: you mean the Wikibase build on Travis? The service itself seems to be more reliable than WMF Jenkins [18:54:00] (03Merged) 10jenkins-bot: Fix dumpJson class not found fatal [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165777 (https://bugzilla.wikimedia.org/71871) (owner: 10Aude) [18:54:04] (03CR) 10Jeroen De Dauw: [C: 04-1] "> Needed by "Factor connection management into separate class."" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [18:56:51] JeroenDeDauw: not always, not the last wikidata build [18:57:03] usually works well though [18:58:32] [13Validators] 15JeroenDeDauw created 06012 (+1 new commit): 02http://git.io/I5XIEQ [18:58:32] 13Validators/06012 1480cbe6f 15jeroendedauw: Make installable with DV 1.x and bump to 0.1.2 [19:01:17] [13Time] 15JeroenDeDauw created 06061 (+1 new commit): 02http://git.io/7FW-UQ [19:01:17] 13Time/06061 142db8fb0 15jeroendedauw: Make installable with DV 1.x and bump to 0.6.1 [19:01:42] (03PS1) 10Aude: Update Wikidata, fix for dumpJson and ParserAfterParse handler [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165786 [19:05:07] [13Iri] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/6uytMg [19:05:07] 13Iri/06master 1420a6d8d 15Marius Hoch: Specify 'license-name' => 'GPL-2.0+' for MediaWiki [19:08:58] !merge | Thiemo_WMDE [19:08:58] Thiemo_WMDE: merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c// [19:09:03] !m | Thiemo_WMDE [19:09:03] Thiemo_WMDE: $2 merge merge merge MERGEEEEEEEEEEEEE [19:09:08] rage [19:09:20] waiting for the tests... [19:09:30] I ran all of the tests already [19:09:47] [13Time] 15thiemowmde 04deleted 06061 at 142db8fb0: 02http://git.io/Rb_XQA [19:10:32] [13Validators] 15thiemowmde comment on pull request #2 1480cbe6f: Where did this 1.0.1 come from? 02http://git.io/V0gbWg [19:10:39] [13Validators] 15thiemowmde 04deleted 06012 at 1480cbe6f: 02http://git.io/EoZCmQ [19:10:44] JeroenDeDauw: fails: https://github.com/DataValues/Number/pull/11 [19:11:27] [13Geo] 15thiemowmde closed pull request #20: Make installable with DV 1.x and bump to 1.0.1 (06master...06101) 02http://git.io/Y1F8tw [19:12:06] [13Validators] 15JeroenDeDauw comment on pull request #2 1480cbe6f: That line was `### 0.1.1 (2014-03-27)` before, which was a typo that I fixed in this commit 02http://git.io/I7XaeQ [19:12:25] [13Validators] 15JeroenDeDauw tagged 060.1.2 at 06master: 02http://git.io/Nf7nxQ [19:12:36] Thiemo_WMDE: build passed https://travis-ci.org/DataValues/Number/builds/37529976 [19:12:45] Looks like Scrutinizer is just being broken [19:13:15] Ah [19:13:21] [13Number] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/of4sUQ [19:13:21] 13Number/06master 1437747f4 15thiemowmde: Merge pull request #11 from DataValues/041... [19:13:23] It's failing due to wrong @covers [19:14:49] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165786 (owner: 10Aude) [19:15:05] (03CR) 10Aude: [C: 032] Update Wikidata, fix for dumpJson and ParserAfterParse handler [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165786 (owner: 10Aude) [19:15:11] [13Number] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/9BQ7DQ [19:15:11] 13Number/06master 146b5da7b 15jeroendedauw: Fix @covers tags [19:15:25] [13Number] 15JeroenDeDauw tagged 060.4.1 at 06master: 02http://git.io/pQU-0g [19:16:11] [13Geo] 15JeroenDeDauw tagged 061.1.0 at 06master: 02http://git.io/3n8vaQ [19:17:01] Thiemo_WMDE: thnx [19:19:45] (03CR) 10Jeroen De Dauw: Cleanup EntityContentDiffView (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165700 (owner: 10Thiemo Mättig (WMDE)) [19:20:31] (03CR) 10Jeroen De Dauw: [C: 031] Remove unused destroy event from listview, improve destroy method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165181 (owner: 10Adrian Lang) [19:24:02] (03Merged) 10jenkins-bot: Update Wikidata, fix for dumpJson and ParserAfterParse handler [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/165786 (owner: 10Aude) [19:55:44] (03CR) 10Thiemo Mättig (WMDE): Cleanup EntityContentDiffView (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165700 (owner: 10Thiemo Mättig (WMDE)) [20:05:10] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06betterUnserialize from 14200bfbf to 14030d3c6: 02http://git.io/JJ5H0A [20:05:10] 13WikibaseDataModel/06betterUnserialize 14030d3c6 15Thiemo Mättig: Optimize all EntityId::unserialize [20:05:35] [13WikibaseDataModel] 15thiemowmde comment on pull request #222 14030d3c6: Done, see below. 02http://git.io/PEgv8w [20:11:06] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06betterUnserialize from 14030d3c6 to 148c2fe23: 02http://git.io/JJ5H0A [20:11:07] 13WikibaseDataModel/06betterUnserialize 148c2fe23 15Thiemo Mättig: Optimize all EntityId::unserialize [20:16:14] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06wbaliases from 14fc61c68 to 14ebb8e28: 02http://git.io/VRxeZg [20:16:14] 13WikibaseDataModel/06wbaliases 14ebb8e28 15Thiemo Mättig: Drop aliases in Wikibase main namespace [20:17:20] wmde/WikibaseDataModel/betterUnserialize/030d3c6 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseDataModel/builds/37536959 [20:21:46] [13WikibaseDataModel] 15thiemowmde created 06simplealiases (+1 new commit): 02http://git.io/VslCKw [20:21:46] 13WikibaseDataModel/06simplealiases 14605ef20 15Thiemo Mättig: Use full class names instead of aliases [20:22:31] [13WikibaseDataModel] 15thiemowmde opened pull request #223: Use full class names instead of aliases (06master...06simplealiases) 02https://github.com/wmde/WikibaseDataModel/pull/223 [20:24:13] wmde/WikibaseDataModel/betterUnserialize/8c2fe23 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37537460 [20:32:08] Lydia_WMDE: Do you think the broken (empty) json dumps should be deleted? [20:33:42] hoo: any way to recreate them? [20:34:14] Lydia_WMDE: I'll try to get Ariel to create a new one tonight... but that wont replace the old files, but generate a new one [20:34:19] as the file name is the current date [20:34:31] could be moved around/ symlinked though [20:34:43] ok [20:34:52] Well, probably not today [20:35:01] deploy is at 1am and Ariel is in Greek [20:35:18] and not sure other ops will dare to touch Wikidata stuffs... and I can't :S [20:35:20] can the new incremental dump include what should have been in them? [20:35:36] them = previous ones [20:35:37] We don't have (own) incremental dumps [20:35:56] oh right. so this is about the full ones? [20:35:59] xml? [20:36:12] json [20:36:12] ok [20:36:13] No, only json *should* be affect [20:36:17] if others are broken, well :S [20:36:34] then i think it is ok to get rid of the empty ones [20:37:03] I'm not in favor of doing further dumps unless we have permissions sorted out [20:37:07] this is just a pain [20:37:16] agreed [20:38:18] wmde/WikibaseDataModel/simplealiases/605ef20 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/37538428 [20:54:50] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06master: 02http://git.io/8hY7Zg [20:54:50] 13WikibaseDataModel/06master 141e9e703 15Bene*: Merge pull request #223 from wmde/simplealiases... [20:55:51] [13WikibaseQueryEngine] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/7PrAqQ [20:55:51] 13WikibaseQueryEngine/06master 14bab5082 15jeroendedauw: The methods in QueryStoreWriter now accept `EntityDocument` rather than just `Entity` [20:55:51] 13WikibaseQueryEngine/06master 14c106788 15thiemowmde: Merge pull request #122 from wmde/entitydoc... [20:56:09] Lydia_WMDE: hey, do you already have met the students for the bachelor project with contraints? [20:56:19] no [20:56:22] next week [20:56:30] (03PS14) 10Bene: [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 [20:56:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 (owner: 10Bene) [20:56:41] k, which university? [20:57:06] HSPI I think [20:57:27] HPI again, yeah [20:57:33] same professor [20:57:42] Oh... w/o the s :P [20:57:46] ;-) [20:58:09] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/Hbtvpg [20:58:09] 13WikibaseQueryEngine/06master 14d6fac82 15thiemowmde: Merge pull request #121 from wmde/ClaimList... [21:04:05] constraints? [21:04:19] legoktm: ? [21:04:27] [13:55:57] Lydia_WMDE: hey, do you already have met the students for the bachelor project with contraints? [21:04:35] Oh [21:04:47] do we ahve a link with an abstract or something? [21:04:49] Lydia_WMDE: ^ [21:05:45] the abstract is "make the constraint violations process work and better and make it easier to add sources" [21:06:12] hopefully includes a framework for checking against 3rd party databases [21:06:17] but we'll need to see [21:06:29]