[00:03:30] DanielK_WMDE: yes, before this one, I was able to add multiple properties without any problem. I don't understand why it hangs on this one in particular [01:42:19] (03PS1) 10Aude: Fix / use dieException in SetClaim [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164749 [01:42:39] Okki: that is https://bugzilla.wikimedia.org/show_bug.cgi?id=71479 which we are looking into [01:42:56] it helps to know specific item and property where this occurs [01:43:01] at least [05:59:15] (03CR) 10Amire80: "... I examined the code a bit more closely, and uls already is a conditional dependency." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164743 (owner: 10Ebrahim) [06:05:44] (03PS1) 10Amire80: Make descriptionview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 [06:06:31] (03PS3) 10Amire80: Make labelview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164743 (owner: 10Ebrahim) [06:06:41] (03PS2) 10Amire80: Make descriptionview match the appropriate language direction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 [06:07:39] (03CR) 10Amire80: "See also the follow up: Ic8e8a1fb0fd0ddcdd5a740248618d756856cdae9" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164743 (owner: 10Ebrahim) [07:36:39] [73651ae8] 2014-10-05 07:34:39: Fatal exception of type MWContentSerializationException [07:38:04] ^^ when trying to save this: https://www.wikidata.org/w/index.php?title=Q9358&action=edit&undoafter=156222333&undo=156222390 [07:40:21] > Exception from line 145 of /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/lib/includes/store/EntityContentDataCodec.php: SnaksSerializer can only serialize Snaks objects [07:40:28] no idea what that means. [07:41:12] https://www.wikidata.org/w/index.php?title=Q1048&action=edit&undoafter=152185825&undo=152188325 --> Unexpected non-MediaWiki exception encountered, of type "InvalidArgumentException" [07:48:07] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Uh, I can't merge here. :-)" [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164749 (owner: 10Aude) [07:49:50] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Cool. Henning?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164757 (owner: 10Amire80) [07:50:13] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Cool. Henning?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164743 (owner: 10Ebrahim) [07:56:44] hoi I forgot how to point directly at a date and time in a log [09:18:45] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Do browser tests pass?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164064 (owner: 10Adrian Lang) [09:21:20] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Uh. Sounds good. But I think I need to test this a bit more in-depth." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164307 (owner: 10Adrian Lang) [09:54:26] (03CR) 10Thiemo Mättig (WMDE): "I'm not sure what I should do here. In the current master I can not edit badges, no matter what I try. Not in the JS UI, not on the specia" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164058 (owner: 10Adrian Lang) [09:56:26] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Introduce wb.getMwApiForRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163845 (owner: 10Adrian Lang) [10:05:20] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Had a first quick look. Looks great. I would like to have a second look and a round of manual testing before I click +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [10:05:36] (03Merged) 10jenkins-bot: Introduce wb.getMwApiForRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163845 (owner: 10Adrian Lang) [11:12:07] https://www.mediawiki.org/wiki/Thread:Extension_talk:Wikibase_Client/Database_tables [13:00:25] (03PS1) 10Aude: Fix reference snaks handling in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164767 (https://bugzilla.wikimedia.org/71479) [13:06:45] (03PS2) 10Hoo man: UserLanguageLookup: Only return languages we support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164725 [13:07:53] (03CR) 10Hoo man: UserLanguageLookup: Only return languages we support (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164725 (owner: 10Hoo man) [13:08:08] (03CR) 10Hoo man: "Addressed Thiemo's comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164725 (owner: 10Hoo man) [13:09:29] (03PS3) 10Hoo man: UserLanguageLookup: Only return languages we support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164725 [13:13:07] * aude wants help with https://bugzilla.wikimedia.org/show_bug.cgi?id=71479 and https://bugzilla.wikimedia.org/show_bug.cgi?id=71519 [13:13:40] aude: Will look at stuff when back home (1 1/2 hour maybe) [13:13:40] hoo|train: ^ if you have time, enough internets etc. [13:13:43] ok [13:13:57] think i made progress on the first one but don't think that totally fixes it everywhere [13:14:11] but no my connection is to unstable over here [13:14:12] just trying to upload some stuff I wrote before [13:14:12] so much stuffs :S [13:14:17] * aude will be out later [13:14:21] yeah, i know [13:15:02] it's just weird that the bug happens only some of the time, so really hard to reproduce [13:15:35] Well, I can have a look at that also... [13:15:43] ok [13:15:51] if those are segfaults or out of time, they can happen depending on machine load [13:15:52] we know some places where it does happen now: https://bugzilla.wikimedia.org/show_bug.cgi?id=71479#c9 [13:16:02] could be [13:17:15] we captured some stuff in wikibase-debug.log (archived now) and documented in the bug [13:20:26] ok, will look at taht [13:21:35] thanks [13:21:42] i might be around later this evening [13:26:03] :) [13:26:20] * hoo|train will use connection soonish [13:26:21] :P [13:26:44] (03CR) 10Jeroen De Dauw: [C: 032] Fix reference snaks handling in ClaimHtmlGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164767 (https://bugzilla.wikimedia.org/71479) (owner: 10Aude) [13:31:13] aude: so the rest of the issues now fall into "sometimes goes wrong somewhere on WD or WP and we need to fix it"? [13:32:03] JeroenDeDauw: Well, more of: Our stuffs is to inefficient nowadays :S [13:32:33] JeroenDeDauw: for bug https://bugzilla.wikimedia.org/show_bug.cgi?id=71479, somewhere else i think there is an issue [13:32:43] did nto find exactly where yet [13:32:46] cu later ;) [13:32:59] Q183 is due to its size and inefficiency of handling that [13:33:11] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/P8_YIw [13:33:11] 13WikibaseDataModel/06master 146929bca 15jeroendedauw: Improve wording [13:33:20] i don't think the bugs are related [13:33:47] ugh, how big is Q183 anyway? (labels, statements, etc?) [13:34:10] it was 500k in the old serialization [13:34:24] someone added a description or such (tiny edit) [13:34:31] but that doubled the size of the blob [13:34:35] 998.020 bytes [13:34:38] https://www.wikidata.org/w/index.php?title=Q183&action=info [13:34:56] i don't think size is the only issue also [13:34:57] Yeah not surprising it doubles, that was clear this would happen if we switched the format [13:35:02] could be way the code handles it [13:35:24] after all, they edited it on sept 19 [13:35:34] Still, sending ~1MB to the client (browser) for a single page is insane [13:35:36] before data model 1.0 and i think it was 'ok' [13:35:53] it is! [13:36:02] aude: you think the performance issue is in WikibaseDataModel? [13:36:10] i don't know [13:36:24] probably many factors [13:37:06] aude: You can get the json, deserialize and reserialize it a few times and see how long it takes. I suspect not much time at all [13:37:33] (deserialize to the objects, not the array stuff) [13:39:55] lolwat 54 million queries https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/561 [13:40:43] back later this evening probably [15:04:59] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=71665 on items? [15:05:04] Or properties? [15:05:15] Well, or both [15:09:10] That's not a bug, that's a feature! :O [15:26:27] I like features of IE11 [15:27:33] Every IE is bad. :( [15:29:09] sjoerddebruin: Nah, they started improving a lot [15:29:21] the world isn't that easy (anymore) [15:29:25] * simple [15:29:43] If my site works in Safari, I can be sure that it's working correct in Chrome and Firefox. [15:29:48] I still need to test in IE. [15:30:01] sjoerddebruin: Would be great, if it were that way [15:30:15] but I saw bugs in all three (four) major browser engines [15:30:25] * annoying bugs [15:30:40] Like? [15:31:07] sjoerddebruin: Mostly rendering bugs [15:31:21] Hm [18:07:00] [13WikibaseInternalSerialization] 15thiemowmde pushed 1 new commit to 06reuse: 02http://git.io/7PSXpg [18:07:00] 13WikibaseInternalSerialization/06reuse 141006fb3 15Thiemo Mättig: Fix test [18:08:30] [travis-ci] wmde/WikibaseInternalSerialization/reuse/1006fb3 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/37119228 [18:47:56] uhm [18:47:56] https://www.wikidata.org/wiki/Property:P1547 [18:48:03] when I click edit [18:48:10] both save and cancel are grayed out [18:48:28] when I change sth save becomes active [18:48:28] cancel not [18:48:28] known? [18:49:08] lazowik: Yes [18:49:20] fixed on master, will be backported [18:49:41] mhm [18:50:15] Yes, it's awful :S [19:43:12] (03PS13) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [21:21:24] aude: I just did the most horrible thing ever [21:21:26] but it worked [22:31:03] okay, why can't i find the discussion about the (rather large) interface changes lately? [22:31:31] Jhs: https://www.wikidata.org/wiki/Wikidata:UI_redesign_input [22:31:32] Jhs: https://www.wikidata.org/wiki/Wikidata:UI_redesign_input [22:31:36] lol [22:31:37] thanks :) [22:32:05] Even in that old version Q183 is still enormous [22:33:29] though that's not what i mean though.... i mean the thing that when you edit labels/descriptions for other languages than your primary language, you click edit once, so you can edit several at the same time, instead of editing each one individually [22:33:36] and the same with sitelinks [22:34:02] Jhs: it's intermediate steps to getting us to the stuff on that linked page [22:34:07] right [22:34:17] it's not always an improvement atm [22:34:18] That was a widely requested feature... I'm sure you can find discussion about it [22:34:22] I just don't have anything at hands [22:34:26] for me it's very buggy though [22:34:33] but there are a few dependencies that make it hard to not do that intermediate step [22:34:41] and yes - we need to fix bugs in it ;-) [22:34:46] i get edit conflicts with myself if i try to edit more than one thing at the same time :s [22:34:58] :S [22:35:01] we've already fixed a few but the edit conflict one is one of the remaining ones [22:35:05] it is in bugzilla already [22:35:12] Ok... am I CCed? [22:35:18] let me check [22:35:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=71555 [22:35:51] you are now [22:36:17] seems like the frontend wants me to edit more things simultaneously, while the backend still does it one-by-one [22:37:19] but well, since you're aware of it then it's a-okay i guess ;) [22:37:30] yeah [22:37:34] will be fixed [22:39:03] also, probably a different issue, but the icon for badges are the same for good and featured articles now, but they used to be different [22:39:35] got a link to an item where this shows? [22:39:43] what [22:39:45] gimme 2 secs [22:39:47] That one is new to me [22:41:10] https://www.wikidata.org/wiki/Q8752 [22:41:19] dewiki is featured, nowiki is good [22:41:23] both are marked as such [22:41:30] the icons used to be gold/silver, now both are blue [22:42:24] * Lydia_WMDE looks [22:42:37] should i file a bug for it? [22:42:39] I see [22:42:49] Jhs: yes please [22:42:54] this is indeed wrong [22:42:58] probably a config issue [22:43:11] that's the fallback [22:43:15] or that yeah [22:43:18] I guess CSS gone awry/ missing partly [22:43:28] *nod* [22:43:30] if it's obvious I'll fix it now, but probably not [22:43:31] either way [22:43:34] please file bug :) [22:43:40] Of course :) [22:43:53] WikiataClient or wikidataRepo? [22:43:56] repo [22:43:57] repo [22:47:19] https://bugzilla.wikimedia.org/show_bug.cgi?id=71684 [22:47:28] thx Jhs [22:47:29] i'm not very good at titling bugs... :P [22:50:56] what is this Phabricator thing.... why do they keep changing the things i'm used to. /me is old and grumpy at age 26 [22:52:15] nobody needs to understand [23:02:04] Lydia_WMDE: I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=71685 [23:03:00] legoktm: thx. (i hadn't forgotten ;-)) [23:03:18] and with that i go to bed [23:03:21] :) [23:03:21] good night :) [23:03:24] good night!