[00:25:03] that date thing might be because something is trying to adhere to ISO-8601 [00:25:28] cos 1882-00-00 is not a valid date in that format [06:20:34] (03CR) 10Henning Snater: Introduce wb.getMwApiForRepo (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163845 (owner: 10Adrian Lang) [07:17:33] (03CR) 10Henning Snater: "I reminded myself of that we actually do not want to use editentity in every case. For example, when setting site links: Setting multiple " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [07:43:37] [13WikibaseDataModel] 15thiemowmde 04deleted 06hasharray at 14f5775c1: 02http://git.io/0GkMKQ [07:50:08] [13WikibaseDataModelJavascript] 15snaterlicious pushed 1 new commit to 06fingerprint: 02http://git.io/-dQ-7Q [07:50:09] 13WikibaseDataModelJavascript/06fingerprint 14569ed38 15snaterlicious: Added image of data model diagram to README [08:19:30] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think there is a mistake, see comments." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162859 (https://bugzilla.wikimedia.org/69739) (owner: 10Lucie Kaffee) [08:30:40] (03CR) 10Thiemo Mättig (WMDE): "I can reproduce the issue locally." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163832 (owner: 10Hoo man) [08:41:51] (03CR) 10Thiemo Mättig (WMDE): "I agree with Jeroen, see comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159784 (owner: 10Bene) [08:54:45] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Almost +2, just some typos and questions." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [09:09:49] [13WikibaseQueryEngine] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/lPKeIA [09:09:49] 13WikibaseQueryEngine/06master 14dd6660a 15thiemowmde: Merge pull request #118 from wmde/exception... [09:19:47] [13WikibaseQueryEngine] 15thiemowmde comment on pull request #119 14e5e1ef3: I wonder why the `$dvHandler` is manipulated after it was used. Sure, doesn't make a difference, but makes reading the code a bit odd. 02http://git.io/pSDAUw [09:20:51] [13WikibaseQueryEngine] 15thiemowmde closed pull request #119: Simplify methods in DescriptionMatchFinder (06master...06desc) 02http://git.io/opCwWQ [09:24:56] (03CR) 10Daniel Kinzler: Example for WikibaseTextForSearchIndex hook (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [09:27:55] aude: JeroenDeDauw: DanielK_WMDE: no daily, as there is the presentation of the annual plan and this will still take time [09:28:13] oh, i thought that was going to start at 12:00 [09:28:51] ah, 10-12. got that wrong, then [09:41:15] (03PS12) 10Daniel Kinzler: Record usage info from ParserOutput to the database. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162650 (https://bugzilla.wikimedia.org/64589) [09:42:44] (03CR) 10Springle: Introduce usage tracking service. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [09:43:29] (03CR) 10Springle: "Responded on patch set 9 comment thread." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [09:46:19] (03PS2) 10Daniel Kinzler: Example for WikibaseTextForSearchIndex hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 [09:55:15] no daily???? [09:57:43] aude: no, big meeting going on, see tobi's message earlier [09:57:49] rage ;) [09:59:29] (03CR) 10Thiemo Mättig (WMDE): "Say, am I allowed to merge this?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [10:00:01] (03CR) 10Daniel Kinzler: "sure, why not?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [10:00:24] DanielK_WMDE: do you remember which api module has the dispatch stats? [10:00:31] * aude thought we had that [10:01:16] gah, found it.... implemented entirely via (and in Wikibase.hooks.php) [10:02:16] but ctrl+f 'dispatch' https://www.wikidata.org/w/api.php don't see it [10:04:20] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Example for WikibaseTextForSearchIndex hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [10:05:30] Lydia_WMDE: http://gyazo.com/d487a59329fd335fb53a1e443629238a [10:06:30] https://www.wikidata.org/w/api.php?action=query&meta=siteinfo&siprop=statistics&format=json [10:06:43] well-hidden [10:07:37] yea... it makes sense to have the dispatch stats there, but they are hard to find that way [10:08:52] (03PS17) 10Tobias Gritschacher: Update ApiModules to conform to api conventions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162859 (https://bugzilla.wikimedia.org/69739) (owner: 10Lucie Kaffee) [10:13:01] (03CR) 10Springle: [C: 031] "+1 with bug 71498" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [10:14:24] (03Merged) 10jenkins-bot: Example for WikibaseTextForSearchIndex hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [10:19:36] (03PS14) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) [10:21:54] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=71479 if you like to help look into htis [10:21:57] this* [10:22:26] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06multilingualunserializer: 02http://git.io/2JKRFw [10:22:26] 13WikibaseSerializationJavaScript/06multilingualunserializer 14e9c585e 15snaterlicious: Updated EntityIdSerializer/Deserializer [10:22:49] aude: is this under hhvm? [10:23:07] how to reproduce? [10:23:19] my first guess is yet another issue with class_alias [10:24:12] we don't have hhvm on wikidata [10:24:20] i assume this is wikidata and not test.wikidata [10:25:01] how to reproduce, no idea but looks like it can happen in multiple ways based on stack traces [10:25:09] or with setclaim [10:25:12] ah, this is from the live error log [10:25:24] that wasn't clear from the bug report [10:26:30] aude: the two exceptions are completely different, but both point to "snaks that are not snaks" being encountered. [10:26:32] [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06multilingualunserializer: 02http://git.io/2vPXUQ [10:26:32] 13WikibaseSerializationJavaScript/06multilingualunserializer 14e04c69a 15snaterlicious: Adapt function names of latest JavaScript data model design [10:26:36] mw1196 wikidatawiki that's an api server [10:26:37] but this only happens sometimes? [10:26:49] as is the other one [10:26:56] sometimes, no idea [10:27:07] it's not completely spamming the logs and no one has complaiend yet [10:27:20] * aude can try setclaim [10:28:26] aude: hypothesis: new code hitting an entity cached by old code, or vice versa. [10:28:40] that would be odd [10:28:44] we really need to stop putting objects into memcached. damn. so convenient. [10:28:46] but possible [10:28:51] we change the cache key [10:28:58] each deploy, so shouldn't be old objects [10:28:59] yes, that helps [10:29:11] unless they are cached somewhere else [10:29:29] we even bumped parser cache epoch [10:29:39] aude: the cache is sahared betwen repo and client. should still work iof each uses the correct cache key prefix, but still... [10:29:49] no [10:29:52] PC shouldn't be the issue here [10:29:59] not across versions of wikibase / core [10:30:21] would be shared with wikivoyage now but not wikipedia (e.g.) [10:36:03] uncaught TypeError: Cannot read property 'disable' of undefined [10:36:17] line 368 of jquery.wikibase.entityview.js [10:36:39] http://pastie.org/9609881 [10:41:24] Lydia_WMDE: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#BadMethodCallException is possibly related to [10:41:27] https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#BadMethodCallException [10:41:36] which we have a workaround now, shouldn't happen now [10:41:46] if you want to ask if it still happens [10:42:58] (03PS1) 10Adrian Lang: Make entityview work with Properties again [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164042 [10:43:11] ^ aude Lydia_WMDE [10:47:04] Adrian_WMDE: \o/ [10:47:37] Tobi_WMDE_SWE: Prowser ptests phor properties, pretty please :=) [10:48:11] Adrian_WMDE: by yesterday, I assume [10:48:28] That would have saved us this instance of bugs deployed [10:49:03] Adrian_WMDE: REVIEW!!! https://github.com/wmde/WikidataBrowserTests/pull/11 [10:49:12] we can have the same for a property [10:49:33] will create a separate task for it [10:49:58] Thanks :) [10:51:01] !m | Adrian_WMDE [10:51:01] Adrian_WMDE: $2 merge merge merge MERGEEEEEEEEEEEEE [11:04:07] JeroenDeDauw: you there? [11:05:27] aude: Maybe you can help me … I'm trying to get an EntityId parsed via API: http://localhost/api.php?action=wbparsevalue&format=json&parser=wikibase-entityid&values=Q1 [11:05:58] The value is an empty object, though, because Wikibase\DataModel\Entity\ItemId is json-encoded to an empty object [11:06:09] I wonder how that works for other values [11:06:19] huh [11:07:52] Adrian_WMDE: that sounds very broken. why is ItemId encoded as an empty object? [11:08:43] Dunno how json_encode works with objects [11:09:12] aude: the best i can think of re the SnakList issue is to make the error more informative. HashArray::setElement should include the actual class of the object in the error message [11:09:20] Adrian_WMDE: json_encode should never engounter an EntityId [11:09:27] if it does, something is horribly broken [11:09:37] What should it encounter? [11:09:42] EntityIdValue? [11:09:57] Array structures generated by our "Serializer" classes [11:10:24] it'S always objects -> arrays -> json. objects -> arrays is done by "serializers". [11:10:41] (they should be called Arrayalizers, but whatever) [11:11:18] Ah, I see [11:11:20] For time that works [11:11:24] for wikibase-entityid, it does not [11:11:50] Will investigate, thanks [11:12:37] Ah, it's pretty easy [11:12:58] api/ParseValue only calls getArrayValue() on DataValue instances (makes sense) [11:13:18] But the EntityIdValueParser returns an EntityId [11:13:23] so it wouldn't work on EntityId, but on EntityIdValue [11:13:32] o_O [11:13:49] that's a bug. [11:14:27] it's simply missing the code to wrap the EntityId [11:14:29] The parser should wrap [11:14:32] holy crap, how long has that been there? [11:14:32] yeha [11:14:52] actually, even the documentation sais it's returning the wrong thing. [11:15:13] Adrian_WMDE: EntityId used to be a DataValue at some point. I guess this was forgotten when we changed that [11:15:27] strange that we never noticed so far o_O [11:15:31] 80edaca54dab9700307f21cd8ccc4e5fd4333374 [11:15:31] (03CR) 10Aude: [C: 032] "we probably should have a propertyview or something, but this works for now" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164042 (owner: 10Adrian Lang) [11:15:57] DanielK_WMDE: You renamed the parser from EntityIdParser to EntityIdValueParser without touching the code :P [11:16:10] oooo [11:16:30] Well, not without touching the code, but without fixing that part [11:16:42] eeek! [11:16:52] want to fix it, or shall i? [11:16:59] I can do it [11:17:35] (03PS1) 10Aude: Make entityview work with Properties again [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164046 [11:23:50] (03PS1) 10Adrian Lang: Return an EntityIdValue in EntityIdValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164047 [11:24:03] ^ DanielK_WMDE I'd wait for the unit tests :) [11:24:39] Adrian_WMDE: well, at least6 EntityIdValueParserTest needs to check for the correct return type... [11:25:23] (03CR) 10Daniel Kinzler: [C: 04-1] "EntityIdValueParserTest needs to be adjusted appropriately" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164047 (owner: 10Adrian Lang) [11:25:39] Seems obvious [11:30:04] (03Merged) 10jenkins-bot: Make entityview work with Properties again [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164042 (owner: 10Adrian Lang) [11:31:00] (03PS2) 10Adrian Lang: Return an EntityIdValue in EntityIdValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164047 [11:48:39] gah, now i have to again remember how to "correctly" make pull requests for github stuff installed via composer. [11:49:52] ...or run tests on them, ick [11:51:09] DanielK_WMDE: feel free to +2 [11:51:20] composer install --prefer-source [11:54:23] [13WikibaseDataModel] 15brightbyte created 06ImproveHashArrayTypeErrorMessage (+1 new commit): 02http://git.io/_YPAGg [11:54:23] 13WikibaseDataModel/06ImproveHashArrayTypeErrorMessage 142f05015 15daniel: Show better error for "wrong" objects in HashArray... [11:54:35] [13WikibaseDataModel] 15brightbyte opened pull request #215: Show better error for "wrong" objects in HashArray (06master...06ImproveHashArrayTypeErrorMessage) 02http://git.io/ffQRmg [11:55:03] Adrian_WMDE: was waiting for jenkins. [11:55:30] aude: but then you still can't run unit tests. "You need to install this package with Composer before you can run the tests" [11:55:37] jenkin's there [11:55:41] and i had to dig up the right push syntax [11:56:04] (03CR) 10Daniel Kinzler: [C: 032] Return an EntityIdValue in EntityIdValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164047 (owner: 10Adrian Lang) [11:56:15] Adrian_WMDE: how come we were not using thisw before? [11:56:21] i mean, this *never* worked right... [11:56:40] aude: https://github.com/wmde/WikibaseDataModel/pull/215 [12:02:37] DanielK_WMDE: EntityId parsing happened on the client [12:03:58] DanielK_WMDE: do it, install with composer [12:04:09] (03Merged) 10jenkins-bot: Return an EntityIdValue in EntityIdValueParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164047 (owner: 10Adrian Lang) [12:04:50] aude: again? so i get a vendor dir inside the vendor dir? do we need to go deeper?... [12:05:09] you do [12:05:12] you can delete it again [12:05:20] bah. [12:05:26] this ain't pretty. [12:05:45] * aude nods [12:05:55] hahaha! but it has a rainbox nyancat animation ^_^ [12:06:00] err, rainbow [12:06:00] [travis-ci] wmde/WikibaseDataModel/ImproveHashArrayTypeErrorMessage/2f05015 : daniel The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/36763051 [12:06:01] :D [12:06:40] the pull request looks fine though i might need to hack into the build so we don't have to deal with making a release [12:07:36] yea, i was afraid that would be the case. fun times. [12:07:37] [13WikibaseDataModel] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/6InyXw [12:07:37] 13WikibaseDataModel/06master 145875353 15Katie Filbert: Merge pull request #215 from wmde/ImproveHashArrayTypeErrorMessage... [12:07:56] it's not the only place the issue is occurring, also [12:08:12] aude: what about the serialization issue? do we at least have a quick fix for that now? [12:08:13] * aude cannot reproduce it via api [12:08:20] ? [12:08:32] aude: antity caching / hhvm [12:08:35] *entity [12:08:39] did that yesterday [12:08:42] * DanielK_WMDE is keyboardly challanged today [12:08:54] we split the cache based on hhvm or not [12:09:14] aude: but we still doin't know what is actually wrong... [12:09:23] and we still die if we get invalid data back from memcached [12:09:39] i think we should be more robust against that [12:09:48] might poke at this tonight [12:09:51] * aude cringes [12:10:10] we also put a try catch but it's a bit evil [12:10:30] oh, that went in? got a link? [12:10:41] as long as it logs & makes tests fail, it should be ok [12:10:45] best solution might be to handle serialization ourselves (e.g. to json) [12:10:52] for entity revision [12:10:53] yes, we should do that anyway [12:11:00] for everything, really. [12:11:01] though i'd also like to know what exactly the issue with hhvm is [12:11:08] yea. [12:11:25] * aude notes the current serialization is very verbose etc. [12:11:35] and brittle [12:11:36] caching json would best be done by pushing the caching down one level. may need refactoring / introduction of a raw data storage layer [12:11:42] yep [12:11:52] that way, we could cache the json without re-serializing all the time [12:12:25] otoh... maybe not qorth the pain. we only re-serialize after loading. the happy path will always have to desierialize once, one way or the other [12:12:39] happy = cache hit, in this case [12:12:40] (03PS1) 10Adrian Lang: Parse EntityIds via API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164053 [12:14:01] (03CR) 10Daniel Kinzler: "Yay, killing a special case! No idea about the details, though." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164053 (owner: 10Adrian Lang) [12:14:17] ok folks, gtg [12:17:04] (03PS4) 10Adrian Lang: Introduce wb.getMwApiForRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163845 [12:17:09] (03CR) 10Adrian Lang: Introduce wb.getMwApiForRepo (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163845 (owner: 10Adrian Lang) [12:23:02] aude: I want to merge https://www.wikidata.org/wiki/Q16763911 with https://www.wikidata.org/wiki/Q13104574 so it can become a redirect, but I can't delete the sitelink on the first one. [12:23:14] And why is this even possible? [12:23:45] worked for me [12:23:59] * aude undo so you can try [12:24:15] nope, doesn't work [12:24:23] you have to click save [12:24:26] now [12:24:29] remove then save [12:24:54] wtf [12:25:02] that's so confusing [12:25:16] it's now like editing a section [12:25:35] * aude thinks takes getting used to [12:26:05] I don't like the deploy. [12:26:10] Everything is ugly now and confusing [12:26:12] :/ [12:26:18] it will get better [12:26:23] http://gyazo.com/d487a59329fd335fb53a1e443629238a [12:26:42] wtf [12:27:30] Adrian_WMDE: ^ [12:27:39] I can't see sitelinks without scrolling btw [12:27:45] the button overlaps the heading text [12:27:56] if the window is narrow enough and text long enough [12:28:16] damn [12:28:24] sjoerddebruin: do you want to make a bug for this [12:28:26] ? [12:28:34] I could do... [12:30:01] Wikidatarepo? [12:30:22] yes [12:34:45] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=71514 [12:34:57] thanks [12:37:30] (03PS5) 10Adrian Lang: Introduce entityChangers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 [12:38:04] (03CR) 10Adrian Lang: "Improved docs. Thiemo, hoo, can you review this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162555 (owner: 10Adrian Lang) [12:38:23] Talking about space wasting... http://gyazo.com/87ec0553175853f633a9efe6ba8e7240 [12:38:46] If Thiemo is in the office, can anyone make him join IRC? [12:39:25] ^ [12:39:28] XD [12:39:40] aude: Thanks :) [12:39:42] Thiemo_WMDE: hi [12:39:55] hi there. [12:40:13] I guess you saw the stuffs regarding our ask the developers session? [12:40:21] aude is waving elephants at me. whats going on? [12:40:49] hah [12:40:53] PHP elephants :) [12:40:54] w0t [12:41:10] which stuff exactly? i found some urgend emails i missed but my impression is everything is good now? [12:41:17] Thiemo_WMDE: Yep [12:41:34] Just wanted to make sure you are up with what happened ;) [12:41:41] When will you arrive there, btw? [12:41:48] * hoo was lazy and hasn't yet booked his train [12:42:01] do you think we need to preper something? i just wanted to sit there and listen and answer questions. [12:42:47] Not really, I'll just plug my notebook and open some resource that will/ might come in handy (like the etherpad, configuration stuffs, ...) [12:43:48] aude: About the sitelinks, it's weird that the row disappears and you still need to click save. People will think it's already done. [12:44:43] hoo: ok, cool. [12:46:15] (03CR) 10Aude: [C: 032] Make entityview work with Properties again [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164046 (owner: 10Aude) [12:51:51] (03PS1) 10Adrian Lang: Use $.when for promise handling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164058 [12:51:53] (03PS1) 10Adrian Lang: Use single API request for fetching multiple entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164059 [12:57:07] (03CR) 10Hoo man: "This is only needed for this single test, that's why I chose to not implement a generic setUp function." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163832 (owner: 10Hoo man) [12:58:35] (03Merged) 10jenkins-bot: Make entityview work with Properties again [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164046 (owner: 10Aude) [13:00:35] (03PS1) 10Aude: Add exception handling to SetClaim with log warning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164060 [13:00:59] DanielK_WMDE: hoo ^ probably for branch only [13:03:45] aude: Yep, looks very hackish [13:03:51] $entityId = $entity->getId() ? $entityId->getSerialization() : ''; 85 [13:03:51] [13:04:09] I think you mean to have: $entityId = $entityId ? $entityId->getSerialization() : ''; [13:04:12] if someone has better idea [13:05:29] yeah [13:06:43] (03CR) 10jenkins-bot: [V: 04-1] Use single API request for fetching multiple entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164059 (owner: 10Adrian Lang) [13:06:49] (03PS2) 10Aude: Add exception handling to SetClaim with log warning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164060 [13:06:55] i don't want to assume the entiyt has id though probably does [13:07:04] (03CR) 10Thiemo Mättig (WMDE): "This siteGroup lookup can't work in any test, right? Why not disable it for all tests? Just add a setUp, disable it and leave it disabled." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163832 (owner: 10Hoo man) [13:07:27] Thiemo_WMDE: The other tests mock everything... [13:07:40] the other tests are unit ones, this one is kind of an integration test [13:07:45] the borderline is blurry [13:07:46] we could instead add a log group for wikibase [13:07:52] debug* log [13:08:35] Wikibase seems to generic to me [13:08:49] why? [13:08:51] (03PS2) 10Adrian Lang: Use single API request for fetching multiple entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164059 [13:08:52] wikibase-warning or so might be ok [13:09:01] wikibase-debug [13:09:04] because that suggests that all our debug logging should be there [13:09:17] but for certain features (eg. change propagation) we have own deubg logs [13:09:24] (for a good reason) [13:09:29] hoo: it's a client setting, right? no other tests uses a client setting as far as i can see. [13:09:54] however, this is really trivial. don't make it more complicated. my suggestion should make it simpler, not more complicated. [13:09:55] hah, there already is 'wikibase' => "udp://$wmfUdp2logDest/wikibase" [13:10:14] and one for updateRepoOnMoveJob [13:10:31] I did the update repo one [13:10:35] the first one is awry [13:10:35] i know [13:10:38] is anything there? [13:10:47] it's not there [13:10:48] is anything logging to it, I mean [13:10:49] not used [13:10:54] we could use it [13:11:01] * hoo would suggest to rename it [13:11:03] only case by case, like this [13:11:06] ok :) [13:11:30] there's log for echo, centralauth, flow etc [13:11:44] Only for us 2? https://www.wikidata.org/wiki/Wikidata:Project_chat#problem_with_tools... [13:14:08] aude: Most of them are very spammy [13:14:16] yeah [13:14:24] i only want case-by-case to use it [13:14:58] (03PS3) 10Aude: Add exception handling to SetClaim with debug logging [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164060 [13:24:12] [13WikibaseInternalSerialization] 15filbertkm created 06evilclassalias (+1 new commit): 02http://git.io/7OxTkg [13:24:12] 13WikibaseInternalSerialization/06evilclassalias 1409f4d38 15aude: Don't use Statement class alias... [13:26:03] [13WikibaseInternalSerialization] 15filbertkm 04force-pushed 06evilclassalias from 1409f4d38 to 14d706ab1: 02http://git.io/1Cicqg [13:26:03] 13WikibaseInternalSerialization/06evilclassalias 14d706ab1 15aude: Don't use Statement class alias... [13:26:21] [travis-ci] wmde/WikibaseInternalSerialization/evilclassalias/09f4d38 : aude The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/36770004 [13:27:11] [13WikibaseInternalSerialization] 15filbertkm 04force-pushed 06evilclassalias from 14d706ab1 to 140ae7c6e: 02http://git.io/1Cicqg [13:27:11] 13WikibaseInternalSerialization/06evilclassalias 140ae7c6e 15aude: Don't use Statement class alias... [13:27:53] [13WikibaseInternalSerialization] 15filbertkm opened pull request #36: Don't use Statement class alias (06master...06evilclassalias) 02http://git.io/etQKLw [13:29:08] [travis-ci] wmde/WikibaseInternalSerialization/evilclassalias/d706ab1 : aude The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/36770194 [13:30:41] [travis-ci] wmde/WikibaseInternalSerialization/evilclassalias/0ae7c6e : aude The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/36770269 [13:31:44] [13WikibaseDataModelSerialization] 15filbertkm created 06evilclassalias (+1 new commit): 02http://git.io/fXkzWg [13:31:44] 13WikibaseDataModelSerialization/06evilclassalias 14e7f1e4e 15aude: Don't use Statement class alias... [13:32:29] [13WikibaseDataModelSerialization] 15filbertkm opened pull request #90: Don't use Statement class alias (06master...06evilclassalias) 02http://git.io/BgTBkg [13:33:30] [13WikibaseInternalSerialization] 15filbertkm 04force-pushed 06evilclassalias from 140ae7c6e to 147b2e046: 02http://git.io/1Cicqg [13:33:30] 13WikibaseInternalSerialization/06evilclassalias 147b2e046 15aude: Don't use Statement class alias... [13:33:42] [travis-ci] wmde/WikibaseDataModelSerialization/evilclassalias/e7f1e4e : aude The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/36770580 [13:33:47] omg, class alias is used everywhere in wikibase :( [13:34:32] Yep [13:34:34] [13WikibaseDataModelSerialization] 15thiemowmde closed pull request #90: Don't use Statement class alias (06master...06evilclassalias) 02http://git.io/BgTBkg [13:34:40] To man places :( [13:34:43] * many [13:34:49] gigantic patch coming [13:35:08] * aude sorry for any rebase hell it causes [13:44:29] (03PS1) 10Adrian Lang: Mark param as optional in documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164063 [13:45:18] (03CR) 10Hoo man: [C: 032] Mark param as optional in documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164063 (owner: 10Adrian Lang) [13:48:28] [13WikibaseInternalSerialization] 15thiemowmde 04deleted 06evilclassalias at 147b2e046: 02http://git.io/W0mFMA [13:53:30] (03PS1) 10Adrian Lang: Replace widgetBaseClass with widgetFullName [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164064 [13:56:06] (03PS1) 10Aude: Don't use Statement class alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164066 (https://bugzilla.wikimedia.org/71508) [13:58:17] (03PS2) 10Aude: Don't use Statement class alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164066 (https://bugzilla.wikimedia.org/71508) [14:03:40] (03Merged) 10jenkins-bot: Mark param as optional in documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164063 (owner: 10Adrian Lang) [14:04:17] (03PS1) 10Aude: Don't use EntityDiff and ItemDiff class aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164067 [14:06:38] [13WikibaseInternalSerialization] 15filbertkm created 06classalias (+1 new commit): 02http://git.io/CYFTOw [14:06:38] 13WikibaseInternalSerialization/06classalias 142e463bf 15aude: Don't use LegacyIdInterpreter class alias [14:07:44] [travis-ci] wmde/WikibaseInternalSerialization/classalias/2e463bf : aude The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/36773548 [14:10:19] Tobi_WMDE_SWE: action=query&meta=siteinfo&siprop=languages&format=json [14:10:53] Oh, another person fron SWE! [14:14:09] Thiemo_WMDE: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Allowed_languages_for_monolingualtext [14:35:35] (03PS1) 10Aude: Add exception handling to SetClaim with debug logging [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164076 [14:35:44] does anyone care ^ ? [14:35:54] idk [14:36:22] :P [14:36:27] Not sure how common the problem [14:36:29] * aude would likve to solve the bug [14:36:32] like* [14:36:39] mh [14:36:48] but can't reproduce the issue [14:36:49] but that's not the real solution, right [14:37:07] unless someone has other idea how to solve this [14:37:45] * aude also need https://github.com/wmde/WikibaseDataModel/pull/215 in [14:40:13] aude: uh... make a new relasee? [14:40:41] i'd rather not but that would be best [14:41:08] How would you avoid it? You could make a composer build from source and then cherry-pick it in [14:41:16] but that's insanely nasty [14:41:22] ok, not that bad... but bud [14:41:23] * bad [14:42:17] ugh [14:42:29] we have 1.0 in wikibase [14:42:34] 1.1 is released [14:42:45] i will have to cherry pick and make 1.0.1 [14:42:54] I guess so [14:46:27] https://github.com/wmde/WikibaseDataModel/tree/1.0.1 [14:46:29] [13WikibaseDataModel] 15filbertkm created 061.0.1 from 06master (+0 new commits): 02http://git.io/AU4WrA [14:46:39] gah [14:46:44] looks wrong [14:47:26] [13WikibaseDataModel] 15filbertkm 04deleted 061.0.1 at 145875353: 02http://git.io/w0Nacw [14:47:46] [13WikibaseDataModel] 15filbertkm created 061.0.1 (+2 new commits): 02http://git.io/ZIMD_A [14:47:46] 13WikibaseDataModel/061.0.1 14ed56e99 15daniel: Show better error for "wrong" objects in HashArray... [14:47:46] 13WikibaseDataModel/061.0.1 144bd23c2 15aude: Update release notes for 1.0.1 [14:47:47] we have 13 minutes to make a new build [14:48:02] if we want to have something for swat [14:48:17] should be enough [14:48:23] we can tell them to do us last [14:48:26] https://github.com/wmde/WikibaseDataModel/commits/1.0.1 look ok [14:49:20] [13WikibaseDataModel] 15mariushoch tagged 061.0.1 at 061.0.1: 02http://git.io/AU4WrA [14:49:27] yay [14:49:53] https://github.com/wmde/WikibaseDataModel/compare/1.0.0...1.0.1 [14:49:56] looks good :) [14:50:02] (03CR) 10Aude: [C: 04-2] "not for master" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164060 (owner: 10Aude) [14:50:16] https://gerrit.wikimedia.org/r/#/c/164076/ ? [14:50:46] (03CR) 10Hoo man: [C: 032] "Good enough for the branch" [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164076 (owner: 10Aude) [14:50:49] thanks [14:50:53] [travis-ci] wmde/WikibaseDataModel/1.0.1/5875353 : Katie Filbert The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/36777522 [14:51:14] huh [14:51:18] travis being to slow [14:51:25] that's the tag you deleted, I guess [14:51:29] yeah [14:51:30] that's why travis can't find it [14:51:39] we can delete it now [14:55:27] (03PS1) 10Aude: New deployment build, fix for editing properties and add api debugging [extensions/Wikidata] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164079 [14:55:31] aude: Ok, making the new build nw [14:55:39] got it^ [14:55:49] meh :P [14:56:15] * aude preparing to update submodule [14:57:22] 0oh dear [14:57:31] it's missing the last commit in wikibase [14:57:40] * aude impatient [14:58:50] (03CR) 10Tobias Gritschacher: "Updated the commit message. One issue left, see Thiemo's comment." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162859 (https://bugzilla.wikimedia.org/69739) (owner: 10Lucie Kaffee) [14:58:57] (03CR) 10Tobias Gritschacher: Update ApiModules to conform to api conventions (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/162859 (https://bugzilla.wikimedia.org/69739) (owner: 10Lucie Kaffee) [14:59:03] (03Merged) 10jenkins-bot: Add exception handling to SetClaim with debug logging [extensions/Wikibase] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164076 (owner: 10Aude) [14:59:45] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks good. I would like to dig into the doc of $.when a bit before merging this." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164058 (owner: 10Adrian Lang) [15:00:48] (03CR) 10Hoo man: "Ok, can you please merge this as is then? This test is nastily failing locally for me..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/163832 (owner: 10Hoo man) [15:01:01]