[04:52:12] [13WikibaseDataModel] 15Benestar comment on pull request #196 14a8b92f1: Still indentation issues 02http://git.io/FFlq3g [04:52:37] [13WikibaseDataModel] 15Benestar comment on pull request #196 14a8b92f1: Here as well 02http://git.io/sIqrVg [09:30:08] (03CR) 10JanZerebecki: "Shouldn't we put the function that is used in the hook in some class so it can be tested?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161268 (owner: 10Daniel Kinzler) [10:00:49] (03PS1) 10WikidataBuilder: New Wikidata Build - 19/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161436 [10:01:16] * aude rage! [10:01:24] ? [10:01:28] (03Abandoned) 10Aude: New Wikidata Build - 19/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161436 (owner: 10WikidataBuilder) [10:01:38] reeeeeeview https://github.com/wmde/WikidataBuildResources/pull/7 ! [10:04:56] aude: should I merge it? [10:05:07] yes :) [10:05:20] aude: looks good, didn't test it [10:05:26] would be nice to have it on beta during the weekend [10:05:42] if there are any issues with our new code [10:05:46] [13WikidataBuildResources] 15tobijat closed pull request #7: Autogenerate sharedCacheKeyPrefix setting (06master...06settings) 02http://git.io/WG_poQ [10:05:49] aude: done [10:05:50] \o/ [10:06:03] * aude makes new build [10:13:51] [13WikidataBuildResources] 15filbertkm created 06suggester at 14ea3a6a1 (+0 new commits): 02http://git.io/WZSyGA [10:16:08] (03PS1) 10Aude: New Wikidata Build - 19/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161441 [10:16:22] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 19/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161441 (owner: 10Aude) [10:16:29] bah [10:18:50] [13WikidataBuildResources] 15filbertkm 04deleted 06suggester at 14ea3a6a1: 02http://git.io/epLeCQ [10:20:22] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161436 (owner: 10WikidataBuilder) [10:20:39] :( [10:21:00] it's mwext-Wikidata-testextension, for one thing, not mwext-Wikidata-testextensions [10:25:08] [13WikidataBuildResources] 15filbertkm created 06suggester (+1 new commit): 02http://git.io/b1URLg [10:25:08] 13WikidataBuildResources/06suggester 14a8acb31 15aude: Fix entry point, property suggester and settings file generator [10:26:27] ls [10:26:31] gah [10:33:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161441 (owner: 10Aude) [10:39:00] [13WikidataBuildResources] 15filbertkm opened pull request #8: Fix entry point, property suggester and settings file generator (06master...06suggester) 02http://git.io/VuFS8w [10:47:42] aude:. merge? [10:51:17] (03CR) 10Aude: Initial rough spec for the usage tracking system [WIP] (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157682 (owner: 10Daniel Kinzler) [10:52:24] (03CR) 10Aude: Draft of subscription and tracking interfaces [WIP] (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [10:52:49] Tobi_WMDE_SWE: sure [10:52:56] i am doing new build [10:53:38] [13WikidataBuildResources] 15tobijat 04deleted 06suggester at 14a8acb31: 02http://git.io/NLeYFA [10:54:03] (03Abandoned) 10Aude: New Wikidata Build - 19/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161441 (owner: 10Aude) [11:03:02] is master broken? [11:04:15] aude: how? [11:04:47] http://rotemy.com/blog/img/Yoda.png [11:05:15] http://dpaste.com/341X7R4 [11:05:34] when running tests [11:05:41] lazowik: :D [11:06:23] aude: need to pull core [11:06:40] * aude did [11:06:52] i have suspicions [11:08:23] don' have failures before pulling [11:08:39] it's something that depends on global settings [11:08:42] and doesn't like mine [11:09:11] aude: which settings? [11:09:15] $wgLocalisationCacheConf [11:09:23] ah, don't have this [11:09:26] probably a core bug [11:09:50] i was looking at why messages don't appear on special:version for badges [11:10:17] we have a special version for badges? [11:10:21] yes [11:10:32] Special:Version/Badges? [11:10:36] https://www.wikidata.org/wiki/Special:Version [11:10:40] broken [11:10:54] the descriptions [11:10:58] ah, I see [11:11:09] localisation cache doesn't find them [11:11:24] anyway, i want to run tests :) [11:14:09] aude: rollback core [11:14:55] delete core :D [11:16:30] gah, i am confused [11:16:37] on version numbers [11:19:04] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/-cLPTw [11:19:05] 13WikidataBuildResources/06master 1444e2fe7 15Katie Filbert: fix confusion over property suggester version number... [11:19:27] still confused [11:20:23] aude: what is the version that does not work correctly? 1.2? [11:20:29] correct [11:20:35] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/Mpc9uQ [11:20:35] 13WikidataBuildResources/06master 14e7cccf9 15Katie Filbert: 1.1.2 is the correct tag for suggester, there is no 1.1.3 tag [11:20:37] i am confused between 1.1.2 and 1.2 [11:20:43] 1.1.2 is what we need now [11:21:00] aude: why did you specify 1.1.3 then? [11:21:05] confused [11:21:38] of course, maybe in next sprint we review the 1.2 changes and look at why tests fail [11:21:40] also just ~1.0.0 should work [11:21:46] i see performance issues [11:21:50] ok :) [11:22:19] äm, I mean ~1.1.0 [11:22:26] confused too now [11:22:35] i think it's ok now [11:23:14] except i get TransportExcption [11:25:24] huh, gmail and github unavailable???? [12:26:45] (03Draft3) 10Aude: New Wikidata Build - 19/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161445 [12:27:02] jenkins says yes! [12:39:31] aude: https://twitter.com/BlairJenkinsYes uhm… [12:41:19] :D [12:41:32] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06statements-on-properties from 14910a160 to 14f8b72fa: 02http://git.io/5Uw3Gg [12:41:32] 13WikibaseDataModelSerialization/06statements-on-properties 148ae42f3 15Jan Zerebecki: Implement serialization of statements on properties. [12:41:32] 13WikibaseDataModelSerialization/06statements-on-properties 14f8b72fa 15Jan Zerebecki: Implement deserialization of statements on properties. [12:42:34] [travis-ci] wmde/WikibaseDataModelSerialization/statements-on-properties/f8b72fa : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35726886 [12:42:39] [13WikibaseDataModelSerialization] 15JanZerebecki opened pull request #83: Statements on properties (06compose-EntitiySerializer...06statements-on-properties) 02http://git.io/MYYSIQ [12:43:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161445 (owner: 10Aude) [12:43:46] (03CR) 10Aude: [C: 032] ":D" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161445 (owner: 10Aude) [12:52:54] (03Merged) 10jenkins-bot: New Wikidata Build - 19/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161445 (owner: 10Aude) [13:12:13] [13WikidataBuilder] 15filbertkm created 06wikidata from 06master (+0 new commits): 02http://git.io/18hsxg [13:12:15] I'm looking to query wikiwdata for all entries that have an InChIKey property (http://www.wikidata.org/wiki/Property:P235) and then retreve the corresponding svg file representing the structure of that chemical along with the InChIKey value. I'm looking to use the Wikidata Toolkit. Whilst I've looked at a few examples with this code, I've still not grokked it. Any quick pointers on how to go about this would be really appreciated. [13:14:35] [travis-ci] wmde/WikidataBuilder/wikidata/2a0c0c5 : Marius Hoch The build passed. http://travis-ci.org/wmde/WikidataBuilder/builds/35729779 [13:17:01] [13WikidataBuilder] 15filbertkm pushed 1 new commit to 06wikidata: 02http://git.io/zxNKag [13:17:01] 13WikidataBuilder/06wikidata 14a30b397 15aude: Update wikidata build resources... [13:21:01] [13WikidataBuilder] 15filbertkm opened pull request #28: Update wikidata build resources (06master...06wikidata) 02http://git.io/bBKHFA [13:27:40] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 14a8b92f1: Ahhh, the evil things spread like a virus! 02http://git.io/xY73hw [13:37:38] aude: Has the PR you asked me about being merged? [13:37:44] I can't seem to find it anymore [13:38:01] (builder stuff) [13:38:03] tobi reviewed it [13:38:09] :) [13:38:19] there is https://github.com/wmde/WikidataBuilder/pull/28 to sync stuff [13:38:39] we have a new build merged and scap has run on beta [13:38:54] i'm trying to find out why it doesn't seem to update wikidata [13:39:08] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06reference_tests: 02http://git.io/xZAe8g [13:39:08] 13WikidataBrowserTests/06reference_tests 1434ecd19 15Tobias Gritschacher: Add browsertests for references [13:39:31] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Version [13:56:38] (03CR) 10Lucie Kaffee: "If I use PHPUnit_Framework_TestCase I get some weird MWException, e.g.: Unstub loop detected on call of $wgLang->getCode from Message::inL" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [14:06:21] (03PS1) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [14:15:14] (03CR) 10jenkins-bot: [V: 04-1] Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 (owner: 10Henning Snater) [14:27:59] (03PS2) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [14:28:29] (03PS4) 10Daniel Kinzler: Initial rough spec for the usage tracking system [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157682 [14:28:31] (03PS13) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 [14:35:39] (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [14:38:33] gah [14:38:35] * aude screams [14:39:19] beta brokw! [14:39:20] e [14:39:38] (03PS3) 10Henning Snater: Refactored toolbars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161453 [14:56:33] who wrote the code to integrate wikidata with lua? [15:16:44] (03PS9) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) [15:26:29] (03CR) 10Henning Snater: [C: 032] Let mw.Api handle params and token in RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 (owner: 10Adrian Lang) [15:35:29] (03Merged) 10jenkins-bot: Let mw.Api handle params and token in RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 (owner: 10Adrian Lang) [15:38:34] (03CR) 10Henning Snater: [C: 032] Make RepoApi.post private (rename to RepoApi._post) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 (owner: 10Adrian Lang) [15:46:12] (03PS4) 10Henning Snater: Move handling of remote APIs out of RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 (owner: 10Adrian Lang) [15:48:24] (03CR) 10Henning Snater: [C: 032] Move handling of remote APIs out of RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 (owner: 10Adrian Lang) [15:54:05] (03PS10) 10Henning Snater: Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [16:04:17] (03Merged) 10jenkins-bot: Move handling of remote APIs out of RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 (owner: 10Adrian Lang) [16:14:26] (03CR) 10Henning Snater: Refactor EntityStore (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 (owner: 10Adrian Lang) [16:29:16] (03PS14) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 [16:33:16] (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [16:34:52] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #81 14c15d4cb: not correct 02http://git.io/Ru4k1Q [16:36:01] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06compose-EntitiySerializer: 02http://git.io/gmVaFA [16:36:01] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 14ced7cec 15Jeroen De Dauw: Update FingerprintSerializer.php [16:36:49] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/kP9ibw [16:36:49] 13WikibaseDataModelSerialization/06master 14125a933 15Jeroen De Dauw: Merge pull request #81 from wmde/compose-EntitiySerializer... [17:01:39] (03CR) 10JanZerebecki: [C: 032] Use checkboxes instead of multiselect to edit badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159103 (https://bugzilla.wikimedia.org/70333) (owner: 10Bene) [17:13:06] (03Merged) 10jenkins-bot: Use checkboxes instead of multiselect to edit badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159103 (https://bugzilla.wikimedia.org/70333) (owner: 10Bene) [17:24:53] (03PS15) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 [17:25:38] (03CR) 10Daniel Kinzler: [C: 04-2] "This is a prototype change, it's not intended to be merged as-is." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [17:29:29] (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [17:34:05] (03PS2) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 [17:35:27] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06statements-on-properties: 02http://git.io/ygvaAQ [17:35:27] 13WikibaseDataModelSerialization/06statements-on-properties 142212818 15Jeroen De Dauw: Update .travis.yml [17:35:37] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/09d69ad : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/35751499 [17:37:58] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06entitypatcher from 14a8b92f1 to 145a3cc3c: 02http://git.io/TGyIaw [17:37:59] 13WikibaseDataModel/06entitypatcher 14d7bbdf4 15WMDE-Fisch: added basic tests and entity-patcher documentation [17:37:59] 13WikibaseDataModel/06entitypatcher 1429cc462 15WMDE-Fisch: added basic entitypatcher test and implementation [17:37:59] 13WikibaseDataModel/06entitypatcher 14c5f2f19 15jeroendedauw: Move patching code out of Entity hierarchy into dedicated patchers [17:39:43] (03PS5) 10Daniel Kinzler: Initial rough spec for the usage tracking system [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157682 [17:39:45] (03PS16) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 [17:41:07] [travis-ci] wmde/WikibaseDataModelSerialization/statements-on-properties/2212818 : Jeroen De Dauw The build was fixed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35753381 [17:46:06] (03CR) 10jenkins-bot: [V: 04-1] Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (owner: 10Daniel Kinzler) [17:46:08] (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [17:47:20] DanielK_WMDE_, JeroenDeDauw: around? [17:47:44] HHVM is barfing a lot with the following two errors: [17:47:50] Fatal error: Argument 1 passed to Wikibase\RepoLinker::getEntityUrl() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given in /srv/mediawiki/php-1.24wmf21/extensions/Wikidata/extensions/Wikibase/client/includes/RepoLinker.php on line 173 [17:47:50] Fatal error: Argument 1 passed to Wikibase\EntityHandler::getTitleForId() must be an instance of Wikibase\EntityId, Wikibase\DataModel\Entity\ItemId given in /srv/mediawiki/php-1.24wmf21/extensions/Wikidata/extensions/Wikibase/repo/includes/content/EntityHandler.php on line 426 [17:48:03] aude figured out it's most likely a bug with class_alias() in HHVM [17:48:16] ori: yeah [17:48:17] As an interim strategy, could we work around the problem from now by dropping type annotations from the signatures of RepoLinker::getEntityUrl and EntityHandler::getTitleForId? [17:48:29] s/from now/for now/ [17:48:42] Better to just fix them [17:48:58] how much work would that take? [17:49:15] idk, having a look now [17:49:26] ori: but good idea for if it is to much work [17:49:44] cool. i'll submit a patch [17:49:57] we can even cherry-pick it to the prod branches but leave it unmerged on master [17:50:45] (03CR) 10jenkins-bot: [V: 04-1] Initial rough spec for the usage tracking system [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157682 (owner: 10Daniel Kinzler) [17:50:55] (thanks for looking) [17:51:05] ori: the RepoLinker looks easy to fix [17:51:40] EntityHsndler perhaps a bit less, though still looks manegable [17:51:50] ori: I'll have a go at this now and see if I get it fixed [17:52:21] JeroenDeDauw: Cool. I really appreciate it. [17:54:34] JeroenDeDauw: please have another look at https://gerrit.wikimedia.org/r/#/c/159515/ [17:57:03] DanielK_WMDE_: kk [17:57:31] (03PS1) 10Jeroen De Dauw: Move RepoLinker into Client namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 [17:57:49] (03PS1) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 [17:58:54] (03PS3) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/66586) [18:00:01] (03PS4) 10Daniel Kinzler: Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) [18:01:53] (03PS2) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 [18:01:59] (03PS3) 10Daniel Kinzler: Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) [18:04:16] (03CR) 10Jeroen De Dauw: Move SidebarBeforeOutput hook to SidebarHookHandlers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159515 (owner: 10Daniel Kinzler) [18:04:19] DanielK_WMDE_: ^ [18:06:42] (03PS2) 10Jeroen De Dauw: Move RepoLinker into Client namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 [18:06:44] (03PS1) 10Jeroen De Dauw: Improve docs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161488 [18:08:30] (03PS1) 10Ori.livneh: Drop type hints from signatures of of RepoLinker::getEntityUrl and EntityHandler::getTitleForId [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 [18:10:16] JeroenDeDauw: i'm also taking about the cohesion of the class. [18:10:17] JeroenDeDauw: I don't know my way around the codebase to be able to judge how risky "Move RepoLinker into Client namespace" would be to deploy. Would you be OK with the temp. workaround above for the weekend? [18:14:37] (03CR) 10Daniel Kinzler: Move SidebarBeforeOutput hook to SidebarHookHandlers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159515 (owner: 10Daniel Kinzler) [18:14:41] JeroenDeDauw: --^ [18:15:08] ori: Just reploying this without running the tests should definitly not be done [18:15:18] In fact, I have not run the tests myself and am waiting for Jenkins [18:15:41] JeroenDeDauw: i wasn't planning on that [18:15:56] JeroenDeDauw: i'm perfectly fine with waiting for you to have a look (and appreciate you doing so) [18:16:41] DanielK_WMDE_: you mentioned the "wikibase-otherprojects" key. This is only used in the method, so I don't see how that key is cohesive with the other code in the class. [18:16:45] ori: class_alias is just broken. we need to get rid of it. [18:16:50] *sigh* [18:17:00] JeroenDeDauw: read my comment [18:17:05] DanielK_WMDE_: I did [18:18:16] (03CR) 10jenkins-bot: [V: 04-1] Introduce usage tracking service. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161477 (https://bugzilla.wikimedia.org/64586) (owner: 10Daniel Kinzler) [18:18:19] JeroenDeDauw: that key comes from LangLinkHandler. i'm trying to concentrate the knowedge about these keys and structures. [18:18:53] it's not 100% yet, but since the SidebarHookHandlers class already has the knowledge about internals of LangLinkHandler, it seems sensible to continue that way [18:19:10] (03CR) 10Jeroen De Dauw: "This is not worse than before, and improves some stuff. I'm still rather dubious on the cohesion here, but go ahead if you're really inten" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159515 (owner: 10Daniel Kinzler) [18:19:18] eventually, I'd pull the logic for setting these fields out of LangLinksHandler (or dissolve that class alltogether) [18:19:20] (03CR) 10jenkins-bot: [V: 04-1] Collect usage tracking info in ParserOutput. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161487 (https://bugzilla.wikimedia.org/64588) (owner: 10Daniel Kinzler) [18:20:06] oh ffs [18:20:08] ... [18:20:12] JeroenDeDauw: i agree though that we have to take care that SidebarHookHandlers doesn't become another kitchen sink. It should really be restricted to stuff related to the sidebar. [18:20:21] Evil PhpStorm 8.0 is so buggy >_> [18:20:30] there is already a spin-off in the pipeline. [18:20:44] good thing i haven't updated yet, then :) [18:22:01] (03PS1) 10Jeroen De Dauw: Move EntityHandler and derivatives into Repo\Content NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161492 [18:23:49] (03CR) 10jenkins-bot: [V: 04-1] Move RepoLinker into Client namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 (owner: 10Jeroen De Dauw) [18:23:51] (03CR) 10jenkins-bot: [V: 04-1] Improve docs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161488 (owner: 10Jeroen De Dauw) [18:25:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [18:31:06] Just updated to 8.0.1, hope that helps [18:35:24] benestar: REVIEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEW [18:35:26] !review | benestar [18:35:26] benestar: https://bit.ly/wdrieview [18:35:30] huh [18:35:35] !r | benestar [18:35:35] benestar: https://gerrit.wikimedia.org/r/#/c// [18:35:37] JeroenDeDauw: hey :D [18:35:38] >_> [18:35:42] Who broke my commands?! [18:35:49] -.- [18:36:10] * JeroenDeDauw bets it was this evil aude person [18:38:24] ori: this fixes half of the problem: https://gerrit.wikimedia.org/r/#/c/161492/ [18:38:27] JeroenDeDauw: btw, the nyan cat phpunit output generator doesn't work for me :( [18:41:51] (03PS3) 10Jeroen De Dauw: Move RepoLinker into Client namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 [18:41:52] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06bypropertyidgrouper: 02http://git.io/QLqsuA [18:41:52] 13WikibaseDataModel/06bypropertyidgrouper 14df4d8ed 15Bene: Finish tests and add release notes [18:41:57] (03PS2) 10Jeroen De Dauw: Improve docs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161488 [18:42:08] benestar: wat [18:42:10] wat [18:42:12] wat [18:42:14] o_O [18:42:17] benestar: wtf??? [18:42:21] * JeroenDeDauw panics [18:42:30] JeroenDeDauw: evil windows console... [18:42:40] benestar: seriously? [18:42:45] JeroenDeDauw: -.- [18:42:54] (03CR) 10Ori.livneh: [C: 031] Move EntityHandler and derivatives into Repo\Content NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161492 (owner: 10Jeroen De Dauw) [18:43:06] benestar: I hope this does not prevent you from running the tests? [18:43:21] JeroenDeDauw: no but it is a bit hard to find the failures... [18:43:23] benestar: also, do file the issue here https://github.com/whatthejeff/nyancat-phpunit-resultprinter/issues [18:43:39] not an issue of the output generator [18:43:45] benestar: you can run "phpunit -c tests/phpunit.travis.xml" [18:43:47] the console does not support ANSI escape sequences [18:43:50] Then it won't use the nyan thing [18:43:58] great, thanks [18:44:07] * benestar would really like to see the nyan thing [18:44:22] benestar: you'll have to switch to Linux then :D [18:44:40] JeroenDeDauw: yes, will install it besides windows when I have time [18:44:46] * benestar never has time [18:47:44] (03CR) 10Bene: [C: 032] "More structure \o/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161492 (owner: 10Jeroen De Dauw) [18:48:24] JeroenDeDauw: now you ;) https://github.com/wmde/WikibaseDataModel/pull/199 [18:57:50] (03Merged) 10jenkins-bot: Move EntityHandler and derivatives into Repo\Content NS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161492 (owner: 10Jeroen De Dauw) [18:59:10] ori: other half: https://gerrit.wikimedia.org/r/#/c/161486/ [18:59:26] benestar: ^ mergeeeee [19:00:03] JeroenDeDauw: first you have to merge ;) [19:05:27] benestar: remove the WIP part then? [19:07:18] done [19:07:53] (03CR) 10Jeroen De Dauw: [C: 031] "The proper fix is both https://gerrit.wikimedia.org/r/#/c/161492/ and https://gerrit.wikimedia.org/r/#/c/161486/" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [19:08:20] benestar: https://gerrit.wikimedia.org/r/#/c/161486/ [19:08:21] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ieEeZA [19:08:21] 13WikibaseDataModel/06master 14fc5a158 15Jeroen De Dauw: Merge pull request #199 from wmde/bypropertyidgrouper... [19:11:05] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06pp (+1 new commit): 02http://git.io/17OWpQ [19:11:05] 13WikibaseDataModelSerialization/06pp 14d966b7d 15jeroendedauw: More clearly document package private [19:13:33] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06typednska (+1 new commit): 02http://git.io/Uxrd7Q [19:13:33] 13WikibaseDataModelSerialization/06typednska 14a4aa29a 15jeroendedauw: Added `newTypedSnakSerializer` to `SerializerFactory` [19:13:41] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #84: Added `newTypedSnakSerializer` to `SerializerFactory` (06master...06typednska) 02http://git.io/1-OjJg [19:14:48] [travis-ci] wmde/WikibaseDataModelSerialization/pp/d966b7d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35762406 [19:15:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9895198 : jeroendedauw The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/35761202 [19:16:05] benestar: you tricked me or what?! :<0 [19:16:37] sry, writing tests [19:16:49] benestar: ah, then all your sins are forgiven :D [19:17:18] [travis-ci] wmde/WikibaseDataModelSerialization/typednska/a4aa29a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35762605 [19:17:23] aude: resources for making a fresh WikidataBuild (as needed, update Wikidata branch in composer.json and run "composer install -o") [19:17:28] That is one weird repo description [19:18:08] (03CR) 10Bene: [C: 032] "Tests passed and changes look fine" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 (owner: 10Jeroen De Dauw) [19:18:27] \o/ [19:20:35] JeroenDeDauw: so, what do you think? I can push your changes to prod if you feel sufficiently comfortable with them. If we do that, I'll abandon my workaround patch. [19:21:16] JeroenDeDauw: but if you think the workaround is safer for a friday deploy, we can do that instead. Your call. [19:22:29] (03CR) 10Addshore: [C: 04-2] "Needs to be done in the Wikibase repo =]" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [19:24:37] ori: I do not know how much master and what is deployed diverge. Applying these patches to an older version is risky - there might have been another ref to the moved things, which then ends up not being updated [19:24:45] ori: something to ask aude though [19:25:06] (03CR) 10Addshore: [C: 032] Move RepoLinker into Client namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 (owner: 10Jeroen De Dauw) [19:25:21] >_> [19:25:28] (03CR) 10Addshore: [C: 032] Improve docs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161488 (owner: 10Jeroen De Dauw) [19:25:35] (03CR) 10Jeroen De Dauw: "Double +2 across the sky, OMG" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 (owner: 10Jeroen De Dauw) [19:25:55] (03CR) 10Ori.livneh: [C: 032] "+6!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 (owner: 10Jeroen De Dauw) [19:25:56] Silly addshore [19:26:15] :) [19:28:29] (03CR) 10Ori.livneh: "Could we merge this for now, and then revert it on Monday and deploy Jeroen's fixes?" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [19:29:20] (03CR) 10Addshore: "will removing this possibly break any third party scripts etc?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160650 (owner: 10Adrian Lang) [19:29:30] (03CR) 10Addshore: "will removing this possibly break any third party scripts etc?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160649 (owner: 10Adrian Lang) [19:30:27] (03Merged) 10jenkins-bot: Move RepoLinker into Client namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161486 (owner: 10Jeroen De Dauw) [19:35:15] (03Merged) 10jenkins-bot: Improve docs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/161488 (owner: 10Jeroen De Dauw) [19:37:55] JeroenDeDauw: aude is unresponsive, so I'm just going to drop the type annotations from the signatures for now, and we'll revert it on Monday and deploy your fix. Does that work? [19:47:10] (03PS1) 10Ori.livneh: Drop type hints from signatures of of RepoLinker::getEntityUrl and EntityHandler::getTitleForId [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161519 [19:47:40] (03PS1) 10Ori.livneh: Drop type hints from signatures of of RepoLinker::getEntityUrl and EntityHandler::getTitleForId [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161520 [19:48:31] (03CR) 10Ori.livneh: [C: 032] "Temp. fix; applied to release branches only." [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161519 (owner: 10Ori.livneh) [19:48:42] (03CR) 10Ori.livneh: [C: 032] "Temp. fix; applied to release branches only." [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161520 (owner: 10Ori.livneh) [19:59:18] [13WikibaseDataModel] 15Benestar pushed 5 new commits to 06beststatementfinder: 02http://git.io/vkKqjQ [19:59:18] 13WikibaseDataModel/06beststatementfinder 14f695626 15Bene: Create initial version of BestStatementFinder [19:59:18] 13WikibaseDataModel/06beststatementfinder 14001409f 15Bene: Use ByPropertyIdGrouper [19:59:18] 13WikibaseDataModel/06beststatementfinder 149fe2ee8 15Bene: Created tests [20:02:33] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06beststatementfinder: 02http://git.io/AkdyKA [20:02:33] 13WikibaseDataModel/06beststatementfinder 143cc83f7 15Bene: Rename BestStatementFinder to BestStatementsFinder [20:05:10] JeroenDeDauw: do you like https://github.com/wmde/WikibaseDataModel/pull/198 ? [20:06:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161519 (owner: 10Ori.livneh) [20:08:53] (03Merged) 10jenkins-bot: Drop type hints from signatures of of RepoLinker::getEntityUrl and EntityHandler::getTitleForId [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161519 (owner: 10Ori.livneh) [20:08:55] (03Merged) 10jenkins-bot: Drop type hints from signatures of of RepoLinker::getEntityUrl and EntityHandler::getTitleForId [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161520 (owner: 10Ori.livneh) [20:10:57] !r | JeroenDeDauw [20:10:57] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c// [20:11:12] !review | JeroenDeDauw [20:11:12] JeroenDeDauw: https://bit.ly/wdrieview [20:11:41] !gh-review [20:11:50] !github-review is [20:11:50] You are not authorized to perform this, sorry [20:11:56] :( [20:14:45] Successfuly added .*@wikimedia/Bene [20:14:45] @trustadd .*@wikimedia/Bene trusted [20:14:50] benestar: there :p [20:15:05] :D [20:15:29] (03CR) 10Ori.livneh: [C: 04-1] "I cherry-picked this on the production branches. Keeping this change for record-keeping purposes." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [20:17:07] !github-review is https://github.com/$1/#$2 [20:17:07] Key was added [20:17:15] !github-review WikibaseDataModel 190 [20:17:15] https://github.com/WikibaseDataModel/#190 [20:18:18] !github-review is https://github.com/wmde/$1/pull/$2 [20:18:18] This key already exist - remove it, if you want to change it [20:18:28] !remove github-review [20:18:32] !github-review is https://github.com/wmde/$1/pull/$2 [20:18:32] This key already exist - remove it, if you want to change it [20:18:35] !help [20:18:41] @remove github-review [20:18:44] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.1.0 [libirc v. 1.0.2] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [20:18:44] @help [20:19:26] !github-review unalias [20:19:31] !github-review is https://github.com/wmde/$1/pull/$2 [20:19:31] This key already exist - remove it, if you want to change it [20:20:05] !github-review remove [20:20:05] https://github.com/remove/#$2 [20:20:24] !github-review del [20:20:25] Successfully removed github-review [20:20:28] !github-review is https://github.com/wmde/$1/pull/$2 [20:20:28] Key was added [20:20:42] !github-review WikibaseDataModel 198 | JeroenDeDauw [20:20:42] JeroenDeDauw: https://github.com/wmde/WikibaseDataModel/pull/198 [20:21:09] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161520 (owner: 10Ori.livneh) [21:15:24] (03CR) 10Addshore: "On master this will just be overwritten at tomorrow! :)" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [21:16:08] (03CR) 10Addshore: "Both of Jeroen's fixes are merged :)" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [21:46:37] benestar: woha, you can have two arguments?! [21:46:47] benestar: that command is basically as long as the URL tho ;p [21:47:15] JohnLewis: you made benestar tusted?! AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAH [21:47:27] Wait... [21:47:34] That means JohnLewis is also trusted?! [21:47:38] *word explodes* [21:47:43] *world [21:47:46] JeroenDeDauw: I'm an admin iirc :p [21:47:51] I trust: .*@wikimedia/IWorld (2admin), .*@wikimedia/DangSunM (2admin), .*@quassel\.jefferai\.org (2admin), .*@unaffiliated/jeroendedauw (2admin), .*@wikipedia/Liangent (2trusted), .*@wikimedia/Vogone (2admin), .*@wikipedia/rschen7754 (2admin), .*@wikimedia/Hym411 (2admin), .*@wikimedia/John-F-Lewis (2admin), .*@wikidata/Lydia-Pintscher-WMDE (2admin), .*@wikipedia/Josve05a (2trusted), .*@wikimedia/Bene (2trusted), [21:47:51] @trusted [21:47:52] nooooo [21:48:09] JeroenDeDauw ^ there :p [21:48:13] :ö [21:48:48] benestar: huh, did I not already merge that?! [21:48:58] oh [21:49:00] ... [21:50:10] benestar: https://github.com/wmde/WikibaseDataModel/pull/198 [21:50:20] (03PS1) 10Ori.livneh: Drop additional type hints [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161595 [21:50:33] ofc [21:50:49] (03CR) 10Ori.livneh: [C: 04-1] "Another patch not meant for master." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161595 (owner: 10Ori.livneh) [21:51:12] (03PS1) 10Ori.livneh: Drop additional type hints [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161597 [21:51:21] (03CR) 10Ori.livneh: [C: 032 V: 032] Drop additional type hints [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161597 (owner: 10Ori.livneh) [21:51:40] (03PS1) 10Ori.livneh: Drop additional type hints [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161600 [21:51:46] (03CR) 10Ori.livneh: [C: 032 V: 032] Drop additional type hints [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161600 (owner: 10Ori.livneh) [21:52:58] JeroenDeDauw: done [21:53:08] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06beststatementfinder: 02http://git.io/i8WteQ [21:53:08] 13WikibaseDataModel/06beststatementfinder 1428daf47 15Bene: Move BestStatementsFinder into Statement namespace [21:55:55] benestar: You wanted me to finish this no? https://github.com/wmde/WikibaseDataModel/pull/196 [21:56:48] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #198: Create initial version of BestStatementsFinder (06master...06beststatementfinder) 02http://git.io/_tzT9Q [21:59:36] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #187 14beac925: Not sure what this index thing is used for. Suspect that was not in the original method. If we do not have an immediate use case, I prefer not having this in the function signature for now. 02http://git.io/N0OrRQ [22:01:00] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #187 14beac925: Big violation of Arrange Act Assert... 02http://git.io/sODnIw [22:04:10] [13WikibaseDataModel] 15Benestar comment on pull request #187 14beac925: basically copied from above and adjusted to the new methods... 02http://git.io/Z8KBSg [22:08:49] [13WikibaseDataModel] 15Benestar comment on pull request #196 145a3cc3c: Not a problem of this patch but we have to remember that this isn't very sane. EntityDiff should not know about claims. 02http://git.io/R_XBow [22:09:14] [13WikibaseDataModel] 15Benestar comment on pull request #196 145a3cc3c: too many new lines imo 02http://git.io/nFp3Rg [22:11:17] [13WikibaseDataModel] 15Benestar comment on pull request #196 145a3cc3c: this indexing should happen somewhere else, either in `StatementList` or in another class like `ByPropertyIdGrouper`. I think indexing by GUID can also happen in `StatementList` itself. 02http://git.io/JsweJg [22:12:26] [13WikibaseDataModel] 15Benestar comment on pull request #196 145a3cc3c: `Claim` in `StatementListPatcher`? o.O This should rather typecast against `Statement` to prepare for composition. 02http://git.io/Z6N6pA [22:12:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161595 (owner: 10Ori.livneh) [22:26:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf21) - 10https://gerrit.wikimedia.org/r/161597 (owner: 10Ori.livneh) [22:40:39] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf22) - 10https://gerrit.wikimedia.org/r/161600 (owner: 10Ori.livneh) [22:55:49] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 145a3cc3c: It should also not know about fingerprints. And the "claims" in the names here should be changed to "statements". That's an `EntityDiff` problem though, which is for another time. 02http://git.io/O1ba5A [22:56:42] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06entitypatcher: 02http://git.io/s1jrYw [22:56:42] 13WikibaseDataModel/06entitypatcher 1448de4da 15Jeroen De Dauw: Remove those evil newlines! [22:58:24] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 1448de4da: Right. This makes it quite plain that all I did was move code and clean it up. 02http://git.io/-2O6Tw [22:58:56] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06entitypatcher: 02http://git.io/J5DM4A [22:58:56] 13WikibaseDataModel/06entitypatcher 1412de0d9 15Jeroen De Dauw: Update StatementListPatcher.php [23:00:24] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #196 1412de0d9: This code actually needs an array. Also, even if this can perhaps be further improved, I do not want to add to this commit. This code is already simpler than it was before, when it was located in `Item` 02http://git.io/_eHaIg [23:00:46] benestar|cloud: thanks for the review! \o/ [23:15:39] !m | benestar|cloud [23:15:39] benestar|cloud: merge merge merge MERGEEEEEEEEEEEEE [23:15:49] ah, that's the command :) [23:26:04] [13WikibaseQueryEngine] 15JeroenDeDauw created 06dm1 (+1 new commit): 02http://git.io/XzFrsw [23:26:04] 13WikibaseQueryEngine/06dm1 1414097f9 15jeroendedauw: Make compatible with DataModel 1.0 [23:26:10] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #116: Make compatible with DataModel 1.0 (06master...06dm1) 02http://git.io/X74nTg [23:29:56] [travis-ci] wmde/WikibaseQueryEngine/dm1/14097f9 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35782159 [23:30:00] [13WikibaseQueryEngine] 15JeroenDeDauw created 06geo1 (+1 new commit): 02http://git.io/_YMIEA [23:30:00] 13WikibaseQueryEngine/06geo1 1483ba47f 15jeroendedauw: Switch to DataValue Geo 1.x [23:38:22] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mpdV0g [23:38:22] 13WikibaseQuery/06master 144db7268 15Jeroen De Dauw: Update README.md [23:38:54] [13WikibaseQueryEngine] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/YFu15A [23:38:54] 13WikibaseQueryEngine/06master 14183864e 15Jeroen De Dauw: Update README.md [23:44:01] [travis-ci] wmde/WikibaseQueryEngine/master/183864e : Jeroen De Dauw The build was broken. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/35782743