[00:24:00] <grrrit-wm>	 (03CR) 10Springle: "The two DB tables look sane and the access patterns logical, based on your email to wikitech-l." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler)
[03:11:39] <vlsergey>	 http://www.wikidata.org/w/api.php?action=wbgetclaims&entity=Q64
[03:11:42] <vlsergey>	 Exception Caught: Internal error in ApiFormatXml::recXmlPrint: (P1151, ...) has integer keys without _element value. Use ApiResult::setIndexedTagName().
[07:29:08] <grrrit-wm>	 (03CR) 10Adrian Lang: Refactor EntityStore (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 (owner: 10Adrian Lang)
[07:29:17] <grrrit-wm>	 (03PS2) 10Adrian Lang: Refactor EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 
[09:13:10] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 04-1] "As Jeroen said." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[09:13:37] <lazowik>	 hi :)
[09:30:40] <grrrit-wm>	 (03PS2) 10JanZerebecki: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[10:00:48] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 17/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160941 
[10:09:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 17/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160941 (owner: 10WikidataBuilder)
[10:11:26] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 031] Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[10:16:55] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160941 (owner: 10WikidataBuilder)
[10:17:52] <grrrit-wm>	 (03Abandoned) 10Aude: New Wikidata Build - 17/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160941 (owner: 10WikidataBuilder)
[10:54:11] <gh-wmde>	 [13WikidataBuildResources] 15filbertkm 04force-pushed 06settings from 1432a6c88 to 14b487cba: 02http://git.io/e4i1dA
[10:54:11] <gh-wmde>	 13WikidataBuildResources/06settings 14b487cba 15aude: Autogenerate sharedCacheKeyPrefix setting...
[10:54:35] <hoo>	 aude: Lydia_WMDE: FYI: Deploy yesterday went fine and monobook issues solved
[10:54:53] <aude>	 yay
[10:54:55] <Lydia_WMDE>	 \o/
[10:55:01] <aude>	 thanks for staying awake at 1am :)
[10:55:25] <gh-wmde>	 [13WikidataBuildResources] 15filbertkm opened pull request #7: Autogenerate sharedCacheKeyPrefix setting (06master...06settings) 02http://git.io/WG_poQ
[10:55:35] <hoo>	 :) Only had minor trouble getting up this morning... now after playing Badminton I'm more than awake :D
[10:55:40] <aude>	 :D
[10:56:55] <gh-wmde>	 [13WikidataBuildResources] 15filbertkm comment on commit 14b487cba: this is autoloaded via composer, so not needed to specify this explicitly here 02http://git.io/Z8cu4A
[10:57:37] <gh-wmde>	 [13WikidataBuildResources] 15filbertkm comment on commit 14b487cba: this is unused, as suggester is included unconditionally when repo is included 02http://git.io/55RsvA
[11:20:53] <hoo>	 uh, is property suggester using multi-field IN?
[11:21:04] <hoo>	 that's horribly slow in MySQL/ MariaDB :S
[11:37:21] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "Besides all this bikesheding, I found a real issue:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater)
[11:46:07] <aude>	 hoo|away: yes, it needs review and consideration regarding best approach
[11:46:18] <aude>	 for now we pin the build at the earlier version
[11:47:46] <jzerebecki>	 vlsergey: that is https://bugzilla.wikimedia.org/show_bug.cgi?id=70299
[11:52:33] <gh-wmde>	 [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06settings: 02http://git.io/4LB19A
[11:52:33] <gh-wmde>	 13WikidataBuildResources/06settings 14cd8def5 15aude: Add group, covers tags and more tests
[11:55:37] <gh-wmde>	 [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06settings: 02http://git.io/NEVzVg
[11:55:37] <gh-wmde>	 13WikidataBuildResources/06settings 1401fbb01 15aude: Pin property suggester version to 1.1.1
[11:55:55] <gh-wmde>	 [13Wikiba.se] 15jakob-WMDE pushed 1 new commit to 06master: 02http://git.io/jgIAxg
[11:55:55] <gh-wmde>	 13Wikiba.se/06master 14edb96aa 15Jakob Warkotsch: Add eagle project to 'projects'.
[11:59:14] <sjoerddebruin>	 aude: Is there any more news about the entity suggester? Has it already adapted the new serialization?
[12:40:03] <lol>	 hi
[12:40:07] <lol>	 :)
[12:40:22] <lol>	 ................
[12:46:44] <sjoerddebruin>	 Wow, let's hope that P735 will get a better position in the entity suggester. A lot of additions in the last few days.
[13:18:08] <gh-wmde>	 [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06sitelinkgroup_edit: 02http://git.io/Y3Agiw
[13:18:08] <gh-wmde>	 13WikidataBrowserTests/06sitelinkgroup_edit 14178fc3b 15Tobias Gritschacher: Added methods to get the webdriver object for certain elements
[13:21:02] <grrrit-wm>	 (03PS3) 10Adrian Lang: Refactor EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 
[13:27:19] <jzerebecki>	 sjoerdinstad: according to https://bugzilla.wikimedia.org/show_bug.cgi?id=70335 it is not yet updated
[13:45:23] <grrrit-wm>	 (03PS7) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) 
[13:45:58] <Henning_WMDE>	 Tobi_WMDE_SWE: ^
[13:49:34] <DanielK_WMDE_>	 https://github.com/wmde/graphcore
[13:54:59] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar)
[14:39:32] <grrrit-wm>	 (03PS3) 10Daniel Kinzler: Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 
[14:39:49] <grrrit-wm>	 (03PS3) 10Daniel Kinzler: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 
[14:41:07] <grrrit-wm>	 (03PS4) 10Daniel Kinzler: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 
[14:48:44] <JeroenDeDauw>	 Reedy: one more bug to +1: https://youtrack.jetbrains.com/issue/WI-24807 :)
[14:53:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[14:53:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[15:01:19] <grrrit-wm>	 (03PS4) 10Daniel Kinzler: Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 
[15:01:33] <grrrit-wm>	 (03PS5) 10Daniel Kinzler: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 
[15:38:36] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "@springle: transaction size directly depends on how many distinct entities are used on a given wiki page. Currently, this would be at most" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler)
[15:49:26] <gh-wmde>	 [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06sitelinkgroup_edit: 02http://git.io/YuIbRA
[15:49:26] <gh-wmde>	 13WikidataBrowserTests/06sitelinkgroup_edit 14c7897f7 15Tobias Gritschacher: Adjust sitelinks tests
[16:20:40] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 04-1] Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[16:24:17] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 04-1] "Should not contain code changes according to commit message. Needs to be updated for the changes in its dependency." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[16:31:16] <grrrit-wm>	 (03CR) 10JanZerebecki: Add hook to control text for search index. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[16:32:54] <grrrit-wm>	 (03CR) 10JanZerebecki: "(Forget about the code changes, that was only me being confused by the rebase.)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[16:39:41] <benestar>	 it's a hoo :D
[16:42:41] <grrrit-wm>	 (03CR) 10Daniel Kinzler: Add hook to control text for search index. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[16:43:22] <hoo>	 :)
[16:44:43] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 032] Add hook to control text for search index. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[16:45:02] <benestar>	 JeroenDeDauw: do we really need StatementList::getBestStatementPerProperty ?
[16:45:17] <JeroenDeDauw>	 benestar: we need the functionality
[16:45:35] <JeroenDeDauw>	 benestar: though it's in the same boat as the other method we talked about
[16:45:39] <benestar>	 -.-
[16:45:41] <JeroenDeDauw>	 getAllSnaks or something?
[16:45:49] <benestar>	 it makes StatementList quite complex...
[16:46:02] <JeroenDeDauw>	 I would not go that far
[16:46:06] <JeroenDeDauw>	 Though it moves into that direction
[16:46:28] <DanielK_WMDE_>	 JeroenDeDauw, benestar: it would also be very nice to have a way to get all statements about a given property.
[16:46:33] <benestar>	 perhaps we should make StatementList sorting its statements by property all the time7
[16:46:34] <JeroenDeDauw>	 benestar: if you find a good way to move it out
[16:46:39] <DanielK_WMDE_>	 let me forward an email i recently wrote to MaxSem about this
[16:47:00] * benestar will index statements by property
[16:47:06] <JeroenDeDauw>	 benestar: not in StatementList
[16:47:27] <benestar>	 JeroenDeDauw: maybe we will create a Statements interface and create two implementations
[16:47:31] <benestar>	 one with indexing and one without
[16:47:35] <JeroenDeDauw>	 err
[16:47:40] <JeroenDeDauw>	 No, that makes no sense
[16:47:47] <JeroenDeDauw>	 Just create a different list class
[16:47:54] <JeroenDeDauw>	 The methods it will have will be different
[16:48:14] <benestar>	 JeroenDeDauw: nope, it will also have addStatements and getStatements
[16:48:57] <JeroenDeDauw>	 benestar: are you talking about an interface that has just these two methods?
[16:49:12] <JeroenDeDauw>	 benestar: also note how StatementList does not have a public addStatements
[16:49:13] <benestar>	 JeroenDeDauw: something like the References interface
[16:49:42] <JeroenDeDauw>	 benestar: the References interface was created by me when I did not understand what interfaces are about
[16:50:00] <JeroenDeDauw>	 benestar: it adds less value to the system than it costs IMO
[16:50:03] <benestar>	 evil JeroenDeDauw ...
[16:50:13] * benestar ought to learn from Jeroen and now is confused
[16:50:18] <JeroenDeDauw>	 benestar: indeed. So you don't want to become evil benestar!
[16:50:31] <JeroenDeDauw>	 benestar: you can learn what not to do here :)
[16:50:38] <benestar>	 ^^
[16:51:12] <benestar>	 JeroenDeDauw: but why shouldn't we index statements by property ids all the time?
[16:51:18] <benestar>	 it doesn't cost that much imo
[16:51:37] <benestar>	 perhaps it even increases efficience
[16:53:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler)
[16:53:23] <JeroenDeDauw>	 benestar: there are several things by which one might want to index
[16:53:42] <benestar>	 but property ids are the most obvious ones
[16:53:56] <JeroenDeDauw>	 benestar: not sure
[16:54:01] <JeroenDeDauw>	 benestar: https://github.com/wmde/WikibaseDataModel/issues/175
[16:54:13] <JeroenDeDauw>	 If you want to remove one, how will you do that?
[16:54:17] <JeroenDeDauw>	 Or select one by GUID?
[16:54:23] <sjoerdinstad>	 jzerebecki: Thanks for the bugzillalink.
[16:54:38] <JeroenDeDauw>	 benestar: the old Claims class has by GUID indexing
[16:54:59] <benestar>	 JeroenDeDauw: we can index by property id and then by guid
[16:55:01] <JeroenDeDauw>	 benestar: we also had a simple way to index stuff with a property id by property id
[16:55:04] <JeroenDeDauw>	 ByPropertyIdArray
[16:55:15] <JeroenDeDauw>	 We still have it, though it's no longer simple
[16:55:20] <JeroenDeDauw>	 Since other stuff has been added to it
[16:55:23] <benestar>	 because every statement has a property id
[16:55:46] <JeroenDeDauw>	 benestar: sure, you can do this. But not in StatementList
[16:55:53] <benestar>	 so imo indexing by property id doesn't increase complexity that much but gives us much more efficient ways to look up properties
[16:55:56] <benestar>	 * statements
[16:56:28] <benestar>	 ByPropertyIdArray is evil, I don't want to use that
[16:57:03] <JeroenDeDauw>	 benestar: yes, I would indeed not use the class as it is
[16:57:09] <DanielK_WMDE_>	 JeroenDeDauw, benestar: have a peek at the mail i just forwarded to you
[16:57:13] <JeroenDeDauw>	 benestar: how about something like this though? https://github.com/wmde/WikibaseDataModel/blob/0.4/DataModel/ByPropertyIdArray.php
[16:57:42] <JeroenDeDauw>	 benestar: note how we have multiple lists of things with a prop id that we might want to index by
[16:58:40] <benestar>	 JeroenDeDauw: what else?
[16:58:52] <benestar>	 also this should be done with a proper interface
[16:59:20] <JeroenDeDauw>	 benestar: indeed, I'd have added an interface to the thing already if it had not gotten messed up
[16:59:43] <JeroenDeDauw>	 benestar: statements, claims, snaks
[17:00:06] <benestar>	 JeroenDeDauw: it's not used anywhere besides Claims in DataModel
[17:00:44] <JeroenDeDauw>	 DanielK_WMDE_: why did you put Lydia_WMDE in cc for that mail?!
[17:01:34] <JeroenDeDauw>	 benestar: what? ByPropertyIdArray? Could be, but then again why care? We already agreed to not use this as is?
[17:01:40] <grrrit-wm>	 (03PS6) 10Daniel Kinzler: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 
[17:01:48] <benestar>	 JeroenDeDauw: yes, so delete it ;P
[17:02:30] <JeroenDeDauw>	 benestar: if you can without breaking stuff...
[17:02:31] <DanielK_WMDE_>	 JeroenDeDauw: because i forget to do that when i originally replied to max. Lydia should know about other teams using our code, and the issues and questions they have.
[17:02:32] <JeroenDeDauw>	 Think you first need to create some replacement code
[17:03:04] <JeroenDeDauw>	 benestar: two worst rated priduction classes in DM
[17:03:06] <JeroenDeDauw>	 https://scrutinizer-ci.com/g/wmde/WikibaseDataModel/code-structure/master
[17:03:11] <JeroenDeDauw>	 Claims and ByPropertyIdArray
[17:03:33] <JeroenDeDauw>	 Enough to convince you that putting the indexing code together with other stuff is a bad idea?
[17:04:07] <benestar>	 JeroenDeDauw: yes, I'm already convinced ;)
[17:04:11] <Lydia_WMDE>	 JeroenDeDauw: because i need to take such things into account when prioritizing?
[17:04:56] <benestar>	 JeroenDeDauw: maybe create some filter classes which turn one StatementList into another one?
[17:05:05] <benestar>	 this won't be that efficient but much saner
[17:05:09] <DanielK_WMDE_>	 benestar: yes, please :)
[17:05:23] <benestar>	 and our StatementLists won't be that large that this will become a problem
[17:05:42] <DanielK_WMDE_>	 benestar: however, i'm not sure that's sufficient for the "group serialization by property id" use case
[17:06:13] <DanielK_WMDE_>	 but there could be a filter that just returns a plain array with property ids as keys and StatementList objects as values
[17:06:23] <DanielK_WMDE_>	 nice & simple
[17:06:40] <benestar>	 DanielK_WMDE_: gnah, I see you need all statements indexed by property ids...
[17:07:02] <DanielK_WMDE_>	 benestar: for that use case, we need them *grouped* that way, yes
[17:07:27] <benestar>	 so create a new ByPropertyList ?
[17:07:48] <DanielK_WMDE_>	 i don't see a need for that
[17:07:53] <DanielK_WMDE_>	 *shrug*
[17:08:01] <benestar>	 so rather a StatementByPropertyList ?
[17:08:35] <DanielK_WMDE_>	 i see no need for a specialized data structure
[17:09:05] <grrrit-wm>	 (03CR) 10Manybubbles: "Two things, easy one first:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler)
[17:09:16] <DanielK_WMDE_>	 i'd prefer a filter/transformer: StatementGrouper: StatementList -> StatementList[]
[17:10:14] <benestar>	 DanielK_WMDE_: but you might also want to get the best statements for a given property id.
[17:10:44] <grrrit-wm>	 (03CR) 10Bene: Add documentation for hooks defined by Wikibase. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[17:12:03] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "@manybubble:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler)
[17:13:18] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 032] Fix tag names generated in API XML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160677 (https://bugzilla.wikimedia.org/70531) (owner: 10Daniel Kinzler)
[17:13:56] <grrrit-wm>	 (03CR) 10Manybubbles: "Cool! Link tables sometimes update in process (for direct page edits) but also can update on the job queue (for template edits being refl" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler)
[17:16:04] <grrrit-wm>	 (03PS7) 10Daniel Kinzler: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 
[17:16:31] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 032] Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[17:21:34] <benestar>	 JeroenDeDauw: we might also filter them by the hash of the main snak
[17:21:38] <benestar>	 DanielK_WMDE_ --^
[17:22:07] <DanielK_WMDE_>	 benestar: we could, but what'S the use case?
[17:22:12] <JeroenDeDauw>	 benestar: there are many types of filters and indexed lookups one might want to do
[17:22:37] <JeroenDeDauw>	 And as is, adding a grouping for statements is already on the roadmap for 2.0
[17:22:38] <benestar>	 DanielK_WMDE_: because we don't allow to statements with the same snak in one item
[17:22:39] <JeroenDeDauw>	 https://github.com/wmde/WikibaseDataModel/issues/22
[17:22:40] <DanielK_WMDE_>	 benestar: we could have a filter that *sorts* them according to some criterion (e.g. based on an ordered list of guids).
[17:22:42] <benestar>	 * two
[17:22:56] <DanielK_WMDE_>	 benestar: sure we do.
[17:23:22] <DanielK_WMDE_>	 they could have different qualifiers, meaning completely different things.
[17:23:53] <benestar>	 DanielK_WMDE_: oh, I see. But we don't allow statements with same claims, or do we?
[17:23:58] <DanielK_WMDE_>	 we don't want two statements that are *completely* the same in the same item - though i'm not even sure that is enforced.
[17:24:21] * benestar tries
[17:24:37] <DanielK_WMDE_>	 i think we even allow this, because it may be needed while building up a simmilar but slightly different statement.
[17:24:59] <DanielK_WMDE_>	 benestar: this is why statements are identified by guid, not by hash, like references.
[17:25:01] <JeroenDeDauw>	 It is allowed in DataModel itself
[17:26:30] <benestar>	 it works :-)
[17:26:36] <benestar>	 but I think it didn't work onc
[17:26:37] <benestar>	 e
[17:27:41] <benestar>	 JeroenDeDauw: btw, when will you discuss the GUID issue with the team?
[17:28:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix tag names generated in API XML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160677 (https://bugzilla.wikimedia.org/70531) (owner: 10Daniel Kinzler)
[17:28:51] <JeroenDeDauw>	 benestar: if you want to have this discussed soon, then write a mail about it to the list to get things started
[17:29:16] * benestar wants to have everything discussed soon ;)
[17:29:16] <JeroenDeDauw>	 benestar: ATM this is not near the top of my todo list
[17:29:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 (owner: 10Daniel Kinzler)
[17:29:49] <benestar>	 JeroenDeDauw: out of curiosity: what's on top of your todo list?
[17:29:57] <JeroenDeDauw>	 benestar: please quit phrasing the issues in terms of StatementList
[17:30:12] <JeroenDeDauw>	 It includes part of a solution
[17:30:17] <JohnFLewis>	 Then second: Nyan!
[17:30:18] <JeroenDeDauw>	 And one that is clear I disagree with
[17:30:26] <benestar>	 k
[17:31:01] <JeroenDeDauw>	 benestar: "This class currently contains some methods which are still missing in StatementList so #190 is a blocker for this."
[17:31:07] <JeroenDeDauw>	 benestar: "This class currently contains some methods which are still missing for lists of statements, so #190 is a blocker for this."
[17:31:22] <benestar>	 yeah, I see
[17:32:03] <grrrit-wm>	 (03PS11) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 
[17:35:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler)
[18:01:45] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Would be good to have a test for this." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160376 (owner: 10Hoo man)
[18:04:46] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "This commit does not fix the code sharing by inheritance mentioned in the commit message. What's the deal with that? Is this preparation w" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159516 (owner: 10Bene)
[18:10:16] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "Yay for moving more code out of the hooks class. Some more work seems to be needed to not simply create a new mess though." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159515 (owner: 10Daniel Kinzler)
[18:12:25] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Remove revision from FetchedContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160651 (owner: 10Adrian Lang)
[18:14:55] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Right now this whole commit chain is just rotting here. Let's get this done and not have our effort wasted?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148664 (owner: 10Aude)
[18:15:02] <JeroenDeDauw>	 aude: ^
[18:34:38] <gh-wmde>	 [13WikibaseDataModel] 15Benestar created 06noclaims (+1 new commit): 02http://git.io/rN_htg
[18:34:38] <gh-wmde>	 13WikibaseDataModel/06noclaims 146202f10 15Bene: Use StatementList instead of Claims in patchClaims
[18:34:53] <gh-wmde>	 [13WikibaseDataModel] 15Benestar opened pull request #191: Use StatementList instead of Claims in patchClaims (06master...06noclaims) 02http://git.io/_AqASA
[18:35:27] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #191 146202f10: `$patch->getClaimsDiff()` should be renamed to `$patch->getStatementsDiff()` 02http://git.io/qTkYiA
[18:35:56] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #191 146202f10: This indexing should be made in another place, maybe `StatementList` itself. 02http://git.io/6eifaA
[18:37:12] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/noclaims/6202f10 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35562760
[18:47:28] <benestar|afk>	 JeroenDeDauw: shall we deprecate ClaimList?
[18:48:06] <JeroenDeDauw>	 benestar: why?
[18:48:25] <benestar>	 JeroenDeDauw: because we have StatementList now which should be used everywhere we currently use ClaimList
[18:48:44] <JeroenDeDauw>	 benestar: err
[18:48:46] <benestar>	 it isn't feature complete yet, that's why I'm asking
[18:48:52] <JeroenDeDauw>	 benestar: I hope we do not have such places
[18:48:59] <JeroenDeDauw>	 They where both added in 1.0 after all
[18:49:12] <benestar>	 we have no usecase for ClaimList, do we?
[18:49:14] <JeroenDeDauw>	 You are right that the introduction of StatementList makes ClaimList less usefull for us
[18:49:18] <JeroenDeDauw>	 Since we just have statements
[18:49:35] <JeroenDeDauw>	 Still, why would we want to go kill this thing?
[18:49:53] <JeroenDeDauw>	 It's clean, well tested and does not get in the way of anyone that does not need it
[18:49:59] <benestar>	 to prepare for the Claim-Statement-composition change
[18:50:02] <JeroenDeDauw>	 Claims on the other hand
[18:50:27] <JeroenDeDauw>	 I don't see how this class hinders the composition change
[18:50:33] <benestar>	 Claims will be considered only as internal objects, kind of an implementation detail
[18:50:55] <JeroenDeDauw>	 benestar: so we should also not have any classes that represent lists of snaks?
[18:50:56] <benestar>	 so having a class without usecases in our code isn't that nice, right?
[18:51:28] <benestar>	 JeroenDeDauw: they are used inside of DataModel which isn't (or shouldn't) be the case for ClaimList
[18:51:35] <JeroenDeDauw>	 benestar: if it becomes clear we are very unlikely to need it all, then usre
[18:51:54] <JeroenDeDauw>	 Actually I think QueryEngine uses ClaimList
[18:51:57] <benestar>	 ok, so just wait how things are moving
[18:52:03] <JeroenDeDauw>	 Or rather, still the original version
[18:52:07] <benestar>	 evil QueryEngine
[18:52:17] <JeroenDeDauw>	 benestar: it's usage is not evil
[18:52:34] <JeroenDeDauw>	 And can remain when we make the composition change
[18:52:51] <benestar>	 hmm, not sure because the construction will become complicated
[18:53:05] <JeroenDeDauw>	 ???
[18:53:24] <benestar>	 you cannot construct a ClaimList from a StatementList then
[18:53:56] <JeroenDeDauw>	 Why not? Just iterate over it and get the claims the statements contain?
[18:53:58] <benestar>	 and since DataModel doesn't create any ClaimList perhaps, I cannot imagine of any serious reason to use a Claimlist instead of a StatementList
[20:11:52] <hockew>	 Anyone here?
[20:12:30] <sjoerddebruin>	 Yes hockew.
[20:12:44] <hockew>	 Great :)
[20:13:05] <hockew>	 Are you working with wikidata?
[20:13:24] <sjoerddebruin>	 Yes. :P
[20:13:44] <hockew>	 I can not understand one thing
[20:13:58] <sjoerddebruin>	 Tell me
[20:14:10] <hockew>	 how do I use the data in a Wikipedia article?
[20:15:22] <hockew>	 I can link to the data with [[d:Q39715]]
[20:15:27] <sjoerddebruin>	 That's described on https://meta.wikimedia.org/wiki/Wikidata/Notes/Inclusion_syntax
[20:16:15] <hockew>	 Sweet
[20:16:39] <hockew>	 Checking it out! Thanks!
[20:16:42] <sjoerddebruin>	 :)
[20:28:37] <hockew>	 sjoerddebruin: Do you know of any good examples on Wikipedia where wiki data is used?
[20:29:07] <sjoerddebruin>	 I think the Russian Wikipedia uses it in infoboxes, for like photo's etc
[20:29:53] <sjoerddebruin>	 Like on https://ru.wikipedia.org/wiki/Ван_Кирк,_Теодор
[20:30:01] <sjoerddebruin>	 The picture is not in the source of the current page.
[20:33:31] <hockew>	 Hard to understand the russian...
[20:35:03] <sjoerddebruin>	 Yes.
[20:36:22] <hockew>	 But, if I would like to write the Item Continent in the Sweden post? At https://www.wikidata.org/wiki/Q34
[20:37:42] <hockew>	 eg. write Europe at Wikipedia
[21:19:29] <benestar|afk>	 JeroenDeDauw: suggestion: create a class called ByPropertyIdGrouper which groups a list of something implementing PropertyIdProvider interface
[21:20:06] <benestar|afk>	 this class can then be used in another class called BestStatementProvider or sth like that
[21:20:29] * benestar|afk thinks this is a good approach
[21:28:29] <gh-wmde>	 [13WikibaseDataModel] 15Benestar created 06propertyidprovider (+1 new commit): 02http://git.io/aoOL7Q
[21:28:29] <gh-wmde>	 13WikibaseDataModel/06propertyidprovider 14093fb4e 15Bene: Add interface PropertyIdProvider
[21:29:00] <gh-wmde>	 [13WikibaseDataModel] 15Benestar opened pull request #194: Add interface PropertyIdProvider (06master...06propertyidprovider) 02http://git.io/jGZNkA
[21:30:53] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/propertyidprovider/093fb4e : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35578541
[21:31:23] <JeroenDeDauw>	 benestar|afk: maybe. That might be splitting it more than is warranted
[21:31:30] <JeroenDeDauw>	 No objection thoug
[21:31:40] <JeroenDeDauw>	 Joining things is easier than splitting them
[21:42:44] <sjoerddebruin>	 hoo|away: guess what.
[21:44:58] <JeroenDeDauw>	 benestar|cloud: you are all over the dm recently...
[21:45:59] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06propertyidprovider: 02http://git.io/UYOQxg
[21:45:59] <gh-wmde>	 13WikibaseDataModel/06propertyidprovider 14506ea7b 15Jeroen De Dauw: Update PropertyIdProvider.php
[21:46:09] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw closed pull request #194: Add interface PropertyIdProvider (06master...06propertyidprovider) 02http://git.io/jGZNkA
[21:49:53] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/propertyidprovider/506ea7b : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/35580036
[22:33:38] <Anupmehra>	 How to create a new 'value' -(for 'occupation' property)?  -"former pornographic actor/actress", I'm looking for.
[22:38:54] <jackmcbarn>	 how's progress on https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Lua&diff=625958102&oldid=625563157 ?
[23:29:28] <harej>	 question: where can I see what wikidata software changes have been made since april?
[23:30:35] <jackmcbarn>	 harej: go into the wikidata directory and type "git log"
[23:30:53] <jackmcbarn>	 (or if you don't have your own setup, look at it on the web)
[23:31:31] <jackmcbarn>	 https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Wikibase+status:merged+-owner:L10n-bot,n,z
[23:31:35] <jackmcbarn>	 there's a ton, btw
[23:32:16] <harej>	 For a slightly less technical audience, do you have like a newsletter or something?
[23:32:49] <jackmcbarn>	 yes, let me find it...
[23:34:35] <jackmcbarn>	 https://www.wikidata.org/wiki/Wikidata:Status_updates