[07:02:02] (03CR) 10Henning Snater: Let mw.Api handle params and token in RepoApi (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 (owner: 10Adrian Lang) [07:02:32] (03CR) 10Henning Snater: "Do we actually need get() to be public?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 (owner: 10Adrian Lang) [07:09:21] (03CR) 10Henning Snater: Move handling of remote APIs out of RepoApi (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 (owner: 10Adrian Lang) [07:24:35] (03PS2) 10Henning Snater: Implemented badge selector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160456 [07:28:16] (03PS5) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) [07:31:13] (03CR) 10Adrian Lang: "get needs to be public since jquery.wikibase.linkitem is using it. It becomes private in I99c656f11ec636d879b84c3f2d88983a8d239f45, though" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 (owner: 10Adrian Lang) [07:37:21] (03CR) 10Adrian Lang: Move handling of remote APIs out of RepoApi (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 (owner: 10Adrian Lang) [07:38:19] (03PS3) 10Adrian Lang: Make RepoApi.post private (rename to RepoApi._post) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 [07:38:21] (03PS3) 10Adrian Lang: Let mw.Api handle params and token in RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 [07:38:23] (03PS9) 10Adrian Lang: Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 [07:38:25] (03PS3) 10Adrian Lang: Move handling of remote APIs out of RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 [07:42:02] (03PS6) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) [07:58:02] (03CR) 10Henning Snater: [C: 04-1] "When the menu is invisible, no action is performed now. I assume it would still make sense to reset the selected site to null while the me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [08:12:28] (03CR) 10Henning Snater: [C: 031 V: 031] "Just a suggestion: Might be nice to display the badge icons and have the badge labels link to the corresponding badge items; Anyway, no ne" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159103 (https://bugzilla.wikimedia.org/70333) (owner: 10Bene) [08:19:17] (03CR) 10Adrian Lang: Let mw.Api handle params and token in RepoApi (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 (owner: 10Adrian Lang) [08:23:16] Lydia_WMDE: Hi! I'm looking for nice ideas of projects related to Wikidata for something like 10 students from mid-september to mid-december. I thaught about creating a new version of wiri. Have you any other ideas? [08:23:42] Tpt: ohhhhhh [08:23:44] tons of them :D [08:24:00] Lydia_WMDE: nice :-) [08:24:14] Tpt: should we have a quick call at some point this week? [08:24:46] Lydia_WMDE: It's a very nice idea [08:25:21] Tpt: tomorro morning? [08:25:33] or thursday morning? [08:26:29] Lydia_WMDE: All my morning are fulls :-( [08:27:06] People won't work on it more than 5-8 hours a week and won't be very skilled so it should be something small. [08:27:24] later today? [08:28:30] Lydia_WMDE: I can't before 18 CET [08:28:37] that's fine [08:29:08] So, something like 18h? [08:29:24] sounds good :) [08:30:00] Lydia_WMDE: Nice. On Hangout? [08:31:20] deal [08:31:47] Lydia_WMDE: Thanks a lot! [08:31:58] thank you! [08:33:58] (03PS4) 10Henning Snater: Refactored siteselector._selectFirstSite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [08:41:57] (03Abandoned) 10Aude: Revert "Retry inserting into wb_entity_per_page table on deadlock." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159030 (owner: 10Aude) [08:45:21] (03CR) 10Henning Snater: [C: 032] Refactored siteselector._selectFirstSite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [08:54:57] (03Merged) 10jenkins-bot: Refactored siteselector._selectFirstSite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [09:37:04] Adrian_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=69708#c6 and then restarting hhvm, it works again [09:38:13] in production they are doing https://gerrit.wikimedia.org/r/#/c/160394/ (increase jit 'acold' size, because wikibase caused stuff to crash) [10:00:26] (03PS1) 10WikidataBuilder: New Wikidata Build - 16/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160622 [10:01:10] (03Abandoned) 10Aude: New Wikidata Build - 16/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160622 (owner: 10WikidataBuilder) [10:04:53] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160622 (owner: 10WikidataBuilder) [10:19:43] JeroenDeDauw: good morning :D [10:19:50] when will DataModel 1.0 be released? [10:19:54] * 1.1 [10:22:10] is it morning? [10:22:10] Where's hoo when you need him... [10:22:19] don't think he's here yet [10:22:56] I'm getting the same issue again. :/ [10:32:09] sjoerddebruin: i don't see any errors for the change notification jobs [10:32:16] Okay, weird. [10:32:22] don't know why there are issues but maybe hoo knows [10:39:52] hoo: do you know where the ChangeNotification hhvm errors are logged to? [10:39:59] i know i have seen them in the past [10:40:09] looks like the jobs are running ok now, though [10:46:50] Got some false positives a few minutes ago, hoo. ;) [10:48:50] [13WikibaseDataModel] 15Benestar created 06ranktostatement (+1 new commit): 02http://git.io/76eT9w [10:48:50] 13WikibaseDataModel/06ranktostatement 14d316acd 15Bene: Move ranks to statement [10:49:12] [13WikibaseDataModel] 15Benestar opened pull request #185: Move ranks to statement (06master...06ranktostatement) 02http://git.io/7Yvixw [10:49:44] aude: Probably with the Zend ones [10:49:50] aude: do you know when DataModel 1.1 will be released? [10:50:04] * benestar needs Property::getStatements [10:50:26] benestar: no [10:50:45] [travis-ci] wmde/WikibaseDataModel/ranktostatement/d316acd : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35422763 [10:51:21] btw, https://github.com/wmde/WikibaseDataModel/releases shows 0.9.1 as latest release, not 1.0 :-/ [10:51:49] huh [10:52:46] * benestar blames JeroenDeDauw [10:53:04] fixed [10:53:18] thx [10:53:50] aude: JeroenDeDauw: You have to type in a release title if you want a proper release [10:54:04] * aude doesn't touch data model component [10:54:05] Just use the name of the tag or so [10:54:11] it's JeroenDeDauw's thing or maybe tobi can do [10:54:25] i always put a title for the other things [10:54:42] :) [10:54:45] in general we put the name of the tag in there.. maybe JeroenDeDauw just forgot [10:55:57] (03PS3) 10Henning Snater: Implemented badge selector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160456 [10:57:23] (03PS1) 10Henning Snater: Refactored edittoolbar options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160627 [10:59:48] (03PS2) 10Henning Snater: Refactored edittoolbar options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160627 [12:03:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160456 (owner: 10Henning Snater) [12:07:36] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [12:15:31] Tobi_WMDE_SWE: I'm not caring much about the releases page on GitHub [12:15:48] The annoying thing could figure out what the latest stable release is itself [12:15:58] And this forces us to put more things into GitHub itself [12:15:59] JeroenDeDauw: seems others do. :) [12:16:08] It's not used elsewhere and we lose it if we move the repo [12:16:14] Tobi_WMDE_SWE: some others [12:16:43] Tobi_WMDE_SWE: and there is a big difference between one of our components and say PHPUnit, which has many thousands of users [12:17:03] not even sure why github not recognizes a valid release if it has no title.. [12:17:12] Of course if you put in one release there, it will look deceptive if you don't keep updating it [12:17:21] So if you put one in there, you should keep on maintaining it [12:17:21] but putting the version number as title fixes it [12:18:10] not a big issue [12:26:25] [13WikibaseDataModel] 15Benestar created 06statementclaimconstructor (+1 new commit): 02http://git.io/dmHoKA [12:26:25] 13WikibaseDataModel/06statementclaimconstructor 14ad382a1 15Bene: Statement constructor takes Claim as an argument [12:28:15] [travis-ci] wmde/WikibaseDataModel/statementclaimconstructor/ad382a1 : Bene The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35428339 [12:28:35] [13WikibaseDataModel] 15Benestar opened pull request #186: Statement constructor takes Claim as an argument (06master...06statementclaimconstructor) 02http://git.io/OS-ytA [12:57:00] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06statementclaimconstructor: 02http://git.io/rXL_iw [12:57:00] 13WikibaseDataModel/06statementclaimconstructor 1476dd016 15Bene: Fix tests and add Statement::setClaim [13:02:04] [travis-ci] wmde/WikibaseDataModel/statementclaimconstructor/76dd016 : Bene The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35430780 [13:08:43] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06ranktostatement: 02http://git.io/6AcLog [13:08:43] 13WikibaseDataModel/06ranktostatement 14b580e96 15Bene: Don't redeclare values and deprecate whole enum [13:10:03] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06statementclaimconstructor: 02http://git.io/wXZTag [13:10:03] 13WikibaseDataModel/06statementclaimconstructor 14cf8df0e 15Bene: Oops [13:17:54] [13WikibaseDataModelSerialization] 15Benestar created 06statementserializer (+2 new commits): 02http://git.io/-hILPg [13:17:54] 13WikibaseDataModelSerialization/06statementserializer 14a423ae0 15Bene: Create StatementSerializer and StatementDeserializer [13:17:54] 13WikibaseDataModelSerialization/06statementserializer 1491883d2 15Bene: Add integration tests [13:17:58] (03PS1) 10Aude: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 [13:18:00] (03PS1) 10Aude: Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160644 [13:18:02] (03PS1) 10Aude: Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160645 [13:19:09] [travis-ci] wmde/WikibaseDataModelSerialization/statementserializer/91883d2 : Bene The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35432512 [13:19:46] [13WikibaseDataModelSerialization] 15Benestar opened pull request #80: Create StatementSerializer and StatementDeserializer (06master...06statementserializer) 02http://git.io/Hn8wVQ [13:27:24] (03CR) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [13:28:10] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 1474c944b to 14a1fd165: 02http://git.io/qVv3IQ [13:28:10] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 14a1fd165 15Jan Zerebecki: Do no inherit from EntitySerializer.... [13:30:59] (03CR) 10jenkins-bot: [V: 04-1] Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 (owner: 10Aude) [13:31:41] * aude rage to hoo and benestar [13:31:45] :D [13:33:03] (03PS2) 10Aude: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160643 [13:33:05] (03PS2) 10Aude: Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160644 [13:33:07] (03PS2) 10Aude: Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160645 [13:33:09] (03PS1) 10Aude: Call parent::tearDown in FingerprintViewTest [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160647 (https://bugzilla.wikimedia.org/70659) [13:33:42] (03CR) 10Siebrand: Moved edit feature from sitelinkview to sitelinkgroupview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [13:38:22] (03PS1) 10Adrian Lang: Remove removeReferences from AbstractedRepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160649 [13:40:35] (03PS1) 10Adrian Lang: Remove removeClaim from AbstractedRepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160650 [13:41:43] (03PS1) 10Adrian Lang: Remove revision from FetchedContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160651 [13:43:49] (03PS1) 10Adrian Lang: Refactor EntityStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 [13:45:29] (03CR) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [13:46:22] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 14a1fd165 to 147814592: 02http://git.io/qVv3IQ [13:46:22] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 147814592 15Jan Zerebecki: Do not inherit from EntitySerializer.... [13:46:39] [13WikibaseDataModelSerialization] 15JanZerebecki opened pull request #81: Do not inherit from EntitySerializer. (06master...06compose-EntitiySerializer) 02http://git.io/wy0v9g [13:48:02] [travis-ci] wmde/WikibaseDataModelSerialization/compose-EntitiySerializer/7814592 : Jan Zerebecki The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/35434921 [13:48:43] (03CR) 10Siebrand: Moved edit feature from sitelinkview to sitelinkgroupview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [13:54:24] (03CR) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [14:00:36] (03CR) 10jenkins-bot: [V: 04-1] Fix missing options bug in GetClaims [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160644 (owner: 10Aude) [14:00:38] (03CR) 10jenkins-bot: [V: 04-1] Add tests for api xml format [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160645 (owner: 10Aude) [14:01:20] ooooo [14:20:46] (03CR) 10Jeroen De Dauw: Refactor EntityStore (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 (owner: 10Adrian Lang) [14:21:30] (03CR) 10Jeroen De Dauw: "Yay for finally getting to this btw" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160652 (owner: 10Adrian Lang) [14:22:04] (03PS1) 10Daniel Kinzler: Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 [14:23:15] (03PS2) 10Daniel Kinzler: Add hook to control text for search index. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 [14:27:47] raaaaaaaaage at bugzilla [14:28:02] stop reopening bugs when backporting patches [14:37:03] aude: phabricator tothe rescue! ;) [14:37:05] (03PS1) 10Daniel Kinzler: Add documentation for hooks defined by Wikibase. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160657 [14:37:51] :D [14:38:04] aude: that's the stupid bot actually [14:38:31] yeah [14:48:09] bah, jenkins says no to xml [14:48:24] and looks like it fails locally for me when cherry picked [14:48:49] we can still deploy badges fix [14:48:52] css [14:50:13] doh... the moment I [14:50:21] realize I forgot to stop by the bank :P [14:50:38] oh noes! [14:50:58] To lazy to go out again... at least now [14:52:09] (03PS1) 10Aude: Update Wikidata, fix for badges css in monobook [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 [14:54:30] (03CR) 10jenkins-bot: [V: 04-1] Update Wikidata, fix for badges css in monobook [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [14:55:01] wtf https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension/5/console [14:55:03] wtf jenkins [14:55:13] 14:54:25 ERROR:zuul.Cloner:upstream repo is missing branch mw1.24-wmf19 [14:55:16] Could not load some extensions because they are missing [14:55:20] expected entry point? [14:55:31] oh [14:55:32] doh [14:55:33] aude: yeah must be me [14:55:44] that's because it tries to use our branch names on other repos [14:55:46] :S [14:55:54] I have totally broke continuous integration half an hour ago [14:55:57] ok [14:56:06] we will postpone swat [14:56:06] let me refresh the job [14:56:09] probably tomorrow [14:56:18] sorry for the swat :( [14:56:24] it' sok [14:56:29] jslint fails for some reason. no idea [14:56:30] the other thing i want is failing [14:56:37] for xml api [14:56:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [14:56:49] |log INFO:root:Updating jobs in config/ (['mwext-Wikidata-testextension']) [14:56:57] wdjenkins too? [14:56:58] (03CR) 10Hashar: "recheck" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [14:57:29] 14:57:11 Could not load some extensions because they are missing [14:57:29] 14:57:11 the expected entry point: [14:57:29] 14:57:11 [14:57:30] 14:57:11 /srv/ssd/jenkins-slave/workspace/mwext-Wikidata-testextension/src/extensions//.php [14:57:30] bah [14:57:39] :( [14:58:49] aude: I see what's wrong with wdjenkins [14:58:51] I can fix it [14:59:13] hoo: ok [14:59:21] oh that [14:59:28] it failed on our daily build [14:59:43] might have to do with cachign of mediawiki [14:59:47] yeah [15:00:05] you know how to fix that on wdjenkins? [15:00:10] yep, on it [15:00:12] i think we delete stuff [15:00:16] but not sure where [15:00:20] ok :) [15:01:47] aude I found out the issue [15:01:55] some empty extension dependency is passed [15:02:06] and we end up attempting to load an extension named "\n" :-D [15:02:12] (03CR) 10Hashar: "recheck" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [15:03:29] aude: hoo: wikimedia jenkins fixed up for https://gerrit.wikimedia.org/r/#/c/160664/ [15:03:41] looks good [15:03:53] gotta send a mail to wikitech [15:04:00] and quick [15:04:14] aude: ours should be fixed as well [15:04:20] locally i do get the storage exceptions though [15:04:24] jslint I am not sure why it fails [15:04:30] it is not voting so .. [15:04:46] (03PS2) 10Hoo man: Update Wikidata, fix for badges CSS in monobook [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [15:04:54] to ahve our jenkins re-run [15:05:02] hashar: our js terribly violates the rules [15:05:11] well, we have own rules [15:05:16] heh [15:05:18] but not sure we're following them anymore [15:05:24] using JS should be against the rules [15:05:30] :) [15:05:39] it took me and Daniel W. ages to have Wikibase pass jshint at some point [15:05:56] That's was mid 2013 :P [15:06:30] aude: hoo@wdjenkins:~$ sudo rm -rf $( find /var/lib/jenkins/jobs/ -name workspace | grep '\-build\-' | grep -v browsertest ) [15:06:35] if you ever have to clean up jeknins [15:06:41] * our jenkins [15:06:45] it's quick and very dirty [15:07:24] (03CR) 10Aude: "i get the failure locally about storage failure, although seems intermittent." [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [15:07:31] hoo: ok [15:08:03] our jenkins is still slow :( [15:08:17] only doing the builds [15:08:32] luckily [15:18:19] (03Draft10) 10Daniel Kinzler: Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 [15:18:48] (03CR) 10Daniel Kinzler: [C: 04-1] "This is very incomplete and needs to be split up." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [15:19:10] (03Draft3) 10Daniel Kinzler: Initial rough spec for the usage tracking system [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157682 [15:21:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [15:21:39] (03CR) 10jenkins-bot: [V: 04-1] Draft of subscription and tracking interfaces [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158078 (owner: 10Daniel Kinzler) [15:22:10] wtf [15:22:19] PHP Fatal error: Uncaught exception 'MWException' with message 'Wikibase\Test\FingerprintViewTest::tearDown() must call parent::tearDown()' in /var/lib/jenkins/jobs/wikibase-build-repo-tests/workspace/tests/phpunit/MediaWikiTestCase.php:95 [15:22:26] wasn't the fix backported? [15:22:29] aude: ^ [15:23:45] i put it in [15:23:54] didn't merge yet [15:24:05] mh [15:24:14] and why is wmf jenkins only running 11 tests [15:24:22] https://gerrit.wikimedia.org/r/#/c/160647/ [15:24:42] (03CR) 10Hoo man: [C: 032] Call parent::tearDown in FingerprintViewTest [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160647 (https://bugzilla.wikimedia.org/70659) (owner: 10Aude) [15:24:43] 11? [15:24:52] 15:05:05 OK (11 tests, 21 assertions) [15:25:07] only vendor tests or something weird? [15:25:13] mediawiki/vendor ? [15:25:29] maybe [15:25:32] oh, that's why it's so quick! [15:25:36] seemed suspicious [15:25:38] hashar: ^ [15:26:32] Configuration read from /srv/ssd/jenkins-slave/workspace/mwext-Wikidata-testextension/src/tests/phpunit/suite.xml [15:26:43] testsuite extensions [15:32:09] JeroenDeDauw: around? I've got a question [15:34:53] (03Merged) 10jenkins-bot: Call parent::tearDown in FingerprintViewTest [extensions/Wikibase] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160647 (https://bugzilla.wikimedia.org/70659) (owner: 10Aude) [15:35:27] hoo: aude: which change ? [15:35:51] hashar: https://gerrit.wikimedia.org/r/#/c/160664/ [15:35:59] wfRunHooks( 'UnitTestsList', array( &$files ) ); [15:36:10] did we change our handler to that hook? [15:36:18] maybe it can find the tests ? :( [15:36:27] hoo: that would be surprising [15:36:48] mh... maybe it doesn't actually install the extension? [15:36:58] looks like other extensions, e.g. flow https://gerrit.wikimedia.org/r/#/c/160259/ don't have the issue though [15:37:44] note it only runs the tests in the "extensions" test suite [15:37:58] hashar: which depends on the hook, right? [15:38:01] hashar: but our stuff should be part of that [15:38:04] in the past that worked [15:38:28] I probably broke it with my huge change :/ [15:38:50] if ( PHP_SAPI === 'cli' && getenv( 'JOB_NAME' ) === 'mwext-Wikidata-testextensions-master') { [15:38:53] nope, our fault [15:38:54] m( [15:39:05] job name changed [15:39:09] oh [15:39:18] * aude cries [15:39:28] but ok [15:39:50] (03PS1) 10Hoo man: Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 [15:40:02] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [15:40:04] stupid [15:40:10] and it's not master [15:40:29] 15:40:01 [3faa14be] [no req] Exception from line 90 of /srv/ssd/jenkins-slave/workspace/mwext-Wikidata-testextension/src/extensions/Wikidata/extensions/Wikibase/repo/Wikibase.hooks.php: Wikibase: Incomplete configuration: $wgWBRepoSettings["entityNamespaces"] has to be set to an array mapping content model IDs to namespace IDs. See ExampleSettings.php for details and examples. [15:41:06] oh, there's more hard coded stuff [15:41:08] m( [15:41:13] hoo: ah I should have though about the job renaming sorry :( [15:41:38] we shouldn't have evil stuff in our code that depends on the name [15:41:42] also note that the job now look at the patch BRANCH and checkout mediawiki/core @ that branch [15:41:44] of course it will change [15:41:45] instead of always using master [15:41:48] sorry :-( [15:41:56] (03PS2) 10Hoo man: Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 [15:42:12] aude: Yeah... mid term we should fix that [15:42:13] that branch? [15:42:23] you mean 1.24wmf21 and what not? [15:42:29] (03CR) 10Hashar: "Good catch. I am sorry I should really have thought about this one :-/" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [15:42:32] no, not hard coding job names [15:42:37] also branch names, maybe [15:42:38] not sure [15:42:46] i mean "checkout mediawiki/core @ that branch" [15:43:01] yeah, taht would require us to change branch names [15:43:13] for change https://gerrit.wikimedia.org/r/#/c/160664/ made against mw1.24-wmf19 [15:43:15] but that would also mean that stuff would run against older branches than in actual production [15:43:15] we also use our branches across multiple core branches [15:43:23] the job checkout the mw1.24-wmf19 branch of mediawiki/core [15:43:27] oh [15:43:42] which definitely has some side effect for you guys :-/ [15:43:54] the idea is to later on test against multiple core branches [15:43:58] Yeah, master is better than older [15:44:30] (03PS1) 10Hoo man: Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160670 [15:44:45] i suppose we can start naming things 1.24wmf19 [15:45:15] if you look at the top of https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension/10/consoleFull [15:45:23] you can see some debug/ info message for zuul.Cloner [15:45:31] that is the software that now handles git cloning of repositories [15:45:51] and it does stuff like: 00:00:02.131 INFO:zuul.Cloner:Prepared mediawiki/core repo with branch master [15:46:01] (which would change if the patch is proposed to a different branch) [15:46:21] (03CR) 10Hashar: [C: 031] Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [15:46:33] (03CR) 10Hashar: [C: 031] Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160670 (owner: 10Hoo man) [15:47:58] hashar: if it can't find such branch then it uses master? [15:48:04] aude yes [15:48:06] ok [15:48:14] need to write down all that doc [15:48:20] going forward for new branches, we can use new naming [15:48:35] some doc is at http://ci.openstack.org/zuul/gating.html#cross-projects-dependencies [15:48:42] it will be for 1.25wmf# anyway [15:48:51] don't think we will have any more for 1.24 [15:50:21] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [15:50:40] *rage* [15:51:16] 15:50:19 Failed asserting that '

Redirect to:

[15:51:18] yaay!! I have SUL! 26.5 months after I started usurping and unifying, finally done [15:51:33] \o/ [15:51:39] \o/ :) [15:51:46] aude: Didn't we fix that a logn time ago? [15:51:56] hoo: it's an incompatibility with master [15:52:05] of what? [15:52:08] yes it is fixed [15:52:34] wikidata master is nowhere near Wikibase master, I guss [15:53:32] :( [15:53:34] https://gerrit.wikimedia.org/r/#/c/158925/ [15:53:47] i cherry picked it into our last (failed) deploymen tbuild [15:54:02] but it's not on Wikidata master? [15:54:05] it is [15:54:21] why's it failing then [15:54:24] * aude confused [15:54:42] oh https://gerrit.wikimedia.org/r/#/c/160669/ [15:54:52] https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension/10/console [15:54:58] we've had no successful, working build for master since september 2 [15:55:18] also it ahs those 15:50:19 Fatal error: Uncaught exception 'MWException' with message 'Wikibase\Test\FingerprintViewTest::tearDown() must call parent::tearDown()' in /srv/ssd/jenkins-slave/workspace/mwext-Wikidata-testextension/src/tests/phpunit/MediaWikiTestCase.php on line 95 [15:55:24] not surprising, though [15:55:32] shall I still force merge? [15:55:39] no please [15:55:43] or i guess [15:55:49] since it's not new code [15:55:58] no tests or failing tests [15:55:59] ok :) [15:56:01] that's the options [15:56:08] * those are the [15:57:50] [13WikibaseDataModel] 15Benestar created 06addreference (+2 new commits): 02http://git.io/p3BHYQ [15:57:50] 13WikibaseDataModel/06addreference 14c00f6a1 15Bene: Create convenience method [15:57:50] 13WikibaseDataModel/06addreference 14374f66a 15Bene: Update release notes [15:57:58] aude: so= [15:57:59] *? [15:59:11] hoo: the file will be overwritten [15:59:15] next build [15:59:27] fix it https://github.com/wmde/WikidataBuildResources [15:59:43] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job name is now "mwext-Wikidata-testextension" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160670 (owner: 10Hoo man) [15:59:43] and https://github.com/wmde/WikidataBuilder/blob/master/build_config/Wikidata_master/build_resources/Wikidata.php [15:59:46] and... [15:59:55] aude hop if need be I can have Wikidata trigger the old job [15:59:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [15:59:56] note https://github.com/wmde/WikidataBuilder/issues/25 [16:00:46] mh [16:01:07] then i believe the property suggester has an erorr [16:01:23] it's exploding on travis [16:01:25] I saw that [16:01:34] and i am working to have a shared cache key prefix generated when making a build [16:01:35] [13WikibaseDataModel] 15Benestar opened pull request #187: Create Statement::addReference (06master...06addreference) 02http://git.io/5GnvYw [16:01:57] so it changes each time we deploy to beta, as not setting it is what caused beta to break on friday [16:02:13] solve all those things and we can have a new build on beta [16:04:32] mh, I see [16:04:40] yep [16:04:46] but that's not directly relevant here [16:04:50] yep [16:08:29] [travis-ci] wmde/WikibaseDataModel/addreference/374f66a : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35449231 [16:08:48] (03PS1) 10Daniel Kinzler: Fix tag names generated in API XML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160677 (https://bugzilla.wikimedia.org/70531) [16:08:49] why is reporting all datamodel builds here? [16:09:57] aude: I would suggest to now (force) merge the Wikidata patches which make the tests run, and I can also update WD builder [16:10:00] is that ok with you? [16:10:07] Better have failing tests then no tests [16:10:16] (03PS2) 10Daniel Kinzler: Fix tag names generated in API XML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160677 (https://bugzilla.wikimedia.org/70531) [16:10:20] hoo: ok [16:10:21] only gives a false sense of security to not have tests running [16:10:25] aude: --^^ [16:10:40] And then I have to fiddle out how to scan to PDF :D [16:10:54] * figure [16:12:42] Lydia_WMDE: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Wikibase-tokencheck-mustposttoken/sv [16:12:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [16:13:05] (03CR) 10Hoo man: [C: 032 V: 032] "Failing tests are better than having no tests run (I guess the next build will fix the tests anyway)." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160669 (owner: 10Hoo man) [16:13:58] (03CR) 10jenkins-bot: [V: 04-1] Fix tag names generated in API XML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160677 (https://bugzilla.wikimedia.org/70531) (owner: 10Daniel Kinzler) [16:14:12] (03CR) 10Hoo man: [C: 032 V: 032] "Tests will be fixed with next commits" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160670 (owner: 10Hoo man) [16:15:59] Nemo_bis: thx [16:17:25] [13WikidataBuilder] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/uTO1_Q [16:17:25] 13WikidataBuilder/06master 142a0c0c5 15Marius Hoch: Jenkins job name is now "mwext-Wikidata-testextension"... [16:22:27] (03PS3) 10Hoo man: Update Wikidata, fix for badges CSS in monobook [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [16:22:41] aude: ^ incorporates the test fix now [16:29:38] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160670 (owner: 10Hoo man) [16:31:27] still failing? [16:32:06] that's the test name change only [16:32:12] not the monobook CSS one [16:32:16] confusing today, I know [16:32:42] I hope that it passes and we can jump on tonights SWAT [16:34:36] if we are awake [16:34:48] I will be, I guess [16:35:04] I overslept this morning, so :P [16:35:58] ok :) [16:35:58] Unless I decide to go to Badminton early tomorrow, then I might want to sleep early :P [16:36:09] but I doubt I'll go before 11 :D [16:43:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [16:43:43] JeroenDeDauw: should the GUID be a property of a claim or of a statement? [16:43:56] aude: \o/ It passed [16:43:59] merge now? [16:44:14] can also wait until tonight [16:49:17] aude: Updated deployments table [16:50:05] hoo: yay [16:50:21] go ahead and merge [16:50:45] (03CR) 10Hoo man: [C: 032] Update Wikidata, fix for badges CSS in monobook [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [16:51:01] Will prepare other stuff later on. Time for food now [16:51:05] ok [16:51:24] i am making the build generate the setting [16:51:32] e.g. composer to do it [16:53:29] [13WikibaseDataModelSerialization] 15Benestar pushed 2 new commits to 06statementserializer: 02http://git.io/u-JL9Q [16:53:29] 13WikibaseDataModelSerialization/06statementserializer 1487a408e 15Bene: Add StatementDeserializerTest and fix some issues [16:53:29] 13WikibaseDataModelSerialization/06statementserializer 149c1e9f5 15Bene: Create StatementSerializerTest [17:00:15] (03Merged) 10jenkins-bot: Update Wikidata, fix for badges CSS in monobook [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/160664 (owner: 10Aude) [17:06:18] (03PS3) 10Daniel Kinzler: Move SidebarBeforeOutput hook to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159515 [17:10:22] [13WikidataBuildResources] 15filbertkm created 06settings (+1 new commit): 02http://git.io/hWcbdg [17:10:22] 13WikidataBuildResources/06settings 14b81f6bf 15aude: Autogenerate sharedCacheKeyPrefix setting... [17:11:31] [13WikidataBuildResources] 15filbertkm 04force-pushed 06settings from 14b81f6bf to 1432a6c88: 02http://git.io/e4i1dA [17:11:31] 13WikidataBuildResources/06settings 1432a6c88 15aude: Autogenerate sharedCacheKeyPrefix setting... [17:41:56] (03CR) 10Daniel Kinzler: "that looks sensible, but i didn't check how hasStats is actually used, or why stats would not be an array." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160376 (owner: 10Hoo man) [17:49:57] (03PS3) 10Daniel Kinzler: Fix tag names generated in API XML output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160677 (https://bugzilla.wikimedia.org/70531) [17:54:43] [13WikibaseDataModel] 15Benestar created 06statementclaimconstructor_compat (+1 new commit): 02http://git.io/DJj8Qg [17:54:43] 13WikibaseDataModel/06statementclaimconstructor_compat 141cada02 15Bene: Add optional claim parameter to Statement constructor [17:55:43] [13WikibaseDataModel] 15Benestar opened pull request #188: Add optional claim parameter to Statement constructor (06master...06statementclaimconstructor_compat) 02http://git.io/no5a4g [17:55:52] JeroenDeDauw: around? [17:57:41] [travis-ci] wmde/WikibaseDataModel/statementclaimconstructor_compat/1cada02 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35459385 [17:58:13] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06statementclaimconstructor_compat: 02http://git.io/XnZfYg [17:58:13] 13WikibaseDataModel/06statementclaimconstructor_compat 148920718 15Bene: Add Statement::setClaim to release notes [18:45:00] (03CR) 10Jeroen De Dauw: "Since this is a public interface, verifying that it actually gets invoked at the right times and gets passed the correct stuff, would not " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160655 (owner: 10Daniel Kinzler) [18:57:26] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #188 148920718: That's kinda pushing what it means to be an addition :) 02http://git.io/dgjVYA [18:57:46] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06statementclaimconstructor_compat at 148920718: 02http://git.io/5buseA [18:58:06] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #186: Statement constructor takes Claim as an argument (06master...06statementclaimconstructor) 02http://git.io/OS-ytA [19:00:48] benestar: no, square [19:01:39] oh [19:01:45] MW 1.24 has not been released yet [19:01:52] That's why Travis fails to fetch it [19:01:57] >_> [19:02:01] :D [19:02:09] https://travis-ci.org/JeroenDeDauw/SubPageList [19:03:24] Time to install dat new PhpStormz [19:03:43] mh... maybe I should give phpstorm another shot [19:04:16] hoo: no shooting at poor old PhpStorm! [19:04:19] You evil person [19:05:15] JeroenDeDauw: can I use my Nyan Cat level 2 as ssl cert? [19:08:09] lazowik: sure, though the Nyansa might be able to crack it ofc [19:08:35] mhm [19:09:51] * benestar is happy with netbeans [19:10:05] Same here [19:10:16] although kdevelop was just freaking fast last time I tried it [19:10:21] lacked proper NS support, though [19:10:33] but they fixed that with 4.7 or so [19:10:48] JeroenDeDauw: when do you plan to release DataModel 1.1? [19:12:06] hoo: you saying that PHPStorm is slow?! [19:12:24] benestar: when it makes sense to do so? [19:12:24] phpstorm didn't start for me last time I tried [19:12:30] although I didn't try very hard :P [19:12:46] hoo: the start file had some evil check for openjdk [19:12:51] Since thet don't like openjdk [19:12:56] So you had to kill it [19:13:00] * hoo has openjdk [19:13:02] Looks like it's gone now tho [19:13:08] JeroenDeDauw: what are the criterias? [19:16:50] benestar: that the release is of use, and that you do not have stuff that should also be in there that is not yet (ie not a feature rel every other day) [19:17:06] Unless ofc your dev pace is so high this is warranted [19:17:09] ok, I see ;) [19:17:11] Though this is not the case for us [19:23:09] Well, first PhpStorm 8 bug... [19:23:11] https://youtrack.jetbrains.com/issue/WI-24807#u=1410895348082 [19:23:19] I hope I'm not going to regret upgrading so fast... [19:25:06] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06addreference: 02http://git.io/jdnWXQ [19:25:06] 13WikibaseDataModel/06addreference 146ccc62d 15Bene: Add addNewReference to ReferenceList [19:26:10] JeroenDeDauw: another question to semantic versioning [19:26:18] why were breaknig changes allowed in 0.8? https://github.com/wmde/WikibaseDataModel/blob/master/RELEASE-NOTES.md#version-08-2014-06-05 [19:26:49] benestar: because we where in the 0.x range [19:27:04] ah, and there it's ok to do so, I see [19:27:16] * aude someday teaches jeroen difference between where and were :D [19:27:22] but why did we move to the 1.x range? [19:27:23] we were in.. [19:27:33] where are the cookies :D [19:27:41] * benestar wants cookies [19:29:06] aude: huh? What are you talking about? [19:29:18] oh [19:29:26] english is confusing [19:29:36] aude: I did not actually see that was the same word [19:29:38] :D [19:30:10] and we're = wwe are [19:30:12] we are [19:30:12] aude: at lest English does not have au/ou and ei/ij [19:30:21] yeah [19:30:23] Eviiiiiil Dutch spelling is more difficult than English [19:30:51] aude: I know how the 're thing works [19:30:57] :) [19:31:32] JeroenDeDauw: should the guid stay in claim or be moved to statement? [19:32:10] benestar: claim, is ay [19:32:11] say [19:32:29] how does a claim work without guid? [19:35:08] meh [19:35:37] benestar: we should probably first consider what we want to do with GUIDs [19:35:54] https://github.com/wmde/WikibaseDataModel/issues/152 [19:36:04] By collecting a list of requirements [19:36:18] Right now it's not entriely clear what all the requirements are to me [19:36:42] One of the original assumptions was that we'd want to be able to track all claims by identity [19:36:53] Where this included all statements [19:37:20] If we change to composition, then we have no use for tracking the identity of the claim in a statement I think [19:37:27] Though what if you just have a Claim? [19:38:12] benestar: agree with putting this under 2.0 [19:39:02] JeroenDeDauw: I think basically we have to find out if we need claims outside of the datamodel [19:39:32] so if Claims are just something like Snaks to wrap data inside the model or if they should be used directly in entities or whatever [19:39:51] maybe I shall create an issue on github for that question? [19:40:10] we're now going to put statements on properties [19:40:24] i don't see where claims are used on their own [19:41:16] Yeah [19:41:29] We can probably get away with dropping GUIDs from Claim for that reason [19:41:35] We simply have no case where this is needed [19:42:17] We're going to end up with some naming mismatches at the edge of the system though [19:42:20] ie in the web API [19:42:31] modules with "claim" [19:42:36] in their name [19:42:49] Or the "claims" key in Item serializations [19:42:53] JeroenDeDauw: hmm, breaking that would be saner but people will cry [19:43:02] * aude cries! :D [19:43:12] benestar: you would efinitly want to migrate [19:43:16] not just break it [19:43:29] ie add a version with "statement" [19:43:37] Or rather, just alias the wrong name to it [19:43:49] Then the primary docs do not have the name mismatch [19:43:55] indeed, but first I think we can just say that in some places claims = statements [19:44:17] we don't know if we change all of that in half a year again [19:48:15] benestar: why would we change it again? [19:48:28] The current problem arises from the stuff not being well defined [19:48:36] We are now fixing that [19:48:50] So unless we do stupid stuff, it should not have to change again [19:48:54] JeroenDeDauw: well, I hope it won't but we don't know [19:49:15] I think we should just let the new stuff settle down and then change outside stuff [19:56:26] * benestar just notices that netbeans' update to 8.0.1 apparently broke all PHP features -.- [19:57:02] * hoo is on 7.4 [19:57:47] hoo: why? [19:57:57] * benestar is downgrading [19:58:14] Haven't bothered to upgrade yet [19:58:26] Tea is finished \o/ :D [19:58:50] PhpStorm 8.0 does not support the NyanCat runner! [19:58:52] How evil! [19:58:54] http://youtrack.jetbrains.com/issue/WI-24808 [19:58:56] Bastards [20:35:27] JeroenDeDauw: I +1'd it :P [22:04:00] Reedy: \o/