[00:52:00] legoktm: if you're around, can you delete https://www.wikidata.org/wiki/Q18043363 ? (it's a test page or something; that user has been filling the wmf cluster with them across several wikis) [00:52:10] okay [00:52:30] gone [00:52:37] meh [00:52:38] to slow [00:53:03] thanks [00:53:15] hoo: I need to get my admin action for this month! [00:53:31] :D [01:56:31] (03PS1) 10Hoo man: Fix DispatchStats::hasStats [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160376 [02:35:50] (03PS2) 10Hoo man: Fix DispatchStats::hasStats [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160376 [06:14:28] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06getallsnaks: 02http://git.io/6p1s6g [06:14:28] 13WikibaseDataModel/06getallsnaks 1485dc51a 15Bene: Add tests [09:28:38] [13WikibaseDataModel] 15addshore closed pull request #184: Add StatementList::getAllSnaks (06master...06getallsnaks) 02http://git.io/dMPdIA [10:00:35] (03PS1) 10WikidataBuilder: New Wikidata Build - 15/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160414 [10:01:34] (03Abandoned) 10Aude: New Wikidata Build - 15/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160414 (owner: 10WikidataBuilder) [10:06:41] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160414 (owner: 10WikidataBuilder) [10:21:59] (03PS1) 10Adrian Lang: Use new way of getting a token from the API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160417 [10:35:00] * hoo waves [10:57:33] (03Abandoned) 10Hoo man: Remove the populateSitesTable maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145765 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [10:58:35] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=42207 WONTFIX ? [10:58:51] * aude sighs [10:59:14] * aude wants it moved somewhere [10:59:19] mh... shall we attempt to generalize it and then move to core? [10:59:26] sure [11:00:33] otherwise we keep having to do https://gerrit.wikimedia.org/r/#/c/155119/ :P [11:00:43] rather annoying [11:01:41] aude: updated the bug [11:01:50] ok [11:02:24] * aude eats [11:02:58] (03PS3) 10Tobias Gritschacher: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [11:04:15] (03CR) 10Tobias Gritschacher: "@Adrian: the link to bugzilla was missing in the commit message. that makes it clearer what this is about. it changes behavior, so that yo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) (owner: 10Henning Snater) [11:07:22] (03CR) 10Hoo man: [C: 032] "Manually verified" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160417 (owner: 10Adrian Lang) [11:11:35] (03CR) 10Hoo man: [C: 032] Improve usage of global state in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159771 (owner: 10Bene) [11:20:36] (03Merged) 10jenkins-bot: Use new way of getting a token from the API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160417 (owner: 10Adrian Lang) [11:20:38] (03Merged) 10jenkins-bot: Improve usage of global state in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159771 (owner: 10Bene) [11:20:51] (03PS1) 10Adrian Lang: Remove unused wikibase.RepoApi.removeSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160422 [11:22:08] (03PS1) 10Hoo man: Update comment about lib in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160424 [11:25:30] (03CR) 10Hoo man: [C: 032] "Not even used in user JS" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160422 (owner: 10Adrian Lang) [11:36:08] (03Merged) 10jenkins-bot: Remove unused wikibase.RepoApi.removeSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160422 (owner: 10Adrian Lang) [11:52:42] (03PS1) 10Adrian Lang: Move wbparsevalue and wbformatvalue calls to RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160429 [12:02:27] (03CR) 10jenkins-bot: [V: 04-1] Move wbparsevalue and wbformatvalue calls to RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160429 (owner: 10Adrian Lang) [12:02:50] * hoo scratches head [12:03:08] Oho [12:03:36] Fiddling with badges in client... [12:04:15] hoo: you see daniel's patches? [12:04:32] aude: I was about to test how it acts on old parser cache [12:04:41] but looks like badges don't work for me at all in client [12:04:43] even on master [12:04:44] https://gerrit.wikimedia.org/r/#/c/159345/ [12:04:49] really? [12:05:12] Maybe I just screwed something up [12:05:34] i think the strategy is that we can have the pages using badges purged (with a script or such) [12:05:46] plus update cache epoch (in a gradual manner) [12:05:57] with https://gerrit.wikimedia.org/r/#/c/159345/, badges don't work [12:05:58] yeah, that makes sense [12:06:12] then -1 it, please [12:06:19] ok [12:06:32] well, i guess i need to look at the new patchsets [12:06:35] (03PS2) 10Adrian Lang: Move wbparsevalue and wbformatvalue calls to RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160429 [12:06:37] Henning_WMDE: Adrian_WMDE: I assume the browsertests have not been adjusted for the sitelinkgroup-edit mode [12:06:41] right? [12:06:45] (03CR) 10Hoo man: "nit picks (couldn't yet test :S)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [12:06:56] of course [12:06:58] not [12:07:02] ha [12:07:04] if not, I'll do this right now. [12:07:05] ;) [12:07:14] shizzle! [12:07:16] hoo: daniel changed a bit so i would need to try it again [12:08:31] ok [12:08:44] I'm also trying a bit more [12:09:15] now it looks like badges are obtained from the full entity (since they are not available in SiteLinkLookup) [12:09:25] and added to parser output [12:09:35] yeah [12:09:52] * aude messing with vagrant and such to debug the serialiation issues we had last week [12:09:58] grrr [12:10:08] so can't test badges right now [12:10:09] why aren't badges working for me on master [12:11:51] i am sure they worked withthe SidebarHookHandlers patches [12:12:03] but you might try reverting them and see? [12:12:31] q [12:12:53] trying that [12:13:24] mh, getting an exception now :P [12:13:26] the last patch of daniels "rewrite the logic" was very confused [12:13:29] oooo [12:13:40] the one i commented on [12:14:02] hoo: do you know where i can see logs in vagrant? [12:14:16] what kind of logs? [12:14:20] i disabled property suggester (which jenkins says is broken) [12:14:40] then my "wikidata" vagrant wiki does not load still [12:14:46] if i disable wikibase, then it loads [12:15:01] so, like fatals? [12:15:12] /var/log/apache/error_log [12:15:15] not sure [12:15:16] nope [12:15:18] :S [12:15:26] not in /var/log/upstart/hhvm.log [12:15:38] i wonder if there is logging at all for hhvm in vagrant [12:16:22] look into /tmp [12:16:29] good idea [12:16:52] Nope, can't get badges to work... even if I jump before Daniel's changes :( [12:17:08] Wikibase]$ git status [12:17:08] HEAD detached at d8c1ca7 [12:17:10] do you have appropriate settings? [12:17:22] it's quite complex to set up [12:17:32] I think so [12:17:42] and the wikidata.org and wikimediabadges components? [12:17:44] on repo they work for me on ages (as I wrote part of the code) [12:17:51] latter which is autoloaded via composer [12:17:59] Nope, don't need these right now... just want to see the classes being set [12:18:02] ok [12:18:13] they simply don't appear [12:18:25] found the logs! [12:18:28] /vagrant/logs [12:19:51] I disabled objectcache... maybe that was breaking it [12:25:42] nope [12:30:36] DanielK_WMDE_: hey [12:30:47] any idea why badges might be totally broken in client for me? [12:31:09] Fatal error: Class 'DataValues\LatLongValue' not found [12:31:25] on non-hhvm, normal dev wiki [12:31:52] "data-values/geo": "~1.0.0", [12:31:55] aude: New Geo version [12:31:57] do you have that? [12:32:02] Should be fixed [12:32:03] composer updating [12:33:06] works now [12:35:00] Badges still don't work for me... what the... [12:35:25] hoo: o.O [12:35:31] they work for me [12:35:43] hoo: we refactored the code for them [12:35:53] maybe some caching issue? [12:35:58] #$wgWBRepoSettings['internalEntitySerializerClass'] = 'Wikibase\Lib\Serializers\LegacyInternalEntitySerializer'; [12:37:02] * aude cries [12:37:07] oh [12:37:27] Should I uncomment that? [12:37:29] reeeeview https://gerrit.wikimedia.org/r/#/c/159837/ ! [12:37:58] otherwise, i get a warning about missing argument [12:38:02] (03CR) 10Bene: [C: 032] Update comment about lib in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160424 (owner: 10Hoo man) [12:38:19] which only happens if you have abuse filter, etc. [12:39:00] (03CR) 10Hoo man: [C: 032] "JSON sounds good as we immediately throw this into json_decode" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159837 (owner: 10Aude) [12:39:05] thanks [12:39:31] some places in the code, $format is optional [12:39:36] so i got confused [12:40:17] "PHP Fatal error: Maximum function nesting level of '200' reached, aborting!" whoops :D [12:40:23] woah [12:42:01] badges work, editing and then appearing correctly in client [12:42:08] upon purge [12:42:19] mhh :( [12:42:33] hoo: wtf [12:42:40] on master? [12:42:52] yep [12:44:57] hoo: question: do we use EntityContent::STATUS_* anywhere? [12:45:11] my netbeans cannot find any usages of it [12:45:40] i thought [12:45:43] it was for page_props [12:45:52] repo/tests/phpunit/includes/content/ItemContentTest.php [12:45:52] 138: EntityContent::STATUS_NONE [12:45:52] 146: EntityContent::STATUS_NONE [12:46:04] and in EntityContnet itself [12:46:07] benestar: to add a 'stub', and such (e.g. if an item has no site links or something) [12:46:24] repo/includes/content/ItemContent.php [12:46:24] 278: } else if ( $status === self::STATUS_STUB && $hasSiteLinks ) { [12:46:34] ok, but nowhere else in the code [12:46:39] so it is basically useless? :O [12:46:57] repo/includes/content/ItemContent.php [12:46:57] 276: if ( $status === self::STATUS_EMPTY && $hasSiteLinks ) { [12:47:06] so it's used, but not very often [12:47:09] benestar: i think it might be used/useful for special pages [12:47:24] itemswithoutsitelinks [12:47:28] or something [12:47:43] aude: hmm, might be useful is not a good argument to put it in such a prominent place... [12:47:55] heh [12:48:01] rage to DanielK_WMDE_ :) [12:48:34] ;P [12:48:44] damn badges :P [12:48:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=40157 [12:52:54] (03Merged) 10jenkins-bot: Update comment about lib in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160424 (owner: 10Hoo man) [12:53:15] (03Merged) 10jenkins-bot: Specify format in EntityContent::getTextForFilters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159837 (owner: 10Aude) [12:54:58] huh, so $wgMainCacheType in vagrant is none ? [12:55:53] $navId = $languageLinkTitle->getInterwiki(); [12:55:53] if ( !$sites->hasNavigationId( $navId ) ) { [12:55:53] return; [12:56:22] aude: ^ that is returning all the time for me... is my site table outdated? [12:56:47] MariaDB [dewiki]> SELECT * FROM site_identifiers; [12:56:47] Empty set (0.00 sec) [12:58:00] that would be a problem [12:58:27] mh [13:00:30] how do I propagate those? [13:01:09] think you need --site-group in populateSitesTable script [13:01:24] i don't know if it's automatic [13:01:34] trying [13:01:51] that's it [13:02:26] now they work for me... meh [13:02:30] what a mess [13:02:47] * aude hates maintaining sites tables [13:12:51] (03CR) 10Hoo man: "This works for me, apparently even without purging (which is weird)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [13:13:10]

(CR) Hoo man: "This works for me, apparently even without purging (which is weird)." [extensions/Wikibase] - https://gerrit.wikimedia.org/r/159345 (owner: Daniel Kinzler) [13:13:14] DanielK_WMDE_: ^ [13:13:17] is that realistic? [13:13:51] are they cached? [13:14:12] the sidebar might be cached [13:14:16] yeah [13:14:21] not the language links [13:14:37] not in same way as $wgEnableSidebarCache, at least [13:14:53] mh [13:14:56] it is cached in some way [13:15:06] parsre cache, memcached [13:15:26] memcached for site list [13:15:36] which we should not access, except in parse [13:15:47] if I use uselang=es on my dewiki w/o purging the parser cache badges are gone [13:15:53] oh [13:16:14] confused [13:16:31] i can give the patch a try [13:17:06] now badges seem to stay if I use uselang=es [13:17:08] mh [13:17:20] badges are gone (no purge) [13:17:26] action=purge [13:17:28] they are there [13:18:00] ok... so a purge is required [13:18:14] just saw that again as well [13:19:09] (03CR) 10Aude: [C: 031] "not looked at the code in much detail, except see the badges are obtained from full entity and added to parser ouptut." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [13:19:27] i'll let someone else merge or nitpick at the code :p [13:19:42] aude: how do you plan to purge all badge pages? [13:20:01] either a script/bot + cache epoch [13:20:13] cache epoch which we change gradually [13:20:15] (03CR) 10Hoo man: "It doesn't work without purging the parser cache... so this needs a special treatment for deploying." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [13:20:22] hoo: https://lists.wikimedia.org/pipermail/wikidata-tech/2014-September/000603.html [13:20:32] cache epoch which we change gradually << how should that look in detail? [13:20:52] hoo: like we do on wikidata, but .... [13:21:06] parser cache is cached for a year, so maybe we bump it to 11 months [13:21:15] then 10 months [13:21:46] benestar: saw that... but that change is here *now* and waiting for review [13:22:06] for badges, we need a way to track what items they are used on [13:22:24] then purge the linked pages, which is a small subset [13:22:42] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=70229 [13:22:46] that? --^ [13:22:55] pretty much, yes [13:23:43] hmmm, i wonder if we want them in page_props (in client?) [13:24:11] won't help with now but could be useful [13:24:17] don't really see the value of having them in page_props [13:24:30] maybe, if we solve 70229 [13:24:50] another table sounds ok to me [13:25:32] yeah [13:25:40] but how are we going to handle that patch... now [13:25:52] (03PS5) 10Bene: [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 [13:26:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 (owner: 10Bene) [13:26:25] idk, with json or xml dump, we can probably find all the pages eaily [13:26:27] easily [13:26:35] possible [13:29:26] (03CR) 10Hoo man: "@Daniel: Can we another bug for this and then merge this now?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [13:31:37] bah, composer update in hhvm.... [13:31:45] Fatal error: Maximum execution time of 180 seconds exceeded in phar://composer.phar/bin/../src/../src/Composer/Util/ErrorHandler.php on line 36 [13:32:28] oO [13:32:51] xD [13:32:53] (03PS10) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [13:32:57] 3 minutes is not that long [13:33:27] it's an Adrian_WMDE :D [13:33:58] * aude gives someone else a bug https://bugzilla.wikimedia.org/show_bug.cgi?id=70843 [13:35:10] (03CR) 10Hoo man: [C: 04-1] "As discussed before" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159103 (https://bugzilla.wikimedia.org/70333) (owner: 10Bene) [13:36:24] benestar: it is [13:41:50] (03CR) 10Hoo man: [C: 031] Possible refactoring of siteselector._selectFirstSite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [13:49:45] (03PS7) 10Adrian Lang: Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 [13:49:47] (03PS1) 10Adrian Lang: Let mw.Api handle params and token in RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 [13:49:49] (03PS1) 10Adrian Lang: Make RepoApi.post private (rename to RepoApi._post) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 [13:49:51] (03PS1) 10Adrian Lang: Move handling of remote APIs out of RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 [13:50:22] (03CR) 10Adrian Lang: [C: 04-1] "Restore -1, still needs a factory." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [13:54:05] How do I merge items? [13:54:29] benestar: ping [13:56:27] hoo: yes? [13:56:53] benestar: https://gerrit.wikimedia.org/r/#/c/158631/11/repo/tests/phpunit/includes/ItemViewTest.php [13:56:57] LewisHulbert: There is a gadget called merge which you can enable in your preferences [13:56:59] do you have any replacement for these tests? [13:57:05] (03PS2) 10Adrian Lang: Make RepoApi.post private (rename to RepoApi._post) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 [13:57:07] (03PS2) 10Adrian Lang: Let mw.Api handle params and token in RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 [13:57:09] (03PS8) 10Adrian Lang: Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 [13:57:11] (03PS2) 10Adrian Lang: Move handling of remote APIs out of RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160444 [13:57:13] benestar: thanks [13:57:25] (03CR) 10Adrian Lang: [C: 04-1] "restore once more" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [13:57:30] hoo: the tests were already moved to another place before [13:57:42] and new tests are added in the third patch of the chain [13:57:49] ewk [13:57:51] ok [13:57:52] which I'm currently rebasing -.- [13:58:05] so this should probably not be merged alone [13:58:15] hoo: benestar: Might want to merge the stuff above before I return tomorrow; it'll only get worse otherwise :D [13:58:40] Adrian_WMDE: I'll try to have a look... and the JS always gets worse anyway :D [13:59:34] (03CR) 10Hoo man: [C: 031] "Looks good at a glance, untested." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [14:00:01] hoo: :P Not true [14:00:49] (03CR) 10Daniel Kinzler: "@hoo: there are relatively few pages with badges. manual purging or a bot run would do, I think. Perhaps ask Amir." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:01:52] benestar: Now there's an empty entry, do I nominate it for deletion or something? [14:02:04] benestar: want to have a look at the badge rewrite again? i think it's good to go, but you are the badge man ;) [14:03:28] it's a DanielK_WMDE_ ! [14:03:39] * DanielK_WMDE_ waves [14:03:43] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #184 1485dc51a: You do realize you can now simply do `$list->addNewSnak( ... )` right? 02http://git.io/A5M-ag [14:05:25] (03CR) 10Daniel Kinzler: Rewrite badge display logic. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:05:45] (03PS14) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [14:09:22] (03PS15) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [14:10:36] (03CR) 10jenkins-bot: [V: 04-1] Inject configured mwApi into RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145281 (owner: 10Adrian Lang) [14:10:46] (03PS16) 10Hoo man: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:11:57] (03CR) 10Hoo man: [C: 032] "Added Deploy note, should be good now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:12:35] (03PS6) 10Bene: Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [14:14:34] DanielK_WMDE_: working on xml bug? [14:14:58] for whatever reason, people (or someone) likes to use it a lot, hence spamming the logs [14:14:58] aude: yes. still need to fix the one api test. [14:15:01] ok [14:15:22] if the fix is reasonably not scary, i'd like it backported so we don't have to wait [14:15:27] (03PS6) 10Bene: [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 [14:15:30] this would be so much easier with proper mocking for api tests [14:15:42] yep [14:16:17] ...and the local behavior is different from what happens on jenkins... ugh [14:16:38] wahtever is using the xml, the operator doesn't even apparently notice [14:16:58] since it's been broken 2 weeks now but is still trying to use it [14:19:01] (03PS7) 10Bene: [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 [14:20:20] (03CR) 10Bene: [C: 031] "I also think that regression tests go beyond this simple bug fix." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [14:20:49] (03CR) 10jenkins-bot: [V: 04-1] Make RepoApi.post private (rename to RepoApi._post) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160443 (owner: 10Adrian Lang) [14:21:02] (03CR) 10jenkins-bot: [V: 04-1] Let mw.Api handle params and token in RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160442 (owner: 10Adrian Lang) [14:24:20] [13WikidataBrowserTests] 15tobijat created 06sitelinkgroup_edit (+1 new commit): 02http://git.io/3qU0VQ [14:24:20] 13WikidataBrowserTests/06sitelinkgroup_edit 1473155e1 15Tobias Gritschacher: Adjust sitelink browsertests to sitelinkgroup edit-mode [14:24:41] Henning_WMDE: https://github.com/wmde/WikidataBrowserTests/pull/9 [14:24:45] [13WikidataBrowserTests] 15tobijat opened pull request #9: Adjust sitelink browsertests to sitelinkgroup edit-mode (06master...06sitelinkgroup_edit) 02http://git.io/MhP7xQ [14:26:50] hoo: http://www.w3.org/TR/html401/interact/forms.html#edef-LABEL and http://stackoverflow.com/questions/774054/should-i-put-input-tag-inside-label-tag [14:27:06] so putting the checkbox into the label is semantically correct [14:27:11] (03CR) 10jenkins-bot: [V: 04-1] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 (owner: 10Bene) [14:27:13] (03Merged) 10jenkins-bot: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:27:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 (owner: 10Bene) [14:30:26] (03PS4) 10Bene: Use checkboxes instead of multiselect to edit badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159103 (https://bugzilla.wikimedia.org/70333) [14:30:36] benestar: As we don't care for screen readers... whatever [14:31:02] hoo: we don't? [14:31:08] hoo: so here you go with the

;) [14:31:15] * aude cares [14:31:25] DanielK_WMDE_: Apparently [14:31:26] but I think screen readers should follow W3 suggestions [14:31:44] well, afk now [14:31:49] cu tomorrow or so [14:31:53] benestar: they should, but they don't. [14:32:01] Of course they should, but that's not that easy [14:32:05] (just like browsers) [14:32:18] and I'm not going to test that now... screen reader testing is time eating [14:32:33] hoo: forget about it and merge my patch :P [14:32:37] I added

s [14:32:41] just editing wikipedia is hard on screen reader [14:32:41] bye [14:32:42] very hard [14:32:54] can't imagine trying to edit wikidata, but we still should care [14:33:12] aude: javascript support on screen readers? o.O [14:33:21] benestar: they doo [14:33:22] do* [14:33:39] Kind of :( [14:33:42] not sure if they also support such a complex ui as wikidata's [14:33:48] they should [14:33:54] if we made it properly [14:34:02] They tend to go crazy on DOM changes... so I fear not [14:34:06] I never even tested it [14:34:10] screen reader users tend to use mobile versions [14:34:22] they already go crazy at core MW and that's not a lot of crazy scripty stuff [14:34:22] so editing with mobile wikipedia would be pretty easy [14:34:32] for wd, they should probably use the non-js interface [14:34:35] but that's incomplete :/ [14:34:36] there is no mobile wikidata [14:34:39] DanielK_WMDE_: rage [14:34:47] hehe [14:37:24] (03PS5) 10Daniel Kinzler: Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [14:37:49] (03PS4) 10Daniel Kinzler: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158090 (owner: 10Thiemo Mättig (WMDE)) [14:37:55] (03PS6) 10Daniel Kinzler: Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [14:38:02] (03PS14) 10Daniel Kinzler: Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [14:38:15] aude: --^^^ [14:38:32] ok [14:38:42] * aude deploying but can look when done [14:39:20] * DanielK_WMDE_ is curious what jenkins has to say now [14:51:10] (03PS1) 10Henning Snater: Implemented badge selector widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160456 [15:39:23] (03PS4) 10Henning Snater: Moved edit feature from sitelinkview to sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159989 (https://bugzilla.wikimedia.org/68908) [15:42:38] [13WikibaseDataModelSerialization] 15JanZerebecki created 06compose-EntitiySerializer (+1 new commit): 02http://git.io/X5qo1w [15:42:38] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 144c57110 15Jan Zerebecki: Do no inherit from EntitySerializer.... [15:53:46] (03PS3) 10Henning Snater: Move wbparsevalue and wbformatvalue calls to RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160429 (owner: 10Adrian Lang) [15:54:19] (03CR) 10Henning Snater: [C: 032] Move wbparsevalue and wbformatvalue calls to RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160429 (owner: 10Adrian Lang) [16:06:29] (03Merged) 10jenkins-bot: Move wbparsevalue and wbformatvalue calls to RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160429 (owner: 10Adrian Lang) [16:55:52] (03CR) 10Jeroen De Dauw: [C: 031] "Is this fixes a bug, then it'd be nice if you added a new test to verify that bug is not present" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158090 (owner: 10Thiemo Mättig (WMDE)) [16:57:32] (03CR) 10Jeroen De Dauw: [C: 031] Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [17:35:35] is anyone here working with Wikidata Toolkit at the moment? [17:36:23] Markus told me about a binary dataformat he created to store WIkidata in memory for parsing, which I'd like to set up, but need some pointing in the right direction. [18:45:24] aude: When do we plan to push those fixes? [18:45:36] once we merge the xml [18:45:56] Can we do that tomorrow? [18:46:07] maybe or wednesday [18:47:11] I'd prefer tomorrow, if we can do that [18:47:22] ok [18:47:23] Can I help with that or does it require attention by Daniel? [18:47:34] review his patches :) [18:47:36] for xml [18:47:51] i made the tests so can +1 but can't +2 everything [18:47:57] I planned to do some more code review later on anyway ;) [18:48:01] and ideally it all is merged together [18:48:12] ok [18:51:11] hoo: added us for swat tomorrow [18:52:25] :) [19:08:52] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06compose-EntitiySerializer from 144c57110 to 1474c944b: 02http://git.io/qVv3IQ [19:08:52] 13WikibaseDataModelSerialization/06compose-EntitiySerializer 1474c944b 15Jan Zerebecki: Do no inherit from EntitySerializer.... [19:24:38] (03CR) 10Addshore: [C: 032] Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158090 (owner: 10Thiemo Mättig (WMDE)) [19:24:43] (03PS5) 10Addshore: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158090 (owner: 10Thiemo Mättig (WMDE)) [19:24:52] (03PS7) 10Addshore: Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [19:24:59] (03CR) 10Addshore: [C: 032] Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [19:25:04] (03PS15) 10Addshore: Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [19:25:09] (03CR) 10Addshore: [C: 032] Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [19:46:59] (03Merged) 10jenkins-bot: Fix OPT_INDEX_TAGS not properly delegated [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158090 (owner: 10Thiemo Mättig (WMDE)) [19:47:01] (03Merged) 10jenkins-bot: Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [19:57:07] hoo|away: It's happening again. [20:01:24] doh doh doh [20:01:51] sjoerddebruin: mh... which wiki? [20:01:56] nlwiki again [20:02:24]