[09:15:03] Lydia_WMDE hey ;) [09:15:06] around? [09:53:07] benestar: hey [10:00:29] (03PS1) 10WikidataBuilder: New Wikidata Build - 14/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160272 [10:09:40] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 14/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160272 (owner: 10WikidataBuilder) [10:15:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160272 (owner: 10WikidataBuilder) [10:46:09] Lydia_WMDE: Is this going to be better in the new design? https://www.dropbox.com/s/gfowttef31dk3ph/Schermafdruk%202014-09-14%2012.45.58.png?dl=0 [10:46:31] yes [10:46:34] :) [10:46:46] It's too small there. :P [10:46:53] yeah :) [10:47:06] if it doesn't work in one of the first iterations poke me. definitely something that needs to work in the new one [10:47:42] 20% of my screen doesn't get used. :/ [12:09:02] Pages show up in https://nl.wikipedia.org/wiki/Speciaal:OngekoppeldePaginas but they have a item, most of them have a recent edit on Wikidata. Is it a cache thing? [12:09:50] that special page is a terrible mess [12:09:59] and no, it's not cached [12:10:05] will have a quick look [12:11:12] sjoerddebruin: Do you have an example of a page there that has an item? [12:11:18] the first few I've checked look ok [12:11:35] The Albert ones I think [12:12:00] (I'm also null editing those pages atm, so I stop now) [12:12:13] indeed, yes [12:12:25] Albert van Citters by example [12:12:38] purging them fixes the problem [12:12:56] Yes, but that's not my task. [12:13:02] the system should do that [12:13:25] The "system" wont do that automatically [12:13:31] I can kick it of per hand, though [12:13:44] (but that's quite some work) [12:17:04] hoo: sometimes they show up with the "X interlanguage links on the page" behind them, but there are no local interlanguage links. [12:23:10] not at all local language links anymore? [12:23:43] at least here: https://nl.wikipedia.org/w/index.php?title=Arbeidspsychologie&action=edit [12:24:00] You have to look onto the second page [12:24:09] I just purged all pages on the first one [12:24:12] Arbeidspsychologie is a conflict :P [12:24:28] Take a look at "Charles Lefebvre" [12:24:49] Or "Daniel Fedrigo" [12:26:09] Or most of the David's. [12:26:17] btw I have a nice gadget that highlights those pages that aren't on Wikidata [12:26:23] page_touched: 20140914121755 [12:26:23] page_links_updated: 20140914120032 [12:26:59] Stryn: Nice, but I want a special page that works like described. [12:27:06] sure [12:27:20] * Stryn wants too [12:27:39] hoo: Can I call that "lag"? :) [12:28:02] No :( [12:28:14] What is it then? [12:28:22] the wikibase item isn't showing up in page props for page_title: Charles_Lefebvre [12:28:27] and I've no idea why [12:28:28] :S [12:28:33] Stryn: you forgot the object in your sentence [12:29:08] Sounds like https://bugzilla.wikimedia.org/show_bug.cgi?id=53562 [12:30:01] only a null edit could fix it :S [12:31:36] It's annoying, because I'm working and the content moves the whole time. [12:32:49] And the amount of pages is pretty high. I've been on that page for about a week and I never experienced this. [12:34:15] literally every item with a nlwiki sitelink and a recent edit shows up [12:34:54] I doubt that [12:34:57] ... taht would be very scary [12:35:12] unless hhvm job runners knock us over again [12:36:13] yep [12:36:15] -.- [12:36:15] sight [12:36:17] * sigh [12:36:24] sjoerddebruin: Will be fixed in a second [12:36:26] :) [12:39:33] sync-common on that box takes ages :S [12:39:46] ... and it's done :D [12:39:50] almost [12:40:08] Stryn: Btw, I don't make items for most of the pages on the first page because they are nominated for deletion or there is a merge nomination for them. The one's with local interwiki's are conflicts that need some attention. [12:41:02] yeah, it takes a lot of time to fix those conflicts... and you need to know many languages [12:41:40] or know something about the subject [12:41:55] I think https://www.wikidata.org/wiki/Q2045692 needs to be split up. [13:47:39] This seems double, isn't it? https://www.wikidata.org/wiki/Special:Contributions/BrackiBot [13:47:50] Most of them already have the subclass of that. [13:48:05] It's running on top speed. [13:48:49] uh [13:49:17] tststs [16:11:56] is there a problem with editing ? [16:12:03] I get "invalid token" [16:15:39] only in chrome not firefox [16:16:08] When? [16:16:24] Try to relog in and clear your cache [16:18:02] (03CR) 10Jeroen De Dauw: "This seems to address my concerns with the previous approach. Yay." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [16:19:03] (03CR) 10Jeroen De Dauw: "Also yay for removing 200 lines!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [17:34:12] JeroenDeDauw: have you really done nothing over the past two weeks? :p [17:44:29] hoo: Don't suppose you have a minute to check something quickly? :p [17:48:39] JohnFLewis: I have [17:48:58] hoo: a Lydia appeared out of no where and is doing it :) [17:49:23] It's a Lydia \o/ [17:49:36] :P [17:59:39] aude: doh [17:59:48] found the DiffViewTest bug we were searching [18:01:19] (03PS1) 10Hoo man: Call parent::tearDown in FingerprintViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160289 (https://bugzilla.wikimedia.org/70659) [18:14:22] (03CR) 10Bene: [C: 032] Call parent::tearDown in FingerprintViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160289 (https://bugzilla.wikimedia.org/70659) (owner: 10Hoo man) [18:14:45] thanks, benestar :) [18:14:51] Hopefully that fixes the linked bug [18:15:34] hoo|away you're welcome ;) [18:24:16] (03Merged) 10jenkins-bot: Call parent::tearDown in FingerprintViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160289 (https://bugzilla.wikimedia.org/70659) (owner: 10Hoo man) [18:40:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/85a4e32 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/35274650 [18:58:08] * aude owes chocolate to hoo and benestar :) [18:58:32] :O [19:06:00] \o/ [19:09:32] aude: https://gerrit.wikimedia.org/r/160292 To prevent this in the future [19:21:38] hoo: :) [19:21:46] for when we use MediaWikiTestCase [19:22:02] In other cases it wont really matter [19:22:14] as only MediaWikiTestCase tearDown fixes state [19:22:26] i see [19:22:48] (03Abandoned) 10Aude: New Wikidata Build - 14/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/160272 (owner: 10WikidataBuilder) [19:29:14] (03CR) 10Bene: "Jeroen: So you are ok with this if I put a TODO on top of the class?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [19:29:21] JeroenDeDauw --^ [19:31:20] hoo can you give https://gerrit.wikimedia.org/r/#/c/159103/ a review? [19:31:41] maybe [19:31:51] oh that [19:32:15] Has Henning be consulted? [19:33:21] (03PS11) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [19:33:41] * been [19:33:42] he is added as a reviewer [20:23:23] benestar: Did you intend to wrap the checkboxes in the ? [20:25:39] !nyan | benestar | hoo [20:25:40] benestar | hoo: ~=[,,_,,]:3 [20:29:41] hoo: yes, otherwise they are placed on the moon [20:30:26] we could also add specific styles to that special page but I think this is completely valid HTML and nothing prevents us from putting the checkbox inside the label tag [20:31:04] it's not really semantically correct [20:31:10] eg. screen readers will get confused [20:34:55] hoo: would you be happy with wrapping both label and checkbox into a

and adding the wb-label class to the

? [20:35:08] JeroenDeDauw: I've got a question [20:35:24] creating a ClaimsView currently is not really nice [20:36:02] JeroenDeDauw: http://pastebin.com/TXPJEsWw so many lines are needed to create it [20:36:41] benestar: Sounds ok... except that the class name wont fit [20:36:48] yeah [20:37:11] JeroenDeDauw: should a new factory class be created to do this creation or does a static method inside ClaimsView suffer? [20:37:22] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa [20:37:27] because c&p-ing the code around isn't very nice [20:37:48] Service creation should always be done outside of the service objects themselves [20:37:55] In factories or DI containers [20:37:57] * benestar thinks JeroenDeDauw saw monsters [20:38:21] so a factory class? [20:38:57] benestar: ye [21:33:03] hahaha [21:33:07] the first single in Wikidata [21:33:09] Q57 [21:33:11] \o/ [21:35:20] did i... just get Rick Rolled..? [21:37:22] moogsi: don't worry, I'm never going to give you up! [21:37:45] !q 695677 [21:37:45] https://www.wikidata.org/wiki/Q695677 [21:37:51] That id is a bit bigger o_O [21:39:18] hah [21:41:30] :P [21:43:16] JeroenDeDauw: is it very evil to pass a WikibaseRepo instance around? [21:43:27] I think it is better than always calling the singleton [21:43:29] benestar: generally, yes [21:43:53] benestar: nope, it just pretends to be nice [21:43:59] so in EntityContent where we create all the objects because we have to there I thin it's ok [21:44:06] * to do there [21:44:35] If it's an entropy point to our code, then youn will need to interact with the global factory there [21:44:43] But get only the stuff you need from it [21:44:46] it's a bit tricky because this is a place where global state is allowed [21:44:46] Don't pass it around [21:46:49] No but I'll make sure [21:47:05] kk [21:47:46] JeroenDeDauw: I think https://gerrit.wikimedia.org/r/#/c/160305/ will be a good solution finally [21:47:56] https://www.youtube.com/watch?v=oHg5SJYRHA0 [21:48:02] * Mr-Potter lost the game [21:51:03] Mr-Potter: sacreficing a benestar to the almighty NyanCat will make your loss go away [21:51:17] rally? whats a benestar? go write an article [21:51:20] It can be any benestar, even a wild one, so just capture one if you see it [21:52:07] * benestar hide [21:52:09] *s [21:52:09] * Nemo_bis gives his benestare [21:52:18] Mr-Potter: it's a form of semi-sentient life, often found on IRC channels. It converts questions into code review load [21:52:33] Thanks [21:52:37] lol [21:53:12] Facinating [21:53:26] huh [21:55:16] JeroenDeDauw: is there any non-deprecated way to get the statements of an item? [21:55:40] benestar: $item->getStatements() ? [21:56:06] oh, forgot about that [21:56:10] :D [21:56:11] * benestar hits netbeans [21:56:38] Mr-Potter: as you can see, sometimes they might get slightly violent, but they are not too dangerous overall [21:56:43] Unless you are an IDE [21:56:43] :O what [21:56:57] JeroenDeDauw: and getAllClaims? [21:57:24] benestar: what is that? I don't even [21:57:38] JeroenDeDauw: it is deprecated in Entity [21:57:44] but highly used in our codebase [21:57:51] so there should be an equivalent in StatementList [21:58:44] sorry, * getAllSnaks [21:58:56] typo :-/ [22:03:53] benestar: I'd like to keep StatementList simple [22:04:20] JeroenDeDauw: it needs that method [22:05:10] benestar: what method? getAllSnaks is in Statement no? [22:05:19] yes, and in entity [22:05:32] so we need one in statementlist when we deprecate the one in entity [22:05:46] otherwise we cannot remove the deprecated uses of getAllSnaks [22:07:14] JeroenDeDauw: we are currently 1.1, right? [22:10:44] [13WikibaseDataModel] 15Benestar created 06getallsnaks (+1 new commit): 02http://git.io/Nr2k7Q [22:10:44] 13WikibaseDataModel/06getallsnaks 148972d51 15Bene: Add StatementList::getAllSnaks [22:10:55] [13WikibaseDataModel] 15Benestar opened pull request #184: Add StatementList::getAllSnaks (06master...06getallsnaks) 02http://git.io/dMPdIA [22:10:57] JeroenDeDauw: my last commit for today [22:11:11] merge? :D [22:11:17] gn8 [22:12:34] [travis-ci] wmde/WikibaseDataModel/getallsnaks/8972d51 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/35288452