[01:54:57] why doesn't wikidata convert its arrays to be 1-based before it gives them to lua? [08:14:07] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/157689/ [08:15:21] (03PS4) 10Tobias Gritschacher: Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 (owner: 10Henning Snater) [08:15:46] (03PS2) 10Tobias Gritschacher: Optimized applying wb-empty class in label/descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158606 (owner: 10Henning Snater) [08:31:34] (03CR) 10Henning Snater: [C: 032] Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [08:37:25] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=66653 [08:40:53] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=64820 [08:41:19] (03Merged) 10jenkins-bot: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [08:47:10] aude: around yet? :) [08:47:22] hoo: not in the office yet [08:47:33] mh [08:47:42] is Lydia still away? [08:47:49] hoo: back on monday [08:48:19] Ok, so I guess aude will do the call this evening [08:48:43] hoo: aude and danielK I think [08:48:59] like last week [08:49:23] hoo: although we had a call with Nik yesterday [08:50:58] * hoo is not up to date [08:51:58] hoo: I think it was mostly on how to deal with query and dbal. I was not attending though. aude and danielk can give you an update once they're here [08:52:44] (03PS1) 10Henning Snater: Fixed toggling action message when saving empty label/description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159681 [08:52:50] Tobi_WMDE_SWE: ^ [09:02:43] (03CR) 10Tobias Gritschacher: [C: 032] Fixed toggling action message when saving empty label/description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159681 (owner: 10Henning Snater) [09:13:21] (03Merged) 10jenkins-bot: Fixed toggling action message when saving empty label/description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159681 (owner: 10Henning Snater) [09:14:38] [13WikibaseInternalSerialization] 15filbertkm created 061.2.1 (+1 new commit): 02http://git.io/shXA_g [09:14:38] 13WikibaseInternalSerialization/061.2.1 14c33864e 15aude: Update release notes for 1.2.1 [09:15:18] [13WikibaseInternalSerialization] 15filbertkm opened pull request #34: Update release notes for 1.2.1 (06master...061.2.1) 02http://git.io/RTVcrw [09:17:33] [travis-ci] wmde/WikibaseInternalSerialization/1.2.1/c33864e : aude The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/34995511 [09:19:19] [13WikibaseQuery] 15adrianlang created 06fixAnnotation (+1 new commit): 02http://git.io/8C2uqA [09:19:19] 13WikibaseQuery/06fixAnnotation 14679f582 15Adrian Lang: Correct return type annotation [09:21:42] [travis-ci] wmde/WikibaseQuery/fixAnnotation/679f582 : Adrian Lang The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/34995823 [09:23:09] [13WikibaseQuery] 15adrianlang opened pull request #52: Correct return type annotation (06master...06fixAnnotation) 02http://git.io/b73UJA [09:25:41] Tobi_WMDE_SWE: https://github.com/wmde/WikibaseInternalSerialization/pull/34 [09:26:46] aude: Please see PM [09:29:49] [13WikibaseInternalSerialization] 15tobijat closed pull request #34: Update release notes for 1.2.1 (06master...061.2.1) 02http://git.io/RTVcrw [09:33:40] (03CR) 10Tobias Gritschacher: [C: 032] Optimized applying wb-empty class in label/descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158606 (owner: 10Henning Snater) [09:34:09] thanks tobi [09:34:37] Tobi_WMDE_SWE: want me to tag it? [09:34:50] aude: everything in that is needed? [09:35:15] for the bug fix, yes [09:35:25] i have follow ups but not required for deployment [09:35:40] aude: ok, then tag [09:35:44] ok [09:36:31] (03PS1) 10Henning Snater: Update initial value after stopping fingerprint editing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159686 [09:36:39] done [09:36:49] Tobi_WMDE_SWE: ^ [09:36:52] [13WikibaseInternalSerialization] 15filbertkm tagged 061.2.1 at 06master: 02http://git.io/nELdxA [09:36:55] ok [09:39:32] (03CR) 10Tobias Gritschacher: [C: 032] Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 (owner: 10Henning Snater) [09:46:55] (03CR) 10jenkins-bot: [V: 04-1] Update initial value after stopping fingerprint editing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159686 (owner: 10Henning Snater) [09:46:57] (03Merged) 10jenkins-bot: Optimized applying wb-empty class in label/descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158606 (owner: 10Henning Snater) [09:47:56] (03CR) 10jenkins-bot: [V: 04-1] Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 (owner: 10Henning Snater) [09:56:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4341429 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34998045 [09:56:59] rage [09:59:13] think i know why [09:59:20] fixed in my next pull request [09:59:21] DiffViewTest [09:59:24] ? [09:59:40] hoo: no, statement serializaiton [09:59:54] jenkins says no [10:00:36] (03PS1) 10WikidataBuilder: New Wikidata Build - 11/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159688 [10:03:54] [13WikibaseInternalSerialization] 15filbertkm created 06guid (+1 new commit): 02http://git.io/1cOf3A [10:03:54] 13WikibaseInternalSerialization/06guid 140bc1e4c 15aude: Fix setting of guid in statement deserialization [10:04:14] [13WikibaseInternalSerialization] 15filbertkm opened pull request #35: Fix setting of guid in statement deserialization (06master...06guid) 02http://git.io/hHLg0w [10:04:15] Tobi_WMDE_SWE: ^ [10:04:59] [travis-ci] wmde/WikibaseInternalSerialization/guid/0bc1e4c : aude The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/34999100 [10:06:03] aude: the search-box issue on wikidata.org is caused by the improvedsearch-gadget [10:06:07] oh [10:06:11] so don't know who should fix that [10:06:19] it has weird styles [10:06:40] note it in the bug? [10:07:22] aude: can you send me the link? [10:07:26] https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-Search.js&action=history ? [10:07:36] looks like benestar|cloud can fix it [10:09:28] [13WikibaseInternalSerialization] 15tobijat 04deleted 06guid at 140bc1e4c: 02https://github.com/wmde/WikibaseInternalSerialization/commit/0bc1e4c [10:09:39] Tobi_WMDE_SWE: do we re-tag or make new tag again? [10:09:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=70655 is the search bug [10:09:55] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 11/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159688 (owner: 10WikidataBuilder) [10:10:58] aude: hm.. not sure. I would retag it.. [10:11:03] ok [10:11:05] delete the tag and then create a new one [10:11:06] * aude doing :) [10:11:24] aude: http://nathanhoad.net/how-to-delete-a-remote-git-tag [10:11:30] got it [10:12:17] Henning_WMDE: can you add your observation to https://bugzilla.wikimedia.org/show_bug.cgi?id=70655? [10:12:19] [13WikibaseInternalSerialization] 15filbertkm 04deleted 061.2.1 at 1431fb9ba: 02http://git.io/HJIYPA [10:12:36] link to https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-Search.js#Misplacing_search_box [10:15:07] [13WikibaseInternalSerialization] 15filbertkm tagged 061.2.1 at 06master: 02http://git.io/nELdxA [10:15:41] Ah, they already figured out it's about the gadget. [10:16:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159688 (owner: 10WikidataBuilder) [10:17:46] (03Abandoned) 10Aude: New Wikidata Build - 11/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159688 (owner: 10WikidataBuilder) [10:23:12] Henning_WMDE: hm, yes, seems [12:07:09] [13WikidataBuildResources] 15filbertkm created 06entrypoint (+1 new commit): 02http://git.io/MxM0rA [12:07:09] 13WikidataBuildResources/06entrypoint 142d6b4ee 15aude: Fix Wikidata.org extension path in localisation entry point [12:07:24] [13WikidataBuildResources] 15filbertkm opened pull request #6: Fix Wikidata.org extension path in localisation entry point (06master...06entrypoint) 02http://git.io/q4C0hw [12:10:44] (03PS1) 10Aude: New Wikidata Build - 11/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159707 [12:13:53] [13WikidataBuildResources] 15filbertkm closed pull request #6: Fix Wikidata.org extension path in localisation entry point (06master...06entrypoint) 02http://git.io/q4C0hw [12:24:36] (03CR) 10Adrian Lang: "I'm opposed to this change, but I guess what's done is done. Still, jquery.wikibase/jquery.wikibase.claimview.tests.js, jquery.wikibase/jq" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157648 (owner: 10Henning Snater) [12:27:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159707 (owner: 10Aude) [12:27:22] omg, jenkins approves! [12:27:50] (03CR) 10Aude: [C: 032] "\o/" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159707 (owner: 10Aude) [12:36:05] Adrian_WMDE: are your failures like https://bugzilla.wikimedia.org/show_bug.cgi?id=70710 ? [12:37:00] (03Merged) 10jenkins-bot: New Wikidata Build - 11/09/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159707 (owner: 10Aude) [12:37:09] Adrian_WMDE: or DiffViewTest, by any chance? [12:37:14] travis doesn't like that one [12:37:16] No, sorry [12:37:21] :/ [12:49:56] (03PS5) 10Tobias Gritschacher: Apply keydown instead of keyup in sitelinkview toolbar definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158354 (owner: 10Henning Snater) [12:50:05] (03PS2) 10Tobias Gritschacher: Update initial value after stopping fingerprint editing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159686 (owner: 10Henning Snater) [12:50:11] aude: do we have a branch already? [12:50:29] not yet [12:50:53] do we want badges in? [12:51:00] aude: ok. these two changes^^ should be in as well, approved already this morning but jenkins failed because of mergeitemstest [12:51:06] ok [12:51:23] go ahead and approve again [12:51:25] aude: what do you think? [12:51:30] about badges? [12:51:39] DanielK_WMDE: ? [12:51:39] i am reviewing those now [12:51:42] ^^ [12:51:45] ok [12:51:50] if all good, these are in the branch [12:51:58] (03CR) 10Tobias Gritschacher: [C: 032] Update initial value after stopping fingerprint editing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159686 (owner: 10Henning Snater) [12:52:04] i a problem then we backport [12:52:28] ok [12:52:46] let's do it like that then [12:52:50] ok [12:52:57] (03CR) 10Aude: [C: 032] Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [12:53:03] there's the first one [12:53:07] :) [12:57:46] (03PS11) 10Daniel Kinzler: Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [12:58:23] (03CR) 10Daniel Kinzler: "PS11 is a rebase to get rid of a dependency" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [13:08:35] (03Merged) 10jenkins-bot: Update initial value after stopping fingerprint editing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159686 (owner: 10Henning Snater) [13:09:00] (03Merged) 10jenkins-bot: Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [13:09:30] aude: we can close https://bugzilla.wikimedia.org/show_bug.cgi?id=70613 [13:09:32] right? [13:10:26] (03CR) 10jenkins-bot: [V: 04-1] Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [13:10:36] Tobi_WMDE_SWE: suppose so [13:10:45] (03PS12) 10Daniel Kinzler: Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [13:10:49] i'll do follow up and more checks of serializers [13:18:43] (03CR) 10jenkins-bot: [V: 04-1] Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [13:24:28] Tobi_WMDE_SWE: why is 1.2.1.x-dev have old commit ? [13:24:29] https://packagist.org/packages/wikibase/internal-serialization [13:24:48] so if i have minimum-stability: dev in composer.json then i get old code [13:25:59] aude: don't know. I did not create that tag [13:26:04] who did? [13:26:05] yeah [13:26:07] * aude did [13:26:12] what did i do wrong? [13:26:14] why? [13:26:27] what should it be for? [13:26:36] i think the -dev is always there? [13:26:41] i did not make that, only 1.2.1 [13:27:42] aude: probably that happened because we deleted the original tag [13:27:46] and created a new one? [13:27:54] maybe? [13:27:56] don't know [13:28:19] aude: should I try to remove it from packagist? [13:28:27] if you can [13:28:37] https://github.com/composer/packagist/issues/213 [13:28:45] so looks like you can remove it [13:28:50] aude: I see a dark red "delete" button [13:28:58] oh noes [13:31:07] solved :) [13:32:23] aude: :) [13:38:16] (03CR) 10Aude: [C: 04-1] "hook registration is wrong, see comment" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [13:38:27] DanielK_WMDE: if you want, i can just fix and then merge https://gerrit.wikimedia.org/r/#/c/159295/ [13:38:34] otherwise looks good [13:41:04] (03CR) 10Aude: "ok, i see this is fixed in a follow up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [13:42:31] (03CR) 10Aude: Rename ParserOutputHooks to SidebarHookHandlers (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [13:59:46] (03PS4) 10Daniel Kinzler: Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [14:00:37] (03PS13) 10Daniel Kinzler: Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [14:01:18] * DanielK_WMDE waits for jenkins [14:02:32] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159707 (owner: 10Aude) [14:04:10] (03CR) 10Aude: "when i do runJobs, there is a problem it seems $wgLang is actually a StubUserLang which extends StubObject and not Language, so the type h" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [14:04:22] hey, Just letting you know my bot (neither I) can't change the Q183 (Germany) every time we get 503 error, with API or GUI. I want to add featured badge to ptwiki and afwiki [14:04:39] what? [14:04:51] You can check it by yourself [14:04:56] sure [14:05:09] try adding the badge to ptwiki and afwiki in Q183 [14:05:20] omg, really slow [14:05:38] it's half of a MB [14:05:45] :( [14:05:51] compiling it takes ages [14:07:13] confirmed [14:07:21] to bugzilla [14:07:36] and obviously we need to make it high priority [14:08:33] The evil solution would be removing some huge statements ;) [14:08:47] well.... [14:09:09] i'm sure we're doing some stuff suboptimally like looking up labels for stuff [14:09:23] we made it better and it was okay, but now items are even bigger [14:09:28] and hrwiki [14:09:28] and problem again :( [14:09:29] (03CR) 10jenkins-bot: [V: 04-1] Fix missing options bug in GetClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158093 (owner: 10Thiemo Mättig (WMDE)) [14:09:38] I understand [14:09:59] (03CR) 10jenkins-bot: [V: 04-1] Add tests for api xml format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158994 (owner: 10Aude) [14:10:12] Lush PHP Fatal error: Base lambda function for closure not found in /usr/local/apache/common-local/php-1.24wmf20/extensions/Wikidata/extensions/Wikibase/lib/config/WikibaseLib.default.php on line 18 [14:10:25] addshore: apc error [14:10:30] (03PS6) 10Daniel Kinzler: Extract skin hook handlers into ParserOutputHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 [14:10:41] i don't know why we are getting so many now [14:10:47] i think apache has to be restarted [14:10:59] addshore: that's apc getting confused, restart apache to fix [14:13:57] Amir1: https://bugzilla.wikimedia.org/show_bug.cgi?id=70716 [14:14:21] probably can't look into it until tomorrow [14:15:01] Thank you :) [14:15:44] thanks for poking us [14:20:36] (03PS5) 10Aude: Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [14:20:47] (03CR) 10Aude: "rebased, patchset 5" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [14:23:57] (03CR) 10Aude: [C: 032] Extract skin hook handlers into ParserOutputHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [14:24:06] (03CR) 10Aude: [C: 032] Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [14:24:31] (03PS11) 10Aude: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:24:32] aude: Are you going to have a bump commit today? :) [14:24:56] yes [14:25:06] cool, any idea on ETA? [14:25:09] trying to get the last bug fixes in [14:25:27] no rush on my part :) [14:25:35] maybe an hour [14:28:29] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 per bene's comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:28:42] [13WikibaseQuery] 15JeroenDeDauw 04deleted 06fixAnnotation at 14679f582: 02http://git.io/IVFKQw [14:34:01] (03CR) 10Aude: [C: 04-1] "see comment" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:36:45] (03CR) 10Aude: Rewrite badge display logic. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:37:14] (03Merged) 10jenkins-bot: Extract skin hook handlers into ParserOutputHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [14:37:18] (03Merged) 10jenkins-bot: Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [14:37:56] Tobi_WMDE_SWE: DanielK_WMDE i say make the branch now [14:38:12] aude: allright [14:38:13] we don't have to update cache epoch this time [14:38:31] too many things to follow up in the last badges patch that i don't want to be done in a rush [14:38:34] rush = bugs [14:39:05] if xml is simple, we can backport [14:39:13] aude: fine with that [14:39:21] k [14:44:25] or we can backport badges also [14:44:37] think the fixes might be simple enough but not today [14:53:14] (03CR) 10Aude: "even when making all these modifications locally, I have no badges now in the client :(" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [14:56:33] we have a branch [14:57:06] waiting for packagist and make the buidl [14:57:09] build* [15:09:19] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06reference_tests: 02http://git.io/MkL13Q [15:09:19] 13WikidataBrowserTests/06reference_tests 14b062873 15Tobias Gritschacher: WIP - Browsertests for references [15:18:59] (03PS1) 10Aude: New deployment build, mw1.24-wmf20 [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159741 [15:22:40] [13WikidataBuildResources] 15filbertkm created 06badges (+1 new commit): 02http://git.io/30VR_A [15:22:40] 13WikidataBuildResources/06badges 14f49c838 15aude: Remove WikimediaBadges from localisation entry point since it is autoloaded [15:23:07] (03PS2) 10Aude: New deployment build, mw1.24-wmf20 [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159741 [15:38:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159741 (owner: 10Aude) [15:38:32] (03CR) 10Aude: [C: 032] New deployment build, mw1.24-wmf20 [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159741 (owner: 10Aude) [15:47:43] (03Merged) 10jenkins-bot: New deployment build, mw1.24-wmf20 [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159741 (owner: 10Aude) [15:48:34] Reedy: ^ we have new branch [15:48:44] sweet [15:48:56] I'm about to go AFK for about an hour, so will be branching after that [15:49:07] ok [15:49:55] Mind doing the tools/release commit if you haven't already please? [15:50:00] done [15:51:45] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159741 (owner: 10Aude) [16:19:12] [13Wikiba.se] 15Benestar created 06favicon (+1 new commit): 02http://git.io/Gw911A [16:19:12] 13Wikiba.se/06favicon 142271629 15Bene: Add favicon... [16:22:31] [13Wikiba.se] 15JeroenDeDauw opened pull request #23: Add favicon (06master...06favicon) 02http://git.io/fyJ7fw [16:24:26] benestar: yay for adding that [16:24:37] JeroenDeDauw hope it works ;) [16:24:42] [13Wikiba.se] 15JeroenDeDauw 04deleted 06favicon at 142271629: 02http://git.io/PUakzg [16:25:15] sometimes there are caching issues and browsers don't want to display the icon first [16:25:47] benestar: it's displaying for me now on the actual site [16:26:08] yeah, it works \o/ [16:40:03] (03PS12) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [16:50:43] (03CR) 10jenkins-bot: [V: 04-1] Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [16:50:55] gah. [16:53:18] (03PS13) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [17:21:00] aude: when hashar gets back in a week or so I'll poke jenkins stuff a bit more :) [17:30:15] addshore: great :) [17:35:42] (03PS1) 10Bene: Improve usage of global state in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159771 [17:40:21] * aude cries [17:40:36] aaaaaah wikibase + spam/abuse filter is broken [17:41:24] :O [17:41:39] needs a quick fix imo [17:41:58] it's for test.wikidata, but still yes [17:55:56] (03PS1) 10Bene: Limit the usage of global state [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159784 [18:14:32] (03CR) 10Jeroen De Dauw: [C: 04-1] "It sucks to have to update this the whole time when valid uses are added. This might also incentivise people to simple not talk to the fac" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159784 (owner: 10Bene) [18:21:57] (03PS1) 10Aude: Fix fatal in EntityContent::getTextForFilters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159797 (https://bugzilla.wikimedia.org/70725) [18:23:00] JeroenDeDauw: DanielK_WMDE ^ [18:23:07] also note https://bugzilla.wikimedia.org/show_bug.cgi?id=70728 [18:24:50] (03PS1) 10Aude: Fix fatal in EntityContent::getTextForFilters [extensions/Wikibase] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159799 (https://bugzilla.wikimedia.org/70725) [18:32:34] * aude gives 5 more minutes and then is self-merging into the branch [18:32:48] so we can proceed with test.wikidata deploy [18:48:37] (03CR) 10Aude: [C: 032] "nobody around... per ignore all rules ;)" [extensions/Wikibase] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159799 (https://bugzilla.wikimedia.org/70725) (owner: 10Aude) [18:57:59] (03Merged) 10jenkins-bot: Fix fatal in EntityContent::getTextForFilters [extensions/Wikibase] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159799 (https://bugzilla.wikimedia.org/70725) (owner: 10Aude) [19:00:47] (03CR) 10Daniel Kinzler: "This looks like it should work, but I haven't tested it. And it's of course a nasty hack." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159797 (https://bugzilla.wikimedia.org/70725) (owner: 10Aude) [19:00:56] aude: sorry, gotta go [19:01:05] DanielK_WMDE: sure [19:01:26] entire method looks nasty [19:02:00] * aude manually tested [19:09:10] (03PS1) 10Aude: New deployment build, fix bug with abuse / spam filter + wikibase interaction [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159810 [19:24:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159810 (owner: 10Aude) [19:26:30] (03CR) 10Aude: [C: 032] New deployment build, fix bug with abuse / spam filter + wikibase interaction [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159810 (owner: 10Aude) [19:34:27] (03CR) 10Jeroen De Dauw: [C: 032] "Err... why the smag did we not notice this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159797 (https://bugzilla.wikimedia.org/70725) (owner: 10Aude) [19:35:22] (03Merged) 10jenkins-bot: New deployment build, fix bug with abuse / spam filter + wikibase interaction [extensions/Wikidata] (mw1.24-wmf20) - 10https://gerrit.wikimedia.org/r/159810 (owner: 10Aude) [20:00:47] (03PS1) 10Aude: Revert "New Wikidata Build - 11/09/2014" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159818 [20:00:57] (03CR) 10Aude: [C: 032] Revert "New Wikidata Build - 11/09/2014" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159818 (owner: 10Aude) [20:09:42] (03CR) 10jenkins-bot: [V: 04-1] Revert "New Wikidata Build - 11/09/2014" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159818 (owner: 10Aude) [20:10:12] oh, gah [20:11:53] (03CR) 10Aude: [V: 032] "1 test is broken due to change in core, but otherwise should be fine and not a problem" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159818 (owner: 10Aude) [20:16:39] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159818 (owner: 10Aude) [20:28:54] hah, on test.wikidata "Warning: You are naughty." :D [20:29:18] abuse filter works! [20:30:49] lol, nice [20:56:53] (03PS1) 10Aude: Specify format in EntityContent::getTextForFilters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159837 [21:02:33] yay! only two more wikiprojects left and I will finally be SUL'ed [21:02:49] I started the unification process in 2012... [21:07:30] dennyvrandecic_: nice [21:07:49] oh, we're in the underscore club :p [21:10:17] * aude has test2 account back :) [21:11:27] lazowik_: it's always about identity :) [21:11:51] aude: but you're SUL'ed already aren't you? [21:12:11] dennyvrandecic_: except for test2 ... until now [21:12:20] congrats then! :) [21:12:26] :D [21:12:35] i am missing trwiki and debooks [21:12:42] soon [21:12:58] I heard that "soon" song before :D [21:13:28] I have an idea for a Wikidata-based game, if some JS/HTML-developer wants to work on it, contact me :) [21:13:32] I don't have the time [21:13:40] suppose if they have edits, then not as soon [21:14:06] just a single edit on debooks, changing "ein" to "einen", and three little edits on trwiki [21:14:18] :( [21:14:31] maybe the local crats will be lenient, due to the upcoming changes [21:14:49] I usurped a few accounts with a small number of edits before, maybe it will work there too [21:15:12] dennyvrandecic_: somthing simple to code? [21:15:14] I'd rather be unified before the forced unification, in case something there goes wrong :) [21:15:28] lazowik_: I would say so. Nothing huge [21:15:44] but still, it will take a few days, but it could be fun [21:15:56] and I'd say one would either learn a bit about canvas or svg [21:16:02] I'd rather go for SVG [21:16:20] canvas is not supported that much probably [21:16:36] canvas has issues with connecting events [21:16:43] SVG handles that for you [21:17:04] the support is almost even besides older IEs [21:18:42] * lazowik_ is torn [21:18:48] hehe [21:19:00] i understand that :) [21:19:14] * lazowik_ would like to do 10x moar things than he has time for [21:19:26] * dennyvrandecic_ too [21:19:34] * benestar too [21:19:39] good evening everybody :D [21:19:47] * dennyvrandecic_ would also like lazowik_ and benestar to do 10x moar things than they have time for [21:19:53] it's a benestar \o/ [21:20:01] hi benestar :) [21:20:16] a skyyyy full of staaars [21:20:21] benestars! [21:20:36] are we all going to be Qs one day, so we can automatically make a huge organigram of the entire Wikimedia universe, via "member of" and stuff [21:20:46] * mutante added Brion :p [21:21:51] dennyvrandecic_ an SVG game? :OO [21:22:34] aye [21:22:39] wanna hear? :) [21:23:00] mutante: maybe, if we all fulfill the notability criteria [21:23:30] brion is a number now [21:23:31] (03CR) 10Bene: "Hi Jeroen, I understand your concerns. However, there should be a limit where global state can be used and where not. Maybe we should forc" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159784 (owner: 10Bene) [21:23:54] dennyvrandecic_ maybe write down on a wiki page or so? [21:24:03] because I have to leave in a few minutes again -.- [21:24:49] benestar: I'd like to keep it undercover until publication [21:24:53] just to make it more fun [21:24:57] dennyvrandecic_: but the criteria for wikidata are less strict than for WP? [21:25:05] mutante: they are different [21:25:27] but necessarily everythin in WP is also inside of Wikidata, so, yeah [21:26:04] dennyvrandecic_: the hell, I can take a look :D [21:26:10] it was a bit weird, on WP there was only Wikipedia:Brion Vibber Day but Brion himself [21:26:18] so i created actual Brion and linked that page [21:26:23] and i guess "named after" [21:26:24] I primise I'll keep the secret :p [21:27:24] dennyvrandecic_ so write a mail with Top Secret in its subject ;) [21:27:40] lazowik_ lets work on this together? :D [21:28:42] mutante: sounds good to me :) [21:28:57] benestar: yeah, let's make a company :p [21:29:14] ^^ [21:29:28] i'm fine with that :) [21:44:52] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159818 (owner: 10Aude) [22:01:01] 'night! [22:45:35] hmm, I'm getting "Uncaught Error: Unknown dependency: jquery" on my dev wiki when I'm trying to add a language link [22:49:57] nvm, finally got how to update it... [22:53:10] Broken link message https://test.wikidata.org/w/index.php?title=Q11111&action=edit&restore=108032093 [22:53:26] BTW, is there an API equivalent to wikidata "restore"?