[00:01:13] greg-g: Replied (that works for me) [00:01:26] coolio, ty hoo [02:11:46] where is the script/tool used to generate the json files in http://dumps.wikimedia.org/other/wikidata/ ? [02:16:27] jayvdb: one second [02:17:11] jayvdb: https://github.com/wikimedia/operations-puppet/blob/production/modules/snapshot/files/dumpwikidatajson.sh [02:17:24] That's the bash that hits of the various PHP processes [02:17:36] repo/maintenance/dumpJson.php in Wikibase [02:24:20] thx I thought it might be dumpJson.php , but wanted to be sure [02:25:22] it is :) [06:11:09] HURRAY 50% of our items have zero, one or TWO statements :) [06:17:31] (03PS12) 10Bene: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 [06:19:26] (03CR) 10Bene: "Daniel: Addressed your small issues and totally dropped the $dataValueType param because we can rely on the fact that url values always ar" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [07:07:44] (03PS9) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [08:26:09] (03PS10) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [08:35:01] hi rxy [08:37:09] (03PS4) 10Daniel Kinzler: Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 [08:37:21] (03PS5) 10Daniel Kinzler: Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 [08:38:36] (03CR) 10Daniel Kinzler: Extract handlers for ParserOutput hooks (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [08:39:40] (03PS3) 10Daniel Kinzler: Extract skin hook handlers into ParserOutputHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 [08:39:40] jayvdb: hi [08:51:44] (03PS2) 10Daniel Kinzler: Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 [08:52:07] (03CR) 10Daniel Kinzler: "PS2 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [10:00:30] (03PS1) 10WikidataBuilder: New Wikidata Build - 10/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159465 [10:03:27] (03PS15) 10Addshore: Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [10:08:03] (03PS1) 10Aude: Do not invalidate Title in other projects sidebar feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159466 (https://bugzilla.wikimedia.org/70482) [10:09:55] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 10/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159465 (owner: 10WikidataBuilder) [10:13:55] (03CR) 10jenkins-bot: [V: 04-1] Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [10:16:31] (03PS3) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [10:16:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159465 (owner: 10WikidataBuilder) [10:16:36] argh, why jenkins still say no!? [10:16:50] but wikidata jenkins say yes [10:17:22] benestar|cloud: --^^^ [10:25:52] (03CR) 10jenkins-bot: [V: 04-1] Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [11:05:40] Hoi this output is WEIRD ... http://tools.wmflabs.org/reasonator/?q=1402277 [11:05:53] it looks as if it cannot read the database [11:16:54] (03PS4) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [11:19:37] (03PS5) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [11:24:47] (03CR) 10Daniel Kinzler: "Looks good, but doesn't have a test, and is hard to test manually. Please provide a unit test for the case in question - it should be poss" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159466 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [11:29:15] (03CR) 10Bene: Extract handlers for ParserOutput hooks (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [11:40:45] [13WikibaseInternalSerialization] 15filbertkm created 06statements (+2 new commits): 02http://git.io/Rps_rw [11:40:45] 13WikibaseInternalSerialization/06statements 14090c4cc 15aude: Implement LegacyStatementDeserializer [11:40:45] 13WikibaseInternalSerialization/06statements 14fa15e5a 15aude: Normalize claim serialization on Items and use LegacyStatementDeserializer... [11:41:10] Tobi_WMDE_away: guess i am workign on #66425 or at least cleaning some of the mess [11:43:01] [travis-ci] wmde/WikibaseInternalSerialization/statements/fa15e5a : aude The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/34903451 [11:48:55] (03CR) 10Aude: Extract handlers for ParserOutput hooks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [12:07:14] (03CR) 10Bene: "This is what my -1 was for ;-) Sorry for not pointing it our clear enough" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [12:20:11] (03PS11) 10Tobias Gritschacher: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [12:25:18] (03CR) 10Aude: [C: 04-1] "see comments" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [12:39:02] [13WikibaseInternalSerialization] 15filbertkm 04force-pushed 06statements from 14fa15e5a to 1464bbf1c: 02http://git.io/bLCfHw [12:39:02] 13WikibaseInternalSerialization/06statements 1464bbf1c 15aude: Normalize claim serialization on Items and use LegacyStatementDeserializer... [12:58:32] JeroenDeDauw: hey i wonder if DisjunctionSerializer is not better off inheriting DescriptionCollectionSerializer? https://github.com/wmde/AskWikitextSerialization/pull/1 [13:03:19] [13WikibaseInternalSerialization] 15filbertkm 04force-pushed 06statements from 1464bbf1c to 143186f09: 02http://git.io/bLCfHw [13:03:19] 13WikibaseInternalSerialization/06statements 14607a800 15aude: Implement LegacyStatementDeserializer [13:03:19] 13WikibaseInternalSerialization/06statements 143186f09 15aude: Normalize claim serialization on Items and use LegacyStatementDeserializer... [13:07:39] aude: ok, are we on a good way resolving the red dots? [13:08:03] i hope so, think so [13:08:07] aude: ok [13:08:48] basically, i have claims on items so am sorting out the internal serializers to handle that more appropriately [13:09:16] and then need to review daniel's thing (or benestar can) and add test for other proejcts things [13:09:43] aude: please also check back with JeroenDeDauw as he wanted to work on that as well [13:09:53] sure [13:09:57] don't know whether he started doing something there [13:09:57] he can review [13:10:01] hehe :) [13:10:14] it's a blocker, as i imagine wikidata has such items [13:10:27] he also mentioned something that we want to get rid of some inheritance in the code as well [13:10:34] doing :) [13:10:45] great :D [13:10:52] there are more places to do [13:11:10] and i hope all the code handles claims on items properly [13:20:09] [13WikibaseDataModelJavascript] 15snaterlicious pushed 4 new commits to 06fingerprint: 02http://git.io/91HnWw [13:20:09] 13WikibaseDataModelJavascript/06fingerprint 14be87512 15snaterlicious: Resolved Item and Property inheriting from Entity [13:20:09] 13WikibaseDataModelJavascript/06fingerprint 14205fe4d 15snaterlicious: Removed unnecessary test runner specifications [13:20:09] 13WikibaseDataModelJavascript/06fingerprint 140849ca6 15snaterlicious: Removed toJSON() / newFromJSON functions [13:21:14] [13WikibaseDataModelJavascript] 15snaterlicious 04force-pushed 06fingerprint from 1482a7c61 to 1455b312e: 02http://git.io/AW1kmQ [13:21:14] 13WikibaseDataModelJavascript/06fingerprint 1455b312e 15snaterlicious: Fixed SnakList function level documentation [13:24:56] [13WikibaseInternalSerialization] 15filbertkm created 06claimserializer (+2 new commits): 02http://git.io/AXNOmw [13:24:56] 13WikibaseInternalSerialization/06claimserializer 14ff2b32b 15aude: Remove statement deserialization code from LegacyClaimDeserializer... [13:24:56] 13WikibaseInternalSerialization/06claimserializer 14202a27b 15aude: Update release notes [13:26:29] gah, what is 'old' and what is 'recent' legacy? [13:27:16] [travis-ci] wmde/WikibaseInternalSerialization/claimserializer/202a27b : aude The build failed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/34911131 [13:32:17] [13WikibaseDataModelJavascript] 15snaterlicious opened pull request #16: General update (06master...06fingerprint) 02http://git.io/_h73LQ [13:38:29] (03CR) 10Tobias Gritschacher: [C: 032] Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [13:38:45] (03CR) 10Tobias Gritschacher: [C: 032] Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [13:48:52] (03Merged) 10jenkins-bot: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [13:49:45] (03Merged) 10jenkins-bot: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [13:55:08] [13ValueView] 15tobijat tagged 060.7.0 at 06master: 02http://git.io/TGRTpw [13:57:13] [13ValueView] 15tobijat 04deleted 060.7.0 at 14b1dc7fa: 02http://git.io/VM1-pg [13:57:48] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/rewkWw [13:57:48] 13ValueView/06master 143e44893 15Tobi Gritschacher: Update README.md [13:58:12] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/V279xQ [13:58:12] 13ValueView/06master 14e2032aa 15Tobi Gritschacher: Update ValueView.php [13:58:38] [13ValueView] 15tobijat tagged 060.7.0 at 06master: 02http://git.io/TGRTpw [13:59:57] (03PS4) 10Tobias Gritschacher: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) [14:02:27] (03CR) 10jenkins-bot: [V: 04-1] Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [14:03:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bbefc99 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34913346 [14:19:57] Tobi_WMDE_SWE: https://gerrit.wikimedia.org/r/#/c/159029/ no one merged it yet! [14:20:18] that is why wikidata jenkins approves but not wmf jenkins [14:21:00] (03Abandoned) 10Aude: New Wikidata Build - 10/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/159465 (owner: 10WikidataBuilder) [14:21:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/e70dd8a : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34913402 [14:24:54] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/159029/ [14:25:02] das ist why jenkins say sno [14:25:04] no* [14:25:20] thought it was merged yesterday but no [14:25:55] (03CR) 10Daniel Kinzler: [C: 032] Use invalid UnDeserializableValue in DataModelSerializationRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159029 (owner: 10Aude) [14:25:59] \o/ [14:26:03] and the thing it depends on [15:01:40] aude, you around? :) [15:39:45] Jhs: i am busy but if it's quick.... [15:40:02] i pm'd you earlier, but it's no rush. don't worry about it :) [15:40:05] see pm [15:40:46] * hoo waves [15:41:01] hi :) [15:52:14] (03CR) 10Tobias Gritschacher: [C: 032] Use DataValueFactory::tryNewFromArray in legacy SnakSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159047 (owner: 10Aude) [15:52:18] \o/ [15:52:23] chocolate for tobi [15:52:33] [13WikibaseInternalSerialization] 15filbertkm 04force-pushed 06claimserializer from 14202a27b to 14243ba95: 02http://git.io/9LL7GA [15:52:33] 13WikibaseInternalSerialization/06claimserializer 14dea74c5 15aude: Remove statement deserialization code from LegacyClaimDeserializer... [15:52:33] 13WikibaseInternalSerialization/06claimserializer 14243ba95 15aude: Update release notes [15:53:08] Tobi_WMDE_SWE: JeroenDeDauw for bug #70613, https://github.com/wmde/WikibaseInternalSerialization/tree/statements is more minimal solution that i think can have a minor tag [15:53:29] https://github.com/wmde/WikibaseInternalSerialization/tree/claimserializer is a bit more, but think needed changes [15:53:46] they can be split, so 2nd depends on the first [15:54:10] i would like to add more integration tests and test this with my dump, additionally [15:56:58] [13WikibaseInternalSerialization] 15filbertkm opened pull request #32: Fix Item deserialization for items with claims (06master...06claimserializer) 02http://git.io/oiutjw [15:57:57] [13WikibaseDataModelJavascript] 15tobijat created 06use_new_dmjs (+1 new commit): 02http://git.io/7scBJA [15:57:57] 13WikibaseDataModelJavascript/06use_new_dmjs 14840a265 15Tobias Gritschacher: Use new version of data-values/javascript... [15:58:21] [travis-ci] wmde/WikibaseInternalSerialization/claimserializer/243ba95 : aude The build was fixed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/34926430 [15:59:00] [13WikibaseInternalSerialization] 15filbertkm opened pull request #33: Simple fix for Item deserialization for items with claims (06master...06statements) 02http://git.io/D4_44w [15:59:25] [13WikibaseDataModelJavascript] 15tobijat tagged 060.3.3 at 06use_new_dmjs: 02http://git.io/9lq0YA [16:00:26] (03PS5) 10Tobias Gritschacher: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) [16:00:49] why is travis complainign??? [16:04:00] (03CR) 10jenkins-bot: [V: 04-1] Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [16:05:09] (03Merged) 10jenkins-bot: Use DataValueFactory::tryNewFromArray in legacy SnakSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159047 (owner: 10Aude) [16:05:26] (03Merged) 10jenkins-bot: Use invalid UnDeserializableValue in DataModelSerializationRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159029 (owner: 10Aude) [16:05:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=70659 [16:08:08] oh that [16:08:12] *sigh* [16:08:13] yes that [16:08:21] * aude just raged to Tobi_WMDE_SWE [16:08:39] have to take something else out of the sprint or finish everyething then we can add this [16:09:02] I guess I could work on it [16:09:18] if you want.... [16:09:19] although I'm not sure how exactly, but I'll have to figure that out anyway [16:09:20] really want [16:09:49] do you really want? [16:10:22] buzy fixing red dot bugs [16:10:25] busy [16:15:19] [13WikibaseSerializationJavaScript] 15tobijat pushed 2 new commits to 06master: 02http://git.io/1NbNqA [16:15:19] 13WikibaseSerializationJavaScript/06master 1456862fc 15Tobias Gritschacher: Use new version of data-model/javascript [16:15:19] 13WikibaseSerializationJavaScript/06master 1446fcd29 15Tobias Gritschacher: Merge branch 'master' of git://github.com/wmde/WikibaseSerializationJavaScript [16:16:04] [13WikibaseSerializationJavaScript] 15tobijat tagged 061.1.3 at 06master: 02http://git.io/h1CV0A [16:18:44] (03PS6) 10Tobias Gritschacher: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) [16:30:54] (03CR) 10Bene: [C: 04-1] "See inline comments" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [16:32:12] (03CR) 10Bene: [C: 031] Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [16:38:39] (03CR) 10Bene: "Looks good, some nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [16:51:30] (03CR) 10Aude: "I do not see a good way to test the fallback code without extracting the entire hook handler to it's own class." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159466 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [16:52:43] hoo: maybe you want to look at https://gerrit.wikimedia.org/r/#/c/159466/ ? [16:52:54] give a second set of eyes [16:53:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/95eff09 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34927744 [16:54:42] aude: $otherProjectsSidebar = null; [16:54:44] why is that? [16:55:02] (03CR) 10Daniel Kinzler: Extract handlers for ParserOutput hooks (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [16:55:03] oh, debugging [16:55:08] :P [16:55:16] so you can see that the fallback code gets hit [16:55:22] (03PS6) 10Daniel Kinzler: Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 [16:56:23] 899 Fatal error: Base lambda function for closure not found in /usr/local/apache/common-local/php-1.24wmf20/extensions/Wikidata/extensions/Wikibase/lib/config/Wiki [16:56:23] baseLib.default.php on line 18 [16:56:28] aude: hoo ^ [16:56:38] we didnt' change anything [16:56:48] Out of sync apache? [16:56:48] since when? [16:56:50] * Reedy will have a look [16:56:51] probably [16:56:56] yep [16:57:00] no wait [16:57:03] Reedy: That's APC [16:57:04] It's recent [16:57:11] restart apache [16:57:13] AFAIR [16:57:18] is it just one apache? [16:57:25] no idea, not on fluorine atm [16:57:47] Nope [16:57:49] It's a few [16:57:57] fu [16:58:00] :/ [16:58:04] (03PS2) 10Aude: Do not invalidate Title in other projects sidebar feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159466 (https://bugzilla.wikimedia.org/70482) [16:58:04] 5 or 6 maybe [16:58:06] But still this is a APC thing [16:58:13] what hoo says [16:58:24] Yeah [16:58:28] don't know why now [16:58:30] get an op to restart these apaches... or graceful them all [16:58:32] (03PS4) 10Daniel Kinzler: Extract skin hook handlers into ParserOutputHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 [16:58:44] (03CR) 10Daniel Kinzler: Extract skin hook handlers into ParserOutputHooks (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [16:59:57] (03CR) 10Aude: Rewrite badge display logic. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [16:59:58] aude: Have you tested that code per hand [17:00:04] hoo: i did [17:00:09] Fine, then [17:00:11] that's why the debugging [17:00:20] and did it w/o that also [17:00:37] (03CR) 10Hoo man: [C: 032] "Makes sense for now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159466 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [17:00:41] thanks [17:00:46] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #33 143186f09: I'd either use `assertEquals` or `assertTrue( $s->equals( $o ) )`. Why use the hash? 02http://git.io/XC27tA [17:00:48] daniel has all these follow up patches [17:00:57] so it should get nicer and fully tested [17:01:21] plus selenium, if i learn how to do those + beta not broken :) [17:02:03] JeroenDeDauw: Tobi_WMDE_SWE can you look at https://github.com/wmde/WikibaseInternalSerialization/pulls please [17:02:30] aude: I just did [17:02:32] your choice https://github.com/wmde/WikibaseInternalSerialization/pull/33 or https://github.com/wmde/WikibaseInternalSerialization/pull/32 [17:02:35] ok [17:02:57] sure we can follow up and make it even nicer but not today [17:03:06] JeroenDeDauw review? https://gerrit.wikimedia.org/r/#/c/158631/ [17:03:15] (03PS3) 10Daniel Kinzler: Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 [17:03:25] aude: I prefer the claim and statement stuff to be split [17:03:36] Sucks to make a breaking change to the package interface though [17:03:36] (03PS6) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [17:03:54] JeroenDeDauw: yeah [17:04:08] suppose i can make it more b/w compatible [17:04:53] aude can you maybe review https://gerrit.wikimedia.org/r/#/c/159096/ ? [17:05:03] aude: so do we have item serializations stored on wikidata.org that contain claims? [17:05:14] JeroenDeDauw: i need to check but probably [17:05:32] aude: where are you running into issues with this then? [17:05:38] on my test wiki [17:05:59] i think it's possible to make such edits via the api or at least used to be [17:06:06] aude: sure [17:06:15] so, 90% sure it's on wikidata [17:06:24] aude: however as of DataModel 1.0 you can no longer have actual such objects [17:06:31] yep [17:06:54] hence the legacy thing handles this [17:07:02] Not sure how much it helps to turn stuff in a format we never wanted to support into what we do support [17:07:55] not great but we cant' treat them as invalid [17:08:10] "them"? [17:08:16] claims on items [17:08:31] or without the correct serialization [17:08:44] aude: you sure we cannot just ignore them? [17:08:50] yes [17:09:06] let stuff vanish? [17:09:29] Ok, fair enough [17:09:48] i would like https://github.com/wmde/WikibaseInternalSerialization/pull/33 [17:09:49] Then I'm fine with this approach, don't see any real issues [17:10:03] and then polish the additional stuff in the other request [17:10:15] more integration tests etc. [17:10:57] thanks :) [17:10:57] [13WikibaseInternalSerialization] 15JeroenDeDauw closed pull request #33: Simple fix for Item deserialization for items with claims (06master...06statements) 02http://git.io/D4_44w [17:11:40] (03CR) 10Daniel Kinzler: Rewrite badge display logic. (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [17:12:01] (03PS7) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [17:12:40] benestar, aude: i updated all four changes in the chain now [17:13:21] DanielK_WMDE will have a look into that later :) [17:13:30] btw, thanks for refactoring that crap ;) [17:14:58] aude: feel free to up the rel notes and create a tag (though either let someone else do the tag or have them verify first all is ok). Should be 1.2.1 if this is just a fix [17:17:20] JeroenDeDauw: ok [17:17:35] might do either when i get home or in the morning (or tobi does it) [17:20:06] (03Merged) 10jenkins-bot: Do not invalidate Title in other projects sidebar feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159466 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [17:26:25] (03CR) 10Daniel Kinzler: [C: 032] Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [17:28:30] (03CR) 10Daniel Kinzler: [C: 031] "the code looks fine, but someone should review this from a ui and html dom perspective." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159103 (https://bugzilla.wikimedia.org/70333) (owner: 10Bene) [17:29:01] (03CR) 10Daniel Kinzler: [C: 04-1] "please add a regression test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [17:29:44] (03CR) 10Daniel Kinzler: [C: 032] Move ApiModuleTestHelper into namespace and api test directory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159074 (owner: 10Aude) [17:31:35] DanielK_WMDE do you really want me to create a test system for the special pages? :-/ [17:36:17] benestar: we already have one [17:36:41] it's not great, but it works ok [17:37:13] or you can refactor a bit, and do what i did for SpecialMergeItems, which now has proper unit tests [17:37:19] DanielK_WMDE we have one which checks the HTML output [17:37:34] DanielK_WMDE ok, however I think this should not block that change [17:37:41] benestar: nothing prevents you from also checking the state of the database [17:38:06] because it is a one line change and I tested it locally and you can also test it locally very easily ;) [17:38:09] well, it blocks me merging it, because i cannot see what this change actually means for the full process [17:38:27] i'd have to dig through the code, debug, etc, instead of just confirming that the test case checks what it should check, and then merge [17:38:27] hmm, not sure if this is urgent though [17:38:43] (03Merged) 10jenkins-bot: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [17:38:57] I agree that tests are necessary but there were people already complaining on that... [17:39:10] writing that test isn't that hard. 20 minutes? [17:39:27] or am i missing something? [17:39:34] (03Merged) 10jenkins-bot: Move ApiModuleTestHelper into namespace and api test directory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159074 (owner: 10Aude) [17:43:49] DanielK_WMDE ok, will try :) [17:44:21] (03CR) 10Bene: "Looks good, only some minor issues." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [17:45:33] (03CR) 10Daniel Kinzler: "The failure on travis is just a symptom of mediawiki's broken support for transactions (why oh why did i even add that warning?). I'd much" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159030 (owner: 10Aude) [17:46:51] (03CR) 10Bene: "another nitpick" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [17:48:17] Mediawiki's transaction support is just so much fun [17:49:35] (03CR) 10Bene: [C: 031] "Looks fine to me" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [17:50:13] (03CR) 10Bene: [C: 031] Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [17:51:24] (03CR) 10Daniel Kinzler: Extract handlers for ParserOutput hooks (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [17:51:46] (03PS7) 10Daniel Kinzler: Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 [17:52:04] (03PS5) 10Daniel Kinzler: Extract skin hook handlers into ParserOutputHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 [17:53:40] (03CR) 10Daniel Kinzler: Extract skin hook handlers into ParserOutputHooks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159295 (owner: 10Daniel Kinzler) [17:54:27] bah. needs rebase. again. [17:57:34] (03PS4) 10Daniel Kinzler: Rename ParserOutputHooks to SidebarHookHandlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 [17:57:49] (03CR) 10Daniel Kinzler: "PS4 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [17:58:03] (03PS8) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [18:03:03] (03CR) 10Bene: Rewrite badge display logic. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [18:03:29] (03CR) 10Bene: [C: 04-1] "See my comments on PS7. There are some problems with the parameters..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [18:04:32] Uhm. Why URL datatype has limit for just 500 symbols? [18:04:52] putnik: i thought it was 400, but yea [18:05:29] putnik: it must have *some* limit. if you have a *really* good use case for longer URLs (which are nasty to display and review anyway), please file a feature request [18:05:38] the limit is easy to adjust, if there's a good reason [18:05:50] DanielK_WMDE, I have source link with 736 symbols =/ [18:05:58] o_O [18:06:05] that sounds pretty broken [18:06:10] What's the url? [18:06:39] (03CR) 10Bene: [C: 031] Extract handlers for ParserOutput hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159078 (owner: 10Daniel Kinzler) [18:06:42] http://goo.gl/X70vvV [18:06:50] the http spec doesn't say what the limit should be, but urls longer than 1000 (or 1024) byte can be expected to break, depending on the browser, web server, and any proxies involved... [18:07:05] It contains filename with Russian letters. [18:08:55] DanielK_WMDE, maybe we should increase URLs length to 1000 symbols in this case? [18:09:15] (03CR) 10Bene: [C: 031] "Gnah, use the gerrit rebase feature, otherwise I always have to press +1 again ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [18:09:36] :S [18:09:54] That's why many resources use transcripts in URLs :P [18:17:55] DanielK_WMDE the special pages are a bit messy [18:18:00] * benestar blames himself [18:18:18] they use quite much inheritance for code sharing which makes testing harder... [18:18:59] so writing tests is not that simple I fear... [18:19:07] we first have to get rid of the inheritance there... [18:21:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1c833c4 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34935007 [18:22:37] (03PS9) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [18:23:45] (03CR) 10Daniel Kinzler: "@bene: i only do manual rebase if gerrit's rebase fails... seems like it doesn't work well with renames." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159301 (owner: 10Daniel Kinzler) [18:24:07] benestar: fixed the issues with the "rewrite badges" change (i hope). [18:25:51] just reviewing [18:28:43] (03CR) 10Bene: [C: 04-1] "found a bug" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [18:31:33] bah :) [18:32:55] (03CR) 10Aude: "alright, let's see if this is a problem on test.wikidata...." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159030 (owner: 10Aude) [18:33:04] (03PS1) 10Bene: Add an initServices method to SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159516 [18:33:42] DanielK_WMDE: working on xml yet? [18:33:52] aude: no. won't get to that today. [18:34:04] ok [18:34:14] i added you to my tests patch, as reviewer [18:34:16] (03CR) 10Daniel Kinzler: Rewrite badge display logic. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [18:34:23] we can look at the issue tomorrow [18:36:37] (03PS10) 10Daniel Kinzler: Rewrite badge display logic. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 [18:36:43] benestar: nice catch, fixed [18:36:56] ok, that's it for me for today [18:36:57] DanielK_WMDE perhaps this should also be tested ;) [18:36:59] cu tomorrow [18:37:04] cu [18:39:08] benestar: You in Berlin? :) [18:39:18] + Are [18:39:26] hoo no, cu on irc ;) [18:39:35] oh :S [18:39:36] but I'd wish to be in Berlin... [18:39:58] hoo will I see you in cologne? [18:40:16] Yes, going to have a session with Thiemo :) [18:40:51] (03CR) 10Bene: "I think there should also be a test testing both methods interacting together to prevent issues like the recent one. So basically, we coul" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159345 (owner: 10Daniel Kinzler) [18:41:08] hoo great :D [18:41:55] (03CR) 10jenkins-bot: [V: 04-1] Add an initServices method to SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159516 (owner: 10Bene) [18:52:06] (03PS2) 10Bene: Add an initServices method to SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159516 [19:12:52] Lydia_WMDE: I wonder how long it will take until we have the stub badge [19:16:31] multichill: a week if people ask ;) [19:16:46] I'm waiting for someone to ask for it :p [19:16:58] a stub badge, I wonder do we need a such badge [19:17:17] Stryn: to identify stubs ofc [19:18:00] How to tell the difference between a featured article and a stub then? [19:18:23] sjoerddebruin: look at the badge :p [19:18:32] But isn't the badge the same then? [19:18:49] yes :D [19:18:56] :/ [19:19:06] By the way, who's gonna fix those. https://www.wikidata.org/wiki/Special:BrokenRedirects [19:19:31] JohnLewis: well, whether an article is a stub is rather sibjective I think … while a "Featured" article requires consensus I believe [19:19:35] Do you guys no if anyone already tried to import death of birth and death of date automagically? [19:19:46] I don't know whether marking "stubs" makes sense at all [19:19:49] I mean from full text, persondata is easy [19:20:02] IMHO it doesn't... [19:20:06] Vogone: Featured articles are also subjective [19:20:23] What one defines as 'great' another will define as 'good' and another will define as 'average' [19:20:38] multichill why ? [19:20:38] JohnLewis: of course, but it is decided by a discussion [19:20:38] it's how wikis work. Nothing is ever a or b. [19:21:01] featured are on enwiki; good are 'well whatever you think' [19:21:05] JohnLewis: I hardly believe any wiki has a process to make stubs [19:21:17] GerardM-: I was playing around with mix'n'match and without dob/dod that's sloooooow [19:21:29] all sv-wiki articles can be marked as stubs :) [19:21:40] (I mean bot made articles) [19:22:01] I just don't see the value in marking stubs [19:22:08] Stryn: all fiwiki ones can because of their quality ;) [19:22:13] no reader is looking for stubs either [19:22:21] JohnLewis: not really [19:22:27] while they might be interested in good articles [19:22:31] GerardM-: So thought about importing at least part of http://tools.wmflabs.org/wikidata-todo/autolist.html?lang=nl&q=CLAIM%5B31%3A5%5D%20AND%20noclaim%5B569%5D%20and%20link%5Bnlwiki%5D%20AND%20CLAIM%5B27%3A55%5D [19:23:31] why not read them from an rss feed as and when they are created/changed ? [19:23:38] Stryn: any wiki with you on the AC has problems :D [19:24:13] JohnLewis: any wiki with you as the manager will not work [19:24:17] GerardM-: What are you talking about? [19:24:28] Vogone: of course [19:24:32] it is what DBpedia does [19:24:51] and is willing to do for Wikidata as well [19:25:09] Vogone: but I'm not a wiki manager; I manage other stuff :p [19:25:13] JohnLewis: I mean, who needs to know what articles are short?! you'd rather search by bytes than by badges [19:30:32] Hi. Could an admin check if Q18008936 were about Dr. slumps media franchise? If so, could you restore it? It were deleted as empty after an user merges an item about a manga with an item about the frachise (manga, anime 1, anime 2, video games). [19:32:54] Dereckson: 'Dr. Slump, manga and anime franchise' [19:33:10] is that what it should be? :) [19:33:16] Yes, it's well my lost item :) [19:33:35] Dereckson: restored. [19:33:43] Thank you. [19:36:24] GerardM-: That sounded nice, but for the examples I picked, they didn't manage to extract the date of birth [19:36:33] I've explained the difference between the items to the original RfD nominator and documented it in a WikiProject Fictional universes subpage. [19:36:46] So, it should be (I hope) okay in the future. [19:38:54] Dereckson: if it gets deleted again; feel free to poke me :) [21:07:10] (03Abandoned) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [21:07:15] freaking timeouts [22:02:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4018a61 : Translation updater bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34959353