[03:55:24] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Liuxinyu970226 link https://www.mediawiki.org/w/index.php?diff=1138132 edit summary: [+34] [09:07:22] JeroenDeDauw: hey :) [09:07:25] the change is https://gerrit.wikimedia.org/r/#/c/158631/ [09:08:19] however, I'm still fixing the tests which is not that trivial [10:00:30] (03PS1) 10WikidataBuilder: New Wikidata Build - 06/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158857 [10:09:45] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 06/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158857 (owner: 10WikidataBuilder) [10:15:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/158857 (owner: 10WikidataBuilder) [12:16:22] (03PS3) 10Addshore: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [12:17:03] (03PS11) 10Addshore: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [12:17:25] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156042 (owner: 10Thiemo Mättig (WMDE)) [12:17:30] (03PS3) 10Addshore: Possible refactoring of siteselector._selectFirstSite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [12:21:09] (03CR) 10jenkins-bot: [V: 04-1] Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [13:22:42] hi, I tried to link an article in hewiki to entity in wikidata, and failed because of invalid token. (i managed to link it using wikidata item directly). what should we do when we get invalid token? [13:23:12] BTW the API call for requesting the token use deprecated function: "ction=tokens has been deprecated. Please use action=query&meta=tokens instead." [13:25:25] eranroz: https://bugzilla.wikimedia.org/show_bug.cgi?id=70488 [13:25:40] we will deploy the fix on monday [13:27:21] aude, thanks! [13:31:05] (03PS5) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [13:39:32] (03PS6) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [13:43:32] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [13:47:35] (03PS7) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [13:50:30] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [13:59:17] (03PS2) 10Bene: [WIP] Some more refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [14:03:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Some more refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [14:05:22] (03CR) 10Bene: [C: 04-2] "No longer needed, this is done in https://gerrit.wikimedia.org/r/#/c/156044/. May I abandon the change?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156042 (owner: 10Thiemo Mättig (WMDE)) [14:06:36] (03PS8) 10Bene: Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 [14:15:44] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158631 (owner: 10Bene) [14:20:58] aude: around? [14:21:19] or JeroenDeDauw? [14:25:52] !nyan [14:25:52] ~=[,,_,,]:3 [14:26:04] It's an Abraham_WMDE ! [14:26:49] Lydia_WMDE: what?! no John? :( You evil person [14:33:11] JeroenDeDauw: can you tell me why this test fails? https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/7032/console [14:37:22] >_> [14:37:38] benestar: idk [14:44:51] JeroenDeDauw: do you think the approach is ok? [14:47:05] benestar: what approach? [14:47:40] of the patch (https://gerrit.wikimedia.org/r/#/c/158631/7) [14:47:54] the test still fails but I don't know why [15:12:31] * JeroenDeDauw almost used inheritance for code reuse... almost [15:12:43] Finally a good use case for a trait [15:20:59] =o [15:27:24] (03PS3) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [15:32:55] benestar: I already asked you if you were using http://projects.haykranen.nl/java/ right? ;-) [15:33:27] multichill: if you did so I forgot about it ;) [15:34:30] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [15:34:58] multichill: is that a comment to my patch? :P [15:45:57] (03PS4) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [15:47:25] (03PS5) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [15:47:28] (03PS1) 10Bene: [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [15:49:53] (03Abandoned) 10Bene: [DRAFT] Inject ClaimsView and FingerprintView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155096 (owner: 10Bene) [15:53:29] (03PS6) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [15:53:45] (03PS2) 10Bene: [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [16:00:22] (03PS3) 10Bene: [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [16:02:07] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [16:04:55] (03PS7) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [16:05:08] * benestar is spamming jenkins ^^ [16:08:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 (owner: 10Bene) [16:12:37] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [16:13:51] (03PS8) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 [16:22:52] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [16:43:53] (03Draft1) 10Aude: Handle other projects sidebar more nicely if not in parser cache [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) [16:44:29] (03CR) 10Aude: [C: 04-2] "needs tests and update LangLinkHandler" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [16:44:52] (03CR) 10jenkins-bot: [V: 04-1] Handle other projects sidebar more nicely if not in parser cache [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [16:49:54] (03PS2) 10Aude: Handle other projects sidebar more nicely if not in parser cache [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) [16:58:57] (03CR) 10jenkins-bot: [V: 04-1] Handle other projects sidebar more nicely if not in parser cache [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [17:40:13] (03PS3) 10Aude: Handle other projects sidebar more nicely if not in parser cache [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) [17:45:43] aude: https://www.wikidata.org/w/index.php?title=Q701&diff=156074726&oldid=154601908 <- do you understand what is happening here? [17:46:01] https://www.wikidata.org/w/index.php?title=Q701&action=history <- all sorts of changed claims, but nothing seems to have changed [17:46:50] gattopardesco! [17:47:54] (03CR) 10jenkins-bot: [V: 04-1] Handle other projects sidebar more nicely if not in parser cache [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [17:50:16] multichill: submit a bug ticket [17:50:40] appears to be just that user (from looking in recent changes) [17:50:43] no idea why [17:55:36] [13WikibaseDataModel] 15JeroenDeDauw created 06idth (+1 new commit): 02http://git.io/OT3qOw [17:55:36] 13WikibaseDataModel/06idth 141e080d3 15jeroendedauw: Improve getId type hints... [17:55:46] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #183: Improve getId type hints (06master...06idth) 02http://git.io/q013iw [17:56:03] addshore: easy review is easy ^ [17:57:03] [13WikibaseDataModel] 15addshore 04deleted 06idth at 141e080d3: 02http://git.io/37LDeg [17:57:04] JeroenDeDauw: easy review was easy ^ [17:58:43] [travis-ci] wmde/WikibaseDataModel/idth/1e080d3 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34588584 [18:37:51] (03CR) 10Jeroen De Dauw: Handle other projects sidebar more nicely if not in parser cache [WIP] (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158879 (https://bugzilla.wikimedia.org/70482) (owner: 10Aude) [18:53:31] (03CR) 10Jeremyb: "this is apparently bug 62493 (topic is right, commit msg is wrong)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133086 (https://bugzilla.wikimedia.org/62439) (owner: 10Daniel Kinzler) [18:53:48] ohai grrrit-wm [19:12:32] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/eFFPqw [19:12:32] 13WikibaseDataModel/06master 141f67a1c 15Jeroen De Dauw: Update Claim.php [19:13:07] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/7sfzeQ [19:13:07] 13WikibaseDataModel/06master 1452b8801 15Jeroen De Dauw: Update Claim.php [19:25:20] (03PS4) 10Bene: [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [19:27:21] is any dev here? [19:27:34] You are a dev. :O [19:29:07] (03PS5) 10Bene: [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 [19:29:09] lål [19:29:21] sjoerddebruin lol, any other dev I mean :P [19:29:32] ;) [19:29:41] there's a test failing and I don't know why because I didn't touch the code handled by that test... [19:35:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 (owner: 10Bene) [20:09:23] μαν. σορρυ [23:56:37] (03PS10) 10Jeroen De Dauw: Reduce loading spinner toggle to a single 'loading' CSS class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE))