[06:36:02] are you aware of a bug in Monobook now allowing editors see the badges? [06:36:40] The bot removing badges in the English Wikipedia was blocked [06:36:51] by editors unable to see the badges [06:37:08] "he badges disappeared only from pages edited by Dexbot, like Aspirin, I still see them in other pages like Diamond." [06:37:22] "use monobook, and see the badges after logging out. I've unblocked the bot. It would be great to have the monobook badge issue fixed. I've tried to purge (?action=purge) Aspirin on this wiki and on wikidata, with no effect. " [06:37:40] " Confirmed that it is an issue with Monobook. Diamond is showing as an FA in Esperanto, but it is also an FA in Hungarian and Latvian which are not showing. All three show in Vector. That is a strange inconsistency, but Dexbot removing the template does not seem to have made any difference." [06:38:02] bot unblocked shortly after but we were not aware of this bug [08:12:06] hi [08:12:11] how do I merge items? [08:27:49] Juandev: The best way is to use the merge gadget [08:41:39] matanya: Hey, are you there? [08:41:47] Tpt_: well, now is see it will not be easy [08:42:18] but the problem is wikidata, as the cs.wp doesnt link to en.wp, just because it is connected with a different item on d [08:44:43] well, never midn [08:52:23] (03CR) 10Tpt: "@Benestar:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [08:55:36] Anyone know how to add new languages to the 'In other languages' section? I want to be able to put French labels in, but whatever buttons I nudge in preferences, I can't seem to add French. [08:56:21] Add the babel-template to your user apge, tommorris [08:56:26] page* [08:56:33] sjoerddebruin: ah, okay. [08:56:39] https://www.wikidata.org/wiki/User_talk:Sjoerddebruin#Babel [08:59:03] * tommorris pops fr-1 into his babelbox. ;-) [08:59:26] hah, that's not very intuitive [08:59:27] merci beaucoup, sjoerddebruin. [08:59:33] <3 [08:59:41] jeremyb: especially as there's tools to do so in preferences that don't work. :) [09:01:11] Amir1|AFK: now i am [09:01:53] (03PS1) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [09:19:05] hi :) [09:23:32] matanya: I'm online now [09:23:53] Amir1: just posted on wikidata :) [09:25:27] matanya: So badges exists in Wikidata but not showing in he.wp? [09:25:33] yes [09:25:42] are you using monobook? [09:26:22] skin: monobook, vector, blue cologne, etc. [09:26:55] [13ValueView] 15snaterlicious pushed 1 new commit to 06fix-calendar-switch: 02http://git.io/JQ338g [09:26:55] 13ValueView/06fix-calendar-switch 140c6fcb3 15snaterlicious: Some general sanitation [09:28:35] matanya: It doesn't work in monobook skin, I checked he.wp right now and it's working for me [09:28:56] i use vector [09:29:14] i think the user reporting is using monobook [09:29:25] Can you check yourself? [09:30:30] matanya: ^ [09:30:44] it doesn't work for me in vector [09:32:47] benestar|cloud: ^ [09:33:07] matanya: it's not showing at all? [09:33:16] no, not at all [09:33:25] hmm strange [09:34:02] matanya: have tried logging out? maybe it's because of some gadgets conflicts [09:34:13] i'll try now [09:34:44] Amir1: yes, it works logged-out [09:35:27] check out gadgets you have [09:35:36] I think they are causing this [09:35:50] matanya: ^ [09:36:01] i am [09:36:09] thank you :) [09:41:01] [13WikibaseQueryEngine] 15thiemowmde created 06globenull (+1 new commit): 02http://git.io/aAF2Yg [09:41:01] 13WikibaseQueryEngine/06globenull 14169ecb6 15Thiemo Mättig: Fix searching for default globe [09:42:13] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06globenull from 14169ecb6 to 14e6ac4f5: 02http://git.io/2IHqAg [09:42:13] 13WikibaseQueryEngine/06globenull 14e6ac4f5 15Thiemo Mättig: Fix searching for default globe [09:43:09] [13WikibaseQueryEngine] 15thiemowmde opened pull request #113: Fix searching for default globe (06master...06globenull) 02http://git.io/VywBkA [09:43:49] [travis-ci] wmde/WikibaseQueryEngine/globenull/169ecb6 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/34169803 [09:44:46] [13WikibaseQueryEngine] 15thiemowmde created 06dvintegration2 (+1 new commit): 02http://git.io/6gwaow [09:44:46] 13WikibaseQueryEngine/06dvintegration2 1422d476a 15Thiemo Mättig: Add all DVHandler integration tests [09:45:33] [13WikibaseQueryEngine] 15thiemowmde opened pull request #114: Dvintegration2 (06master...06dvintegration2) 02http://git.io/1okRVA [09:45:35] Amir1: i couldn't find any offending gadget [09:46:19] matanya: i think there is a bug with monobook and badges [09:46:30] aude: but i use vector :) [09:46:32] [travis-ci] wmde/WikibaseQueryEngine/globenull/e6ac4f5 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/34169860 [09:46:37] oh [09:46:39] no idea [09:47:14] hi Amir1_ [09:47:26] matanya: hey [09:47:28] :) [09:47:47] so i looked, and couldn't find the offending gadget [09:49:21] hmm [09:49:41] Surely benestar|cloud can check that [09:52:24] matanya: Go to an article in he.wp that has badge in Wikidata (and my bot removed your template) [09:52:34] Use Inspect Element [09:52:53] Amir1: sorry, must rush to a meeting in a few [09:52:53] you should see something like this: [09:53:03] i'll look at it in the evening, ok ? [09:53:22] ok, I'm off to bed [09:53:25] e-mail me [09:54:14] [travis-ci] wmde/WikibaseQueryEngine/dvintegration2/22d476a : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/34170071 [09:54:37] sure, thanks for your help Amir1 [09:54:50] (03CR) 10Henning Snater: [V: 032] "All Selenium and QUnit tests pass." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 (owner: 10Henning Snater) [09:54:51] you are welcome :) [10:01:00] (03PS1) 10WikidataBuilder: New Wikidata Build - 02/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157800 [10:01:29] (03PS12) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [10:06:44] [13Wikiba.se] 15jakob-WMDE pushed 1 new commit to 06master: 02http://git.io/aUblUA [10:06:44] 13Wikiba.se/06master 14ba5fc5e 15Jakob Warkotsch: Add icons to feature list points. [10:07:07] it's a Lucie_WMDE ! [10:07:20] https://www.wikidata.org/wiki/Q19088 [10:07:26] thanks [10:07:42] I made it to the wikidata channel!! [10:10:33] *waves at Lucie_WMDE* [10:15:42] * Lucie_WMDE waves [10:15:47] * legoktm grumbles about having to use github... [10:15:58] Lucie_WMDE: what json dump are you using? what date? [10:16:15] * Lydia_WMDE hugs legoktm [10:16:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157800 (owner: 10WikidataBuilder) [10:16:20] yo addshore! [10:16:25] o/ [10:16:42] yo Lydia_WMDE yo legoktm :> [10:16:57] * aude ignores wikidatajenkins [10:17:14] (03CR) 10Aude: [C: 032] New Wikidata Build - 02/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157800 (owner: 10WikidataBuilder) [10:17:58] aude I used 20140825, so the newest one and 20140721 [10:18:10] ok [10:18:37] i can run dumpJson on the item and it works [10:18:46] [13WikimediaBadges] 15legoktm opened pull request #11: Fixes for things I noticed (06master...06fixname) 02http://git.io/BcBfdg [10:18:57] :o stalker [10:19:55] extensions on github aren't being translated on twn...? [10:20:40] legoktm: no workflow, scripts yet [10:20:53] :( [10:20:58] legoktm: and no maintainer... [10:21:02] benestar|cloud: https://bugzilla.wikimedia.org/show_bug.cgi?id=70280 fyi [10:23:17] aude I will try to test it again, but I somehow made a mistake and it takes a minute to find it... [10:23:29] there is a new dump from yesterday [10:23:47] my theory is that the entity per page rebulid script repaired that item [10:28:52] https://www.wikidata.org/wiki/Special:Version [10:36:54] (03Abandoned) 10Thiemo Mättig (WMDE): Refactor nested loop in entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155757 (owner: 10Thiemo Mättig (WMDE)) [10:43:16] [13Wikidata.org] 15legoktm opened pull request #11: Fix things I noticed (06master...06fix) 02http://git.io/BA9DeQ [12:03:44] (03PS5) 10Thiemo Mättig (WMDE): Make ChangeNotifier an interface and introduce NullChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 [12:06:50] Tobi_WMDE_SWE: evil tobi, moving the meeting\ [12:07:14] Tobi_WMDE_SWE: and you only sedn two mails about it! [12:07:17] eviiiiil [12:09:14] (03PS2) 10Thiemo Mättig (WMDE): Remove visible whitespace in sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156117 [12:12:30] [13Wikidata.org] 15thiemowmde pushed 3 new commits to 06master: 02http://git.io/8g0RsQ [12:12:30] 13Wikidata.org/06master 14c84bbf0 15Kunal Mehta: Rename resource module to "ext.wikidata-org.badges"... [12:12:30] 13Wikidata.org/06master 143c49f03 15Kunal Mehta: Use OutputPage::addModuleStyles() for non-JS users [12:12:30] 13Wikidata.org/06master 140402bed 15thiemowmde: Merge pull request #11 from legoktm/fix... [12:21:11] JeroenDeDauw: I was just the poor guy having to announce it [12:22:17] Tobi_WMDE_SWE: as the saying goes: "rage to the messager and rage more to Lydia_WMDE" [12:22:31] :) [12:22:45] Thiemo_WMDE: protip: if you have a dbal question, ask it on their issue tracker or IRC [12:23:10] (03CR) 10Tobias Gritschacher: [C: 031 V: 032] "Also all of the browsertests passed. So there seems to be no obvious influence on the frontend." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw) [12:23:32] JeroenDeDauw: ok. i worked around this for now. could not find the case in a documentation unfortunatelly. [12:29:56] [13WikibaseQueryEngine] 15JeroenDeDauw 04deleted 06globenull at 14e6ac4f5: 02http://git.io/5CGHGA [12:30:51] Thiemo_WMDE: see the thing I quoted [12:31:16] Thiemo_WMDE: if you want, you can try getting support for this in: https://github.com/doctrine/dbal [12:38:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw) [12:51:26] (03CR) 10Aude: "@bene* before and after this patch, the other projects section is positioned above the toolbox." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [12:53:28] (03CR) 10Aude: [V: 032] "per wmf jenkins" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157800 (owner: 10WikidataBuilder) [12:53:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/72c115e : jeroendedauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34183047 [12:56:26] (03CR) 10Bene: [C: 04-1] "We have to find a better way of doing this than destroying the whole code layout. Maybe some str_replace( "\n", '' ) or so." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156117 (owner: 10Thiemo Mättig (WMDE)) [13:03:00] [13WikibaseDataModel] 15thiemowmde created 06badgesnull from 06master (+0 new commits): 02http://git.io/kBuLoQ [13:04:05] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06badgesnull: 02http://git.io/zgB0gQ [13:04:05] 13WikibaseDataModel/06badgesnull 14ae21de7 15Thiemo Mättig: Restore support for badges being null [13:07:25] [travis-ci] wmde/WikibaseDataModel/badgesnull/ae21de7 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34185016 [13:07:30] [13WikibaseDataModel] 15thiemowmde opened pull request #179: Restore support for badges being null (06master...06badgesnull) 02http://git.io/1uovAA [13:36:59] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157800 (owner: 10WikidataBuilder) [13:38:00] (03CR) 10Bene: "@Tpt so are you ok with this change or do you know if something won't work with this code? Otherwise I'll merge it as Aude has tested the " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [14:02:49] aude still doesn't work. But doesn't work for world war 1 (Q361) so I start thinking I just wrote a very selective script. :) I will check again! [14:04:54] huh [14:10:18] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/hg7yQw [14:10:18] 13WikibaseDataModel/06master 142bc84df 15Jeroen De Dauw: Merge pull request #179 from wmde/badgesnull... [14:20:51] Thiemo_WMDE: any DM 1.0 blockers from your side? [14:20:53] addshore: ^ [14:20:56] Tobi_WMDE_SWE: ^ [14:21:04] (Blockers for creating the 1.0 tag) [14:27:25] think it's ok [14:32:01] Deploy-day? :D [14:33:00] yes [14:33:08] according to the calendar ofc [14:33:15] not so much new, but yes [14:33:20] not christmas :/ [14:33:35] the opposite as stuff are possibly breaking today :D [14:34:38] Entity suggester? [14:34:48] sjoerddebruin: yes [14:35:04] :D [14:35:28] Within a few hours, I think? [14:35:41] sjoerddebruin: yes [14:35:57] Can you say something else? :) [14:36:13] no :p [14:36:16] (03PS1) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [14:45:26] (03CR) 10jenkins-bot: [V: 04-1] Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [14:54:19] (03PS2) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [15:05:18] aude: new JS gets deployed today, right? so things might break due to caching [15:05:19] (03CR) 10jenkins-bot: [V: 04-1] Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [15:05:43] and gadgets will break - as announced [15:06:03] [13WikibaseDataModel] 15thiemowmde created 06badgepatch (+1 new commit): 02http://git.io/vnWLEA [15:06:03] 13WikibaseDataModel/06badgepatch 142278185 15Thiemo Mättig: Fix Item::patchSiteLinks [15:08:13] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #177 148db21f7: Not very happy with this provider. Using multiple methods would be better to counter code rot and would result in more re-usability in the rest of the test, thus less duplication 02http://git.io/Lsoa1g [15:08:17] Thiemo_WMDE: Thiemo_WMDE please condier my comment on that pr [15:08:48] [13WikibaseDataModel] 15thiemowmde opened pull request #180: Fix Item::patchSiteLinks (06master...06badgepatch) 02http://git.io/zqZ8kA [15:10:13] (03CR) 10Daniel Kinzler: "@Bene: does this patch mean we are running a db query to find the links every time the page is output? That doesn't scale..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [15:11:32] [travis-ci] wmde/WikibaseDataModel/badgepatch/2278185 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34196264 [15:11:43] (03CR) 10Daniel Kinzler: "...the sidebar should be generated from the (cached) ParserOutput object, not from a db query. Is it?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [15:23:36] (03CR) 10Tobias Gritschacher: [C: 032] Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [15:23:58] (03PS10) 10Tobias Gritschacher: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 (owner: 10Henning Snater) [15:26:01] JeroenDeDauw: jzerebecki: [15:26:35] jzerebecki: are you bothered by the noise in the room? [15:31:58] JeroenDeDauw: which noise? [15:34:20] [13WikibaseDataModel] 15thiemowmde created 06nocopy (+1 new commit): 02http://git.io/dOKb1Q [15:34:20] 13WikibaseDataModel/06nocopy 14cadb726 15Thiemo Mättig: Avoid using copy() in ItemTest [15:34:35] [13WikibaseDataModel] 15thiemowmde opened pull request #181: Avoid using copy() in ItemTest (06master...06nocopy) 02http://git.io/OecKbw [15:35:13] (03Merged) 10jenkins-bot: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [15:36:56] [travis-ci] wmde/WikibaseDataModel/nocopy/cadb726 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34199119 [15:49:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/49d4217 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34199230 [16:01:41] [13ValueView] 15thiemowmde created 06termtrim (+1 new commit): 02http://git.io/eQ4gAg [16:01:41] 13ValueView/06termtrim 143097033 15Thiemo Mättig: Trim term in suggester [16:01:46] jzerebecki: I'll take that as a no [16:02:59] [13ValueView] 15thiemowmde opened pull request #111: Trim term in suggester (06master...06termtrim) 02http://git.io/LbpU7g [16:03:24] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/Sl8e6Q [16:03:24] 13WikibaseDataModel/06master 14cadb726 15Thiemo Mättig: Avoid using copy() in ItemTest [16:03:24] 13WikibaseDataModel/06master 147aff1f2 15Jeroen De Dauw: Merge pull request #181 from wmde/nocopy... [16:05:28] <92AAAQ6B9> [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/_jBr7w [16:05:28] <92AAAQ6B9> 13ValueView/06master 144695925 15Tobi Gritschacher: Merge pull request #109 from wmde/fix-calendar-switch... [16:05:29] [13ValueView] 15tobijat closed pull request #109: Fix calendar switch to Julian (Bug 65847). (06master...06fix-calendar-switch) 02http://git.io/RoWNRQ [16:05:57] (03PS11) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [16:06:09] (03CR) 10jenkins-bot: [V: 04-1] Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [16:07:04] benestar|cloud: late congrats with badges :) [16:07:08] *high five* [16:08:07] (03PS11) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [16:08:20] (03PS8) 10Henning Snater: Eliminated PersistentPromisor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 [16:08:20] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/lwBKSQ [16:08:20] 13WikibaseDataModel/06master 14afd3e61 15jeroendedauw: 1.0 release [16:08:25] (03PS8) 10Henning Snater: Removed wikibase.utilities.jQuery [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 [16:08:29] (03PS9) 10Henning Snater: Refactored ResourceLoader QUnit test modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 [16:08:34] (03PS8) 10Henning Snater: Untangled $.wikibase.snakview ResourceLoader modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 [16:08:40] (03PS13) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [16:08:40] [13WikibaseDataModel] 15JeroenDeDauw tagged 061.0.0 at 06master: 02http://git.io/fTMhpw [16:08:44] (03PS12) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [16:08:53] (03PS6) 10Henning Snater: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 [16:14:36] (03PS7) 10Henning Snater: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 [16:18:47] (03PS6) 10Henning Snater: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 [16:21:29] (03PS6) 10Henning Snater: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 [16:21:37] (03PS11) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [16:21:42] (03PS7) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [16:21:47] (03PS2) 10Henning Snater: Eliminated global events [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157794 [16:21:51] (03PS3) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [16:25:44] [travis-ci] wmde/WikibaseDataModel/1.0.0/afd3e61 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34202532 [16:26:23] [13ValueView] 15thiemowmde created 06suggestLanguage (+1 new commit): 02http://git.io/rzauow [16:26:23] 13ValueView/06suggestLanguage 140f6a901 15Thiemo Mättig: Introduce language suggester for monolingual [16:26:39] (03PS4) 10Henning Snater: Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 [16:28:25] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ReBIug [16:28:25] 13WikibaseDataModel/06master 1433d4979 15jeroendedauw: Fix @since tags [16:31:12] [13ValueView] 15thiemowmde opened pull request #112: Introduce language suggester for monolingual (06master...06suggestLanguage) 02http://git.io/T4yM9A [16:41:07] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "What the ...? A -1 because of "code formatting"? In HTML? That's a joke, right? The suggestion is scary. Why should anybody waste time on " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156117 (owner: 10Thiemo Mättig (WMDE)) [16:47:12] Amir1|ZzzZzz: ping [16:57:46] (03CR) 10Bene: [C: 031] "Hmmm, while code formatting isn't that important in HTML we had such cases quite some recently iirc. This does not really affect your chan" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156117 (owner: 10Thiemo Mättig (WMDE)) [16:58:52] (03CR) 10jenkins-bot: [V: 04-1] Moved edit functionality to fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157817 (owner: 10Henning Snater) [17:30:53] (03CR) 10Bene: "@Daniel yeah, this is perhaps why we had two functions before. The sidebar gets cached at the moment but apparently not on Wikipedias as t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [17:35:07] (03CR) 10Aude: "with this change, the sidebar (and the lookups) is only done for those who opt-in." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [17:37:17] (03CR) 10Aude: "we could also, or instead, stuff this into parser cache for output page to access. (@todo in follow up)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [17:47:52] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/2OnNow [17:47:52] 13Wikiba.se/06master 1435ee580 15Jeroen De Dauw: Update applications.html [17:56:32] [13WikimediaBadges] 15Benestar closed pull request #11: Fixes for things I noticed (06master...06fixname) 02http://git.io/BcBfdg [18:13:38] benestar: uh, how long will it take for my github PRs to get deployed? [18:13:48] legoktm: ask aude [18:13:57] or, when do I have to fix them by so things don't break? [18:14:01] hah [18:14:23] depends how bad stuff is broken [18:14:49] i would like to backport the patch for badges in monobook [18:15:14] aude: they fixed it somehow locally by removing some evil CSS from the Common.css [18:15:25] legoktm: btw, how many wikis do still have that evil code? [18:15:34] benestar: ok :) [18:15:45] i am nervous about changing module names in a backport [18:16:03] *wonders if he should remove Content objects from his mediawiki-datamodel library .... [18:16:04] that's better to do in a new branch [18:16:06] aude: users who get the cached html won't see badge styles since I changed the name [18:16:33] To fix that we just need a 'wikimediaBadges' => array( 'dependencies' => 'ext.wikimediaBadges' ) [18:16:42] (as a registered module) [18:17:04] legoktm: and remove it once the stuff is deployed, right? [18:17:11] after 30 days [18:17:37] hmm [18:17:40] I'm seeing "wikimediaBadges.default" [18:18:06] legoktm: benestar we make a new branch next week [18:18:35] so deploy in 2 weeks [18:18:47] ok, I'll upload a patch to fix it later tonight [18:20:37] magioladitis: pong [18:20:47] :) [18:21:10] Amir1: I left a question in your talk page [18:23:37] okay :) [18:24:20] magioladitis: I can't find it, you answered some else's question (Thanks) [18:25:16] aude: when will https://gerrit.wikimedia.org/r/#/c/155276/ go live? [18:25:28] oh you left a message in my talk page [18:25:42] Amir1: --^ this will make the badge categories on Wikipedias perhaps obsolete [18:26:17] hmm [18:26:45] DanielK_WMDE: you will look at the Ask language and verify that you do not see any problems with having this as interface for out query system? [18:26:52] I'm wondering if bugs (I mean bugs bugs -> i.e. something wrong, not feature bugs) related to badges should really block the badges bug [18:27:15] (40810) [18:27:30] lazowik: why not? it's a tracking bug [18:27:35] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase.git/refs%2Fheads%2Fmw1.24-wmf19?pg=2 [18:27:45] but that's sth Lydia_WMDE has to decide because she owns the power of bugzilla ;) [18:27:45] benestar: so today [18:27:45] yeah, but for a new feature [18:27:54] \o/ [18:27:58] * Amir1 doesn't know who to thank benestar [18:28:41] when proper (js) repo ui is ready it should be probably closed [18:28:46] benestar: for the wikipedias, thursday [18:28:52] Amir1: I don't know though if all the items have to get touced so that the badges get recorded or if this will happen automatically [18:28:56] aude: do you know? [18:29:11] magioladitis: stopped the bot [18:29:12] not automatic [18:29:35] aude: so touching all the items is necessary? [18:29:48] how many items? [18:29:48] or is there some maintenance script? [18:29:52] benestar: okay, Just asking Can you fix monobook issue? [18:29:57] Amir1: how many items have badges? [18:30:12] I pinged you and aude in English Wikipedia [18:30:12] Amir1: the monobook issue is fixed on enwiki afaik [18:30:21] legoktm fixed it [18:30:21] magioladitis: ^ [18:30:49] there was some evil css in Common.css [18:30:49] Today morning some one told it's not [18:30:49] someone else fixed it, I just figured out what the issue was [18:30:54] benestar: https://en.wikipedia.org/wiki/User_talk:Dexbot#Blocked [18:30:55] legoktm: well, fair enough ;) [18:31:03] aude: 30k items [18:31:03] but until new code is deployed or other wikis fix their css, we'll see the issue on other projects [18:31:17] magioladitis: I think it's a little more than that about 40K [18:31:40] in he.wp it has issues even in vector [18:31:43] matanya: he/she told me [18:32:02] aude: perhaps we should backport the fix... [18:32:15] legoktm: hey! [18:32:20] o/ [18:32:22] matanya is a he [18:32:29] Amir1: 13076 + 16722 = 29798 [18:32:39] Link FA _ Link GA [18:32:40] legoktm: when labs issue is over, come help solve this :) [18:32:44] magioladitis: count English badges too [18:32:50] ? [18:33:01] featured articles in English Wikipedia [18:33:17] and they overlap obviously [18:33:39] Amir1: benestar there is no maintenance script for this afaik [18:33:58] aude: for what script? [18:34:05] for touching those items [18:34:08] a bot can do it [18:34:44] Amir1: to have the backlinks in the database [18:34:44] aude: I can do that [18:34:49] so you'd have to touch all those items again that the links to badge items get recorded [18:34:51] It's easy [18:35:06] but wait until the thing is deployed ;) :P [18:35:14] sure [18:35:26] Amir1: :) [18:36:05] ping me when it's done [18:37:01] waiting on doing stuff with wikitech wiki [18:37:13] unbreaking things there [18:37:48] * Amir1 is afk for "breakfast" :D [18:38:01] Amir1: o.O [18:38:17] well, you are from the other side of the world, right? :P [18:39:22] same timezone as Jeroen.DeDauw ? [18:39:28] benestar: :))) http://thedailyshow.cc.com/videos/xer89g/jason-jones--behind-the-veil---ayatollah-you-so [18:39:46] my tz is +3:30 [18:39:57] so, yes ;) [18:40:09] but in real life I wake up in 11 PM [18:40:41] Amir1: we're sorry but this video isn't available in your location -.- [18:42:02] shit [18:42:07] let me find this [18:54:22] benestar: sent the video [18:54:25] ;) [19:09:53] Amir1: xD thanks for the video :D [19:10:06] :) [19:10:29] John Stewart is amazing [19:10:43] I collect his videos [19:11:51] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/2_siLg [19:11:51] 13WikibaseDataModel/06master 14d2821fb 15Jeroen De Dauw: Update RELEASE-NOTES.md [19:14:33] deployed! [19:14:41] :O [19:15:08] :O [19:15:38] I see. https://www.dropbox.com/s/vvn9jj6i3jcwcnl/Schermafdruk%202014-09-02%2021.15.35.png?dl=0 [19:15:45] * aude checks for issues with site links [19:16:07] sjoerddebruin: reload [19:16:22] i've seen that once ina while and not sure why [19:16:26] Still there. [19:16:28] but it goes away when reloading [19:16:29] Also after pruge [19:16:30] :/ [19:16:40] oh, i see [19:17:51] And too much margin. :'( [19:18:44] ok for me with debug=true [19:18:54] not a solution but indicates caching problem [19:19:23] I hate the cache. [19:19:49] or resource loader [19:25:07] But this doesn't look normal. https://www.dropbox.com/s/s9ilp2e8uru39u0/Schermafdruk%202014-09-02%2021.25.02.png?dl=0 [19:25:27] maybe it's a new UI? [19:25:39] That would be a huge mistake. ;) [19:26:19] sjoerddebruin: it's default jquery style [19:26:35] something is loading in the wrong order that our overrides are not working :( [19:26:40] Have you looked at the screenshot? [19:26:49] * aude click [19:26:49] It's not about the gradientbackground. ;) [19:27:46] you are talking about the width? [19:28:02] The space between the sections. [19:28:22] hmmm [19:28:40] we purged the parser cache so shoudl not be these issues [19:28:57] * aude investigates [19:32:42] And where's the entity suggester? :( [19:33:13] ? [19:33:56] That was pushed from last week to this week? [19:34:05] For sources and qualifications? [19:35:14] the code is there [19:35:23] i need to update one of the tables [19:36:00] want to lok at the bugs first [19:36:06] ok [19:46:48] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/j5414Q [19:46:48] 13WikibaseDataModelSerialization/06master 1493d144b 15jeroendedauw: Use a stable version of DataModel [19:47:38] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_Ee_kQ [19:47:38] 13WikibaseDataModelSerialization/06master 1464c124c 15jeroendedauw: 1.1 release [19:58:34] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/CQLozQ [19:58:34] 13WikibaseInternalSerialization/06master 143129659 15jeroendedauw: Make component work with DataModel 1.0 [20:02:48] [travis-ci] wmde/WikibaseDataModelSerialization/1.1.0/679eecc : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/34222164 [20:13:56] Hello, I have a quick question: it is possible to create a property programmatically, i.e. using pywikibot? [20:16:05] CristianCantoro: only Wikidata admins and the property creators can create properties on Wikidata after succesful request at Wikidata:Property proposal [20:17:23] CristianCantoro: as Stryn said. if you have the proper right you can also do it via the API [20:18:44] Stryn: Sorry, what I did not specify was that I was asking about a custom Wikibase install. Say that I want to experiment with Wikibase and I have a local install, and I have some data sitting there that I want to put in my local wikibase. Is there a way to populate the properties programmatically? So assuming that I have all the needed rights in my local MediaWiki+Wikibase install? [20:19:35] yes via the API [20:19:58] https://www.wikidata.org/w/api.php [20:20:00] Lydia_WMDE: is it only possible via API? Then pywikibot does not come with the needed functions/interfaces/whatever? [20:20:13] i don't know if pywikibot implements it [20:20:16] Amir1: ^ [20:23:47] CristianCantoro: i think so [20:23:53] using wbeditentity [20:23:59] CristianCantoro: Hey [20:24:02] 'new' => 'property' [20:24:06] It's implemented [20:24:28] data' => $serialization, [20:24:33] :) [20:24:39] even easier [20:24:48] aude: but that's using the API, right? [20:24:55] CristianCantoro: yes [20:24:58] CristianCantoro: https://www.mediawiki.org/wiki/Manual:Pywikibot/Wikidata [20:25:12] * aude copied all the wikidata properties to my test wiki [20:25:20] using wbeditentity [20:25:37] the compat branch has some issues [20:25:47] (my patch hasn't been merged yet) [20:26:38] aude: :D [20:26:56] Amir1: data.editclaim(property, value) creates the property if it does not exists? [20:27:16] yes [20:27:18] In compat [20:27:22] in core it's different [20:27:40] ach, I am using core [20:27:56] (but I would switch if it is the case) [20:28:27] in core branch things change so fast that I can't touch [20:28:34] let me check [20:28:48] * aude rage at resource loader [20:28:56] (strange though since https://tools.wmflabs.org/pywikibot/ says "[compact is] The older version of pywikipedia which is better for running in out-dated wikis") [20:29:30] I wrote that :D [20:30:08] Amir1: I was assuming that core is recommended over compact :) [20:30:21] it is [20:30:23] Honestly compat is very stable comparing to core but it's old and buggy and not efficient [20:30:44] Anyway I'm searching for documentation for core [20:30:57] Amir1: ok, thy [20:31:07] CristianCantoro: https://www.mediawiki.org/wiki/Manual:Pywikibot/Wikidata#Working_with_pywikibot.2Fcore_.28former_rewrite_branch.29 [20:31:14] this works for you I think [20:32:29] I usually learn things through examples and I write manuals this way [20:36:34] Amir1: (sorry connection) [20:37:01] np [20:37:07] Amir1: bu then I am not sure if I understand here (https://www.mediawiki.org/wiki/Manual:Pywikibot/Wikidata#Working_with_pywikibot.2Fcore_.28former_rewrite_branch.29) how to add a property if I don't know before if it exists [20:37:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/53c05e4 : Translation updater bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34225061 [20:38:04] CristianCantoro_: you can check that by something like if 'P107' in item.claims: [20:38:35] Can I simply do: item.claims['P123'] = something with P123 being a new property number? [20:38:50] and how can I set the name for the new P123? [20:39:18] yes [20:40:13] what kind of name? [20:40:21] do you mean value of P123? [20:41:44] yes, like P21 is 'country' (https://www.wikidata.org/wiki/Property:P17) [20:41:59] ops sorry, P17 :P [20:42:40] In pywikibot AFAIK you shouldn't use names [20:42:53] you can check the wiki and get the number [20:43:04] (because name is language-based) [20:44:13] (Don't tell anyone but I implemented a way to do that in compat, based on language of source page but it brings server to its knees) [20:44:29] Amir1: ok, but there is a way in pywikibot to get P21 if I search for 'country'? [20:45:08] I think, let me check [20:47:31] CristianCantoro_: there is not :( [20:47:36] Can you file a bug for it? [20:48:25] [13WikibaseInternalSerialization] 15JeroenDeDauw tagged 061.2.0 at 06master: 02http://git.io/qJqV6Q [20:48:27] (03PS3) 10Jeroen De Dauw: Don't use SkinBuildSidebar hook for other projects feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [20:52:55] GerardM-: Hoi, kan je weer een lading Belgische sentators en volksvertegenwoordigers importeren? Er zijn in de tussentijd weer een flink aantal bijgekomen. [20:54:47] [travis-ci] wmde/WikibaseInternalSerialization/1.2.0/e7be041 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/34227510 [20:54:57] Amir1: is this ok? https://bugzilla.wikimedia.org/show_bug.cgi?id=70302 [20:56:41] CristianCantoro_: Great thank you [21:03:24] (03PS3) 10Jeroen De Dauw: Remove visible whitespace in sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156117 (owner: 10Thiemo Mättig (WMDE)) [21:15:08] <3 [21:17:14] (03PS1) 10Jeroen De Dauw: Use a stable version of DataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157973 [21:21:50] aude: I forgot to ask, Can I touch items? [21:21:54] badges? [21:22:46] Amir1: yes [21:23:01] cooool [21:24:33] :) [21:28:26] aude: 2- Is there any API action like touch? [21:28:54] or a action=purge&forcesitelinks=1 is enough? [21:30:00] I can do dummy edit too [21:30:23] Amir1: purge? [21:30:35] not aware of anything else [21:31:15] I don't think purge would update cache [21:31:20] this cache I mean [21:31:28] I do dummy edit [21:32:42] hmmmm [21:32:52] you are probably right [21:39:57] Amir1: AFAIK a dummy edit is equal to purging [21:40:21] at least according to dewiki docs :p (no warranty!) [21:43:12] :))) [22:07:59] sjoerddebruin: Lydia_WMDE we now have property suggestions for referneces and qualifiers [22:08:03] seems to work fine [22:08:04] :O [22:08:11] wohooooooooooooooooo [22:08:13] still looking at the styling issues though [22:08:25] \o/ [22:08:41] jquery.ui.core is being defined after wikibase styles :/ [22:08:43] one cake for aude :D [22:08:54] heh [22:09:50] i see [22:09:57] aude: Have you updated the whole entity suggester database? [22:10:09] not sure why it's or what adds it [22:10:13] sjoerddebruin: yes [22:10:24] Okay, nice. [22:10:54] Yes, I see it. :) [22:10:58] urgh [22:11:07] can we blacklist "imported from"? :D [22:11:08] updated to the august 4 dump [22:11:15] Lydia_WMDE: i think we can [22:11:19] AUGUST 4?!? [22:11:22] what do others think? [22:11:44] Lydia_WMDE: i see p107 blacklisted [22:11:52] It's only for bots? [22:12:00] (imported from) [22:12:16] sjoerddebruin: it is used so often... [22:12:26] it'll be suggested everywhere [22:12:32] and most of the time people shouldn't use it [22:12:37] Ok... [22:12:47] sjoerddebruin: the latest dump from last week uses the new serialization format [22:12:56] so unless there are strong objections i'd like to blacklist that one [22:13:05] we need to update the entity suggester scripts for that [22:13:10] Okay. [22:13:14] Lydia_WMDE: do we have a bug for that? [22:13:21] should be trivial [22:13:26] sjoerddebruin: shouldn't be too much of a difference though in the correlations since then [22:13:30] Is P70 already on the blacklist? [22:13:33] https://www.wikidata.org/wiki/Property:P70 [22:13:38] aude: for the switch to new serialization? will check [22:13:40] per Lydia_WMDE [22:13:50] Lydia_WMDE: yes [22:14:02] sjoerddebruin: not yet i believe [22:14:03] that's why i was getting empty results, as the dump already had switched [22:14:08] https://www.wikidata.org/wiki/Property:P741 also needs to be added [22:14:13] (to the blacklist) [22:14:25] *nod* [22:14:29] Urgh, why can't sysops do that? :( [22:15:05] sjoerddebruin: we should consider moving that on-wiki indeed [22:15:23] Shouldn't be hard? [22:15:51] idunno :D [22:16:01] aude: none yet. will take care of that tomorrow [22:16:26] Lydia_WMDE: ok [22:17:09] sjoerddebruin: wanna file a bug for that? [22:17:12] For blacklisting? [22:17:16] yeah [22:17:30] Can you do that? It's almost bedtime. Zzzzz [22:17:37] here too :D [22:17:40] will try to do it tomorrow [22:17:44] Same timezone. :'( [22:18:05] I'm searching for the item where i've beated the entity suggester. [22:18:13] lol [22:24:21] What was the last time btw the entity suggester-database got updated before? [22:24:32] we have not updated it [22:24:38] so it was when we first deployed it [22:24:51] this is the first update it gets [22:24:52] Okay, I notice differences. <3 [22:24:56] \o/ [22:25:39] taxon gives the suggestion for the image property now, so a lot of images were added in the last weeks! [22:25:48] nice [22:26:01] i think we will automate it more to update with each dump [22:26:05] +1 [22:26:12] yeah [22:26:17] the first times, wmf wanted it to be manual [22:26:34] seems to work ok :) [22:26:50] But this gives people a good feeling, because their edits have a huge impact on our pretty large database. [22:27:26] indeed :) [22:27:29] <3 [22:28:28] And my 69094 edits still need to be processed. :O [22:28:45] :P [22:40:07] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=wikidata&service=check+if+wikidata.org+dispatch+lag+is+higher+than+2+minutes [22:40:20] (you can login with labs credentials if you have the NDA group in LDAP) [22:40:24] such as jzerebecki [22:40:36] short version: monitoring for dispatch added.. bam [22:41:29] \o/ [22:41:31] so easy [22:44:06] Okay, aude good luck with fixing styles. Lydia_WMDE: see you later today I think? [22:44:23] sjoerddebruin: indeed :P [22:44:28] mutante: weeeeeeeeeee [22:44:35] thx! [22:44:47] * sjoerddebruin goes for a shower [22:45:52] Lydia_WMDE: now, perfect test would be if we can break it on purpose for a few minutes :) [22:46:18] heh [22:46:42] oh, and next question.. so far this will show up in web ui, and on IRC... [22:46:49] but did you want actual email or even pages? [22:46:56] then that would be additional changes [22:47:07] incl. adding a group for wikidata and such [22:47:39] mutante: was about to ask [22:47:54] can we be notified in the wikidata channel? [22:47:55] sending mail is not so hard [22:47:55] irc is most important, second would be email [22:48:00] don't care about the rest tbh [22:48:01] sending SMS is another thing [22:48:11] then email me [22:48:12] ehm. yea. i don't know yet [22:48:15] it's about the IRC bot :) [22:48:22] * aude doesn't pay attention to sms [22:48:24] we'll have to check how easy it is to configure that [22:48:35] so far it's only in ops channel [22:48:36] yeah email to aude and me would be good [22:48:45] ok [22:48:58] i expect that it won't be hard to make it join this channel [22:49:03] but that it will be harder to filter it [22:49:11] and my phone number always changes depending on waht country i am in [22:49:16] so sms not good [22:49:18] and you would soon say "but all this non-wikidata stuff, we dont care" [22:49:44] can talk to jzerebecki about that [22:49:56] mutante: or it can ping me in operations? [22:50:04] we might as well just use another not, we never have enough different IRC bots :P [22:50:23] say "aude: the dispatch is broken!" [22:51:09] hmm, the easy way to do that would be to simply include "aude" in the name of the service :p [22:51:16] :) [22:51:21] "check_for_aude_if_wikidata_.." :p [22:51:28] if reporting to wikidata channel is too complicated [22:51:47] i wonder if there will be more monitoring later [22:52:18] the dispatcher will eventually go away, actually [22:52:25] be replaced entirely with the job queue [22:52:40] who knows, we might have some other monitoring though [22:52:59] we said we want some for database stuff [22:53:03] like size of some tables [22:53:16] hmmm, ok [22:56:59] ehm, unfortunately.. it does NOT work yet [22:57:06] The command defined for service check if wikidata.org dispatch lag is higher than 2 minutes does not exist [22:57:16] that's some problem with escaping.. grrr [22:57:49] i got the impression it was fixed because there is such a long delay until icinga is done refreshing [22:58:00] :/ [23:06:50] aude: touching [23:18:15] aude: it's populating: https://www.wikidata.org/wiki/Special:WhatLinksHere/Q17437796 [23:18:43] yay [23:21:57] sorry it took so long, it was some issues in token handling [23:23:08] no rush