[00:36:34] Hi. [00:37:41] We have some items with labels created by bot following interwikis. Some of these bots used *EVERY* interwiki to use as a label, including redirects. [00:37:51] That gives items like Q246866 - Unseen University#Librarian [00:38:19] or Q2813462 - 2005 Giro d'Italia, Stage 11 to Stage 20#19th stage [00:39:34] I've prepared such a list: http://ysul.nasqueron.org/~dereckson/wikidata/wikidata-label-with-redirects-en.html (443 items) [00:41:19] (this list is only for English labels, if someone wants another language, just ask) [01:00:51] any regex experts (regexperts) around? [01:01:29] i need a regex that matches an entire line that contains the string "OK, now" [01:37:32] Hi [05:58:44] (03CR) 10Bene: [C: 032] Fix incomplete ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157080 (owner: 10Thiemo Mättig (WMDE)) [06:03:10] * hoo wonders if aude is awake, yet [06:07:46] (03Merged) 10jenkins-bot: Fix incomplete ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157080 (owner: 10Thiemo Mättig (WMDE)) [06:23:13] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/62edb2e : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34075468 [07:12:56] (03PS1) 10Thiemo Mättig (WMDE): Make TestChanges compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157646 [07:16:35] (03PS1) 10Thiemo Mättig (WMDE): Make SnaksFinderTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157647 [07:28:00] (03PS1) 10Henning Snater: Have AbstractedRepoApi inherit from RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157648 [08:17:11] (03PS3) 10Tobias Gritschacher: Drop unused EntityRevisionSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [08:24:49] (03PS9) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [08:25:18] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Nice find, Tobi. :-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [08:29:19] Здравствуйте. Пытаюсь создать запрос в Wikidata Query editor, который бы делал выборку по слову, содержащемуся в title (lable) элемента. Какая конструкция учитывает этот критерий? В http://wdq.wmflabs.org/api_documentation.html ничего подходящего не увидел. [08:47:08] (03PS2) 10Aude: Don't use SkinBuildSidebar hook for other projects feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) [08:47:39] (03CR) 10Aude: Don't use SkinBuildSidebar hook for other projects feature (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [08:56:57] (03CR) 10Daniel Kinzler: [C: 031] "looks sensible, especially since it gets rid of the nasty unset( $sidebar['wikibase-otherprojects'] ) hack. Didn't try though, and I don't" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [09:00:58] (03CR) 10Daniel Kinzler: [C: 032] Drop unused EntityRevisionSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [09:10:23] (03PS1) 10Thiemo Mättig (WMDE): SetSiteLinkTest finally compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157653 [09:10:52] (03CR) 10Daniel Kinzler: [C: 04-1] "I would like this to be a little more generic. IF there are good reasons not to go that way, let me know." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [09:13:36] (03CR) 10Daniel Kinzler: [C: 04-1] "no tests for EntityParserOutput?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene) [09:15:50] (03Merged) 10jenkins-bot: Drop unused EntityRevisionSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [09:27:53] DanielK_WMDE: are you joining the hangouts for the daily? [09:30:49] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1630fc2 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34085066 [09:37:18] (03PS1) 10Thiemo Mättig (WMDE): Move DataModelSerializationRoundtripTest to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157654 [09:39:17] (03PS1) 10Thiemo Mättig (WMDE): Make WikibaseLuaEntityBindingsTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157655 [09:41:30] Tobi_WMDE_SWE: could do ;) [09:41:50] DanielK_WMDE: want to? [09:41:54] :) [09:47:30] Tobi_WMDE_SWE: waiting... [10:00:09] (03CR) 10Henning Snater: [V: 032] "All except one Selenium tests pass." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157648 (owner: 10Henning Snater) [10:00:29] (03PS1) 10WikidataBuilder: New Wikidata Build - 01/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157656 [10:14:53] Jhs: ^(Ok, now)$ [10:15:24] Jhs: oh you can ommit the group, you don't need to "capture" this string: ^Ok, now$ [10:16:02] Dereckson, thanks, i just got the same answer from #pywikibot :o) [10:16:06] so you're probably right :D [10:18:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157656 (owner: 10WikidataBuilder) [10:18:59] (03PS1) 10Henning Snater: Show entity id when label is empty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157657 [10:20:44] (03PS10) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [10:21:02] (03PS9) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [10:21:07] (03PS8) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [10:21:12] (03PS7) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [10:21:16] (03PS5) 10Henning Snater: Eliminated PersistentPromisor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 [10:21:27] (03PS5) 10Henning Snater: Removed wikibase.utilities.jQuery [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 [10:21:32] (03PS6) 10Henning Snater: Refactored ResourceLoader QUnit test modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 [10:21:36] (03PS5) 10Henning Snater: Untangled $.wikibase.snakview ResourceLoader modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 [10:24:47] (03PS10) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [10:27:32] (03CR) 10Bene: "So you mean not baked to StringValues? Then we'll have to have two more classes. We could also decide to return DataValue objects instead " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [10:31:21] (03CR) 10Bene: [C: 04-1] "Per Jeroen this needs to be split into ClaimsParserOutput and SitelinksParserOutput etc. Also instead of inheritance the classes should as" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene) [10:32:44] (03PS7) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [10:34:12] (03PS3) 10Henning Snater: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 [10:34:20] (03PS3) 10Henning Snater: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 [10:37:12] (03CR) 10Daniel Kinzler: "sorry, my comments got stuck on an old patchset." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [10:39:14] (03PS3) 10Henning Snater: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 [10:39:28] (03PS8) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [10:39:33] (03PS2) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [10:41:08] (03CR) 10Daniel Kinzler: "@bene: I mean, make a ValueFinder that finds DataValues for a given DataType. The DataType dictates the interpretation of the DataValues, " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [10:41:46] benestar|cloud: --^ ...and see me comments to patchset 5. sorry for commenting on the old version. [10:44:41] [13WikibaseDataModel] 15thiemowmde created 06isempty (+1 new commit): 02http://git.io/1Z8rEw [10:44:41] 13WikibaseDataModel/06isempty 144144ae0 15Thiemo Mättig: Add StatementList::isEmpty [10:45:16] (03CR) 10Tobias Gritschacher: [C: 032] Have AbstractedRepoApi inherit from RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157648 (owner: 10Henning Snater) [10:45:30] (03CR) 10Tobias Gritschacher: [C: 032] Show entity id when label is empty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157657 (owner: 10Henning Snater) [10:46:26] [13WikibaseDataModel] 15thiemowmde opened pull request #176: Add StatementList::isEmpty (06master...06isempty) 02http://git.io/Q5LajA [10:47:07] [travis-ci] wmde/WikibaseDataModel/isempty/4144ae0 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34090464 [10:49:31] [13WikibaseDataModel] 15thiemowmde created 06equaltests (+1 new commit): 02http://git.io/a4q93g [10:49:31] 13WikibaseDataModel/06equaltests 148db21f7 15Thiemo Mättig: Data providers for Item::equals tests [10:50:37] [13WikibaseDataModel] 15thiemowmde opened pull request #177: Data providers for Item::equals tests (06master...06equaltests) 02http://git.io/xMBbwg [10:51:46] (03PS8) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [10:52:10] [travis-ci] wmde/WikibaseDataModel/equaltests/8db21f7 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/34090834 [10:56:00] (03PS11) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [10:57:07] (03PS10) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [10:57:12] (03PS9) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [10:57:17] (03PS8) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [10:57:21] (03PS6) 10Henning Snater: Eliminated PersistentPromisor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 [10:57:26] (03PS6) 10Henning Snater: Removed wikibase.utilities.jQuery [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 [10:57:30] (03PS7) 10Henning Snater: Refactored ResourceLoader QUnit test modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 [10:57:35] (03PS6) 10Henning Snater: Untangled $.wikibase.snakview ResourceLoader modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 [10:57:39] (03PS11) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [10:57:44] (03PS9) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [11:07:45] Tobi_WMDE_SWE: I'm not seeing a calendar entry for the EAGLE folks [11:09:34] (03CR) 10Lucie Kaffee: Add ApiConventionsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:11:35] (03CR) 10Daniel Kinzler: Add ApiConventionsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:18:12] DanielK_WMDE: did not send out invites yet [11:18:15] (03CR) 10Addshore: Add ApiConventionsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:22:36] DanielK_WMDE: now [11:23:43] (03CR) 10jenkins-bot: [V: 04-1] Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [11:26:13] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 01/09/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157656 (owner: 10WikidataBuilder) [11:27:21] (03Merged) 10jenkins-bot: Have AbstractedRepoApi inherit from RepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157648 (owner: 10Henning Snater) [11:27:23] (03Merged) 10jenkins-bot: Show entity id when label is empty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157657 (owner: 10Henning Snater) [11:30:36] (03CR) 10Tobias Gritschacher: Add ApiConventionsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:34:16] (03CR) 10Addshore: Add ApiConventionsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:43:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ea79079 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34093251 [12:01:36] (03CR) 10Henning Snater: [V: 032] "All QUnit and Selenium tests pass." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [12:01:52] (03PS4) 10Henning Snater: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 [12:01:58] (03PS4) 10Henning Snater: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 [12:06:14] (03PS4) 10Henning Snater: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 [12:06:23] (03PS9) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [12:06:28] (03PS3) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [12:08:40] (03PS5) 10Daniel Kinzler: Refactor SpecialMergeItems [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 [12:09:43] (03PS6) 10Daniel Kinzler: Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 [12:12:11] :> [12:13:32] :D [12:13:37] (03PS4) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [12:14:19] (03CR) 10Addshore: [C: 031] "Looks good, need to test it" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [12:14:49] addshore: will a checkbox for redirects be added someday? :)) [12:14:59] Vogone: why dont you add it? ;p [12:15:11] holiday! [12:15:52] hehe, Henning_WMDE trying to overload jenkins agian, It will not work! mwahahaha! [12:21:06] addshore: we will just create a clone of Henning_WMDE for each job runner you add [12:21:14] :< [12:21:45] Blame the other guys for reviewing too slow. ;) [12:22:15] Henning_WMDE: you are right. It's actually addshores fault [12:22:21] addshore: you hypocritical bastard [12:22:46] :D Still, to this day I have probably reviewed less than 100 lines of JS code for Wikibase :P [12:41:26] (03PS12) 10Tobias Gritschacher: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 (owner: 10Henning Snater) [12:46:03] (03CR) 10Tobias Gritschacher: [C: 032] Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 (owner: 10Henning Snater) [12:46:12] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06isempty from 144144ae0 to 14809cb94: 02http://git.io/futppw [12:46:12] 13WikibaseDataModel/06isempty 14809cb94 15Thiemo Mättig: Add StatementList::isEmpty [12:46:12] (03PS11) 10Tobias Gritschacher: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [12:48:33] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/QI4ZWA [12:48:33] 13WikibaseDataModel/06master 1400739e4 15Jeroen De Dauw: Merge pull request #176 from wmde/isempty... [12:48:49] Thiemo_WMDE: you can now also update the isEmpty method in Item [12:49:08] [travis-ci] wmde/WikibaseDataModel/isempty/809cb94 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/34098640 [12:49:24] (03CR) 10Jeroen De Dauw: [C: 032] Make WikibaseLuaEntityBindingsTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157655 (owner: 10Thiemo Mättig (WMDE)) [12:49:33] (03CR) 10Jeroen De Dauw: [V: 032] Make WikibaseLuaEntityBindingsTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157655 (owner: 10Thiemo Mättig (WMDE)) [12:50:18] (03CR) 10Jeroen De Dauw: [V: 032] Move DataModelSerializationRoundtripTest to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157654 (owner: 10Thiemo Mättig (WMDE)) [12:50:27] fail [12:50:31] (03CR) 10Jeroen De Dauw: [C: 032] Move DataModelSerializationRoundtripTest to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157654 (owner: 10Thiemo Mättig (WMDE)) [12:51:03] Thiemo_WMDE: got flattened to an array? :D [12:51:44] (03CR) 10Jeroen De Dauw: SetSiteLinkTest finally compatible with DataModel 1.0 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157653 (owner: 10Thiemo Mättig (WMDE)) [12:51:56] that flatten method is scary. [12:52:01] Thiemo_WMDE: can you fix this in that commit already? https://gerrit.wikimedia.org/r/#/c/157653/ [12:52:23] Thiemo_WMDE: indeed. Reminds me of the ObjectComparer thing which we had in DataModel [12:52:29] One of the evil things killed by 1.0 [12:52:31] yea, i was already thinking about this. will try. [12:53:00] (03CR) 10Jeroen De Dauw: [C: 032] Make SnaksFinderTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157647 (owner: 10Thiemo Mättig (WMDE)) [12:53:26] (03CR) 10Jeroen De Dauw: [C: 032] Make TestChanges compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157646 (owner: 10Thiemo Mättig (WMDE)) [12:54:28] Thiemo_WMDE: is this still a thing? https://gerrit.wikimedia.org/r/#/c/156528/ [12:54:32] (03PS5) 10Jeroen De Dauw: Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [12:56:14] ohnoez! [12:56:16] http://wikiba.se/components/ [12:56:18] failing build [12:56:20] panic [12:56:41] Where is addshore when I want to rage to him? :( [12:56:57] huhwat [13:04:29] Thiemo_WMDE: I'm fixing a compat issue in DataModel Serialization [13:06:52] (03Merged) 10jenkins-bot: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 (owner: 10Henning Snater) [13:09:54] (03PS2) 10Thiemo Mättig (WMDE): SetSiteLinkTest finally compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157653 [13:11:04] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b2e9ebd : Jeroen De Dauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34098899 [13:11:33] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06dm10 (+1 new commit): 02http://git.io/3fIOAQ [13:11:33] 13WikibaseDataModelSerialization/06dm10 149eec4b6 15jeroendedauw: Restore compat with DM 1.x [13:12:03] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04force-pushed 06dm10 from 149eec4b6 to 14beea3ed: 02http://git.io/nwEXWQ [13:12:03] 13WikibaseDataModelSerialization/06dm10 14beea3ed 15jeroendedauw: Restore compat with DM 1.x [13:12:08] [travis-ci] wmde/WikibaseDataModelSerialization/dm10/9eec4b6 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/34100726 [13:12:09] (03CR) 10Tobias Gritschacher: [C: 032] Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [13:13:49] (03PS10) 10Tobias Gritschacher: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [13:14:28] [13Wikiba.se] 15jakob-WMDE pushed 1 new commit to 06master: 02http://git.io/AjlF_Q [13:14:28] 13Wikiba.se/06master 14f75a0d7 15Jakob Warkotsch: Fix some styling issues on the main page. [13:15:58] [travis-ci] wmde/WikibaseDataModelSerialization/dm10/beea3ed : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/34100755 [13:19:21] * hoo waves [13:19:38] welcome back [13:19:42] * aude assumes you are back [13:20:31] (03CR) 10jenkins-bot: [V: 04-1] Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [13:20:53] aude: Nope, nope, nope :P [13:20:59] ah :) [13:21:19] Am in Jersey City now (to see NYC) [13:21:36] \o/ [13:21:41] Been to Georgetown Cupcake, btw [13:21:45] mmmmmm [13:21:50] It was nice... and my sister loved it [13:21:52] * aude wants cupcakes! [13:22:11] Do they also have a store in New York? [13:22:15] they do [13:22:19] Ah, I see [13:22:40] I was quite "What is google maps doing" when that was the first store I saw in Manhattan :P [13:22:50] heh [13:23:03] (03PS6) 10Thiemo Mättig (WMDE): Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 [13:24:05] aude: Do you have any secret (or less secret) tips on what to visit over here? [13:24:10] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModelSerialization/pull/76/files [13:24:32] i always get tacos, although they are not that special compared to the ones in SF [13:25:06] (03PS5) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [13:25:14] (03CR) 10jenkins-bot: [V: 04-1] Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [13:25:31] (03CR) 10Henning Snater: [V: 032] "All Selenium and QUnit tests pass." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 (owner: 10Henning Snater) [13:26:53] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #178: moved the diff test to new test folder (06master...06move) 02http://git.io/MRCwfw [13:27:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c736c72 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34098949 [13:29:34] [13WikibaseDataModelSerialization] 15thiemowmde 04deleted 06dm10 at 14beea3ed: 02http://git.io/slZZwA [13:30:44] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/pCt8xQ [13:30:44] 13WikibaseDataModel/06master 142882dd1 15thiemowmde: Merge pull request #178 from wmde/move... [13:32:29] [travis-ci] wmde/WikibaseDataModelSerialization/master/1824832 : thiemowmde The build was fixed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/34102026 [13:34:29] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/932239c : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34099131 [13:35:12] Thiemo_WMDE: oh dear [13:35:19] Writing a long comment of rage? :D [13:36:04] (03PS7) 10Daniel Kinzler: Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 [13:40:43] jakob_WMDE: There is only one item filed for the site that has any urgency, which is https://github.com/wmde/Wikiba.se/issues/13 [13:41:06] jakob_WMDE: not sure you can figure out on your own what should be listed there though [13:41:39] Lydia_WMDE: where are you hiding? [13:43:00] JeroenDeDauw: did you rage to the Lydia_WMDE yet? :P [13:43:17] aude: no, that's why I wonder where she is? [13:43:20] ah [13:43:25] err, no questionmark! [13:43:50] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/K-6HbQ [13:43:50] 13Wikiba.se/06master 149070e05 15Jeroen De Dauw: Update components.html [13:48:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d2ce4a1 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34099421 [13:50:20] jakob_WMDE: site updated :) [13:53:37] (03PS3) 10Jeroen De Dauw: SetSiteLinkTest finally compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157653 (owner: 10Thiemo Mättig (WMDE)) [13:53:50] (03CR) 10Jeroen De Dauw: [C: 032] SetSiteLinkTest finally compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157653 (owner: 10Thiemo Mättig (WMDE)) [13:59:37] (03CR) 10Jeroen De Dauw: [C: 032] Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:01:56] (03CR) 10Jeroen De Dauw: [C: 04-1] "The test needs to improve" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [14:06:19] (03CR) 10Daniel Kinzler: "@jeroen: can you be more specific?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [14:06:27] (03CR) 10Jeroen De Dauw: Refactor SpecialMergeItems (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [14:06:59] (03Merged) 10jenkins-bot: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [14:07:08] DanielK_WMDE: if you don't know what to do, just try splitting the methods [14:07:15] That will already help a lot [14:07:39] JeroenDeDauw: i read before you saved your comments. ok. [14:08:48] JeroenDeDauw: this is a mix of adjusted older tests and tests copied and modified from the api module... i don't know either what $pre1 and $pre2 stand for :) [14:08:50] Tobi_WMDE_SWE: can we close this? https://gerrit.wikimedia.org/r/#/c/89102/ [14:09:10] DanielK_WMDE: >_> [14:09:47] DanielK_WMDE: if you don't understand the code, then perhaps it's not a good idea to copy it :) [14:09:47] (03Merged) 10jenkins-bot: SetSiteLinkTest finally compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157653 (owner: 10Thiemo Mättig (WMDE)) [14:11:06] JeroenDeDauw: oh, i know what it does, but i just left the parameter names. i left that in a half finished state a few weeks back, and finished it today. missed a few rough spots, i guess. [14:11:28] (03Merged) 10jenkins-bot: Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:14:47] (03PS4) 10Tobias Gritschacher: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw) [14:17:40] is it possible to remove statements using Quick Statements ? [14:20:59] JeroenDeDauw: i'm not sure what to do about https://github.com/wmde/Wikiba.se/issues/13 but if you give me a list of wikibase client features i can add them there :P [14:24:41] (03CR) 10jenkins-bot: [V: 04-1] [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw) [14:25:44] (03PS11) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [14:37:14] * hoo waves good bye [14:38:29] It was a hoo [14:38:34] later! [14:38:51] (03PS13) 10Tobias Gritschacher: Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [14:39:23] :) [14:39:40] Tobi_WMDE_SWE: whats the name of the new person again? [14:39:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/42b72f0 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34100458 [14:39:46] (new one, not the newer one) [14:40:27] JeroenDeDauw: CFisch_WMDE [14:40:37] Christoph Fischer [14:41:04] evil nickname change again! [14:45:13] JeroenDeDauw: question re "not putting stuff in lib": for usage tracking, i once more need to write a service interface that abstracts a table shared between repo and client. I could make a new component for this, but what, except for that service (an interface, an implementation, a test, maybe an exception) would go in there? This seems too fine grained. [14:45:34] So, perhaps split off some kind of "shared storage" component, and put storage layer stuff shared between client and repo there? [14:46:04] (in any case, i'd go for a new directory in the Wikibase repository at first, not immediately a separate git repo) [14:46:49] This is a bit simmilar to the change notification stuff. [14:47:11] (03CR) 10jenkins-bot: [V: 04-1] Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [14:47:17] in both cases there is quite a bit of client only code (for change handling and usage tracking), which i would't want to have on the repo... [14:49:23] (03PS14) 10Tobias Gritschacher: Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [14:49:40] DanielK_WMDE: having an "all of the storage" component is bad [14:50:37] DanielK_WMDE: the new json dumps use the old lib serialization code?? [14:50:41] JeroenDeDauw: it's not *all* of the storage. it's the storage level communication interface between repo and client. [14:51:28] (03PS1) 10Thiemo Mättig (WMDE): Make ItemSerializerTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157683 [14:51:29] JeroenDeDauw: JSON dumps were implemented long before the new serialization code existed (jkust took forever to deploy). so, yes, if nobody changed that, they use the old code. [14:51:30] "storage level communication interface between repo and client" mhhh [14:51:46] JeroenDeDauw: well, change notifications, usage tracking (aka change subscriptions) [14:52:00] DanielK_WMDE: ok, then I wonder about MArkus his email - why does the issue occur there and not in the API? [14:52:15] JeroenDeDauw: we also use shared access to entity_per_page, and to item_per_site [14:52:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/654f295 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34104490 [14:53:17] [13ValueView] 15snaterlicious created 06eachchange (+1 new commit): 02http://git.io/Kgg2ug [14:53:17] 13ValueView/06eachchange 14eb17eeb 15snaterlicious: Cancel event after it got removed [14:53:24] JeroenDeDauw: tbh, i'm not positive about the json dumps. they might just use $content->serialize() - which would use whatever is used internally, i guess. [14:53:26] (03PS2) 10Thiemo Mättig (WMDE): Make ItemSerializerTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157683 [14:54:10] JeroenDeDauw: nope. uses old Wikibase\Lib\Serializers. i just checked. [14:54:55] JeroenDeDauw: about the "storage level interface": we can slice and dice it until it's all chopped up, then the responsibilities are clear - but we have an unmanageable depedency hell [14:55:09] i'm looking for a sane split into manageable chunks [14:55:27] DanielK_WMDE: change notification and usage tracking are two different things [14:55:36] [13ValueView] 15snaterlicious 04force-pushed 06eachchange from 14eb17eeb to 14e8c34c8: 02http://git.io/gPrfWQ [14:55:36] 13ValueView/06eachchange 141a2ac83 15aude: Update README for 0.6.10 release [14:55:36] 13ValueView/06eachchange 14e8c34c8 15snaterlicious: Cancel event after it got removed [14:55:39] actually, they arn't. [14:55:49] the usage tracking is basically a subscription for change events [14:56:00] the two are tied together (but separate from the client side local usage tracking) [14:57:08] JeroenDeDauw: without usage tracking (subscriptions), we cannot send change notifications. our current subscription system is solely based on sitelinks. i'm about to change that [14:57:41] but for that, the client has to be able to, well, subscribe. it needs to have an implementation of the subscription interface that is based on the database tables used by the repo [14:57:59] That's all very specific to the exact use case we have at the moment [14:58:16] [13ValueView] 15snaterlicious opened pull request #110: Fixed eachchange event (06master...06eachchange) 02http://git.io/fTdCsA [14:59:40] DanielK_WMDE: parts of this system will be usefull in other contexts, so I want to avoid suffering from inseperability here [15:00:32] DanielK_WMDE: do you have an idea of why the API and the JSON dumps are returning different JSON then? [15:01:09] serialization options? [15:01:29] (03CR) 10Jeroen De Dauw: [C: 032] Make ItemSerializerTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157683 (owner: 10Thiemo Mättig (WMDE)) [15:01:49] aude: maybe. Which ones? I looked at the object and did not see something obvious [15:01:55] no clue [15:02:09] JeroenDeDauw: my guess is that the API does some magic before the actual json encoding. that'S controlled by core, i never looked at that code. [15:02:14] coudl also be options, yea. [15:02:24] JeroenDeDauw: i replied to Markus [15:02:35] i doubt magic in this case [15:02:37] DanielK_WMDE: kthnx [15:02:40] (03PS9) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [15:02:44] (03PS7) 10Henning Snater: Eliminated PersistentPromisor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 [15:02:48] I checked the new code, and it looks to also be doing this wrong [15:02:52] Tpt_: ^ [15:02:59] (03PS7) 10Henning Snater: Removed wikibase.utilities.jQuery [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 [15:03:04] (03PS8) 10Henning Snater: Refactored ResourceLoader QUnit test modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 [15:03:08] (03PS7) 10Henning Snater: Untangled $.wikibase.snakview ResourceLoader modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 [15:03:10] JeroenDeDauw: i don't see how we could separate change notifications from subscriptions. and if we do, how we would not end up with 10 new components just to model the storage level stuff shared between repo and client [15:03:22] more, probably, if we go for that level of granularity [15:05:07] (03PS12) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [15:05:16] (03PS10) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [15:05:21] (03PS5) 10Henning Snater: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 [15:05:26] (03PS5) 10Henning Snater: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 [15:05:30] (03PS5) 10Henning Snater: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 [15:05:34] (03PS10) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [15:05:39] (03PS6) 10Henning Snater: Implemented sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156784 [15:07:55] DanielK_WMDE: I cannot give you detailed input on how to exactly do this without looking into the code and what it does exactly first [15:08:40] (03CR) 10jenkins-bot: [V: 04-1] Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [15:09:00] DanielK_WMDE: in any case, examples of how one can split storage stuff: EntityStore, TermStore, QueryEngine [15:10:51] JeroenDeDauw: essentially, one component per table? actually, two. one for reading, and one that adds write functionality. [15:11:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/6417b0a : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34104630 [15:11:20] JeroenDeDauw: there's no code to look at for usage tracking. i'm starting to write that. and i'm asking myself where to put it. [15:11:40] DanielK_WMDE: Not sure why you'd split read and write [15:11:47] DanielK_WMDE: and no, not one component per table [15:12:12] in many cases, the client does not need, and should not have (to know about) the writing logic. [15:12:31] DanielK_WMDE: look at the package principles. I do not care there is a table to begin with, this is not how you figure out how to make cohesive packages [15:13:17] DanielK_WMDE: fair enough, then client will probably want to have a different interface [15:13:27] Which does not mean you have 2 components per table [15:14:10] not necessarily, but it can easily end up that way. [15:14:14] my problem is that applying that principle blindly leads to a lot more components than i want to be dealing with. [15:14:41] i was hoping for a good idea what to bundle together to avoid that kind of fragementation. [15:17:45] (03Merged) 10jenkins-bot: Make ItemSerializerTest compatible to DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157683 (owner: 10Thiemo Mättig (WMDE)) [15:21:19] (03PS8) 10Daniel Kinzler: Refactor SpecialMergeItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 [15:21:25] JeroenDeDauw: --^ [15:21:49] [13ValueView] 15tobijat 04deleted 06eachchange at 14e8c34c8: 02http://git.io/XzjYNg [15:22:14] DanielK_WMDE: well, I've said that you're doing if wrong if you throw it all together and I've said that you're doing it wrong if you end up with two components per table [15:22:36] And I've said that to provide a proposal on how to split this, I'd need to look at the code to make an informed decision [15:23:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2a4766b : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34104751 [15:23:50] DanielK_WMDE: I cannot do this now. We can talk about this tomorrow [15:24:07] (03PS5) 10Tobias Gritschacher: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw) [15:26:14] ok. have to go soon, too [15:37:47] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/da450bd : Thiemo Mättig The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34110168 [15:47:14] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/LtLTfQ [15:47:14] 13DataValuesJavascript/06master 14b29bca9 15Tobi Gritschacher: Update README.md [15:47:44] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/CKNHpw [15:47:44] 13DataValuesJavascript/06master 140006a69 15Tobi Gritschacher: Update DataValuesJavascript.php [15:48:06] [13DataValuesJavascript] 15tobijat tagged 060.6.0 at 06master: 02http://git.io/_wZiZQ [15:51:07] [13DataValuesJavascript] 15jakob-WMDE created 06test-for-calendar-issue (+1 new commit): 02https://github.com/wmde/DataValuesJavascript/commit/1ce1ead39ce4 [15:51:07] 13DataValuesJavascript/06test-for-calendar-issue 141ce1ead 15Jakob Warkotsch: Add test for time.Time.equals() with different calendar models. [15:53:27] [travis-ci] wmde/DataValuesJavascript/test-for-calendar-issue/1ce1ead : Jakob Warkotsch The build failed. http://travis-ci.org/wmde/DataValuesJavascript/builds/34112828 [15:55:46] [13DataValuesJavascript] 15jakob-WMDE opened pull request #48: Add test for time.Time.equals() with different calendar models. (06master...06test-for-calendar-issue) 02http://git.io/l55LKA [16:10:04] [13ValueView] 15tobijat pushed 2 new commits to 06fix-calendar-switch: 02http://git.io/Tpj4NA [16:10:04] 13ValueView/06fix-calendar-switch 1443cd8e5 15Tobias Gritschacher: Merge branch 'master' into fix-calendar-switch [16:10:04] 13ValueView/06fix-calendar-switch 142a15346 15Tobias Gritschacher: Use version 0.6.0 of DataValuesJavascript [16:10:15] aude: https://github.com/wmde/ValueView/pull/109 [16:10:59] Henning_WMDE ^^ [16:14:22] (03PS1) 10Tobias Gritschacher: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 [16:14:36] aude: Henning_WMDE: ^^ [16:15:55] (03PS2) 10Tobias Gritschacher: Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) [16:16:03] Tobi_WMDE_SWE: looks good although prefer henning approve [16:17:37] Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/156679/1/RELEASE-NOTES-1.24 [16:17:44] so sounds like they can still use txt [16:17:56] but it will go away at some point [16:19:29] [13WikibaseDataModelSerialization] 15thiemowmde created 06undesertest (+1 new commit): 02http://git.io/Dgqb9w [16:19:29] 13WikibaseDataModelSerialization/06undesertest 14c258e3b 15Thiemo Mättig: Add tests for UnDeserializableValue [16:19:34] (03CR) 10jenkins-bot: [V: 04-1] Use new versions of DataValuesJavascript and ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157689 (https://bugzilla.wikimedia.org/65847) (owner: 10Tobias Gritschacher) [16:20:27] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #78: Add tests for UnDeserializableValue (06master...06undesertest) 02http://git.io/97oDgg [16:21:48] (03CR) 10Bene: [C: 04-1] Refactor SpecialMergeItems (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152148 (owner: 10Daniel Kinzler) [16:22:52] [travis-ci] wmde/WikibaseDataModelSerialization/undesertest/c258e3b : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/34114862 [16:42:47] (03PS1) 10Thiemo Mättig (WMDE): Remove bogus test from DataModelSerializationRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157693 [16:52:20] (03PS4) 10Thiemo Mättig (WMDE): Make ChangeNotifier an interface and introduce NullChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 [16:57:40] (03CR) 10jenkins-bot: [V: 04-1] Make ChangeNotifier an interface and introduce NullChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141666 (owner: 10Thiemo Mättig (WMDE)) [17:00:47] (03PS9) 10Thiemo Mättig (WMDE): Reduce loading spinner toggle to a single 'loading' CSS class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 [18:07:29] (03PS6) 10Jeroen De Dauw: Use DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 [18:13:24] JeroenDeDauw: I clarified my thoughts a bit and also created https://bugzilla.wikimedia.org/show_bug.cgi?id=70264 which is unrelated to the issue raised there [18:27:15] (03CR) 10Bene: [C: 031] "The code looks good to me and makes sense but either someone was a bit crazy when they created this piece of code or they had a reason why" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157500 (https://bugzilla.wikimedia.org/70234) (owner: 10Aude) [18:33:18] (03CR) 10Bene: "@daniel: well, the ReferencedEntitiesFinder does not work after that principle because it does not check the Property data type but the da" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [18:39:35] benestar: :D [18:39:44] benestar: poor Item class, what has it ever done to you? [18:40:14] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/BJB0LA [18:40:14] 13WikibaseDataModelSerialization/06master 14421a86e 15Jeroen De Dauw: Merge pull request #78 from wmde/undesertest... [18:40:34] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/cGcZ6g [18:40:34] 13WikibaseDataModelSerialization/06master 14fa84adb 15Jeroen De Dauw: Update composer.json [18:56:11] Lydia_WMDE: heh :P "I have large doubts about this." [19:01:24] how is an edit like this: https://www.wikidata.org/w/index.php?diff=155021037 suddenly )+13.550 bytes) [19:01:58] FakirNL: see https://www.wikidata.org/wiki/Wikidata:Project_chat#Huge_diff_size [19:02:23] the answer is few clicks away [19:02:32] new internal serialization. It is a bit more verbose [19:02:41] ah [19:05:18] Yeah, those byte counts were intended for use with content models where you edit the internal format directly, I think [19:09:52] I just use the regular editor [19:23:06] Lydia_WMDE: large doubts about what? [19:23:22] addshore: Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/157075/ [19:23:32] !r 157075 [19:23:33] https://gerrit.wikimedia.org/r/#/c/157075/ [19:23:35] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=70264 [19:23:38] !m 157075 [19:23:38] merge merge merge MERGEEEEEEEEEEEEE [19:23:45] !merge 157075 [19:23:45] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/157075/ [19:23:49] ah [19:24:16] wth? [19:24:30] what did you teached this bot? [19:24:52] lol [19:24:55] all the bad stuff apparently ;-) [19:25:41] * Lydia_WMDE goes back to silly tv series [19:25:53] uh. i'm responsible for half the datamodel 1.0 stuff. i think i don#t want to be responsible for whatever that merge will cause. ;))) [19:26:12] !badstuff is "'bad stuff', also known as 'Lydia_WMDE'" [19:26:12] Key was added [19:26:14] * JeroenDeDauw hides [19:26:18] !badstuff [19:26:18] "'bad stuff', also known as 'Lydia_WMDE'" [19:26:22] fail [19:26:30] !del badstuff [19:26:36] * Lydia_WMDE pets wm-bot3 [19:26:37] !badstuff del [19:26:38] Successfully removed badstuff [19:27:11] Thiemo_WMDE: you know what is going on, and you did nothing of the stuff in that commit [19:27:15] haha, i'm sitting in the middle of a room full of people talking about digital natives. nobody is looking at his phone. [19:27:24] So you are the ideal person to merge [19:27:49] i did most of the stuff that made this comit succeed. ;) [19:27:53] Thiemo_WMDE: digital natives can merge and watch a talk at the same time [19:27:58] Thiemo_WMDE: so? [19:28:11] poke me tomorrow please, will not merge more stuff today. [19:28:38] addshore: you want to recieve the "officially better than Thiemo_WMDE" badge! [19:29:01] * Thiemo_WMDE food, shower, youtube, sleep. gn8. [19:32:44] hey Thiemo_WMDE :D [19:33:00] did you read my comment on the Kill Item bug? [20:40:02] benestar|cloud: oh dear [20:40:14] benestar|cloud: I'll reply tomorrow, when I'm awake again [20:41:26] !merge 157075 | benestar|cloud [20:41:26] benestar|cloud: merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/157075/ [21:19:30] (03CR) 10Bene: [C: 031] "Looks good, though we might deprecated some of the classes which become obsolete by this change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw) [21:35:08] Do we have a standard for how to treat bus routes? [21:42:59] Are bus routes notable by Wikidata standards? the DC area has at least a hundred bus routes [21:43:20] They're certainly the subject of Wikitravel articles from time to time. [21:43:30] London has ~ 500 I'd guess. [21:43:38] The world is large. [21:44:34] Everything is notable. :) [21:44:47] Well, not "everything", but close. [21:45:18] https://tools.wmflabs.org/reasonator/?q=Q3240003 [21:45:27] Hm, we have a lot Dutch ones. :/ [21:46:11] We have a lot of dutch everything. :-) [21:47:01] Let's take a look at the properties. [21:47:34] Speaking of dutch things, https://www.wikidata.org/w/index.php?title=User:Pasleim/projectmerge/enwiki-nlwiki&diff=155101290&oldid=155026942 :( [21:47:48] Oh dear. [21:49:10] James_F: https://www.wikidata.org/wiki/Property:P137 is a handy one. [21:49:23] Huh. [21:49:37] But too much work for me doing a drive-by fix as part of deletion work. :-) [21:51:42] lazy James_F [21:51:44] LAZY [21:51:50] That's me. :-) [21:53:06] I'm not lazy! :O [21:53:34] sjoerddebruin: Then you are welcome to create the 480 remaining London bus route items and link them up. :-) [21:54:27] No experience with that. :( [21:54:40] No worries. [21:54:45] Eventually someone will. [21:58:05] I remember a few months ago the deletion queue was just nuts. It would often reach 400 open [21:58:08] what happened to that? [21:58:18] Redirects. [22:01:53] But there is enough to delete. [22:01:54] https://www.wikidata.org/wiki/Special:ShortPages [22:02:02] Uncompleted merges. [22:14:57] sjoerddebruin, huh, 427448 pages with page_len < 200 [22:23:56] Yes. [22:24:42] nn [22:35:59] So all merges use redirects now, deletion is reserved for other things? [22:43:22] Krenair: I wouldn't say all, it kind of depends on the admin [22:44:52] Krenair: but this will change after the community decided some tiny things, I guess [22:45:23] so that indeed redirects will be the option to use in case of all merges [22:48:17] Vogone, also I broke it: https://www.wikidata.org/w/index.php?title=Q3434419&action=history [22:49:02] I wonder if that is merge.js actually [22:54:01] :/ [22:54:32] anyway, this default edit summary should finally be fixed [22:54:54] probably it was already but not deployed yet, dunno