[04:27:44] <hoo>	 aude: Around? :)
[08:22:16] <lazowik>	 hi :)
[10:00:34] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 30/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157343 
[10:02:25] <BAR_>	 !admin
[10:02:37] <Stryn>	 BAR_: yes?
[10:02:39] <Ash_Crow>	 Bar_ ?
[10:02:50] <Stryn>	 ok
[10:02:53] <Ash_Crow>	 ...
[10:03:41] <Romaine>	 so easy can it be to solve an admin related request
[10:04:27] <sjoerddebruin>	 :)
[10:18:51] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157343 (owner: 10WikidataBuilder)
[10:32:55] <grrrit-wm>	 (03CR) 10Aude: [C: 032] New Wikidata Build - 30/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157343 (owner: 10WikidataBuilder)
[10:42:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: New Wikidata Build - 30/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157343 (owner: 10WikidataBuilder)
[10:55:59] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Use instanceof self [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157344 
[11:03:43] <gh-datavalues>	 [13Number] 15thiemowmde created 06equals (+1 new commit): 02http://git.io/7b2NsA
[11:03:43] <gh-datavalues>	 13Number/06equals 1492044b7 15Thiemo Mättig: Use instanceof self if possible
[11:04:28] <gh-datavalues>	 [13Number] 15thiemowmde opened pull request #10: Use instanceof self if possible (06master...06equals) 02http://git.io/1vPXmg
[11:11:40] <gh-datavalues>	 [13DataValues] 15thiemowmde created 06self (+1 new commit): 02http://git.io/yXE0aw
[11:11:40] <gh-datavalues>	 13DataValues/06self 148778989 15Thiemo Mättig: Use instanceof self if possible
[11:11:58] <gh-datavalues>	 [13DataValues] 15thiemowmde opened pull request #11: Use instanceof self if possible (06master...06self) 02http://git.io/PDK90A
[11:20:55] <gh-wmde>	 [13WikibaseDataModel] 15thiemowmde created 06self (+1 new commit): 02http://git.io/KdXutA
[11:20:55] <gh-wmde>	 13WikibaseDataModel/06self 14de730e4 15Thiemo Mättig: Use instanceof self if possible
[11:21:05] <gh-wmde>	 [13WikibaseDataModel] 15thiemowmde opened pull request #171: Use instanceof self if possible (06master...06self) 02http://git.io/g1KE0w
[11:24:58] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157343 (owner: 10WikidataBuilder)
[12:16:32] <grrrit-wm1>	 (03CR) 10Hashar: "This commit apparently broke the beta cluster: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/19416/console" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157343 (owner: 10WikidataBuilder)
[12:22:43] <gh-wmde>	 [13WikidataBuilder] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/sYHPyw
[12:22:43] <gh-wmde>	 13WikidataBuilder/06master 14fd11a7a 15Katie Filbert: fix extension include path for localisation update
[12:57:08] <grrrit-wm>	 (03PS1) 10Aude: New build, fix localisation update entry point [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157345 
[12:59:52] <grrrit-wm>	 (03CR) 10Aude: [C: 032] New build, fix localisation update entry point [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157345 (owner: 10Aude)
[13:13:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: New build, fix localisation update entry point [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157345 (owner: 10Aude)
[13:16:07] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157345 (owner: 10Aude)
[13:55:49] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157345 (owner: 10Aude)
[14:13:55] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw closed pull request #171: Use instanceof self if possible (06master...06self) 02http://git.io/g1KE0w
[14:14:43] <gh-datavalues>	 [13Number] 15JeroenDeDauw closed pull request #10: Use instanceof self if possible (06master...06equals) 02http://git.io/1vPXmg
[14:15:10] <gh-datavalues>	 [13DataValues] 15JeroenDeDauw 04deleted 06self at 148778989: 02http://git.io/AURJmw
[14:15:16] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 
[14:23:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 (owner: 10Jeroen De Dauw)
[14:46:38] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157346 
[14:48:16] <multichill>	 sjoerddebruin: What was the tool again to display Wikidata items on a map?
[14:48:31] <sjoerddebruin>	 Let me look, it's included in the reasonator
[14:48:40] <sjoerddebruin>	 let me take a look* :P
[14:49:31] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 
[14:49:31] <sjoerddebruin>	 https://tools.wmflabs.org/wikidata-todo/around.html
[14:49:51] <sjoerddebruin>	 It could use a "likje verf" imo. :)
[14:50:03] <grrrit-wm>	 (03PS2) 10Jeroen De Dauw: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157346 
[14:50:09] <sjoerddebruin>	 And it seems to be broken.
[14:51:34] <multichill>	 sjoerddebruin: Just noticed the same
[14:52:37] <sjoerddebruin>	 openlayers.org deleted some stuff, it seems
[14:53:56] <gh-datavalues>	 [13Time] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/HoB8YA
[14:53:56] <gh-datavalues>	 13Time/06master 145b64402 15Jeroen De Dauw: Update .scrutinizer.yml
[14:54:13] <multichill>	 sjoerddebruin: Wanted to include it in https://nl.wikipedia.org/wiki/Wikipedia:De_kroeg#Alle_Rijksmonumenten_op_Wikidata
[14:54:45] <sjoerddebruin>	 You can poke Magnus.
[15:03:14] <multichill>	 sjoerddebruin: Pff, 1296 Rijksmonumenten zonder coordinaten
[15:03:19] <sjoerddebruin>	 Dat zag ik.
[15:03:26] <sjoerddebruin>	 Ik ga https://nl.wikipedia.org/wiki/Categorie:Wikipedia:Rijksmonument_zonder_link_op_Wikidata doorwerken.
[15:05:44] <multichill>	 sjoerddebruin: Neem https://nl.wikipedia.org/wiki/Lijst_van_rijksmonumenten_in_Nieuwegein 30432 heeft geen coordinaten, raar...
[15:06:11] <sjoerddebruin>	 :/
[15:12:10] <sjoerddebruin>	 Kijk, het heeft nu al nut multichill! https://nl.wikipedia.org/w/index.php?title=Anna_Paulownahuis&diff=41980631&oldid=41400017
[15:14:53] <multichill>	 mooi, ook https://nl.wikipedia.org/w/index.php?title=Lijst_van_rijksmonumenten_in_Nieuwegein&diff=29732535&oldid=29717789 gevonden
[15:17:14] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw closed pull request #170: Make Statement test not derive from ClaimTest (06master...06statementtest) 02http://git.io/GIdaCw
[15:27:19] <sjoerddebruin>	 multichill: Deze is nog niet helemaal schoongemaakt. https://www.wikidata.org/w/index.php?title=Q17458453&diff=152585431&oldid=150456188
[15:27:44] <multichill>	 Oh right, die nbsp's
[15:27:51] <sjoerddebruin>	 Heerlijk hé. :)
[15:27:55] <sjoerddebruin>	 Ik ga hem nu mergen hoor
[15:28:02] <multichill>	 Zou mooi zijn als iemand een lijstje kan produceren met items met html meuk erin
[15:29:09] <sjoerddebruin>	 Oproepje in de project chat werkt meestal wel.
[16:07:05] <multichill>	 sjoerddebruin: Merged some more items at https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P359
[16:09:35] <sjoerddebruin>	 :)
[16:14:33] <multichill>	 The first ones are quite complicted. Saving them for last
[18:56:37] <JeroenDeDauw>	 !r 157347
[18:56:42] <JeroenDeDauw>	 !review 157347
[18:56:42] <wm-bot3>	 https://bit.ly/wdrieview
[18:57:05] <JeroenDeDauw>	 !r is https://gerrit.wikimedia.org/r/#/c/$1/
[18:57:05] <wm-bot3>	 Key was added
[18:57:29] <JeroenDeDauw>	 !r 157347 | aude 
[18:57:29] <wm-bot3>	 aude: https://gerrit.wikimedia.org/r/#/c/157347/
[18:57:32] <JeroenDeDauw>	 !r 157346 | aude 
[18:57:32] <wm-bot3>	 aude: https://gerrit.wikimedia.org/r/#/c/157346/
[19:16:58] <JeroenDeDauw>	 lazowik: I can haz review of two very simple commits?
[19:17:11] <lazowik>	 JeroenDeDauw: if you care for +1, sure
[19:18:00] <JeroenDeDauw>	 mhhhh
[19:18:30] <JeroenDeDauw>	 lazowik: then that probably will not speed up things
[19:21:07] <grrrit-wm>	 (03CR) 10Michał Łazowik: [C: 031] DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[19:21:47] <lazowik>	 oh, jenkins is smart enough to stop running tests when another PS is made
[19:21:49] <lazowik>	 nice
[19:25:00] <JeroenDeDauw>	 lazowik: perhaps you can re-submit the change, and then I can +2 it? Sounds legit to me.
[19:25:08] <lazowik>	 haha
[19:25:48] <JeroenDeDauw>	 lazowik: have you seen this awesomeness yet? http://wikiba.se/
[19:27:13] <lazowik>	 http://community.sephora.com/t5/image/serverpage/image-id/80285iB16C4FA60EBC0248?v=mpbl-1
[19:30:54] <gh-wmde>	 [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/YOuSGw
[19:30:54] <gh-wmde>	 13WikibaseInternalSerialization/06master 148be9507 15jeroendedauw: Update dev dependencies
[19:32:35] <JeroenDeDauw>	 lazowik: that not animooted! You noob! http://now-here-this.timeout.com/wp-content/uploads/2012/10/1269259657_omg_cat.gif
[19:32:55] * lazowik so n00b :(
[19:33:20] <lazowik>	 JeroenDeDauw: I can sort uses
[19:33:49] <lazowik>	 you put …\Claim\… after …\Snak\…
[19:33:57] <lazowik>	 was that intended?
[19:33:58] <JeroenDeDauw>	 huhwat
[19:34:23] <JeroenDeDauw>	 lazowik: oh, the order of the imports?
[19:34:27] <lazowik>	 uep
[19:34:32] <lazowik>	 bah
[19:34:33] <lazowik>	 *yep
[19:34:45] <JeroenDeDauw>	 In DM 1.0 Statement is in DataModel\Statement, not DataModel\Claim
[19:34:50] <JeroenDeDauw>	 Which is what I originally used
[19:34:59] <JeroenDeDauw>	 And then realized I needed to change it for compat with 0.9.x
[19:35:40] <lazowik>	 JeroenDeDauw: you changed Statement to Claim but didn't move that to right position
[19:35:50] <JeroenDeDauw>	 lazowik: yeah so?
[19:36:00] <lazowik>	 so I can move that
[19:36:03] <lazowik>	 then you can +2
[19:36:08] <JeroenDeDauw>	 ah
[19:36:12] <JeroenDeDauw>	 lazowik: good plan!
[19:42:11] <grrrit-wm>	 (03PS3) 10Michał Łazowik: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157346 (owner: 10Jeroen De Dauw)
[19:48:05] <grrrit-wm>	 (03PS2) 10Michał Łazowik: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[19:48:16] <lazowik_>	 JeroenDeDauw: ^
[19:51:43] <JeroenDeDauw>	 lazowik_: thanks
[20:16:34] <Ash_Crow>	 something is broken with the {{List of properties}} template
[20:17:01] <Ash_Crow>	 in https://www.wikidata.org/wiki/Wikidata:WikiProject_Fictional_universes#Properties the first column is full of "(no label)"
[20:18:40] * lazowik_ looks at some js patch
[20:18:41] <lazowik_>	 http://wholles.com/wp-content/uploads/2014/03/Scared-Cat-Wallpaper.jpg
[20:18:54] <lazowik_>	 tab level: 8
[20:18:55] <lazowik_>	 …
[20:26:03] <lazowik_>	 JeroenDeDauw: ^ something known? (what Ash_Crow said)
[20:28:01] <multichill>	 Ash_Crow: Zolo did some updates afaik
[20:33:16] <mvolz>	 Erm. I take it this isn't supposed to happen :) https://www.wikidata.org/wiki/Wikidata:List_of_properties/Works
[20:33:29] <lazowik_>	 *puff*
[20:33:29] <mvolz>	 script errors. script errors everywhere.
[20:36:24] <benestar>	 JeroenDeDauw: hey, can you rebase https://gerrit.wikimedia.org/r/#/c/155896/ to retrigger jenkins until https://gerrit.wikimedia.org/r/#/c/157302/ is merged?
[20:44:26] <JeroenDeDauw>	 benestar: why don't you do this yourself? if it's already latest against master, you have to modify the thing, for instance by editting the comit message
[20:44:49] <JeroenDeDauw>	 I guess some people can retrigger the Jenkins job, but I never do this
[20:46:26] <benestar>	 JeroenDeDauw: but jenkins does not run for me because I somehow changed my email address -.-
[20:46:36] <benestar>	 from @googlemail to @gmail
[20:47:14] <benestar>	 JeroenDeDauw: so I need you to trigger it, otherwise we will have to wait until the other patch I linked aboved gets merged
[20:47:40] <JohnLewis>	 benestar: poor you :p
[20:49:49] <grrrit-wm>	 (03PS7) 10Jeroen De Dauw: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene)
[20:50:15] <JeroenDeDauw>	 benestar: ^
[20:50:28] <JeroenDeDauw>	 JohnLewis not as poor as you I hope?
[20:50:59] <benestar>	 thx
[20:52:00] <JohnLewis>	 JeroenDeDauw: screw you :p
[20:52:48] <multichill>	 benestar: So that patch would get the imagelinks table updated? That would be nice
[20:53:43] <benestar>	 multichill: :)
[20:54:25] <multichill>	 Hmm, didn't I file a bug for that? :P
[20:54:48] <JeroenDeDauw>	 JohnLewis: no thanks
[20:58:08] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0c54953 : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33997405
[21:14:11] <sjoerddebruin>	 JeroenDeDauw: The Purrari is dead. :( http://www.ctvnews.ca/autos/purrari-458-upsets-ferrari-prompts-legal-warning-against-deadmau5-1.1983063
[21:16:53] <JeroenDeDauw>	 >_>
[21:17:10] <JeroenDeDauw>	 Ferrari behaving a bit to ferral?
[21:25:35] <JeroenDeDauw>	 !r 157346 | addshore 
[21:25:35] <wm-bot3>	 addshore: https://gerrit.wikimedia.org/r/#/c/157346/
[21:25:37] <JeroenDeDauw>	 !r 157347 | addshore 
[21:25:37] <wm-bot3>	 addshore: https://gerrit.wikimedia.org/r/#/c/157347/
[21:25:45] <addshore>	 :O
[21:25:49] <JeroenDeDauw>	 mergeeeeeeeeeeee
[21:25:59] <JeroenDeDauw>	 addshore: hi btw
[21:26:27] <grrrit-wm>	 (03PS3) 10Addshore: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[21:26:29] <grrrit-wm>	 (03PS4) 10Addshore: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157346 (owner: 10Jeroen De Dauw)
[21:27:16] <grrrit-wm>	 (03PS4) 10Bene: Refactor ReferencedEntitiesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156044 
[21:28:03] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] DM 1.0 compat: do not add claims to properties and add statements to items (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[21:28:15] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157346 (owner: 10Jeroen De Dauw)
[21:28:19] <addshore>	 JeroenDeDauw: ^^
[21:29:42] <grrrit-wm>	 (03PS5) 10Bene: Refactor ReferencedEntitiesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156044 
[21:29:44] <JeroenDeDauw>	 addshore: ^^
[21:29:52] <JeroenDeDauw>	 huhwat
[21:29:55] <benestar>	 yes addshore, merge my commit as JeroenDeDauw said
[21:30:20] <grrrit-wm>	 (03PS4) 10Jeroen De Dauw: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 
[21:30:34] <JeroenDeDauw>	 :)
[21:31:51] <grrrit-wm>	 (03CR) 10Bene: "Any reviews?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155287 (owner: 10Bene)
[21:33:14] <JeroenDeDauw>	 addshore: you saw this already right? http://wikiba.se/
[21:33:18] <JeroenDeDauw>	 benestar: you to http://wikiba.se/
[21:34:09] <addshore>	 JeroenDeDauw: yup
[21:34:10] <benestar>	 JeroenDeDauw: yes, I complained about the missing footer ;)
[21:34:13] <addshore>	 :D
[21:34:18] <addshore>	 eww, yeh
[21:34:48] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[21:35:15] <addshore>	 JeroenDeDauw: enjoying having a speedier jenkins again? :D
[21:35:34] <benestar>	 addshore: nope :P
[21:36:55] <addshore>	 benestar: true :P you are not xD
[21:37:32] <benestar>	 addshore: can you maybe ping someone from the foundation to merge that patch?
[21:37:37] <benestar>	 it's really annoying atm
[21:37:40] <JeroenDeDauw>	 benestar: create a ticket please!
[21:38:16] <addshore>	 benestar: its not just merging it, it needs to be deployed, and as far as I know there are a very limited number of people that can do that
[21:38:22] <benestar>	 JeroenDeDauw: for the footer? will do
[21:38:25] <benestar>	 addshore: :'(
[21:40:25] <JeroenDeDauw>	 benestar: I reviewed your commit again
[21:40:38] <JeroenDeDauw>	 benestar: that inheritance worries me
[21:40:50] <JeroenDeDauw>	 The class itself also appears to have low cohesion
[21:41:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157346 (owner: 10Jeroen De Dauw)
[21:41:35] <benestar>	 JeroenDeDauw: yeah, it's rather a collection of some methods
[21:41:45] <benestar>	 but it is still better to have it there than in EntityView
[21:42:26] <grrrit-wm>	 (03PS4) 10Bene: Introduce HtmlGeneratorTestCase to validate HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 
[21:44:05] <JeroenDeDauw>	 benestar: I'm not sure
[21:44:11] <JeroenDeDauw>	 It's different...
[21:44:27] <benestar>	 JeroenDeDauw: so where do you propose to put the code
[21:44:30] <JeroenDeDauw>	 benestar: the method this replaces should definitly be split
[21:44:36] <benestar>	 it has to go out of EntityView
[21:44:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[21:44:48] <JeroenDeDauw>	 And having some of it in a dedicated class is not bad
[21:45:11] <JeroenDeDauw>	 Create a new class that just does what the method did before?
[21:45:30] <benestar>	 is a small improvement ;)
[21:45:40] <benestar>	 but maybe we should think in larger steps
[21:45:47] <JeroenDeDauw>	 Agree
[21:46:30] <benestar>	 JeroenDeDauw: I'm however not sure if a ClaimsParserOutput class would be better
[21:46:43] <JeroenDeDauw>	 If you want to improve EntityView, I'd identify the cohesive groups of fields and methods that serve one particular actor, and move each out into their own class
[21:47:05] <benestar>	 that's what I basically tried with the EntityParserOutput
[21:47:29] <JeroenDeDauw>	 benestar: Creating a derivative of ParserOutput just to use the added behaviour right after instantiation is very suspect to me
[21:48:07] <benestar>	 we can also create a service class which takes an existing ParserOutput object and adds the data to it
[21:48:15] <JeroenDeDauw>	 benestar: suppose the code changes and you already construct the object somewhere else. You'll no longer be able to add the things to it, since you'd need to change the class of the existing instance
[21:48:33] <JeroenDeDauw>	 benestar: that would prevent this problem
[21:49:36] <benestar>	 JeroenDeDauw: so the inheritance problem is the one thing but the other question is: should we create an own service class for claims, for sitelinks and for whatever else
[21:49:39] <benestar>	 ?
[21:55:01] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/080e390 : jeroendedauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/34000197
[21:56:11] <JeroenDeDauw>	 benestar: what context? entity view or just parser output?
[21:56:59] <benestar>	 parser output
[21:57:18] <benestar>	 for the entity view we already have different services for the claims and the sitelinks etc.
[21:57:35] <grrrit-wm>	 (03PS5) 10Bene: Refactor ClaimsViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 
[21:57:57] <JeroenDeDauw>	 benestar: having something that does this for stuff of type Entity is bad
[21:58:04] <JeroenDeDauw>	 You need a split at least per Entity type
[21:58:10] <JeroenDeDauw>	 So one for Item and one for Property
[21:58:35] <benestar>	 JeroenDeDauw: that's also bad
[21:58:37] <JeroenDeDauw>	 And perhaps it makes sense to have a class for Fingerprint or StatementList that both use
[21:58:45] <benestar>	 we have to split per fingerprint, per claims and per sitelinks
[21:58:49] <JeroenDeDauw>	 I don't know how much code this is, or what it is used for
[21:59:03] <benestar>	 but we will end in having some 10 lines classes
[21:59:04] <JeroenDeDauw>	 benestar: why is that bad?
[21:59:17] <benestar>	 JeroenDeDauw: it does not scale if we have some other new entity types
[21:59:22] <benestar>	 like commonsmedia or quotation
[21:59:35] <JeroenDeDauw>	 benestar: it is not certain we will have entity types for those
[21:59:47] <JeroenDeDauw>	 benestar: so the issue you have with this is that we will have duplication?
[22:00:14] <benestar>	 JeroenDeDauw: huh, we need different entity types for those...
[22:00:28] <JeroenDeDauw>	 benestar: just ask youself the question for each type of thing that is duplicated if it's wortwhile at present to factor it out and use composition
[22:00:33] <JeroenDeDauw>	 If it is not presently, then don't
[22:00:39] <JeroenDeDauw>	 This can easily be done later
[22:01:02] <JeroenDeDauw>	 benestar: in any case, you want an item specific class and a property specific one that contain the smaller parts
[22:01:12] <JeroenDeDauw>	 having an entity one does not work
[22:01:25] <JeroenDeDauw>	 (at least not if it contains the parts)
[22:02:33] <JeroenDeDauw>	 benestar: have a look at ItemDiffer and PropertyDiffer here https://github.com/wmde/WikibaseDataModel/tree/master/src/Entity/Diff
[22:02:47] <JeroenDeDauw>	 They have some duplication: the fingerprint stuff
[22:03:00] <JeroenDeDauw>	 That's only 3 lines, so I did not create a FingerprintDiffer
[22:03:07] <JeroenDeDauw>	 You could though, and that'd not be a bad thing
[22:03:16] <JeroenDeDauw>	 Important here is that you have a differ per type of entity
[22:03:42] <JeroenDeDauw>	 And if you have a case where you get an entity, you can delegate to strategies based on the type https://github.com/wmde/WikibaseDataModel/blob/master/src/Entity/Diff/EntityDiffer.php
[22:03:59] <JeroenDeDauw>	 Which gives you an obvious way to extend the system with new entity types
[22:29:15] <rschen7754>	 anyone familiar with lua and how it works with wikibase?
[22:30:31] <Dalia>	 probably
[22:30:53] <Dalia>	 rschen7754: this channel is full of developers, just FYI
[22:31:22] <rschen7754>	 i've been struggling with fixing https://www.wikidata.org/wiki/Module:Roadtable_row for at least a few hours now...
[22:35:55] <rschen7754>	 benestar|cloud: do you do stuff with lua?
[23:15:11] <grrrit-wm>	 (03PS5) 10Addshore: DM 1.0 compat: do not add claims to properties and add statements to items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157347 (owner: 10Jeroen De Dauw)
[23:16:12] <sjoerddebruin>	 The automatic edits on Wikidata when you do a page move, why do we need to mark those as controlled? Should be automatic imo.