[01:09:52] Uncaught TypeError: Cannot read property 'data' of undefined VM364:361$.widget.draw [01:10:12] when trying to add statements to wikidata [06:35:57] (03PS7) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [06:36:07] (03CR) 10jenkins-bot: [V: 04-1] Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 (owner: 10Henning Snater) [06:45:07] (03PS1) 10Henning Snater: Fixed TermBox toolbar initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157042 [06:52:45] (03CR) 10jenkins-bot: [V: 04-1] Fixed TermBox toolbar initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157042 (owner: 10Henning Snater) [09:24:11] [13Wikiba.se] 15thiemowmde comment on commit 1449119b5: I honestly have no idea whats going on here. Both the bootstrap download and the [documentation](http://getbootstrap.com/getting-started/) mention a `dist` folder. I tried following the installation instructions like the tenth time now, both in a clean directory and in my existing one. Bootstrap is in a `dist` folder.... 02http://git.io/G-Bn8Q [09:29:35] [13Wikiba.se] 15thiemowmde comment on commit 1449119b5: The source is https://github.com/worldskills/bootstrap.git. There is a `dist` folder. What's the URL you are referring to? 02http://git.io/vLlKNA [09:29:53] did you discuss with succu the data we could get (remember Wikimania) ? [09:31:53] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] "Jenkins is having a composer issue. Verified manually." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157042 (owner: 10Henning Snater) [09:33:24] Is now the change about badges implemented? Are now all badges in wikidata? [09:33:36] can you start removing them from the English Wikipedia pages? [09:36:09] you = we [09:40:33] magioladitis: not yet [09:40:39] [13Wikiba.se] 15thiemowmde created 06bootnerv (+1 new commit): 02http://git.io/b4LHrw [09:40:39] 13Wikiba.se/06bootnerv 14cb37250 15Thiemo Mättig: Fix broken bootstrap install again [09:40:49] [13Wikiba.se] 15thiemowmde opened pull request #11: Fix broken bootstrap install again (06master...06bootnerv) 02http://git.io/FeJWTg [09:43:59] [13Wikiba.se] 15thiemowmde comment on commit 1449119b5: See #11. 02http://git.io/UOn1Sw [09:58:54] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/X6ywzA [09:58:54] 13Wikiba.se/06master 142a45cef 15Jeroen De Dauw: Merge pull request #11 from wmde/bootnerv... [10:01:06] (03PS1) 10WikidataBuilder: New Wikidata Build - 29/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157052 [10:12:26] (03PS3) 10Addshore: Delete the method getPossibleErrors of ApiModules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155042 (owner: 10Lucie Kaffee) [10:17:19] (03CR) 10Addshore: [C: 032] Delete the method getPossibleErrors of ApiModules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155042 (owner: 10Lucie Kaffee) [10:20:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/157052 (owner: 10WikidataBuilder) [10:20:45] why is wikidata jenkins still reviewing? [10:23:38] on Wikidata? [10:23:54] the wmf jenkins isnt running for the Wikidata repo yet, still got some issues to iron out [10:23:55] yes [10:23:57] ok [10:24:09] see my big comment on https://gerrit.wikimedia.org/r/#/c/156977/ and also https://github.com/wmde/WikidataBuilder/issues/27 [10:25:46] (03CR) 10Addshore: "The change would automatically be merged once the gate-and-submit jobs have run :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155042 (owner: 10Lucie Kaffee) [10:29:19] [13Wikiba.se] 15JeroenDeDauw pushed 3 new commits to 06master: 02http://git.io/-uA9mA [10:29:19] 13Wikiba.se/06master 140a54759 15jeroendedauw: Do not use "components" for two different things [10:29:20] 13Wikiba.se/06master 14bdaf42b 15jeroendedauw: Add smoke test [10:29:20] 13Wikiba.se/06master 14deec7f9 15jeroendedauw: Add TravisCI config [10:32:11] (03CR) 10Tobias Gritschacher: [C: 032] Optimized copyright tooltip logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 (owner: 10Henning Snater) [10:32:36] [13Wikiba.se] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/2wt4mQ [10:32:36] 13Wikiba.se/06master 14aad0dc4 15jeroendedauw: Add smoke test for css loading [10:32:36] 13Wikiba.se/06master 1496891a9 15jeroendedauw: Update Travis config [10:35:06] [13Wikiba.se] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/gtqp0w [10:35:06] 13Wikiba.se/06master 142f0535c 15jeroendedauw: Update README [10:35:06] 13Wikiba.se/06master 14099a197 15jeroendedauw: Add build status badge [10:35:41] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/tF-uUQ [10:35:41] 13Wikiba.se/06master 1463066d4 15jeroendedauw: Fix typo in test file name [10:35:48] Thiemo_WMDE: you are now happy: https://github.com/wmde/Wikiba.se/blob/master/tests/SmokeTest.php#L31-33 [10:36:36] Abraham_WMDE: you can have smoke tests for the site: https://github.com/wmde/Wikiba.se [10:37:38] addshore: so you want us to enhance the bug? https://github.com/wmde/WikidataBuilder/issues/27 [10:37:49] :D [10:38:10] yes please JeroenDeDauw ;p [10:38:14] JeroenDeDauw: cool thx [10:38:45] JeroenDeDauw: I'll add phplint for that too :O [10:38:54] maybe, if your lucky ;p [10:39:04] addshore: for what? [10:39:10] Wikiba.se [10:39:22] addshore: for all the 0 php files it has? [10:39:56] it has 0 php files? :O [10:40:46] addshore: perhaps first look at the project :) [10:40:56] it does have 2, you liiie! :P [10:41:01] (03Merged) 10jenkins-bot: Optimized copyright tooltip logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 (owner: 10Henning Snater) [10:41:07] addshore: where? [10:41:13] the tests? [10:41:15] >_> [10:41:18] https://github.com/wmde/Wikiba.se/tree/master/tests ;p [10:41:18] xD [10:41:43] addshore: but then we will also have to test the linter? [10:42:09] (03CR) 10Thiemo Mättig (WMDE): "I'm totally confused now. Just some days ago any auto-merge got disabled and I was told I have to submit everything myself from now on. Wh" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155042 (owner: 10Lucie Kaffee) [10:42:10] A system test that makes sure it runs correctly on our code [10:42:30] **Thiemo_WMDE unlocked the totally confused achievement, level 2** [10:42:42] Thiemo_WMDE: the Wikibase repo is using the wmf jenkins again now :) No need to merge things yourself [10:43:11] But also what you got told the other day was true :) as nothing would get merged then otherwise [10:43:12] * aude celebrate! [10:43:20] what does that mean? why was is disabled for a few days? [10:43:36] die wikidata jenkins! [10:43:46] Thiemo_WMDE: wmf jenkins is running our tests now [10:43:51] so it can +2 verify [10:44:43] but stuff got auto +2ed before. what changed? [10:45:13] Thiemo_WMDE: no, +1 [10:45:26] i also don't understand why a +2 sometimes creates a new patch set and sometimes not. i can't remember this happening before. [11:06:10] Thiemo_WMDE: please do not add stuff to https://gerrit.wikimedia.org/r/#/c/153714/ [11:09:35] (03Abandoned) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [11:10:00] (03PS1) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 [11:10:08] (03PS2) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157075 [11:10:36] (03CR) 10Jeroen De Dauw: "Unrelated things got added into this commit." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [11:11:54] (03PS1) 10Thiemo Mättig (WMDE): Fix incomplete ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157080 [11:12:44] (03CR) 10jenkins-bot: [V: 04-1] Show copyright tooltip on aliases edit toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157058 (owner: 10Henning Snater) [11:20:12] (03CR) 10jenkins-bot: [V: 04-1] Drop unused EntityRevisionSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [11:23:11] [13WikibaseQuery] 15addshore pushed 1 new commit to 06master: 02http://git.io/vZ_x2A [11:23:11] 13WikibaseQuery/06master 14788df5a 15addshore: Remove use of deprecated getPossibleErrors (since 1.24) [11:47:50] (03CR) 10Tobias Gritschacher: [C: 032] Show copyright tooltip on aliases edit toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157058 (owner: 10Henning Snater) [11:56:54] (03Merged) 10jenkins-bot: Show copyright tooltip on aliases edit toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157058 (owner: 10Henning Snater) [12:10:41] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/154425/ needs rebase [12:26:12] (03PS8) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [12:44:15] JeroenDeDauw: update for the dm1.0 tests: https://tools.wmflabs.org/paste/view/af5d30b1 [12:52:02] Thiemo_WMDE: k [12:54:27] Thiemo_WMDE: wfSuppressWarnings(); // We are referencing properties that don't exist. Not relevan [12:54:29] t here. [12:54:31] wow [12:54:53] (03CR) 10Jeroen De Dauw: [C: 032] Make GetClaimsTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157098 (owner: 10Thiemo Mättig (WMDE)) [12:57:54] Thiemo_WMDE: I am looking at the SetSiteLinkTest failure now [12:58:24] JeroenDeDauw: ok. i'm at SetClaimTest now. [12:58:57] (03PS1) 10Jeroen De Dauw: Add missing class ref and use new method name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157132 [13:00:56] (03PS1) 10Jeroen De Dauw: Make SetSiteLinkTest compatible with DM 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157133 [13:01:01] Might have fixed this one... [13:02:17] (03PS1) 10Thiemo Mättig (WMDE): Remove wfSuppressWarnings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157134 [13:05:44] Thiemo_WMDE: did you look at ItemDisambiguationTest yet? [13:07:18] aude: hey :D [13:07:29] it's benestar ! [13:07:34] aude: you can enable the setting if Lydia_WMDE didn't tell you yet ;) [13:07:45] aude: "it's a benestar!" [13:07:49] * aude waiting for greg to say it's ok [13:07:50] Get your grammar right please [13:08:01] JeroenDeDauw: hi :D [13:08:09] finally it's weekend for me \o/ [13:08:11] das ist JeroenDeDauw ! [13:13:39] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/9e73b38 : Jeroen De Dauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33896025 [13:13:44] (03PS1) 10Jeroen De Dauw: Sop using deprecated methods in SpecialItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157135 [13:13:59] (03PS1) 10Jeroen De Dauw: Stop using deprecated DM functions in ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157136 [13:14:10] (03PS2) 10Jeroen De Dauw: Stop using deprecated methods in SpecialItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157135 [13:14:46] Thiemo_WMDE: this ItemDisambiguationTest one does not compute - the error output does not seem to match what the code does... [13:14:55] not being able to run this really sucks [13:15:22] wow, php5 just segfaultet for the first time. [13:18:47] JeroenDeDauw: similar problem here. this just doesnt make sense. the code returns outdated crap, unrelated to what it actually does. [13:19:22] addshore: self merged in all of the repos?! :<@ [13:19:51] Thiemo_WMDE: that test class is an excellent example of data provider abuse [13:21:06] Thiemo_WMDE: I'm thinking that perhaps I should just revert the claim and statement changes in DM for now and put them in a later version [13:22:23] JeroenDeDauw: im fine with that. [13:23:15] to me it looks like there is something deep in some api or serialization code that just drops claims now with no warning. [13:24:21] Thiemo_WMDE: you know this happens for properties right? [13:24:45] JeroenDeDauw: with the exception i added, yes, but i dont get the exception. [13:25:27] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated DM functions in ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157136 (owner: 10Jeroen De Dauw) [13:26:13] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make SetSiteLinkTest compatible with DM 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157133 (owner: 10Jeroen De Dauw) [13:27:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add missing class ref and use new method name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157132 (owner: 10Jeroen De Dauw) [13:27:06] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated methods in SpecialItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157135 (owner: 10Jeroen De Dauw) [13:28:52] (03CR) 10Thiemo Mättig (WMDE): "You can not call setters on getFingerprint because it does not return a reference, remember?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157135 (owner: 10Jeroen De Dauw) [13:32:13] (03Abandoned) 10Jeroen De Dauw: Stop using deprecated methods in SpecialItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157135 (owner: 10Jeroen De Dauw) [13:32:15] (03Abandoned) 10Jeroen De Dauw: Stop using deprecated DM functions in ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157136 (owner: 10Jeroen De Dauw) [13:32:18] Thiemo_WMDE: >_> [13:33:03] (03CR) 10Jeroen De Dauw: [C: 032] Remove wfSuppressWarnings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157134 (owner: 10Thiemo Mättig (WMDE)) [13:41:19] JeroenDeDauw: oh yes, some equals fails to compare claims/statements. [13:42:22] [13WikibaseDataModel] 15JeroenDeDauw created 06statementequals (+1 new commit): 02http://git.io/FbOF7g [13:42:22] 13WikibaseDataModel/06statementequals 14116ec78 15jeroendedauw: Add extra tests for StatementList::equals [13:42:33] (03Merged) 10jenkins-bot: Add missing class ref and use new method name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157132 (owner: 10Jeroen De Dauw) [13:42:35] (03Merged) 10jenkins-bot: Make SetSiteLinkTest compatible with DM 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157133 (owner: 10Jeroen De Dauw) [13:45:29] [travis-ci] wmde/WikibaseDataModel/statementequals/116ec78 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33900021 [13:45:52] Lydia_WMDE: Answered the question :) [13:46:32] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06statementequals at 14116ec78: 02http://git.io/s2o5IA [13:49:15] JeroenDeDauw: found it. [13:49:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4d2fbd2 : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33899192 [13:52:44] Thiemo_WMDE: looks like there are no proper general tests for this... ItemTest extends EntityTest, one of those evil things [13:55:17] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/169 [13:55:18] [13WikibaseDataModel] 15JeroenDeDauw created 06statementcompare (+1 new commit): 02http://git.io/j2mQPQ [13:55:18] 13WikibaseDataModel/06statementcompare 14a4d0416 15jeroendedauw: Fix bug in Item::equals [13:55:29] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #169: Fix bug in Item::equals (06master...06statementcompare) 02http://git.io/OhO9ow [13:55:37] I'm going to clean up those evil tests... they are the biggest pile of legacy code left in DM [13:59:03] [travis-ci] wmde/WikibaseDataModel/statementcompare/a4d0416 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33901312 [14:03:14] [13WikibaseDataModel] 15JeroenDeDauw created 06statementtest (+1 new commit): 02http://git.io/WCcC0w [14:03:14] 13WikibaseDataModel/06statementtest 141e4e571 15jeroendedauw: Make Statement test not derive from ClaimTest [14:03:29] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #170: Make Statement test not derive from ClaimTest (06master...06statementtest) 02http://git.io/GIdaCw [14:05:24] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06statementtest from 141e4e571 to 14de8e922: 02http://git.io/HQMXGQ [14:05:24] 13WikibaseDataModel/06statementtest 14de8e922 15jeroendedauw: Make Statement test not derive from ClaimTest [14:05:30] [travis-ci] wmde/WikibaseDataModel/statementtest/1e4e571 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33902101 [14:07:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c33b266 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33900141 [14:08:32] Thiemo_WMDE wins the debugger of the day award [14:08:47] I clearly do. [14:09:19] Feels good finding such nasty things. :))) [14:09:47] running the repo tests again. looks waaayyy better now. [14:11:14] [travis-ci] wmde/WikibaseDataModel/statementtest/de8e922 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33902282 [14:12:11] Thiemo_WMDE: tests finieshed [14:14:27] whaaaaaaaaaaaaaaaaaaa [14:14:30] !nyan | Thiemo_WMDE [14:14:30] Thiemo_WMDE: ~=[,,_,,]:3 [14:19:40] Thiemo_WMDE: don't make user50 sad! [14:21:57] JeroenDeDauw: https://tools.wmflabs.org/paste/view/90d93926 [14:22:21] Thiemo_WMDE: well that's better! [14:22:42] [13WikibaseDataModel] 15thiemowmde 04deleted 06statementcompare at 14a4d0416: 02http://git.io/uFwHHw [14:22:56] Thiemo_WMDE: so I did not fix SetSiteLinkTest ??? [14:25:01] (03PS1) 10Thiemo Mättig (WMDE): Fix SetSiteLinkTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157147 [14:26:37] (03PS1) 10Addshore: Fix namespaces and use statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157148 [14:26:56] (03CR) 10Addshore: [C: 032] "Followup https://gerrit.wikimedia.org/r/157148 should be merged" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [14:27:02] JeroenDeDauw: you want to work on the last 2 tests? else i will do. [14:27:57] oh, not today. pavel-time. [14:28:42] (03CR) 10Addshore: [C: 031] Fix namespaces and use statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157148 (owner: 10Addshore) [14:28:52] Thiemo_WMDE: ^^ ;p [14:29:00] Thiemo_WMDE: will merge if jenkins finishes soon [14:29:22] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix namespaces and use statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157148 (owner: 10Addshore) [14:29:50] (03CR) 10Daniel Kinzler: [C: 031] "just waiting for jenkins. fine to merge." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157148 (owner: 10Addshore) [14:30:12] DanielK_WMDE: no need to wait for jenkins, it will do the gate-submit jobs before merging now :) [14:30:41] oh, right, we are using the core jenkins now, yay :) [14:30:58] benestar: around? [14:31:06] aude: yes :) [14:31:14] DanielK_WMDE: yup :) [14:31:17] i'll deploy the badge change shortly [14:31:24] I might add a third slave to it though, to make it even speedier! [14:31:29] i'll want you to confirm that it's good [14:31:38] s/want/need [14:32:08] aude: it's only the config change, correct? [14:32:15] I +1 ed it already [14:32:45] (03CR) 10Thiemo Mättig (WMDE): "Waiting for the other patches to be merged and just rebasing should have fixed this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [14:33:13] yes [14:41:44] benestar: Can you start with fa, pt, pl? [14:41:50] benestar: done [14:41:55] aude: :D [14:41:59] Amir1: what start? [14:42:03] please check that it looks ok [14:42:17] i suppose purge a page and see the class names [14:42:31] benestar: fixing their css to show badges [14:42:36] aude: purging not needed [14:42:41] ok [14:42:46] the class names are not in wikitext ;) [14:42:54] looks good [14:42:56] yes, looks fine :) [14:42:57] benestar: true [14:43:24] (03Merged) 10jenkins-bot: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [14:45:35] (03Merged) 10jenkins-bot: Fix namespaces and use statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157148 (owner: 10Addshore) [14:47:22] aude: does not work for monobook though -.- [14:47:33] oh no [14:47:53] aude: I can prepare a fix in WikimediaBadges [14:48:34] however, cologneblue seems to work quite well :) [14:49:57] we'll have to wait until tuesday :/ [14:50:05] but yes prepare it [14:50:11] aude: no backport? [14:51:47] backport yes to our new branch [14:51:55] and to the current one [14:52:08] monday is a holiday so no swat / deploy [14:53:06] back later [14:57:26] is there any way to locally set how those badges looks like? [14:59:48] [13WikimediaBadges] 15Benestar created 06monobook (+1 new commit): 02http://git.io/8quX3w [14:59:48] 13WikimediaBadges/06monobook 145bbee7a 15Bene: Fix the selectors to work with monobook [15:00:03] [13WikimediaBadges] 15Benestar opened pull request #10: Fix the selectors to work with monobook (06master...06monobook) 02http://git.io/eX0w4A [15:10:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f695e58 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33906256 [15:33:48] Stryn: in common.css ? [15:34:41] https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikidata/d529f388ef92a7bfca04c5eded34006b49a8bec3/extensions%2FWikimediaBadges%2Fresources%2Fskins%2Fdefault [15:35:02] copy those and customize the icon [15:35:22] with one from commons? [15:35:44] (full protected there, of course) [15:36:21] aude: now we have 3 jenkins slaves :> [15:36:25] \o/ [15:36:27] thanks aude, I will try [15:36:33] ok [15:36:42] benestar might be able to help more [15:37:23] Stryn: hey, what exactly do you want to modify? [15:38:07] benestar: change the good article badge on fi-wiki to https://upload.wikimedia.org/wikipedia/commons/4/42/Monobook-bullet-ga.png [15:38:43] Stryn: we might think about making this configurable per wiki [15:38:56] because Commons.css hacks aren't the best way to go (not embeddable etc.) [15:39:03] agree [15:39:49] so I let it be as it's now... if some complaints on fi-wiki, then let's see again [15:39:53] but I have to talk to Lydia_WMDE first if we want that [15:40:09] Stryn: I will perhaps create a page or section on meta where wikis can request a change of the icons [15:40:20] if there are enough we might think about a software implementation [15:40:35] if there are only two or three we can also do it on their local common.css pages [15:40:48] ok, that's fine :) [15:44:12] (03CR) 10Jeroen De Dauw: [C: 032] Fix SetSiteLinkTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157147 (owner: 10Thiemo Mättig (WMDE)) [15:50:54] Stryn: https://meta.wikimedia.org/wiki/Wikidata/Development/Badges#Requests_for_different_icons if your community decides to change the icons [15:51:42] benestar: thanks, we will see [15:52:15] aude: when does Lydia_WMDE come back? [15:52:21] monday? [15:55:09] (03PS1) 10Addshore: Remove use of deprecated Diff class aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157163 [16:00:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d1ce77c : Jeroen De Dauw The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33913217 [16:07:50] [13Time] 15addshore created 06calanderModelParserTest from 06master (+0 new commits): 02http://git.io/7KVvCw [16:09:48] [13Time] 15addshore pushed 1 new commit to 06calanderModelParserTest: 02http://git.io/2U0s6w [16:09:48] 13Time/06calanderModelParserTest 144984f97 15addshore: Add basic CalendarModelParserTest [16:11:20] [13Time] 15addshore opened pull request #24: Add basic CalendarModelParserTest (06master...06calanderModelParserTest) 02http://git.io/6hIccg [16:16:04] benestar: monday or maybe is around before that [16:34:26] is it me or this editor is doing the wrong thing ? https://www.wikidata.org/w/index.php?title=Q3886550&diff=154210127&oldid=153647954 [16:34:50] Only the last one is good. [16:35:05] labels should be short as possible <3 [16:35:44] he changed the labels for many items whose label was Osiris... [16:36:21] Maybe he is using the terminator of Magnus, and thinks that the label needs to be changed to fix items. [16:37:02] Magnus tools add a [WiDAR-something] text to the edit comment, no? [16:37:13] No, it's a other tool. [16:37:14] http://tools.wmflabs.org/wikidata-terminator/ [16:37:36] Gotcha. http://tools.wmflabs.org/wikidata-terminator/?list&lang=de [16:38:30] So tell him to only add descriptions. :) [16:38:59] I'll do this [16:39:18] He can also add other stuff, but don't adjust the labels. :) [17:29:36] Can somebody check the edits of 180.183.158.155? Can't read that language https://www.wikidata.org/w/index.php?title=Q55816&action=history [17:29:43] He/she fucked up the commonscat -_- [17:31:24] sjoerddebruin: Do you want someone blocks him/her? [17:31:43] No, the edits are from a few days ago. [17:31:57] But I just want to know if it's not vandalism. :) [17:32:28] okay, I can't read that language, looks like eastern Asian [17:33:41] Google Translate gives weird stuff. [17:44:17] sjoerddebruin: looks like Thai [17:44:24] Can you read that? :O [17:44:35] i can only recognise it :( [17:44:38] :/ [17:53:33] (03CR) 10Addshore: [C: 031] Fix incomplete ItemDisambiguationTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/157080 (owner: 10Thiemo Mättig (WMDE)) [17:54:19] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [18:08:18] ^^ looks like a test edits... one of them said "Spanish" per google translate [18:19:00] Amir1, sjoerddebruin that's Thai language [18:19:19] Yes, we know. [18:19:29] We only want to know if it's vandalism or not. :) [19:18:37] Amir1: hey, the thing with the categories is weird... [19:20:27] JeroenDeDauw: around, if so know of any nice way to resolve my small issue? https://gist.github.com/addshore/04863ade4960c5616135 [19:21:35] addshore: I'd create a static method invoking the constructor [19:21:57] mhhm, I was thinking that benestar, but what to call it? :P I would have just gone for ::new ;p [19:22:14] addshore: yes, or ::factory [19:22:19] true! [19:24:07] bit of a depresing method [19:24:10] https://www.irccloud.com/pastebin/fVtwFRCx [19:27:08] addshore: indeed, why don't you just want to call the constructor and then invoke the methods on the resulting object? [19:27:25] I don't get it without any context information ;) [19:27:30] urgh, I could, but then thats a whole extra line :P [19:27:51] addshore: well, so you create 6 lines to avoid one? :P [19:36:23] benestar: basically it allows me to do the following, from // 1 to // 2 to // 3 [19:36:26] https://www.irccloud.com/pastebin/5XOmuTZ3 [19:37:25] moving to seters instead of constructors as they allow me to have much more flexibility, but then doing so introduces this one annoyance [19:37:38] I sort of think it is worth it though [19:37:52] thoughts? [19:38:49] 3 looks best for me indeed [19:39:09] indeed, guess I will go for it then :P [19:39:13] sometimes it is even better to create a separate factory class for that purpose [19:39:24] done so in many Android libraries [19:40:25] addshore: because this way you can create invalid revision objects etc [19:40:58] a factory class could store all the values and then have a create method to actually create the object [19:43:54] benestar: >> https://github.com/addwiki/mediawiki-datamodel/compare/flexibility?expand=1 basically thats it all together so far [19:46:09] addshore: I'm not entirely happy with that [19:46:16] :P [19:46:29] neither am I, hence why I didnt just go and do it right away :P [19:46:36] this patch will allow you to modify all those objects after construction [19:46:47] mhhhm, now that is true! [19:47:00] gragh! [19:47:03] I'd rather create a separate factory class if you really need this flexibility [19:47:33] then you won't actually modify the constructors [19:48:25] so, the issue I am trying to avoid is having massive constructors with a billion arguments, many of which I wont need to / want to set, but say I want to set the 2st 2nd 3rd 5th 7th and 8th [19:48:39] but I have to naturally stick to the single order as php is annoying like that :P [19:48:50] mhhhhhm [19:49:16] just php sometimes, Bah! [19:50:46] addshore: so just reorder the constructor parameters? :P [19:51:19] meh, all this thought comes from me needing to add a $title to the Revision object https://github.com/addwiki/mediawiki-datamodel/blob/master/src/Revision.php#L49 [19:52:56] addshore: a $title? o.O [19:53:18] benestar: yup [19:53:56] back [19:54:01] addshore: but then the constructor has to change anyway. Or is the $title optional? [19:54:34] well, yes, currently the constructor would have to change, potentially I should just create a NewRevision object [19:55:56] addshore: another step into mediawiki rewrite ^^ [19:56:07] potentially $pageId in the constructor for Revision needs to change from and int to some new PageIdentifier class, that can be constructed with either a title or pageid or both [19:56:18] that would actually solve my issue, I think.. [19:56:43] addshore: how often is the Revision constructor called in the code base? [19:57:05] I guess it varies depending on the use of the library :) [19:59:43] benestar: https://github.com/addwiki/mediawiki-datamodel/commit/c2c9a0841d47a68607ade18c96f0e5c642fa81af#diff-d41d8cd98f00b204e9800998ecf8427e ? :P [20:00:55] addshore: hmm, you said "PageIdentifier class, that can be constructed with either a title or pageid or both" [20:00:58] now this needs both [20:01:03] true [20:07:28] benestar: Are you there? [20:07:40] sjoerddebruin: yes [20:07:51] I've got some reports about this: http://gyazo.com/87ca606a2f8a4fd43a085b7333a257f3 [20:08:05] (on nlwiki) [20:11:47] benestar: https://github.com/addwiki/mediawiki-datamodel/commit/9c842c89e7465f319fead39693b17aa083419e75#diff-d41d8cd98f00b204e9800998ecf8427e [20:13:35] addshore: now we also allow identifiers which do not identify anything but that might be ok [20:13:53] yup, I believe that is okay :) [20:15:30] sjoerddebruin: hmm, weird caching issue... [20:15:45] works for me now if I set debug=true [20:15:57] Hm [20:16:48] mmm, indeed cache, but I would not call it weird, I can remember such in the past too [20:17:00] (03PS5) 10Bene: Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 [20:17:05] Romaine: the cache *is* weird :P [20:17:12] (03CR) 10jenkins-bot: [V: 04-1] Record usage of commons media files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [20:17:16] we had lots of trouble with it on wikidata [20:17:17] hahahaha [20:17:27] you have your point :p [20:18:52] It's very racist to blame the cache always. :) [20:20:48] it is common the problem of many things [20:23:21] :) [20:48:23] benestar|afk: feel free to review https://github.com/addwiki/mediawiki-datamodel/pull/1 when you get back ;p [20:50:33] benestar|afk: another issue we have on nl-wiki is that the stars shown now are different icons than the ones we used to show [20:51:20] Same for fa.wp ^ [20:52:29] stars for FP and GP? [20:52:35] FA and GP? [20:52:45] FA and GA [20:52:59] (featured page makes it sounds like there are also featured templates or categories) [20:53:06] example? [20:53:15] https://nl.wikipedia.org/wiki/Aardappel [20:58:47] do we now use local symbols? [20:59:05] didn't we once poll or vote that we'd use silver and gold stars? [20:59:10] other local [21:00:32] the Dutch community had a voting to use particular symbols, and those are not used by the new system [21:01:02] Romaine: they can be. benestar|afk can help set it uo [21:01:04] *up [21:01:05] :) [21:01:18] yes please [21:01:29] just let him know how it should look like [21:01:57] I remember my main argument was the possible cultural differences [21:02:09] https://nl.wikipedia.org/wiki/Bestand:Fairytale_bookmark_gold.svg [21:02:16] if in Austronesian language and culture a red thumbs down means "excellent" [21:02:24] https://nl.wikipedia.org/wiki/Bestand:Fairytale_bookmark_silverstar.svg [21:02:55] those two were used on nl-wiki [21:03:00] Romaine: ok cool. i'm sure benestar|afk can set that up for you soon [21:03:12] :) [21:03:37] nice [21:04:14] Lydia_WMDE: read my mail? [21:04:52] benestar: not yet. just got back from cinema after a really stressful week [21:04:56] catching up [21:05:02] will look at your email now [21:05:38] Lydia_WMDE: Romaine: FakirNL: https://meta.wikimedia.org/wiki/Wikidata/Development/Badges#Requests_for_different_icons [21:05:50] I think we should collect all requests and maybe support them globally [21:05:58] ok, will add it there [21:06:07] benestar: excellent idea [21:06:22] Romaine: thanks :) [21:06:30] benestar: good job [21:06:36] if we have it centrally, we can also support different skins in a better way [21:07:13] benestar: added [21:12:29]