[00:18:08] legoktm: Hi. Just checked my global.js loading on other wikis is working with the script you have written, would you please run it for me also? [00:19:28] Like https://ku.wikipedia.org/wiki/Bikarh%C3%AAner:Ebraminio/common.js It is causing browser error which feels bad really [00:22:51] ebraminio: can you add your name to https://meta.wikimedia.org/wiki/GlobalCssJs ? [00:23:38] Oh. done. Thank you [05:50:45] (03PS6) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [05:51:06] (03PS7) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [05:51:54] (03PS5) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [06:19:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 (owner: 10Henning Snater) [06:27:08] (03PS6) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [06:27:23] (03PS4) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [06:27:44] (03PS5) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [06:28:37] (03PS3) 10Henning Snater: Eliminated PersistentPromisor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 [06:29:20] (03PS3) 10Henning Snater: Removed wikibase.utilities.jQuery [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 [06:29:53] (03PS4) 10Henning Snater: Refactored ResourceLoader QUnit test modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 [06:31:14] (03PS3) 10Henning Snater: Untangled $.wikibase.snakview ResourceLoader modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 [06:33:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [06:48:14] (03PS7) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [07:02:02] Lydia_WMDE: got a patch for other projects feature, to deploy this afternoon [07:03:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [07:05:45] aude: awesome :) [07:06:02] i'm heading to the office in a few mins [07:08:55] (03PS3) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [07:28:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [07:46:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 (owner: 10Henning Snater) [07:57:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 (owner: 10Henning Snater) [08:08:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 (owner: 10Henning Snater) [08:13:10] (03PS1) 10Daniel Kinzler: Make ungrouped output the default for getentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156505 (https://bugzilla.wikimedia.org/70081) [08:23:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 (owner: 10Henning Snater) [08:28:39] (03PS4) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [08:37:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 (owner: 10Henning Snater) [08:40:45] hi :) [08:40:54] * aude waves [08:41:00] * DanielK_WMDE stabs [08:41:08] err, not you, lazowik :P [08:41:43] :D [08:45:02] (03PS8) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [08:45:12] (03PS5) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [08:47:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [08:49:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 (owner: 10Henning Snater) [09:06:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 (owner: 10Henning Snater) [09:16:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [09:20:22] [13Geo] 15thiemowmde created 06private (+1 new commit): 02http://git.io/s55fcw [09:20:22] 13Geo/06private 14cb53015 15Thiemo Mättig: Private [09:20:55] [13Geo] 15thiemowmde opened pull request #18: Private (06master...06private) 02http://git.io/WsBnHg [09:25:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156505 (https://bugzilla.wikimedia.org/70081) (owner: 10Daniel Kinzler) [09:31:17] (03Abandoned) 10Daniel Kinzler: Make ungrouped output the default for getentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156505 (https://bugzilla.wikimedia.org/70081) (owner: 10Daniel Kinzler) [09:34:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [09:38:54] [13Geo] 15JeroenDeDauw closed pull request #18: Private (06master...06private) 02http://git.io/WsBnHg [09:43:39] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/165 [09:44:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 (owner: 10Henning Snater) [09:45:11] DanielK_WMDE: if you have some time, could you take a look at https://gerrit.wikimedia.org/r/#/c/154447/ ? [09:48:03] ty :D [09:48:40] (03CR) 10Jeroen De Dauw: [C: 032] Drop/replace some pointless assert() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155247 (owner: 10Thiemo Mättig (WMDE)) [09:49:36] (03CR) 10Jeroen De Dauw: [C: 032] Replace some assert() with actual code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155246 (owner: 10Thiemo Mättig (WMDE)) [09:50:01] No daily? [09:50:11] DanielK_WMDE: there's also https://gerrit.wikimedia.org/r/#/c/153541/ for the Config fallback logic that we had talked about in london if you have some more time :) [09:52:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [10:00:50] (03PS1) 10WikidataBuilder: New Wikidata Build - 27/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156515 [10:10:23] [13WikibaseDataModel] 15thiemowmde 04deleted 06clear at 146f6ff35: 02http://git.io/elD-TQ [10:10:38] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 27/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156515 (owner: 10WikidataBuilder) [10:15:52] (03PS7) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 [10:16:37] (03PS1) 10Aude: Fix EntityTitleLookup namespace in ApiHelperFactoryTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156519 [10:17:07] (03CR) 10Addshore: [C: 04-1] "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155246 (owner: 10Thiemo Mättig (WMDE)) [10:17:21] (03PS8) 10Addshore: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [10:24:21] is there a bot merging things from commons to WD? Do we have a scriprt for such things? [10:24:38] wut [10:24:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [10:24:49] sjoerddebruin: wut? hmm... :/ [10:24:59] Merging things from commons? [10:25:27] Interwikis [10:25:51] at least for the main namespace :D [10:26:06] Thiemo_WMDE: guess the PHPUnit issue I'm running into might be due to me having PHPUnit 4 and MW not liking that [10:28:20] lol, dat changelog... https://github.com/sebastianbergmann/phpunit/wiki/ChangeLog-for-PHPUnit-4.2 [10:29:15] JeroenDeDauw: i can not reproduce any of the bugs. all tests run fine. [10:29:44] Thiemo_WMDE: you did run "composer update" after you got that change right? [10:29:52] sure. [10:30:07] Thiemo_WMDE: so all tests pass for you when using DM 1.0? [10:30:08] or, ... arg. [10:31:44] me stupid. ok. 70042 is fixed by your patch. the other two fail. will look into. [10:34:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156515 (owner: 10WikidataBuilder) [10:42:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156519 (owner: 10Aude) [10:47:15] (03PS1) 10Henning Snater: Implemented jQuery.wikibase.fingerprintlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156521 [10:48:57] (03PS11) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [10:50:46] JeroenDeDauw: i give up. Claim vs. Statement. some code expects this,. oither code that, not interchangeable any more. whats going on? [10:51:23] JeroenDeDauw: look at \Wikibase\DataModel\Entity\Item::addClaim, this cant work. [10:51:56] Thiemo_WMDE: Item::addClaim now no longer accepts non-statements. This was part of the recent cleanup. I'll drop that restriction for now if we cannot comply to it easily [10:52:37] it accepts non-statements, there is no check, it just fails with that php error you get in the tests. [10:53:11] Thiemo_WMDE: the check is there in the form of adding the thing to a list that only accepts statements [10:53:17] the casting is done in the wrong direction. [10:54:01] there is no casting [10:54:51] Thiemo_WMDE: the question is if we can stop supporting addition of claims to items or not [10:55:00] I do not know how much stuff in Wikibase.git depends on it [10:55:08] I suspect the production code will not break [10:55:18] Though we might have a lot of tests that assume you can do this [10:55:26] Thiemo_WMDE: do you know? [10:55:42] why is there a addClaim if it does not accept claims? [10:56:05] migration? i'm confused again. [10:56:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [11:06:13] JeroenDeDauw: fixed one of the tests!!! [11:07:01] Thiemo_WMDE: ChageOpMergeTest is not just any test, fixing that one is extra hard [11:08:46] i fixed that [11:09:02] Thiemo_WMDE: I wonder if the tests will work if addClaim turns Claim instances it gets into Statement instances [11:10:11] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [11:10:16] (03PS7) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 [11:11:42] (03PS8) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 [11:11:52] (03CR) 10Hashar: "check experimental" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [11:14:22] the poor jobs takes a while to run :D [11:15:33] JeroenDeDauw: getClaims() { return array(); } seriously? [11:15:41] thats why the other test fails. [11:16:27] Thiemo_WMDE: it assumes all entities have claims? [11:16:33] wait... [11:16:43] This is something that I did not change recently [11:16:53] It should have failed before the statement cleanup already [11:19:51] so yes, the test expects properties support claims. [11:21:46] Thiemo_WMDE: I suspect that ssumption is not to hard to remove - correct? [11:21:53] JeroenDeDauw: this changed in 1.0. Property::getClaims returns an empty array now. [11:22:02] Thiemo_WMDE: I know [11:22:20] why is this not abstract? [11:22:31] Again, we can restore the incorrect behaviour, though it's nicer if we can already ditch it [11:22:40] addClaim just does nothing and getClaims returns array(). thats really odd. [11:23:01] Thiemo_WMDE: check out 0.9 and look at what they do [11:23:16] have it on the screen right now. [11:23:52] Thiemo_WMDE: like this Item is the only thing that does something when addClaim is called on it [11:24:25] uh, no? property does. [11:24:31] did in 0.x. [11:24:37] Yes, did [11:24:44] And that got removed [11:24:53] Since the behaviour was incorrect [11:25:04] And not used by proudction code to begin with [11:25:11] (or should not have been used) [11:26:05] i find the migration path very odd. just removing the implementation and leaving empty methods. [11:26:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [11:26:45] Thiemo_WMDE: what would you do instead? [11:26:55] good question. :( [11:30:46] Thiemo_WMDE: we could also completely ditch the stuff and implement it for properties now as well [11:31:03] Then we wont't have these weird half removed things [11:31:15] (03PS8) 10Thiemo Mättig (WMDE): [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [11:31:18] Though that'd mean adding yet another pile of stuff and breakage into 1.0 [11:31:25] I rather do this in another rel [11:31:51] what do you mean with "implement it for properties"? [11:33:02] Thiemo_WMDE: statement support [11:33:05] [13WikibaseDataModel] 15JeroenDeDauw created 06StatementListDiffer (+1 new commit): 02http://git.io/0C2HcQ [11:33:05] 13WikibaseDataModel/06StatementListDiffer 148b4ff6c 15jeroendedauw: ClaimListDiffer -> StatementListDiffer [11:33:10] I rather do this in 1.1 [11:34:28] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06StatementListDiffer from 148b4ff6c to 1458a50ae: 02http://git.io/lNfUgA [11:34:28] 13WikibaseDataModel/06StatementListDiffer 1458a50ae 15jeroendedauw: ClaimListDiffer -> StatementListDiffer [11:35:02] addClaim should at least throw an exception in 1.0. [11:35:48] Thiemo_WMDE: which addClaim? You seem to keep forgetting this thing is being overload in the inheritance hierachy [11:36:36] its not in Property::addClaim. [11:37:12] Thiemo_WMDE: you want calls to Property::addClaim to throw an exception? [11:37:20] yes [11:37:38] Fine with me, if that does not break all of the things in Wikibase.git [11:37:48] In fact, I preffer that as well, if it's doable [11:38:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [11:46:30] [13WikibaseDataModel] 15thiemowmde created 06exceptions (+1 new commit): 02http://git.io/8HNeHw [11:46:30] 13WikibaseDataModel/06exceptions 14f8dc4f8 15Thiemo Mättig: Throw Exceptions for easier migration [11:47:49] [13WikibaseDataModel] 15thiemowmde opened pull request #167: Throw Exceptions for easier migration (06master...06exceptions) 02http://git.io/JYjEOA [11:53:52] (03CR) 10Aude: "check experimental" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156519 (owner: 10Aude) [11:54:25] (03CR) 10Aude: "wow, this is great :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [11:54:43] aude: all credits / cheers should be sent to addshore :] [11:54:49] \o/ [11:58:46] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06exceptions at 14f8dc4f8: 02http://git.io/R_VU6g [11:58:58] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/iFaH0A [11:58:58] 13WikibaseDataModel/06master 14c265648 15jeroendedauw: Deprecate type hinting against Entity [11:58:58] 13WikibaseDataModel/06master 14dbe9322 15Jeroen De Dauw: Merge pull request #161 from wmde/depent... [12:03:02] (03PS1) 10Thiemo Mättig (WMDE): Make ChangeOpClaimTest compatible with DM 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156524 [12:03:23] omg, why is https://www.wikidata.org/w/index.php?title=Q4913200&diff=next&oldid=129797739 date formatted as a timestamp? [12:04:19] (03CR) 10Jeroen De Dauw: [C: 032] Make ChangeOpClaimTest compatible with DM 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156524 (owner: 10Thiemo Mättig (WMDE)) [12:05:48] Thiemo_WMDE: wondering if there is anything I can do now to further help with this [12:06:22] I'm starting to fix some tests. Mainly switching "new Claim" with "new Statement". [12:06:34] will not be able to finish this today. [12:07:07] Thiemo_WMDE DanielK_WMDE https://github.com/Wikidata-lib/PropertySuggester/pull/95 [12:09:43] (03PS9) 10Daniel Kinzler: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) [12:09:56] (03PS9) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 [12:11:59] aude: merged [12:12:03] yay [12:15:24] [13WikidataBuildResources] 15filbertkm 04deleted 06update at 14542e49f: 02http://git.io/SgH8yA [12:15:38] [13WikidataBuilder] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/YUkf8w [12:15:38] 13WikidataBuilder/06master 14ae99e0c 15Katie Filbert: Merge pull request #26 from wmde/update... [12:17:56] [13ValueView] 15jakob-WMDE created 06fix-calendar-switch (+1 new commit): 02http://git.io/jMvyXQ [12:17:56] 13ValueView/06fix-calendar-switch 14eb2f8ef 15Jakob Warkotsch: Fix calendar switch to Julian (Bug 65847). [12:18:35] [13ValueView] 15jakob-WMDE opened pull request #109: Fix calendar switch to Julian (Bug 65847). (06master...06fix-calendar-switch) 02http://git.io/RoWNRQ [12:28:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156524 (owner: 10Thiemo Mättig (WMDE)) [12:28:48] (03PS1) 10Thiemo Mättig (WMDE): Make tests compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 [12:30:10] (03CR) 10Jeroen De Dauw: [C: 032] Make tests compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 (owner: 10Thiemo Mättig (WMDE)) [12:35:33] (03PS1) 10Henning Snater: Implemented jQuery.wikibase.fingerprintgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 [12:36:50] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/pull/166 [12:37:44] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/aS2JDQ [12:37:44] 13WikibaseDataModel/06master 14935186e 15Jeroen De Dauw: Update README.md [12:38:01] (03PS10) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 [12:38:27] JeroenDeDauw: now i run into an extremely weird test. CreateClaimTest. revision ids are messed up somehow. [12:40:11] (03CR) 10Aude: [C: 032] ClaimDifferenceVisualizer code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156265 (owner: 10Thiemo Mättig (WMDE)) [12:40:18] [13WikibaseDataModel] 15thiemowmde comment on pull request #166 1458a50ae: This is not used in this file, right? 02http://git.io/9tv2tw [12:41:14] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/tMxCbA [12:41:14] 13WikibaseDataModel/06master 142185a05 15thiemowmde: Merge pull request #166 from wmde/StatementListDiffer... [12:42:33] JeroenDeDauw: the api request does not increment the revision id with DM1.0. hwo is that possible? [12:45:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a7d9ffc : Thiemo Mättig The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33690331 [12:48:21] (03PS1) 10Thiemo Mättig (WMDE): Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 [12:51:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [13:00:34] (03CR) 10Aude: [C: 032] "fixes the bug adequately" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156298 (https://bugzilla.wikimedia.org/70034) (owner: 10Daniel Kinzler) [13:00:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d740e8e : Aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33691278 [13:08:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [13:12:08] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 (owner: 10Thiemo Mättig (WMDE)) [13:15:22] (03PS5) 10Thiemo Mättig (WMDE): Replace some assert() with actual code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155246 [13:17:20] [13WikibaseDataModelJavascript] 15thiemowmde 04deleted 06refactoring at 1406936a2: 02http://git.io/4H3Y8A [13:18:20] [13WikibaseDataModelJavascript] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/u-5-gQ [13:18:20] 13WikibaseDataModelJavascript/06master 14c085c30 15thiemowmde: Update README.md [13:19:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b592445 : Aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33693161 [13:20:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix EntityTitleLookup namespace in ApiHelperFactoryTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156519 (owner: 10Aude) [13:23:44] (03PS2) 10Thiemo Mättig (WMDE): Make tests compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 [13:23:53] (03CR) 10jenkins-bot: [V: 04-1] Make tests compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 (owner: 10Thiemo Mättig (WMDE)) [13:25:28] (03PS1) 10Thiemo Mättig (WMDE): Merge "Fix EntityTitleLookup namespace in ApiHelperFactoryTest" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156530 [13:26:16] (03Abandoned) 10Thiemo Mättig (WMDE): Merge "Fix EntityTitleLookup namespace in ApiHelperFactoryTest" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156530 (owner: 10Thiemo Mättig (WMDE)) [13:28:10] (03PS3) 10Thiemo Mättig (WMDE): Make tests compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 [13:34:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156527 (owner: 10Henning Snater) [13:36:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fixed jQuery.wikibase.aliasesview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156300 (owner: 10Henning Snater) [13:39:54] (03CR) 10Jeroen De Dauw: [C: 032] Make tests compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 (owner: 10Thiemo Mättig (WMDE)) [13:40:05] (03CR) 10Jeroen De Dauw: [C: 032] Replace some assert() with actual code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155246 (owner: 10Thiemo Mättig (WMDE)) [13:40:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f69e3bf : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33694985 [13:40:18] (03CR) 10Jeroen De Dauw: "Still needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155247 (owner: 10Thiemo Mättig (WMDE)) [13:41:40] (03CR) 10Jeroen De Dauw: Make CreateClaimTest compatible with DataModel 1.0 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [13:42:09] (03PS11) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 [13:46:07] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/k-y9mQ [13:46:07] 13WikibaseDataModel/06master 14b6d9118 15jeroendedauw: Remove unused imports [13:49:58] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Changed $.fn.applyTemplate mechanics [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156306 (owner: 10Henning Snater) [13:52:58] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [13:56:38] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2270818 : Thiemo Mättig (WMDE) The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33696700 [14:03:06] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:08:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/bbb523f : Thiemo Mättig (WMDE) The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33697955 [14:12:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155246 (owner: 10Thiemo Mättig (WMDE)) [14:14:36] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] Make CreateClaimTest compatible with DataModel 1.0 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:15:08] (03PS2) 10Jeroen De Dauw: Make CreateClaimTest compatible with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:16:01] (03CR) 10Jeroen De Dauw: "If it's testing this on a property, then the property will not change, since setClaim does not do stuff there, and so the revision number " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:20:02] (03CR) 10Thiemo Mättig (WMDE): "The tests run on Items. I var_dumped the old and new Items and I can see that their Statements change. But the revision ID does not." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156528 (owner: 10Thiemo Mättig (WMDE)) [14:22:13] (03PS4) 10Thiemo Mättig (WMDE): Drop/replace some pointless assert() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155247 [14:24:43] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/b5NGHQ [14:24:43] 13Wikiba.se/06master 146200c6c 15Jeroen De Dauw: Update components.html [14:27:18] [13Wikiba.se] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/C0dsjQ [14:27:18] 13Wikiba.se/06master 14f9ad2b0 15Jeroen De Dauw: Update projects.html [14:29:50] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f8913a8 : Jeroen De Dauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33700549 [14:32:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 (owner: 10Thiemo Mättig (WMDE)) [14:40:20] (03PS1) 10Aude: New deployment build, mw1.24-wmf19 [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/156541 [14:44:36] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156530 (owner: 10Thiemo Mättig (WMDE)) [14:45:37] (03PS1) 10Aude: New Wikidata Build - 27/08/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 [14:46:08] (03Abandoned) 10Aude: New Wikidata Build - 27/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156515 (owner: 10WikidataBuilder) [14:49:04] I am going to enable the Jenkins jobs for Wikibase repo, following up all addshore efforts [14:49:08] change is https://gerrit.wikimedia.org/r/#/c/156270/ :D [14:49:10] [= [14:49:39] yay! [14:49:55] aude: so the tests looks like they generally run 5 mins faster now [14:50:07] amd also we have 2 nodes executing them :) [14:50:08] :D [14:50:09] *and [14:50:18] so we can run 2 of each job at a time :D [14:50:25] * aude owes beers to addshore [14:50:31] for making jenkins awesome [14:50:41] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 27/08/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 (owner: 10Aude) [14:50:46] oh noes [14:51:11] my fault [14:51:36] deployed :D [14:51:50] restarting Zuul [14:52:21] * DanielK_WMDE sings ghost busters theme [14:52:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf19/f8913a8 : Jeroen De Dauw The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33701007 [14:53:01] disabled the jobs for wikibase repo on wdjenkins [14:54:09] :) [14:54:29] should be good now [14:54:38] not sure of jjbc will override that, dont know how to disbale other than to totally remove, [14:54:48] but guess there is no harm in totally removing from jjbc [14:55:45] (03PS9) 10Addshore: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [14:55:51] lets see :> [14:56:10] (03PS1) 10Henning Snater: Integrated fingerprintgroupview into entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156548 [14:56:15] it still run the old jobs in check-only bah [14:56:40] :> [14:56:56] silly zuul [14:57:07] silly me [14:57:15] that should be an integration test on zuul-config [14:57:21] addshore: fix up for review https://gerrit.wikimedia.org/r/156549 [14:57:34] check-voter is always triggered [14:57:39] ahhhh! [14:57:47] 'check' is the antinomy of 'test' [14:58:52] deployed :D [14:59:11] (03PS10) 10Addshore: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [14:59:12] \o/ [14:59:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156526 (owner: 10Thiemo Mättig (WMDE)) [15:00:06] https://integration.wikimedia.org/ci/label/Wikidata/. [15:00:24] hashar: can you delete the accidental mwext-Wikibase-wikibase-client-tests-tests ? [15:00:36] yeah [15:00:51] also aude our jobs now appear on https://integration.wikimedia.org/zuul/ again :D [15:01:06] \O/ [15:01:08] :) [15:01:28] so hashar how can we make 2 of the same jobs run on different nodes? they dont seem to be currently :/ [15:01:39] -1 for composer cloning whole repos though https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-api-tests/11/consoleFull [15:01:39] :D [15:02:06] you have them run concurrently with concurrent: true [15:02:23] if you want at most 1 job per instance, that is slightly more complicated [15:02:38] you need to use the 'throttle' plugin [15:02:52] thats the next task then xD [15:02:59] hopefully your jobs can run concurrently on the same node [15:03:16] Jenkins creates workspaces to "isolate" them. So for 'foobar', the first job run in /foobar/ [15:03:18] now wit the workspace currently being the same [15:03:21] the second one in /foobar@2/ [15:03:23] and so on [15:03:36] ahh, so workspace and sqlite dbs wont conflict at all with the current setup? [15:03:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/156541 (owner: 10Aude) [15:03:55] addshore: if your jenkins job use $WORKSPACE everywhere yeah [15:04:05] Will have to check quickly :P [15:04:25] make sure the sqlite database name vary as well [15:04:46] dont think the sqlite database name does currently [15:04:49] by build name / build number [15:05:02] or you might end up with two jobs hitting both /tmp/mw.sqlite :-D [15:05:09] :> [15:06:36] php maintenance/install.php ... --dbtype=sqlite --dbname=build11 --dbpath=/mnt/jenkins-workspace/workspace/mwext-Wikibase-repo-api-tests/data [15:06:38] so that vary by job name and the dbname is the build # [15:06:38] so that is all good [15:06:47] +1 on reusing the crazy macro I wrote in jjb :D [15:06:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 (owner: 10Aude) [15:07:06] oh yeh, Im using that already :P [15:07:15] so just concurrent: true on the job-template and that should work [15:07:20] :> [15:07:44] [13jenkins-job-builder-config] 15addshore pushed 1 new commit to 06master: 02http://git.io/IriafA [15:07:44] 13jenkins-job-builder-config/06master 14754866f 15addshore: Wikibase jobs are now on wmf jenkins [15:08:06] brb nature's call [15:10:01] https://gerrit.wikimedia.org/r/#/c/156551/ for concurrnet jobs [15:11:14] Lydia_WMDE: https://www.mediawiki.org/wiki/Talk:Beta_Features/Other_projects_sidebar if you can keep watch please [15:11:50] Thiemo_WMDE: Tobi_WMDE_SWE Henning_WMDE do the qunit jobs depend on stuff pulled in by composer? [15:11:56] deployed! [15:12:03] addshore: probably [15:21:50] are there different quint jobs for repo and client aude ? [15:22:05] *qunit [15:23:28] no clue [15:23:32] addshore: Yes, they do... which is a pitty, of course. [15:23:56] For example, all the valueview tests are run via the MediaWiki QUnit test runner. [15:24:07] ahh they are all in lib! [15:24:25] Yes, all in lib - where everything should be [15:24:32] ;D [15:26:45] Henning_WMDE: thats okay, lets see how jenkins handles it ;p [15:33:28] Henning_WMDE: do the qunit tests need Scribunto ?:P [15:35:46] addshore: i hope not [15:35:51] :P [15:36:56] :D [15:39:55] (03PS2) 10Aude: New Wikidata build - 27/08/2014 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 [15:41:51] Not as far as I now. [15:41:51] know [15:45:37] Hallo Lydia_WMDE [15:45:47] hey aharoni [15:46:12] Is there some kind of a guide about what a given Wikipedia community should do to migrate the featured articles badges to Wikidata? [15:47:10] aharoni: give amir's bot approval and that's all [15:47:23] O RLY [15:47:26] Is that all? [15:47:30] jep [15:47:41] Sounds very easy. [15:47:43] Thanks. [15:47:45] :D [15:49:52] Lydia_WMDE: That covers the first conversion step. Now, when a new article will become featured in the Hebrew Wikipedia, how will it be added to the list? Will it be a property of the corresponding item? [15:50:12] it is attached to the sitelink [15:50:16] hashar_: a handfull of more changes up for you ;p [15:50:18] look at the item on berlin for example [15:50:27] in the wikipedia section at the bottom [15:50:32] i think amir1 is done [15:50:44] Ah, Berlin, the quintessential example for semantic data :) [15:50:47] all are imported [15:50:57] aharoni: :P exactly [15:50:57] not yet removed from the clients [15:51:23] Hi all. Who works on related projects block in the sidebar? I know that hoo did it, but I didn't see him for several days. [15:51:54] putnik: Tpt [15:52:22] Lydia_WMDE: looks very simple. [15:52:24] Thank you. [15:52:24] (03CR) 10Aude: [C: 032] "wikidata jenkins is broken and disqualified ;)" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/156541 (owner: 10Aude) [15:52:37] (03CR) 10Aude: [C: 032] "to beta!" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 (owner: 10Aude) [15:53:05] And the next obvious question is how to prevent vandalism - people adding and removing these badges to articles against the community's will. [15:53:20] Lydia_WMDE, is he on this channel? [15:53:24] (03CR) 10Aude: New deployment build, mw1.24-wmf19 [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/156541 (owner: 10Aude) [15:53:43] putnik: no. what do you need? :) [15:53:56] Lydia_WMDE, Wikinews =) [15:54:17] aharoni: we need checks against the badge that is kept in the article i'd say (in the article that is actually featured) [15:54:31] putnik: ah you mean because of categories? [15:54:42] lol aude, disqualified! [15:54:45] :) [15:55:00] Lydia_WMDE: "kept in the article"? Do you mean that the featured article itself should still have a template? [15:55:11] aharoni: for now at least yes [15:55:16] O I C [15:55:21] (03PS2) 10Aude: New deployment build, mw1.24-wmf19 [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/156541 [15:55:35] OK, so I don't expect any resistance from he.wiki community, but of course there are always surprises :) [15:55:53] putnik: if it is about that i am the person to talk to. it is on my radar but not solved yet. needs more thought and work. [15:56:05] also i need to run in a minute [15:56:32] Lydia_WMDE, oh, I don't really want to get into a dispute about how they should linked. I just want to see Wikinews pages/categories if they already linked. [15:57:01] putnik: yeah [15:57:34] ok time to leave [15:57:37] back in 45 mins or so [15:58:20] aude: will try and add jobs for the build now [15:58:29] ok [16:00:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "* The blue background behind the top description input (when in edit mode) is missing now. Is this intended? I found it helpful but it's n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [16:02:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 (owner: 10Aude) [16:02:24] go away wikidata jenkins! [16:02:53] LEROOOOOOOOY [16:03:11] harej :) [16:06:15] (03PS1) 10Henning Snater: Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 [16:06:20] (03CR) 10Aude: [V: 032] "verified by wmf jenkins" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156545 (owner: 10Aude) [16:13:10] (03CR) 10jenkins-bot: [V: 04-1] Added aliasesview to fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156565 (owner: 10Henning Snater) [16:19:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf19) - 10https://gerrit.wikimedia.org/r/156541 (owner: 10Aude) [16:30:31] (03PS12) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [16:31:24] (03PS17) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [16:35:26] (03PS18) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [16:37:04] I can't edit with my user account... [16:37:10]