[04:46:29] (03PS1) 10Hoo man: Remove a MW 1.23 b/c leftover in ClientHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156241 [04:48:06] (03Abandoned) 10Hoo man: Remove a MW 1.23 b/c leftover in ClientHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156241 (owner: 10Hoo man) [04:48:53] (03CR) 10Hoo man: [C: 032] Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156123 (owner: 10Thiemo Mättig (WMDE)) [05:01:12] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156241 (owner: 10Hoo man) [05:11:28] (03PS9) 10Aude: Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 [05:11:36] aude: You awake? [05:11:38] oO [05:11:40] (03CR) 10jenkins-bot: [V: 04-1] Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [05:11:48] rage [05:11:54] moin! [05:12:10] aude: Well, not really... going to bed soonish, I guess [05:12:19] You aware of Travis being broken? [05:12:31] it was fixed ?! [05:12:50] No, it's broken right now [05:12:53] DiffViewTest [05:13:02] but it's almost certainly not related to my changes [05:13:04] aaaah [05:13:10] we had that before [05:13:12] but I'm not sure what it's caused by [05:13:14] then it disappeared [05:13:22] thought it was fixed :/ [05:13:25] maybe something is messing with contexts or language stuff [05:13:28] yep [05:13:56] dear somebody, fix the Germany :-) [05:14:24] FingerPrintViewTest looks suspicious as it was introduced at the time DiffViewTest started breaking and it does awry stuff to MessageCache [05:14:27] hi vlsergey :) [05:14:30] seems to start with https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/cfca74db3ecd9931eabd6768b07744763b62b76a [05:14:41] fingerprint [05:14:42] vlsergey: I'm not in Germany... If I were, I'd probably not be awake atm [05:15:24] wel... it means "fix the problem with Germany entity", not "with Germany timezone" :-) [05:15:44] aude: Yep... but can't reproduce locally on a russian wiki [05:16:02] (and yes, the Fingerprint stuffs is running there before the diff view things) [05:17:42] shall look later, after getting deployment stuffs ready etc [05:17:59] aude: What's being deployed? [05:18:05] serializaiton [05:18:09] beta feature [05:18:10] ah [05:18:13] backport? [05:18:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [05:18:33] badges on the clients (except wikipedia, which is thursday) [05:18:42] no backport [05:18:54] ah ok [05:19:04] but new build, with property suggester changes and badges stuff [05:19:09] You in the US also or just up early? [05:19:14] ah, and new property suggester code [05:19:32] not that early :) [05:19:57] mh... want to put the badges history link fix and your dump json fix into the build maybe? [05:21:07] (03PS10) 10Aude: Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 [05:21:07] dump json no [05:21:16] ok [05:21:29] if it's not threat to production json dumps that's ok [05:21:31] that happens only because of abusing my database [05:21:33] * not a [05:21:37] or something bad in wikidata [05:21:38] ah [05:21:46] fortunatley not happened yet [05:25:03] ah, I see :) [05:25:10] Going to explore DC tomorrow [05:25:15] yay [05:25:18] well, today [05:26:54] * aude recommends Q5546987 :) [05:33:01] aude: :) I planned to be very close to that... so that's certainly something I'll take into account [05:33:15] cool [05:33:20] Just 50m away from the route I planned to take :P [05:33:26] * hoo stays at Arlington [05:33:39] nice [05:34:25] Q1192305 is my favorite museum [05:34:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [05:35:02] (03CR) 10Aude: "rebased properly" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [05:35:10] (03PS5) 10Aude: Move EntityPermissionChecker and EntityContentFactory into namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155904 [05:36:35] I only have 2 days here, so probably not going to find time for that (yet) [05:37:19] :( [05:37:45] * aude has to organize hackathon so you can come back [05:38:06] That would awesome :) [05:38:22] the chapter definitely wants to [05:39:06] Are you still in the board? [05:39:24] no [05:42:21] Hackathon in DC would be awesome... and give me more time to see more details of the City [05:44:04] only issue is we can't do european hackathon [05:44:34] and there will be something in sf in january [05:44:39] Yeah, obviously :D [05:44:56] ... I heard of that, not sure I'll be able to attend, though (University stuffs) [05:45:05] :/ [05:46:12] Anyway... good night [05:46:21] nacht [05:46:24] Want to get up early tomorrow to use my time :) [05:46:29] sure [05:46:39] * aude eat [05:46:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155904 (owner: 10Aude) [05:51:23] (03CR) 10Aude: [C: 032] Add build/jenkins/mw-apply-wb-settings.sh [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156165 (owner: 10Addshore) [05:53:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155904 (owner: 10Aude) [06:04:03] (03PS14) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [06:07:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/70fe157 : Aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33557979 [06:17:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [07:54:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [07:57:37] (03PS17) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [08:06:19] (03PS4) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [08:06:33] (03CR) 10jenkins-bot: [V: 04-1] Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [08:08:30] (03PS18) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [08:15:26] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4e0e8c0 : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33565216 [08:21:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [08:29:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 (owner: 10Henning Snater) [08:30:43] Any ETA for the deploy of today? [08:37:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:12:38] (03PS19) 10Thiemo Mättig (WMDE): Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:12:45] (03CR) 10jenkins-bot: [V: 04-1] Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:13:40] sjoerddebruin: as always late evening in europe :) [09:13:48] :( [09:13:51] (03CR) 10Thiemo Mättig (WMDE): Implemented jQuery.wikibase.aliasesview (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:18:53] Abraham_WMDE: grats at moving the meeting twice (so far that is) ;p [09:20:19] [13WikidataBrowserTests] 15tobijat closed pull request #5: Adapt to implementation of sitelinkgroup (06master...06sitelinkgroupview) 02http://git.io/XPcy-g [09:22:28] (03PS20) 10Thiemo Mättig (WMDE): Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:23:01] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 060.9.x-remove-getType: 02http://git.io/DQoNHg [09:23:01] 13WikibaseDataModel/060.9.x-remove-getType 14d0494ca 15Jeroen De Dauw: Update RELEASE-NOTES.md [09:25:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:30:42] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [09:30:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:31:43] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #159: 0.9.x remove get type (060.9.x...060.9.x-remove-getType) 02http://git.io/ritFAQ [09:31:53] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 060.9.x-remove-getType at 14d0494ca: 02http://git.io/URPy4A [09:36:15] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 060.9.1-master-releasenotes: 02http://git.io/lQCpEA [09:36:15] 13WikibaseDataModel/060.9.1-master-releasenotes 14e8a06b7 15jeroendedauw: Update realase notes [09:36:39] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/D6gREw [09:36:39] 13WikibaseDataModel/06master 14811e2d7 15Jeroen De Dauw: Merge pull request #160 from wmde/0.9.1-master-releasenotes... [09:37:48] [travis-ci] wmde/WikibaseDataModel/0.9.1-master-releasenotes/e8a06b7 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/33571983 [09:37:51] [13WikibaseDataModel] 15JeroenDeDauw created 06lolwat (+1 new commit): 02http://git.io/danCoA [09:37:51] 13WikibaseDataModel/06lolwat 14bebaec3 15jeroendedauw: Merge branch 'master' of github.com:wmde/WikibaseDataModel [09:38:26] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06lolwat at 14bebaec3: 02http://git.io/GKn05Q [09:39:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:41:14] [13WikibaseDataModel] 15JeroenDeDauw tagged 060.9.1 at 060.9.x: 02http://git.io/Y-VaJg [09:44:30] [travis-ci] wmde/WikibaseDataModel/lolwat/bebaec3 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/33572103 [09:44:49] [travis-ci] wmde/WikibaseDataModel/0.9.1/ee8c720 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33572311 [09:56:13] (03PS6) 10Thiemo Mättig (WMDE): Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [09:56:27] (03PS7) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [09:59:27] Lydia_WMDE: benestar|cloud: Hey, have you seen this: https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Bot/Statut#Dexbot [10:00:30] They say Link FA and Link GA shouldn't be removed since they populate categories by that [10:00:34] (03PS1) 10WikidataBuilder: New Wikidata Build - 26/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156255 [10:00:53] (03PS8) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [10:01:03] Amir1: fine with me if they keep it really [10:01:58] I was thinking about a way to implement it with Lua [10:02:20] hey Lydia_WMDE! [10:02:29] hey DanielK_WMDE [10:02:43] your desk is sad and empty :/ [10:02:57] DanielK_WMDE: i no! :D [10:03:00] i will be back tomorrow [10:03:15] no opensym tomorrow? i have to look at the schedule... [10:03:20] btw: Can someone give me a translation of "Bot: Removing %s since the badge(s) are already in Wikidata" into German? [10:03:42] DanielK_WMDE: no i checked the schedule and considering that we still have to do the talk... [10:04:02] Amir1: i don't know what term folks use for "badge" in german... [10:04:13] Lydia_WMDE: yea [10:05:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [10:05:44] DanielK_WMDE: Let me check [10:07:56] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move EntityPermissionChecker and EntityContentFactory into namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155904 (owner: 10Aude) [10:10:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/78fa6ae : Henning Snater The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33573285 [10:12:46] DanielK_WMDE: I couldn't find anything in several pages but I think they mentioned it somewhere in https://www.wikidata.org/wiki/Wikidata:Forum [10:13:30] Amir1: i would ask benestar|cloud [10:13:53] aude: thanks [10:13:56] Amir1: "Auszeichnung". Hm. [10:14:33] is there a page to link to in the edit summary? [10:14:37] that explains more? [10:14:49] it's an edit summary [10:14:53] Amir1: "Bot: entferne %s da die Auszeichnungen bereits in Wikidata sind". [10:15:05] i remember the bots removing interwikis linked to something [10:15:12] DanielK_WMDE: Thank you :) [10:15:14] Amir1: that's plural. I see no obvious way to cover both singular and plural in German. [10:15:36] no problem [10:15:54] aude: I can link to a help in Wikidata [10:16:03] would be good [10:16:39] (03PS7) 10Henning Snater: Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 [10:16:43] oh hey aude DanielK_WMDE JeroenDeDauw Thiemo_WMDE Tobi_WMDE_SWE etc :) [10:16:57] good news is that today we can switch our jenkins back to wmf stuff :) [10:16:58] hey adam! [10:17:01] it's addshore, mkaing jenkins awesome! [10:17:07] \o/ [10:17:08] aude: already done :) [10:17:13] :D [10:17:27] so you are working for us again? yay! ;) [10:17:30] addshore: when do we want to try this? [10:18:11] Tobi_WMDE_SWE: already tried, will just wait for hashar to come around so we can deoply some stuff his side properly, then just need to turn of the wikibase bit for wdjenkins [10:18:22] addshore: if you can do nit without us, probably 14-16 would be best as we're having a meeting there and no new patches should pop up [10:18:34] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156086 (owner: 10Aude) [10:18:38] :) [10:18:39] sure [10:18:58] if that would solve MW_INSTALL_PATH issue, would be even more awesome [10:19:06] it will ;p [10:19:10] \o/ [10:19:20] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [10:20:34] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/156086/ [10:20:37] aaas [10:20:44] https://www.wikidata.org/wiki/Property:P968 [10:21:02] Tobi_WMDE_SWE: aude where should I write the docs for out jenkins slaves? [10:21:20] where are the wmf docs? [10:21:32] addshore: do we still need puppet-jenkins then? [10:21:35] Well, I could write it on https://wikitech.wikimedia.org/wiki/Nova_Resource:Wikidata-dev [10:21:47] Tobi_WMDE_SWE: no, we no longer need out puppet-jenkins stuff [10:21:51] ok [10:22:06] and we wont need our jenkins-job-builder-config stuff as it is maintained in the gerrit repo again [10:22:20] we do use puppet-composer! [10:22:28] addshore: that page is a mess [10:22:40] suppose we can erase everything and replace it with new docs [10:22:44] addshore: aude: what about putting it as suppage of https://www.mediawiki.org/wiki/Wikibase [10:22:50] aude: lets do that then ;p [10:22:55] Tobi_WMDE_SWE: sounds good [10:23:13] / integration? [10:23:20] sure [10:23:43] addshore: https://www.mediawiki.org/wiki/Wikibase/Programmer%27s_guide_to_Wikibase#Testing [10:23:56] you could add a new chapter integration there [10:24:02] https://www.mediawiki.org/wiki/Wikibase/Programmer%27s_guide_to_Wikibase#Integration [10:24:16] yup :) [10:24:57] Jakob_WMDE is currently working on a new design of the website. we need to see how we structure it best then. but for now, good to have it there [10:25:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/75abe3c : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33573826 [10:25:32] Tobi_WMDE_SWE: wonder if the scope of these jenkins slaves would suite the wikidata-build project on wikitech more than wikidata-dev [10:26:18] addshore: hm.. don't know [10:26:27] * aude doesn't care [10:26:32] wikidata-build probably has more resources [10:26:35] Cant currently make anything new on -dev again as we hit some resource limit [10:26:36] yup [10:26:46] I'll move then both to -build :) [10:26:50] ok [10:26:56] ok [10:26:56] and just leave the old wdjenkins on -dev :) [10:27:12] k [10:28:03] (03CR) 10Aude: [C: 032] New Wikidata Build - 26/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156255 (owner: 10WikidataBuilder) [10:30:03] addshore: where did you see this DM fatal error? [10:30:18] JeroenDeDauw: in irc last night *scrolls up* [10:30:37] Can't inherit abstract function Wikibase\\DataModel\\Entity\\EntityDocument::getType() (previously declared abstract in Wikibase\\DataModel\\Entity\\Entity) in /var/www/html/mediawiki-1.24-snapshot-20140825/extensions/Wikibase/vendor/wikibase/data-model/src/Entity/Entity.php on line 34 [10:30:53] yeah sure, but how do you run into this? [10:30:54] sent by jayvdb [10:31:02] Neither the tests or our production system had this [10:31:08] And they definitly execute the code path [10:32:19] thats what I initially though, weather it is some odd version of php? [10:32:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [10:33:45] maybe yes [10:37:35] (03CR) 10Daniel Kinzler: [C: 04-1] Record usage of commons media files (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155896 (owner: 10Bene) [10:37:47] (03Merged) 10jenkins-bot: New Wikidata Build - 26/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156255 (owner: 10WikidataBuilder) [10:39:16] (03CR) 10Aude: [C: 032] "tests pass on wmf jenkins (wikidata jenkins is broken)" [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156086 (owner: 10Aude) [10:39:21] * aude waste no more time on that [10:44:16] :> [10:44:35] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156255 (owner: 10WikidataBuilder) [10:46:28] [13WikidataBrowserTests] 15snaterlicious created 06descriptionview (+1 new commit): 02http://git.io/JZyL4Q [10:46:28] 13WikidataBrowserTests/06descriptionview 145bcff56 15snaterlicious: Adapt to implementation of descriptionview [10:47:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [10:47:15] [13WikidataBrowserTests] 15snaterlicious opened pull request #7: Adapt to implementation of descriptionview (06master...06descriptionview) 02http://git.io/oiVTQA [10:47:35] [13puppet-composer] 15addshore pushed 1 new commit to 06master: 02http://git.io/6yuyXQ [10:47:35] 13puppet-composer/06master 14bdf3731 15addshore: Add Usage section [10:48:41] (03Merged) 10jenkins-bot: New build, update PropertySuggester and add WikimediaBadges [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156086 (owner: 10Aude) [10:55:29] Lydia_WMDE: have we communicated to the people maintaining the lua modules on wikidata? [10:55:32] about the switch [10:55:37] are they ready? [10:55:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [10:55:53] aude: it was in my announcement that lua modules will break [10:55:58] hmmm [10:58:19] (03CR) 10Daniel Kinzler: "Please do not use base classes to provide utility functions. Imagine you have a test that needs entities (and thus could derive from some " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 (owner: 10Bene) [10:59:12] (03CR) 10Daniel Kinzler: [C: 04-1] Introduce HtmlGeneratorTestCase to validate HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 (owner: 10Bene) [10:59:42] looks like we have some new lua modules already [11:00:26] legacy ones probably will be updated quickly [11:05:13] wtf, why is http://dumps.wikimedia.org/ 403 error? [11:05:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [11:05:32] aude: it isnt for me :P [11:05:40] oh, really [11:06:00] maybe it works in firefox [11:06:08] aka proxy [11:06:13] :> [11:06:16] broken here [11:06:19] it does! [11:06:26] o_O [11:07:40] (03PS9) 10Thiemo Mättig (WMDE): Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [11:08:04] asking ops [11:09:12] Meanwhile on a talk page "CAN ANYBODY HELP ME PLEASEEEE" [11:10:03] (03CR) 10Daniel Kinzler: "@thiemo: Our app-scope top-level factory has grown huge and messy, it seems high time to split it up. getSerializerFactory() should be pub" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [11:10:25] (03PS3) 10Daniel Kinzler: Introducing ApiHelperFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 [11:10:31] Thiemo_WMDE: --^ [11:10:40] (03PS5) 10Daniel Kinzler: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) [11:11:55] (03PS12) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [11:13:06] (03PS13) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [11:13:20] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Introducing ApiHelperFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [11:13:33] \o/ [11:14:41] (03Abandoned) 10Daniel Kinzler: Simplified MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 (owner: 10Daniel Kinzler) [11:19:04] (03CR) 10Henning Snater: [C: 031] Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [11:21:46] Tobi_WMDE_SWE: Whenever you have a time slot for running tests, please test and merge https://gerrit.wikimedia.org/r/#/c/151854/ [11:22:12] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/156255 (owner: 10WikidataBuilder) [11:25:27] (03CR) 10Addshore: [C: 04-1] Introducing MergeItemsInteractor (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [11:30:04] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/GY2KQw [11:30:04] 13WikidataBrowserTests/06master 147ffa16a 15Tobi Gritschacher: Merge pull request #6 from wmde/aliasesview... [11:30:25] (03CR) 10Daniel Kinzler: Introducing MergeItemsInteractor (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [11:30:30] addshore: --^ [11:32:22] (03CR) 10Addshore: Introducing MergeItemsInteractor (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [11:33:43] (03CR) 10Daniel Kinzler: Introducing MergeItemsInteractor (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [11:35:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [11:39:03] (03PS10) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [11:41:29] (03CR) 10Addshore: [C: 04-1] Add ApiConventionsTest (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:48:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [11:48:59] (03CR) 10Addshore: [C: 031] Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [11:58:20] (03PS1) 10Thiemo Mättig (WMDE): ClaimDifferenceVisualizer code cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156265 [11:58:28] (03PS4) 10Daniel Kinzler: Introducing ApiHelperFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 [11:58:38] Thiemo_WMDE: would you +2 again? --^ [11:59:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [11:59:22] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Introducing ApiHelperFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [12:00:26] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "1 + 1 + 1 = 3, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [12:02:30] hashar_: :P [12:06:10] addshore: good afternoon [12:06:20] addshore: took the morning off (had plenty of stuff to do) [12:06:34] addshore: how is the Jenkins going on on wikidata repo? :D [12:07:37] well, I have made 2 new fresh instances to be jenkins slaves on a different project :) [12:07:54] puppet is just about to finish running on them, and I'll give you the details for them [12:08:14] and then as far as I can tell we are ready to turn it on once youve looked at your comment on https://gerrit.wikimedia.org/r/#/c/156170/ =] [12:10:15] addshore: quantum +1 ? https://github.com/wmde/WikidataBuilder/pull/26 [12:11:41] JeroenDeDauw: I'll let someone else merge it ;p [12:11:57] hashar: sent you an email =] [12:16:36] addshore: gotta migrate some job first [12:17:07] ah moar slaves [12:18:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [12:21:22] addshore: I can't ssh to the new instances wikidata-jenkins{1,2} from gallium as user jenkins-deploy [12:21:30] hmmm [12:21:30] addshore: seems some puppet manifest is not applied maybe [12:22:04] role::ci::slave::labs is on both [12:22:17] oh wait, I need to add the user to the project again! [12:22:26] these instances are on a different project! [12:22:52] {{done}} [12:26:42] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [12:29:17] Slave successfully connected and online [12:29:17] ! [12:29:42] addshore: may I delete yesterday slave? [12:29:47] yup [12:34:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [12:42:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156265 (owner: 10Thiemo Mättig (WMDE)) [12:46:50] Tobi_WMDE_SWE: guess We can move the wikibase-build-client-tests etc to the wmf one too? [12:46:58] they just test the Wikidata repo right? [12:48:00] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/tFpcow [12:48:00] 13WikibaseDataModel/06master 14672e323 15thiemowmde: Merge pull request #158 from wmde/statement... [12:50:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [12:51:18] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/60LsCw [12:51:18] 13WikibaseDataModel/06master 14b5e0008 15jeroendedauw: Remove not needed FQN [12:54:25] [13github-hook-updater] 15addshore pushed 1 new commit to 06master: 02http://git.io/qXQ2-w [12:54:25] 13github-hook-updater/06master 14929a7df 15addshore: Add new repos (and fix order) [13:00:38] [13WikibaseDataModel] 15JeroenDeDauw created 06depdiff (+1 new commit): 02http://git.io/2uHbAA [13:00:38] 13WikibaseDataModel/06depdiff 14ca2f407 15jeroendedauw: Deprecate Entity::getDiff [13:03:20] [13WikibaseDataModel] 15JeroenDeDauw created 06depent (+1 new commit): 02http://git.io/kpg_5g [13:03:20] 13WikibaseDataModel/06depent 14c265648 15jeroendedauw: Deprecate type hinting against Entity [13:03:30] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #162: Deprecate Entity::getDiff (06master...06depdiff) 02http://git.io/R6iXJQ [13:03:35] [travis-ci] wmde/WikibaseDataModel/depdiff/ca2f407 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33586409 [13:09:33] [travis-ci] wmde/WikibaseDataModel/depent/c265648 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33586626 [13:11:34] [13github-hook-updater] 15addshore pushed 1 new commit to 06master: 02http://git.io/GQXb0A [13:11:34] 13github-hook-updater/06master 14a8da788 15addshore: Add some output for the script [13:11:52] JeroenDeDauw: would be great if you could pull the above and run run.php :) so we get all the repos on github reporting here again! [13:27:52] (03PS6) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [13:28:03] (03CR) 10jenkins-bot: [V: 04-1] Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [13:28:09] (03PS14) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [13:38:17] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=70034 [13:45:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [13:47:32] Finish implementing order agnostic comparison, realize the list is actually ordered [13:47:33] >_> [13:47:35] #fail [13:50:48] [13WikibaseDataModel] 15JeroenDeDauw created 06statementlist (+1 new commit): 02http://git.io/DyFbFg [13:50:48] 13WikibaseDataModel/06statementlist 14824db3c 15jeroendedauw: Make StatementList Comparable and Countable [13:51:03] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #163: Make StatementList Comparable and Countable (06master...06statementlist) 02http://git.io/PaqgMw [13:53:41] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [13:55:24] Does Magnus Manske use IRC? [13:55:34] Sometimes... [13:55:47] Twitter is a good option to try. [13:55:48] [travis-ci] wmde/WikibaseDataModel/statementlist/824db3c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33591237 [13:58:23] (03PS15) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [14:02:28] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06statementlist: 02http://git.io/6BWkpg [14:02:28] 13WikibaseDataModel/06statementlist 14181e35d 15jeroendedauw: Have Item use StatementList [14:03:11] Thiemo_WMDE: are you working from home or what? [14:03:34] !nyan | Abraham_WMDE [14:03:34] Abraham_WMDE: ~=[,,_,,]:3 [14:13:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [14:15:12] (03PS6) 10Daniel Kinzler: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) [14:16:47] Tobi_WMDE_SWE: https://gerrit.wikimedia.org/r/#/c/153714/ [14:18:11] addshore: they are testing the Wikidata.git thing, yes. guess we can move them [14:18:19] sorry for the delay.. [14:18:48] we already test wikidata.git in wmf jenkins [14:18:57] but it does everything together in one job [14:19:03] can have more, perhaps [14:19:11] (03PS5) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 [14:19:52] aude: yep we can :) [14:24:46] no haz rollback on wikidata? [14:25:36] uh? [14:25:54] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=70034 [14:25:58] do you want to fix? [14:26:23] eek. yea. [14:26:32] can easily be fixed ugly way [14:26:37] or be done nice [14:26:47] let me have a look [14:26:52] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06statementlist: 02http://git.io/YvkQJA [14:26:52] 13WikibaseDataModel/06statementlist 14b00ada5 15jeroendedauw: Add Item::setStatements [14:27:37] aude: getEntityRevision should trigger an error page if the id refers to a redirect [14:27:42] that should do the trick, no? [14:27:46] sure [14:28:47] actually - there should be code to handle StorageExceptions anyway... i guess that's missing compeltely [14:30:42] [13WikibaseDataModel] 15JeroenDeDauw created 06Claims (+1 new commit): 02http://git.io/QHZ26g [14:30:42] 13WikibaseDataModel/06Claims 14795eb4f 15jeroendedauw: Deprecate Claims class... [14:32:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [14:34:03] [13WikibaseDataModel] 15tobijat 04deleted 06statementlist at 14b00ada5: 02http://git.io/Qo3Azw [14:35:39] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/-eRuRA [14:35:39] 13WikibaseDataModel/06master 141f52b1e 15Jeroen De Dauw: Merge pull request #162 from wmde/depdiff... [14:36:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [14:36:54] (03PS16) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [14:37:46] aude: {{done}} [14:38:01] wow, super quick :) [14:38:05] [13WikidataBrowserTests] 15snaterlicious created 06labelview (+1 new commit): 02http://git.io/0mYm7A [14:38:05] 13WikidataBrowserTests/06labelview 14cac30d5 15snaterlicious: Adapt to implementation of labelview [14:38:31] [travis-ci] wmde/WikibaseDataModel/Claims/795eb4f : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33595441 [14:38:32] * aude was wondering if it was a bug that there was no rollback [14:38:35] [13WikidataBrowserTests] 15snaterlicious opened pull request #8: Adapt to implementation of labelview (06master...06labelview) 02http://git.io/oDnMVA [14:38:54] aude: you were just lucky to a) to request it while I was looking at a feed of that page and b) be known to me :) [14:38:59] heh [14:41:45] [13WikibaseDataModel] 15JeroenDeDauw pushed 3 new commits to 06master: 02http://git.io/i4mhuQ [14:41:45] 13WikibaseDataModel/06master 14a76d09c 15jeroendedauw: Improve deprecation doc formatting [14:41:45] 13WikibaseDataModel/06master 14fbde409 15jeroendedauw: Add deprecations from #163 [14:41:45] 13WikibaseDataModel/06master 1424023c6 15jeroendedauw: Add additions from #163 [14:42:22] Tobi_WMDE_SWE: https://gerrit.wikimedia.org/r/#/c/153714/ [14:43:59] Tobi_WMDE_SWE: https://github.com/wmde/WikibaseDataModel/pull/165 [14:44:01] [13WikibaseDataModel] 15JeroenDeDauw created 06clear (+1 new commit): 02http://git.io/IlKcow [14:44:01] 13WikibaseDataModel/06clear 146f6ff35 15jeroendedauw: Fix bug in clear method introduced in last change [14:44:11] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #165: Fix bug in clear method introduced in last change (06master...06clear) 02http://git.io/bPyoWA [14:47:02] JeroenDeDauw: want to update the github hooks for irc notifications? :) [14:47:07] JeroenDeDauw: https://github.com/wmde/github-hook-updater :) [14:48:53] addshore: ok, just verified there is no "if ( machine of jeroen ) { nyan nyan nyan }" [14:48:58] :> [14:49:00] JeroenDeDauw: see the blockers: https://bugzilla.wikimedia.org/show_bug.cgi?id=70039 [14:49:52] addshore: care helping switching to DM 1.0? Just 4 small things needed now [14:49:56] Seee link by tobi [14:50:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 (owner: 10Henning Snater) [14:50:37] (03PS6) 10Henning Snater: Moved initializing basic entity widgets to entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 [14:51:24] addshore: what rights does this thing need? [14:51:37] public_rep and admin:repo_hook ? [14:51:38] mhhm, the hook admin one, and the repo one I think [14:51:57] if it doesnt have the right rights it will just complain and then you can add another right :P [14:52:49] addshore: done [14:52:52] =] [14:52:54] awesome [14:56:29] benestar|cloud: ping [14:56:41] benestar|cloud: https://bugzilla.wikimedia.org/show_bug.cgi?id=70039 [14:58:11] JeroenDeDauw: what patch is https://bugzilla.wikimedia.org/show_bug.cgi?id=70042 relating to? [15:00:03] * aude bot broke wikidata :p [15:00:07] infact how are any of the errors in https://bugzilla.wikimedia.org/show_bug.cgi?id=70039 found? [15:00:12] must be just my bot [15:00:20] aude: how so/ [15:00:28] playing in the sandbox [15:00:36] * aude goes to see the logs [15:01:31] (03PS1) 10Jeroen De Dauw: Attempt to fix bug 70041 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156296 [15:01:48] addshore: https://gerrit.wikimedia.org/r/#/c/153714/ [15:02:06] That commit is meant to let us see what incompatibilities remain [15:02:13] addshore: I will now amend it to avoid that error [15:02:36] ahh [15:03:23] (03PS6) 10Jeroen De Dauw: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 [15:05:01] addshore: can you have a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=70044 ? It's your lovely test class after all :) [15:05:47] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/_lnMVg [15:05:47] 13WikibaseDataModel/06master 14e0acda4 15thiemowmde: Merge pull request #164 from wmde/Claims... [15:06:59] looking now [15:08:01] heh, well I get Fatal error: Class 'Wikibase\Test\ChangeOpTestMockProvider' not found [15:08:14] Thiemo_WMDE: https://translatewiki.net/wiki/MediaWiki:Default-skin-not-found/de https://translatewiki.net/wiki/MediaWiki:Default-skin-not-found-no-skins/de [15:08:17] compare to english [15:08:22] but I guess thats because I broke my localsettings file :P [15:11:17] (03CR) 10Thiemo Mättig (WMDE): Attempt to fix bug 70041 (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156296 (owner: 10Jeroen De Dauw) [15:11:45] (03CR) 10Tobias Gritschacher: [C: 031 V: 031] "Browsertests pass. Qunit tests are broken (probably not related)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [15:14:41] [travis-ci] wmde/WikibaseDataModel/clear/6f6ff35 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/33597098 [15:14:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 (owner: 10Henning Snater) [15:15:24] (03PS7) 10Henning Snater: Moved initializing basic entity widgets to entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 [15:15:33] (03PS6) 10Henning Snater: Optimized copyright tooltip logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 [15:20:22] (03PS1) 10Daniel Kinzler: Handle redirects gracefully on special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156298 (https://bugzilla.wikimedia.org/70034) [15:20:28] aude: --^ [15:20:33] yay [15:23:24] DanielK_WMDE: if you are bored now, https://bugzilla.wikimedia.org/show_bug.cgi?id=69750 also [15:23:58] probably simple fix [15:24:31] (03PS7) 10Daniel Kinzler: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) [15:24:41] Lydia_WMDE: do you know if we need the property suggester table updated for the new features? [15:25:03] https://github.com/Wikidata-lib/PropertySuggester-Python/commits/master indicates some corresponding changes, so yes [15:27:07] [13WikibaseDataModelJavascript] 15thiemowmde comment on pull request #15 1406936a2: * Removed wikibase.datamodel.Entity.equals().... 02http://git.io/YR017A [15:28:10] what changes are happening with claims / statements? *goes to read changelog* [15:28:16] (03PS1) 10Henning Snater: Fixed jQuery.wikibase.aliasesview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156300 [15:28:30] aude: i thought not [15:28:48] when i run the script, it takes a while but then the dump.csv file is empty [15:32:53] mpfh [15:33:08] we can try the new code [15:33:18] if there are issues then roll it back? [15:33:24] (03PS1) 10Daniel Kinzler: Fix auto-comment parameter when creating redirects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156301 (https://bugzilla.wikimedia.org/69750) [15:33:28] aude: --^ [15:33:32] yay [15:34:11] ok [15:35:58] Lydia_WMDE: https://wiki.wikimedia.de/w/index.php?title=Betriebsrat/Kandidatur/Lydia_Pintscher&action=edit&redlink=1 [15:36:04] )-; [15:36:24] DanielK_WMDE: i know -.- too much stuff to do :( it's on my list... [15:36:53] * aude no can login [15:37:24] die benutzername no exist [15:40:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156296 (owner: 10Jeroen De Dauw) [15:44:19] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix auto-comment parameter when creating redirects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156301 (https://bugzilla.wikimedia.org/69750) (owner: 10Daniel Kinzler) [15:46:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [15:46:58] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Attempt to fix bug 70041 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156296 (owner: 10Jeroen De Dauw) [16:03:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 (owner: 10Henning Snater) [16:08:18] DanielK_WMDE: https://github.com/Wikidata-lib/PropertySuggester/compare/v1.0...v1.1 [16:14:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 (owner: 10Henning Snater) [16:17:59] aude: I have had a quick look at the changes to the php code of PropertySuggester. seems fine. [16:18:15] The changes to the python code are more complex, i did not check them yet. [16:21:15] (03PS1) 10Henning Snater: Changed $.fn.applyTemplate mechanics [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156306 [16:22:12] (03CR) 10Henning Snater: "site link widgets related QUnit tests are fixed by https://gerrit.wikimedia.org/r/#/c/156306/." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156300 (owner: 10Henning Snater) [16:23:59] (03CR) 10Henning Snater: "I have failing QUnit tests for aliasesview and for the site link widgets." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 (owner: 10Henning Snater) [16:26:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156298 (https://bugzilla.wikimedia.org/70034) (owner: 10Daniel Kinzler) [16:29:04] (03PS2) 10Henning Snater: Changed $.fn.applyTemplate mechanics [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156306 [16:38:12] DanielK_WMDE: the php is ok to you? [16:38:46] the python makes no csv for me [16:39:03] so unable to update the table today [16:40:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [16:48:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156300 (owner: 10Henning Snater) [16:56:13] aude: yea, looks like all that they did was to pass the "context" parameter through from the web request to the database query. [16:56:23] not sure why that call it "context", but whatever. [16:56:51] aude: if the script makes no csv, the db query probably doesn't return a result. a timeout, perhaps? [16:57:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156301 (https://bugzilla.wikimedia.org/69750) (owner: 10Daniel Kinzler) [16:57:31] DanielK_WMDE: uses the dump [16:57:33] old format [16:58:08] i am debugging but the new code will have to work for now w/o update [16:58:44] yea. which should just mean no suggestions. [16:58:54] yep [17:05:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156306 (owner: 10Henning Snater) [17:10:59] DanielK_WMDE: around? [17:11:19] do you think the code sanitizes the query enough? [17:12:34] i think the api param should be checked more strictly and return an error if it's not one fo the allowed options [17:14:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156306 (owner: 10Henning Snater) [17:35:31] Lydia_WMDE: around? [17:37:11] How do you change the data type of a property on Wikidata? [17:37:30] If it's already in use, I don't think that's possible. [17:38:25] sjoerddebruin: So what do you do if it's in use and wrong? [17:38:26] kaldari: not possible afaik [17:38:42] kaldari: What property are you talking about? [17:39:01] the values would then be incompatible [17:39:06] depending on what kind [17:39:30] some context would be great. :) [17:40:17] aude, sjoerddebruin: https://www.wikidata.org/wiki/Property:P1449 should be string, not Monolingual text. Nicknames are generally not translated and often don't match the language in which they are used. [17:40:36] all other name properties are strings [17:40:37] kaldari: that's kind of the point of monolingual [17:40:43] it has one language [17:40:51] doesn't have to be the same as your language [17:40:55] aude: nicknames do not belong to a language [17:41:00] hmmm [17:41:08] strings have no language, like identifiers [17:41:10] You can use https://www.wikidata.org/wiki/Property:P742 then. [17:41:29] nickname could be 'City of Brotherly Love' :) [17:41:33] that's english [17:41:34] sjoerddebruin: thanks, I'll use that for now [17:41:46] But I think that's going to be replaced later. :/ [17:41:49] or 'philly' [17:41:51] or something maybe [17:42:18] nickname could also be Jimbo, what language is that? [17:42:23] true [17:42:38] aude: I guess it depends on how it's used [17:42:45] * aude nods [17:43:08] hmm, oh well, I'll just use pseudonym for now [17:43:49] ok [17:43:51] aude: How is the deploying going? [17:43:55] not yet [17:44:01] :( [17:44:10] * aude wonders where the Lydia_WMDE is [17:44:31] "Gone fishing for a while... (Please don't just ping but say what you need and I will respond later.)" [17:44:38] :P [17:44:45] That's in the away message. [17:44:58] it's always in her away message btw [17:45:07] :/ [17:45:11] Helpfull. [17:45:39] well, maybe she likes to go fishing [17:45:57] Or it's just a game on a tablet. [17:49:37] aude: sorry - was getting back home from the kde office. how can i help? [17:51:11] Stryn: i do! :D [17:51:13] Lydia_WMDE: i would like us to wait another week on the property suggester [17:51:21] nice :) [17:51:32] aude: ok. what's the issue? [17:51:33] slightly concerned about how the db query is constructed and think it can be sanitized better [17:51:37] ok [17:51:50] from the api, it accepts context - Either item, reference or qualifier [17:51:57] too bad. but if you don't feel comfortable with it then let's push it [17:52:05] but takes any string, and while mediawiki escapes quotes [17:52:17] :( [17:52:19] probably is ok, but think it's too generous [17:53:07] *nod* [17:53:10] should be strict about accepting only item, reference or qualifier and give the api user an error if they request something else [17:53:20] also, would be nice to run the python thing :) [17:53:20] gottcha [17:53:26] heh yeah [17:53:27] everything else looks ready [17:53:31] cool [17:53:39] sjoerddebruin: :( sorry [17:53:51] if we do what i suggest, no further security review is needed [17:54:05] though daniel can look [17:54:25] or hoo [17:54:46] kaldari: yeah it is not possible to change the datatype of an existing property. that'd create way too much of a mess. if it really was created with the wrong datatype it has to be recreated with the right one. however there have been long discussions about names. so it is probably best to read up on those. [17:54:58] aude: ok sounds good [18:00:08] Lydia_WMDE: Thanks for the info. I'll just leave it be for now. [18:00:32] alright [18:02:29] (03PS1) 10Aude: Use property suggester 1.0 for another week [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156326 [18:08:40] so, when do people thing we will reach one billion edits? [18:10:48] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/A4U-uA [18:10:48] 13WikibaseDataModel/06master 14389e23f 15Jeroen De Dauw: Update RELEASE-NOTES.md [18:13:49] (03CR) 10Aude: [C: 032] "jenkins approves" [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156326 (owner: 10Aude) [18:21:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156326 (owner: 10Aude) [18:23:15] yeah yeah, wikidata jenkins is broken [18:34:17] Jhs: Don't know, I can remember the 100th millionth edit very good. :) [18:35:22] sjoerddebruin, :D [18:35:50] i see what you did there [18:35:55] and i see what you did then [18:35:58] https://www.wikidata.org/w/index.php?diff=100000000 <3 [18:37:38] that was ~8 months ago, and now we're at 154 000 000, so some easy math gives us ........ [18:37:43] (calculating) [18:38:22] (calculating) [18:38:30] (calculating) [18:38:39] 11 and 1/3 years [18:38:48] i think it will be sooner [18:42:07] Moar bots. [18:43:17] hey folks...for who is around... [18:44:08] I am following up on some discussion that took place on the listserv (wikidata-l) about social media on the Main page [18:45:22] there were a few suggestions - 1) we should not promote them at all, and instead just link to our own page Wikidata:Social media [18:45:34] (03CR) 10Aude: [V: 032] Use property suggester 1.0 for another week [extensions/Wikidata] (mw1.24-wmf18) - 10https://gerrit.wikimedia.org/r/156326 (owner: 10Aude) [18:46:15] 2) we should not over-emphasize them (so somehow diminish their visibility/importance from as they are now) [18:46:30] 3) we should leave as they are [18:47:03] I'd like to poll the channel to see what people think... [19:08:17] Lydia_WMDE: beta feature is enabled [19:08:29] <3 [19:08:30] aude: sweet [19:08:36] i'm not sure, there might be caching [19:08:42] or problems with the compact links thing [19:11:16] or might be config [19:15:14] Lydia_WMDE: ? [19:15:56] aude: want me to enable it? [19:16:06] try it [19:16:13] for me, it's not doing anything [19:16:26] so wonder if it's caching [19:16:34] worked for me on my test wiki this morning [19:18:28] aude: not working here either it seems [19:18:31] on dewp [19:18:36] paris article [19:18:56] grrrr [19:19:33] i know there is heavy caching, but then it works on the wikis that opted in [19:20:17] *nod* [19:20:31] aude: did you configure the projects that are shown? i think that's needed [19:20:37] there is a default [19:20:39] it worked for me [19:20:59] hmmmm [19:21:18] think i need to move on to the serialization change [19:21:43] ok [19:21:45] think we should leave other projects enabled and further debug after? [19:21:56] jep agreed [19:21:59] k [19:24:55] no response to thepwnco's question up there? [19:24:58] :( [19:26:02] serialization! [19:26:08] go edit! [19:26:39] aude: \o/ [19:27:06] logs quiet [19:27:35] https://www.wikidata.org/wiki/Special:Export/Q6041538 looks fine [19:27:53] now badges (for sister projects) [19:28:42] :) [19:28:54] not sure where to see them [19:29:18] ah [19:30:47] one more config change also [19:37:59] did something just change? [19:38:05] like a few minutes ago? [19:38:36] my bot just stopped working [19:38:50] and judging from the traffic in the rc IRC channel, so did several other bots [19:39:07] Jhs: yes we switched the serialisation format as announced [19:39:20] ah, right [19:39:34] oh! [19:39:35] noes [19:39:46] aude: ? [19:39:56] bots are broken? [19:40:16] well, mine is [19:40:18] if they did rely on the internal serialization... [19:40:19] :( [19:40:23] but i'll figure it out [19:40:23] they shouldn't [19:40:31] if i don't, Amir1 will :D [19:40:34] that guy's a genius [19:46:30] Lydia_WMDE: does http://tools.wmflabs.org/wikidata-game/ work for you [19:46:34] ? [19:46:39] looking [19:48:02] aude: getting a white page except for the header after logging in [19:49:07] :( [19:49:09] me too [19:49:31] aude, me too, but that happened quite some time before my bot stopped working [19:49:44] so i'm thinking those aren't related [19:49:46] :( [19:51:10] :( [19:54:17] oh that got deployed? [19:54:25] I need to fix WBHacks now [19:58:01] Lydia_WMDE: in good news, https://test.wikidata.org/wiki/Special:Version works again [19:58:14] config issue [19:58:16] aude: weeeeeeeee [20:00:33] Hi multichill. :) [20:02:16] eh what [20:02:21] I don't get lua [20:02:47] oh wait [20:05:00] how to I print a table for debugging? [20:05:49] Good evening [20:09:36] https://www.wikidata.org/w/index.php?title=Module%3AWBHacks&diff=153579742&oldid=129622099 [20:09:40] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156435 (owner: 10L10n-bot) [20:09:42] pages with script errors will need purges [20:10:04] https://www.wikidata.org/wiki/Category:Pages_with_script_errors :( [20:10:59] null edits don't work? [20:11:34] that will work too [20:11:41] does anything actually use https://www.wikidata.org/wiki/Template:Collapsible_list ? [20:16:04] Why do we have that on Wikidata? [20:16:42] hm? [20:18:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/50ad2c1 : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33628170 [20:18:04] JohnLewis: "legoktm: does anything actually use https://www.wikidata.org/wiki/Template:Collapsible_list ?" [20:18:50] not used really [20:19:17] https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard/Archive/2014/04#Collapsible [20:20:00] :/ [20:26:26] https://dpaste.de/Fb8N/raw all need to be checked to make sure they work after the serializaiton change [20:26:29] serialization* [20:29:55] aude: how's the deployment going? [20:39:35] DanielK_WMDE: lua broken [20:39:37] awww [20:39:38] rage [20:41:47] Lydia_WMDE, sorry to be asking; i've been looking in quite some places, but can't find it. what does it mean in practice that the serialization is changed? or rather, what did the internal serialization look like before today? [20:42:30] Jhs: if you look at an old dump it is in there [20:42:51] we changed it to be the same as what you already got through the api for a long time [20:43:09] oh ok [20:43:13] thanks :) [20:43:15] np [20:43:41] https://github.com/wmde/WikibaseInternalSerialization/tree/master/tests/data/properties/legacy/old [20:44:03] https://raw.githubusercontent.com/wmde/WikibaseInternalSerialization/master/tests/data/properties/legacy/old/P6-22681711.json [20:45:00] probably more examples [20:45:24] https://raw.githubusercontent.com/wmde/WikibaseInternalSerialization/master/tests/data/items/legacy/recent/Q3.json [20:45:57] Lydia_WMDE: *wave* [20:46:03] hey benestar! [20:46:05] thanks aude [20:46:17] sry, I was *really* busy the last days... [20:46:22] np :) [20:46:39] benestar: badges are on the sister projects [20:46:47] aude: :D [20:46:50] although not sure which actually have them [20:46:55] * benestar did not fix their scirpts yet though... [20:47:02] k [20:47:16] Lydia_WMDE: did you look through my mappings? [20:48:11] benestar: i counldn't find any issues in it [20:48:12] sjoerddebruin: No zin om te helpen met de RIjksmonumenten? [20:48:30] Ja hoor multichill, doe er wel een paar per dag hoor. :) [20:48:41] De import bot is klaar met de eerste run [20:48:49] Lydia_WMDE: ok, so I will run the script now? [20:48:58] aude: ^ok? [20:49:09] for badges [20:49:12] ok [20:49:13] maybe I should give a link to some wikidata page like Contact the dev team [20:49:18] yeh [20:49:25] sjoerddebruin: Working my way down https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P359 now [20:49:26] that page is good [20:49:29] because I'm not sure if I have more time the rest of the week :/ [20:49:39] ok [20:49:45] we'll handle it if they show up there [20:51:48] we have a new main page now :) [20:52:01] Stryn: we do indeed [20:52:02] \o/ [20:52:08] Ah, the darth vader main page [20:52:22] i will write an email later with an announcement for that and the deployment [20:52:31] * Lydia_WMDE looks @ multichill [20:52:31] -.- [20:52:42] so we kept the dark heading [20:52:45] * benestar not so happy with tat [20:52:46] now the proceedural; Lydia_WMDE: do we have another amazing deploy next week planned or is it just what I see on the calendar? [20:52:47] *that [20:53:06] * Stryn wants more presents :P [20:53:25] Stryn: wait and find out what is next week :p [20:53:25] benestar: we can see how it goes with this and change it later if wanted [20:53:45] JohnLewis: enhanced property/entity suggester (i think) [20:53:47] JohnLewis: we'll have to push at least one thing from this week [20:54:05] Stryn: can't be christmas every week :D [20:54:10] :( [20:54:12] aude: I see something different on the calendar :) [20:54:13] * aude quick, merge all the things! :P [20:54:14] Lydia_WMDE: -.- [20:54:40] https://www.mediawiki.org/wiki/Wikidata_deployment is official and not updated yet [20:54:42] Lydia_WMDE: Hmm, people ask for feedback, get it, don't do anything with it and just deploy the new main page? That's not good [20:54:48] * aude doesn't look at other calendar [20:54:54] multichill: lots of feedback was acted on [20:55:06] multichill: and there was conflicting feedback on that part [20:55:20] aude: oh I don't look at that one but the other one :p [20:55:25] heh [20:55:49] this is not the end. we're iterating [20:56:06] where's the kitten? :P [20:56:18] ^^ [20:58:59] multichill: I agree... [21:01:32] Lydia_WMDE: starting the script now [21:01:38] thx! [21:03:55] Lydia_WMDE: or not as my ssh connection does not want to work *argh* [21:04:02] -.- [21:04:13] that's weired, always when you need it urgently... [21:09:54] aude: what? :O [21:10:00] why is the setting already on the clients? -.- [21:10:07] this breaks the whole scripts... [21:10:18] ? [21:10:25] aude: there is a setting for Wikibase client [21:10:35] badgeCssNames or sth like that [21:10:42] it shouldn't do anything yet? [21:10:45] and this setting should only be set on deployment... [21:10:50] Hey have you changed API output of getentities? [21:10:52] aude: it adds css class names [21:11:04] and we only use the old system if the new classnames aren't there [21:11:06] everything is different I'm literally panicking [21:11:11] so we have to disable the setting again [21:11:18] * aude confused [21:11:21] if this is not too much of work for you [21:11:30] aude: see https://ace.wikipedia.org/wiki/Berlin [21:11:34] when do we enable it? [21:11:43] aude: on deployment [21:11:46] when our icons are there [21:11:58] and not before... [21:12:31] Amir1: btw, how is the badge import going? [21:12:55] benestar: hey, All of badges are imported [21:13:07] \o/ [21:13:14] the next step is to remove them from Wikipedia [21:13:21] Amir1: any conflicts or sth like that [21:13:31] benestar: have you tested if the badges work with https://www.mediawiki.org/wiki/Universal_Language_Selector/Design/Interlanguage_links ? [21:13:40] Or is there a place where that can be tested [21:13:41] two things need your attention [21:14:03] benestar: https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Bot/Statut#Dexbot [21:14:15] and https://pl.wikipedia.org/wiki/Wikipedia:Boty/Zg%C5%82oszenia/Wnioski [21:14:33] i don't see anything on https://ace.wikipedia.org/wiki/Berlin [21:14:33] Nemo_bis: not sure [21:14:35] is it the new system? http://paste.ubuntu.com/8153292/ [21:14:43] but that feature is still beta afaik [21:14:56] so I think they will easily be able to adapt our badge feature [21:15:04] everything is different and my bot gets error for everything it is doing in Wikidata [21:15:07] or related [21:15:09] aude: that's the problem, no stars [21:15:41] aude: because of that https://ace.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.js&diff=84819&oldid=84295 [21:15:44] why there is no announcement about this [21:15:48] one thing at a time [21:16:09] Amir1: let benestar and aude figure out the badge thing quickly then we'll get to your issue [21:16:23] Amir1: I guess a bug -.- [21:16:45] Lydia_WMDE: okay [21:16:52] looks like some PHP internal serialization mixed with JSON but I've no idea ;) [21:17:10] aude: so can you disable that setting again or does that need some time? [21:17:11] * Amir1 is panicking and knocking his head to wall [21:17:21] benestar: doing [21:17:31] :) [21:18:00] aude: btw, sorry, I should've told you that the setting enables some stuff we need the depolyment for... [21:19:22] * Nemo_bis calms down Amir1 [21:19:24] aude: when will you've finished this? [21:19:43] because I've not so much time left and will just run the script otherwise now or tomorrow [21:20:00] we enable these again on thursday? [21:20:02] Nemo_bis: :D [21:20:08] aude: yes [21:20:21] as soon as WikimediaBadges extension is there [21:20:34] ok [21:21:18] Amir1: in the meantime can you see what is different in the output? [21:21:29] aude: ready? [21:21:43] Lydia_WMDE: sure [21:21:51] benestar: not that quick [21:22:17] aude: :/ will have to do it tomorrow then [21:22:46] ok [21:22:47] multichill: Hier wachte ik even mee tot jij het item aanmaakte. :) https://www.wikidata.org/w/index.php?title=Q17616500&diff=153585038&oldid=153504275 [21:23:04] so bye, cu :) [21:23:24] cya benestar [21:23:30] ok now Amir1 :) [21:23:42] :) [21:23:43] Are all badges templates in Wikipedia projects unneccessary now? [21:23:45] Jhs: i guess that's the same issue you were facing [21:24:07] magioladitis: it'll still have to stay on the article itself [21:24:17] Lydia_WMDE, definitely, since i'm using Amir1's code ;) [21:24:21] k [21:24:32] http://paste.ubuntu.com/8153292/ [21:24:44] this is newer output of wbgetentity [21:24:52] or wbgetentities [21:25:07] Lydia_WMDE: When can we remove the templates then? [21:25:08] the older one was completely different [21:25:20] Lydia_WMDE: since we can remove them [21:25:24] magioladitis: hey :) [21:25:32] Amir1: Hi!! [21:25:33] (Dexbot operator) [21:25:36] Amir1: btw, also imports from sisterprojects? [21:25:48] Ja, dat is mooi sjoerddebruin! [21:25:49] can we do one thing at a time please guys? [21:26:00] let's figure out the wbgetentities issue now [21:26:04] because that looks serious [21:26:10] then we can move on to the next one [21:26:29] thanks Lydia_WMDE [21:26:34] multichill: Oh ja, zag je trouwens dat https://www.wikidata.org/wiki/Property:P1456 is aangemaakt? Ik vroeg me af of we die botmatig kunnen toevoegen. [21:26:49] the old system was like entity['claims'] was a list [21:27:37] Tobi_WMDE_SWE: still around by any chance? [21:27:40] Is there a change regarding size in bytes? Some edits are bigger then before. [21:27:50] and each entity was a dictionary with ['refs':[], 'q':[], 'm':[blah,20,something, "string"] [21:27:51] sjoerddebruin: new serialization [21:27:57] Lydia_WMDE: ah. :P [21:28:08] 1500 bytes for a sitelink is pretty big. [21:28:09] that's odd [21:28:29] and now the entity['claims'] is a dictionary instead of list [21:28:49] sjoerddebruin: Volkomen gemist [21:28:55] which is like entity['claims']['P12'] [21:29:04] and it's a dictionary [21:29:06] multichill: Er is ook nog geen overlegpagina. :/ [21:29:21] aude: any idea? [21:29:39] Lydia_WMDE: and even removing is making it bigger [21:29:54] see last edits: https://www.wikidata.org/wiki/Special:Contributions/Dexbot [21:30:05] let's figure out editentity first [21:30:09] (03CR) 10Siebrand: Handle redirects gracefully on special pages. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/156298 (https://bugzilla.wikimedia.org/70034) (owner: 10Daniel Kinzler) [21:30:48] 21:06, 26 August 2014 (diff | hist) . . (+2,628)‎ . . David Lea (Q431792) ‎ (‎Removed claim: date of death (P570): 2 November 1937) !!!! [21:30:55] k [21:31:01] http://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q17&format=json ? [21:31:05] looks normal to me [21:31:13] There is clearly something wrong. [21:32:13] Amir1: ^ [21:32:36] checking [21:32:42] Amir1: id? [21:33:00] id of what? [21:34:02] an item that gives you an error [21:34:20] I give this on any item [21:34:40] let me find a comparing system [21:35:14] aude Lydia_WMDE: http://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q1700&format=json [21:35:25] in this entity['claims'] is different [21:35:33] than it was before [21:36:00] Amir1: I am off to bed. Please clear the badges thing and write a comment at https://en.wikipedia.org/wiki/Wikipedia:Bots/Requests_for_approval/Dexbot_2#Discussion [21:36:15] Lydia_WMDE: Please check this link too. Thanks [21:36:21] magioladitis: sure :) [21:36:27] bye! [21:36:33] bye [21:36:44] it was a list [21:36:45] Amir1: indeed. something is different [21:37:07] * Lydia_WMDE looks when q17 was last edited [21:37:34] before the serialisation switch [21:37:40] I use Q1700 because is smaller [21:37:46] 1700 as well though [21:37:48] wth [21:38:07] and sitelinks are different [21:38:24] before it was items['links']['dewiki']['name'] [21:38:37] now it is items['links'][ [21:38:50] 'dewiki']['title'] [21:39:04] and sitelinks was a list now it's a dictionary [21:39:18] (I'm not sure about the last one) [21:39:32] ok [21:41:33] hmmm [21:41:45] it was a dictionary but it was like entity['items']['dewiki'] = {'name':"foo","badges":[]} [21:43:33] legoktm: on a small note - legobot seems CVN blacklisted [21:46:36] aude, Lydia_WMDE: What do you think? [21:47:17] Amir1: i am letting katie investigate. there's not much i can do atm. worst case we'll all have to look at this first thing tomorrow morning with the rest of the team [21:48:09] okay, thank you. I'm off to bed [21:48:27] i don't know that it's something quick to fix [21:48:28] please e-mail whenever it got fixed or any update [21:48:46] is there a bug ticket? [21:48:49] Amir1: will do. thanks [21:49:00] aude: not yet. i will email when you say you can't fix it [21:49:22] i am confused what exactly to fix [21:49:27] seems there are multiple problems [21:49:40] possibly [21:50:24] ok i will email about wbeditentities [21:50:44] ok [21:50:48] sjoerddebruin: do you have a link to a diff with too huge size change? [21:50:52] brb [21:51:14] Lydia_WMDE: https://www.wikidata.org/w/index.php?title=Q17616500&diff=153585038&oldid=153504275 [21:51:30] probably badges being added everywhere, even if empty [21:51:43] Could be. [21:51:44] e.g. empty array placeholder [21:52:12] But this one is smaller. https://www.wikidata.org/w/index.php?title=Q17616977&diff=prev&oldid=153521707 [21:52:24] A lot smaller! [21:52:34] ah, only 1 site link [21:52:35] aude: i don't think that is it based on the history of the item [21:52:49] that's a new item [21:53:12] But this confusing for a user. [21:54:31] sjoerddebruin: we need to look into this more tomorrow [21:54:35] thanks for the links [21:54:42] i will email about that as well [21:55:01] I'm searching for a old one with more site links. [21:55:17] aude: what do we do with announcement? [21:55:27] not much to announce [21:55:30] :( [21:55:39] also need to look at the other projects [21:56:31] ugh, so much edits [22:43:41] Some people live under stones. https://nl.wikipedia.org/w/index.php?title=Rabbula_van_Edessa&curid=2305431&diff=41950903&oldid=37926214 [22:43:55] ah [22:43:57] Lydia_WMDE: so badges on clients are deployed? [22:44:02] lazowik: we're still struggling with this deployment. will need to fix remaining issues tomorrow [22:44:04] ok [22:44:35] not sure what the status of badges on clients is atm [22:49:51] aude: anything i can still help you with? [23:04:27] Lydia_WMDE: we do badge icons on thursday or when bene* is ready [23:04:33] ok [23:04:43] they are there but nothing to see in the clients [23:05:04] k [23:05:28] serialization stuff.... i'm too tired to look at [23:05:44] not trivial [23:06:44] yeah [23:06:46] let's tackle that tomorrow [23:06:49] with the others [23:07:00] not getting anywhere now anyway [23:07:00] k [23:37:10] JohnLewis: eh, legobot is still editing? o.O [23:37:29] legoktm: That is what a bot does right? :p [23:37:37] :o wow [23:37:50] I only saw it on Status updates/Next so it might have been prior to deploys [23:39:17] I don't remember how to unblacklist it or if I even should [23:39:48] mmm, looks like compat broke with the serialization change [23:40:04] legoktm: it's nothing worth bothering about - just something I saw :p