[00:00:47] lazowik: if only there was a "rage about all code" button... [00:01:06] :p [00:02:11] (03CR) 10Jeroen De Dauw: "This reduces the type safety. In at least some of the places the code is scary and having the check is nice. Replacing those asserts with " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155247 (owner: 10Thiemo Mättig (WMDE)) [00:02:18] Time for lunch [00:02:36] there's no better time for lunch than 2:02am [00:02:53] exactly [00:20:24] JeroenDeDauw: have a good revieweing [00:20:31] *reviewing [03:56:17] (03PS4) 10Hoo man: Fix link to badge items pointing to the wrong site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155180 (https://bugzilla.wikimedia.org/69758) [04:10:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155180 (https://bugzilla.wikimedia.org/69758) (owner: 10Hoo man) [04:11:19] :) [04:12:44] hoo: what are you doing being awake at this evil hour? [04:13:02] JeroenDeDauw: Coding? :P [04:13:12] I'm in the US so the hour isn't as evil :) [04:14:44] ah [04:35:16] (03CR) 10Hoo man: "Did this properly now (using an EntityTitleLookup). Also added a test case." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155180 (https://bugzilla.wikimedia.org/69758) (owner: 10Hoo man) [04:36:57] yawn... almost time for dinner [04:42:47] JeroenDeDauw: are you in the US too? :P [06:28:28] (03PS9) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [06:29:41] (03PS10) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [06:29:52] (03PS7) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [06:30:14] (03PS8) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [06:30:26] (03PS5) 10Henning Snater: Propagating editable state in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 [06:30:45] (03PS7) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [06:37:32] (03PS8) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [06:39:14] (03PS22) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [06:40:36] (03PS9) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [06:40:42] (03CR) 10jenkins-bot: [V: 04-1] Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [06:48:07] (03PS10) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [06:48:13] (03CR) 10jenkins-bot: [V: 04-1] Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [06:56:22] (03PS11) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [06:56:24] (03PS11) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [06:56:26] (03PS23) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [06:56:28] (03PS9) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [06:56:30] (03PS6) 10Henning Snater: Propagating editable state in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 [06:56:32] (03PS9) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [06:57:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [06:58:11] (03PS4) 10Henning Snater: Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 [07:02:41] (03CR) 10Bene: [C: 031] "Looks good to me, waiting per Thiemo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155180 (https://bugzilla.wikimedia.org/69758) (owner: 10Hoo man) [07:24:04] (03PS4) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [07:24:19] (03CR) 10jenkins-bot: [V: 04-1] Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 (owner: 10Henning Snater) [07:27:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [07:45:00] legoktm: hell no - I'm not visiting the land of the free [07:54:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 (owner: 10Henning Snater) [07:54:20] :P [08:16:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 (owner: 10Henning Snater) [08:34:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 (owner: 10Henning Snater) [08:42:45] Does anybody by accident know if the JSON-Dumps contain Items only or properties as well? [08:43:45] diferrumtrioxide: should contain both [08:44:01] thanks [08:49:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [09:03:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [09:07:26] (03PS1) 10Aude: Set global $wgContLang for CopyrightMessageBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155507 [09:16:19] (03CR) 10Tobias Gritschacher: [C: 032] Use 'auto' direction if language does not exist in ULS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155254 (owner: 10Henning Snater) [09:17:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [09:17:52] Lydia_WMDE do they follow a specific order or are they mixed? [09:22:17] diferrumtrioxide: i fear they are mixed [09:25:11] Lydia_WMDE: Just thinking, would it be feasable to split them into two dumps? [09:25:37] diferrumtrioxide: yeah we just didn't have a chance to do that yet [09:25:45] too many other things to do unfortunately [09:25:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:28:37] Lydia_WMDE: Good to know that this is planned for the future. :) [09:28:49] :) [09:31:42] (03CR) 10Thiemo Mättig (WMDE): "Jeroen, I already split this in two patches: Places where I replaced the assert() like you said and places where I think it's pointless. P" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155247 (owner: 10Thiemo Mättig (WMDE)) [09:31:46] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/05c771e : Tobias Gritschacher The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33154022 [09:34:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:42:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [09:43:51] (03PS1) 10Thiemo Mättig (WMDE): Stop using the Wikibase\ByPropertyIdArray alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155510 [09:55:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [10:00:29] (03PS1) 10WikidataBuilder: New Wikidata Build - 21/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/155513 [10:10:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [10:12:49] (03PS24) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [10:13:06] (03PS12) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [10:13:12] (03PS10) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [10:13:18] (03PS7) 10Henning Snater: Propagating editable state in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 [10:13:23] (03PS10) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [10:13:28] (03PS12) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [10:13:33] (03PS5) 10Henning Snater: Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 [10:22:55] (03PS1) 10Thiemo Mättig (WMDE): Stop using EntityDiff and ItemDiff aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155515 [10:24:45] (03PS6) 10Henning Snater: Implemented jQuery.wikibase.descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154388 [10:28:33] [13ValueView] 15tobijat created 06rm_msg (+1 new commit): 02http://git.io/6Mqo7w [10:28:33] 13ValueView/06rm_msg 147e04088 15Tobias Gritschacher: Removed valueview-descr msg from i18n [10:29:46] (03PS1) 10Aude: Handle MWContentSerializationException in JsonDumpGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155517 (https://bugzilla.wikimedia.org/69846) [10:30:24] [13ValueView] 15tobijat created 06changeurl (+1 new commit): 02http://git.io/6NI8BQ [10:30:24] 13ValueView/06changeurl 142777486 15Tobias Gritschacher: Link to GitHub instead of mediawiki.org in extension credits [10:30:30] [13ValueView] 15tobijat opened pull request #108: Link to GitHub instead of mediawiki.org in extension credits (06master...06changeurl) 02http://git.io/EhSaLw [10:32:38] (03PS1) 10Thiemo Mättig (WMDE): Stop using the Wikibase\ReferenceList alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155519 [10:33:50] (03PS11) 10Henning Snater: Implemented jQuery.wikibase.labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154394 [10:34:04] (03PS5) 10Henning Snater: Moved initializing basic entity widgets to entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154416 [10:34:11] (03PS5) 10Henning Snater: Optimized copyright tooltip logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154419 [10:34:31] (03PS2) 10Thiemo Mättig (WMDE): Stop using the Wikibase\ReferenceList alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155519 [10:35:52] (03PS5) 10Henning Snater: Eliminated PropertyEditTool [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154425 [10:36:04] (03PS5) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [10:36:27] Henning_WMDE spamming the wdjenkins!!! [10:36:46] (03PS3) 10Henning Snater: Overhauled tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154458 [10:36:53] (03PS3) 10Henning Snater: Eliminated wikibase.utilities.ui.StatableObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154463 [10:36:58] (03PS2) 10Henning Snater: Eliminated PersistentPromisor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154754 [10:37:03] (03PS2) 10Henning Snater: Removed wikibase.utilities.jQuery [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154756 [10:37:40] (03PS1) 10Aude: Add method for generating json of individual entities in JsonDumpGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155520 [10:37:42] (03PS1) 10Aude: protected -> private in JsonDumpGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155521 [10:38:15] (03PS3) 10Thiemo Mättig (WMDE): Stop using the Wikibase\References and ReferenceList aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155519 [10:39:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 (owner: 10Henning Snater) [10:39:43] (03PS3) 10Henning Snater: Refactored ResourceLoader QUnit test modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 [10:39:50] (03PS2) 10Henning Snater: Untangled $.wikibase.snakview ResourceLoader modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 [10:42:39] (03PS5) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [10:43:04] wow, wikidatajenkins is backlogged [10:43:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/155513 (owner: 10WikidataBuilder) [10:43:25] 1 1/2 hours [10:45:14] (03PS1) 10Thiemo Mättig (WMDE): Stop using the Wikibase\Reference alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155523 [10:45:19] FYI: Properties in the JSON Dump are mixed in but seem clustered. Parsing got me [10:45:19] 15741K entries: 15740K items, 1172 properties [10:45:51] things are sharded and then assembled again [10:46:07] so properties might be clustered in multiple places [10:48:12] Hi. [11:02:15] (03PS6) 10Henning Snater: Refactored ResourceLoader module definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 [11:05:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 (owner: 10Henning Snater) [11:30:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [11:33:13] hwy :) [11:33:17] *hey… [11:48:31] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 21/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/155513 (owner: 10WikidataBuilder) [11:57:31] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [12:17:09] is wikidata jenkins broken? [12:17:48] Tobi_WMDE_SWE: !!!! [12:19:57] (03CR) 10Bene: [C: 032] "Merged" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155180 (https://bugzilla.wikimedia.org/69758) (owner: 10Hoo man) [12:22:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155507 (owner: 10Aude) [12:23:36] hello jenkins! [12:23:40] :) [12:24:09] aude: https://www.youtube.com/watch?v=5vHYvD-7FXE [12:24:31] :) [12:25:20] "seems to be a good season of year, the oysters are good" [12:25:35] "well, I don't know what nationality they are" [12:25:53] "I'd like to think that oysters transcend national bariers" [12:26:08] lol [12:29:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155510 (owner: 10Thiemo Mättig (WMDE)) [12:33:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/92e0d68 : Bene The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/33167582 [12:36:03] aude: do we still need https://gerrit.wikimedia.org/r/#/c/154106/? [12:36:19] no [12:36:25] abandon? [12:36:27] ok [12:36:40] wdjenkins just has a huge backlog. it is not broken, just working hard. [12:36:49] would deserve some chocolate [12:37:22] (03Abandoned) 10Tobias Gritschacher: Use 0.5.2 DataValuesJavascript and 0.3.1 WikibaseDataModelJavascript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154106 (owner: 10Aude) [12:37:35] (03Abandoned) 10Tobias Gritschacher: Use 0.5.2 DataValuesJavascript and 0.3.1 WikibaseDataModelJavascript [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154107 (owner: 10Aude) [12:52:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [12:54:03] (03CR) 10Henning Snater: [C: 04-1] "Due to missing user feedback/visualization, automatically selecting the first site should not be performed when the menu is invisible. In " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [12:57:54] (03PS1) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [13:01:38] (03PS2) 10Thiemo Mättig (WMDE): Possible refactoring of siteselector._selectFirstSite [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 [13:02:21] (03CR) 10Aude: "fingerprint is the term box?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [13:06:50] (03PS2) 10Henning Snater: Implemented jQuery.wikibase.fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 [13:12:54] [travis-ci] filbertkm/mediawiki-extensions-Wikibase/copyrightview/9506e66 : aude The build failed. http://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/33170343 [13:13:02] bah [13:13:21] 2 failure instead of 4 [13:13:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [13:15:22] (03PS1) 10Aude: Use mock in SpecialPageCopyrightViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155535 [13:20:36] (03CR) 10Tobias Gritschacher: "@aude yes, one entry in the term box." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [13:21:48] (03CR) 10Aude: "fingerprint list? (ps, i don't blame henning for the name, but it's confusing imho)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [13:21:54] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Set global $wgContLang for CopyrightMessageBuilderTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155507 (owner: 10Aude) [13:22:51] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/155513 (owner: 10WikidataBuilder) [13:23:37] (03CR) 10Tobias Gritschacher: "for a list of fingerprints ther will be the fingerprintlistview widget. we've a separate task for that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [13:32:12] * hoo waves [13:32:16] just had breakfast [13:32:23] it's a hoo! [13:32:33] hi aude :) [13:33:18] do you know what we poke to purge local storage / caches for sites module? [13:33:36] it does that automatically now [13:33:37] we tried SitesModule, wikibase.sites.js and wikibase.Site.js [13:33:39] hmmm [13:33:44] might poke again [13:33:45] none of that will work [13:33:51] ? [13:33:55] look at the timestamp it has in the start module [13:34:21] ok [13:34:22] Well, it has an own method for getting it's last change [13:34:33] including if settings change? [13:34:35] (and before that it just returned 0 as last change time) [13:34:37] yep [13:34:40] ok [13:34:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155520 (owner: 10Aude) [13:34:56] it uses a hash of settings and the sites table for cache invalidation [13:35:00] ok [13:35:10] look into the class, I think it's quite nice (took me a few hours to figure that) [13:35:12] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Introduce ViewTestCase to validate HTML output (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 (owner: 10Bene) [13:35:35] (03CR) 10Aude: "git fail, not the patch" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155520 (owner: 10Aude) [13:36:04] if i use debug=true? special sites are 'wikidata' and 'commons' [13:36:11] otherwise, sometimes testwikidata [13:36:17] which is wrong! [13:36:24] testwikidata [13:36:25] wtf [13:36:29] i fixed the settings [13:36:30] on the real one? [13:36:32] oh [13:36:35] I see [13:36:37] so they are correct now and debug=true does the righ thting [13:36:53] let me look into my tin home, I used to have an extra purge thing around [13:36:59] that does some nasty memcached manipulation [13:37:00] ok [13:37:06] not sure I still have it [13:37:09] i think the memcached is ok [13:37:12] I don't think we need it anymore [13:37:34] except resource loader in memcached maybe [13:37:42] mh [13:37:50] it just bumped the last change timestamp [13:37:57] which the module now does automatically [13:38:03] ok [13:38:07] but then it's up to RL to actually purge the caches etc. [13:38:14] wikibase.getSitesOfGroup('special'); [13:38:17] if it doesn't that's bad :( [13:38:30] :( [13:38:45] do you have an example item that's broken or do I just have to hit Special:Random a bit? [13:39:01] random [13:39:02] and [13:39:04] wikibase.getSitesOfGroup('special'); [13:39:26] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "With the depending patch it's ok for me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [13:39:26] doing it locally, it automatically updated without me touching things [13:39:30] looking [13:39:44] yep, that's how it is supposed to work [13:39:54] the timestamp stuff works correctly, I've tested that a lot [13:40:00] good [13:40:02] but if RL then doesn't purge accordingly :S [13:41:13] could just be the order that things were touched in swat [13:41:28] doubt it [13:41:42] yeah, also doubt that [13:41:49] did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=69671 ? [13:41:53] Looks like parser cache stuff [13:42:09] bah [13:42:13] but it should have been purged by the cache bump, right? [13:42:14] we updated cache epoch [13:42:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155521 (owner: 10Aude) [13:42:35] I saw [13:42:41] and I guess you did that correctly [13:42:44] so :( [13:43:00] yep [13:43:05] it worked for me [13:43:20] grrr [13:43:32] that was reported on tuesday [13:43:33] maybe some server didn't get the sync initially or something like that? [13:43:40] yeah, probably fixed now [13:43:44] close it [13:44:42] commented [13:45:09] did you see the history patch earlier on? benestar merged it [13:45:14] would probably be nice to backport [13:45:58] possible [13:46:15] would prefer if doing a bunch of things, but maybe not if it's the only thing [13:46:34] yeah, ok [13:46:42] aude: hoo: also the authoritycontrol gadget is broken when debug=false. it works when debug=true [13:46:46] is there nothing else (which would be awesome) [13:46:53] but surprising after such a huge deploy [13:46:59] only minor things [13:47:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155519 (owner: 10Thiemo Mättig (WMDE)) [13:47:04] Tobi_WMDE_SWE: :S Load order again [13:47:09] I predicted it to break [13:47:20] due to the entity init code changes [13:47:40] hoo: but it should just load after the rest of the page loaded, no? [13:48:28] Tobi_WMDE_SWE: Well, yes... but how should it know when that time is? [13:48:43] Right now it can't really [13:48:53] hoo: i thought mw gadget mechanism takes care of that [13:49:07] I've suggested earlier to add another (javascript) mw.hook for gadgets once we're really done with our stuff [13:49:07] s [13:49:14] maybe you want to explore that [13:49:32] no, server side can't know how long our JS stuffs need [13:53:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154763 (owner: 10Henning Snater) [13:58:16] * hoo waves good bye [13:58:25] later [13:58:28] ,o/ [13:58:52] aude: Will probably be back at 10pm... UTC-4 :P [13:58:57] ok [14:00:39] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154804 (owner: 10Henning Snater) [14:01:20] Thiemo_WMDE: what's with https://gerrit.wikimedia.org/r/#/c/152875/? how do we proceed [14:02:19] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I don't think this needs any additional tests. This code is older than mw.Api.postWithToken() and does not make sense any more. The patch " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [14:02:59] Tobi_WMDE_SWE: by reviewing it? doing it right now. [14:03:20] Thiemo_WMDE: :) [14:03:25] me too [14:03:36] again :) [14:04:46] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155523 (owner: 10Thiemo Mättig (WMDE)) [14:09:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154805 (owner: 10Henning Snater) [14:12:40] Is https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/A_need_for_a_resolution_regarding_article_moves_and_redirects#new_Proposal_zero deployed now? [14:12:49] Is it possible to link to redirects? [14:14:28] (03CR) 10Henning Snater: "I do not like the term fingerprint that much as well although I have no proper alternative at hand. My initial naming, before I noticed th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [14:16:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [14:18:57] Svetlana: yes, but only via api [14:24:08] lazowik|afk: No interface for this? Whom would you suggest to poke about this? :-) [14:24:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155255 (owner: 10Thiemo Mättig (WMDE)) [14:35:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [14:38:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155533 (owner: 10Henning Snater) [14:44:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155535 (owner: 10Aude) [14:45:36] (03PS13) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [14:52:23] Thiemo_WMDE: will you merge https://gerrit.wikimedia.org/r/#/c/154322/ ? [14:52:26] JeroenDeDauw already gave his +1 [14:55:47] (03PS1) 10Aude: Drop 5.3 repo only travis build (in German) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155550 [15:05:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [15:08:09] Svetlana: I think Lydia_WMDE is well aware that there is no ui for that :) [15:11:25] (03PS25) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [15:18:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155550 (owner: 10Aude) [15:19:24] (03PS2) 10Bene: Introduce HtmlGeneratorTestCase to validate HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 [15:22:00] benestar: do we have a star icon for http://bits.wikimedia.org/static-1.24wmf17/extensions/Wikidata/extensions/Wikibase/lib/resources/images/wb-badges-empty.svg ? [15:22:36] aude: no, where would we need one? :O [15:23:00] when i click edit for a site link, it shows me the empty icon [15:25:20] or there are no stars? [15:25:32] lazowik: ok; I think no need for the specific case probably [15:25:38] danke [15:25:50] i see, default is blue [15:26:00] wikidata is gold and silver, no stars [15:26:27] Svetlana: your welcome :) [15:27:21] Lydia_WMDE: I hope this is a special case [15:27:45] yeesterday I explained to someone at plwiki [15:28:04] that managing iw links is *not* the main purpose of Wikidata [15:28:27] :O [15:28:43] he thought that statements are there to help decide to which Wikipedia articles to link [15:30:41] (03CR) 10Fomafix: Sanitized RepoApi.js (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [15:31:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [15:31:58] (03PS2) 10Bene: Record usage of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155276 [15:32:21] aude: yeah, we do not use stars at wikidata at all ;) [15:34:08] what is https://github.com/wmde/WikimediaBadges for ? [15:35:00] client? [15:35:02] aude: yes [15:35:10] this is the extension which contains the stars [15:35:16] oooh [15:35:21] aude: btw, may you merge the pull request on it? [15:35:27] I think there is an open one [15:35:38] looking [15:35:40] yes there is [15:35:51] to support cologneblue skin as well [15:35:55] heh :) [15:36:24] who uses cologneblue? [15:37:30] Jhs: don't know but we should support it as well ;) [15:37:43] how do i get the class to be .badge-featuredarticle ? [15:37:44] sure, why not ^^ [15:37:51] i set labels as such [15:37:56] aude: that's another config change [15:38:05] oh [15:38:11] do we have patch yet? [15:38:19] aude: öhm... [15:38:24] we don't need yet but so i can see how to do it [15:38:24] * benestar looks [15:39:24] badgeClassNames [15:39:31] array( 'Q101' => 'wb-badge-goldstar' ) [15:39:44] aude: yes [15:39:57] remember raging about having examples, so that helps [15:40:03] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "* I'm afraid I found a major bug. Steps to reproduce: Start adding a sitelink. Type a letter but don't pick the first site, pick an other." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [15:40:41] aude: btw, the documentation is outdated o.O [15:40:49] oh no [15:41:46] lazowik: Oo [15:42:18] Lydia_WMDE: I really hope this is an exception [15:42:32] me too! [15:45:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 (owner: 10Bene) [15:46:25] (03CR) 10Tobias Gritschacher: "Can reproduce the issue with the siteselector and pagesuggester - good catch Thiemo." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [15:46:33] (03PS1) 10Bene: Update outdated documentation on badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155570 [15:46:42] aude: merge? --^ [15:49:49] in the client there is no default styling [15:49:57] maybe we want to document that [15:50:02] (03PS6) 10Thiemo Mättig (WMDE): Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [15:50:07] up to the site administrator or users to add the css [15:50:18] (03CR) 10jenkins-bot: [V: 04-1] Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [15:50:26] aude: mention that in the documentation? Maybe [15:50:39] people might be confused otherwise [15:51:33] aude: btw, can you turn on github notifications for the two repositories on this channel? [15:51:41] tobi! [15:51:44] Tobi_WMDE_SWE: [15:51:54] (03PS7) 10Thiemo Mättig (WMDE): Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [15:51:59] i'm sure i could but don't know where/how or even if i have permission to do that [15:52:17] no haz settings [15:54:29] aude: there's a bot from addshore that can enable it.. Not sure where it is. I'm afk, can have a look tomorrow.. [15:54:56] (03PS2) 10Bene: Update outdated documentation on badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155570 [15:55:21] aude: Tobi_WMDE_SWE: thanks :) [15:55:28] dewiki has clases like interlanguage-link interwiki-af badge-Q17437796 FA currently [15:55:30] btw, I added a sentence to the config [15:55:40] the star is added with 'FA' ? [15:55:41] aude: :) [15:55:47] aude: yes, at the moment [15:56:00] when we enable the badges extension, how do those co-exist? [15:56:04] I will change the script which adds the FA to check if badge-featuredarticle is already added [15:56:12] I got global editinterface for that task [15:56:17] oh :) [15:56:27] however, dewiki cannot get fixed currently as the common.js is superprotected -.- [15:56:40] yikes [15:57:26] Lydia_WMDE: maybe you can ping Erik about that? It's really weird and we cannot deploy badges on dewiki if we cannot fix the script before... [15:57:47] benestar: ok [15:58:01] benestar: can you prepare the needed change? [15:58:06] then i will email him [15:58:07] currently we enable this for all clients (next week) [15:58:21] Lydia_WMDE: hmm, how can I prepare that best? [15:58:33] just changed wikitext i guess [15:58:36] ok [15:58:38] so he can paste it in [16:01:46] [13WikibaseDataModel] 15thiemowmde created 06ediffalias (+1 new commit): 02http://git.io/wp-cGA [16:01:46] 13WikibaseDataModel/06ediffalias 14a9c875b 15Thiemo Mättig: Stop using EntityDiff alias [16:02:01] [13WikibaseDataModel] 15thiemowmde opened pull request #149: Stop using EntityDiff alias (06master...06ediffalias) 02http://git.io/thBzbw [16:03:58] benestar: wikimedia badges is for client only? or both? [16:04:21] aude: only for clients [16:04:24] aude: repo icons are in wikidata.org [16:04:24] ok [16:04:32] lazowik: got it [16:04:47] aude: you merged change to that yesterday :p [16:05:04] benestar: why not use the same classes at clients as the current ones? [16:05:14] rage [16:05:26] ? [16:05:45] lazowik: i think the communities should keep the icons they use now [16:05:47] lazowik: they are evil [16:05:53] the stars will work for most [16:06:08] Lydia_WMDE: are you ok with this? http://pastebin.com/VgV2mDJG [16:06:18] i don't htink they would like if we changed them [16:06:18] aude: maybe you can also check if I did some silly typo ;) [16:06:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155276 (owner: 10Bene) [16:06:43]