[01:53:49] [13Serialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/3dGGjg [01:53:49] 13Serialization/06master 148e06ec5 15jeroendedauw: Minor tweaks [01:57:17] [13Serialization] 15JeroenDeDauw tagged 063.2.1 at 06master: 02http://git.io/WwcipA [01:59:24] [travis-ci] wmde/Serialization/3.2.1/8e06ec5 : jeroendedauw The build passed. http://travis-ci.org/wmde/Serialization/builds/32919323 [03:14:23] (03PS1) 10Aude: Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 [03:14:30] (03CR) 10jenkins-bot: [V: 04-1] Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [03:18:58] (03PS2) 10Aude: Move EntityTitleLookup into Wikibase\Lib\Store namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 [03:21:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [03:27:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154982 (owner: 10Aude) [05:53:48] (03CR) 10Henning Snater: [C: 032] Remove unused dependency from pagesuggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154880 (owner: 10Thiemo Mättig (WMDE)) [05:57:13] (03PS6) 10Henning Snater: Added $container option to $.wikibase.toolbarbase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152016 [06:06:32] (03PS7) 10Henning Snater: Added $container option to $.wikibase.toolbarbase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152016 [06:10:40] (03PS6) 10Henning Snater: Refactored $.wikibase.toolbar* test definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 [06:12:17] (03PS5) 10Henning Snater: Optimized edittoolbar retrieving parent widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152021 [06:13:03] (03PS6) 10Henning Snater: Improved $.wikibase.siteselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152038 [06:13:17] (03PS5) 10Henning Snater: Added badge template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 [06:14:06] How can I clear the indicator that has it that I have so many messages ? [06:16:14] (03PS6) 10Henning Snater: Added badge template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 [06:18:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152016 (owner: 10Henning Snater) [06:23:02] (03PS10) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [06:38:21] (03PS11) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [06:40:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152016 (owner: 10Henning Snater) [07:03:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 (owner: 10Henning Snater) [07:17:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152021 (owner: 10Henning Snater) [07:25:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152038 (owner: 10Henning Snater) [07:33:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 (owner: 10Henning Snater) [07:42:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 (owner: 10Henning Snater) [07:48:09] GerardM-: the red indicator of notifications? [07:48:20] there should be a "Mark all as read" button in the flyout [07:49:15] I can show you a screenshot that there is not [07:49:45] as it is it is not working for me [07:50:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [07:51:03] yes please [07:59:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [08:10:11] [13WikidataBrowserTests] 15snaterlicious pushed 1 new commit to 06new_sitelinks_ui: 02http://git.io/kepZJw [08:10:11] 13WikidataBrowserTests/06new_sitelinks_ui 14fa6ceea 15snaterlicious: Additional updates [08:10:33] (03PS12) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [08:11:18] (03PS5) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [08:12:13] (03PS5) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [08:12:51] (03PS3) 10Henning Snater: Propagating editable state in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 [08:14:07] (03PS5) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [08:19:19] (03PS6) 10Henning Snater: Implemented jQuery.wikibase.sitelinkgroupview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 [08:36:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [08:37:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a73a16b : Henning Snater The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32939541 [08:41:46] (03PS3) 10Henning Snater: Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 [08:47:24] [13WikibaseDataModel] 15reiz opened pull request #147: Updating Dependency Badge and adding Reference Badge (06master...06master) 02http://git.io/6mkI2A [08:49:33] (03PS4) 10Henning Snater: Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 [08:56:43] (03PS13) 10Tobias Gritschacher: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [08:56:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [09:14:28] (03PS14) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [09:17:28] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 (owner: 10Henning Snater) [09:32:39] (03PS5) 10Henning Snater: Sanitized RepoApi.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 [09:34:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 (owner: 10Henning Snater) [09:42:27] it's THE day :) [09:45:14] hi there! [09:45:50] does anyone have a link to the widget used on ruwiki to do in-place editing on wikidata? [09:46:13] Lydia_WMDE perhaps? :D [09:46:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [09:53:21] johl: if you find it, please link it to sannita [09:55:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153564 (owner: 10Henning Snater) [09:56:31] johl: here's info on project chat: https://www.wikidata.org/wiki/Wikidata:Project_chat#Edit_directly_from_infocard_.2F_infobox [09:56:38] "Adding such functionality to your local language is quite complicated." [10:00:04] johl: that's be this: https://ru.wikipedia.org/wiki/MediaWiki:Gadget-wefinfobox.js [10:00:37] (03PS1) 10WikidataBuilder: New Wikidata Build - 19/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154997 [10:04:45] it's a benestar! [10:06:11] hey lazowik :) [10:06:42] (03PS9) 10Thiemo Mättig (WMDE): [WIP] Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [10:13:01] (03CR) 10Henning Snater: [C: 032] Use $() instead of mw.hook( 'wikipage.content' ).add() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154532 (https://bugzilla.wikimedia.org/69674) (owner: 10Gerrit Patch Uploader) [10:14:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [10:22:52] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/eb85b3c : Thiemo Mättig (WMDE) The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32947225 [10:25:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [10:27:32] JeroenDeDauw: I need $item->getStatements() in Wikibase.git [10:27:40] can we backport that, too? [10:27:56] I hate it to use methods I know that will be deprecated in future [10:30:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154997 (owner: 10WikidataBuilder) [10:35:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [10:36:55] (03CR) 10Tobias Gritschacher: "What is the status of this? Is this still needed (then please follow-up) or can this be abandoned?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) (owner: 10Aude) [10:37:24] (03Abandoned) 10Aude: Force EditFilterMergedHook to be registered in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) (owner: 10Aude) [10:43:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [10:49:02] (03PS1) 10Thiemo Mättig (WMDE): Improve code readability in EntityContent and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155006 [10:56:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151854 (owner: 10Henning Snater) [10:59:49] (03PS10) 10Lucie Kaffee: [WIP] Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) [11:09:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:17:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155006 (owner: 10Thiemo Mättig (WMDE)) [11:26:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [11:34:27] (03CR) 10Aude: "generally looks ok, though some of the changes are style preference things and imho not necessarily improve readability." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155006 (owner: 10Thiemo Mättig (WMDE)) [11:37:33] (03CR) 10Aude: [C: 032] New Wikidata Build - 19/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154997 (owner: 10WikidataBuilder) [11:38:11] (03Abandoned) 10Aude: New Wikidata Build - 18/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154776 (owner: 10WikidataBuilder) [11:38:17] (03Abandoned) 10Aude: New Wikidata Build - 17/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154454 (owner: 10WikidataBuilder) [11:38:22] (03Abandoned) 10Aude: New Wikidata Build - 16/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154393 (owner: 10WikidataBuilder) [11:38:26] (03Abandoned) 10Aude: New build, with tagged version of property suggester [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154089 (owner: 10Aude) [11:45:15] Can you ping me when the badges or Wikinews is deployed? [11:47:09] (03Merged) 10jenkins-bot: New Wikidata Build - 19/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154997 (owner: 10WikidataBuilder) [11:53:58] (03PS6) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 [11:54:07] (03CR) 10jenkins-bot: [V: 04-1] Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [12:01:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [12:01:45] aude: are you doing badges/Wikinews in your deployment window? [12:02:10] As I see them listed in the now-'we are not here for this'-MediaWiki train window. [12:08:08] (03PS7) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 [12:19:36] (03CR) 10Bene: "Thiemo: I'm preparing a follow up for the test. However, this patch only adopts what was already there so imo this is no blocker. Furtherm" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [12:21:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [13:11:58] (03PS11) 10Lucie Kaffee: Add ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) [13:21:30] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154997 (owner: 10WikidataBuilder) [13:26:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee) [13:44:01] (03PS6) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [13:45:03] (03PS6) 10Henning Snater: Optimized jQuery.wikibase.sitelinkview.isInitialValue [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 [13:45:04] (03PS4) 10Henning Snater: Propagating editable state in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 [13:55:51] (03PS1) 10Thiemo Mättig (WMDE): Trim site name on Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155031 [14:08:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [14:20:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152956 (owner: 10Henning Snater) [14:23:56] (03PS1) 10Lucie Kaffee: delete the method getPossibleErrors of ApiModules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155042 [14:26:10] (03CR) 10Tobias Gritschacher: [C: 032] Added $container option to $.wikibase.toolbarbase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152016 (owner: 10Henning Snater) [14:32:28] (03CR) 10Tobias Gritschacher: [C: 04-1] "If I run QUnit tests with debug=false I get:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 (owner: 10Henning Snater) [14:34:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153394 (owner: 10Henning Snater) [14:35:53] (03CR) 10Tobias Gritschacher: "It seems to be a general problem. I'm also getting something similar on current master. Some missing dependency?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 (owner: 10Henning Snater) [14:36:41] (03CR) 10Tobias Gritschacher: "Addition: I'm running" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152020 (owner: 10Henning Snater) [14:41:01] aude: please see myCR [14:41:13] * my CR [14:41:39] Didn't look at all patches, though [14:41:59] So let Daniel or someone do CR ;) [14:42:12] * hoo out for today [14:42:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155031 (owner: 10Thiemo Mättig (WMDE)) [14:45:04] Did my messages make it? [14:45:24] Point is: I didn't review everything [14:45:42] So somebody else should ;) [14:51:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155042 (owner: 10Lucie Kaffee) [14:56:00] (03CR) 10Bene: [C: 04-1] "while you're at it... ;-)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155031 (owner: 10Thiemo Mättig (WMDE)) [15:04:22] (03PS2) 10Tobias Gritschacher: Trim site name on Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155031 (owner: 10Thiemo Mättig (WMDE)) [15:07:35] Lydia_WMDE: do we want to display badges for cologneblue skin, too? [15:07:49] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a4b529b : Tobias Gritschacher The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32968871 [15:07:51] see https://de.wikipedia.org/wiki/MediaWiki:Cologneblue.css for a possible solution [15:08:06] benestar: are they shown right now? [15:08:10] then yes imho [15:08:27] ok, then we have to check in the WikimediaBadges extension for the skin [15:17:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155031 (owner: 10Thiemo Mättig (WMDE)) [15:23:02] (03PS8) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 [15:36:08] (03PS9) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 [15:37:41] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/a2cb18e : Tobias Gritschacher The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32969659 [15:42:19] (03PS15) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [15:42:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [15:45:05] (03PS7) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [15:49:47] (03PS8) 10Henning Snater: Removed site link scraping from entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 [15:49:51] (03PS10) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 [15:49:53] (03PS1) 10Bene: Introduce ViewTestCase to validate HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155056 [15:51:35] review! https://gerrit.wikimedia.org/r/#/q/status:open+project:operations/mediawiki-config+branch:master+topic:wikidata,n,z :) [15:53:58] (03PS11) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 [16:03:37] for https://www.wikidata.org/wiki/Property:P658 , is it kosher to create items for songs which don't have articles in any wikipedias? what are the current policies in that area? [16:08:17] You can create them. [16:08:30] https://www.wikidata.org/wiki/Wikidata:Notability [16:08:34] 2 and 3. [16:08:41] Hi Jhs, I think according to the notability policy it'd be ok [16:08:59] cool, thanks [16:09:12] it's halal, indeed [16:09:14] "it is needed to make statements made in other items more useful" :) [16:09:24] :) [16:09:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [16:21:57] (03PS1) 10Bene: Introduce ViewTestCase to validate HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 [16:22:12] (03Abandoned) 10Bene: Introduce ViewTestCase to validate HTML output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155056 (owner: 10Bene) [16:31:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [16:45:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [16:48:05] (03PS16) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [16:58:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152953 (owner: 10Henning Snater) [17:06:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [17:15:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155056 (owner: 10Bene) [17:24:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene) [17:30:18] (03CR) 10Bene: [C: 032] Added badge template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152215 (owner: 10Henning Snater) [17:33:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155060 (owner: 10Bene) [17:33:32] aude: already deployed? [17:33:47] soon [17:34:45] we put wikidata (and other sites) on new branch [17:34:52] then do config for badges, etc [17:36:17] (03CR) 10Bene: [C: 032] "thanks Tobi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155031 (owner: 10Thiemo Mättig (WMDE)) [17:39:25] benestar, you here? [17:39:49] Jhs: indeed [17:39:58] i'd like to subtly point you towards https://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Administrator#Jon_Harald_S.C3.B8by_2 :P [17:40:38] oh dear, totally forgot this... [17:40:44] Jhs: too much dev stuff atm ;) [17:41:04] mkay, np :) [17:41:15] Jhs: what you're not an admin yet? [17:41:29] aude, nope [17:41:33] awww [17:42:06] Jhs: now you are ;) [17:42:14] benestar, grazie :D [17:42:27] you're welcome ;) [17:42:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [17:42:38] \o/ [17:42:44] Jhs: do you want the Admin welcome template again on your talk page [17:42:45] ? [17:43:01] benestar, hehe not really necessary ;) [17:43:15] maybe it helps you, if it's updated :P [17:43:40] Jhs: but for politeness ;) [17:43:50] Stryn: and that :P [17:44:04] in that case, sure why not ;) [17:46:58] Jhs: at least closed within 24 hours :) [17:47:07] (by 8 minutes) [17:47:17] hehehe, niice [18:20:56] (03PS1) 10Aude: Fix silly typo in EntityChange that is causing fatal errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155088 [18:22:22] benestar: JeroenDeDauw Tobi_WMDE_SWE ^ [18:22:49] aude: commit msg does not sound good... [18:22:50] (03PS1) 10Aude: Fix silly typo in EntityChange that is causing fatal errors [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155090 [18:22:55] heh [18:23:01] * aude can change it [18:23:14] (03PS2) 10Aude: Fix typo in EntityChange that is causing fatal errors [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155090 [18:23:30] (03CR) 10Bene: [C: 032] "indeed silly" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155088 (owner: 10Aude) [18:23:40] i don't know how we missed it [18:24:02] aude: I mean the commit message makes me feeling scared ;) [18:24:34] (03PS2) 10Tobias Gritschacher: Fix typo in EntityChange that is causing fatal errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155088 (owner: 10Aude) [18:24:37] (03CR) 10Tobias Gritschacher: [V: 032] Fix typo in EntityChange that is causing fatal errors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155088 (owner: 10Aude) [18:25:58] ok, verified [18:26:08] :) [18:26:12] great :D [18:27:42] running tests and then will +2 so we can proceed [18:28:16] (03CR) 10Aude: [C: 032 V: 032] "verified manually and tests pass for me on client and repo" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155090 (owner: 10Aude) [18:28:23] sure jenkins willa gree [18:34:05] (03PS1) 10Aude: New build, fix fatal error in change notification jobs [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155092 [18:44:29] (03CR) 10Aude: [C: 032] New build, fix fatal error in change notification jobs [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155092 (owner: 10Aude) [18:45:18] (03CR) 10Aude: [V: 032] "tests already passed and also verified myself" [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155092 (owner: 10Aude) [18:54:16] aude: ugh - the tests did not catch this? :( [18:54:19] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155088 (owner: 10Aude) [18:54:31] (03PS1) 10Bene: [DRAFT] Inject ClaimsView and FingerprintView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155096 [18:54:37] benestar: you are supposed to shout FIRST!!!! [18:55:02] JeroenDeDauw: when shout? [18:55:14] benestar: you merged the commit before me or Tobi_WMDE_SWE [18:55:26] oh, I see :D [18:55:35] * benestar shouts FIRST [18:55:46] JeroenDeDauw: obviously we need to see why tests did not catch and fix [18:56:05] JeroenDeDauw: after I've killed EntityView I'm supposed to kill EntityContent, right? [18:58:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/88ac655 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32992973 [19:00:27] Lydia_WMDE: is there already a bug for refactoring EntityContent? [19:00:47] benestar: looking [19:00:54] because after I moved some code out of EntityView the next step will be refactoring EntityContent [19:01:15] maybe the action classes? [19:01:17] this will already help a lot for introducing other entity types from outside [19:01:41] benestar: https://bugzilla.wikimedia.org/show_bug.cgi?id=67238 and https://bugzilla.wikimedia.org/show_bug.cgi?id=65531 are what i can find [19:02:21] Lydia_WMDE: I will create a new bug and mark those two as blockers [19:02:29] and perhaps create some other blockers, too [19:02:33] if you are ok with that? [19:03:06] benestar: totally [19:11:17] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155090 (owner: 10Aude) [19:11:29] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155092 (owner: 10Aude) [19:11:49] bah [19:12:34] Lydia_WMDE: for Wikiquote, which project should I choose when filing bugs? [19:12:46] also wikidatarepo`? [19:12:49] benestar: yeah [19:13:11] composer fail [19:16:32] \o/ [19:16:45] benestar: what are you trying to do? Get rid of things mirroring the Entity inheritance hierarchy? [19:16:50] Lydia_WMDE: is there a bug for Commons? [19:16:57] JeroenDeDauw: ineed [19:16:59] *d [19:17:09] and making the code better at all [19:17:17] EntityContent is just a mess also without inheritance [19:17:18] benestar: why did you start with EntityView? [19:17:24] JeroenDeDauw: why not? [19:17:33] benestar: https://bugzilla.wikimedia.org/show_bug.cgi?id=64288 [19:17:33] I had to start somewhere [19:17:44] benestar: k [19:17:55] benestar: we have badges [19:18:10] i don't know about the css part but if i need to do something.... [19:18:20] benestar: EntityContent as well probably, though I'm not sure this is one of the more serious issues [19:18:28] EntityContent has a number of problems, including this mirroring [19:18:45] Though it's a thing that resides, or at least should reside, at the edges of the system [19:18:49] Since it's a data access thing [19:19:09] JeroenDeDauw: you mean EntityContent should stay there? [19:19:21] I'm not sure what other instances of mirrored hierrachies we have though - would need to look though the code [19:19:39] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155090 (owner: 10Aude) [19:20:10] now redirects [19:20:49] benestar: no - I think it's good to also take care of EntityContent, all I'm saying is that I'd first look if there are no higher prio violations [19:21:08] * aude votes for the action classes [19:21:12] evil [19:21:30] although challenging the way they interact with core [19:22:23] aude: is there a bug for that, too? [19:22:32] lolol, ViewPropertyAction and ViewItemAction... hahahaha [19:22:50] benestar: no idea [19:23:06] btw, what does action mean in that context? [19:23:28] it hijacks action=view [19:23:32] aude: yeah, agreed, lots of evil. Extreme abuse of inheritance [19:23:45] to present our stuff instead of default whatever mediawiki does [19:23:52] and action=edit etc [19:23:59] https://www.wikidata.org/w/index.php?title=Q56194&diff=prev&oldid=151770760 [19:24:33] yay [19:24:40] benestar: putting application and domain code in actions is as bad as putting it in a API or SpecialPage class [19:24:56] * aude rearranges site links now :) [19:25:01] Amir1: \o/ [19:25:06] :) [19:25:11] It's just the start [19:25:11] Most of it probably belongs in a delivery agnostic controller (ie, that won't know about MediaWiki) [19:25:22] Some of it might belong in domain objects [19:25:29] what is good article badge item? I lost it [19:25:55] Amir1: https://wikidata.org/wiki/Category:Badge_items [19:27:18] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #147: Updating Dependency Badge and adding Reference Badge (06master...06master) 02http://git.io/6mkI2A [19:27:28] JeroenDeDauw: I think the Actions classes is some part of the code I never put my feet into... [19:28:01] benestar: thanks [19:28:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155088 (owner: 10Aude) [19:28:14] benestar: don't put any body part into it, it'll spontaniously get cancer [19:28:44] JeroenDeDauw: puh, almost did :P [19:28:55] well, will file a bug with a big red warning on top of it [19:29:22] aude: why isn't that change live? https://gerrit.wikimedia.org/r/#/c/154325/ [19:29:32] it should fix the badges display problems [19:30:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/155096 (owner: 10Bene) [19:31:07] benestar: looking [19:31:24] has to be backported [19:31:35] hmm, ok [19:31:42] * aude do other things first [19:43:47] Is there any way to hide "good article" for nlwiki? We don't have that badge. [19:45:25] benestar: ^ [19:47:50] sjoerddebruin: Don't add it? [19:48:02] I'm just worried that people do vandalism with it. [19:48:21] That is the best vandalism :p [19:48:35] 'How can we be disruptive?' Mark all nlwiki articles as good!!! :p [19:51:28] sjoerddebruin: should probably just be another constraint report or abuse filter? [19:51:42] Would love that. [19:51:44] JohnLewis: well they'd be shown in the sidebar of other wikis potentially [19:52:09] "Oh, my article looks pretty good. Let's mark it as good article" [19:52:11] Lydia_WMDE: I know :) [19:52:21] :P [19:54:26] I've expected badges on thursday, no idea why. Probally because that's the normal deployday. [19:54:47] sjoerddebruin: for wikipedia. wikidata is tuesdays :) [19:54:54] :D [19:54:57] you can now add site links to wikidata itself (help pages, etc) [19:55:07] \o/ [19:55:08] next to make it a client [19:55:23] aude: i have announcements ready. let me know when you're done with everything and i'll send it out [19:55:25] I want the better entity suggester :( [19:55:32] sjoerddebruin: next week :) [19:55:34] if there are caching issues, at the end i will have to bump the parser cache thing [19:55:38] So long waiting!!!!! [19:55:40] will be necessary [19:55:46] just letting you know I just started harvesting all of featured and good badges from every wiki [19:55:48] sjoerddebruin: :P [19:55:59] I've needed to purge the page, aude. [19:55:59] Amir1: sweet [19:56:10] :) [19:56:18] And corrected three translations using a other word than "badge" [19:56:27] sjoerddebruin: qualifier suggesters :D [19:56:30] is wikinews deployed? I have some other scripts to run too [19:56:39] Amir1: last thing on my list [19:56:40] JohnLewis: I want a better value suggester. [19:56:57] Position based on number of sitelinks is bullshit. [19:57:01] thanks aude [19:57:23] sjoerddebruin: no qualifier suggester is better! [19:57:23] Why do I have to select the 7th(!) option to mark someone as men. [19:57:58] sjoerddebruin: because 7 is an awesome number [19:57:59] ;-) [19:58:06] No. [19:58:11] It's plainly stupid. [19:58:11] :/ [19:58:17] *sob* [19:58:18] Lydia_WMDE: No, 2013 is :p [19:58:26] JohnLewis: ;-) [19:58:38] !q 2013 [19:58:38] https://www.wikidata.org/wiki/Q2013 [19:58:56] for those who didn't get the reference :P [19:59:12] JeroenDeDauw <3 the !q thing :p [19:59:36] !q 12345 [19:59:37] https://www.wikidata.org/wiki/Q12345 [19:59:58] i am seeing some js errors (might be caching) [20:00:03] one* error [20:00:04] Uncaught TypeError: Cannot read property 'getSite' of undefined [20:00:21] line 111 of wikibase.js on pages like Special:Version [20:00:30] not critical but annoying [20:00:33] Oh dear, "Pages on other sites linked to this item" isn't translated!!!!!!!! [20:00:33] !! [20:00:37] !q 5223 [20:00:37] https://www.wikidata.org/wiki/Q5223 [20:00:41] go to translatewiki! [20:00:42] https://www.wikidata.org/wiki/Special:Version [20:00:46] Hurrryyyyyy [20:01:16] * Stryn translated it just some hours ago [20:01:30] https://translatewiki.net/wiki/MediaWiki:Wikibase-sitelinks-special/nl :) [20:01:44] * sjoerddebruin checking for other stuff [20:04:45] Oh my god, the toc will grow into three rules soon. :( [20:05:22] aude: it seems possible to add links to testwikidata on wikidata [20:05:34] sjoerddebruin: yeah that'll go away with the new design [20:05:43] It is possible :p [20:05:44] Lydia_WMDE: caching [20:05:48] oh [20:05:52] kk :) [20:05:56] ok cool [20:05:57] hmph [20:05:58] Any TOA yet? [20:06:05] sjoerddebruin: for new design? [20:06:09] if it doesn't go away, i will poke stuff [20:06:09] Yeah [20:06:12] sjoerddebruin: Next decade :D [20:06:20] :O [20:06:20] * Lydia_WMDE looks at JohnLewis [20:06:32] sjoerddebruin: we've started implementing [20:06:37] Lydia_WMDE: it's more realistic than your 'something basically useable this year' :p [20:06:44] the first changes should come with the next 2 or 3 deployments [20:06:47] :D [20:06:51] but it'll take a while to be completely done [20:06:56] JohnLewis: :P [20:07:02] ~1 decade sjoerddebruin [20:08:58] * aude rage to have the populateSitesTable script independent of wikibase [20:09:13] yet don't know a good place for it, core perhaps [20:09:38] Lydia_WMDE: You've said yesterday that the entity suggester needs a manual update every time? [20:10:14] the data it uses for suggestions needs to be updated every now and then [20:11:01] Okay. No difference here yet since the deploy. :( [20:11:07] And I'm working so hard!!! [20:14:42] the featured list isn't a valid it seems [20:15:21] Amir1: yeah only good and featured article to start with [20:15:49] sjoerddebruin: *hug* [20:16:02] Lydia_WMDE: still awesome :) [20:17:05] !JohnLewis [20:17:08] mhh [20:17:14] xD [20:17:36] (03PS1) 10Aude: Enable populateSitesTable script to run without wikibase enabled [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/155119 [20:17:42] lolwat http://metrouk2.files.wordpress.com/2012/12/johnlewis.jpg [20:17:55] :D [20:18:12] * aude remindes people to review https://gerrit.wikimedia.org/r/#/c/145765/ [20:18:17]