[00:50:11] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: Refactor Fingerprint code out of EntityView (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene)
[00:50:16] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Refactor Fingerprint code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene)
[01:02:23] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/446fd61 : Jeroen De Dauw The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32597812
[01:15:57] <grrrit-wm>	 (03PS1) 10Hoo man: Fix FingerprintViewTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154226 
[01:16:02] <hoo|busy>	 JeroenDeDauw: ^
[01:16:16] <hoo|busy>	 or aude if still around
[01:30:31] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154226 (owner: 10Hoo man)
[01:30:48] <hoo|busy>	 Thiemo_WMDE: ^
[01:31:08] <hoo|busy>	 leaving now
[07:58:15] <Ainali>	 Lydia_WMDE: Hi, are there any plans for making a DCAT-AP descritption for Wikidata?
[07:59:03] <Ainali>	 Or rather, have it been discussed at all?
[07:59:03] <Lydia_WMDE>	 Ainali: what is that and what is it good for? ;-)
[07:59:14] <Lydia_WMDE>	 no
[07:59:30] <Ainali>	 It is a standard for description of LOD datasets
[07:59:41] <Lydia_WMDE>	 ok
[08:00:26] <Lydia_WMDE>	 not a priority atm tbh
[08:00:52] <Lydia_WMDE>	 but if you want to work on it write down some info and send it to the mailing list for discussion
[08:01:02] <Lydia_WMDE>	 including what would need to be done
[08:01:05] <Ainali>	 We are thinking on making an application to Swedish Innovation Agency to do an investigation wether it would be good to use it for us
[08:01:45] <Ainali>	 We could probably get around €10000 for an investigation
[08:01:52] <Lydia_WMDE>	 i'd start with an email to the mailing list
[08:01:54] <Lydia_WMDE>	 heh
[08:02:02] <Lydia_WMDE>	 ok...
[08:02:19] <Lydia_WMDE>	 i have a few things that are imho more important that we could do with 10000 :D
[08:02:25] <Ainali>	 I bet :)
[08:02:28] <Lydia_WMDE>	 anyway - need to go take a shower
[08:02:30] <Lydia_WMDE>	 back in a bit
[08:21:16] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix FingerprintViewTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154226 (owner: 10Hoo man)
[08:21:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix FingerprintViewTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154226 (owner: 10Hoo man)
[08:37:13] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/c2f0730 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32616417
[09:00:00] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "Whoo, what happened to this patch? I spend quite some time refactoring this code (when it was in EntityView). I was happy to see you left " (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene)
[09:00:30] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Revert "Refactor Fingerprint code out of EntityView" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 
[09:00:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "Refactor Fingerprint code out of EntityView" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 (owner: 10Thiemo Mättig (WMDE))
[09:14:20] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 (owner: 10Thiemo Mättig (WMDE))
[09:14:26] <julesw>	 test.wikidata is down. not showing items
[09:25:19] <julesw>	 not all pages. example: https://test.wikidata.org/wiki/Q344 I get Unknown column 'epp_redirect_target' in 'field list' in SqlEntityInfoBuilder::getPageInfoForType
[10:00:36] <grrrit-wm>	 (03PS1) 10WikidataBuilder: New Wikidata Build - 15/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154244 
[10:19:45] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154244 (owner: 10WikidataBuilder)
[10:21:27] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Fix SqlEntityInfoBuilder(Factory) constructor parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154250 
[10:23:47] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): Revert "Refactor Fingerprint code out of EntityView" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 
[10:24:31] <Tobi_WMDE_SWE>	 aude: can I merge https://gerrit.wikimedia.org/r/#/c/154244/ ?
[10:24:46] <aude>	 Tobi_WMDE_SWE: sure
[10:25:21] <Tobi_WMDE_SWE>	 aude: beta is still broken I guess?
[10:25:25] <aude>	 yes
[10:25:44] * aude has raged about finding logs for the errors
[10:25:47] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 15/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154244 (owner: 10WikidataBuilder)
[10:27:32] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on commit 14398774b: @JeroenDeDauw do you have any idea why the tests are failing here? Apparently some serialization does not work although I didn't touch the code at all. 02http://git.io/xE_XuA
[10:34:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: New Wikidata Build - 15/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154244 (owner: 10WikidataBuilder)
[10:37:25] <grrrit-wm>	 (03CR) 10Aude: [C: 031] "waiting for jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154250 (owner: 10Thiemo Mättig (WMDE))
[10:38:33] <grrrit-wm>	 (03PS1) 10Aude: Fix SqlEntityInfoBuilder(Factory) constructor parameters [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154251 
[10:43:50] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Refactor Fingerprint code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154252 
[10:47:01] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154250 (owner: 10Thiemo Mättig (WMDE))
[10:51:41] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Fix SqlEntityInfoBuilder(Factory) constructor parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154250 (owner: 10Thiemo Mättig (WMDE))
[10:51:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix SqlEntityInfoBuilder(Factory) constructor parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154250 (owner: 10Thiemo Mättig (WMDE))
[11:00:08] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 (owner: 10Thiemo Mättig (WMDE))
[11:08:56] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154251 (owner: 10Aude)
[11:17:55] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154244 (owner: 10WikidataBuilder)
[11:17:59] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154252 (owner: 10Thiemo Mättig (WMDE))
[11:28:39] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Make hide/show changes toggle respect showExternalRecentChanges setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude)
[11:28:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make hide/show changes toggle respect showExternalRecentChanges setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude)
[12:12:23] <grrrit-wm>	 (03CR) 10Bene: [C: 032] Revert "Refactor Fingerprint code out of EntityView" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 (owner: 10Thiemo Mättig (WMDE))
[12:12:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Refactor Fingerprint code out of EntityView" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154241 (owner: 10Thiemo Mättig (WMDE))
[12:32:34] <benestar>	 aude: \o/ https://test.wikidata.org/wiki/Q486
[12:32:46] <benestar>	 Lydia_WMDE: our first badges are life --^
[12:32:53] <benestar>	 though not really nice styled yet
[12:33:09] <Lydia_WMDE>	 \o/
[12:33:25] <aude>	 benestar: how do we configure them to make them nice?
[12:33:34] <aude>	 we have the wikidata.org git repo there
[12:36:01] <benestar>	 aude: they should be nice then...
[12:36:26] <benestar>	 the setting is correct, the badges have the wb-badge-goodarticle class
[12:39:17] <grrrit-wm>	 (03PS1) 10Aude: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) 
[12:39:20] <aude>	 evil!
[12:39:31] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] "So long as sitelinks stay part of wikibase (and this this repo) this script should stay part of wikibase (and thus this repo)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145765 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man)
[12:40:19] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Fix phpdoc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153697 (owner: 10Jeroen De Dauw)
[12:40:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix phpdoc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153697 (owner: 10Jeroen De Dauw)
[12:40:46] <Thiemo_WMDE>	 benestar: i felt so bad for the revert. now you merged it. ;-)
[12:41:08] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove dead line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153703 (owner: 10Jeroen De Dauw)
[12:41:08] <benestar>	 urgh
[12:41:10] <benestar>	 aude: the styling is there but the default style overrides the styles in wikidata.org
[12:41:12] <benestar>	 aude: we might fix that by adding !important but that isn't nice :/
[12:41:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove dead line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153703 (owner: 10Jeroen De Dauw)
[12:41:20] <benestar>	 Thiemo_WMDE: there were obviously errors
[12:41:27] * benestar should not submit patches after 1 am :P
[12:41:42] <Thiemo_WMDE>	 i'm working on it currently. adding more tests first. will let you know.
[12:41:52] <benestar>	 Thiemo_WMDE: hey, I'm working on that, too
[12:41:54] <grrrit-wm>	 (03PS2) 10Addshore: Remove unused vars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153711 (owner: 10Jeroen De Dauw)
[12:42:01] <benestar>	 please not conflicts ... 
[12:42:11] <grrrit-wm>	 (03PS2) 10Addshore: Remove some presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153712 (owner: 10Jeroen De Dauw)
[12:42:32] <Thiemo_WMDE>	 i already resubmitted your patch and i'm currently adding more tests. thats what i do.
[12:42:39] <grrrit-wm>	 (03PS1) 10Aude: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) 
[12:42:50] <addshore>	 wow, Henning has a lot of patches up!
[12:43:27] <aude>	 addshore: merge!
[12:43:38] <aude>	 merge the evil patch
[12:43:48] <aude>	 benestar: merge! :)
[12:44:09] <grrrit-wm>	 (03CR) 10Addshore: [C: 04-1] [wip] ApiConventionsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee)
[12:44:37] <grrrit-wm>	 (03Abandoned) 10Addshore: Jenkins job validation (DO NOT SUBMIT) [extensions/WikibaseSolr] - 10https://gerrit.wikimedia.org/r/152697 (owner: 10Hashar)
[12:44:40] <grrrit-wm>	 (03Abandoned) 10Addshore: Jenkins job validation (DO NOT SUBMIT) [extensions/WikibaseRepo] - 10https://gerrit.wikimedia.org/r/152696 (owner: 10Hashar)
[12:44:44] <grrrit-wm>	 (03Abandoned) 10Addshore: Jenkins job validation (DO NOT SUBMIT) [extensions/WikibaseLib] - 10https://gerrit.wikimedia.org/r/152694 (owner: 10Hashar)
[12:44:47] <grrrit-wm>	 (03Abandoned) 10Addshore: Jenkins job validation (DO NOT SUBMIT) [extensions/WikibaseClient] - 10https://gerrit.wikimedia.org/r/152693 (owner: 10Hashar)
[12:44:52] <benestar>	 Thiemo_WMDE: wtf???
[12:44:55] <benestar>	 argh
[12:45:27] <benestar>	 Thiemo_WMDE: I'm also adding tests...
[12:45:32] <benestar>	 how can this lead to a good end?
[12:45:40] <Thiemo_WMDE>	 hm...
[12:45:43] <Thiemo_WMDE>	 sorry.
[12:45:56] <Thiemo_WMDE>	 i will upload what i have and do something else.
[12:46:02] <benestar>	 Thiemo_WMDE: can we remerge my patch?
[12:46:10] <Thiemo_WMDE>	 which?
[12:46:16] <benestar>	 the reverted one
[12:46:18] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Fix SqlEntityInfoBuilder(Factory) constructor parameters [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154251 (owner: 10Aude)
[12:46:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix SqlEntityInfoBuilder(Factory) constructor parameters [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154251 (owner: 10Aude)
[12:46:27] <benestar>	 Thiemo_WMDE: so I can upload my patch set up to there
[12:46:29] <grrrit-wm>	 (03PS4) 10Addshore: Refactor MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE))
[12:46:37] <benestar>	 and then you can rebase your change if my patch gets merge
[12:46:39] <benestar>	 d
[12:46:55] <Thiemo_WMDE>	 sorry, dont understand. let me quickly finish this and upload it.
[12:47:04] <aude>	 omg
[12:47:09] <aude>	 don't merge my patch yet
[12:47:25] * aude needs to fix the ascii art
[12:47:58] <grrrit-wm>	 (03CR) 10Addshore: [C: 031] "Waiting on WDJenkins to run" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE))
[12:49:09] <grrrit-wm>	 (03PS2) 10Aude: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) 
[12:49:16] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Fix class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153710 (owner: 10Jeroen De Dauw)
[12:49:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153710 (owner: 10Jeroen De Dauw)
[12:49:34] <aude>	 https://gerrit.wikimedia.org/r/#/c/154260/2/lib/WikibaseLib.php
[12:49:59] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Minor cleanup in SnaksFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153698 (owner: 10Jeroen De Dauw)
[12:50:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Minor cleanup in SnaksFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153698 (owner: 10Jeroen De Dauw)
[12:50:24] <grrrit-wm>	 (03PS2) 10Aude: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) 
[12:50:37] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Improve phpdoc in ChangeHandlerTest and improve class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153699 (owner: 10Jeroen De Dauw)
[12:50:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve phpdoc in ChangeHandlerTest and improve class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153699 (owner: 10Jeroen De Dauw)
[12:51:41] <grrrit-wm>	 (03PS2) 10Addshore: Introducing ApiHelperFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler)
[12:51:47] <grrrit-wm>	 (03PS4) 10Addshore: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler)
[12:52:16] <addshore>	 much spam :>
[12:53:53] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): Refactor Fingerprint code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154252 
[12:55:23] <Thiemo_WMDE>	 benestar: https://gerrit.wikimedia.org/r/#/c/154252/ I added only tests, did not changed the class (only cosmetic changes, you can ignore them).
[12:57:15] <benestar>	 Thiemo_WMDE: ok, I will just work on my patch
[12:57:26] <benestar>	 we can then rebase yours and apply your changes
[12:57:40] <benestar>	 although I've already rewritten my code again ;)
[12:58:00] * benestar didn't expect you to fix his patches :P
[13:00:48] <benestar>	 Thiemo_WMDE: argh, I cannot push a patchset to the closed patch...
[13:00:56] <addshore>	 :O
[13:01:02] <addshore>	 remove the changeid from the commit message
[13:01:20] <benestar>	 addshore: will try
[13:03:26] <grrrit-wm>	 (03PS1) 10Bene: Refactor Fingerprint code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154261 
[13:03:33] <benestar>	 addshore: thanks :)
[13:03:38] <benestar>	 Thiemo_WMDE: you may want to review --^
[13:03:39] <addshore>	 no worries :)
[13:05:01] <aude>	 https://test.wikidata.org/w/api.php?action=wbparsevalue&format=json&parser=monolingualtext&values=fd&options=%7B%22valuelang%22%3A%22%22%7D
[13:05:08] <travis-ci>	 [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4f5ee96 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32631036
[13:05:40] <grrrit-wm>	 (03PS3) 10Thiemo Mättig (WMDE): Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[13:08:19] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "This test is testing all API modules, not just the Wikibase ones. As this test is in the Wikibase repository I think it should only check " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (https://bugzilla.wikimedia.org/67407) (owner: 10Lucie Kaffee)
[13:09:37] <grrrit-wm>	 (03PS2) 10Bene: Refactor Fingerprint code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154261 
[13:09:57] <FakirNL>	 I feel like [[User:ERDINC]] might not become an administrator
[13:10:38] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[13:11:41] <benestar>	 wut?
[13:11:43] <benestar>	 http://snag.gy/dYGh0.jpg
[13:11:45] <benestar>	 aude: --^
[13:12:15] <benestar>	 is that only me and my local testrepo?
[13:12:16] <aude>	 benestar: that's what my evil patch fixes
[13:12:22] <benestar>	 oh, ok :D
[13:37:05] <JeroenDeDauw>	 aude: hey, unfouded accusation of being evil! You evil person!
[13:40:14] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153711 (owner: 10Jeroen De Dauw)
[13:43:35] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14398774b: I do not know why it is failing - I'm not seeing this locally. 02http://git.io/ckdvTA
[13:46:20] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on commit 14398774b: So maybe travis is broken? 02http://git.io/iiDYhA
[13:46:47] <grrrit-wm>	 (03PS4) 10Aude: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) 
[13:52:28] <grrrit-wm>	 (03PS5) 10Aude: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) 
[13:53:06] <aude>	 Tobi_WMDE_SWE: merge https://gerrit.wikimedia.org/r/#/c/154260/ !
[13:53:43] <Tobi_WMDE_SWE>	 aude: I wanted Thiemo_WMDE to confirm it, as on my system I don't see the issue
[13:53:49] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw created 06test (+1 new commit): 02http://git.io/FI3ZgA
[13:53:49] <gh-wmde>	 13WikibaseDataModel/06test 14af51157 15jeroendedauw: Test
[13:53:49] <Tobi_WMDE_SWE>	 I don't have this setting set
[13:54:13] <aude>	 benestar: want to review ?
[13:54:39] <aude>	 does https://gerrit.wikimedia.org/r/#/c/154260/ fix the invalid stuff
[13:54:41] <aude>	 ?
[13:54:45] <benestar>	 aude: checking
[13:54:50] <aude>	 thanks
[13:55:02] <JeroenDeDauw>	 benestar: I will have a look at the failing thing on 0.9.x
[13:55:02] <benestar>	 lol https://gerrit.wikimedia.org/r/#/c/154259/1..2/lib/WikibaseLib.php
[13:55:02] * aude wants to be ready when greg is around
[13:55:09] <aude>	 heh
[13:55:10] <benestar>	 JeroenDeDauw: thanks :)
[13:55:18] <sjoerdde4209>	 :O
[13:56:16] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/test/af51157 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32636270
[13:56:30] <JeroenDeDauw>	 aude: heh... 
[13:56:34] <addshore>	 is wdjenkins dead or something? seems to be taking a very long time :<
[13:56:57] <aude>	 oh dear
[13:57:03] <Tobi_WMDE_SWE>	 addshore: no, someone just only rebased lot's of stuff ;)
[13:57:14] <benestar>	 Tobi_WMDE_SWE: hoo told me you could create another server running jenkins
[13:57:23] <benestar>	 wanna do?
[13:57:25] <JeroenDeDauw>	 aude: do you know what actually ends up invoking that code from data model? (talking about https://gerrit.wikimedia.org/r/#/c/154260/)
[13:57:36] <aude>	 SnakObject
[13:57:43] <Tobi_WMDE_SWE>	 benestar: there is one, but when we tried last we failed to get servers to communicate
[13:57:55] <benestar>	 :/
[13:58:03] <addshore>	 Tobi_WMDE_SWE: *cant wait to move back to wmf jenkins* ;p
[13:58:07] <benestar>	 Tobi_WMDE_SWE: and what about give the current server more power?
[13:58:19] <Tobi_WMDE_SWE>	 benestar: guess that would not help
[13:58:21] <benestar>	 or what addshore says if that worked
[13:58:22] <sjoerdde4209>	 Superjenkins?
[13:58:34] <Tobi_WMDE_SWE>	 our tests suck
[13:58:36] <addshore>	 benestar: Tobi_WMDE_SWE that wouldnt really work as we are still limited to running 1 of each job at a time
[13:58:39] <Tobi_WMDE_SWE>	 mediawiki tests suck
[13:58:48] <aude>	 https://github.com/wmde/WikibaseDataModel/blob/0.8.2/src/Snak/SnakObject.php#L169
[13:59:05] <aude>	 https://github.com/wmde/WikibaseDataModel/blob/0.8.2/src/Claim/Claim.php#L206
[13:59:07] <Tobi_WMDE_SWE>	 unit tests generally should not take more than a fraction of a second
[13:59:21] <Tobi_WMDE_SWE>	 but since we ahve to write stuff into DB that takes time
[13:59:23] <JeroenDeDauw>	 aude: yes, but what code in Wikibase.git...
[13:59:43] <aude>	 https://github.com/wmde/WikibaseDataModel/blob/0.8.2/src/Entity/Entity.php#L718 unstub claims
[13:59:50] <aude>	 JeroenDeDauw: none
[14:00:06] <aude>	 https://github.com/wmde/WikibaseDataModel/blob/0.8.2/src/Entity/Entity.php#L705 getClaims
[14:00:17] <aude>	 or very indirect
[14:00:24] <aude>	 in ways that are not present in 1.0
[14:00:51] <aude>	 $entity->getAllSnaks()
[14:00:51] <JeroenDeDauw>	 Right
[14:00:52] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove unused vars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153711 (owner: 10Jeroen De Dauw)
[14:00:57] <JeroenDeDauw>	 I forgot about this unstubbing part
[14:01:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unused vars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153711 (owner: 10Jeroen De Dauw)
[14:01:08] <JeroenDeDauw>	 So that indeed makes it not possible to remove the global for now
[14:01:13] <aude>	 sadly not
[14:01:13] <JeroenDeDauw>	 >_> evil spagethi code
[14:01:27] <JeroenDeDauw>	 aude: thanks for looking at this!
[14:01:56] <aude>	 glad it was something easy
[14:02:03] <aude>	 that will go away again soon
[14:02:14] <aude>	 EntityView.php:$entityIds = $refFinder->findSnakLinks( $entity->getAllSnaks() );
[14:02:28] <aude>	 and a couple other places we get all snaks
[14:02:42] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw created 06rmtest (+1 new commit): 02http://git.io/XrixPw
[14:02:42] <gh-wmde>	 13WikibaseDataModel/06rmtest 1485836b9 15jeroendedauw: Remove test that no longer works with the latest dependencies
[14:03:58] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw opened pull request #141: Remove test that no longer works with the latest dependencies (060.9.x...06rmtest) 02http://git.io/hNjxAg
[14:04:49] <grrrit-wm>	 (03CR) 10Bene: [C: 032] "tested locally" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:04:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:05:00] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14398774b: The failure is also on 0.8.x. https://travis-ci.org/wmde/WikibaseDataModel/jobs/32636276... 02http://git.io/Aqv6bg
[14:05:05] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/rmtest/85836b9 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32637091
[14:05:23] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 031] Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:05:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Can I +2 on deployment branches?" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:07:06] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06test at 14af51157: 02http://git.io/9DKJYg
[14:07:45] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153712 (owner: 10Jeroen De Dauw)
[14:07:58] <JeroenDeDauw>	 benestar: https://github.com/wmde/WikibaseDataModel/pull/141
[14:09:13] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/UmJwqg
[14:09:13] <gh-wmde>	 13WikibaseDataModel/06master 14d732945 15Jeroen De Dauw: Change now in 0.9.0
[14:10:10] <gh-wmde>	 [13WikibaseDataModel] 15Benestar pushed 1 new commit to 060.9.x: 02http://git.io/XMQITw
[14:10:10] <gh-wmde>	 13WikibaseDataModel/060.9.x 14ff744e9 15Bene*: Merge pull request #141 from wmde/rmtest...
[14:10:21] <gh-wmde>	 [13WikibaseDataModel] 15Benestar 04deleted 06rmtest at 1485836b9: 02http://git.io/eWbX1A
[14:10:34] <benestar>	 JeroenDeDauw: do we have to write this into the release notes
[14:10:36] <benestar>	 ?
[14:11:42] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on commit 14398774b: Thanks, I've merged the pull request. 02http://git.io/UBbp6A
[14:12:13] <benestar>	 Thiemo_WMDE: did you already have a look into my new FingerprintView?
[14:12:53] <JeroenDeDauw>	 benestar: write what in the release notes?
[14:12:54] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/0.9.x/ff744e9 : Bene* The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32637704
[14:13:40] <benestar>	 JeroenDeDauw: never mind, just realized it makes no sense to write test changes into the release notes
[14:17:18] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw created 06fpadd (+1 new commit): 02http://git.io/GVXraQ
[14:17:18] <gh-wmde>	 13WikibaseDataModel/06fpadd 1400f6c04 15jeroendedauw: Add hasLabel, hasDescription and hasAliasGroup to Fingerprint
[14:17:24] <JeroenDeDauw>	 benestar: You also wanted this? https://github.com/wmde/WikibaseDataModel/pull/142
[14:17:28] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw opened pull request #142: Add hasLabel, hasDescription and hasAliasGroup to Fingerprint (060.9.x...06fpadd) 02http://git.io/yCc7bA
[14:24:15] <JeroenDeDauw>	 benestar: huh, so apparently the thing does not get rebased...
[14:24:43] <benestar>	 which ting?
[14:24:46] <benestar>	 *thing
[14:24:52] <JeroenDeDauw>	 https://github.com/wmde/WikibaseDataModel/pull/142
[14:24:57] <JeroenDeDauw>	 This will go when it's merged
[14:25:32] <Lydia_WMDE>	 benestar: we will roll out the client part of badges the weeek after next, right? so one week after the repo part
[14:25:43] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06fpadd: 02http://git.io/A32nzw
[14:25:43] <gh-wmde>	 13WikibaseDataModel/06fpadd 147dab90d 15jeroendedauw: Merge branch '0.9.x' of github.com:wmde/WikibaseDataModel into 0.9.x
[14:25:57] <benestar>	 Lydia_WMDE: yes, should be ok
[14:26:15] <sjoerdde4209>	 :(
[14:26:15] <aude>	 yay
[14:26:21] <benestar>	 although we still have to fix sth
[14:26:21] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:26:23] <benestar>	 :P
[14:26:23] <Lydia_WMDE>	 benestar: is that also in the current configs?
[14:26:29] <Lydia_WMDE>	 what?
[14:26:46] <benestar>	 Lydia_WMDE: the icons are not displayed on repo because the default icons override the special icons
[14:27:06] <Lydia_WMDE>	 hah
[14:27:08] <Lydia_WMDE>	 ok
[14:27:10] <benestar>	 on my local machine it worked but apperently the order of how they get loaded is different on production
[14:27:16] <benestar>	 and we should not rely on any ordering
[14:27:28] <benestar>	 so for now we can just add a !important hack
[14:27:42] <Lydia_WMDE>	 k
[14:27:44] <benestar>	 but maybe there are better ways to do that?
[14:27:53] <Lydia_WMDE>	 probably
[14:28:14] <JeroenDeDauw>	 benestar: if that commit looks good to you, I can proceed with tagging 0.9
[14:28:35] * benestar is looking
[14:29:00] * JeroenDeDauw will be back in an hour
[14:29:19] <sjoerdde4209>	 Lunch, toilet, ...
[14:29:21] <grrrit-wm>	 (03CR) 10Aude: "@jeroen yes, please merge" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:29:27] <benestar>	 JeroenDeDauw: already done ;)
[14:29:27] <gh-wmde>	 [13WikibaseDataModel] 15Benestar closed pull request #142: Add hasLabel, hasDescription and hasAliasGroup to Fingerprint (060.9.x...06fpadd) 02http://git.io/yCc7bA
[14:30:05] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/fpadd/7dab90d : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/32639420
[14:30:22] <benestar>	 wut?
[14:34:42] <sjoerdde4209>	 Wut
[14:34:45] <sjoerdde4209>	 Wat
[14:34:52] <sjoerdde4209>	 Wot
[14:35:11] <aude>	 Thiemo_WMDE: Lydia_WMDE https://bugzilla.wikimedia.org/show_bug.cgi?id=69608
[14:35:26] <aude>	 don't know if this is related to why i get no suggestions
[14:39:22] <aude>	 https://test.wikidata.org/wiki/Property:P247 and https://test.wikidata.org/wiki/Property:P248
[14:39:25] <aude>	 same label
[14:40:18] <sjoerdde4209>	 :O
[14:40:44] <aude>	 evil anon editor https://test.wikidata.org/wiki/Special:Contributions/87.138.110.76 ;)
[14:43:37] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:43:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Re-add $evilDataValueMap global, still used in DataModel 0.8.2 [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[14:44:30] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE))
[14:49:18] <benestar>	 aude: how can that happen?
[14:49:26] <benestar>	 did someone remove the constraints?
[14:49:31] <aude>	 probably the slaves are not updated
[14:49:46] <aude>	 it might be checking a slave or cache for a label and doesn't find it yet
[14:49:50] <Lydia_WMDE>	 benestar: it can happen when they are created at the same time like here
[14:50:05] <benestar>	 :/
[14:50:09] <benestar>	 evil indeed
[14:50:24] <benestar>	 however, not that tragical because property creation is limited on wikidata itself
[14:50:30] <benestar>	 aude: should I delete one of them?
[14:50:39] <aude>	 benestar: if you want
[14:51:02] <benestar>	 aude: well, if it doesn't harm I will just let it there
[14:51:06] <aude>	 ok
[14:51:16] <benestar>	 however, I think it will break things when accessing a property by its label on client
[14:51:23] <benestar>	 not sure if that is already implemented though
[14:51:26] <aude>	 might be good to delete one if we want people to tes stuff
[14:51:27] <aude>	 test*
[14:51:37] <aude>	 and not confuse folks
[14:52:10] <benestar>	 aude: is accessing by label already implemented?
[14:52:22] <aude>	 yes
[14:52:34] <benestar>	 so what happends on testwikipedia?
[14:52:42] <benestar>	 and how does it work?
[14:52:55] * aude tries
[14:53:04] <aude>	 oh wait, can't
[14:53:27] <aude>	 editing claims is broken until we deploy bug fixes
[14:55:30] <grrrit-wm>	 (03PS1) 10Aude: Update Wikidata, fix database error and display of snak values [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154274 
[14:55:54] <benestar>	 aude: ups
[14:55:56] <benestar>	 https://test.wikidata.org/wiki/Q413
[14:56:22] <aude>	 :(
[14:56:34] * aude waits for jenkins then goes to find greg
[14:56:40] <benestar>	 aude: seems like almost everything is broken on testwikidata atm
[14:56:56] <aude>	 yep
[14:59:21] <benestar>	 aude: and now entirely broken
[14:59:26] <benestar>	 MediaWiki internal error.
[14:59:27] <benestar>	 Exception caught inside exception handler.
[14:59:29] <benestar>	 Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information.
[14:59:35] <benestar>	 white page ...
[15:00:50] <aude>	 that's the db error
[15:01:09] <aude>	 might depend on which apache server it is
[15:02:22] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[15:03:06] <benestar>	 Thiemo_WMDE: are you still at the office?
[15:03:11] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Update Wikidata, fix database error and display of snak values [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154274 (owner: 10Aude)
[15:03:32] <Thiemo_WMDE>	 benestar: yes. sorry, to many bugs, to many mails to write.
[15:03:47] <benestar>	 Thiemo_WMDE: ok, don't worry
[15:04:15] <benestar>	 just want to annoy you with my fingerprintview :P
[15:11:54] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154259 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[15:13:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikidata, fix database error and display of snak values [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154274 (owner: 10Aude)
[15:17:05] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154274 (owner: 10Aude)
[15:20:45] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler)
[15:22:16] <grrrit-wm>	 (03PS1) 10Aude: Handle MonolingualTextParser errors for values with language not set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154277 (https://bugzilla.wikimedia.org/69608) 
[15:23:06] <grrrit-wm>	 (03PS1) 10Aude: Handle MonolingualTextParser errors for values with language not set [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154279 (https://bugzilla.wikimedia.org/69608) 
[15:23:34] <aude>	 Thiemo_WMDE: Tobi_WMDE_SWE ^
[15:32:07] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/4-NZaQ
[15:32:07] <gh-wmde>	 13WikibaseDataModel/06master 140680b3e 15jeroendedauw: Add hasLabel, hasDescription and hasAliasGroup to Fingerprint...
[15:36:30] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 060.9.x: 02http://git.io/KsioXg
[15:36:30] <gh-wmde>	 13WikibaseDataModel/060.9.x 14843c363 15jeroendedauw: 0.9 release
[15:36:37] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler)
[15:37:46] <JeroenDeDauw>	 benestar|afk: can you do a sanity check on https://github.com/wmde/WikibaseDataModel/tree/0.9.x ? To me it looks ready for the 0.9 tag now
[15:39:03] <benestar>	 JeroenDeDauw: +1
[15:44:49] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154252 (owner: 10Thiemo Mättig (WMDE))
[15:45:07] <gh-wmde>	 [13WikidataBuilder] 15Benestar closed pull request #24: Add Wikidata.org extension to build (06master...06badges) 02http://git.io/pNC1rg
[15:51:00] <benestar>	 JeroenDeDauw: will there be cases possible where an entity has claims but no statements?
[15:51:16] <benestar>	 do we want to support such kind of things`?
[15:51:50] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw tagged 060.9.0 at 060.9.x: 02http://git.io/-Cn-0Q
[15:52:31] <JeroenDeDauw>	 benestar: I do not know if we will have such cases, though having code that prevents those is likely bad
[15:52:42] <JeroenDeDauw>	 benestar: for where are you asking about this?
[15:53:06] <benestar>	 JeroenDeDauw: I'm currently refactoring the ClaimsView
[15:53:12] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154261 (owner: 10Bene)
[15:53:42] <benestar>	 so I'm not sure how we should handle statements inside of that
[15:54:01] <JeroenDeDauw>	 benestar: does it currently not handle statements?
[15:54:13] <JeroenDeDauw>	 Right now we do not have claims that are not statements...
[15:54:27] <JeroenDeDauw>	 benestar: did you see the thing about changing the inheritance of the two?
[15:54:37] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/0.9.0/843c363 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32647220
[15:54:47] <benestar>	 JeroenDeDauw: it currently handles statements by overriding a method in ItemView
[15:54:56] <benestar>	 so it only affects the section heading but anyways
[15:55:07] <benestar>	 this is kind of an issue we have to be aware of
[15:55:15] <JeroenDeDauw>	 meh
[15:55:26] <JeroenDeDauw>	 "handles statements by overriding a method in ItemView"
[15:55:28] <JeroenDeDauw>	 bad
[15:56:16] <JeroenDeDauw>	 Right now statements might be cliams, but that does not mean a list of statements is a list of claims
[15:56:54] <JeroenDeDauw>	 benestar: I want to change Statement, and not have it inherit Claim, but rather use composition
[15:57:24] <JeroenDeDauw>	 Which means it's not good to have a Claim type hint somewhere and feed it a statement, as that would need to be changed
[15:58:57] <benestar>	 JeroenDeDauw: well, this mainly affects ClaimHtmlGenerator which currently checks if the claim is a statement
[15:59:25] <benestar>	 but will therefore also affect the ClaimsView
[15:59:32] <benestar>	 because we maybe rather need a StatementsView
[16:00:37] <benestar>	 JeroenDeDauw: also it is not possible to typehint agains Claim[] ...
[16:00:53] <benestar>	 so why don't we use a ClaimList in items?
[16:01:36] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[16:05:47] <JeroenDeDauw>	 benestar: not entirely in php indeed, though you can have Claim[] in the phpdoc ofc
[16:06:09] <benestar>	 I'd not call that typehint though :P
[16:06:20] <benestar>	 or call it type*hint*
[16:06:52] <JeroenDeDauw>	 benestar: it's not very nice to type hint against ClaimList, since this is a concrete implementation
[16:07:07] <benestar>	 oh, thought it was an interface
[16:07:11] <JeroenDeDauw>	 Type hinting against Iterator<Claim> would be better
[16:07:15] <JeroenDeDauw>	 Though same problem there
[16:07:20] <JeroenDeDauw>	 PHP does not have generics...
[16:07:23] <benestar>	 JeroenDeDauw: so is it decided to use composition rather than inheritance in Statements?
[16:07:33] <benestar>	 JeroenDeDauw: I think a future version will get them?
[16:07:55] <JeroenDeDauw>	 benestar: this has not been decided yet. It might turn out to be to much work to get rid of the inheritance
[16:08:11] <JeroenDeDauw>	 benestar: yeah maybe, but that does not help us, esp since WMF is still running PHP 5.3 for fucks sake
[16:08:39] <benestar>	 lol :P
[16:08:43] <JeroenDeDauw>	 benestar: also keep in mind that Item has a list of Statement, not of Claim
[16:08:48] <JeroenDeDauw>	 Which reminds me...
[16:08:59] <benestar>	 I know but that is all a bit smelly
[16:09:57] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154261 (owner: 10Bene)
[16:10:58] <JeroenDeDauw>	 benestar: what is?
[16:11:46] <benestar>	 JeroenDeDauw: the inheritance between claims and statements
[16:12:05] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw created 06rmca (+1 new commit): 02http://git.io/y6VxEw
[16:12:05] <gh-wmde>	 13WikibaseDataModel/06rmca 14d971ec5 15jeroendedauw: Remove not used ClaimAggregate
[16:12:14] <JeroenDeDauw>	 benestar: ^
[16:12:18] <benestar>	 because this code smell forces us to have inheritance overall the whole code base
[16:13:49] <JeroenDeDauw>	 benestar: yeah, this made me realize it's usefull to already have a getter that pretends there is composition going on
[16:13:56] <JeroenDeDauw>	 Will add this now already for DM 1.0
[16:14:30] <benestar>	 :)
[16:14:40] <benestar>	 JeroenDeDauw: you evil murderer :P
[16:14:55] <benestar>	 killed 151 lines in one commit
[16:15:00] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/rmca/d971ec5 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32649068
[16:16:46] <benestar>	 JeroenDeDauw: btw I think https://github.com/wmde/WikibaseDataModel/blob/master/src/Entity/Entity.php#L457 should also be deprecated
[16:16:55] <benestar>	 because getClaims etc are deprecated
[16:17:53] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[16:17:57] <JeroenDeDauw>	 benestar: indeed, feel free to submit a patch!
[16:18:06] <benestar>	 ok :)
[16:18:08] <JeroenDeDauw>	 benestar: I suggest you do not modify the rel notes in the PR though
[16:18:12] <JeroenDeDauw>	 Else we'll have conflicts
[16:18:16] <JeroenDeDauw>	 Just do that afterwards
[16:18:39] <benestar>	 JeroenDeDauw: and then directly push to master?
[16:19:26] <JeroenDeDauw>	 benestar: better
[16:19:26] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06rmca: 02http://git.io/hf8L1Q
[16:19:26] <gh-wmde>	 13WikibaseDataModel/06rmca 14909a889 15jeroendedauw: Add getStatements to Item and deprecated getClaims
[16:19:35] <JeroenDeDauw>	 benestar: https://github.com/wmde/WikibaseDataModel/edit/master/RELEASE-NOTES.md
[16:20:23] <JeroenDeDauw>	 benestar: I added some lines now so I did not purely kill them: https://github.com/wmde/WikibaseDataModel/pull/143
[16:22:04] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw created 06Statement (+1 new commit): 02http://git.io/dAPkLg
[16:22:04] <gh-wmde>	 13WikibaseDataModel/06Statement 14ff49e2c 15jeroendedauw: Make fields in Statement private
[16:22:14] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw opened pull request #144: Make fields in Statement private (06master...06Statement) 02http://git.io/VmTuMw
[16:23:34] <JeroenDeDauw>	 class StatementTest extends ClaimTest
[16:23:36] <JeroenDeDauw>	 :(
[16:26:10] <grrrit-wm>	 (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154260 (https://bugzilla.wikimedia.org/69542) (owner: 10Aude)
[16:26:42] <benestar>	 JeroenDeDauw: that's what I mean :/
[16:27:43] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw created 06getclaim (+1 new commit): 02http://git.io/JN-LnA
[16:27:43] <gh-wmde>	 13WikibaseDataModel/06getclaim 143fd2807 15jeroendedauw: Add getClaim method to Statement...
[16:27:51] <JeroenDeDauw>	 benestar: then you must like this ^
[16:27:58] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw opened pull request #145: Add getClaim method to Statement (06master...06getclaim) 02http://git.io/ssd3pA
[16:28:15] <benestar>	 JeroenDeDauw: <3
[16:31:16] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/Statement/ff49e2c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32649960
[16:33:55] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154277 (https://bugzilla.wikimedia.org/69608) (owner: 10Aude)
[16:36:56] <travis-ci>	 [travis-ci] wmde/WikibaseDataModel/getclaim/3fd2807 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32650375
[16:37:50] <gh-wmde>	 [13WikibaseDataModel] 15Benestar created 06deprecate (+1 new commit): 02http://git.io/WtU1xQ
[16:37:50] <gh-wmde>	 13WikibaseDataModel/06deprecate 1436ad5c7 15bene: Deprecated Entity::newClaim and Entity::getAllSnaks
[16:38:10] <gh-wmde>	 [13WikibaseDataModel] 15Benestar opened pull request #146: Deprecated Entity::newClaim and Entity::getAllSnaks (06master...06deprecate) 02http://git.io/98qhcQ
[16:45:59] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154279 (https://bugzilla.wikimedia.org/69608) (owner: 10Aude)
[16:46:02] <JeroenDeDauw>	 benestar: did you see this piece of awesome? http://www.bn2vs.com:8000/components
[16:46:21] <JeroenDeDauw>	 Lydia_WMDE: yu are now officially sad we did not do this earlier http://www.bn2vs.com:8000/components
[16:46:32] <benestar>	 no, whats that?
[16:46:32] <JeroenDeDauw>	 Even though it does not have a cornify button yet
[16:46:51] <JeroenDeDauw>	 benestar: it's the WIP version of our new awesome site
[16:47:07] <JeroenDeDauw>	 Right now this is on mediawiki.org: http://wikiba.se/
[16:47:24] <JeroenDeDauw>	 benestar: you can add stuff here https://github.com/wmde/Wikiba.se
[16:47:31] <benestar>	 JeroenDeDauw: cool :)
[16:47:34] <benestar>	 but do we need this? :P
[16:48:03] <benestar>	 JeroenDeDauw: we need a footer for this
[16:48:56] <JeroenDeDauw>	 "need"? We don't die if we don't have it. We lose out on stuff if we don't though.
[16:49:15] <JeroenDeDauw>	 benestar: not sure how you'd add a footer
[16:49:20] <JeroenDeDauw>	 Jackob has been creating this thing
[16:49:25] <benestar>	 it's kinda cut off at the bottom
[16:49:29] <JeroenDeDauw>	 Though it just uses Sculpin
[16:49:40] <benestar>	 also such a fancy website should use HTML5 tags imo :)
[16:49:53] <JeroenDeDauw>	 benestar: file all of the things! https://github.com/wmde/Wikiba.se/issues
[16:49:58] <JeroenDeDauw>	 Or better yet, make PRs ;p
[16:50:04] <JeroenDeDauw>	 Now we can actually do such fancy stuff
[16:50:21] <JeroenDeDauw>	 On mediawiki.org we can't even get rid of the totally unrelated main menu
[16:52:12] * benestar first refactors ClaimsView
[16:52:25] <JeroenDeDauw>	 benestar: merge all of the things? https://github.com/wmde/WikibaseDataModel/pulls/assigned/Benestar
[16:52:54] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw closed pull request #146: Deprecated Entity::newClaim and Entity::getAllSnaks (06master...06deprecate) 02http://git.io/98qhcQ
[16:54:26] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "Sires are a MediaWiki concept. Why does this script, which only deals with sites, need to be in Wikibase? Anything else that depends on th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145765 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man)
[16:57:28] <benestar>	 JeroenDeDauw: Thiemo_WMDE will kill me :P
[16:57:47] <benestar>	 he told me to wait at least some hours before merging something
[16:58:29] <JeroenDeDauw>	 benestar: don't worry, I'll kill Thiemo_WMDE first
[16:58:39] <benestar>	 xD
[16:59:23] <gh-wmde>	 [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06master: 02http://git.io/VACQQw
[16:59:23] <gh-wmde>	 13WikibaseDataModel/06master 142d5cc9c 15Bene*: Merge pull request #144 from wmde/Statement...
[16:59:27] <JeroenDeDauw>	 benestar: that's a silly policy IMO. It slows you down and enourages both big commits and long commit chains
[16:59:34] <gh-wmde>	 [13WikibaseDataModel] 15Benestar 04deleted 06Statement at 14ff49e2c: 02http://git.io/5qm9pw
[16:59:45] <benestar>	 this one was trivial enough that Thiemo_WMDE cannot complain :)
[16:59:47] <JeroenDeDauw>	 In some cases it's good to wait for review by specific people
[17:00:04] <JeroenDeDauw>	 Though if you wait on no one in particular for all commits, that's just silly
[17:00:48] <JeroenDeDauw>	 If one qualified person reviewed it, it's generally fine
[17:01:15] <JeroenDeDauw>	 And if it is not, then waiting for a few hours is a totally arbitrary measure that is not guaranteed to help at all
[17:01:24] <JeroenDeDauw>	 What if no one notices it in those hours?
[17:01:33] <JeroenDeDauw>	 It's much better to then poke the relevant people
[17:01:38] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #145 143fd2807: why not `return $this`? 02http://git.io/7T3nVA
[17:02:06] <JeroenDeDauw>	 Thiemo_WMDE: ^ proof you are a silly person! :)
[17:04:10] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #143 14909a889: renaming `$entity` to `$item` would help avoiding confusion 02http://git.io/zpuj6w
[17:05:43] <JeroenDeDauw>	 benestar: well, a lot of other stuff should also be changed in that test class... 
[17:06:10] <benestar>	 JeroenDeDauw: so maybe I'll do it in a follow up
[17:06:15] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06rmca: 02http://git.io/PRWBsw
[17:06:15] <gh-wmde>	 13WikibaseDataModel/06rmca 14100e9e1 15jeroendedauw: Some naming imporvements
[17:06:41] <JeroenDeDauw>	 benestar: this comment makes no sense to me https://github.com/wmde/WikibaseDataModel/pull/145#discussion_r16302815
[17:06:51] <JeroenDeDauw>	 benestar: no need, already done
[17:07:18] <JeroenDeDauw>	 oh
[17:07:20] <JeroenDeDauw>	 I get it
[17:07:59] <benestar>	 JeroenDeDauw: statement extends claim so we can just return ourselves
[17:08:51] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #145 143fd2807: Because then it's still an instance of `Statement`, and some code right now might be doing `if ( $claim instanceof Statement )`. You are right that `return $this` will suffice for a lot of cases. In any case, this is a temporary implementation. 02http://git.io/T0KHXA
[17:09:01] <benestar>	 makes more sense imo because we want to return an existing object
[17:09:21] <JeroenDeDauw>	 benestar: why?
[17:09:36] <benestar>	 JeroenDeDauw: than we can modify the object and the changes get visible
[17:10:01] <benestar>	 or is a claim unmutable?
[17:11:25] <benestar>	 why doesn't PHP support typecasting?
[17:11:36] <benestar>	 otherwise we could just do return (Claim) $this;
[17:11:40] <benestar>	 and everything would be fine
[17:11:48] <JeroenDeDauw>	 benestar: right, I did consider the "by value" part
[17:12:28] <benestar>	 so that changes do *not* get visible in the statement itself?
[17:12:48] <JeroenDeDauw>	 That is the behaviour of the current implementation yes
[17:12:57] <JeroenDeDauw>	 I'm mostly concerned about this since it will likely change
[17:13:05] <JeroenDeDauw>	 When we change the thing to actually use composition
[17:13:12] <JeroenDeDauw>	 And this is a breaking change
[17:13:24] <JeroenDeDauw>	 So using what you suggested fixes that
[17:13:39] <JeroenDeDauw>	 Though I'm concerned about the instanceof checks part
[17:13:41] <JeroenDeDauw>	 ...
[17:14:13] <benestar>	 JeroenDeDauw: that's what I meant
[17:14:32] <JeroenDeDauw>	 Ok, I suspect just returning this will end up being less of a hassle in the future
[17:14:34] <benestar>	 so maybe we should just eliminate all instanceof Statement checks?
[17:14:57] <benestar>	 JeroenDeDauw: btw, getClaim is not used at the moment anyways so it cannot conflict with some old code
[17:15:14] <benestar>	 and for new code we have to take extra care and avoid any instanceof checks
[17:15:57] <JeroenDeDauw>	 benestar: I know there is no break now, but there would be one in the future
[17:16:24] <benestar>	 yeah, and therefore I'm in favour of return $this;
[17:19:00] <JeroenDeDauw>	 benestar: ^
[17:19:07] <JeroenDeDauw>	 ugh
[17:19:09] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06getclaim from 143fd2807 to 14e024b43: 02http://git.io/5nQLkg
[17:19:09] <gh-wmde>	 13WikibaseDataModel/06getclaim 14e024b43 15jeroendedauw: Add getClaim method to Statement...
[17:19:11] <JeroenDeDauw>	 ^
[17:20:24] <JeroenDeDauw>	 benestar: so merge https://github.com/wmde/WikibaseDataModel/pull/143 ?
[17:20:37] <JeroenDeDauw>	 Then I can update the rel notes for your change which was already merged
[17:23:18] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #143 14100e9e1: since 1.0 02http://git.io/ETGpew
[17:23:25] <benestar>	 JeroenDeDauw: :P
[17:23:27] <benestar>	 --^
[17:24:36] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #143 14100e9e1: also why did you kill the `@since 0.3` tag? 02http://git.io/--unVw
[17:25:26] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #143 14100e9e1: ??... 02http://git.io/kcvkeA
[17:25:27] <JeroenDeDauw>	 benestar: you got confused?
[17:25:36] <gh-wmde>	 [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06master: 02http://git.io/eV0QmQ
[17:25:36] <gh-wmde>	 13WikibaseDataModel/06master 14488cfc1 15Bene*: Merge pull request #145 from wmde/getclaim...
[17:26:42] <aude>	 Lydia_WMDE: ping
[17:26:56] <Lydia_WMDE>	 aude: meep
[17:27:17] <aude>	 to enable redirects, i forgot that we also need to change a setting after we add a column
[17:27:38] <aude>	 after begging greg for the bug fixes, i'm not sure about asking for that on a friday
[17:28:10] <aude>	 instead, think we should enable it on test.wikidata on monday
[17:28:24] <aude>	 then give them a week to test, and enable it on wikidata a week later, imho
[17:28:46] <aude>	 the setting is to tell wikibase to use the column
[17:29:11] <Lydia_WMDE>	 if it is just about asking greg i will do that
[17:29:17] <aude>	 hmmm
[17:29:28] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/OcH9EQ
[17:29:28] <gh-wmde>	 13WikibaseDataModel/06master 149ce2ba0 15Jeroen De Dauw: Update RELEASE-NOTES.md
[17:29:29] <aude>	 you can 
[17:29:30] <Lydia_WMDE>	 it'd be sad if we miss out on it just because of that imho
[17:29:55] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #143 14100e9e1: ...... 02http://git.io/zKJ4Fw
[17:30:41] <benestar|afk>	 JeroenDeDauw: perhaps you got confused :P
[17:30:45] <benestar|afk>	 will merge after dinner :)
[17:30:50] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #143 14100e9e1: Meh! Screenshot or it didn't happen. Nowait.gif 02http://git.io/qAMmfg
[17:30:51] <JeroenDeDauw>	 benestar|afk:you misplaced the comment!
[17:31:15] <Lydia_WMDE>	 aude: asked
[17:31:27] <aude>	 ok :)
[17:33:08] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rmca from 14100e9e1 to 14ff29b0f: 02http://git.io/Ena2JQ
[17:33:08] <gh-wmde>	 13WikibaseDataModel/06rmca 145406c6c 15jeroendedauw: Remove not used ClaimAggregate
[17:33:08] <gh-wmde>	 13WikibaseDataModel/06rmca 14a83d8db 15jeroendedauw: Add getStatements to Item and deprecated getClaims
[17:33:08] <gh-wmde>	 13WikibaseDataModel/06rmca 14ff29b0f 15jeroendedauw: Some naming imporvements
[17:33:39] * JeroenDeDauw is off to the land of rts
[17:35:38] <grrrit-wm>	 (03PS2) 10Aude: Update / remove references to TermCache interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152056 
[17:35:56] <aude>	 easy chocolate ^
[17:40:37] <Lydia_WMDE>	 aude: good to go :)
[17:40:45] <aude>	 yay!
[17:41:06] * aude wishes for a day between thursday and friday :)
[17:41:25] <aude>	 to avoid these issues
[17:41:50] <Thiemo_WMDE>	 JeroenDeDauw: i feel likr 70% drunk and still dont know what you are refering to.
[17:46:51] <aude>	 column added
[17:49:08] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152056 (owner: 10Aude)
[17:50:37] <Lydia_WMDE>	 \o/
[17:52:10] <aude>	 updating config
[17:54:11] <aude>	 Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/154292/1/wmf-config/Wikibase.php :)
[17:54:46] <Lydia_WMDE>	 :)
[17:56:20] * aude blame Lydia_WMDE https://gerrit.wikimedia.org/r/#/c/154292/
[17:56:32] <Lydia_WMDE>	 :P
[17:56:38] <Lydia_WMDE>	 that's what i'm here for right?
[17:56:42] <aude>	 heh
[17:57:58] <aude>	 doing
[17:58:05] <aude>	 done :)
[17:58:20] <Lydia_WMDE>	 yaaay
[17:58:40] * aude codes my bot to do redirects now
[17:58:54] <aude>	 during the weekend....
[18:00:02] <Lydia_WMDE>	 aude: sweet. ok to send out emails?
[18:00:22] <aude>	 i think so
[18:00:31] <aude>	 is there any documentation about redirects?
[18:00:46] <Lydia_WMDE>	 nope
[18:00:53] <Lydia_WMDE>	 i should probably add something to the email about that
[18:01:02] <Lydia_WMDE>	 that they can for now only be created viat the api?
[18:01:04] <aude>	 only in https://test.wikidata.org/w/api.php 
[18:01:08] <aude>	 for wbcreateredirect
[18:01:16] <aude>	 looks straightforward
[18:01:31] * Lydia_WMDE goes and adds to email and then sends
[18:01:35] <aude>	 k
[18:01:38] * aude going home
[18:01:46] <Lydia_WMDE>	 laters :)
[18:01:50] <aude>	 later!
[18:01:54] <Lydia_WMDE>	 and thanks for getting the test system up
[18:02:01] <aude>	 thanks for asking gre.g
[18:02:29] * aude really wish we deploy test.wikidata in the morning on thursdays so we have more time for bug fixes
[18:02:32] <aude>	 before friday :)
[18:02:42] <Lydia_WMDE>	 definitely, yeah
[18:02:50] <aude>	 doesn't work with the timezones :(
[18:02:58] <aude>	 laters
[18:03:02] <Lydia_WMDE>	 hopefully getting better with next deployments when we have less stuff again
[18:03:06] <aude>	 yep
[18:03:25] <dennyvrandecic>	 what about no deploys on fridays :)
[18:03:35] <Lydia_WMDE>	 dennyvrandecic: shhhhhh :P
[18:03:40] <Lydia_WMDE>	 this was test.wikidata.org
[18:04:03] * Lydia_WMDE goes and sends off emails
[18:09:46] <gh-wmde>	 [13WikibaseDataModel] 15Benestar comment on pull request #143 14ff29b0f: y did you kill @since 0.3? I think it was useful at this place. 02http://git.io/4sBt3A
[18:11:43] * aude is spammed!
[18:15:44] * Lydia_WMDE hides
[18:16:54] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Refactor MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE))
[18:17:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE))
[19:00:22] <notconfusing>	 is there a page that shows when each language adopted wikidata, and their RFCs?
[19:00:31] <notconfusing>	 i know italian and hebrew and polish were first right?
[19:00:38] <notconfusing>	 are all languages using now?
[19:08:31] <legoktm>	 Lydia_WMDE: most mailing lists (including wikitech-ambassadors) strip cc's from the headers when sending it out to everyone
[19:08:48] <Lydia_WMDE>	 legoktm: urgh seriously?
[19:09:02] <legoktm>	 those people still get it, but others can't see the cc
[19:09:25] <legoktm>	 also, YAY FOR BADGES :DDDD
[19:09:31] <Lydia_WMDE>	 notconfusing: yes all wikipedias. the news page linked on the main page of wikidata.org has the dates
[19:09:36] <Lydia_WMDE>	 legoktm: :D
[19:09:41] <legoktm>	 https://test.wikidata.org/wiki/Special:SetSiteLink/Q296/enwiki <-- how do I unset a badge?
[19:09:55] <Lydia_WMDE>	 notconfusing: there were no real rfcs. just asking for the first ones
[19:10:07] <Lydia_WMDE>	 legoktm: deselect
[19:10:10] <Lydia_WMDE>	 and then save
[19:10:27] <legoktm>	 oh, that's confusing
[19:10:32] <Lydia_WMDE>	 yeah not perfect yet
[19:10:41] <legoktm>	 can there just be a third "None" option?
[19:11:21] <Lydia_WMDE>	 legoktm: well you can select several
[19:11:31] <Lydia_WMDE>	 that makes it a bit tricky
[19:11:31] <legoktm>	 hm
[19:11:53] <legoktm>	 oh interesting
[19:12:00] <dennyvrandecic>	 how do i deselect?
[19:12:46] <Lydia_WMDE>	 dennyvrandecic: ctrl + click
[19:13:01] <dennyvrandecic>	 oh
[19:13:03] <dennyvrandecic>	 and on mobile?
[19:13:04] <Lydia_WMDE>	 same for selecting multiple badges
[19:13:32] <legoktm>	 I wonder if we're going to tag all featured articles as good articles too, or just remove GA when it reaches FA.
[19:13:37] <Lydia_WMDE>	 dennyvrandecic: not sure if this is possible there tbh. this special page isn't the final solution
[19:13:54] <Lydia_WMDE>	 legoktm: the latter makes more sense to me ;-)
[19:14:04] <dennyvrandecic>	 maybe at least write it down that you can use ctrl+click for deselect and multiselect
[19:14:08] <dennyvrandecic>	 i didn't know that :)
[19:14:13] <Lydia_WMDE>	 good point
[19:14:16] <Lydia_WMDE>	 benestar: ^
[19:15:05] <Lydia_WMDE>	 dennyvrandecic: in the end we want to be able to edit this on the item page directly. but hacking this in before the UI redesign was too painful and a waste of benestar's time
[19:15:20] <Lydia_WMDE>	 so this for now and then properly with the new UI
[19:15:55] <dennyvrandecic>	 that's smart
[19:16:33] <benestar>	 Lydia_WMDE: we could also add checkboxes...
[19:16:53] <Lydia_WMDE>	 benestar: hmm wasn't there some reason why we didn't?
[19:17:06] <benestar>	 Lydia_WMDE: not sure ^^
[19:17:15] <Lydia_WMDE>	 hmmmm
[19:17:16] <benestar>	 I think because it would look ugly with many badges
[19:17:30] <benestar>	 but atm we only have two so this wouldn't really matter
[19:17:45] <Lydia_WMDE>	 well i expect quite some requests right after roll-out
[19:17:46] <legoktm>	 how many badges to we anticipate?
[19:17:51] <legoktm>	 do we*
[19:17:59] <Lydia_WMDE>	 legoktm: 20ish maybe?
[19:18:18] <Lydia_WMDE>	 but i am sure people will come up with crazy stuff later
[19:18:22] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Use consistently window.location.href instead of location.href [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154305 
[19:18:24] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154305 (owner: 10Gerrit Patch Uploader)
[19:19:43] <benestar>	 Lydia_WMDE: but later there will be a nicer ui...
[19:20:14] <Lydia_WMDE>	 yeah
[19:20:29] <Lydia_WMDE>	 let's see what feedback we get over the weekend
[19:20:43] <Lydia_WMDE>	 and then check what to do next
[19:21:06] <legoktm>	 i see wat u did there.
[19:22:07] <Lydia_WMDE>	 :P
[19:23:58] <benestar>	 Lydia_WMDE: I think the feedback will mostly be "häää" or "wtf"
[19:24:09] <benestar>	 multiselectfields are not very intuitive
[19:24:58] <Lydia_WMDE>	 hehe
[19:25:44] <Lydia_WMDE>	 let's see
[19:26:04] <Lydia_WMDE>	 i agree
[19:26:23] <Lydia_WMDE>	 but if we get requests for 15 more badges in the next days then we can't really go with checkboxes either
[19:26:26] <dennyvrandecic>	 maybe just prepare a checkbox version for now, so it does not hold back deployment
[19:26:42] <dennyvrandecic>	 oh you can. 15 checkboxes might be ugly, but still intuitive
[19:27:00] <Lydia_WMDE>	 hmmmm
[19:27:02] <dennyvrandecic>	 since it is temporary anyway, why care too much about ugly?
[19:27:12] <Lydia_WMDE>	 true as well
[19:27:21] <Lydia_WMDE>	 benestar: want to prepare it?
[19:27:26] <dennyvrandecic>	 you have the choice between confusing or ugly :)
[19:27:42] <Lydia_WMDE>	 tough! :P
[19:27:47] <dennyvrandecic>	 aye
[19:28:34] <benestar>	 Lydia_WMDE: after I have killed EntityView maybe :P
[19:28:42] <Lydia_WMDE>	 :P
[19:28:44] <Lydia_WMDE>	 alright
[19:28:54] <benestar>	 well, I am going quite well :)
[19:29:07] <benestar>	 created a FingerprintView yesterday and a ClaimsView today
[19:29:18] * benestar becomes faster :)
[19:29:49] <benestar>	 Lydia_WMDE: and that although I have to do code review no, too, because of your evilness :P
[19:29:55] <benestar>	 *now
[19:30:06] <Lydia_WMDE>	 :D
[19:30:12] <benestar>	 JeroenDeDauw annoyed me all the time to merge his patches ^^
[19:30:12] * Lydia_WMDE is an evil genius
[19:30:20] <Lydia_WMDE>	 <3
[19:30:41] <benestar>	 which I did after annoying him all the time with comments on his patches :D
[19:30:49] <Lydia_WMDE>	 \o/
[19:30:58] <benestar>	 so that we finally agreed on returning ourselves
[19:31:15] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154305 (owner: 10Gerrit Patch Uploader)
[19:31:16] <benestar>	 function getClaim() { return $this; }
[19:46:14] <Amir1>	 Just did this edit with my bot: https://test.wikidata.org/w/index.php?title=Q296&diff=7560&oldid=7554
[19:55:22] <Josve05a>	 Anybody...like that are as smart or smarter than Lydia_WMDE (is there someone like that?)... http://i.snag.gy/zgUGt.jpg  &  http://i.snag.gy/vDCyH.jpg
[19:55:55] <Lydia_WMDE>	 Josve05a: :D
[19:56:02] * Lydia_WMDE looks
[19:56:11] <Josve05a>	 (see, flattery works!)
[19:56:16] <Lydia_WMDE>	 :D
[19:56:30] <Lydia_WMDE>	 Josve05a: you mean the screwed up position of the edit link?
[19:56:45] <Josve05a>	 Yes, and the [cancel] [delete] [edit]    too
[19:56:46] <Lydia_WMDE>	 and is this on wikidata.org or test.wikidata.org?
[19:56:50] <Josve05a>	 wikidata.org 
[19:56:56] <Lydia_WMDE>	 ok
[19:57:00] <Lydia_WMDE>	 let me have a look there
[19:57:10] <Josve05a>	 I think I might be using a gadget...that causes this
[19:57:20] <Josve05a>	 You see those arrows at the right side
[19:57:57] <Josve05a>	 I had the browser zoomed out to 90% (looks better that way on all wikis), but I can confirm that it is on both 100% and 90%
[19:58:31] <Lydia_WMDE>	 Josve05a: can't reproduce here in chromium. Can you try logged out or in an anonymous session?
[19:58:47] * Josve05a is logging out
[19:59:18] <Josve05a>	 no...then it is normal
[19:59:34] <Lydia_WMDE>	 that suggests it is indeed a gadget or similar
[20:00:03] <Josve05a>	 but which...urgh
[20:00:09] <Lydia_WMDE>	 yeah :(
[20:00:19] <Lydia_WMDE>	 iirc there is one to move links to another items?
[20:00:29] <Lydia_WMDE>	 that could be a candidate 
[20:00:49] <Josve05a>	 I have like 60-75% of all gadgets turned on... 
[20:00:52] <Lydia_WMDE>	 lol
[20:00:54] <Lydia_WMDE>	 ok...
[20:01:41] <Josve05a>	 Umm....
[20:01:54] * Josve05a is sceen-shotting
[20:03:26] <Josve05a>	 http://i.snag.gy/2lf0j.jpg
[20:03:29] <Josve05a>	 What is that?
[20:04:40] <Josve05a>	 Lydia_WMDE ^
[20:05:27] <Lydia_WMDE>	 ah some admin recently added that gadget for everyone by default and it should not show up in their preferences
[20:05:35] <Lydia_WMDE>	 i don't remember what it does however
[20:05:45] <Josve05a>	 which gadget?
[20:05:52] <Josve05a>	 Urgh!
[20:05:53] <Lydia_WMDE>	 the one at the bottom of your screenshot
[20:07:08] <Josve05a>	 Sounds like MediaWiever...added by default... :P
[20:07:33] <Josve05a>	 Well, I can't find *my* bad gadget
[20:12:00] <Lydia_WMDE>	 Josve05a: do you have the move links one enabled?
[20:12:52] <Josve05a>	 I ctrl+f -ed "move". Not turned on any of those 2 gadgets
[20:13:12] <Lydia_WMDE>	 hmmmm
[20:13:25] <Lydia_WMDE>	 any user scripts?
[20:13:50] <Josve05a>	 I turned off "autoEdit". That seems to have fixed it
[20:14:11] <Lydia_WMDE>	 \o/
[20:14:35] <Josve05a>	 Wooo!
[20:15:10] <Josve05a>	 But. who's script/gadget is that and how can it be fixed/warned that there is a problem?
[20:23:12] <grrrit-wm>	 (03PS1) 10Bene: [DNM] Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 
[20:28:17] <benestar>	 Lydia_WMDE: "ah some admin recently added that gadget for everyone by default and it should not show up in their preferences"
[20:28:19] <benestar>	 wtf???
[20:34:22] <benestar>	 Thiemo_WMDE: are you online?
[20:35:52] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene)
[20:40:20] <grrrit-wm>	 (03PS1) 10Bene: Decrease specificity in badge css selectors [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154325 
[20:41:33] <benestar>	 Lydia_WMDE: should I keep the code for the multiselectbox in the specialpage?
[20:41:50] <benestar>	 or did you decide to never use multiselectboxes again?
[20:42:15] <benestar>	 or did you go entirely? :P
[20:42:37] <Lydia_WMDE>	 benestar: i'd say kill it. if we need it again we can get it from history
[20:43:04] <benestar>	 ok, I've killed so much today already
[20:43:17] <benestar>	 one block of code more or less doesn't matter
[20:43:24] * benestar is murderer no 1
[20:47:14] <Lydia_WMDE>	 ^ ^ 
[20:48:05] <benestar>	 Lydia_WMDE: having the checkboxes in one line or below each other?
[20:48:15] <Lydia_WMDE>	 below
[20:50:04] <benestar>	 Lydia_WMDE: looks a bit empty then...
[20:50:27] <Lydia_WMDE>	 screenshot?
[20:50:57] <benestar>	 Lydia_WMDE: both in one http://snag.gy/5yiVy.jpg
[20:51:26] <benestar>	 I like inline more
[20:51:27] <Lydia_WMDE>	 imho below is fine
[20:51:31] <benestar>	 :P
[20:51:41] <Lydia_WMDE>	 it seems clearer
[20:51:55] <Lydia_WMDE>	 other opinions?
[20:53:01] <benestar>	 Lydia_WMDE: both don't scale :/ http://snag.gy/rwum9.jpg
[20:53:22] <Lydia_WMDE>	 yeah
[20:53:36] <Lydia_WMDE>	 second one still seems clearer to me
[20:53:59] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154325 (owner: 10Bene)
[20:54:16] <benestar>	 Lydia_WMDE: what about a two column layout?
[20:54:34] <Lydia_WMDE>	 that could work yeah
[20:55:08] <benestar>	 Lydia_WMDE: but is not widely supported :(
[20:57:12] <Lydia_WMDE>	 what happens in a not-supported browser?
[20:57:22] <Lydia_WMDE>	 do they just show it as one olumn?
[20:57:26] <Lydia_WMDE>	 column
[20:59:22] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #143 14ff29b0f: I think you are confused by the diff. This method did not exist before, so how could I remove a tag from it?! 02http://git.io/qbXwXQ
[20:59:31] <benestar>	 Lydia_WMDE: http://snag.gy/YiuVw.jpg
[20:59:52] <Lydia_WMDE>	 yes!
[21:00:01] <lazowik>	 hey :)
[21:00:15] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #143 14ff29b0f: Or do you want me to not remove it from `getClaims`? I don't see why it would still need to be there. You should not use that method. 02http://git.io/vJNzQA
[21:01:04] <Lydia_WMDE>	 hey lazowik
[21:01:06] <JeroenDeDauw>	 "i feel likr 70% drunk and still dont know what you are refering to" -- Thiemo_WMDE 
[21:01:19] <JeroenDeDauw>	 It's a Lydia_WMDE 
[21:01:26] <JeroenDeDauw>	 Who is no longer in the office
[21:01:28] <JeroenDeDauw>	 muhahaha
[21:02:34] <lazowik>	 it's a JeroenDeDauw!
[21:02:42] <Lydia_WMDE>	 -.-
[21:02:49] <lazowik>	 benestar: I see you're feeling good?
[21:03:05] <lazowik>	 https://www.youtube.com/watch?v=CmwRQqJsegw
[21:03:13] <JeroenDeDauw>	 lazowik: https://dl.dropboxusercontent.com/u/7313450/entropy/gif/aaaa.gif
[21:04:06] <lazowik>	 JeroenDeDauw: we're visiting my parents friends
[21:04:19] <lazowik>	 and they have ~6 kittens
[21:04:37] <lazowik>	 <1 month old
[21:05:27] <lazowik>	 so I can haz see real kittens!
[21:06:21] <JeroenDeDauw>	 lazowik: please to steal some and bring to the WMDE office
[21:06:23] <benestar>	 Lydia_WMDE: that is not css3 columns but simply elements besides each other
[21:06:24] <benestar>	 however, implementing this costs more effort
[21:06:26] <benestar>	 at least more than I can do within a week or so 
[21:06:47] <benestar>	 lazowik:  Der betreffende Nutzer hat das Video in deinem Land nicht zur Verfügung gestellt. 
[21:07:05] <benestar>	 JeroenDeDauw: evil :O
[21:07:15] <Lydia_WMDE>	 benestar: sure :)
[21:07:36] <lazowik>	 JeroenDeDauw: frankly, I'm quite close to Germany now
[21:07:45] <lazowik>	 thought of visiting you guys :p
[21:07:51] <benestar>	 Lydia_WMDE: not quite sure what you are referring to
[21:08:03] <lazowik>	 benestar: wat? I'm no of knowing german
[21:08:17] <lazowik>	 benestar: just have two divs
[21:08:27] <Lydia_WMDE>	 benestar: as in "that's ok."
[21:08:45] <lazowik>	 and put them one left, one right etc.
[21:09:23] <benestar>	 lazowik: but there are lots of evil floatings around in that crazy box
[21:09:33] <benestar>	 seems they have a big party there
[21:09:38] <lazowik>	 CLEAR ALL OF THE FLOATS
[21:09:39] <lazowik>	 :p
[21:10:24] <lazowik>	 benestar: ah, right, I forgot that you have many videos blocked in Germany
[21:10:43] <JeroenDeDauw>	 How are the allowed bagdes determined now? Where is the list defined? On wiki?
[21:10:48] <benestar>	 JeroenDeDauw: http://snag.gy/sQCPa.jpg
[21:11:01] <benestar>	 maybe that makes clear what I'm wanting to tell you ...
[21:11:17] <benestar>	 JeroenDeDauw: config
[21:11:24] <Josve05a>	 Code RED: promote more adminbots or hurry the developers
[21:11:46] <JeroenDeDauw>	 benestar: mediawiki config, php file?
[21:11:59] <benestar>	 JeroenDeDauw: Wikibase config
[21:12:05] <JeroenDeDauw>	 yeah same thing
[21:12:19] <lazowik>	 ok peeps, perapre for some aww
[21:12:20] <lazowik>	 http://pl.tinypic.com/r/m7qs7c/8
[21:12:26] <benestar>	 JeroenDeDauw: like that https://gerrit.wikimedia.org/r/#/c/149918/
[21:12:26] <JeroenDeDauw>	 benestar: did you see my second comment?
[21:12:32] <benestar>	 just now
[21:13:05] <benestar>	 JeroenDeDauw: do we remove @since tags when we deprecate methods?
[21:13:13] <JeroenDeDauw>	 I generally do this
[21:13:26] <benestar>	 well, k
[21:14:23] <JeroenDeDauw>	 !merge | benestar 
[21:14:23] <wm-bot3>	 benestar: merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/$1/
[21:14:30] <JeroenDeDauw>	 huh
[21:14:34] <lazowik>	 why no aww? :(
[21:14:54] <grrrit-wm>	 (03PS2) 10Bene: Refactor claims code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 
[21:14:55] <JeroenDeDauw>	 !m is merge merge merge MERGEEEEEEEEEEEEE
[21:14:56] <wm-bot3>	 Key was added
[21:15:03] <JeroenDeDauw>	 !m | benestar 
[21:15:03] <wm-bot3>	 benestar: merge merge merge MERGEEEEEEEEEEEEE
[21:15:15] <benestar>	 JeroenDeDauw: not used anywhere in Wikibase.git or in WikibaseDataModel?
[21:15:23] <lazowik>	 !m | wm-bot3
[21:15:23] <wm-bot3>	 wm-bot3: merge merge merge MERGEEEEEEEEEEEEE
[21:15:46] <lazowik>	 !m is !m
[21:15:47] <wm-bot3>	 You are not authorized to perform this, sorry
[21:15:57] <lazowik>	 JeroenDeDauw: ^ would that cause a inf. loop?
[21:16:02] <JeroenDeDauw>	 !idk
[21:16:04] <Josve05a>	 no.
[21:16:08] <JeroenDeDauw>	 !foo is !bar
[21:16:08] <wm-bot3>	 Key was added
[21:16:12] <JeroenDeDauw>	 !bar is !foo
[21:16:12] <wm-bot3>	 Key was added
[21:16:13] <Josve05a>	 The bot can't see what it self says
[21:16:14] <JeroenDeDauw>	 !foo
[21:16:14] <wm-bot3>	 !bar
[21:16:17] <JeroenDeDauw>	 :(
[21:16:23] <lazowik>	 :((
[21:16:26] <JeroenDeDauw>	 Josve05a: booooo!
[21:16:29] <lazowik>	 hmm
[21:16:30] <JeroenDeDauw>	 del foo
[21:16:33] <lazowik>	 wait a sec
[21:16:33] <JeroenDeDauw>	 !del foo
[21:16:36] <JeroenDeDauw>	 !foo del
[21:16:37] <wm-bot3>	 Successfully removed foo
[21:16:40] <JeroenDeDauw>	 !bar del
[21:16:41] <wm-bot3>	 Successfully removed bar
[21:16:41] <Josve05a>	 Just as !ping is !ping wouldn't be good...
[21:16:45] <benestar>	 stop spamming!
[21:16:54] <lazowik>	 what? who is spamming!
[21:16:59] <lazowik>	 gimme him!
[21:17:08] <JeroenDeDauw>	 Yeah Josve05a , how do you dare spam like this?
[21:17:10] <benestar>	 JeroenDeDauw: I'm not available during weekend so if I merge you have to fix :P
[21:17:38] <JeroenDeDauw>	 benestar: master of data model is not used by Wikibase.git...
[21:17:52] <Josve05a>	 JeroenDeDauw - I'm sorry.... ;(
[21:17:54] <JeroenDeDauw>	 And if you are talking about ClaimAggregate, it is not used bu either
[21:18:22] <gh-wmde>	 [13WikibaseDataModel] 15Benestar 04deleted 06rmca at 14ff29b0f: 02http://git.io/7xMqow
[21:18:27] <benestar>	 JeroenDeDauw: here you go
[21:18:41] <benestar>	 lol, wrong order xD
[21:19:02] <JeroenDeDauw>	 benestar: well thank you good sir
[21:19:17] <benestar>	 JeroenDeDauw: somehow gh-wmde forgot to notify that I merged actually
[21:20:46] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Use DataModel 0.9.x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154339 
[21:24:05] <benestar>	 JeroenDeDauw: btw, there are only 7 failures left in http://wdjenkins.wmflabs.org/ci/job/wikibase-repo-tests/3148/console
[21:25:14] <JeroenDeDauw>	 benestar: fantastic!
[21:25:25] <benestar>	 there were 18
[21:27:14] <benestar>	 JeroenDeDauw: shouldn't we delete the 0.8.x branch on WikibaseDataModel?
[21:31:41] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene)
[21:40:01] <JeroenDeDauw>	 benestar|cloud: it's not doing any harm... I suggest to remove it when we are sure we want no further 0.8.x releases
[21:40:31] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154339 (owner: 10Jeroen De Dauw)
[21:41:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 031] "Looks good. Did not check the details yet though." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154322 (owner: 10Bene)
[21:41:55] <grrrit-wm>	 (03PS3) 10Jeroen De Dauw: Remove some presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153712 
[21:42:06] <JeroenDeDauw>	 benestar|cloud: https://gerrit.wikimedia.org/r/#/c/154339/
[21:55:41] <grrrit-wm>	 (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153712 (owner: 10Jeroen De Dauw)
[23:03:17] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Update / remove references to TermCache interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152056 (owner: 10Aude)
[23:04:33] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Handle MonolingualTextParser errors for values with language not set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154277 (https://bugzilla.wikimedia.org/69608) (owner: 10Aude)