[00:07:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153698 (owner: 10Jeroen De Dauw) [00:13:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153697 (owner: 10Jeroen De Dauw) [00:16:20] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153611 (owner: 10Jeroen De Dauw) [00:23:12] (03PS1) 10Hoo man: Revert "Optimized repo imports" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154001 [00:23:39] (03CR) 10Hoo man: [C: 032] "Please don't self merge... especially if stuff breaks test on master." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154001 (owner: 10Hoo man) [00:23:45] (03Merged) 10jenkins-bot: Revert "Optimized repo imports" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154001 (owner: 10Hoo man) [00:24:40] JeroenDeDauw: If you really think you should self merge, please wait for the tests at least [00:33:17] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/37398dd : Hoo man The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32494625 [00:34:28] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154001 (owner: 10Hoo man) [09:13:22] (03PS1) 10Henning Snater: Fall back to language code in wikibase.getLanguageNameByCode() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 [09:25:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154020 (owner: 10Henning Snater) [10:00:28] (03PS1) 10WikidataBuilder: New Wikidata Build - 14/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154025 [10:10:01] Oh look, https://www.wikidata.org/wiki/Special:MostLinkedPages got a update yesterday. [10:10:18] Still not much womans. :( [10:15:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154025 (owner: 10WikidataBuilder) [10:16:10] hey :) [10:17:14] JeroenDeDauw: why did you remove MediaWikiTestCase from tests which extend it? [10:18:38] lazowik: if it's not needed then don't use it [10:19:35] aude: but he removed use [10:19:37] not extending [10:20:01] link? [10:20:07] * aude might be confused [10:20:36] (and I +1d that…) [10:20:51] a sec. [10:22:06] aude: https://gerrit.wikimedia.org/r/#/c/153611/8/repo/tests/phpunit/includes/content/EntityContentDiffTest.php [10:22:39] that looks like a mistake [10:24:10] oh, ok [10:24:20] jenkins said 'no' [10:24:21] * lazowik wonders why merging before WikidataJenkins [10:24:33] mikstake [10:24:35] mistake* [10:24:48] wmf jenkins only does linting [10:25:07] maybe he got confused and saw that [10:25:13] maybe he did a follow-up? [10:25:14] idk [10:25:27] don't know [10:25:36] hmm [10:25:49] * aude been confused a few times by wmf jenkins [10:27:26] easy to check [10:27:41] if it's still like that, jenkins will fail on all jobs [10:27:51] hoo reverted it [10:28:01] yep [10:30:08] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06selfcompare from 14c3c53db to 1435c7be1: 02http://git.io/44x_TA [10:30:08] 13WikibaseDataModel/06selfcompare 1435c7be1 15Thiemo Mättig: Test if getHash is static [10:33:47] [13WikibaseDataModel] 15thiemowmde created 06abc (+1 new commit): 02http://git.io/9p7t0w [10:33:47] 13WikibaseDataModel/06abc 14ee10856 15Thiemo Mättig: Assert instanceof PropertyId [10:34:12] [13WikibaseDataModel] 15thiemowmde opened pull request #139: Assert instanceof PropertyId (06master...06abc) 02http://git.io/mCPtCQ [10:36:38] (03PS4) 10Bene: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [10:37:32] [travis-ci] wmde/WikibaseDataModel/abc/ee10856 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32526672 [10:45:35] (03Abandoned) 10Addshore: New Wikidata Build - 13/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/153768 (owner: 10WikidataBuilder) [10:45:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [11:22:37] hello, is any admin here? it's not really urgent :) [11:23:03] just a curious question about https://www.wikidata.org/w/index.php?title=Q17417913 [11:23:54] I'd like to know please what Wikipedia article (I guess) it had linked in [11:24:20] I assume just and admin can see that item's deleted history [11:24:26] Nothing. [11:24:32] Just a label and a description [11:24:35] hello Glaisher [11:24:46] Yes, hello [11:24:52] ohh, may you tell me the label please? [11:25:19] of course, if it is in a latin language hehe [11:25:20] Peones de Amaya (Q17417913) [11:25:20] Localidad de España. Burgos. [11:25:31] well, no [11:25:32] ohhh thank you very much [11:25:33] es [11:25:34] no? [11:25:40] Spanish [11:26:01] yes, that's Spanish [11:26:16] ok man, thanks again [11:59:58] http://tools.wmflabs.org/wikidata-todo/stats.php is working again, showing the effect of the Wikidata-game. [12:15:16] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "What Jeroen said. But found a big ouch. ;-)" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene) [12:32:01] Tobi_WMDE_SWE: making a patch? [12:32:26] removing mediawiki dependency works for the widget and most of the repo js [12:50:57] (03CR) 10Aude: [C: 032] New Wikidata Build - 14/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154025 (owner: 10WikidataBuilder) [12:53:40] (03Merged) 10jenkins-bot: New Wikidata Build - 14/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154025 (owner: 10WikidataBuilder) [13:02:37] aude: I'm making patches [13:02:43] lot's of patches.. ;) [13:11:40] Tobi_WMDE_SWE: great [13:13:37] aude: https://www.wikidata.org/wiki/Category:Badge_items [13:13:51] (03PS1) 10Tobias Gritschacher: Remove ResourceLoader dependencies to jquery and mediawiki [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) [13:19:38] [13ValueView] 15tobijat created 06rem_depts (+1 new commit): 02http://git.io/bRuoMA [13:19:38] 13ValueView/06rem_depts 143f394e0 15Tobias Gritschacher: Remove ResourceLoader dependencies on jquery and mediawiki... [13:20:05] [13ValueView] 15tobijat opened pull request #105: Remove ResourceLoader dependencies on jquery and mediawiki (06master...06rem_depts) 02http://git.io/mnGZpA [13:25:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [13:25:47] [13DataValuesJavascript] 15tobijat created 06rem_depts (+1 new commit): 02http://git.io/6ZPqkQ [13:25:47] 13DataValuesJavascript/06rem_depts 1438a1673 15Tobias Gritschacher: Remove ResourceLoader dependencies to jquery and mediawiki... [13:25:51] yay [13:32:52] [13DataValuesJavascript] 15tobijat created 06remove_rl_dependencies (+1 new commit): 02http://git.io/6xnfFA [13:32:52] 13DataValuesJavascript/06remove_rl_dependencies 14961d4aa 15Tobias Gritschacher: Remove ResourceLoader dependencies to jquery and mediawiki... [13:33:12] [13DataValuesJavascript] 15tobijat opened pull request #47: Remove ResourceLoader dependencies to jquery and mediawiki (06master...06remove_rl_dependencies) 02http://git.io/IF8IFA [13:38:17] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/154025 (owner: 10WikidataBuilder) [13:45:57] JeroenDeDauw: why not use Mockery in BatchingIterator tests? [13:46:39] aude: Thiemo_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=69468 [13:48:41] aude: Thiemo_WMDE: for DataValuesJavaScript we were already working on major version 0.6 which we probably not want to release right now, so I created another branch which contains the fix too, and we should create the new tag from this branch then [13:48:44] https://github.com/wmde/DataValuesJavascript/tree/rem_depts [13:49:26] please test if the errors are gone and the changes are sane and merge them. then I'm going to tag new versions [13:50:36] * aude seeing undeserializable values in place of entity id values on my wiki [14:00:44] aude: Does Wikidata need a version bump before todays branching? [14:00:56] Reedy: not ready yet, but yes [14:01:06] * aude can update submodule [14:01:26] Any idea how long you'll be? [14:01:29] Don't mind waiting a bit [14:01:40] not sure [14:01:49] Still early, just thought I'd make a start with all the changes to core alone [14:01:54] * aude keeps finding bugs but suppose they don't block test.wikidata [14:02:07] as long as they are fixed by tuesday [14:04:28] aude: You want to branch today? [14:04:36] hoo: want to [14:04:37] (which makes sense) [14:04:54] I would really like https://gerrit.wikimedia.org/r/152196 in [14:05:01] Magnus requested it :P [14:05:02] * aude files a bug and then reviews tobi's patches [14:05:38] i see chris approves [14:08:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=69542 @todo [14:11:12] Tobi_WMDE_SWE: still get one error [14:11:12] Uncaught TypeError: undefined is not a function [14:11:20] property edit tool [14:11:58] ilne 399 of wikibase.ui.PropertyEditTool.js [14:12:02] line* [14:12:30] mw.template('wikibase-toolbar', ...).toolbar() [14:12:36] method undefined [14:12:59] otherwise much better [14:13:27] Should I wait? :) [14:13:40] Reedy: no need to wait [14:13:43] Ook [14:13:44] * aude can update submodule [14:14:12] skipping a deployment would not be better though, so we'll get this ready for test.wikidata [14:15:03] and w/o our js fixes, what's deployed now will break together with new core branch [14:15:14] Tobi_WMDE_SWE: do you have a link to a page that says "do not state dependencies on mediawiki and jquery"? [14:15:24] Thiemo_WMDE: krinkle says so [14:16:57] (03CR) 10Aude: [C: 032] "looks ok to me, and no objections from chris ..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152196 (owner: 10Hoo man) [14:17:05] (03Merged) 10jenkins-bot: Allow CORS for all origins on Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152196 (owner: 10Hoo man) [14:17:19] thanks, aude :) [14:17:38] hoo: https://gerrit.wikimedia.org/r/#/c/153113/ [14:17:50] tiny thing but would clean up ganglia slightly [14:18:15] lazowik: why would I do that? [14:18:30] seems a bit nicer than phpunit mocks [14:18:42] (nicer to read and very nicer with more complex things) [14:19:24] JeroenDeDauw: and next time I'm not +1 until Jenkins approves [14:19:24] aude: submitted [14:19:34] lazowik: aude: wtf... looks like a bug in PHPStorms import cleanup thing [14:19:47] yup [14:22:35] lazowik: aude: fail... https://cloud.githubusercontent.com/assets/146040/3921141/6047249e-23be-11e4-800b-c5538d00c8a9.jpg [14:23:16] waaat [14:25:02] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/se89tA [14:25:02] 13WikibaseDataModel/06master 14134beb8 15Jeroen De Dauw: Merge pull request #139 from wmde/abc... [14:26:17] [13DataValuesJavascript] 15JeroenDeDauw closed pull request #47: Remove ResourceLoader dependencies to jquery and mediawiki (06master...06remove_rl_dependencies) 02http://git.io/IF8IFA [14:27:10] Guess PHPStorm dissaproves of that class? [14:27:55] JeroenDeDauw: Is that how you broke master yesterday? [14:28:02] [13ValueView] 15JeroenDeDauw 04deleted 06rem_depts at 143f394e0: 02http://git.io/xtXPIQ [14:28:45] hoo: probably [14:28:49] thnx to whoever fixed it [14:28:56] JeroenDeDauw: I reverted it :P [14:29:04] >_> [14:29:06] ahhhhhhh [14:29:14] wait for jenkins! [14:29:20] wikidatajenkins [14:29:29] and don't self merge [14:30:50] the jenkins bot thing should not merge if it did not run the tests [14:31:05] I only noticed this very recently [14:31:13] But apparently this has been happening for months [14:31:22] And everyone just ignores the broken behaviour? [14:31:30] This is something that should be fixed... [14:31:50] (03CR) 10Aude: [C: 031] "looks ok and almost all the errors go away, together with the github patches" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:31:57] JeroenDeDauw: It's well known [14:32:04] lol [14:32:26] also it wouldn't have happened if you waited for me to merge it [14:33:31] (03CR) 10Helder.wiki: [C: 031] "See also Ic8b4ed45d4d42172a456cc5eaf314c41e4e6fd18." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:35:08] (03CR) 10Fomafix: [C: 04-1] "I think it is a better solution to solve this problem in ResourceLoader." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:36:01] hoo: yeah yeah, point taken [14:36:46] hashar: the jenkins job for Wikibase.git is giving verified+2 based on just running lints. Can this be changed to +1? [14:36:48] (03CR) 10Tobias Gritschacher: "If you can do so before we deploy, feel free.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:37:50] JeroenDeDauw: bug fill it please I am busy [14:38:00] or amend the conf in integration/zuul-config.git [14:38:19] hashar: thnx, was wondering where the repo was [14:41:23] JeroenDeDauw: gerrit [14:42:15] Reedy: aha, and my treasure map is on the internet [14:43:21] hoo|away: capiunto bugs filed btw [14:43:40] hashar: no idea if this is correct https://gerrit.wikimedia.org/r/#/c/154058/ [14:45:35] (03CR) 10Aude: "improving ResourceLoader to handle this better would be good, but this looks like the proper fix for wikibase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:46:20] Thiemo_WMDE: run "php phpunit.php structure/ResourcesTest.php" [14:46:28] it will show you all the bad dependencies [14:46:34] aaaa [14:49:01] Tobi_WMDE_SWE: there is one in data model js [14:49:21] gone now [14:52:32] (03CR) 10Aude: [C: 032] "per "php phpunit.php structure/ResourcesTest.php" etc., jquery and mediawiki should not be listed as resource dependencies" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:52:34] alright [14:52:38] * aude can wait no more [14:52:41] (03Merged) 10jenkins-bot: Remove ResourceLoader dependencies to jquery and mediawiki [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154050 (https://bugzilla.wikimedia.org/69468) (owner: 10Tobias Gritschacher) [14:56:55] Impatient aude is impatient? That's new :) [14:57:17] heh [15:02:00] (03CR) 10Bene: [C: 04-1] "thanks for noting" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene) [15:07:22] Lydia_WMDE: \o/ [15:07:26] Awesome [15:07:43] * hoo flying tomorrow [15:07:53] will try to push the api JS stuff patch today [15:07:56] but can't promise [15:08:18] hoo: benestare do we need the wikibase/wikidata.org dependdnecy? [15:08:40] or https://github.com/wmde/WikimediaBadges [15:08:41] I think bene* already implemented that [15:08:49] aude: Only the wikidata.org for now [15:08:58] unless you want to enable them test wise on testwikipedia or so [15:09:07] ok [15:09:16] it's not in packagist [15:09:19] no [15:09:27] but bene wanted to do it via a vcs [15:09:34] ok [15:09:36] can do [15:09:51] I can also, it's rather trivial [15:10:01] but he wanted to do it himself [15:10:08] so I guess he has something in github or so [15:10:23] * aude making build now [15:12:26] https://www.mediawiki.org/wiki/MediaWiki_1.24/wmf17/Changelog [15:12:39] (03CR) 10Bene: [C: 04-1] "this prevents third party users from using Wikibase with sitelinks. If we remove this script we have to find another way of filling the si" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145765 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [15:12:44] Reedy: ok [15:13:02] I'm gonna go break testwiki [15:13:53] heh [15:14:07] (03CR) 10Hoo man: "It's only going to be moved, not entirely deleted." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145765 (https://bugzilla.wikimedia.org/42207) (owner: 10Hoo man) [15:14:09] hah [15:14:16] Testwikis were made to be broken. [15:14:32] benestare: read commit messages :p [15:14:34] "Moved to WikimediaMaintenance with Id3335cce" [15:17:19] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf17/199d7ff : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/32547790 [15:17:47] woooo [15:17:58] JeroenDeDauw: back [15:17:59] wow [15:18:23] JeroenDeDauw: does the WikidataJenkins manage to submit changes? [15:18:29] I mean, when folks vote CR+2 [15:18:38] no [15:18:40] JeroenDeDauw: https://github.com/wikimedia/integration-zuul-config/blob/master/layout.yaml#L247 [15:18:40] hashar: I do not think so [15:18:52] if we remove gate-and-submit ( https://gerrit.wikimedia.org/r/#/c/154058/1/layout.yaml ) [15:18:58] the changes will no more be merged automatically [15:19:29] hashar: automatic merging should only happen if the stuff has actually been tested, so if that's not happening... [15:20:24] hashar: what's the deal with being able to run composer on WMF Jenkins btw? You and some other people where doing something in that direction no? [15:20:49] yup using multiple repositories [15:21:06] gah [15:21:37] (03CR) 10Thiemo Mättig (WMDE): "I was reading "thanks for nothing" and was shocked for a second. ;-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene) [15:22:39] hashar: What's the actual problem? Accessing foreign resources? [15:22:46] [travis-ci] wmde/WikibaseQueryEngine/hhvm/66c2a8d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/32550004 [15:27:00] hoo: i still have an item on my todo list to remind you about special:entitydata public access [15:27:08] that was done? [15:27:33] done [15:27:35] Lydia_WMDE: Katie just merged it :) [15:27:43] cool [15:27:47] aude: Did you test your PR against the build resources? [15:27:48] thx! [15:31:24] hoo: one sec [15:31:30] * aude needs to require_once "WikidataOrg.php" [15:32:01] yep [15:32:14] also entry point needs to be in the extension list somehow [15:32:18] yes [15:32:25] moar entry points? [15:32:38] Reedy: Yes... and there's even more to come [15:32:47] within our build [15:32:52] yep [15:33:08] those are just trivial components which add icons and CSS [15:33:40] not even sure they are worth listing on Special:version [15:33:40] probably nto [15:39:24] hoo: benestare the WikidataOrg extension is loaded, purged caches and doesn't seem to have any effect [15:39:44] aude: that's probably ok [15:39:50] look at whether the CSS is there [15:39:52] do i need to config? [15:40:02] (on item pages) [15:40:25] Not for the CSS to be added, you should be able to find it in the developer toolbar of your browser [15:40:35] but you can also configure it, ofc. [15:40:37] it's there [15:41:44] my badges might be configured wrong [15:49:22] aude: You need to map them to the right classes [15:49:42] but if the CSS is there, it should be fine [15:49:57] enough people have tested that already [15:53:07] good enough for now [15:53:19] (03PS1) 10Aude: new deployment build, mw1.24-wmf17 [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154072 [15:53:54] bah [15:55:10] (03PS2) 10Aude: new deployment build, mw1.24-wmf17 [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154072 [15:57:44] aude: did anyone review the property suggestor changes, btw? [15:57:46] Lydia_WMDE: ^ [15:57:58] nothing should've changed there [15:58:17] aude: Didn't yet change the tag for composer to 1.0? [15:58:20] confused [15:58:26] or was that the old version [15:58:28] we are using a tagged version and can update the tag [15:58:33] ah [15:58:34] we were using 1.0 in the last deployment [15:58:55] so we were just marking that as explicit in the composer.json [15:58:56] we should use new tag for next deployment + review it [15:58:59] hoo: yes [15:59:06] ok, nevermind, then [15:59:44] * aude shall do selenium tests now [15:59:54] yes, please [15:59:59] so many JS changes [16:00:07] since beta is broken, have to do locally [16:00:10] if it goes for testwikidata today [16:00:18] please bump the cache epoch [16:00:21] we could run selenium on test wikidata [16:00:25] also* [16:00:25] yep [16:04:07] later [16:05:27] hoo: can you try https://gerrit.wikimedia.org/r/#/c/154072/ ? [16:05:40] i'm purging caches, checked the code and am getting js errors [16:10:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154072 (owner: 10Aude) [16:10:38] bah [16:12:22] yikes [16:12:33] why is it trying to install it on client? [16:12:56] aude: How do you pull it in? [16:13:11] sorry, am jumping around in the whole house today... packing and stuffs [16:13:12] if ( !empty( $wmgUseWikibaseRepo ) ) { [16:13:21] include_once __DIR__ . '/extensions/Wikidata.org/WikidataOrg.php'; [16:13:29] why empty? [16:13:45] if ( isset( ... ) && $wmgUse... ) { [16:13:49] instead of that [16:13:50] that's why I would do [16:13:59] ori changed it, but seems ok [16:14:02] because false is not empty [16:14:14] ah [16:14:39] s/why/what/ [16:14:42] :P [16:16:32] $f = false; echo empty( $f ); [16:16:32] 1 [16:16:35] wtf [16:16:37] I HATE PHP [16:16:40] works for me [16:16:58] * aude haaaaaaaaaaaate php :P [16:16:59] I mean it might be empty as in no bits set [16:17:10] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06selfcompare from 1435c7be1 to 14e1be9b9: 02http://git.io/44x_TA [16:17:10] 13WikibaseDataModel/06selfcompare 14e1be9b9 15Thiemo Mättig: Test if getHash is static [16:17:13] but we're in a high language here and it has a value [16:18:12] ojh [16:18:13] oh [16:18:20] autoload WikidataOrg.php [16:18:36] oh wait [16:18:38] 1 = true [16:18:40] meh [16:18:44] * hoo didn't sleep much [16:18:48] m( [16:19:39] wait, I was right before and am wrong now [16:19:58] * hoo should get back towards clearing his camera SD [16:21:09] hoo: do we want to remove the autoload in composer? or have yet another magic setting? [16:22:59] aude: mh... we could also only pull it in via mediawiki-configuration [16:23:13] will it also die if entered via localization stuffs? [16:23:17] that would be bad [16:23:25] localization has everything [16:23:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154072 (owner: 10Aude) [16:24:53] ah ok [16:25:01] * aude making pull request [16:25:58] (03PS1) 10Thiemo Mättig (WMDE): Extends \MediaWikiTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154081 [16:26:38] Any idea why "Add pages where I have performed a rollback to my watchlist" isn't translated on Wikidata? I'm sure I've done it on translatewiki. [16:26:48] why am i not allowed to make a pull request? [16:26:56] (03CR) 10Hoo man: [C: 031] "What the heck PHPStorm? Netbeans is better at that" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154081 (owner: 10Thiemo Mättig (WMDE)) [16:26:57] oh [16:27:01] you need superpullrequester for that [16:27:06] aude: On what? [16:27:10] * aude logged out [16:27:12] github [16:28:05] https://github.com/wmde/Wikidata.org/pull/7 [16:28:58] merged [16:29:04] thanks [16:29:16] loading it via mediawiki config. seems like the sanest way to do stuff for me [16:29:31] * load [16:29:36] sure [16:30:24] (03PS3) 10Aude: new deployment build, mw1.24-wmf17 [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154072 [16:36:14] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/154081 (owner: 10Thiemo Mättig (WMDE)) [16:39:19] Lydia_WMDE: What's with the sudden Commons question influx? ;-) [16:44:44] multichill: it seems to me it is mostly a handful of very active people who were at Wikimania in the sessions [16:44:52] and now have a lot of questions to clarify [16:45:01] yes [16:45:57] alright, js is broken for me [16:46:00] still [16:46:03] gnah [16:46:06] error? [16:46:07] Lydia_WMDE: I was thinking about something we can do on Commons right now. [16:46:10] * aude sure tobi's changes are in the build [16:46:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf17) - 10https://gerrit.wikimedia.org/r/154072 (owner: 10Aude) [16:46:33] and jenkins approves! [16:46:50] We create items for *every* category on Commons. Link them on Wikidata to their topics. Implement some javascript on Commons that only works on categories and fetches the relevant information from the connected wikidata item [16:46:51] phpunit passes for me [16:47:12] multichill: sounds fine to me [16:47:36] By the time we have the arbitrary acces, we just replace .js with .lua ;-) [16:47:59] *nod* [16:48:04] So, you want to use https://www.wikidata.org/wiki/Property:P301 ? [16:48:13] * aude reclones and checks out my build patch [16:48:47] sjoerddebruin: Yes, and the combines one [16:49:03] That sounds logical. [16:49:05] https://www.wikidata.org/wiki/Property:P971#top [16:50:00] That one too sjoerddebruin, for example for Category:Churches in Haarlem [16:50:16] Didn't know it existed. :P [16:50:33] I suck at Javascript, so we would need someone else to hack up that part [16:56:55] Warning: Invalid argument supplied for foreach() in /usr/local/apache/common-local/php-1.24wmf16/extensions/Wikidata/extensions/Wikibase/repo/includes/api/GetEntities.php on line 237 [16:58:23] hmmm [16:59:15] even on master, composer update of the build, i get js errors [16:59:29] master of the build or master of Wikibase? [16:59:41] Can test master of Wikibase now, don't really have the time for build testing, though [16:59:54] master of the build updated with master of wikibase [17:00:57] hoo: if you can see if master wikibase works or not, that would be helpful [17:01:32] aude: Anything particular to look at? [17:01:36] Or just itme view? [17:01:46] view an item [17:01:55] or try the link item widget [17:02:06] * aude tries master wikibase also [17:02:09] doing [17:02:30] could be i really have confused caches, although i cleared memcached etc [17:02:35] The value is invalid and cannot be displayed. [17:02:43] bah, i know [17:03:04] what's that? [17:03:07] we can deploy with that but obviously needs fixed [17:03:12] Is my test data screwed? [17:03:15] nope [17:03:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=69542 [17:03:34] with master wikibase (no build), i get no js errors [17:03:47] yep, same here [17:04:09] * aude can just take a chance and have new code deployed on test.wikidata [17:04:19] uh [17:04:21] either 1) it's just my caching and it works [17:04:29] 2) js is broken for the weekend [17:04:34] well, kill everything that caches and rety [17:04:35] 3) old code until monday [17:04:47] beta is broken, right? [17:04:50] https://www.wikidata.org/w/index.php?title=Q134390&diff=150717247&oldid=143465552 <- huh? Why do I see edits without a diff? [17:04:50] 4) maybe we ask nicely for friday deploy [17:04:53] hoo: it is [17:05:00] gnah [17:05:09]