[03:36:01] ? [07:10:14] (03Draft1) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [07:14:51] (03PS6) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [07:23:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [07:23:55] (03Draft1) 10Henning Snater: Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 [07:32:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [07:37:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [08:07:11] (03PS2) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [08:18:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [08:33:27] hey :) [09:19:44] [13WikibaseDataModel] 15thiemowmde comment on pull request #132 14c3c53db: How? I'm a programmer. It's my job to make things do what they are supposed to do. But this doesn't answer my question what this _is_ supposed to do. You told me the hashes already changed between 0.x and 1.0. I think this is a problem and should not be done. I'm asking if I should fix this. 02http://git.io/DdWkVA [09:32:31] [13WikibaseDataModel] 15thiemowmde created 06selfcompare0 (+1 new commit): 02http://git.io/Pasesw [09:32:31] 13WikibaseDataModel/06selfcompare0 1448d5fc1 15Thiemo Mättig: Drop self-comparisons [09:33:25] [13WikibaseDataModel] 15thiemowmde opened pull request #137: Drop self-comparisons (06master...06selfcompare0) 02http://git.io/BOYVqw [09:35:19] [travis-ci] wmde/WikibaseDataModel/selfcompare0/48d5fc1 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32416433 [09:36:43] [13WikibaseDataModel] 15thiemowmde comment on pull request #132 14c3c53db: Opposing what? What does "working against refactoring" mean? This is testing if a hash is stable. That's not an implementation detail. 02http://git.io/ErH0gA [09:50:18] (03PS1) 10Thiemo Mättig (WMDE): Drop unused EntityRevisionSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 [10:00:25] (03PS1) 10WikidataBuilder: New Wikidata Build - 13/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/153768 [10:08:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153766 (owner: 10Thiemo Mättig (WMDE)) [10:15:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/153768 (owner: 10WikidataBuilder) [10:15:56] Hello [10:42:56] [13WikibaseQuery] 15thiemowmde created 06scrutinizer (+1 new commit): 02http://git.io/TX1cjw [10:42:56] 13WikibaseQuery/06scrutinizer 148f79c4c 15Thiemo Mättig: Add .scrutinizer.yml [10:43:44] [13WikibaseQuery] 15thiemowmde opened pull request #49: Add .scrutinizer.yml (06master...06scrutinizer) 02http://git.io/Wo8DMQ [10:45:39] [travis-ci] wmde/WikibaseQuery/scrutinizer/8f79c4c : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/32421652 [11:30:47] multichill, hi, are you here? [11:30:58] somewhat [11:31:48] What's up Jhs? [11:35:33] multichill, i don't understand how to use harvest_template.py . I do exactly as the documentation says, and it browses through all pages ("Processing [[no:blablabla]]..."), but it doesn't edit Wikidata at all [11:36:27] the above ^ [11:36:29] multichill, i don't understand how to use harvest_template.py . I do exactly as the documentation says, and it browses through all pages ("Processing [[no:blablabla]]..."), but it doesn't edit Wikidata at all [11:36:56] this is the way i called it: [11:37:02] python harvest_template.py -template:"Filmografi" id P1439 [11:37:39] and it runs through all the pages using the template, but it seems it either (a) doens't find the parameter id or (b) isn't able to edit Wikidata [11:38:37] * multichill looks [11:39:30] Looks like it's already imported? [11:40:35] multichill, yes, now, i used a different script that i got from Amir [11:40:55] but i wasn't able to do it with harvest_template.py at all .. [11:45:57] odd [11:46:10] Working right now. I'll have a look at it later [11:51:35] (03PS1) 10Tobias Gritschacher: Make monolingual-text datatype non-experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 [11:51:36] multichill, thanks :) [12:02:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 (owner: 10Tobias Gritschacher) [12:20:20] Lydia_WMDE: heyho, are you around? [12:20:31] benestar: hey! :) [12:20:33] wasup? [12:20:51] I'm just thinking what I can do for structured wikiquote [12:21:11] I think a good approach would be to create the new entity type [12:21:18] yeah [12:21:31] but apperently JeroenDeDauw or so are just working (or not yet working) on refactoring this [12:21:36] yeah [12:22:18] so what can I help there? I found https://github.com/wmde/WikibaseDataModel/issues/22 [12:22:43] i think a good start is writing down what you want the entity type to do and what it needs [12:22:52] Lydia_WMDE: do you know if the interfaces are already created? or if it would be a good idea to implement them? [12:22:52] and then have jeroen and daniel and others have a look at it [12:26:15] benestar: btw did anything happen wrt hover cards at the hackathon? [12:26:25] after the email you sent [12:26:49] Lydia_WMDE: basically I did not send the mail yet because I was confused by the different mail addresses ;) [12:27:02] ohh [12:27:03] ok [12:27:11] time to send it then? ;-) [12:27:12] so it is on my todo list now after hoo|away explained me the aliases [12:27:18] cool [12:28:03] (03PS7) 10Henning Snater: Revamped site links related JavaScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 [12:28:43] benestar: i'll create a postit for hover cards on the big wall tomorrow :P [12:30:00] (03PS3) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [12:30:02] Lydia_WMDE: great [12:30:42] having them working on wikidata -> <3 [12:30:45] * benestar is strang: happy about more work ^^ [12:30:45] *e [12:30:48] lol [12:30:52] we all are... [12:34:35] Thiemo_WMDE: can you fix your badgesstyle script please? [12:34:52] the li element has to be put into a
    element... [12:35:09] there are rules like .portlet li.FA [12:35:15] which I haven't seen before *argh* [12:43:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/152875 (owner: 10Henning Snater) [12:49:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [12:54:39] Some lovely people on the Hebrew Wikipedia started playing with Wikidata properties \o/ [12:56:30] A template for calculating and showing the age of a person in a person infobox gets the birth data from Wikidata. [12:57:02] If there is no item for the person who is the subject of the article, the person is automatically added to a category. [12:57:50] And if there is an item, but there is no sex property, the article is added to another category. (That's because in Hebrew saying the age depends on gender.) [12:58:10] Is anything comparable done in other languages? I'd love to add interlanguage links to the categories if it's relevant. [12:58:59] More importantly, is there some easy known way to add the sex property to these items? Bot? Tool? Reasonator? Some Wikidata game? [12:59:08] Or only to edit the item page in Wikidata? [13:02:06] (03Abandoned) 10Addshore: New Wikidata Build - 12/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/153572 (owner: 10WikidataBuilder) [13:07:55] Lydia_WMDE: https://meta.wikimedia.org/wiki/Wikidata/Development/Wikiquote [13:08:13] did I forget anything? is there something which has to be extended? [13:08:51] benestar: will have a look [13:09:34] aharoni: in the item i emailed you a link to there are some example iirc about enwp adding a category if no image exists on wikidata but enwp has one or the other way around for example [13:10:07] aharoni: as for mass-editing take a look at autolist2 by magnus [13:10:25] and the game automatically picks them up as well if they're marked as human [13:13:57] Lydia_WMDE: hey :) [13:14:07] hey lazowik! [13:14:13] lazowik: duuuude! [13:14:19] soo, my spies reached you? :p [13:14:20] you sent spies ;-) [13:14:29] one of them did at least [13:14:33] that's what I do :D [13:14:48] ;-) [13:15:41] benestar: it looks complete to me based on our discussions so far :) [13:15:45] thanks for writing it up! [13:15:50] benestar: y u complaining on refactoring? [13:16:06] Lydia_WMDE: you've mail :) [13:16:22] lazowik: what are you talking about? [13:16:37] "but apperently JeroenDeDauw or so are just working (or not yet working) on refactoring this" [13:17:04] benestar: \o/ [13:17:09] lazowik: I'm not complaining ;) [13:17:27] I just do not want to write some hackish code if the system will be refactored anyways [13:17:44] so I'm rather happy about the refactoring and want to join it .) [13:17:46] :) [13:18:04] yeah, sure, explain yourself [13:18:05] :D [13:18:42] Lydia_WMDE: so do you know if JeroenDeDauw or so already created the EntityIdProvider and FingerprintProvider? [13:19:03] benestar: i do not unfortunately [13:19:08] . [13:19:13] but JeroenDeDauw does :D [13:19:16] :D [13:19:24] JeroenDeDauw: are you working on that yet? [13:19:31] otherwise I will create a patch for it ;) [13:19:36] benestar: entity for Wiktionary? [13:19:46] JeroenDeDauw: no, for Wikiquote [13:19:52] err [13:20:12] benestar: all new entity types are blocked on having the serialization chhange finalized [13:20:18] You can already start doing something [13:20:23] But we'll not be able to use it [13:20:45] JeroenDeDauw: this new entity is even blocked by refactoring the Entity class [13:20:57] because it does not contain a fingerprint [13:21:14] benestar: that part is already done [13:21:20] benestar: it should just not extend Entity [13:21:25] JeroenDeDauw: on which branch? [13:21:33] oh, ok [13:21:39] benestar: also, Entity does contain a fingerprint?? [13:21:43] benestar: master [13:22:07] And 0.8.x (used by WB.git master) already has the getter I think [13:22:10] Yeah [13:22:14] @since 0.7.3 [13:22:22] JeroenDeDauw: yes, Entity contains a fingerprint and we do not want it ;) [13:22:30] ah [13:22:35] so we can just add another entity type without extending entity? :O [13:22:41] benestar: yeah, like I said, you do not want to extend Entity [13:22:50] benestar: from the DataModel side: yes [13:22:57] but I think most of our code depends on entities implementing Entity [13:23:05] at least in Wikibase itself [13:23:05] However at this point WB.git does not allow adding new entity types in any way [13:23:19] There are lots of bad assumptions in that code that need to be fixed first [13:23:36] benestar: did you see my email on not type hinting against Entity? [13:24:04] "Planned changes to the Entity hierarchy" [13:24:09] June 2nd [13:24:15] wikidata-tech [13:24:50] JeroenDeDauw: yeah, but I think there are still lots of typehints against it, aren't there? [13:24:50] benestar: if you want to help with getting us to having these new entity types, two things come to mind [13:25:20] 1. remove such bad type hints against Entity (there are some that will be tricky to get rid off, but most ought to be not so hard) [13:25:37] 2. help with switching us over to DataModel 1.0, so development on DataModel can continue [13:26:01] JeroenDeDauw: this is the serialization code you mean, right? https://github.com/wmde/WikibaseDataModelSerialization [13:26:21] benestar: for doing 1, you will need the new objects such as Fingerprint, and might also have use for the new EntityDocument interface [13:26:25] Those are already on 0.8.x [13:26:42] benestar: huh? I do not get your question [13:27:05] JeroenDeDauw: you told me for switching to DataModel 1.0 we have to fix serialization [13:27:15] so I guess you mean DataModelSerialization [13:27:38] benestar: no, the issue is that Wikibase.git uses DataModel 0.8.x [13:27:40] It needs to use 1.0.x [13:27:50] The serialization thing used to block that [13:27:54] It no longer does AFAIK [13:28:03] ah, ok :D [13:28:17] so I just have to switch to DataModel 1.0 and fix all errors? [13:28:22] Yeah [13:28:32] benestar: this branch might be of help for that [13:28:33] * benestar modifies his composer.json [13:28:34] https://gerrit.wikimedia.org/r/#/c/153714/ [13:29:00] It already removes some stuff that will need to be ditched or modified when we make the switch [13:29:18] Such as tests that compare the old code against the new (and that no longer is possible when you do not have the old code anymore) [13:29:40] JeroenDeDauw: so I will just create a patch on top of that branch? [13:29:47] benestar: no [13:29:57] benestar: just find out what is wrong using this branch [13:30:05] Then switch back to master [13:30:07] Anf fix the issue [13:30:23] Or fix it before, but submit the patch against master [13:30:28] ok, makes sense :) [13:30:50] thanks for you guidance, I will ask you if I need more help [13:31:17] benestar: Lydia_WMDE: so there are plans for a new entity type for wikiquote? [13:31:34] JeroenDeDauw: benestar wants to work on that yes [13:31:39] Can we please create an overview of the new entity types we plan to create? [13:31:52] commons, query, quote, wiktionary... [13:32:07] JeroenDeDauw: I suppose they won't go all into WikibaseDataModel [13:32:14] benestar: probably not [13:32:26] Though to make a good decision there we need to have some idea of where we want to end up [13:32:43] JeroenDeDauw: maybe we should even move item out of DataModel... [13:32:56] JeroenDeDauw: media info for commons, query for wikidata, quote for wikiquote and _something_ for wiktionary though that seems a bit more complicated and needs to be talked through with daniel as he has more detailed plans for that [13:33:03] it is quite Wikidata specific at the moment [13:33:16] other than that no plans currently (but then again quote wasn't on my plan until wikimania either) [13:34:11] Lydia_WMDE: ^^ [13:34:18] ;-) [13:34:42] benestar: haha. my first thought to that was "huh, that's crazy". thnx for thinking out of the box :) [13:34:57] ;) [13:35:09] benestar: I do not think that makes sense for now, though will keep the possibility in mind [13:36:19] Lydia_WMDE: are you at the office tomorrow? [13:37:27] Lydia_WMDE: we need to really create some kind of plan for this, so we know where we want to go, and are all working with a common understanding [13:37:43] Abraham_WMDE: ^ [13:38:48] JeroenDeDauw: sure [13:38:51] i'll be [13:40:07] * benestar wants too :( [13:40:44] benestar: well, the things figured out ought to not be kept secret [13:41:08] obviously, but I also want to discuss with you ;) [13:41:08] benestar: btw, client and lib already fully work on the branch I linked [13:41:12] It's just repo [13:41:51] benestar: well, if you have questions or remarks... will be easier to remark on something when we actually have some kind of plan though LD [13:41:53] :D [13:58:46] (03PS4) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [14:11:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [14:22:12] Tobi_WMDE_SWE: Wikidata pages as sitelinks still needs configuration changes [14:22:22] (like we did on testwikidata= [14:23:01] hoo: sorry, was too quick with closing then.. ;) [14:27:01] someone want to merge https://gerrit.wikimedia.org/r/#/c/148732/ ? [14:45:07] cya. [14:47:19] is there any opensource bot to import data from templates to wikidata? [14:48:21] fale: yes [14:48:36] harvest_templates.py or something, in pywikibot [14:48:44] Nemo_bis: thanks :) [14:54:23] fale: what kind of template you want to import data? [14:55:28] hmm [14:55:43] if there are to be "tons" of entity types [14:55:50] maybe add another one for badges? [14:56:01] someone already mentioned that on the bug [14:56:06] JeroenDeDauw: benestar|afk ^ ? [14:56:12] Amir1: I'm creating a db for a (non-commercial) website with airport data. I'd like to use and improve Wikidata for this project, but I can't because one of the key values I need is the length of the runways which is not yet possible to manage in Wikidata [14:57:13] nice, but we have to wait until quantities with unit [14:57:15] lazowik: ugh... [14:57:31] overkill? [14:58:16] Let's first start with getting an idea of what we intend with the currently planned types and with making it possible in the Wikibase.git code to have something other than items and properties [14:58:50] Amir1: I know. I hope it will come soon... meanwhile I'll scrape enwiki [15:00:35] JeroenDeDauw: I'm not saying I started a patch :p, I'm saying maybe lets consider that also [15:00:41] sometime [15:01:50] lazowik: sure [15:02:08] lazowik: what I'm saying is that we first need to figure out some more basic things before we can get to that question [15:02:18] k [15:02:30] JeroenDeDauw: I'm almost done with clean code [15:02:41] I thought I could refactor here and there [15:03:02] if you have any thoughts what can I do hit me [15:44:51] lazowik: I think items as badges are ok for now [15:47:39] for now [15:51:20] Lydia_WMDE: did you think about increasing the version number? [15:51:59] benestar: not had brain cycles for that since returning. JeroenDeDauw: what do you think? [15:52:27] JeroenDeDauw: don't think anything, version numbers in Wikibase are weird anyway :P [16:14:40] [13ValueView] 15thiemowmde created 06localeCompare (+1 new commit): 02http://git.io/aMuOlw [16:14:40] 13ValueView/06localeCompare 1465d829b 15Thiemo Mättig: Sort language names alphabetically [16:19:25] [13ValueView] 15thiemowmde opened pull request #104: Sort language names alphabetically (06master...06localeCompare) 02http://git.io/zjkelA [16:27:00] lazowik: you mean you read the book Clean Code? [16:27:10] yep, almost [16:27:17] benestar: what version number? [16:27:36] I'm on systems [16:27:47] lazowik: did you read the chat between me and benestar from earlier? [16:27:53] yep [16:27:55] lazowik: there definitly is no lack of things to clean up [16:28:02] heh [16:28:15] yeah :) [16:28:16] One of them is this interface seggregation issue where things use an entitre Entity rather than just what they need [16:28:22] JeroenDeDauw: Wikibase version number [16:28:29] from 0.5 to 0.6 [16:28:46] instead property or item? [16:28:48] our version tagging system is broken anyways on Wikibse [16:28:58] lazowik: yes [16:29:00] lazowik: so if you focus on things type htining against Entity, you can do clean up that we really need to happen in the near future [16:29:23] (03CR) 10Hoo man: "Please make a new ValueView version also, when doing this (if it hasn't already happened... I didn't quite follow up recently)." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 (owner: 10Tobias Gritschacher) [16:29:43] benestar: I'm not sure how meaningfull it is to create a version for Wikibase at this point [16:29:50] benestar: Why do you want to make one? [16:30:18] JeroenDeDauw: because we deploy a bunch of new features and we somehow have to indicate that imho [16:30:38] otherwise the version of Wikibase will be 0.5 for ever [16:30:58] JeroenDeDauw: ok, will do [16:31:46] benestar: not forever but until it's ready to be called Wikibase 1.0 :p [16:32:31] Vogone: which is forever I think :P [16:32:58] benestar: the issue is that right now it's a big ball of stuff [16:33:15] And the version number alone is not very meaninfull to the end users of the entire system anyway [16:33:33] It's main use is for people dealing with the versions of the software [16:33:35] ie devs [16:33:38] or admins [16:33:56] It will thus be more meaninfull if we split up the bloody thing [16:34:19] JeroenDeDauw: which means? [16:34:34] For instance in https://github.com/wmde/WikibaseEntityStore I'd like to depend on a specific version range of Wikibase Repo, so the thing does not break when we move something in Wikibase.git [16:36:20] benestar: how is it forever? there's a huge TODO list ATM and after all these features are implemented one could call it 1.0 :p [16:43:44] benestar: I want to have meaninfull version numbers for Wikibase Client and Wikibase Repo, but then we first need to make those possible [16:45:24] JeroenDeDauw: and how are meaningfull version numbers defined? how can we make those possible? [16:45:42] benestar: split wikibase [16:45:44] to repo and client [16:46:07] and kill lib? :D [16:46:19] that's the whole plan. :) [16:47:24] whole evil [16:47:28] ;) [16:49:15] Killing lib is not a prerequisite, though ofc it'd be good to do that [16:54:55] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/B_jjHg [16:54:55] 13ValueView/06master 1491cf8af 15Tobi Gritschacher: Bump version. [16:55:43] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/VggV5Q [16:55:43] 13ValueView/06master 143711c81 15Tobi Gritschacher: Bump version. [16:56:01] [13ValueView] 15tobijat tagged 060.6.9 at 06master: 02http://git.io/CeVKbw [16:59:00] (03PS2) 10Tobias Gritschacher: Make monolingual-text datatype non-experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 [16:59:11] (03CR) 10Tobias Gritschacher: Make monolingual-text datatype non-experimental (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 (owner: 10Tobias Gritschacher) [16:59:32] (03CR) 10Tobias Gritschacher: "New ValueView version 0.6.9 is now released." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 (owner: 10Tobias Gritschacher) [17:10:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 (owner: 10Tobias Gritschacher) [17:12:49] (03PS5) 10Henning Snater: Implemented jQuery.wikibase.aliasesview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 [17:12:59] (03PS2) 10Henning Snater: Added hasConflict() to tagadata widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 [17:16:57] brr [17:17:07] murderers everywhere [17:17:14] killing libs [17:17:23] injecting sth [17:17:29] DB deadlock [17:29:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153621 (owner: 10Henning Snater) [17:35:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153758 (owner: 10Henning Snater) [18:13:51] Lydia_WMDE: I've got a monolog [18:13:54] here it comes: [18:14:00] I've been thinking about UI just now [18:14:05] lol [18:14:06] ok [18:14:12] and how hard it is to please every item [18:14:17] yes [18:14:28] and I've come up with a craziest idea I've probably ever had [18:14:34] it's not even crazy, it's nuts [18:14:38] haha [18:14:39] shoo [18:14:40] t [18:14:47] split ui into little widgest [18:14:50] *widgets [18:14:56] let properites define widgets [18:15:05] (so how each property should be shown) [18:15:26] and then make a layout of these widgets a part of item [18:15:35] so you can edit view of item [18:15:55] lazowik: wtf? [18:15:56] that's probably unmanagable and hard to code [18:16:00] (03PS1) 10Bene: Fix EntityHandlerTest with the new serialization format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153844 [18:16:03] but I couldn't resist sharing it :p [18:16:05] ;-) [18:16:08] thanks for sharing [18:16:15] JeroenDeDauw: first fix with DataModel 1.0 :D [18:16:25] but i indeed fear that it would make things considerably more complicated for our users [18:16:40] we really need to reduce complexity and not add more :/ [18:16:46] this patch removes failures 2 and 3 :D [18:18:16] Lydia_WMDE: kinda like iGoogle [18:18:28] :D [18:18:39] aude: Does tmg use irc? [18:18:53] Krinkle: you mean Thiemo_WMDE ? [18:19:13] thx [18:19:14] Thiemo_WMDE: ping [18:19:22] Lydia_WMDE: I'll make that [18:19:27] …in 20 years :p [18:19:58] lazowik: :P deal [18:20:08] i'll buy you a drink afterwards [18:20:24] also, thank you benestar for the support ("wtf?") :p [18:20:28] Lydia_WMDE: deal [18:20:46] * Lydia_WMDE hugs lazowik and benestar [18:20:52] hey Krinkle [18:21:05] Can any of you reproduce the mw.config undefined bug locally? [18:21:14] I see it on beta wikidata, but localhost with plain mediawiki is working fine [18:21:16] I can't reproduce it [18:21:26] Tobi_WMDE_SWE: ^ [18:21:30] I suspect something in Wikidata might be upsetting ResourceLoader in some fashion [18:21:34] Thiemo_WMDE reported a bug for it [18:22:05] Lydia_WMDE: btw the hovercards guy replied me and promised to give me a code review this or next week [18:22:19] Krinkle: they might have gone home already [18:22:24] benestar: \o/ [18:22:49] what, they go home before 10 pm? :O [18:22:59] sometimes [18:22:59] :P [18:23:03] Krinkle: on master? [18:23:08] but JeroenDeDauw is still there? [18:23:18] if you wait a bit I'll update [18:23:35] lazowik: yeah, master mw [18:23:44] or any commit after the one you've identified as the cause [18:27:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153844 (owner: 10Bene) [18:34:48] mpfh [18:34:52] skins thingy [18:44:15] Lydia_WMDE: has JeroenDeDauw already gone? [18:44:29] benestar: idunno. i am at home [18:44:33] on my couch :P [18:44:35] oh, ok [18:44:37] :P [18:44:37] trying to fight my inbox [18:44:40] xD [18:44:59] Lydia_WMDE: do you know why in the DataModel properties currently do not support statements? [18:45:44] benestar: because we initially only wanted claims there but then decided that references make sense there too [18:45:53] i guess that's the reason [18:46:34] Lydia_WMDE: but atm there are no claims and no statements at all [18:46:49] right [18:46:56] but there will be soon (TM) [18:47:30] Krinkle: that's mine install: http://repo.data.d610.pl/wiki/Strona_g%C5%82%C3%B3wna [18:47:43] Lydia_WMDE: will there be some on queries? [18:48:20] benestar: probably not [18:49:32] Krinkle: also, I don't see that on test.wikidata [18:49:55] production test data isnt running that version of meidaiwki yet, this landed only yesterday [18:50:28] ah [18:51:20] Krinkle: well, I'm on master on repo.data.d610.pl [18:51:32] Lydia_WMDE: do we know how we will handle all the claims and statements stuff? [18:51:55] we have to move it out of the entity specific classes because eg. queries won't have them [18:52:10] however, I also do not want to duplicate all the code in the item and property specific classes [18:52:25] benestar: yeah JeroenDeDauw has a plan but i don't know enough about it to explain it. sorry [18:52:40] gnah, so why isn't he here? :/ [18:53:28] hmm, I do have a bunch of errors on item view [18:53:59] lazowik: I get the error on http://repo.data.d610.pl/wiki/Item:Q4 [18:54:22] lazowik: The undefined error for collapsibelTabs on non-wikiitem pages is something unrelated corrupted in your instal [18:55:23] mhm [18:56:47] Lydia_WMDE: wrote a mail to wikidata-tech [18:57:13] lazowik: I think I found it [18:57:27] lazowik: wikidata has an erronous dependency somewhere on 'jquery' and/or 'mediawiki' [18:57:30] which can'tb e dependend on [18:57:42] the main loadlphp request is reconstructing jquery itself (for the second time). [18:57:51] mhm [18:57:54] benestar: thanks :) [18:57:58] If you run the phpunit tests locally I bet it throws an error for depending on 'jquery' which is illegal [18:58:12] phpunit on wikibase? [18:58:19] Any wiki with wikidata stuff installed [18:58:22] e.g. your .pl wiki [18:58:33] php phpunit.php structure/Resources.php [18:58:37] * lazowik tries [18:58:38] ResourcesTest.ph [19:00:46] Which means $ and mediawiki get randomly redefined half-way execution causing it to be reset to its plain state (yay for redefning js globals) [19:01:21] modules:dataTypes.DataType,DataTypeStore|dataValues,jquery,mediawiki,valueFormatters, [19:02:20] Module 'time.js' must not depend on 'jquery' [19:02:41] Also, I've pointed this out before, Wikidata shouldb't register such generic module names. 'DataType' and 'valueFormatters' are quite fragile as global unnamespaced names. That's asking for problems. Seems to be fine right now, since everybody else namespaces things properly. [19:03:04] but relying on everybody else following a practice doesn't scale :) [19:03:23] heh [19:06:58] Krinkle: https://github.com/wmde/DataValuesJavascript/blob/master/lib/time/time.Time.js#L362 [19:07:14] lazowik: There's nothing wrong with that [19:07:25] everything can use jQuery, youll find a 1000+ other uses of jQuery like that. [19:07:57] https://github.com/wmde/DataValuesJavascript/blob/master/lib/time/time.Time.js#L4 ? [19:08:05] * lazowik is not a js guru [19:08:25] The problem is that modules absolutely *must not* declare a dependency on 'jquery' or 'mediawiki' as those are the very environment that make up the ability to load something. By the time MediaWiki even knows about the existance of 'wikidata' jquery and mediawiki are there, without meidawiki you can't load anything from resourceloader, naturally. [19:08:56] if they explicitly instruct the loader to load jquery, it will re-load it and blow anyway any earlier defined prototypes or extensions. [19:09:04] simply remove it from the module definition. [19:09:19] This also caused a breakage last year, I guess it was added back by someone who didn't pay attention. [19:10:42] ok, then that https://github.com/wmde/DataValuesJavascript/blob/master/lib/resources.php#L46 [19:11:03] Krinkle: depending on jquery.qunit is also bad? [19:11:09] qunit.parameterize does that [19:11:21] jquery.qunit is fine [19:11:22] (03PS1) 10Bene: Make PropertyContentTest work with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 [19:11:34] only 'jquery' and 'mediawiki' are startup bootstrap modules that can't load themselves, naturally. [19:11:41] everything else is fine [19:14:14] Lydia_WMDE: please ping JeroenDeDauw and maybe some other devs to merge all my patches in https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Wikibase+branch:master+topic:dm1.0,n,z ;) [19:14:24] ai ai [19:15:33] Krinkle: https://github.com/wmde/DataValuesJavascript/commit/75438b959429ef03a97094aa9deb8af317e16a3e [19:16:05] Krinkle: you'll do the patch? [19:16:22] I don't know if some backports are neccesary etc. [19:16:33] lazowik: yeah, that code makes no sense. Whatever error he saw, was unrelated and that sure didn't fix it. If it did cause an error, he must've been loading it outside mediawiki [19:16:39] lazowik: how/where? [19:16:43] gerrit? [19:17:33] nope, github [19:17:40] per https://www.mediawiki.org/wiki/Wikibase/Components [19:17:48] Right, I knew that. [19:18:09] How do I install it locally though in a way that it works as part of the mediawiki extensions and can still use the github repo to change working tree [19:18:32] is there a repo with submodules? [19:19:21] Krinkle: composer and --prefer-source > [19:19:22] * ? [19:20:07] what is the root repo I should use to use composer inside of? [19:20:18] ha [19:20:25] Wikibase maybe [19:20:52] also I'm not sure if it's guaranteed that master of component will work will master of wikibase [19:21:08] JeroenDeDauw might be more qualified to help you [19:22:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 (owner: 10Bene) [19:28:29] (03PS2) 10Bene: Make PropertyContentTest work with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 [19:29:11] Lydia_WMDE: argh http://lists.wikimedia.org/pipermail/wikidata-l/2014-August/004298.html [19:29:25] "Doing infoboxen with Lua is profoundly anti-wiki and hopefully won't be done.​" ... [19:29:50] wat? [19:29:53] benestar: heh i was just reading this as well [19:30:04] james has a point but then... [19:30:22] that's the complete opposite from what we're planning :P [19:30:26] afaik [19:32:09] in an ideal world we'd just have a call without parameters to create the infobox [19:32:13] imho [19:32:47] Lydia_WMDE: that's what I wrote him ;) [19:33:44] k [19:36:50] Lydia_WMDE: "in an ideal world we'd just have a call without parameters to create the infobox" exactly what I'm pursing in fa.wp [19:37:12] :) [19:38:53] the badges are still planned for 19th? [19:39:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 (owner: 10Bene) [19:39:56] Amir1: indeed [19:40:04] everything is ready :) [19:40:44] benestar: I'm ready too :) [19:41:07] great :D [19:41:23] and excited since I hate Link FA and Link GA so much [19:41:23] Amir1: did you already see the badge items? [19:41:35] I added them to my codes [19:41:57] Amir1: and did you already ask the communities if they want to get those templates removed? [19:42:19] not yet because there are tons of wikis [19:42:35] note that you have to wait with removing them until the import has finished and we have deployed the rest of our code [19:43:24] I thought It would be better to make an announcement somewhere and ask people to notify me (and give me approval) if they want them to removed [19:43:38] Amir1: and we'll hopefully have a parameterless {{bio}} in it.wiki too [19:43:52] lazowik: What do I do after require_once Wikibase/Wikibase.php to get to a point where I have an Item page on my local wiki [19:43:56] benestar: yes I'm aware of that [19:44:09] Nemo_bis: yaay [19:44:34] Amir1: good [19:44:38] I thought about harvesting images, Can you add a category like what we did on nationalities? [19:44:48] Krinkle: do you have configured everything correctly? [19:44:55] nothing [19:44:55] Krinkle: http://wklej.org/id/1439101/ that should get you going [19:44:59] then go to Special:NewItem and create the item ;) [19:45:16] Krinkle: and don't forget running update.php [19:45:16] Krinkle: and after that what benestar said [19:45:20] ah, right [19:45:23] I think the default configuration should work, too [19:45:29] it works [19:45:33] I'm using that [19:45:41] Nemo_bis: I thought about harvesting images, Can you add a category like what we did on nationalities? [19:45:46] mh, not default [19:45:47] example [19:46:04] Amir1: I read your reply, thinking [19:46:33] okay, this place is crowded (?) [19:46:43] so I thought you haven't seen it [19:46:47] Amir1: we can add the category later, but for now the problem was actually adding the filenames to the bio templates [19:47:18] huh? [19:47:50] Amir1: most articles have something like [[image:blabla.jpg]]{{bio|... [19:48:31] I'm not sure the bot to move the image to a bio parameter has run already [19:48:32] adding them to the template bio via bot is easy [19:49:33] Amir1: sure, just ask rotpunkt if he did that already [19:49:33] (03CR) 10Krinkle: "fixme: This doesn't actually do what you want it to. For local installs that variable is not set. You probably meant "!isset()" instead of" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89707 (owner: 10Addshore) [19:51:33] okay [19:51:38] Amir1: and if he didn't, you're very welcome to do it yourself; it was already discussed [19:52:04] and it.wiki bot authorisations are not for specific tasks [19:52:51] cool [19:55:59] (03PS1) 10Bene: Make ItemContentTest work with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153880 [19:57:54] Nemo_bis: https://it.wikipedia.org/wiki/Discussioni_utente:Rotpunkt#Bot_to_add_image_parameters_to_Template:Bio [19:58:08] * aude waves [19:58:59] hi Amir1 [20:00:57] multichill: hey! [20:01:12] I don't know how to thank you enough [20:01:25] (03PS3) 10Bene: Make PropertyContentTest work with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 [20:01:47] I still haven't seen the video, I hope it'll be uploaded soon [20:01:52] Amir1: Presentation? Not needed, happy to do it :-) [20:02:17] You saved me the hassle of writing a proposal ;-) [20:03:17] multichill: the interesting thing is the abstract had to be "at least" 300 words but I thought It's "at the most", so the abstract is 74 words!!! [20:03:40] * multichill keeps getting confused with that wording too [20:04:24] :) [20:05:04] * Amir1 wonders Wikidata's presentation slides is public or not (I couldn't find them) [20:06:48] Amir1: which presentation? [20:06:52] Lydia_WMDE's keynote? [20:06:58] benestar: yes [20:07:06] wll, ask her ;) [20:07:10] *e [20:07:17] +' [20:07:52] according to wikimania-l livestream has keynotes [20:09:50] i didn't put my slides on commons yet [20:09:56] hope to get to that tomorrow [20:10:07] but yeah the keynote is in the livestream page [20:10:14] have not watched it myself yet :D [20:10:14] Wikidatans, I am on a book buying spree, can anyone recommend some books to help me level up? [20:10:22] Lydia_WMDE: please add this category: https://commons.wikimedia.org/wiki/Category:Wikimania_2014_presentation_slides [20:10:30] Lydia_WMDE: don't do that [20:10:37] Amir1: k [20:10:46] EdSaperia: level up on what? :D [20:10:48] thanks [20:10:49] I watched my talk and thought "wtf is that strange guy saying there?" [20:10:50] benestar: whut? [20:10:53] haha [20:10:54] ok [20:11:06] ;) [20:11:14] i will go and watch an episode of Suits instead then [20:11:18] Open to suggestions [20:11:20] benestar: people usually hate to see their videos (or hear their voice) [20:11:23] :D [20:11:40] Amir1: that's true, you see all the stupid mistakes you've made [20:11:41] afk now [20:11:42] EdSaperia: read peopleware already? [20:12:12] added to basket [20:12:18] EdSaperia: I usually recommend books from "A very short introduction" series [20:12:23] by OUP [20:13:07] ᕕ( ᐛ )ᕗ [20:13:38] I liked philosophy-related books of that series like political philosophy [20:13:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153880 (owner: 10Bene) [20:20:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 (owner: 10Bene) [20:47:27] [13WikibaseDataModel] 15Benestar created 06fixhassitelinks (+1 new commit): 02http://git.io/t5SE4Q [20:47:27] 13WikibaseDataModel/06fixhassitelinks 14ec2bc0f 15bene: Fix Item::hasSitelinks method (compat) [20:51:33] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/B6L9dA [20:51:33] 13WikibaseDataModel/06master 14cd0cdc0 15Jeroen De Dauw: Merge pull request #137 from wmde/selfcompare0... [20:53:36] [13WikibaseDataModel] 15Benestar opened pull request #138: Fix Item::hasSitelinks method (compat) (06master...06fixhassitelinks) 02http://git.io/XBICsQ [20:57:18] [travis-ci] wmde/WikibaseDataModel/fixhassitelinks/ec2bc0f : bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/32476889 [20:58:11] JeroenDeDauw: merge!! :D --^ [20:58:32] * benestar 's first contribution to WikibaseDataModel [21:02:09] * Tpt clap benestar [21:02:12] benestar: link? [21:03:40] JeroenDeDauw: https://github.com/wmde/WikibaseDataModel/pull/138 [21:03:57] don't know why github is so slow [21:04:04] We should totally do this in Wikibase https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/490/files [21:04:04] travis has passed as linked above [21:04:08] Kill the evil codes! [21:06:11] benestar: testItemWithoutSitelinksHasNoSitelinks [21:06:14] >_> [21:06:16] :) [21:06:43] benestar: testHasSiteLinksReturnsFalseForEmptyItem [21:06:56] benestar: will merge, name silly though [21:06:59] JeroenDeDauw: that's weird. why does the code quality get worse if we test deprecated functions? [21:07:12] JeroenDeDauw: ups [21:07:39] benestar: where do you see this? [21:07:44] oh [21:07:58] scrutinizer says that [21:08:12] benestar: I guess it does not like how big this test class is getting [21:08:23] Also, this thing holds into account how often something is modified [21:08:37] Bad code that does not get modified is less problematic than bad code that gets modified the whole time [21:08:46] JeroenDeDauw: https://scrutinizer-ci.com/g/wmde/WikibaseDataModel/inspections/b34baa41-4a2a-464f-a725-9cce92c93d00/issues/ [21:08:52] it complains about deprecated code twice [21:09:09] this are the two usages of hasSitelinks which is deprecated but nevertheless should be tested [21:09:19] oh.. [21:09:31] Yeah well, such tools can't get everything right [21:09:49] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/xdHALA [21:09:49] 13WikibaseDataModel/06master 14daf9cbc 15Jeroen De Dauw: Merge pull request #138 from wmde/fixhassitelinks... [21:09:51] benestar: thnx! [21:09:56] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #138: Fix Item::hasSitelinks method (compat) (06master...06fixhassitelinks) 02http://git.io/XBICsQ [21:10:06] you're welcome :) [21:10:25] Lydia_WMDE: that's one code review chocolate to send to benestar [21:10:50] ohnoes! [21:10:53] :P [21:11:32] (03PS3) 10Bene: [DNM] DM 1.0 compat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [21:13:44] hahahaha [21:13:47] this dude [21:13:49] https://github.com/sarciszewski [21:13:51] Check his avatar [21:15:02] JeroenDeDauw: is there a reason why Properties do not yet contain statements on master? [21:15:48] suggestion: delete all classes starting with Entity [21:15:55] * benestar kills EntityView now [21:15:56] no JohnLewis? [21:17:59] JeroenDeDauw: is there already somebody working on refactoring EntityView? [21:18:10] otherwise I will start killing it now *muhaha* [21:21:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153714 (owner: 10Jeroen De Dauw) [21:21:26] legoktm: benestar already killed him? [21:21:27] benestar: find . -name "Entity*.php" -exec rm -rf "{}" [21:21:30] here u go [21:21:33] RIP [21:21:48] benestar is a serial killer [21:22:00] benestar: yeah, please kill EntityView [21:22:03] But be carefull [21:22:08] This needs to happen slowly [21:22:12] I want it to suffer [21:22:19] * lazowik … [21:22:31] JeroenDeDauw: there is a TermBoxView which seems to be unused... [21:22:39] What?! [21:22:45] >>>_>>> [21:22:51] oO [21:22:52] Oo [21:22:55] oOo [21:23:06] Is used [21:23:11] EntityViewPlaceholderExpander [21:23:47] oh, did not see that one [21:23:52] Whenever I see a constructor that needs to put it's parameters each on it's own line I want to hit something [21:24:04] benestar: what editor are you using?> [21:24:19] JeroenDeDauw: netbeans but I have to wash my glasses ;) [21:24:42] maybe cleaning is enough btw ^^ [21:25:27] JeroenDeDauw: might there be cases where an Entity has labels but no descriptions? [21:25:40] or do we want to support such cases? [21:29:46] JeroenDeDauw: where is the interface for entites which have a fingerprint? [21:30:22] benestar: that could happen... it'd not want to put effort into supporting that specifically though. Then again, if we do things right we also do not end up baking in the assumption we won't all over [21:30:57] benestar: why do you need such an interface? Can't you just pass in the EntityId and the Fingerprint? [21:31:12] JeroenDeDauw: well, that's even more intelligent :) [21:34:28] wtf are we checking if the entity id is null`?? [21:34:49] Where? [21:35:04] in EntityView::getHtmlForLabel [21:35:40] can an entity return a null id? [21:35:44] Well, if you have a new entity that does not have an id yet... [21:35:48] It can [21:36:03] do we need to render it then? [21:36:17] That's up to the view [21:36:21] this makes typehinting impossible ... -.- :'( [21:36:24] You might or might not want to do that [21:36:34] How so? [21:36:44] "EntityId $id = null" [21:36:50] You can make any param nullable like that [21:37:40] We might have been better off using the Null Object pattern, not entirely sure though [21:38:44] * JeroenDeDauw goes off to bash some noobs at StarCrafts [21:39:02] JeroenDeDauw: have fun :) [21:39:10] and review my patches tomorrow ;) [21:49:47] benestar: there is a video from your talk? [21:51:12] lazowik: yes, on youtube [21:51:43] got it [22:12:39] (03PS1) 10Bene: Refactor Fingerprint code out of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 [22:13:06] how is it possible to create items without any label? [22:13:07] Q692318 [22:14:23] another example would be: Q7363123 [22:14:58] lbenedix1: at least with the api [22:15:14] gn8 [22:15:18] shoult this items be deleted? [22:16:09] https://www.wikidata.org/w/index.php?title=Q692318&action=history [22:16:12] Wrong merges. [22:16:24] Wrong on the way they're performed. [22:16:31] :P [22:16:53] there are several like this [22:17:40] Just merge again. [22:20:49] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene) [22:21:53] I'm not sure what I have to do to merge two item [22:22:26] I'll create a list of this Items without any Label [22:23:12] should be done by tomorrow morning [22:23:17] * lbenedix1 goes to bed [22:30:33] benestar|cloud: "this would improve the system… really… really…" :D [22:30:55] sorry, I just had to *quote* that :p [23:02:05] lazowik: link to this vid of benestar|cloud ? I feel obliged to do some youtube trolling :) [23:02:22] JeroenDeDauw: https://www.youtube.com/watch?v=LBCw31K5OOc [23:02:37] it's combined with cirrus search talk [23:03:32] Is it me or does http://tools.wmflabs.org/wikidata-todo/random_item_without_instance.php?run=1&wiki=nlwiki not load? [23:04:52] sjoerddebruin: for me too [23:05:07] I think I've done too much work the last days. [23:05:46] heh [23:05:55] looks like the php script got in the loop [23:05:59] or is waiting for api [23:06:29] This also looks false. http://tools.wmflabs.org/wikidata-terminator/?list&lang=nl&mode=t1000&q=claim[31:7889] [23:07:03] (03CR) 10Jeroen De Dauw: [C: 032] Make PropertyContentTest work with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153869 (owner: 10Bene) [23:07:24] (03CR) 10Jeroen De Dauw: [C: 032] Make ItemContentTest work with DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153880 (owner: 10Bene) [23:07:25] And this is freaking annoying. https://www.wikidata.org/w/index.php?title=Q2131340&diff=150708233&oldid=150708219 [23:07:51] (03CR) 10Jeroen De Dauw: [C: 032] Fix EntityHandlerTest with the new serialization format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153844 (owner: 10Bene) [23:08:00] benestar|cloud: thanks a lot for the compat work! [23:08:23] sjoerddebruin: yeah [23:09:47] lazowik: This is the current list with no claims. https://tools.wmflabs.org/multichill/queries/wikidata/noclaims_nlwiki.txt [23:10:03] It should load at some time, the terminator-tool. [23:11:31] (03CR) 10Jeroen De Dauw: [C: 032] Make monolingual-text datatype non-experimental [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153780 (owner: 10Tobias Gritschacher) [23:12:15] (03PS2) 10Jeroen De Dauw: Remove dead line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153703 [23:12:17] (03PS4) 10Jeroen De Dauw: Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153700 [23:12:19] (03PS2) 10Jeroen De Dauw: Improve phpdoc in ChangeHandlerTest and improve class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153699 [23:12:21] (03PS2) 10Jeroen De Dauw: Minor cleanup in SnaksFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153698 [23:12:23] (03PS2) 10Jeroen De Dauw: Fix phpdoc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153697 [23:12:25] (03PS8) 10Jeroen De Dauw: Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153611 [23:15:37] (03CR) 10Jeroen De Dauw: "Looks good. Since you are just moving the code, you can also just move the tests. And doing this here is not absolutely required (though w" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153958 (owner: 10Bene) [23:16:56] lazowik: please to merge https://gerrit.wikimedia.org/r/#/c/153611/ [23:17:16] * lazowik no haz +2 [23:17:27] lazowik: just +1 it then [23:17:34] sure [23:17:38] \o/ [23:24:56] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/LNq1eQ [23:24:56] 13WikibaseInternalSerialization/06master 1477059db 15Jeroen De Dauw: Update .scrutinizer.yml [23:30:37] (03CR) 10Michał Łazowik: [C: 031] Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153611 (owner: 10Jeroen De Dauw) [23:33:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153703 (owner: 10Jeroen De Dauw) [23:34:49] (03CR) 10Michał Łazowik: [C: 031] Remove dead line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153703 (owner: 10Jeroen De Dauw) [23:35:06] JeroenDeDauw: ^ I gave you an extra +1 :p [23:35:10] 'night [23:42:58] (03CR) 10Jeroen De Dauw: [C: 032] Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153611 (owner: 10Jeroen De Dauw) [23:43:05] (03Merged) 10jenkins-bot: Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153611 (owner: 10Jeroen De Dauw) [23:50:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153700 (owner: 10Jeroen De Dauw) [23:59:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/153699 (owner: 10Jeroen De Dauw)