[03:18:07] #wikimedia-incubator [03:35:00] any thing that I can help here? [05:07:53] hi all, is there any thing that I may help? [07:17:12] (03PS6) 10Henning Snater: Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [07:20:35] (03PS3) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [07:25:45] (03PS4) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [07:29:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [07:31:03] (03PS7) 10Henning Snater: Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [07:33:25] (03PS8) 10Henning Snater: Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 [07:41:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [07:42:26] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/kZ9Prg [07:42:26] 13WikibaseDataModel/06master 1469e71d3 15thiemowmde: Merge pull request #131 from wmde/rg... [07:48:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [07:53:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [07:58:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [08:18:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [08:18:31] (03Merged) 10jenkins-bot: Consolidated wikibase.Site [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150855 (owner: 10Henning Snater) [08:20:03] (03PS5) 10Henning Snater: Implemented pagesuggester widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 [08:27:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151097 (owner: 10Henning Snater) [08:29:24] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Test succeeds. Obviously not needed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151511 (owner: 10Jeroen De Dauw) [08:29:33] (03Merged) 10jenkins-bot: Remove not needed ref to deprecated global [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151511 (owner: 10Jeroen De Dauw) [08:30:26] (03PS2) 10Daniel Kinzler: Add simple logging to MockRepository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151144 [08:31:39] (03PS2) 10Daniel Kinzler: Better handing for redirects in MockRepositors. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 [08:35:54] Thiemo_WMDE: if you have a little time, it would be great to have the two changes above merged ---^ The conflict somewhat with another change I want to do in preparation for the refactoring of the MergeItems module. [08:41:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151144 (owner: 10Daniel Kinzler) [08:43:56] (03CR) 10Daniel Kinzler: "I find the different status values increasingly confusing. There can only be one status value, but we are making statements about differen" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [08:46:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151149 (owner: 10Daniel Kinzler) [08:52:23] (03PS4) 10Thiemo Mättig (WMDE): Optional lang fallback chain in EntityRevisionSerializer::newForFrontendStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89102 (owner: 10Daniel Werner) [09:00:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89102 (owner: 10Daniel Werner) [09:06:31] (03PS1) 10Thiemo Mättig (WMDE): Cleanup Entity Serializer code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151596 [09:14:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151596 (owner: 10Thiemo Mättig (WMDE)) [09:17:38] [13WikibaseDataModel] 15thiemowmde created 06selfcompare (+1 new commit): 02http://git.io/tTqb5g [09:17:38] 13WikibaseDataModel/06selfcompare 1446b5967 15Thiemo Mättig: Remove self-comparisons from tests [09:17:58] [13WikibaseDataModel] 15thiemowmde opened pull request #132: Remove self-comparisons from tests (06master...06selfcompare) 02http://git.io/n_u0zA [09:20:30] [travis-ci] wmde/WikibaseDataModel/selfcompare/46b5967 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/31600082 [09:40:50] (03PS3) 10Daniel Kinzler: Add simple logging to MockRepository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151144 [09:40:52] (03PS1) 10Daniel Kinzler: Introducing ApiHelperFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 [09:48:53] DanielK_WMDE: Thiemo_WMDE: Henning_WMDE: I still need a few minutes.. feel free to start the daily w/o me [09:50:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151144 (owner: 10Daniel Kinzler) [09:55:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151598 (owner: 10Daniel Kinzler) [10:00:35] (03PS1) 10WikidataBuilder: New Wikidata Build - 04/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151601 [10:05:10] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 04/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151601 (owner: 10WikidataBuilder) [10:10:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151601 (owner: 10WikidataBuilder) [10:20:37] DanielK_WMDE: when will you arrive tomorrow? [10:23:28] :O Lydia_WMDE your already in london? :P [10:23:36] addshore: yeah [10:24:33] (03Abandoned) 10Addshore: New Wikidata Build - 03/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151399 (owner: 10WikidataBuilder) [10:46:14] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06selfcompare from 1446b5967 to 1456de976: 02http://git.io/44x_TA [10:46:14] 13WikibaseDataModel/06selfcompare 1456de976 15Thiemo Mättig: Remove self-comparisons from tests [10:48:52] Lydia_WMDE: 13:25 in Heathrow. Also wohl irgendwann gegen 16:00 im Hotel. [10:49:10] What hotel are you guys in? [10:49:54] DanielK_WMDE: hmmm ok mist. das meeting mit fabrice ist 14 bis 16 uhr angesetzt. da müssen wir uns später nochmal mit ihm zusammensetzen und ich mach das morgen [10:50:11] addshore: currently in another hotel but moving tho thistle tomorrow [10:51:04] Thiemo_WMDE: are you on the same flight as daniel? [10:51:18] Lydia_WMDE: oh, sorry, das hätte mir früher auffallen müssen. ich war mir sicher, dass das treffen mit fabrice erst am mittwoch ist :/ [10:51:33] Thiemo_WMDE ist im selben fleiger, ja [10:51:41] äh, flieger [10:51:57] DanielK_WMDE: joa. bekommen wir irgendwie hin. mittwoch ist glaube ich die public discussion [10:52:01] Thistle City Barbican Hotel ? :) [10:53:20] My hotel is around 10 mins from you :) I am closer to the barbican than you ;p [10:55:51] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06selfcompare from 1456de976 to 145552b23: 02http://git.io/44x_TA [10:55:51] 13WikibaseDataModel/06selfcompare 145552b23 15Thiemo Mättig: Test if getHash is static [10:56:27] addshore: :D [10:56:28] yes [10:56:47] well right now i am in shepheard's bush on the other side of the city [10:56:55] so i am sure you are definitely closer ;-) [10:57:00] at least until tomorrow [10:58:18] [travis-ci] wmde/WikibaseDataModel/selfcompare/5552b23 : Thiemo Mättig The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/31605909 [10:58:41] addshore: don't show off, my place is 1min off the barbican :-P [11:01:22] :P [11:02:33] I will be around tomorrow evening! If anyone fancies getting together for dinner let me know :P [11:02:56] hello, I have an error when I try to undohttps://www.wikidata.org/w/index.php?title=Q3654788&diff=149457281&oldid=147301489 and I don't understand why (wrong merging) [11:08:05] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06selfcompare from 145552b23 to 14c3c53db: 02http://git.io/44x_TA [11:08:05] 13WikibaseDataModel/06selfcompare 14c3c53db 15Thiemo Mättig: Test if getHash is static [11:10:35] [travis-ci] wmde/WikibaseDataModel/selfcompare/c3c53db : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/31606596 [11:14:26] Harmonia_Amanda: when you merge, two edits are made, you have to undo the edit on Q2700478 first [11:15:03] addshore: ok, I tought it was the reverse, thanks I'll try [11:50:12] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #132 14c3c53db: NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO! 02http://git.io/ZVcTHQ [11:53:21] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #132 14c3c53db: All code in PropertyNoValueSnak is already covered by a test that does not follow this dubious inheritance approach. 02http://git.io/S2lfGw [11:53:31] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #132 14c3c53db: Same here 02http://git.io/5cwenQ [11:58:03] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #132 14c3c53db: Doing this here and having it overridden for the test cases of which it is different is really not nice. This is code sharing via inheritance which suggests the production code to do the same. It also makes the test a lot less readable. 02http://git.io/xURHag [12:02:50] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #132 14c3c53db: This test illustrates why using `serialize` on the object is bad for the hash. The class name is part of the input.... 02http://git.io/Bggj6w [12:04:00] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/MBPVBg [12:04:00] 13WikibaseDataModel/06master 14e92fe92 15Jeroen De Dauw: Update RELEASE-NOTES.md [12:41:49] [13WikibaseDataModel] 15thiemowmde comment on pull request #132 14c3c53db: The production code _does_ the same. 02http://git.io/SDWPTw [12:42:14] (03PS2) 10Tobias Gritschacher: New Wikidata Build - 04/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151601 (owner: 10WikidataBuilder) [12:44:39] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 04/08/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151601 (owner: 10WikidataBuilder) [12:45:35] [13WikibaseDataModel] 15thiemowmde comment on pull request #132 14c3c53db: This is an other test. It makes sure all tests in `SnakObjectTest` still succeed with an other class. 02http://git.io/jSn9EA [12:49:03] [13WikibaseDataModel] 15thiemowmde comment on pull request #132 14c3c53db: The original idea was to replace all `serialize()` function calls with code like this. Then I realized this is pretty much pointless because of the way `serialize()` just calls the `...->serialize()` methods.... 02http://git.io/lStpvg [12:53:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/151601 (owner: 10WikidataBuilder) [13:03:18] [13WikibaseDataModel] 15thiemowmde created 06bestclaims (+1 new commit): 02http://git.io/25yjUA [13:03:18] 13WikibaseDataModel/06bestclaims 14d25a30a 15Thiemo Mättig: Rename ClaimList::getBestClaims [13:03:41] [13WikibaseDataModel] 15thiemowmde opened pull request #133: Rename ClaimList::getBestClaims (06master...06bestclaims) 02http://git.io/QgXe-Q [13:04:31] [13WikibaseDataModelSerialization] 15thiemowmde closed pull request #75: Do not use deprecated global var (06master...06ng) 02http://git.io/D-Ff-A [13:06:52] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #133 14d25a30a: Wrong class name 02http://git.io/rgra_Q [13:07:12] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #133 14d25a30a: no longer returns a 02http://git.io/6v39Tg [13:07:15] Thiemo_WMDE: hah, good catch of that doc fail [13:07:25] I've looked at the file a dozen times since and never saw that [13:08:41] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06bestclaims: 02http://git.io/c1pciA [13:08:41] 13WikibaseDataModel/06bestclaims 143c10c4f 15thiemowmde: Update RELEASE-NOTES.md [13:16:59] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #132 14c3c53db: I'd be pretty clear what the test is doing. You'd not be able to derive the hashing algorithm from it, though since this is a thing relevant to the model in general, I think it's much better to have this properly documented then to simply mirror the implementation in the test. People creating tools around Wikibase, such as WDTK, might well want to know how to compute the ha [13:41:22] [13WikibaseDataModel] 15thiemowmde comment on pull request #132 14c3c53db: I would like to replace the getHash implementations with this code _but_ make it return the old 0.x hashes. Then the tests can be simplified to simple string comparisons. Are you find with this approach? 02http://git.io/jGp1cA [13:51:22] (03CR) 10Thiemo Mättig (WMDE): "I expected this to appear in two places, Repo and Client. What's the third?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151516 (owner: 10Jeroen De Dauw) [14:01:00] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/8Ul3KA [14:01:00] 13jenkins-job-builder-config/06master 14040455e 15Tobias Gritschacher: Adjust jenkins-browsertest-jobs after moving files... [14:02:36] [13ValueView] 15thiemowmde created 06scrolltop (+1 new commit): 02http://git.io/Ujj7Hg [14:02:36] 13ValueView/06scrolltop 1473e8ae1 15Thiemo Mättig: Scroll ooMenu to top on refresh [14:04:40] [13ValueView] 15thiemowmde opened pull request #101: Scroll ooMenu to top on refresh (06master...06scrolltop) 02http://git.io/UJHJtg [14:10:51] (03PS3) 10Daniel Kinzler: Introducing MergeItemsInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) [14:16:02] Tobi_WMDE_SWE: can you updated the board? 68730 -> review [14:16:35] DanielK_WMDE: yup [14:18:20] [travis-ci] wmde/WikibaseDataModel/bestclaims/d25a30a : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/31614270 [14:18:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151145 (https://bugzilla.wikimedia.org/68730) (owner: 10Daniel Kinzler) [14:20:05] Tobi_WMDE_SWE: Thanks! Bug 69106 follows. Perhaps tag it for the next sprint. [14:20:22] I may poke at it in case I get bored at wikim#ania ;) [14:20:44] * DanielK_WMDE pokes Thiemo_WMDE [14:37:43] [travis-ci] wmde/WikibaseDataModelSerialization/master/225b3de : thiemowmde The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/31614364 [15:32:50] [travis-ci] wmde/WikibaseDataModel/bestclaims/3c10c4f : thiemowmde The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/31614685 [15:36:33] (03PS1) 10Lucie Kaffee: [wip] ApiConventionsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 [15:44:08] (03CR) 10Jeroen De Dauw: [wip] ApiConventionsTest (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (owner: 10Lucie Kaffee) [15:44:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151659 (owner: 10Lucie Kaffee) [16:23:52] [13ValueView] 15thiemowmde created 06langcode (+1 new commit): 02http://git.io/VrgMyQ [16:23:52] 13ValueView/06langcode 14a578e87 15Thiemo Mättig: Allow typing language codes [16:24:42] [13ValueView] 15thiemowmde opened pull request #102: Allow typing language codes (06master...06langcode) 02http://git.io/d7E0CQ [17:21:27] (03CR) 10Thiemo Mättig (WMDE): "I agree, it would be better to use different flags for the different facts. But please keep in mind that you started introducing the first" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129407 (owner: 10Thiemo Mättig (WMDE)) [18:42:53] GerardM-: Ha, ik zag dat je de Zweedse eilandjes hebt ontdekt. [19:08:24] sjoerddebruin: [19:08:29] ze zijn leuk [19:08:49] Maar volgens mij hebben ze nog niet allemaal de minimale properties... [19:09:07] en ze staat nu ook als eiland in Wikidata en als onderdeel van een eilandengroep [19:09:15] Ah, mooi. :) [19:10:02] voordeel is dat ze ook coördinaten hebben, dat hebben al die Indonesische dorpjes niet. [19:11:36] ik heb er een binnengehaald ... werkte niet direct [19:13:00] Michiel1972 even vragen, die heeft er wel ervaring mee dacht ik. [19:44:03] sjoerddebruin als je op de link klinkt, dan krijg je diverse formaten.. de goede zit er tussen [19:45:51] GerardM-: for reference there is a post aboout at WD:AN. I think it'll be best that you respond. [19:46:10] what is WD:AN ? [19:46:32] and I am pressed for time ... about to go to bed and travelling [19:46:56] Administrators' Noticeboard [20:07:08] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/151763 (owner: 10L10n-bot) [20:21:02] hey :) [20:24:22] hihohey [20:24:34] hohoho [20:24:53] No, it's not christmas yet. [20:25:23] but it will be soon [20:25:26] on 19th! [20:25:34] (at least for Wikidata) [20:27:55] :p [20:31:41] lazowik: I want to put that in the topic but know I shouldn't :p [20:31:51] hah [20:32:02] ask JeroenDeDauw if you should [20:33:39] lazowik: never! Lydia_WMDE approves everything :p [20:33:56] oh, well, then ask her [20:34:23] s/Wikinews Phase 1: August 19th/Wikidata's Christmas: August 19th/ [20:34:31] didn't work :(