[08:44:32] (03PS1) 10Thiemo Mättig (WMDE): Fix mistakes and general cleanup in Wikibase\Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 [08:53:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 (owner: 10Thiemo Mättig (WMDE)) [09:16:51] The cache is really hard, still can't add pages or categories on Commons. [09:29:56] (03PS1) 10Thiemo Mättig (WMDE): Cleanup Lib Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150500 [09:35:32] (03PS2) 10Thiemo Mättig (WMDE): Fix mistakes and general cleanup in Wikibase\Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 [09:42:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150500 (owner: 10Thiemo Mättig (WMDE)) [09:43:58] hey :) [09:48:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 (owner: 10Thiemo Mättig (WMDE)) [09:53:34] (03PS8) 10Thiemo Mättig (WMDE): Use deep cloning in ChangeOpLabel/Description/Aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 [09:54:42] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I'm pretty happy with this change now. It still (mis)uses serialization but in a very specific case only where it makes sense." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [09:57:11] Lydia_WMDE: here? [10:00:32] (03PS1) 10WikidataBuilder: New Wikidata Build - 30/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/150507 [10:03:50] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 30/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/150507 (owner: 10WikidataBuilder) [10:06:27] hoo: she was but currently isn't I think [10:06:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [10:06:48] lunch time atm [10:13:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/150507 (owner: 10WikidataBuilder) [10:16:00] hoo: hey [10:16:54] Lydia_WMDE: Extension:RelatedSites ... do you know that one? [10:17:01] yeah [10:17:04] (not sure it's written exactly that way) [10:17:06] ok [10:18:18] How do we plan to work with that and other projects link on 'voyage? [10:18:39] If I understand that extension correctly it can also (and does?) link sites not hsoted by WMF [10:21:03] Lydia_WMDE: ^ [10:21:32] hoo: for now we just don't enable it on wikivoyage [10:21:52] ok, that's a word :) [10:22:06] Because they want to disable related sites in favour of our thing [10:22:21] yeah we can do that in the future [10:22:29] i think tpt even took that into account [10:22:36] it's probably best to chat with him quickly [10:22:40] but they probably don't know it's not exactly feature equivalent [10:22:42] at wikimania [10:22:45] yeah [10:26:09] Lydia_WMDE: mh... https://ru.wikipedia.org/wiki/%D0%91%D0%B5%D1%80%D0%BB%D0%B8%D0%BD [10:26:18] looking [10:26:24] the related sites should not be above the "toolbox" [10:27:02] hoo: agreed [10:27:56] not sure we can influence the actual position... because locally the thing was below the languages for me AFAIR [10:29:05] Hi. There. I have a request from a bot and have spent 7 days [10:29:20] 12https://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Bot/Miguillen-bot [10:31:04] Lydia_WMDE: Can you open a bug and CC Katie, please? [10:31:07] and tpt [10:31:11] (03CR) 10Daniel Kinzler: [C: 032] Use deep cloning in ChangeOpLabel/Description/Aliases (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [10:31:18] hoo: for the position? [10:31:22] I must ask the bot flag in bureaucrats noticeboards? [10:31:31] having a short look at the code, I'm not sure we can fix that easily :S [10:31:34] yes [10:32:40] Miguillen: did you see https://www.wikidata.org/wiki/Wikidata:Bots ? [10:32:42] hoo: ok [10:34:06] Lydia_WMDE Yes I do. The request was made following the steps on that page [10:34:36] Miguillen: ok then i guess a note on the bureaucrat noticeboard is a good next step [10:35:17] Lydia_WMDE ok thanks [10:35:39] (03PS1) 10Thiemo Mättig (WMDE): wgTitle can be null in rare edge cases, e.g. in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150512 (https://bugzilla.wikimedia.org/68697) [10:35:57] oh yes, it can... *sigh* [10:36:34] speaking English makes me lose some [10:38:04] anyone got time to figure out if https://www.wikidata.org/wiki/Q2109702 and https://www.wikidata.org/wiki/Q1426477 should be merged? [10:40:08] I’ll look, be a change for beating my head against a helpee. :P [10:40:26] *from* [10:43:08] Lydia_WMDE: Yeah, they are about the same thing. [10:43:27] revent: :D wanna merge? [10:43:34] and thanks for looking [10:44:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150512 (https://bugzilla.wikimedia.org/68697) (owner: 10Thiemo Mättig (WMDE)) [10:44:42] Merging now, and no problem. [10:45:41] https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Q2109702 [10:45:48] \o/ [10:46:32] (03PS1) 10Thiemo Mättig (WMDE): Cleanup concept (canonical) URL hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150517 [10:47:59] *poof* [10:48:56] !cookie sjoerddebruin [10:49:07] weeeeeeeeeeeeeeee [10:49:13] * Lydia_WMDE looks at the smoke [10:49:48] Going to bomb some more. ;) [10:50:28] revent: nooo, !nyan sjoerddebruin [10:50:35] !nyan sjoerddebruin [10:50:35] ~=[,,_,,]:3 [10:50:43] hmm [10:50:48] !nyan | sjoerddebruin [10:50:48] sjoerddebruin: ~=[,,_,,]:3 [10:50:50] HA [10:51:14] lazowik: Yeah, command for a different bot. :P [10:55:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150517 (owner: 10Thiemo Mättig (WMDE)) [10:59:55] Lydia_WMDE Reading the page: 12https://www.wikidata.org/wiki/Wikidata:Bots I think I made a mistake in the procedure because although I made 192 test edits (call between 50 and 250) only 4 editions have been made after the request [11:02:48] 12https://www.wikidata.org/wiki/Special:Contributions/Miguillen-bot [11:07:30] hmm [11:07:35] should https://www.wikidata.org/wiki/Q4759469 be split? [11:07:54] it mixes Android software development with Android SDK [12:20:12] (03CR) 10Daniel Kinzler: [C: 032] Use real cloning in ChangeOpAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150308 (owner: 10Thiemo Mättig (WMDE)) [12:20:24] (03Merged) 10jenkins-bot: Use real cloning in ChangeOpAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150308 (owner: 10Thiemo Mättig (WMDE)) [12:20:26] (03Merged) 10jenkins-bot: Use deep cloning in ChangeOpLabel/Description/Aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/133523 (owner: 10Thiemo Mättig (WMDE)) [12:22:01] (03CR) 10Daniel Kinzler: [C: 032] Find better name for DataUpdateClosure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [12:22:09] (03Merged) 10jenkins-bot: Find better name for DataUpdateClosure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [12:25:22] (03CR) 10Daniel Kinzler: [C: 031] "looks good, but needs manual poking to make sure" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150026 (owner: 10Bene) [12:52:26] (03CR) 10Daniel Kinzler: "The only think i'd like to see improved before merging is the name..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [12:53:20] I just stumbled across a claim without any references attached and I think that claim is wrong. The user who created it was blocked indefinitely on WikiData. How should I handle that? [12:53:29] Should I just go forward and delete the claim? [12:53:43] To be precise this is about twin cities of Berlin. [12:54:15] As far as I know Vaduz is not an official twin city of Berlin but WikiData has a different "opinion": https://www.wikidata.org/wiki/Q1844 [12:54:32] well, the city of Berlin has an official list: http://www.berlin.de/rbmskzl/internationales/staedtepartnerschaften/ [12:55:04] here's the change: https://www.wikidata.org/w/index.php?title=Q1844&diff=prev&oldid=9546395 [12:55:31] scfe: delete it, then. if there is a sources that states that Verduz *is* a twin city, even though the official source disagrees, in that case keep the claim but set it to "deprecated", so it won't be added back. [12:55:54] (the deprecated claim should also be sourced, though. no reason to kepp wrong stuff if there is no soruce for it) [12:56:00] (03PS1) 10Thiemo Mättig (WMDE): Reduce GUI jumping around when clicking edit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150539 [12:58:52] DanielK_WMDE__: ok, will do. [13:05:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150539 (owner: 10Thiemo Mättig (WMDE)) [13:12:12] Lydia_WMDE: guided tours are now translatable \o/ [13:32:48] Lydia_WMDE: I also added a notice at the beginning of the tour if it isn't available in the user's current language [13:41:22] (03CR) 10Jeroen De Dauw: [C: 032] "\o/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150500 (owner: 10Thiemo Mättig (WMDE)) [13:41:33] (03PS2) 10Jeroen De Dauw: DM 1.0 compat: Another attempt to clean up testCanApply [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149498 [13:45:24] (03CR) 10Jeroen De Dauw: [C: 032] Add order test to DataModelSerializationRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150284 (owner: 10Thiemo Mättig (WMDE)) [13:45:44] (03CR) 10Jeroen De Dauw: [C: 032] Replace Aliases in WikibaseRepo class map [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150376 (owner: 10Thiemo Mättig (WMDE)) [13:50:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149498 (owner: 10Jeroen De Dauw) [14:01:11] I don't have time to do it on-wiki but my RfC is hereby extended 1 week [14:01:24] recording here so everyone knows my consent was given [14:06:04] (03PS3) 10Jeroen De Dauw: DM 1.0 compat: Another attempt to clean up testCanApply [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149498 [14:15:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149498 (owner: 10Jeroen De Dauw) [14:17:53] (03CR) 10Jeroen De Dauw: Simpified MonthNameUnlocalizer (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 (owner: 10Daniel Kinzler) [14:24:51] (03CR) 10Jeroen De Dauw: [C: 032] wgTitle can be null in rare edge cases, e.g. in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150512 (https://bugzilla.wikimedia.org/68697) (owner: 10Thiemo Mättig (WMDE)) [14:25:08] (03PS3) 10Jeroen De Dauw: Fix mistakes and general cleanup in Wikibase\Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 (owner: 10Thiemo Mättig (WMDE)) [14:32:26] (03PS3) 10Nemo bis: Simplified MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 (owner: 10Daniel Kinzler) [14:32:32] (03CR) 10jenkins-bot: [V: 04-1] Simplified MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 (owner: 10Daniel Kinzler) [14:37:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 (owner: 10Thiemo Mättig (WMDE)) [14:43:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 (owner: 10Daniel Kinzler) [14:49:26] Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/149183/ [14:50:08] benestar|afk: yay :) [14:53:53] (03CR) 10Alex Monk: [C: 032] Cleanup concept (canonical) URL hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150517 (owner: 10Thiemo Mättig (WMDE)) [14:54:04] (03Merged) 10jenkins-bot: Cleanup concept (canonical) URL hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150517 (owner: 10Thiemo Mättig (WMDE)) [15:05:51] (03PS1) 10Thiemo Mättig (WMDE): Do not double escape HTML in form label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150558 (https://bugzilla.wikimedia.org/68221) [15:15:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150558 (https://bugzilla.wikimedia.org/68221) (owner: 10Thiemo Mättig (WMDE)) [15:15:53] http://wikidata.beta.wmflabs.org/wiki/Q11 :S [15:15:59] Simple items work, btw [15:16:08] it's an addshore! [15:16:41] hoo: ohnoes! https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Unable_to_add_links_to_Commons [15:17:04] wait... still? [15:17:48] We only had that broken for ~20 minutes ... [15:18:22] mh, it's broken for me again also [15:18:23] wtf [15:18:32] :/ [15:21:31] oh hi lazowik ! [15:21:48] !log hoo Synchronized php-1.24wmf15/extensions/Wikidata/extensions/Wikibase/lib/resources/wikibase.js: touch (duration: 00m 20s) [15:21:52] hope that fixes it [15:22:34] \o/ [15:22:56] hoo: will post on wiki [15:23:04] give it a few minutes first [15:23:08] k [15:23:34] hoo: with a purge of the page it is fine [15:25:45] that's an unrelated side effect of the purging [15:25:59] (03PS1) 10Daniel Kinzler: EntityIdLabelFormatter ignores StorageExceptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) [15:27:26] - unrelated [15:27:43] but still a side effect [15:28:11] Thiemo_WMDE: ---^ [15:28:22] final (?) blocker for redirects [15:29:25] DanielK_WMDE__: Shouldn't it log the StorageExceptions? [15:32:54] everyone is going to be at Wikimania right? :) [15:33:19] Like all living human beings? No [15:33:32] but the team, yeah [15:34:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [15:37:37] hoo: maybe, but definitly not of it's an UnresolvedRedirectException [15:37:44] sure [15:37:44] ....which is the current use case. [15:38:06] hoo: it could log other storage exceptions. i thought about it, and then left it out for simplicity [15:38:16] if you think it should log, i'll add that [15:38:18] I wonder about your test case: Why do you put a redirect? [15:38:32] Yes, if something really awry goes on, please log that [15:38:55] oh right, because the entity wouldn't even exist otherwise [15:39:14] yes. [15:41:43] (03PS2) 10Daniel Kinzler: EntityIdLabelFormatter ignores StorageExceptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) [15:41:47] hoo: --^ [15:45:40] Lydia_WMDE: In private browsing mode it *mostly* works for me now [15:45:52] hoo: ok cool [15:45:57] thx for fixing [15:46:02] but not all the time [15:46:04] ok [15:47:05] ok... now it looks mostly broken again [15:47:06] :S [15:49:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [15:52:18] Lydia_WMDE: Doh, now I see the problem [15:52:31] (why the cache is acting so weird) [15:52:35] ah? [15:52:36] why? [15:52:49] all the touching doesn't really touch [15:52:55] we don't have any way to purge that atm [15:53:10] because it's not a real JS file, but something created by PHP on runtime [15:59:28] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I would like to give the team a little time to have a look. Maybe somebody does have a better idea?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [16:15:00] (03CR) 10Jeroen De Dauw: [C: 032] Fix mistakes and general cleanup in Wikibase\Validators [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150493 (owner: 10Thiemo Mättig (WMDE)) [16:25:34] (03PS1) 10Daniel Kinzler: Introduce item-redirect permission. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150571 (https://bugzilla.wikimedia.org/68454) [16:33:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150571 (https://bugzilla.wikimedia.org/68454) (owner: 10Daniel Kinzler) [16:36:14] hoo: gimme some review? [16:36:49] (03CR) 10Jeroen De Dauw: [C: 032] Do not double escape HTML in form label [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150558 (https://bugzilla.wikimedia.org/68221) (owner: 10Thiemo Mättig (WMDE)) [16:40:16] (03CR) 10Jeroen De Dauw: "Not happy this thing is aware of "storage", though that issue seems to reside elsewhere." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [16:42:37] (03CR) 10Jeroen De Dauw: [C: 032] Introduce item-redirect permission. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150571 (https://bugzilla.wikimedia.org/68454) (owner: 10Daniel Kinzler) [16:45:10] (03CR) 10Daniel Kinzler: "@Jeroen: yes, this would be much nicer with a decent interface for looking up labels, see I1ae41118dc." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [17:07:44] Lydia_WMDE: I've investigated a bit... we *can* probably make caching of the sites smarter [17:07:58] that wont help now, but might in the future [17:08:09] hoo: yay [17:08:25] it's rather trivial actually... will do it later on [17:08:37] Krinkle: ping [17:08:40] nice [17:15:52] (03CR) 10Hoo man: [C: 032] "Test relies on MockRepository not resolving redirects, but that's not really an issue IMO." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [17:16:01] (03Merged) 10jenkins-bot: EntityIdLabelFormatter ignores StorageExceptions. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150563 (https://bugzilla.wikimedia.org/68852) (owner: 10Daniel Kinzler) [17:31:38] Lydia_WMDE: I'm a bit confused atm. When will we get the icons for badges and who is supposed to create them? [17:32:06] benestar: thiemo wanted to iirc [17:32:19] Thiemo_WMDE: --^ [17:32:56] Thiemo_WMDE: have you already created the icons or until when do you plan to do so? [17:33:22] Lydia_WMDE: if he doesn't reply, may you poke him tomorrow on that topic? [17:33:40] he's nto at his desk, but i think he's still in the office [17:34:05] *goes to work on his wikibase lib to avoid doing real work* [17:34:57] DanielK_WMDE__: can you think of a better way to get a "state" hash of the Sites then to just get them all and hash that? [17:35:07] hash to verify whether they changed [17:35:24] needs to be fast, as it's going to be called a lot [17:36:19] hoo: cache the hash after you computed it once? [17:36:30] for 5 minutes or so? [17:36:32] coudl even be made persistent, but i don't like that [17:36:59] hoo: i was thinking inside the object... but you want this to be fast across multiple requests? [17:37:11] in that case, memcached, yea. [17:37:20] DanielK_WMDE__: Ok... will hack that up [17:37:22] though accessing memcached does have some overhead. [17:37:35] I think we might want to even deploy that today [17:37:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [17:37:54] hoo: what's the problem? [17:37:56] Lydia_WMDE: Do people still struggle with commons? [17:38:18] DanielK_WMDE__: We need to invalidate the cache of the sites in JavaScript, if either configuration changes or the sites table does. [17:38:47] hoo: oh wait, you are talking about the global list of sites, not sitelinks of a specific item! [17:38:57] yep [17:39:06] hoo: didn't see anything no [17:39:10] the list of sites is in memcached [17:39:26] Ok, and it's not insanely slow to get it? [17:39:27] benestar: yes :) [17:39:33] the structure that is cached could include some meta-data, like a hash [17:39:59] hoo: it's ok to get it once, when editing or re-rendering [17:40:10] should nt be doen on every page view, especially not multiple times [17:40:44] hoo: but you could just cache the hash under a separate key, in parallel with the actual data [17:41:02] > $a = microtime( true ); SiteSQLStore::newInstance()->getSites(); echo microtime( true ) - $a; [17:41:02] 0.045659065246582 [17:41:08] that's what I thought about [17:41:30] this is going to be hit a lot... on every page view I think. On every item view, at least. [17:41:33] yes, that's probably best [17:41:47] Ok, 5 minutes? [17:42:44] no. as long as the actual data (1 day, i think). just update it when re-caching the data [17:43:12] DanielK_WMDE__: That's not easily possible... how should my stuff know when the sites are going to get recached? [17:43:43] so you want to hit the database every five minutes and check? [17:43:56] no, hit memcached for the sites [17:44:01] then you can just as well reduce the cache duration for the data itself [17:44:03] thos expire after 1h [17:44:14] i'm confused now. [17:44:31] the memcached sites list expires after 1 hour. [17:44:34] the Sites are cached for 1h (as a big blob) [17:44:46] you want to check the hash of that how often? and compare it to what? [17:45:01] I want to check it every 5 minutes... but could also be more [17:45:30] the actual comparison gets done by RL, I just give it a hash to invalidate the cache [17:45:40] the cached blob could include a hash (or version number or timestamp) [17:45:48] but what do you want to check that against? [17:46:01] DanielK_WMDE__: Then I would still need to get that big blob, which defies the purpose (mostly) [17:46:13] DanielK_WMDE__: It's like a cache key [17:46:15] you can have it in a separate key [17:46:39] but then why expire that more frequently than the data itself? it's bound to the blob. it applied to the blob. it's valid as long as the blob doesn't change [17:47:05] i still do not understand what you want to check it against [17:47:05] because we might manually purge the blob when adding new sites [17:47:19] rather seldom event, though [17:47:25] i'm still confused [17:47:45] can you explain step by step how you imagine this would work? [17:48:45] I have a function which gets all sites and then builds a hash from that. [17:48:52] gets all sites from where [17:49:01] From memcached or whatever... like I care [17:49:17] oh, the function *takes* a list of sites and builds a hash. ok [17:49:51] or wait, I'll just upload a WIP patch [17:51:19] hoo: there is a php function you can call to force the sites cache to be updated [17:51:27] if we do manual purging, we can just as well use that, no? [17:52:06] Sites::singleton()->reset() [17:52:19] will purge local cache and memcacehd [17:52:30] DanielK_WMDE__: yep [17:52:38] that's what we run after updating it [17:52:41] but the issue is the JS [17:52:44] wait for my path [17:53:22] hoo: oh, i think i know what you are trying to do. but then i still don't understand the 5 minute timeout [17:53:40] if you cache the hash, cache it as long as the actual blob [17:53:54] ok [17:54:09] https://www.wikidata.org/wiki/Q2844750 why can't I add a link to Commons here? [17:54:19] https://commons.wikimedia.org/wiki/Category:Am%C3%A9lie_Di%C3%A9terle [17:54:39] yannf: Caching issues [17:54:46] Lydia_WMDE: Maybe backport tonight? [17:54:49] Swat [17:54:50] ah [17:55:13] hoo: yeah i fear it's needed [18:01:00] It's annoying. -_- [18:07:28] (03PS1) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 [18:10:29] (03PS2) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 [18:10:37] DanielK_WMDE__: https://gerrit.wikimedia.org/r/#/c/150597/1 [18:10:41] can we get this merged today? [18:11:04] I've tested it and it works for me [18:11:13] and changes when I change the configuration [18:13:11] hoo: use sha1, not md5. there's no reason to use md5, sha1 is not only more secure, it's also faster [18:14:32] hoo: sorry, i know too little about how resource modules work to merge this [18:15:30] hoo: designwise, it would be much nicer if SiteSQLStore did the hashing and caching, so that is always consistent. [18:18:11] RL uses md5 all over the place, but there's not really a reason to be compatible here [18:18:22] of course it would be nicer, but well... [18:18:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [18:19:13] (03PS3) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 [18:19:35] DanielK_WMDE__: Would you merge it, if Krinkle or someone signed of on the RL part of this? [18:24:08] * DanielK_WMDE__ is scared [18:24:23] maybe they would merge it if i gave a ~1 :) [18:24:41] oh, btw sha1 is not faster than md5... at least on my machine (openssl speed) [18:24:48] but also not much slower [18:25:15] DanielK_WMDE__: Ok, can you do that, then? :) [18:28:48] hoo: i can't find anything about getHashMTime. [18:28:57] where does it come from? where is it called? [18:29:08] the only mention i find is in a comment [18:29:14] DanielK_WMDE__: It's in ResourceLoaderModule [18:29:40] * Helper method for calculating when the module's hash (if it has one) changed. [18:29:53] oh, lower case t. [18:29:56] Mtime [18:29:57] bah [18:32:32] hoo: ok, now i understand why you said five minutes. this is all a bit...complicated :) [18:32:39] but 5 minutes would probably be better than an hour. [18:32:40] sorry [18:33:16] this is realyl hacky. it uses memcached to check whether the hash changed, but we cache the hash, so it stays the same for a while... eeek. [18:35:42] (03PS4) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 [18:35:48] Yeah... performance... [18:35:58] Updated to cache for 5 min and added a comment about that [18:36:43] hoo: i wonder about the way the has is constructed [18:36:51] (see comment) [18:37:25] no comment there [18:37:56] and it would really be good to have a comment explaining what happens here (hash is calculated, compared to a hash from the cache, and if it's different, the resource is considered modified; but for performance reasons, we cache the hash ourselves for a while. so it's a doubly cached hash) [18:38:05] (03CR) 10Daniel Kinzler: Enable SitesModule cache invalidation (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [18:38:09] hoo: ---^ [18:38:30] i hate it when a new version is added while i'm commenting. easy to hit the wrong review button [18:38:44] sha1( json_encode( $sites ) ) [18:38:54] results in: {"0":{},"1":{},"2":{},"3":{},"4":{},"5":{},"6":{ [18:39:01] that was the first thing I wanted to do [18:39:23] JSON_FORCE_OBJECT [18:39:25] mh [18:40:02] oh no, that forces the json to have objects [18:40:26] hoo: yea, you want the hash of the raw data [18:40:34] one more reason to implement this in SiteSQLStore [18:41:35] yeah :P [18:41:41] But that's not an option immediately [18:41:53] $site = (array) $site; [18:41:54] that works [18:43:31] (03CR) 10Hoo man: Enable SitesModule cache invalidation (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [18:43:59] (03PS5) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 [18:48:00] (03CR) 10Daniel Kinzler: [C: 031] "From what I understand, this allows the mtime for the resource module containing the site list to be determined based on the hash of the s" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [18:48:34] DanielK_WMDE__: Thanks :) [18:55:44] Lydia_WMDE: Ok, scheduled for SWAT [18:55:54] hope I get somebody to approve it in time [18:55:54] hoo: awesome. thanks [18:58:09] legoktm: Would be *great* if you could have a look at the change today :) [18:58:24] hoo: in getSitesHash, you check the value of every site object, but in getScript you only use some Site objects, so you're probably going to end up over invalidating [18:58:30] * legoktm was already looking :P [18:59:05] legoktm: Yes, but the sites table almost never changes, so that's not really a thing [18:59:18] and I didn't want to bring even more complexity in there [18:59:22] also, I'm not sure about caching the hash for 5 minutes. I'm pretty sure that automatically happens since the startup module is cached by varnish for 5ish minutes. [18:59:50] legoktm: No, Output page calls for the module times [19:00:12] depends on how the module is loaded! [19:00:39] * legoktm looks [19:01:48] (03CR) 10Helder.wiki: Enable SitesModule cache invalidation (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [19:02:29] hoo|away: OutputPage only calls getModifiedTime if the module is in the 'user' group, which this isn't. [19:02:43] afais [19:03:42] it's not [19:04:04] so you think it's ok to shoot for the hungry get *all* sites? [19:05:05] is the module not deployed yet? https://bits.wikimedia.org/www.wikidata.org/load.php?modules=mw.config.values.wbSiteDetails [19:05:37] legoktm: Has another name on master [19:05:41] wikibase.sites [19:05:46] https://bits.wikimedia.org/www.wikidata.org/load.php?modules=wikibase.sites [19:05:47] ok [19:05:48] * deploy [19:09:28] hoo|away: looks fine to me, do you want me to +2? [19:10:14] legoktm: If it's ok, yes... I can also remove the memcached logic and pre-sort the sites if you prefer that [19:10:25] (03CR) 10Legoktm: [C: 031] Enable SitesModule cache invalidation (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [19:11:08] So you're more comfortable with removing it? [19:11:19] yes [19:11:26] also the sorting is a good idea [19:11:28] ok, will do [19:12:35] there's a swat tomorrow too in case stuff goes crazy to fix it [19:14:26] (03PS6) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 [19:16:31] legoktm: Are we good to go now? [19:18:13] away for now [19:18:16] merge would be great [19:25:12] (03PS1) 10Bene: Add badges intro to Special:SetSiteLink only when badges are available [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150632 [19:54:24] legoktm: So? :) [20:16:35] (03PS4) 10Jeroen De Dauw: DM 1.0 compat: Another attempt to clean up testCanApply [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149498 [20:16:56] (03PS5) 10Jeroen De Dauw: DM 1.0 compat: stop using Entity::toArray and ObjectComparer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149498 [20:57:46] Lydia_WMDE: hey, just pinging you re my email about the dev hub [20:58:39] sumanah: hey :) sorry. been swamped :/ it is still in my inbox [20:58:55] ok [21:01:28] Lydia_WMDE: get a slave to do work for you then [21:02:01] JohnLewis: right now a personal assistant would be most helpful [21:02:14] getting stuff organized for wikimania for example [21:02:14] Lydia_WMDE: get one then :p [21:02:28] or putting together the wikidata stuff happening at wikimania to send it around [21:02:40] JohnLewis: i wish i had the money for that ;-) [21:02:46] :p [21:15:55] (03PS7) 10Legoktm: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [21:15:58] (03CR) 10Legoktm: [C: 032] Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [21:16:07] (03Merged) 10jenkins-bot: Enable SitesModule cache invalidation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/150597 (owner: 10Hoo man) [21:17:04] thanks, legoktm :) [21:17:20] :) [21:19:27] aude: around? :) [21:28:22] (03PS1) 10Hoo man: Enable SitesModule cache invalidation [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/150704 [21:53:07] hello, has something changed about links to Wikimedia Commons? [21:53:22] it says "List of values is complete." [21:53:27] UAwiki: Known problem... we will deploy a fix tonight [21:53:37] ohhh thanks hoo [21:54:57] Lydia_WMDE: Do you have admin access to our jenkins? [21:55:19] hoo: i don't think so, no [21:55:22]