[08:43:40] lazowik: I'm the mouse, ok? [09:00:16] hoo: :DDD [09:00:45] mh? [09:00:51] benestar: sure [09:00:56] if you want to [09:01:02] (hey everyone) [09:01:19] hoo: what is still missing in my Wikidata.org pull request on github? [09:01:41] lazowik: hey :) what did you wanna know yesterday? [09:03:50] why get site by it's interwikiId ? [09:04:16] lazowik: because badges are applied to *interwiki*links [09:04:18] benestar: Address the nitpicks and we're good to go [09:04:23] ok [09:04:24] well ... and the actual content is missing [09:04:45] hoo: "Add some basic files" [09:04:52] benestar: why not by global id or sth [09:04:57] the actual content still has to be created [09:05:03] these interwikiIds are added by wikibase [09:05:10] I still don't know why [09:06:14] lazowik: well, that's all a bit tricky because we use parts of the old interwiki link system to add the links in Wikibase Client [09:06:30] and the old system relied on those interwikiIds, not on global ids [09:06:42] we used to write [[en:Foo bar]] not [[enwiki:Foo bar]] [09:06:49] yeah [09:07:01] benestar: why can't you use global ids there? [09:07:04] so the interwikiIds aren't added by wikibase, are they? [09:07:05] (to get site) [09:07:57] benestar: actually, they are [09:08:13] but they existed before [09:08:50] when I stumbled on that problem (class not being added in client) [09:09:17] the only things I've found in core were functions to add to retrieve them from Site [09:09:30] and search Site by them [09:09:34] lazowik: this line might explain it https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/includes/LangLinkHandler.php#L396 [09:09:41] but they were not used anywhere [09:10:30] argh [09:10:40] * benestar just sees that we use language codes there <- even worse [09:11:43] that looks messy [09:12:30] benestar: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/sites/SitesBuilder.php#L44 [09:12:30] that [09:12:47] interwikiIds are only added to groups [09:13:17] aude: ping [09:23:21] hoo: I added some questions to your comments [09:24:02] looking [09:27:28] replied [09:28:08] hoo: to all of them? [09:29:14] no [09:29:21] only what was worth replying [09:29:27] don't care enough for the rest [09:29:38] also don't want to get into super bike shedding mode [09:30:57] will there be a new json-dump today? [09:31:50] yes [09:35:26] It will probably be finished in about 4-5 hours [09:47:41] Thiemo_WMDE: the logo is WIKI in morse code not DATA :P [09:50:00] DanielK_WMDE_: hangout for the daily if you can join.. [09:50:03] we're ready [09:52:15] multichill: ping [10:01:20] (03PS1) 10WikidataBuilder: New Wikidata Build - 28/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149821 [10:04:33] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 28/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149821 (owner: 10WikidataBuilder) [10:10:23] sjoerddebruin: Pong? [10:10:47] I have a bot run for you, I think multichill. [10:10:52] uh oh [10:11:23] A lot of the Indonesia-items still need this: https://www.wikidata.org/w/index.php?title=Q14747527&diff=147962217&oldid=120459191 [10:12:34] Did you find a category/template for those items? [10:13:00] https://nl.wikipedia.org/wiki/Categorie:Plaats_in_Indonesië maybe? [10:13:14] Or you can use https://nl.wikipedia.org/wiki/Sjabloon:Infobox_plaats_in_Indonesië [10:13:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149821 (owner: 10WikidataBuilder) [10:15:54] (03CR) 10Daniel Kinzler: "I'm still not convinced, but ready to merge this to get us unstuck. There are two minor issues remaining though, see inline comments." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 (owner: 10Thiemo Mättig (WMDE)) [10:30:06] (03PS1) 10Thiemo Mättig (WMDE): Add support for numeric months in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149823 [10:32:37] (03Draft2) 10Daniel Kinzler: Simpified MonthNameUnlocalizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 [10:35:20] hoo: so are you ok now with the # used to draw the logo? [10:37:53] (03PS6) 10Thiemo Mättig (WMDE): Make MonthNameUnlocalizer aware of genitive month names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 [10:38:02] (03CR) 10Thiemo Mättig (WMDE): Make MonthNameUnlocalizer aware of genitive month names (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 (owner: 10Thiemo Mättig (WMDE)) [10:39:39] benestar: Not a fan... but if there's no better option [10:40:29] hoo: I did not find a better way to represent the logo [10:40:42] we really need colours in there^^ [10:41:47] looks like my LAN decided to die a little [10:44:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149823 (owner: 10Thiemo Mättig (WMDE)) [10:45:08] "70% packet loss" /0\ [10:50:02] oh noez [10:51:02] (03CR) 10Daniel Kinzler: Refactor MonthNameUnlocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE)) [10:52:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149386 (owner: 10Daniel Kinzler) [10:56:34] hoo: are you back again? [10:56:59] never been away [10:57:20] (03CR) 10Daniel Kinzler: [C: 032] "Approving this now, even though I don't like the details. Let's move on." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 (owner: 10Thiemo Mättig (WMDE)) [10:57:29] only having strong problems with my system right now... writes on network filesystems and high packet loss don't play well together [10:57:29] (03Merged) 10jenkins-bot: Make MonthNameUnlocalizer aware of genitive month names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 (owner: 10Thiemo Mättig (WMDE)) [10:57:39] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148113 (owner: 10Thiemo Mättig (WMDE)) [11:00:34] will have to restart... this is hung up beyond repair [11:00:54] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/0UGdXA [11:00:54] 13WikibaseDataModelSerialization/06master 147c92f25 15Jeroen De Dauw: Update README.md [11:02:04] [13WikibaseDataModelSerialization] 15JeroenDeDauw tagged 061.0.3 at 06master: 02http://git.io/Y43ZYA [11:04:47] [travis-ci] wmde/WikibaseDataModelSerialization/1.0.3/7c92f25 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/31030868 [11:07:22] http://wikidata.beta.wmflabs.org/wiki/Q11246 :S [11:14:18] [13WikibaseQuery] 15JeroenDeDauw created 06testexclude (+1 new commit): 02http://git.io/AAXx7A [11:14:18] 13WikibaseQuery/06testexclude 14708555d 15jeroendedauw: Stop exclusing test [11:14:38] [13WikibaseQuery] 15JeroenDeDauw opened pull request #43: Stop exclusing test (06master...06testexclude) 02http://git.io/ERceQw [11:17:22] [travis-ci] wmde/WikibaseQuery/testexclude/708555d : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/31031482 [11:22:57] Thiemo_WMDE: I can't find a script to import this [11:28:03] Just letting you know I wrote some scripts to harvest badges from Wikipedia and add it to Wikdata (also script for houskepping like removing when the featured article is delisted) and I wrote another script to remove Link FA and Link GA from Wikipedia [11:28:14] :) [11:28:47] Amir1: that's greaqt [11:28:52] -q [11:32:57] wtf is going on with my network [11:32:57] * hoo rages [11:33:00] can't do anything today -.- [11:33:18] (03CR) 10Daniel Kinzler: [C: 04-1] "needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148114 (owner: 10Thiemo Mättig (WMDE)) [11:33:48] (03PS4) 10Daniel Kinzler: Reuse existing date formats in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148641 (owner: 10Thiemo Mättig (WMDE)) [11:34:24] (03CR) 10Daniel Kinzler: "this is ready to be merged, just waiting for jenkins." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148641 (owner: 10Thiemo Mättig (WMDE)) [11:34:30] (03PS3) 10Daniel Kinzler: Only use date formats that can roundtrip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [11:34:38] (03CR) 10Daniel Kinzler: "this is ready to be merged, just waiting for jenkins." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [11:37:40] hoo: maybe one of NSA's spying tools is broken? [11:37:47] and is eating peackets :p [11:37:51] *packtes [11:44:44] benestar: Thank you :) [11:45:23] Tobi_WMDE_SWE, Thiemo_WMDE: From looking at ReferenceListDeserializer, it seems it doesn't look at the keys in the input array at all, so changing the hash value isn't a problem. [11:47:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148641 (owner: 10Thiemo Mättig (WMDE)) [11:53:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [11:54:36] DanielK_WMDE_: ok! thx for looking into that [11:57:39] (03Abandoned) 10Daniel Kinzler: (bug 57744) Allow ItemContent to represent a redirect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89810 (owner: 10Daniel Kinzler) [12:00:11] Amir1: do you have a global bot flag for this task? [12:01:48] benestar: Merged your PR now [12:01:57] now go and add some content etc. [12:02:10] :) [12:02:20] hoo: that's hard as I have no content yet :P [12:02:35] Thiemo_WMDE: Do you have the icons for badges? :P [12:02:36] Lydia_WMDE: do you already have the icons for all the different kinds of badges? [12:02:43] I think Thiemo has them [12:02:59] My connection seems stable now, btw... so I might do some real work later on [12:03:12] think my powerlan overheated which worries me a bit [12:03:19] :/ [12:03:27] all icons ie for stub articles etc :) [12:04:24] we don't need that now [12:04:28] only our two stars [12:04:37] or whatever [12:04:39] if not stars [12:05:52] benestar: No I don't :( It's against global bot policy [12:06:03] Yep... [12:06:23] but I doubt this will be a problem... we can just kill of the scripts [12:06:46] and the templates will then disappear rather fast (there are many who can do such simple template removals) [12:08:56] argh, I see [12:09:13] but that's weird... [12:10:44] well, we usually call it Wikipedia [12:17:25] I can run it and just hope no one block the bot [12:22:49] DanielK_WMDE_: ok, I just checked the behavior of the UI when handling redirects a bit.. [12:23:04] I made a redirect Q1 -> Q2 [12:23:55] and Q1 was used in some other item, let's call it Q30 as a value and as a qualifier value and in a reference as well [12:24:42] after creating the redirect and purging Q30 everything looked fine. the (new) label of Q2 was shown everywhere [12:25:31] but before doing the purge for some reason the new label was only shown in the qualifier.. [12:26:15] also when editing the statement, the new label appeared in the input box but after cancelling the old label returned.. [12:26:30] DanielK_WMDE_: not sure what exactly the correct behavior should be here [12:52:55] Lydia_WMDE: New json dump is there: Scheme looks good :) [12:53:07] And it's almost exactly 1% larger than the last [12:53:23] 1.005% to be precise [12:54:32] hoo: nice! [13:05:49] [13WikibaseQuery] 15JeroenDeDauw created 06commandoptions (+1 new commit): 02http://git.io/7Tcf2Q [13:05:49] 13WikibaseQuery/06commandoptions 14f5f1840 15jeroendedauw: Match changes in Wikibase QueryEngine [13:06:05] [13WikibaseQuery] 15JeroenDeDauw opened pull request #44: Match changes in Wikibase QueryEngine (06master...06commandoptions) 02http://git.io/Gs-SxA [13:11:05] hoo: And when can we see some stats again? http://tools.wmflabs.org/wikidata-todo/stats.php seems broken. [13:12:24] sjoerddebruin: Whenever someone decides to recreated them... the data is available to do so [13:12:41] Ok. :( [13:12:43] [travis-ci] wmde/WikibaseQuery/commandoptions/f5f1840 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/31039226 [13:13:01] a question: When the badges will go live? [13:13:11] Lydia_WMDE: ^ [13:13:45] I mean do you have a certain date or something? [13:14:03] Some stuff will happen on August 19th, not sure badges will be belong that [13:14:37] Amir1: hopefully on 19th but not 100% certain [13:14:55] Lydia_WMDE: thank you :) [13:18:33] Lydia_WMDE: when will we have custom icons for all badges? [13:19:03] benestar: what exactly do you mean? [13:19:05] Amir1: I was looking for you [13:19:23] multichill: Hi, I was sleep I just woke up [13:19:30] Lydia_WMDE: we decided to display custom icons for each badge on wikidata [13:19:44] Amir1: Take a look at https://www.wikidata.org/wiki/User:JanitorBot . Do you want to help out with that? [13:19:45] and we decided to put these icons into the Wikidata.org extension [13:20:03] Central bot with multiple operators to do scheduled work that never stops [13:20:05] so the extension is set up now but the icons are still missing ;) [13:20:37] benestar: yeah. need to talk to thiemo when he is back [13:20:58] k [13:21:14] Lydia_WMDE: should we create an Extension:Wikidata.org page on mediawiki.org? [13:21:17] we're only going to have two badges to start with [13:21:17] multichill: sounds really good, Do you want me to send you my codes for interwiki? [13:21:23] benestar: Not needed, no [13:21:27] k [13:21:40] Lydia_WMDE: Only remaining blockers are: Icons and show badges by label, right? [13:21:46] Code wise i would like to run as much normal pywikibot as possible [13:21:52] sorry guy i need to take care of some other urgent stuff right now [13:22:06] *guys [13:22:26] k [13:22:34] So first step would just be query + newitem.py running on a bunch of wiki's [13:22:34] ok [13:23:09] hoo: and deciding what badges we allow [13:23:59] benestar: Good and featured article [13:24:05] hoo: for now, ok [13:24:22] everything else really is far less important now [13:24:25] let me create a patch to enable these badges on wikidata [13:24:37] to early [13:24:39] multichill: sure, okay. [13:24:52] multichill: what else I can do? [13:25:07] hoo: it is the only thing I can do right now because everything else is blocked [13:25:13] not true [13:25:13] I already created an account on labs [13:25:20] you can enable the label lookups [13:25:35] is the lookup already merged? [13:25:42] I think DanielK_WMDE_ worked on it still? [13:25:43] no, just use an EntityLookup for now [13:25:50] we're talking about to items here [13:25:55] that's not an issue [13:26:05] it's (mem)cached also [13:26:13] Amir1: I'll see if I can properly setup the account with Pywikibot, logging etc and add you to the group [13:26:18] Than we can start setting up jobs [13:26:28] multichill: okay :) [13:27:23] I might still have some outstanding changes to be merged.... [13:27:46] let me check [13:28:01] And I wonder if array jobs are worth the trouble here [13:28:12] well, someone opposed to use EntityLookup for efficience reasons [13:28:24] I don't care for two entities [13:28:35] we do it for several hundred in the client [13:28:48] (sometimes) [13:29:06] multichill: https://gerrit.wikimedia.org/r/138453 [13:29:23] this is the only onw [13:29:25] *one [13:29:46] Might still be staged locally. I have to check [13:34:28] it's about images AFAIK [13:36:00] hoo: are you working on https://bugzilla.wikimedia.org/show_bug.cgi?id=66419? moving the WikibaseAPI JS code? [13:38:57] Tobi_WMDE_SWE: Not right now, but I think I can start over again [13:39:09] apparently the latest change got merged, but I didn't notice [13:39:26] do we yet have a repo for that? [13:39:43] Well, I can create it myself it seems, so nevermind [13:55:13] hoo, benestar : I think the best solution for the approval is mentioning this in announcements: "If you want to get your featured/good templates removed, add your name in this page and give User:Dexbot permission to do so" [13:57:57] who I need to ask for help with adding new article on wikipedia ? the cms and interface of wiki is totally crap - I had add article but I just received an email that admin from Wiki treat it like spam.. Do you have any ideas how can I add my company wiki page ? [13:58:40] Amir1: might be a good idea [13:58:49] just try it and see how many people like it [14:00:34] benestar: you should add it to your announcement for badges in wikitech-l, wikitech-ambassadors [14:00:59] Xtbpolska: "polska" is a coincidence? [14:01:09] jeśli nie -> #wikipedia-pl [14:01:09] Amir1: I think Lydia_WMDE manages the announcements [14:01:43] Xtbpolska: keep in mind wikipedia is not a place to promote companies [14:02:16] she told me she will tell if don't forget :) [14:05:47] I know - but we like microsoft or google - if you are talking about forex in Poland. We want only to add info about company not to promote anything. [14:29:11] What's the item with the longest label btw? [14:30:12] there's an upper limit for labels... [14:30:23] Oh? [14:30:28] hoo: but somehow we get over it and then can't edit the item :) [14:31:00] it used to be possible to add indefinite long labels (more than a year back AFAIR) [14:31:09] but now we have that covered [14:31:26] probably then then :p [14:35:33] (03PS1) 10Bene: Get label of badge in SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149865 (https://bugzilla.wikimedia.org/68183) [14:36:59] hoo: we agreed to create new items for the badges and not use the template items, right? [14:37:31] Lydia_WMDE: ^ [14:37:34] but I think so, yes [14:38:19] yeah [14:44:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149865 (https://bugzilla.wikimedia.org/68183) (owner: 10Bene) [14:57:37] (03PS1) 10Bene: Show label of badges in Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) [14:57:57] and two new patches on gerrit for badges :D [14:58:38] Lydia_WMDE: should the badge items have special item ids or can I just go and create two items for them? [15:03:58] benestar: i'd say just go ahead [15:04:35] benestar: just a simple (and maybe stupid) question: Do you there are three types of status: featured, good and featured list (FL)? I think you can work it out when there i instance of list [15:05:02] some wikis like Persian have different badge for FL [15:05:35] Amir1: yes, something similar also exists on dewiki [15:05:51] however, in a first step we only want to import good and featured articles [15:05:58] okay :) [15:06:10] later on it will be possible to add something like good lists and stubs etc [15:06:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) (owner: 10Bene) [15:06:45] Amir1: your task basically is to go through all Wikipedias all the time and import all good and featured articles to Wikidata [15:07:27] yes, I can do it for lists though and stubs too. I was just curious [15:07:41] your bot has therefore to run all the time, also when migration has finished because the templates are only added to Wikipedia atm [15:07:58] Amir1: do you have the source code of your bot anywhere? [15:08:10] then I can do a quick review if you want :) [15:08:12] yes, I wrote it in a way to keep cleaning for new featured/good articles too [15:08:20] nice :) [15:08:34] benestar: It's based on featured.py in pywikibot [15:08:56] I just removed two functions and replaced with Wikidata version of it [15:09:13] so only adjusted to edit Wikidata instead of Wikipedia [15:09:13] benestar: I can send it to you if you like [15:09:37] I wrote another code for removing template link FA and GA [15:09:38] however, the featured.py does not support stubs or lists, right? [15:09:50] Amir1: no github? :( [15:10:09] featured.py supports featured list but not stubs [15:10:12] Amir1: the second script can sleep a while ;) [15:10:28] we have to finish migration to Wikidata and only run it when everything works fine [15:10:36] and all the data is imported [15:10:38] benestar: I usually don't publish my scripts for some reasons, long story [15:10:55] but if anyone wants I send it to him/her [15:10:55] Amir1: btw where do you run your bots? [15:11:01] labs [15:11:09] then you have to make it open source :P [15:11:40] but don't mind [15:11:51] I suppose it works correctly :) [15:12:43] benestar: Don't get me wrong, I'm not a bad guy that keeps it codes for himself, lots of my codes are published but an incident happened a rather long time ago [15:13:00] a cross-wiki abuse of my code [15:13:17] hmm, that's a problem indeed [15:13:26] so I decided not publish my codes unless necessary [15:13:33] and don't worry, I did not get you wrong :) [15:14:03] :) [15:21:34] a question about the new json-dump: is it one entity per line ? [15:21:44] lbenedix1: yes [15:21:51] nice [15:22:07] is there a date for the next dump with history? [15:22:20] no clue about the xml dumps, sorry [15:22:26] ok [15:22:29] thx [15:23:52] if there are country-specific articles in one wikipedia, but only a single article in another, should be interwiki-links point to the disambiguation page? [15:24:26] lbenedix1: It will be in the next week [15:24:40] xml dumps are usually updated every 25 days [15:25:25] e.g. https://de.wikipedia.org/wiki/Gesellschaft_mit_beschr%C3%A4nkter_Haftung and https://de.wikipedia.org/wiki/Gesellschaft_mit_beschr%C3%A4nkter_Haftung_(Deutschland) both have links, which is kind of stupid [15:27:45] hoo: I want to implement json dump support in pywikibot but it's almost impossible: the issue is xml dump reader are using a generator named iterparse so it won't be a issue for big dumps [15:27:59] but json files doesn't have any library like that [15:28:05] mh [15:28:14] You can parse them line by line [15:28:24] there is a library for that [15:28:30] not sure [15:28:32] named fileinput, it's [15:28:37] I know there is [15:28:39] Daniel mentioned something along these lines [15:28:46] like a deferred json parser or so [15:28:58] but just reading the file line by line will already work [15:29:21] in python there is a famous line-by-line generator named fileinput [15:29:31] it's a built-in library [15:30:11] but the issue is unicode support of the library is shitty. I wanted to use for fa.wp once, It's a utter disaster [15:30:31] (03PS2) 10Bene: Show label of badges in Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) [15:31:22] Amir1: Reading line by line with proper unicode support is doable [15:31:30] I've did it before (in Python 3, though) [15:31:44] in which library? [15:32:43] Amir1: Splitlines? Isn't that unicode? [15:33:02] Amir1: No library :P [15:33:26] multichill: it's unicode, but I need a generator, since dumps are really big [15:33:39] you can set just file.read() or file.readlines() [15:34:21] hoo: Can I see your code? [15:34:44] *can't [15:34:53] Amir1: Nothing wiki related [15:34:53] Oh right, but for line in file contains garbage for you? [15:34:57] also I can't find it right now [15:35:09] one of these messy one-of scripts I wrote some time [15:36:30] (03PS1) 10JanZerebecki: Add title by item special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) [15:37:28] hoo: can you tell me how did you do that? [15:37:39] Amir1: Sadly no, I can't find it :S [15:37:55] multichill: it doesn't contain garbage [15:38:18] hoo: okay, let me search a little more maybe I could find something [15:43:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) (owner: 10Bene) [15:44:38] hoo: do you know why phpunit does not accept when I set 'content' => 'Featured article'? [15:44:43] for assertTag [15:45:09] not offhand [15:45:15] but according to aude (who is away) [15:45:20] assertTag is deprecated [15:45:23] anyway [15:45:31] so you might be better of using a regexp [15:45:49] argh [15:46:10] the last thing one should do is parsing html with a regex [15:46:33] you're not parsing, just asserting certain things [15:47:00] well, I will just skip testing that case and maybe when I have much time rewrite the tests using regex [15:49:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [16:09:41] Just adding a short alias... https://www.wikidata.org/w/index.php?title=Q1983867&diff=148008547&oldid=2698512 [16:10:15] (03PS2) 10JanZerebecki: Add title by item special page. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) [16:14:15] Lydia_WMDE are you around ? [16:18:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [16:19:27] does anybody know if she is currently there ... ? [16:21:43] (03PS3) 10Bene: Show label of badges in Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) [16:21:52] * hoo not in the office this week [16:21:56] so no [16:23:18] ... anybody who can speak in her stead ? [16:23:43] don't think so... maybe you should just ask your question [16:23:54] maybe someone can [16:24:13] it is something on a strategy level [16:25:03] about lexical data [16:25:11] and future stuff [16:26:31] hoo: can you please rename the wikidata.org repository to Wikidata.org (capitalized)? [16:26:47] all other mediawiki extension also start with a capital letter [16:26:47] uh [16:27:07] I can't [16:27:13] * hoo looks for a Tobi [16:27:18] well, so I have to ask Lydia_WMDE? [16:27:18] no Tobi, so :S [16:27:35] well, doesn't matter, just a nitpick [16:27:40] benestar, hoo: for more complicated assertions one could replace assertTag with assertEqualXMLStructure(), some dom parsing/manipulation and assertXmlStringEqualsXmlString() [16:28:09] benestar: Only Jeroen, Tobi and Abraham can actually change that [16:28:11] not even Lydia [16:28:19] oh, ok [16:28:33] jzerebec1i: Assuming these aren't going to be removed, yes [16:28:34] so I will ping one of them if they are here [16:29:24] yeah [16:30:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) (owner: 10Bene) [16:33:21] hoo: just realized it isn't a good idea to make wikibase a dependency of wikidata.org [16:33:33] composer will load the whole extension again to the vendor of wikidata.org [16:33:36] hahaha [16:33:40] :P [16:34:03] hoo: I don't think so. the rationale for removal of asserTag seems not to apply to the xml ones: https://github.com/sebastianbergmann/phpunit/issues/1292 [16:34:19] hoo: just remove the dependency from composer? [16:35:50] benestar: It should also work if you keep it in there, and the install it with the build [16:35:53] not sure, though [17:13:02] (03CR) 10JanZerebecki: "Looks good. Perhaps add a test case where hasTermForLanguage() will be false?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149870 (https://bugzilla.wikimedia.org/67923) (owner: 10Bene) [17:42:30] hoo: pls merge my pull request [17:42:41] some silly and some not so silly additions [17:43:07] link? [17:46:50] (03PS4) 10Hoo man: Inject RepoApi into AbstractedRepoApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145280 (owner: 10Adrian Lang) [17:47:04] (03CR) 10Hoo man: "Rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145280 (owner: 10Adrian Lang) [17:50:24] benestar: Just noticed something: We require the bootstrap to be loaded after the one of Wikibase [17:50:29] if ( !defined( 'WB_VERSION' ) ) { [17:50:29] throw new Exception( 'The Wikidata.org extension requires Wikibase to be installed.' ); [17:50:35] don't think we should do that [17:50:52] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149877 (https://bugzilla.wikimedia.org/64776) (owner: 10JanZerebecki) [17:51:17] github.com/wmde/wikidata.org/pull/2 [17:51:25] https://github.com/wmde/wikidata.org/pull/2 [17:52:01] yeah, just merged [17:52:07] got that by mail [17:52:07] thx :) [17:52:18]