[01:16:41] hoi [01:16:44] hallo [01:16:54] any dutch [01:24:09] any dautch here [01:24:47] any dutch here [01:25:48] i am 13 [01:26:00] help me [01:26:25] i have a problem [01:26:50] drop dead [01:31:15] Hans_: what do you need? i don't speak dutch, however [01:35:21] troll alert ^^^ [02:36:48] (03CR) 10Jeroen De Dauw: [C: 032] Roundtrip tests for Qualifiers and References [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149038 (https://bugzilla.wikimedia.org/66839) (owner: 10Thiemo Mättig (WMDE)) [02:37:10] (03CR) 10Jeroen De Dauw: [C: 032] Add test for ranks to DataModelSerializationRoundtripTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149048 (owner: 10Thiemo Mättig (WMDE)) [02:42:03] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/hN9UXQ [02:42:03] 13WikibaseDataModel/06master 14de3523f 15Jeroen De Dauw: Update WikibaseDataModel.php [02:43:12] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/dEM9Ww [02:43:12] 13WikibaseDataModel/06master 147959060 15Jeroen De Dauw: Update RELEASE-NOTES.md [02:45:14] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/F58vXA [02:45:14] 13WikibaseDataModel/06master 14c8209d9 15Jeroen De Dauw: Update RELEASE-NOTES.md [02:48:24] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/twFP6Q [02:48:24] 13WikibaseDataModel/06master 143c138e8 15Jeroen De Dauw: Update RELEASE-NOTES.md [02:49:56] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 060.8.x: 02http://git.io/-x4Y-A [02:49:56] 13WikibaseDataModel/060.8.x 14b044086 15jeroendedauw: Backport some stuff from 1.0 into a new 0.8.2 rel [02:50:24] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/_MD5_w [02:50:24] 13WikibaseDataModel/06master 14781eb57 15Jeroen De Dauw: Update RELEASE-NOTES.md [02:54:38] (03PS1) 10Jeroen De Dauw: [DNM] See if the CI passes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149222 [03:03:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149222 (owner: 10Jeroen De Dauw) [03:04:22] [13WikibaseDataModel] 15JeroenDeDauw tagged 060.8.2 at 060.8.x: 02http://git.io/YF_ewA [03:05:42] (03Abandoned) 10Jeroen De Dauw: [DNM] See if the CI passes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149222 (owner: 10Jeroen De Dauw) [03:06:18] (03PS1) 10Jeroen De Dauw: Use DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149223 [03:14:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149223 (owner: 10Jeroen De Dauw) [03:15:22] (03CR) 10Jeroen De Dauw: [C: 032] Use DataModel 0.8.2 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149223 (owner: 10Jeroen De Dauw) [03:20:05] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149224 [03:24:04] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149225 [03:26:43] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149226 [03:28:19] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149227 [03:30:02] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149228 [03:31:43] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149229 [03:33:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149224 (owner: 10Jeroen De Dauw) [03:36:48] (03PS1) 10Jeroen De Dauw: Some cleanup in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149230 [03:36:50] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use DataModel\Internal\ObjectComparer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149231 [03:36:52] (03Abandoned) 10Jeroen De Dauw: WIP use DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139599 (owner: 10Jeroen De Dauw) [03:46:24] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: remove bad test case from ChangeOpsMergeTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149232 [03:46:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149225 (owner: 10Jeroen De Dauw) [03:49:57] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/Xpjl1w [03:49:57] 13WikibaseDataModel/06master 1418049fe 15Jeroen De Dauw: Update composer.json [03:52:12] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use Fingerprint::setLabel for now [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149233 [03:56:23] (03PS1) 10Jeroen De Dauw: Add DM 1.0 TODOs in WikibaseRepoTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149234 [03:58:27] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149235 [04:00:48] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use Snaks::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149236 [04:01:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149226 (owner: 10Jeroen De Dauw) [04:04:10] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149237 [04:05:50] (03PS1) 10Jeroen De Dauw: Update ref to Entity and remove ref that has not existed for years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149238 [04:05:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/f15ab26 : Jeroen De Dauw The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30807871 [04:07:23] (03PS1) 10Jeroen De Dauw: Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149239 [04:07:25] (03PS1) 10Jeroen De Dauw: Update class refs and remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149240 [04:07:26] [travis-ci] wmde/WikibaseDataModel/0.8.x/b044086 : jeroendedauw The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/30808167 [04:09:43] (03PS1) 10Jeroen De Dauw: Update class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149241 [04:11:43] (03PS1) 10Jeroen De Dauw: [DNM] Testing against DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149242 [04:13:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/159c663 : Jeroen De Dauw The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30807891 [04:14:30] [travis-ci] wmde/WikibaseDataModel/0.8.2/b044086 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30808515 [04:15:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149227 (owner: 10Jeroen De Dauw) [04:20:07] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/qO6elA [04:20:07] 13WikibaseDataModel/06master 1412daf5c 15Jeroen De Dauw: Update RELEASE-NOTES.md [04:21:29] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149244 [04:22:18] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/0d7ac5a : jeroendedauw The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30808948 [04:25:43] (03PS2) 10Jeroen De Dauw: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149227 [04:29:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149228 (owner: 10Jeroen De Dauw) [04:29:49] (03PS1) 10Jeroen De Dauw: Add FIXME to EntityPerPageTable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149245 [04:31:21] (03PS1) 10Jeroen De Dauw: Remove comment that perscribes dubious approach to solve a problem [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149246 [04:36:10] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149244 (owner: 10Jeroen De Dauw) [04:39:52] (03PS1) 10Jeroen De Dauw: DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149247 [04:44:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149229 (owner: 10Jeroen De Dauw) [04:45:33] (03PS1) 10Jeroen De Dauw: Remove silly lines [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149248 [04:57:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149230 (owner: 10Jeroen De Dauw) [04:59:26] (03CR) 10Jeroen De Dauw: [C: 032] Some cleanup in ClaimDiffer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149230 (owner: 10Jeroen De Dauw) [04:59:53] (03CR) 10Jeroen De Dauw: [C: 032] Remove silly lines [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149248 (owner: 10Jeroen De Dauw) [04:59:58] (03CR) 10Jeroen De Dauw: [V: 032] Remove silly lines [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149248 (owner: 10Jeroen De Dauw) [05:02:34] (03PS1) 10Jeroen De Dauw: Improve test in SpecialUnconnectedPagesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149249 [05:03:38] (03PS1) 10Jeroen De Dauw: Added missing type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149250 [05:11:54] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149231 (owner: 10Jeroen De Dauw) [05:22:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149232 (owner: 10Jeroen De Dauw) [05:31:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149233 (owner: 10Jeroen De Dauw) [05:39:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149234 (owner: 10Jeroen De Dauw) [05:48:50] [travis-ci] wmde/WikibaseDataModel/0.8.2/b044086 : jeroendedauw The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30808515 [05:49:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149235 (owner: 10Jeroen De Dauw) [06:00:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149236 (owner: 10Jeroen De Dauw) [06:07:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149237 (owner: 10Jeroen De Dauw) [06:13:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149238 (owner: 10Jeroen De Dauw) [06:18:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149239 (owner: 10Jeroen De Dauw) [06:23:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149240 (owner: 10Jeroen De Dauw) [06:28:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149241 (owner: 10Jeroen De Dauw) [06:30:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149242 (owner: 10Jeroen De Dauw) [06:30:53] (03Abandoned) 10Jeroen De Dauw: [DNM] Testing against DataModel 1.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149242 (owner: 10Jeroen De Dauw) [06:35:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149244 (owner: 10Jeroen De Dauw) [06:40:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149227 (owner: 10Jeroen De Dauw) [06:45:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149245 (owner: 10Jeroen De Dauw) [06:50:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149246 (owner: 10Jeroen De Dauw) [06:55:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149247 (owner: 10Jeroen De Dauw) [07:00:17] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149248 (owner: 10Jeroen De Dauw) [07:05:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149249 (owner: 10Jeroen De Dauw) [07:10:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149250 (owner: 10Jeroen De Dauw) [09:14:37] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=68533 [09:14:57] not exactly critical but you might be able to fix [09:16:34] aude: that's quite strange... or rather, yes, that would happen if one of the revisions was a redirect. And I see no way to fix it in that case. [09:17:12] display an error? instead of exception? [09:17:27] the issue is that an EntityContent that is a redirect needs to know it's own id, but the standard mechanism for creating redirects Content objects does not provide this information. [09:17:42] suppose might need to be fixed in the special page [09:17:59] yea, i just see to good place to handle this. [09:18:05] where do we have all the information we need? [09:18:09] no idea [09:18:14] me neither [09:18:16] * aude only see stack trace, not looked yet [09:18:39] didn't even know we had such a special page :p [09:18:53] same here [09:19:11] but i did know the standard "make redirect" thing that core uses on content objects would fail for entity content [09:19:20] * aude nods [09:19:40] This is because EntityContent always wants to know it's own id. But has no way to know it in this case. [09:20:09] that's quite annoying, but I see no obvious solution. [09:20:14] i'll comment. [09:20:43] ok [09:20:57] as i say, not urgent [09:21:04] but if someone finds a way to fix this, nice [09:24:49] aude: all we can do is make the special page more robust, see my comment on the bug [09:25:03] probably $ok [09:25:05] gah [09:25:18] if !supportsRedirects [09:25:21] or such [09:26:47] aude: yes, that would fix Property, but not Item: Items do support redirects - well, a special kind of redirect anyway. [09:26:56] oh [09:27:05] For Item, supportsRedirect() should return "kinda sorta"... [09:27:41] aude: we could still just catch any exceptions that arise while trying to create the redirect. [09:40:35] (03PS1) 10Thiemo Mättig (WMDE): Drop dead experimental code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149280 [09:46:42] DanielK_WMDE_: coming? :) [09:48:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149280 (owner: 10Thiemo Mättig (WMDE)) [09:49:21] Lydia_WMDE: ick bin all hier... [10:00:35] (03PS1) 10WikidataBuilder: New Wikidata Build - 25/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149282 [10:03:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149282 (owner: 10WikidataBuilder) [10:03:55] DanielK_WMDE_: Checkout master, open DataModelSerializationRoundtripTest, uncomment the UnDeserializableValue bit and run the test. It will fail because of hash mismatches. [10:13:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=66971 can be closed now? patch is merged [10:17:53] (03PS1) 10Thiemo Mättig (WMDE): Code style cleanup in wbcreateredirect API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 [10:18:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Introduce wbcreateredirect API module (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [10:24:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149224 (owner: 10Jeroen De Dauw) [10:24:40] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149224 (owner: 10Jeroen De Dauw) [10:25:02] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149225 (owner: 10Jeroen De Dauw) [10:25:11] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149225 (owner: 10Jeroen De Dauw) [10:26:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 (owner: 10Thiemo Mättig (WMDE)) [10:31:22] JeroenDeDauw: LegacyIdInterpreter::newIdFromTypeAndNumber is static, but you are using at like it's not static. I find this confusing. Why does PHP even allow this? Is this intentional in your patches? [10:32:21] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I can think of a reason, just want to hear yours." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149228 (owner: 10Jeroen De Dauw) [10:34:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add DM 1.0 TODOs in WikibaseRepoTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149234 (owner: 10Jeroen De Dauw) [10:34:19] (03Merged) 10jenkins-bot: Add DM 1.0 TODOs in WikibaseRepoTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149234 (owner: 10Jeroen De Dauw) [10:34:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149235 (owner: 10Jeroen De Dauw) [10:34:55] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149235 (owner: 10Jeroen De Dauw) [10:35:11] Thiemo_WMDE: huh lolwat [10:35:13] hahaha [10:35:15] >_> [10:35:28] Thiemo_WMDE: ok, silly me, then I did not need to create those instances [10:35:34] Anyway, this still works fine [10:35:46] It's just silly [10:35:55] sure. i accidentially merged two similar patches. no big deal. just bad style. [10:36:17] will you amend the patch? [10:36:19] Thiemo_WMDE: can you also merge the others? This is less of an issue than the old code, and we can fix it afterwards [10:36:27] ok. will do. [10:36:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use Snaks::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149236 (owner: 10Jeroen De Dauw) [10:36:53] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use Snaks::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149236 (owner: 10Jeroen De Dauw) [10:37:13] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Update ref to Entity and remove ref that has not existed for years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149238 (owner: 10Jeroen De Dauw) [10:37:22] (03Merged) 10jenkins-bot: Update ref to Entity and remove ref that has not existed for years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149238 (owner: 10Jeroen De Dauw) [10:37:59] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149239 (owner: 10Jeroen De Dauw) [10:38:08] (03Merged) 10jenkins-bot: Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149239 (owner: 10Jeroen De Dauw) [10:38:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Update class refs and remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149240 (owner: 10Jeroen De Dauw) [10:38:27] (03Merged) 10jenkins-bot: Update class refs and remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149240 (owner: 10Jeroen De Dauw) [10:38:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Update class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149241 (owner: 10Jeroen De Dauw) [10:38:43] (03Merged) 10jenkins-bot: Update class ref [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149241 (owner: 10Jeroen De Dauw) [10:39:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add FIXME to EntityPerPageTable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149245 (owner: 10Jeroen De Dauw) [10:39:12] (03Merged) 10jenkins-bot: Add FIXME to EntityPerPageTable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149245 (owner: 10Jeroen De Dauw) [10:40:33] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "This was added by Daniel. He may want to have a quick look at this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149246 (owner: 10Jeroen De Dauw) [10:41:06] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149247 (owner: 10Jeroen De Dauw) [10:41:15] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149247 (owner: 10Jeroen De Dauw) [10:42:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Improve test in SpecialUnconnectedPagesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149249 (owner: 10Jeroen De Dauw) [10:42:09] (03Merged) 10jenkins-bot: Improve test in SpecialUnconnectedPagesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149249 (owner: 10Jeroen De Dauw) [10:45:13] Thiemo_WMDE: he did see it, I mailed him and he replied [10:53:11] (03CR) 10Daniel Kinzler: "Thanks Thiemo! See comments." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [10:54:49] (03CR) 10Jeroen De Dauw: [C: 032] "Daniel: I rewrote the entire thing for you so you and explained a pile of things several times. Not sure how that is "not helping". Also n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [10:55:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/2dbee30 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30829650 [10:56:08] (03CR) 10Daniel Kinzler: "@Jeroen: removed you as per Tobi's comment; I see no progress on the architecture discussion, and I see no reason to block this change on " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [10:56:18] hey! [10:56:21] Thiemo_WMDE: so why this one -1 then? https://gerrit.wikimedia.org/r/#/c/149228/1 [10:56:53] (03CR) 10Daniel Kinzler: "@Jeroen: whoops, wrote my comment before I saw yours. should have refreshed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [10:58:07] (03CR) 10Jeroen De Dauw: [C: 032] Drop dead experimental code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149280 (owner: 10Thiemo Mättig (WMDE)) [10:58:21] (03PS2) 10Jeroen De Dauw: Code style cleanup in wbcreateredirect API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 (owner: 10Thiemo Mättig (WMDE)) [10:58:41] JeroenDeDauw: the api module thing set around for two weeks because of an unresolved architecture discussion. I didn't want to touch it before that was resolved. [10:59:57] That disucssion did not block merging it [11:00:05] Why would you not fix the issues that everyone agrees on? [11:00:14] Then I get the impression you are not doing anything [11:00:18] Because well, you aren;'t [11:00:32] (03CR) 10Jeroen De Dauw: [C: 032] Code style cleanup in wbcreateredirect API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 (owner: 10Thiemo Mättig (WMDE)) [11:00:43] (03Merged) 10jenkins-bot: Code style cleanup in wbcreateredirect API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 (owner: 10Thiemo Mättig (WMDE)) [11:00:55] JeroenDeDauw: you give a -2 for naming issues? that's very confusing. i was under the impression you insisted on the split. [11:01:15] i don't like polishing things if i know i have to get out the ax again. [11:01:34] that'S why i didn't fix the minor issues earlier - it would have been pointless if a complete refactoring was coming up anyway. [11:02:02] a -2 means "this is a bad idea", not "please find better names". [11:02:30] Really? The naming issues would have needed to be fixed even if you did exactly what I suggested [11:03:18] some yes, some no, some elöesewere or in a different way. if the *approach* is still being discussed, i'm not going to polish details. [11:03:58] JeroenDeDauw: in any case, if you give a -2, please make it very clear what it is for, and would be needed to unblock. [11:04:20] (same applies for a -1 really, but there it's not so critical) [11:04:35] JeroenDeDauw: anyway, what do you think of https://gerrit.wikimedia.org/r/#/c/149183/ ? [11:04:44] Why is it less critical for -1? [11:05:11] because a -1 isn't sticky, and doesn't scream "do not merge". [11:05:18] I think I did that 18 months ago and hope that this time people are less retarded about it [11:05:31] did what? [11:05:37] DanielK_WMDE_: yeah indeed, so you can get it merged without having the issues fixed [11:05:56] if someone agrees that it'S good enough, yes. [11:06:39] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 (owner: 10Thiemo Mättig (WMDE)) [11:07:02] JeroenDeDauw: if you want to make absolutely sure that an issue is fixed before merge, because you think it's absolutely critical, then give a -2 and make it VERY clear what that critical issue is. [11:07:29] naming issues are not -2 material in my book. architecture dioscussions may be. [11:07:55] so I assumed that'S what we are blocked on [11:08:02] DanielK_WMDE_: bad code that can easily be fixed is a critical issue, esp if you do not go back later and fix it [11:08:15] may I chime in a little bit? [11:08:51] lazowik: sure... [11:09:10] DanielK_WMDE_: you're saying that this code is not final, right? [11:09:21] (even if merged) [11:09:28] JeroenDeDauw: so you give a -2 for things that are easily fixed, because they are easily fixed? the convention is the opposit: -2 means "broken beyond repair" or simply "don't do that, it's a bad idea". [11:09:39] lazowik: no code is ever final [11:09:40] (apart from that no code is final) [11:10:02] not sure how that would be "apart". [11:10:11] it's not final. i have no concrete plans to change it right now. [11:10:13] well, that it is to be quickly replaced? [11:10:15] agh [11:10:17] *ah [11:10:35] replaced? no. [11:10:50] the entire module might be disabled in production though. but that's a different issue. [11:11:02] that's more a question of policy. [11:11:10] mhm [11:11:26] (03CR) 10Jeroen De Dauw: Provides a default to otherProjectsLinks configuration parameter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [11:12:08] DanielK_WMDE_: I am making sure you do not introduce more technical debt without taking care of it [11:12:19] The number one source of technical debt introduction is very clear to me [11:12:24] So I counter it [11:13:11] i nthe least productive way possible. [11:14:57] JeroenDeDauw: is probably saying that every commit should improve code quality, right? [11:15:34] lazowik: If your commits on average degrade the code, then there definitly is a problem [11:20:01] JeroenDeDauw: it it that bad? [11:28:38] (03CR) 10Daniel Kinzler: "Subclassing is not a good way to share code. This is a design flaw in DBAccessBase. I factored DBAccessBase out of ORMTable shortly after " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149246 (owner: 10Jeroen De Dauw) [11:29:57] (03CR) 10Daniel Kinzler: "Addendum: the functionality of DBAccessBase is pretty trivial, a rewrite wouldn't be hard. But still, refactoring takes time and effort, a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149246 (owner: 10Jeroen De Dauw) [11:32:10] Hey, Is there any test website that I can test badges (API and UI) [11:33:03] test.wikidata has them disabled [11:33:07] hmm [11:33:51] same goes for beta wikidata [11:34:43] benestar|cloud: do I remember correctly that some basic editing is now possible? [11:34:55] with edit badges linking to special page? [11:35:16] lazowik: Yep, I've did that early this week [11:35:25] ah, that was you [11:35:57] any dev having a public master install? [11:36:05] I could try to set up one [11:36:08] no guarantees [11:39:19] lazowik: If you have composer around it's not hard to set it up at all [11:39:53] nah, I mean more of a serever dependencies [11:39:55] and resources [11:40:08] I have my own local install of course [11:40:28] oh that [11:40:46] if you don't want it for a long time, you can just use tool labs [11:41:46] I once tried to unerstand tools [11:41:49] I failed :D [11:41:57] s/tools/labs [11:42:18] (03CR) 10Daniel Kinzler: [C: 031] "Looks pretty good. there is a minor naming issue, bit would be ok to merge." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [11:42:57] maybe I gave up too quickly? [11:42:59] meh :P [11:43:12] lazowik: MAybe... it's not hard really [11:43:24] if you have a basic understanding of things, at least [11:43:36] all of the things, of course :p [11:44:18] (03CR) 10Daniel Kinzler: "Hm... I'm unclear on the concrete use case of this. Is the idea to allow 'special' to be used to say 'show sister links for all projects c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [11:46:56] (03CR) 10Hoo man: "No, the use case is to make this work even if 'special' is in the 'siteLinkGroups'... this change basically makes the thing smart enough t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [11:47:26] (03CR) 10Daniel Kinzler: [C: 032] Reuse existing date formats in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148641 (owner: 10Thiemo Mättig (WMDE)) [11:50:21] DanielK_WMDE_: Eg. if the setting says siteLinkGroups = array( 'wikipedia', 'wikisource', 'special' ) [11:50:44] we want that thing to actuall work with 'wikipedia', 'wikisource', 'commons', 'wikidata' [11:52:44] DanielK_WMDE_: does https://gerrit.wikimedia.org/r/#/c/145522/ fully solve https://bugzilla.wikimedia.org/show_bug.cgi?id=66971? [11:52:50] and can we close the bug then? [11:53:18] (03PS1) 10Thiemo Mättig (WMDE): Add missing type hints [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149291 [11:53:27] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Added missing type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149250 (owner: 10Jeroen De Dauw) [11:53:35] (03Merged) 10jenkins-bot: Added missing type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149250 (owner: 10Jeroen De Dauw) [11:54:20] Tobi_WMDE_SWE_MW_WD_SMW_OSM [11:54:21] :p [11:54:53] :) [11:55:10] what's SWE? [11:56:06] Tobi_WMDE_SWE: it should, but that needs manual verification. perhaps we need a ticket for writing a browser test for this. now that the api module is merged, this is possible. [11:56:11] i'll try to verify [11:56:55] Hey everyone, I found some naming inconsistencies when looking at the external (Web-API) JSON. Can I file a request for improvement somwhere? [11:57:29] diferrumtrioxide: What kind of inconsistencies? [11:57:38] I mean in what part of it [11:58:05] diferrumtrioxide: here is a good pleace to discuss it. if you want to file a request, you can use https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions&component=WikidataRepo [11:58:42] For example when you have a value snak, in every value the type-field is called "type" except in wikibase-item, where it is called "entity-type" [11:58:57] hoo: it's nice and consistent, but when and why would the setting look like this? [11:59:17] DanielK_WMDE_: Because I think it should be consistent with repo [11:59:22] same name, same content [11:59:32] so, just consistency, no concrete need? [11:59:46] which is fine, i just want to know [11:59:49] well, on repo + client wikis you can only have one value for that setting [12:00:00] it's a lib setting [12:00:38] Also I find it obscure to ahve two values for the *same* setting just because we only support the magic on in repo [12:00:43] that would be wrong to me [12:01:01] diferrumtrioxide: wikibase-item should also have a "type" plus possibly an "entity-type". these are not on the same level. one denotes the type of the value, the other the type of the target. [12:01:15] let me look at the structure though [12:01:20] let me check [12:01:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149291 (owner: 10Thiemo Mättig (WMDE)) [12:03:36] Oh wait. I just saw, what is going on here. Never mind this one. [12:03:55] Overlooked, that the whole thing is nested again [12:06:27] Another one: the spelling of globe(-)coordinate [12:06:27] "datatype": "globe-coordinate", [12:06:27] "datavalue": { … }, [12:06:27] "type": "globecoordinate" [12:07:46] yeah, that's a thing we have on the list for ages :S [12:07:55] pretty sure there's a bug about this [12:08:05] at least we discussed that before [12:08:45] Also: "wikibase-item" vs. "wikibase-entity" [12:08:45] "datatype": "wikibase-item", [12:08:45] "datavalue": { … }, [12:08:45] "type": "wikibase-entityid" [12:09:39] Okay, since I am involved with JSON export for the WDTK, would it be considered a feature if I export a consistent naming? [12:10:38] (Which would probably force the people on the other end to support this too eventually) [12:12:36] mh? Do you plan to convert our json dumps into your format? [12:12:40] I'm confused now [12:14:32] no :) I just meant that when I export JSON, I name globe(-)coordinates consistently [12:15:25] (same goes for wikidata-item vs wikidata-entity: I suppose it would be better to decide upon one way of calling it) [12:15:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 [12:16:29] Tobi_WMDE_SWE, JeroenDeDauw, Lydia_WMDE: this seems to be a blocker for the deployment of the new serialization code. [12:17:37] diferrumtrioxide: value types are different from data-types. for instance, the value type of a url is "string", but the data-type is "url". the value type is about the internal structure only, the datatype tells you the interpretation. [12:18:00] diferrumtrioxide: the fact that we have some stuff with hyphens and some stuff without, and even use CamelCase in some places, is of course not nice. [12:18:43] but the value type wikidata-entity is not the same as the data type wikidata-item. [12:19:25] diferrumtrioxide: for practical purposes, use the value type to know how to construct an object from the data, and the data type to know what to do with it. [12:19:59] storage and indexing is bount to the value type. rendering and validation is bound to the data type. [12:20:38] (it took me months to get this streight in my head. we really should have this written down nicely somewhere) [12:20:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/673a39b : Jeroen De Dauw The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30831057 [12:21:43] Isn't that a bit redundant? When I see "datatype":"wikibase-item", I already know, that the value is a "type":"wikibase-entity" with the "entity-type":"item" [12:22:04] [13WikidataBrowserTests] 15tobijat created 06move_files (+1 new commit): 02http://git.io/pUCU5Q [12:22:04] 13WikidataBrowserTests/06move_files 1447fbe3b 15Tobias Gritschacher: Move files to tests/browser/ [12:22:26] diferrumtrioxide: yes, it's redundant. you can always derive the value type from the data type. [12:22:34] Or ist the Intention that you can also interprete JSON snippets without more context [12:22:39] [13WikidataBrowserTests] 15tobijat opened pull request #2: Move files to tests/browser/ (06master...06move_files) 02http://git.io/petpgw [12:23:25] diferrumtrioxide: yes. in particular, the value serialization is independant of wikibase/wikidata, and should be usable elsewhere. it doesn't know anything about data values. [12:23:41] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/loTK_Q [12:23:41] 13WikidataBrowserTests/06master 1421cf37b 15Tobi Gritschacher: Merge pull request #2 from wmde/move_files... [12:24:47] diferrumtrioxide: whatever you do, don't mess with the identifiers. stay consistent. ugly and redundant is better than inconsistent and confusing. [12:25:39] with "stay consistent" i mean "stay consistent with what wikidata does, don't 'improve' the identifers". that only breaks compatibility, and makes things more confusing. [12:25:51] Okay. will stick to the current notation. [12:27:46] yeah, agree with Daniel here [12:27:57] It just came to my mind: Does one even need the "datatype"-field? Everything you need to know is in "datavalue" -> "type" and even more precise [12:28:47] (Sorry for re-raising already zombiefied discussions btw.) [12:29:28] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/Q4Pj1A [12:29:28] 13WikidataBrowserTests/06master 140ed18a1 15Tobias Gritschacher: Update .gitignore file [12:29:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/dace5ef : Jeroen De Dauw The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30831228 [12:30:23] So, I've beat the property suggester. https://www.wikidata.org/wiki/Q183509 [12:35:40] DanielK_WMDE_: https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/30831232 [12:35:43] you broke travis :P [12:35:49] diferrumtrioxide: we didn't have the datatype in the serialization in the beginning. it was a royal pain, because if you wanted to to anything with the value, you first had to load the associated proeprty definition to find out the datatype. [12:35:56] hoo: not again. [12:36:12] but actually, master seems broken for me. can't edit. [12:36:13] 1) Wikibase\Test\Api\CreateRedirectModuleTest::testSetRedirect_failure with data set "can't redirect" ('P11', 'P12', 'cant-redirect') [12:36:14] Wikibase\Lib\Store\StorageException: Entity type does not support redirects: property [12:37:38] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/162f855 : Thiemo Mättig The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30831387 [12:37:54] hoo: uh... that's the *expected* error in that test?... wtf? [12:38:01] DanielK_WMDE: I have to rely on your experiences here. [12:38:08] DanielK_WMDE_: UsageException [12:38:20] the api should not let StorageExceptions bubble up [12:38:27] huh. [12:38:44] i wonder why that only fails on travis? not on jenkins? that's quite strange. [12:38:50] DanielK_WMDE_: thanks! [12:38:59] was the exception moved? so the catch clause now catches an exception that doesn't exist? [12:39:03] was the exception moved? so the catch clause now catches an exception that doesn't exist? [12:40:09] no, doesn't seem like that [12:40:37] well, what [12:40:42] actually it should catch them [12:41:05] (03PS1) 10Thiemo Mättig (WMDE): [WIP] All date formats in all languages should roundtrip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 [12:41:07] hoo: nope. wrong namespace. the exception got moved to a different namespace. [12:41:11] fixing [12:41:17] indeed [12:43:23] (03PS1) 10Daniel Kinzler: Fix wrong namespace for StorageException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149295 [12:45:36] (03CR) 10Hoo man: [C: 032] Fix wrong namespace for StorageException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149295 (owner: 10Daniel Kinzler) [12:45:43] (03Merged) 10jenkins-bot: Fix wrong namespace for StorageException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149295 (owner: 10Daniel Kinzler) [12:46:03] hoo: oh, and i moved it myself. the api module got merged without having jenkins run on a rebased version. [12:46:21] jenkins should *always* rebase against master before running tests. especially gateway tests. *sigh* [12:51:47] getting this on master: [12:51:53] Fatal error: Class 'Wikibase\DataModel\LegacyIdInterpreter' not found in /var/www/daniel/wikidata/extensions/Wikibase/lib/includes/store/sql/TermSqlIndex.php on line 723 [12:52:07] *sigh* [12:52:17] test fails too [12:52:23] that's why I usually rebase before merging [12:53:01] hm, maybe composer update will fix it [12:53:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [12:53:08] i think zuul does rebase on wmf jenkins [12:53:13] we don't use zuul for wikidata jenkins [12:53:17] aude: Yeah, but we don#t [12:53:28] all the more reason to move back :) [12:53:33] ++ [12:53:43] ok, composer update fixed it. sorry for the noise. [12:54:30] ok, at least something :) [12:57:51] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149295 (owner: 10Daniel Kinzler) [12:58:58] omg, found a core bug [13:00:33] the existence is bad, the finding is great [13:01:22] lazowik: SWE = software engineering [13:01:52] there's another tobi in the office and I'm tired of getting the wrong messages directed to me.. :-P [13:01:53] uck, bug is on test.wikidata [13:02:05] ah [13:02:07] must not be on wikipedia yet [13:02:17] https://test.wikidata.org/w/index.php?title=Q22&action=revisiondelete&ids%5B7062%5D=1 [13:02:29] can probably quickly fix [13:08:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/36a205e : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30835322 [13:17:42] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/38642bd : daniel The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30838769 [13:19:40] (03PS2) 10Thiemo Mättig (WMDE): Only use date formats that can roundtrip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 [13:21:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use Fingerprint::setLabel for now [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149233 (owner: 10Jeroen De Dauw) [13:21:42] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use Fingerprint::setLabel for now [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149233 (owner: 10Jeroen De Dauw) [13:23:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I will create a follow-up." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149228 (owner: 10Jeroen De Dauw) [13:23:56] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149228 (owner: 10Jeroen De Dauw) [13:24:55] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Since all tests succeed, what could possibly go wrong? ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149226 (owner: 10Jeroen De Dauw) [13:25:04] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use Entity::toArray [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149226 (owner: 10Jeroen De Dauw) [13:25:28] (03CR) 10Hoo man: [C: 032] Add missing type hints [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149291 (owner: 10Thiemo Mättig (WMDE)) [13:25:36] (03Merged) 10jenkins-bot: Add missing type hints [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149291 (owner: 10Thiemo Mättig (WMDE)) [13:26:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149227 (owner: 10Jeroen De Dauw) [13:26:21] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use EntityId constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149227 (owner: 10Jeroen De Dauw) [13:27:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [13:34:34] (03PS1) 10Thiemo Mättig (WMDE): LegacyIdInterpreter::newIdFromTypeAndNumber is static [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149309 [13:42:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149309 (owner: 10Thiemo Mättig (WMDE)) [13:43:40] (03CR) 10Eranroz: [C: 031] Only use date formats that can roundtrip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [13:45:40] (03PS2) 10Thiemo Mättig (WMDE): Rename wrongly named EntityRevisionLookup $entityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 [13:45:50] Thiemo_WMDE: ur on a flow? :p [13:46:25] JeroenDeDauw is to blame, he did a hell lot of very small changes. easy to review. :) [13:53:18] (03CR) 10Hoo man: [C: 04-1] "Shouldn't this rather use some other way to compare the expected data? Just removing this doesn't seem like a good idea to me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149229 (owner: 10Jeroen De Dauw) [13:53:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 (owner: 10Thiemo Mättig (WMDE)) [14:00:13] (03PS3) 10Thiemo Mättig (WMDE): Rename wrongly named EntityRevisionLookup $entityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 [14:00:57] (03CR) 10Daniel Kinzler: "the same should be done in onSpecialRecentChangesFilters and onSpecialWatchlistFilters, I suppose? Do you want to make a separate patch fo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148985 (https://bugzilla.wikimedia.org/68463) (owner: 10Aude) [14:03:38] (03CR) 10Aude: "@daniel y u no review https://gerrit.wikimedia.org/r/#/c/148732/ ? :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148985 (https://bugzilla.wikimedia.org/68463) (owner: 10Aude) [14:03:48] (03CR) 10Daniel Kinzler: [C: 031] "+2, but waiting for jenkins..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 (owner: 10Thiemo Mättig (WMDE)) [14:04:57] (03CR) 10Daniel Kinzler: "@aude y u no add me as reviewer? ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148985 (https://bugzilla.wikimedia.org/68463) (owner: 10Aude) [14:05:03] heh [14:05:48] (03CR) 10Daniel Kinzler: [C: 032] Don't show wikibase recent changes / watchlist pref if feature disabled [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148985 (https://bugzilla.wikimedia.org/68463) (owner: 10Aude) [14:05:56] (03Merged) 10jenkins-bot: Don't show wikibase recent changes / watchlist pref if feature disabled [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148985 (https://bugzilla.wikimedia.org/68463) (owner: 10Aude) [14:06:02] yay [14:06:24] aude: Merge the other projects default settings stuff now maybe? :P [14:06:37] i'm looking at revisiondelete [14:06:43] after that [14:07:06] think i understand the bug (it's looking in archive table for a revision that is in revision table) [14:08:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 (owner: 10Thiemo Mättig (WMDE)) [14:11:17] (03PS2) 10Thiemo Mättig (WMDE): LegacyIdInterpreter::newIdFromTypeAndNumber is static [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149309 [14:12:28] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Per Daniel." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 (owner: 10Thiemo Mättig (WMDE)) [14:12:36] (03Merged) 10jenkins-bot: Rename wrongly named EntityRevisionLookup $entityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143375 (owner: 10Thiemo Mättig (WMDE)) [14:15:38] (03CR) 10Thiemo Mättig (WMDE): Code style cleanup in wbcreateredirect API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149286 (owner: 10Thiemo Mättig (WMDE)) [14:17:04] (03CR) 10Daniel Kinzler: [C: 04-1] "Per hoo: passing around a special page is bad unless we REALLY need it." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude) [14:18:58] (03CR) 10Aude: Make hide/show changes toggle respect showExternalRecentChanges setting (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude) [14:19:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149309 (owner: 10Thiemo Mättig (WMDE)) [14:19:50] Thiemo_WMDE: did you get my email? :) [14:33:15] (03PS8) 10Aude: Make hide/show changes toggle respect showExternalRecentChanges setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) [14:37:15] Does anyone have a rather smallish, fast to read tutorial/ how to on how to write decent code at hands? [14:37:24] Eg. what should be in a class and how should it be coupled [14:37:33] should be really short and only needs the basics [14:38:15] I think there really is a need for this, I keep seeing fundamental mistakes being done at a few places, thus I would like to have something I can give them [14:38:25] so that I don't need to teach through CR :P [14:41:54] hoo: http://www.phptherightway.com/ [14:41:59] might be a good starting point [14:42:40] (03CR) 10Daniel Kinzler: "Context is still a kitchen sink that depends on most of core. It would be really good to avoid that dependency." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude) [14:44:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude) [14:44:08] aude: Nice... didn't know that [14:44:21] there's some relevant information there, but also quite some irrelevant [14:44:28] (03CR) 10Aude: "@daniel do you want the construction code from the hook parameters to this handler to be untested?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude) [14:44:32] hoo: sure [14:44:37] would prefer something which is coding styles only, but that's good for a start [14:45:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149282 (owner: 10WikidataBuilder) [14:47:03] (03CR) 10Daniel Kinzler: [C: 04-1] "I would prefer to address the issue the other way around: make the parser apply an unlocalization step that deals with separators (the sep" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [14:53:44] (03CR) 10Thiemo Mättig (WMDE): Introduce wbcreateredirect API module (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [14:55:03] (03CR) 10Daniel Kinzler: "I take that as a "yes", since that's what I meant ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [14:58:06] (03CR) 10Daniel Kinzler: [C: 031] "@aude: I see your point, but still feels bad. I suppose the issue is really that the hook itself has a bad signature, which the handler no" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148732 (https://bugzilla.wikimedia.org/68461) (owner: 10Aude) [15:00:37] (03CR) 10Hoo man: Make "otherProjectsLinks" setting compatible with the "special" sitelink group (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [15:01:05] (03PS3) 10Hoo man: Make "otherProjectsLinks" setting compatible with the "special" sitelink group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 [15:01:33] (03CR) 10Hoo man: "Addressed Daniel's naming comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [15:03:07] Thiemo_WMDE, aude, hoo: anything to review? [15:03:26] DanielK_WMDE_: The other projects thing... it would be awesome to finally get that fully done [15:03:47] * aude about to merge it [15:03:52] \o/ [15:04:22] (03CR) 10Aude: [C: 032] "looks good, manually verified + the tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [15:04:27] have to look at the follow up [15:04:30] (03Merged) 10jenkins-bot: Provides a default to otherProjectsLinks configuration parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [15:04:59] Lydia_WMDE, Tobi_WMDE_SWE: if there's nothing left, i'd like to work on https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 [15:05:10] i estimate 8 points for that. [15:05:21] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/149263/ [15:05:26] https://gerrit.wikimedia.org/r/#/c/149264/ [15:05:27] alternatively, i could work on refactoring wbmergeitems, so we can add redirect creation to that more easily. [15:05:28] DanielK_WMDE_: yeah that sounds good given we want the serialization switch out soon [15:05:49] that's also good but this one seems more important? [15:05:50] trying to make the tests better structured [15:06:05] Lydia_WMDE: btw, did you put "rdf binding" on the feature wall? it has been half-done for more than a year now... [15:06:14] DanielK_WMDE_: jep :) [15:06:19] thanks :) [15:06:21] it's all pretty and green :P [15:06:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 is good one [15:06:36] imho [15:06:50] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I find your comment a bit misplaced. This is a formatter, not a parser. Sure, some day our TimeParser should be able to understand Portugu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [15:07:03] DanielK_WMDE_: ping: https://gerrit.wikimedia.org/r/#/c/149294/ [15:07:13] DanielK_WMDE_: i am setting it to assigned and am adding it to the sprint [15:09:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [15:10:05] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Refactor MonthNameUnlocalizer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148122 (owner: 10Thiemo Mättig (WMDE)) [15:11:58] Lydia_WMDE: thanks [15:15:48] Thiemo_WMDE: i'm continually surprised by how complicated the date parsing stuff is. since we do month name unlocalization, we should be able to handle "1 de janeiro de 2014" using the simple pattern , no? [15:16:08] That's the solution I would have suggested for fixing the reound trip problem. [15:17:13] Thiemo_WMDE: what you are doing to removes much of the locale dependent stuff again from the formatted date, especially the separators. [15:18:23] If we do that, we can just as well go back to 'j F Y'. [15:18:45] if getting the date back out of the localized version is so hard, I'm sorry I ever suggested doing it. [15:18:52] what? [15:19:20] it's not "hard". it just needs lots and lots of tests. i always said that. [15:19:59] i want and i will improve the date parsers in the way you suggested. but not in this patch. [15:20:50] Thiemo_WMDE: that's fine, but this new patch reduces the localization aspect to a minimum, by doing acrobatics wioth the format string. it makes me wonder whether we shouldn't just go back to what we had originally. [15:21:12] are there any relevant aspects of localization left [15:21:34] ? [15:22:19] hm... leading zeros or no... month in genitive or not... that's it, right? [15:22:24] some languages have in front, some in the back, some add suffixes to the numbers, sometime even to the year. all this needs to be parsed in the dateparsers, yes. but not now. [15:23:05] the code has comments for all your questions. [15:23:09] i'm not saying that must be done in this patch. i'm saying that if the parser can't handle any of that, maybe it's better to apply no localiuzation after all. [15:23:12] how about 2014 april 16 ? [15:23:42] thats not dmy. we are currently fixed to dmy. [15:24:11] for parsing, too? i thought the parser was (trying to be) smart about that [15:24:14] but anyway... [15:24:42] DanielK_WMDE_: day with/without leading zeros, month in normal/genitive/abbreviation form, both with optional dots/commas. oh, i forgot numeric months. [15:24:44] * aude wants to support https://en.wikipedia.org/wiki/Tabular_Islamic_calendar :) [15:24:47] someday [15:24:54] arwiki uses it [15:25:19] Thiemo_WMDE: dots and commas, but not dashes or slashes? they are very common. [15:25:35] DanielK_WMDE_: you continue to confuse me. none of my patches changes the fact that we are applying localization. [15:26:03] dots and commans only because of the enforced spaces. come on, thats simple. [15:27:43] yes, our parsers are able to understand more that just the dmy order. but the formatter is currently fixed to this order and i'm not changing that today. [15:28:02] i'm not suggesting you change that [15:30:06] Thiemo_WMDE: i'm trying to understand the reasoning behind these decisions. some of them seems strange to me. But ok. We go from hardly-localized to a-bit-more-localized, because our parser doesn't like fully localized. [15:30:39] maybe we could do fully localized for html and wikitext output, and be restrictive only for pülain text? only plain text needs to round trip... [15:30:42] but that's just a side note. [15:30:56] not sure i'd like the inconsistency [15:32:19] this is really painful to me at the moment. i learned that complex changes are hard to review, so i'm trying to split complicated stuff like that in very small changes. but the comments i get make me go in the other direction, making initially simple changes more and more complex. [15:33:19] how? i didn't suggest doing more in this patch, did i? [15:33:53] but it's true, if the changes are small, it'S easier to understand what they do, but harder to understand why they are done. [15:34:03] not exactly, but the answer to almost all comments is "yes, this needs to be done, but not now". [15:34:43] i was suggesting to fix the parser *instead* of limiting the formatter. and i was hoping that the corresponding fix in the parser wouldn't be *that* hard to do. [15:35:12] (03CR) 10Aude: [C: 04-1] "manually verified + tests. only have a couple nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [15:35:20] thats asking for step 2 before step 1 is done in my opinion. [15:35:25] that was the reason behind the -1: solving a parsing issue by limiting the formatter seemed bad. but if it's that much more complex to fix the parser, well then, this will do for now. [15:35:42] no, that step 2 would mean we don't need to do step 1. [15:35:55] if the parser is fixed, we don't need to "sanitize" the format string. [15:36:03] that was the idea [15:36:12] you realize i introduced a regression in the previous patch? maybe it wasn't a good idea to do this in two patches. [15:36:44] i realized too late, otherwise i wouldn't have merged the first one :/ [15:37:06] (03CR) 10Aude: [C: 032] "how about i approve and do a small follow up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [15:37:07] its not merged. https://gerrit.wikimedia.org/r/#/c/148641/3 [15:37:16] (03Merged) 10jenkins-bot: Make "otherProjectsLinks" setting compatible with the "special" sitelink group [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148993 (owner: 10Hoo man) [15:37:43] Thiemo_WMDE: oh, you are right, i approved, but it wasn't merged. i wonder why?... [15:37:55] oh, dependency. [15:37:55] silly me [15:38:35] (03PS1) 10Aude: add missing type hints in OtherProjectsSitesProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149320 [15:38:54] I would indeed not do this in two patches, then. because the first without the second will not round-trip for some languages, and *should* thus fail tests. [15:39:07] DanielK_WMDE_: Thiemo_WMDE https://gerrit.wikimedia.org/r/#/c/149320/ (would make Lydia_WMDE happy to move this to done) [15:39:59] Thiemo_WMDE: anyway - you convinced me that fixing the parser right away is too complicated. So going for a "slightly more localized" date format is all we can do for now. leaves the question whether "slight more localized" is worth the effort. [15:42:54] Thiemo_WMDE: btw, what are you trying to indicate by giving your own changes a +1? [15:43:32] 9 languages use a dot after the day = 9 languages a bit more happy. 15 use genitive month names. 3 use commas after the month. some others abreviate the month. [15:43:35] (03CR) 10Daniel Kinzler: [C: 032] "ok, thiemo convinced me that fixing the parser is too hard for now, and the slightly-more-localized date formats this provides are the bes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149294 (owner: 10Thiemo Mättig (WMDE)) [15:45:13] DanielK_WMDE_: -1 means "please improve". but you are giving -1 for things i clearly do not want to improve in the same patch set. my +1 means "looks good for me, i will not change it more, please merge". [15:45:17] (03CR) 10Aude: [C: 032] New Wikidata Build - 25/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149282 (owner: 10WikidataBuilder) [15:45:39] (03Abandoned) 10Aude: New Wikidata Build - 23/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148625 (owner: 10WikidataBuilder) [15:45:43] (03CR) 10Daniel Kinzler: "maintaining my +2, but caution: this breaks round trips for dates in some languages, unless I9aefa02a8355c9c is also merged." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148641 (owner: 10Thiemo Mättig (WMDE)) [15:46:54] Thiemo_WMDE: the tests do not assert roundtrips for all cases. why not? should it not be required in all cases? [15:47:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149320 (owner: 10Aude) [15:48:03] DanielK_WMDE_: running these tests was a pain. https://gerrit.wikimedia.org/r/#/c/131587/ [15:48:33] (03Merged) 10jenkins-bot: New Wikidata Build - 25/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149282 (owner: 10WikidataBuilder) [15:49:46] (03CR) 10Thiemo Mättig (WMDE): [C: 032] add missing type hints in OtherProjectsSitesProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149320 (owner: 10Aude) [15:49:51] (03Merged) 10jenkins-bot: add missing type hints in OtherProjectsSitesProvider [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149320 (owner: 10Aude) [15:50:33] DanielK_WMDE_: this is still blocking everything. https://gerrit.wikimedia.org/r/#/c/148113/ [15:54:09] Thiemo_WMDE: yes. and i'd still like to hear another oppinion on the issue. i'll merge it if need be, but i'm still not happy about the "lets add code and try to be strict about some stuff, but ignore other things completely" aspect. [15:55:01] hm... none of the date format stuff was in the sprint, right? [15:55:19] do we need to discuss this again? your alternative approach is not better. it just replaces some edge cases with others. [15:55:31] i guess it was supposed to be quick and easy. gets me every time, too. [15:56:10] Thiemo_WMDE: right - other edge cases, not worse, but less code. no, we should not discuss it again. [15:56:14] no, i picked this because of the patch that would have broken the stuff in all languages but the 15 that use genitive. [15:56:48] yea, i know. still, drained a lot of resources that are not accounted for in the sprint stats. [15:56:51] worse and the same amount of code and magic. [15:57:22] have you asked someone else to review? [15:57:42] not explicitly. [15:58:11] it is quick and easy. i still dont understand why you are making this such a pain. [15:59:50] because it's only quick and easy from your perspective. from mine, it makes my head hurt. i have made this experience over and over: saomething that looks quick & obvious to me turned into a two-sprint ordeal with 30 patch sets. [16:00:27] we already wasted several hours discussing a single line of code. and it blocks more and more changes. [16:01:05] so get someone else to look at that line, see if that goes better. [16:01:26] again, you do NOT need to understand the line. why dont you look at the tests? if you want you can try to add more test cases and find one that behaves wrong in your opinion. why dont you do it this way? [16:02:10] there are already several in the test suite that behave wrong in my oppinion. [16:02:17] it's just defined as expected behavior. [16:02:52] whats "wrong" there? [16:05:24] in my oppinion? all the "let's keep the original even if we could replace something" cases. but as i said: no need to discuss this further. i don't *have* to like it. i'll merge it if there is no one else willing to look at it. [16:05:30] but another opinion would be good. [16:06:03] anyway. i'm off for some hours. 6pm -> family time. promised the kids. may be back later tonight. [16:06:21] please be specific. which test case should have which output? [16:06:45] we can do that on monday if you really want to. [16:07:19] i guess you are referring to the edge cases. but there is no "right" or "wrong" in these cases. [16:07:49] the parser step just needs to do _something_ that doesn't make things worse. [16:08:31] the most simple thing possible that doesn't make things worse. that's the whole point. [16:08:42] thats what my code does. [16:09:40] please show me an ok-ish date input that can not be parsed because of my patch. I'm afraid this is the only way to convince me. [16:18:35] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/149282 (owner: 10WikidataBuilder) [17:38:25] (03CR) 10Thiemo Mättig (WMDE): "Hoo, can you please explain what you expect? Or even better, just merge this and do a follow-up?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [17:51:17] Have I added these RfD' correctly? https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#5_duplicate_taxons [17:51:24] RfD's* [17:52:33] There is no right or wrong way to do it [17:53:27] If there isn't a wrong way, all ways are right! [17:53:38] Good [17:55:38] Can I enter the birthday of someone without the year, or does the system not like that? [17:56:51] Lydia_WMDE: ^ [18:08:43] sjoerddebruin: you can't [18:09:16] Ok [18:37:16] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "As far as I can tell this was a test to make sure that Entity::toArray() and the LegacyInternalEntitySerializer are compatible. Right? If " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149237 (owner: 10Jeroen De Dauw) [18:40:41] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "You should not simply delete all these test cases. Who will re-add them? Please keep the data provider, mark the test method with $this->m" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149232 (owner: 10Jeroen De Dauw) [18:42:03] sjoerddebruin: yeah not possible unfortunately with that datatype [18:42:13] :( [18:42:33] it'd completely screw with precision and so on [18:42:35] :/ [18:43:20] So we must wait till people die, likely... [18:43:29] heh [18:44:15] I make people die the whole day... [18:44:15] (03CR) 10Thiemo Mättig (WMDE): [C: 032] DM 1.0 compat: do not use DataModel\Internal\ObjectComparer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149231 (owner: 10Jeroen De Dauw) [18:44:20] Adding statements. :P [18:44:27] (03Merged) 10jenkins-bot: DM 1.0 compat: do not use DataModel\Internal\ObjectComparer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149231 (owner: 10Jeroen De Dauw) [18:44:33] A lot of zombies still... [18:44:36] ;-) [18:48:41] lol [19:15:14] (03PS1) 10Thiemo Mättig (WMDE): Remove temporary performance hack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149385 [19:25:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149385 (owner: 10Thiemo Mättig (WMDE)) [21:06:53] hmm [21:08:53] hm? [21:12:10] hmm hmm [21:15:43] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/149446 (owner: 10L10n-bot) [21:16:22] HA [21:16:33] just take a look at that :D [21:16:34] http://repo.data.d610.pl/wiki/Item:Q2 [21:29:55] lazowik: badges ;p [21:30:01] yeah [21:30:11] but now can't get client css to show up [21:30:22] http://client.data.d610.pl/wiki/Polska [21:32:56] addshore: btw. I have two mediawikis and a phabricator with it's deamons running [21:33:01] on 0.5G of RAM [21:33:08] of course traffic is ~NULL [21:33:15] but still [21:35:26] :P [21:35:57] benestar|cloud: heeeeelp [21:36:20] do I need anything other than $wgWBClientSettings['badgeClassNames'] [21:36:29] to make badges show up on client? [21:36:39] (of course apart from css that does sth)