[00:21:18] (03CR) 10Jeroen De Dauw: [C: 032] Split parser function rendering and snaks finding code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [00:22:15] (03CR) 10Jeroen De Dauw: [C: 032] Move more parser function rendering code to Renderer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148064 (owner: 10Aude) [00:22:45] (03PS3) 10Jeroen De Dauw: Introduce VariantsRenderer for property parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [00:22:50] (03PS2) 10Jeroen De Dauw: Move more renderer construction code into RendererFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148103 (owner: 10Aude) [00:22:54] (03PS2) 10Jeroen De Dauw: Move property id resolving code for parser function into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [00:24:38] aude: now your chain is only 3 long, way under 9000 [00:28:00] (03CR) 10Jeroen De Dauw: "Not fully reviewed yet. +0.42 so far" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [00:28:48] arrr, whats with all those commit chains >_> [00:30:50] Pirate Day is coming [00:31:08] (03CR) 10Jeroen De Dauw: "I rather see this improved before it's merged. However, as this appears to not go happen, I indeed void my -1. In case of this commit the " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [00:36:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [00:36:33] (03CR) 10Jeroen De Dauw: [C: 032] Roundtrip tests for Lib\Serializers vs. DataModelSerialization (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [00:37:04] (03Merged) 10jenkins-bot: Roundtrip tests for Lib\Serializers vs. DataModelSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [00:37:58] (03CR) 10Jeroen De Dauw: "The options are not something that is blocking switching the internal format over to use the new serialization implementation AFAIK. Will " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [00:44:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148103 (owner: 10Aude) [00:49:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [09:23:25] (03PS3) 10Aude: Move property id resolving code for parser function into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 [09:25:34] aude: hello [09:25:42] aude: I think some of your instances have role::beta::natfix applied [09:25:56] which rewrite some IP packets to be able to access *.beta.wmflabs.org instances [09:26:01] yay [09:26:05] it is no more needed and the class is going to be removed [09:26:14] the change has been made directly in the labs DNS server [09:26:15] oh, ok [09:26:25] so it yields the private IP when queried from a labs instance [09:26:35] sounds good [09:26:47] the removal is https://gerrit.wikimedia.org/r/#/c/146091/ [09:26:49] yeah it is way better [09:27:10] Brandon Black showed up one night and told me it was much easier to handle it in DNS and the server had build in support for it [09:27:15] so he just did it \O/ [09:27:23] makes sense [09:29:00] [13WikibaseQuery] 15jayvdb opened pull request #41: Set XML name for array members (06master...06master) 02http://git.io/4DUhLQ [09:32:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148125 (owner: 10Aude) [09:40:39] (03CR) 10Hoo man: [C: 04-1] "Although this has an own namespace now, I still would like to see the class name changed (not sure my naming ideas are better though :P)." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [09:42:03] (03CR) 10Hoo man: Introduce VariantsRenderer for property parser function (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [09:43:11] (03CR) 10Aude: "let's have a naming contest :) suggestions?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148096 (owner: 10Aude) [10:00:31] (03PS1) 10WikidataBuilder: New Wikidata Build - 22/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148340 [10:12:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148340 (owner: 10WikidataBuilder) [10:17:09] (03CR) 10Aude: [C: 032] New Wikidata Build - 22/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148340 (owner: 10WikidataBuilder) [10:20:24] (03Merged) 10jenkins-bot: New Wikidata Build - 22/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148340 (owner: 10WikidataBuilder) [10:23:02] (03PS1) 10Aude: Don't end JSON snippets with new lines [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148344 [10:24:00] hi :) [10:24:45] (03CR) 10Tobias Gritschacher: "This is getting extremely frustrating for a lot of people now. We need to find a way to get this unstuck asap. I think the new API module " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [10:31:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148344 (owner: 10Aude) [10:31:31] addshore: ping [10:31:36] addshore: https://github.com/DataValues/Time/commits/addParseAndFormat [10:32:11] wouldn't it be better to do this in small steps than in one big go? [10:42:44] (03CR) 10Aude: [C: 032] Don't end JSON snippets with new lines [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148344 (owner: 10Aude) [10:43:28] (03CR) 10Aude: [C: 032] Declare that wikibase.ValueViewBuilder depends on wikibase [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147452 (owner: 10Hoo man) [10:43:56] (03CR) 10Aude: [C: 032] Bump ValueView to 0.6.6 [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147468 (owner: 10Hoo man) [10:45:37] (03Merged) 10jenkins-bot: Don't end JSON snippets with new lines [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148344 (owner: 10Aude) [10:45:39] (03Merged) 10jenkins-bot: Declare that wikibase.ValueViewBuilder depends on wikibase [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147452 (owner: 10Hoo man) [10:45:41] (03Merged) 10jenkins-bot: Bump ValueView to 0.6.6 [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147468 (owner: 10Hoo man) [10:48:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/mw1.24-wmf14/f9cb380 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/30540302 [10:49:30] aude: mh... [10:50:36] (03PS1) 10Hoo man: Fix installing PHPUnit 3.7 via composer (on travis) [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148351 [10:50:50] (03CR) 10Hoo man: [C: 032 V: 032] Fix installing PHPUnit 3.7 via composer (on travis) [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148351 (owner: 10Hoo man) [10:54:09] (03CR) 10Thiemo Mättig (WMDE): Roundtrip tests for Lib\Serializers vs. DataModelSerialization (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138790 (owner: 10Thiemo Mättig (WMDE)) [10:57:14] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "> please consider bug 68325." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [10:58:52] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148351 (owner: 10Hoo man) [11:02:35] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/148340 (owner: 10WikidataBuilder) [12:22:22] (03PS1) 10Aude: Update Wikidata, js fixes and for json dumps [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148364 [12:33:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148364 (owner: 10Aude) [12:43:51] [travis-ci] wmde/WikibaseQueryEngine/idparser/70b9b8b : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/30548869 [12:45:14] (03CR) 10Aude: [C: 032] Update Wikidata, js fixes and for json dumps [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148364 (owner: 10Aude) [12:48:22] (03Merged) 10jenkins-bot: Update Wikidata, js fixes and for json dumps [extensions/Wikidata] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/148364 (owner: 10Aude) [12:50:26] [13WikibaseQuery] 15thiemowmde created 06idparser (+1 new commit): 02http://git.io/g3zQJQ [12:50:26] 13WikibaseQuery/06idparser 14bce38d0 15Thiemo Mättig: Drop unused ID parser [12:51:01] [13WikibaseQuery] 15thiemowmde opened pull request #42: Drop unused ID parser (06master...06idparser) 02http://git.io/ukoQpQ [12:51:41] [13WikibaseQuery] 15thiemowmde 04force-pushed 06idparser from 14bce38d0 to 1466d362e: 02http://git.io/Ty5KLQ [12:51:41] 13WikibaseQuery/06idparser 1466d362e 15Thiemo Mättig: Drop unused ID parser [12:57:13] [travis-ci] wmde/WikibaseQuery/idparser/bce38d0 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/30550009 [13:02:31] [travis-ci] wmde/WikibaseQuery/idparser/66d362e : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/30550125 [14:01:35] (03CR) 10Hoo man: [C: 04-1] Cleanup EntityView, SectionEditLinkGenerator and related (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [14:06:32] (03PS1) 10Alex Monk: Put a link to the entity's canonical URI in the toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) [14:09:14] could someone please have a look at https://gerrit.wikimedia.org/r/148093 [14:09:21] annoying to have stuff broken on master [14:10:10] (03PS2) 10Alex Monk: Put a link to the entity's canonical URI in the toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) [14:12:38] (03PS3) 10Alex Monk: Put a link to the entity's canonical URI in the toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) [14:16:14] (03CR) 10Hoo man: Put a link to the entity's canonical URI in the toolbox (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:16:33] (03CR) 10Hoo man: [C: 04-1] "per PS1" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:19:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:26:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:31:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:32:50] (03CR) 10Alex Monk: Put a link to the entity's canonical URI in the toolbox (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:32:52] (03PS4) 10Alex Monk: Put a link to the entity's canonical URI in the toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) [14:34:15] [travis-ci] wmde/WikibaseQueryEngine/empty-catch/eb53f49 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/30558495 [14:41:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [14:47:32] (03CR) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [14:48:04] (03PS13) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [14:48:14] (03PS14) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [14:48:35] (03PS11) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [14:59:13] (03PS2) 10Daniel Kinzler: Split the applyRedirect method for readability. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 [15:01:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:06:43] [travis-ci] wmde/WikibaseQueryEngine/coverage/ed91068 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/30561368 [15:11:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:16:58] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [15:21:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 (owner: 10Daniel Kinzler) [15:22:10] [13DataValuesJavascript] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/VPhT2Q [15:22:10] 13DataValuesJavascript/06master 14995f272 15Marius Hoch: Merge pull request #45 from wmde/unname... [15:27:51] (03PS15) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [15:28:02] (03PS12) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [15:28:07] (03PS3) 10Daniel Kinzler: Split the applyRedirect method for readability. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 [15:28:15] [13DataValuesJavascript] 15mariushoch closed pull request #43: [WIP] Get rid of "evilsSeed is not defined" (06master...06evil) 02http://git.io/6-8O7g [15:29:40] [13DataValuesJavascript] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/ILwRFA [15:29:40] 13DataValuesJavascript/06master 1485b434a 15Marius Hoch: Merge pull request #44 from wmde/julian... [15:32:01] (03CR) 10Aude: [C: 04-1] "nitpicks about unclear names" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [15:32:36] [13DataValuesJavascript] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/_BPCFg [15:32:36] 13DataValuesJavascript/06master 14d414c17 15Marius Hoch: Merge pull request #42 from wmde/one-degree... [15:32:43] [13DataValuesJavascript] 15mariushoch 04deleted 06one-degree at 14f70e434: 02http://git.io/g3dTSQ [15:32:51] (03CR) 10Aude: Resolve redirects in JS config variables. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [15:36:00] (03PS3) 10Thiemo Mättig (WMDE): Fix triggering of 'restrictEntityPageActions' and 'blockEntityPageActions' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) (owner: 10Hoo man) [15:38:23] (03CR) 10Hoo man: [C: 031] Fix triggering of 'restrictEntityPageActions' and 'blockEntityPageActions' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) (owner: 10Hoo man) [15:39:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:43:15] (03PS13) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [15:43:29] (03PS4) 10Daniel Kinzler: Split the applyRedirect method for readability. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 [15:43:49] (03CR) 10jenkins-bot: [V: 04-1] Split the applyRedirect method for readability. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 (owner: 10Daniel Kinzler) [15:44:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:44:58] (03Merged) 10jenkins-bot: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:48:43] (03PS14) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [15:51:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [15:54:44] (03PS5) 10Daniel Kinzler: Split the applyRedirect method for readability. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 [16:00:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 (owner: 10Daniel Kinzler) [16:07:30] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I would love to see this live. Thanks for the patch. Just some minor details." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [16:10:14] [13DataValuesJavascript] 15thiemowmde reopened pull request #43: [WIP] Get rid of "evilsSeed is not defined" (06master...06evil) 02http://git.io/6-8O7g [16:10:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148093 (https://bugzilla.wikimedia.org/68322) (owner: 10Hoo man) [16:10:49] (03PS5) 10Alex Monk: Put a link to the entity's canonical URI in the toolbox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) [16:17:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [16:19:19] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/HLwYOw [16:19:19] 13DataValuesJavascript/06master 141772741 15thiemowmde: Update README.md [16:19:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 (owner: 10Daniel Kinzler) [16:24:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [16:29:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146063 (owner: 10Daniel Kinzler) [16:34:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [16:41:49] JohnLewis: fix your connection pl0x [16:54:11] [travis-ci] wmde/WikibaseQueryEngine/base-tests/229edc4 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/30570584 [17:18:57] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=68386 [17:19:22] thx [17:39:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148376 (https://bugzilla.wikimedia.org/54275) (owner: 10Alex Monk) [17:41:05] Thiemo_WMDE: hoo https://github.com/wmde/WikibaseQueryEngine/pull/91 [17:43:33] JeroenDeDauw: Will merge once travis passed [17:52:31] [travis-ci] wmde/WikibaseQueryEngine/idparserfu/8a084ed : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/30576618 [18:07:20] Fatal error: Base lambda function for closure not found in /usr/local/apache/common-local/php-1.24wmf14/extensions/Wikidata/extensions/Wikibase/lib/config/WikibaseLib.default.php on line 18 [18:07:24] aude: ^^ [18:07:30] wtf! [18:08:19] lolwat [18:08:27] Reedy: you broke PHP! [18:09:00] I'm gonna revert [18:09:05] it's getting more and more frequent [18:09:05] ok [18:09:19] revert non wikipedias to 1.24wmf14 that is [18:10:27] ok [18:11:12] Not poked at the logs yet [18:11:22] why test.wikidata is not broken, no clue [18:12:35] could be an out of sync apache or 2 [18:13:09] they are mw1081 [18:13:30] Cirrus errors too? [18:14:46] nope [18:16:07] don't see anything obvious wrong with cirrus [18:22:19] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=68386 should be fixed asap, but suppose tomorrow is ok [18:22:28] ugly [18:22:50] aude: thx [18:26:47] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/xAL7Jg [18:26:47] 13WikibaseQuery/06master 1404cde54 15Jeroen De Dauw: Update RELEASE-NOTES.md [18:29:25] aude: where exactly? [18:29:31] (the bug you mentioned) [18:30:13] in the suggestions menu (on test.wikidata) [18:30:24] and unfortunately will be on wikidata until we fix :/ [18:30:46] doesn't affect functionality but is ugly and harder to see the suggestions [18:30:47] aude: Thanks. Confirmedm mw1081 was the source for the wikidata issues [18:30:51] Reedy: thanks [18:30:57] hmm [18:31:02] I can't reproduce [18:31:05] when I've deployed the cirrus fix I'll push it back again [18:31:09] ok [18:31:23] https://test.wikidata.org/wiki/Q22 for example [18:31:45] click "add" for a new statement [18:31:54] start typing something for a property [18:32:03] press down with the arrow key [18:32:12] ah [18:32:13] for selecting something [18:32:13] got it [18:32:29] depending on the user, they might do that (i do sometimes) [18:32:43] ah, I confused "master" with "production" [18:32:43] if i select with the mouse then no problem [18:32:49] * lazowik hides [18:32:52] ah [18:33:01] it's on test.wikidata so will be production soon :( [18:33:06] "this happens on master and test.wikidata" -> and I went to check on production [18:33:07] * aude just found the bug [18:33:21] heh [18:33:26] it's seems fairly easy to fix [18:33:33] probably css has hover [18:33:43] Thiemo_WMDE has poked at the code so might know [18:33:59] he's not here right now though [18:34:21] fix would be in https://github.com/wmde/ValueView [18:34:35] https://github.com/wmde/ValueView/blob/master/lib/jquery.ui/jquery.ui.suggester.css maybe [18:34:50] hmm [18:34:59] is there a way to freeze js on a page? [18:35:03] in chrome [18:35:05] set a breakpoint [18:35:12] if I knew where [18:35:17] and use debug=true to make it easier [18:35:32] not minified? [18:35:34] developer tools? [18:35:39] not minified is easier to debug [18:35:41] where in code [18:35:56] or anywhere and iterate by hand? [18:35:57] developer tools in chrome? [18:36:26] we'd have to guess or find where in the code we want to stop [18:36:51] oh, in debug=true it seems to work correctly [18:37:43] just noticed that [18:37:50] might mean a missing dependency in resource loader definitions [18:38:15] on my wiki, it is broken in debug mode [18:41:25] hmm [18:41:34] element has ui-state-hover [18:41:46] .ui-suggester-list .ui-state-hover has color: white [18:41:51] and text is black… [18:42:01] ah [18:42:16] ".ui-suggester-list .ui-ooMenu-item a" ovverides that [18:42:21] oh [18:42:36] sounds familiar [18:42:41] now what's different in debug=true [18:43:03] debug=true bypasses resource loader minification [18:43:22] resource loader affects the order stuff gets loaded [18:44:25] debug=true has [18:44:28] .ui-suggester-list .ui-state-hover a, [18:44:28] .ui-suggester-list .ui-state-hover a:hover { [18:44:28] color: white; [18:44:30] } [18:44:34] ah [18:46:17] with debug=false [18:46:17] .ui-suggester-list .ui-state-hover a, .ui-suggester-list .ui-state-hover a:hover [18:46:26] is overriden by .ui-suggester-list .ui-ooMenu-item a [18:46:33] dunno how to resolve properly [18:46:37] !important? [18:47:05] also happens with site links [18:47:15] afaik does not use ooMenu [18:47:42] i don't even need to keydown [18:47:50] just type and it's black on blue [18:48:25] * aude is too hot and hungry to debug right now [18:48:26] uses .ui-ooMenu-item [18:48:30] oh [18:51:46] I'd blindly blame https://github.com/wmde/ValueView/commit/cdd9e3ddac4bde8875adf8e6a5f59ac659ccece8 [18:51:57] Thiemo_WMDE: ^ you broke all the wikidatas! [18:52:08] aude: done, let's wait for him to fix it :) [18:53:21] so extra .ui-suggester-list .ui-ooMenu-item a:hover or something [18:53:40] odd that it works when i point my mouse over though [18:54:12] no [18:54:18] extra .ui-state-hover [18:54:22] (with sth of course) [18:54:30] makes sense [18:54:31] :hover actually works (as you just said) [18:54:43] hmm [18:55:03] that would mean that there is some rule that has :hover but not .ui-state-hover [18:57:54] hmm [18:57:55] funny [18:58:11] .ui-suggester-list .ui-state-hover a, .ui-suggester-list .ui-state-hover a:hover [18:58:16] i see ', function() { [18:58:17] 182 se [18:58:19] gah [18:58:24] heh [18:58:26] 'mouseenter.ooMenu' [18:58:30] self.activate [18:58:52] when a is hovered the rule ovverides the black one [18:58:56] if not: not [18:59:46] aude: I think I got it [19:00:05] https://github.com/wmde/ValueView/blob/master/lib/jquery.ui/jquery.ui.suggester.css#L28 [19:00:11] remove .ui-ooMenu-item [19:00:16] cause that is more specific [19:00:17] self.destruct [19:00:55] self.changeBodyToPotato [19:01:01] heh [19:02:10] aude: also https://github.com/wmde/ValueView/blob/master/lib/jquery.ui/jquery.ui.suggester.css#L34 seems pointless [19:02:21] a.ui-state-hover just doesn't happen [19:02:28] * aude nods [19:03:25] did my fix work for you? [19:04:43] trying [19:06:07] seems to work [19:08:53] wooooo! [19:09:45] aude: or make .ui-suggester-list .ui-ooMenu-item.ui-state-hover a, .ui-suggester-list .ui-ooMenu-item.ui-state-hover a:hover [19:09:53] (two classes combined) [19:10:41] i see [19:12:57] depends on whether .ui-suggester-list can or will contain elements without .ui-ooMenu-item which will need other styling [19:13:16] * lazowik feels he needn't have explained that [19:13:57] i really don't know 100% sure enough [19:22:31] i wonder why color: black is needed at all [19:22:44] simply removing it also works for me [19:22:53] heh [19:23:06] maybe then it's a browser default? [19:23:55] inherits from .ui-widget-content a [19:24:05] jquery.ui.theme.css [19:24:10] if i remove color:black [19:24:26] but the hover works correctly with keydown or whatever [19:28:50] i don't know which is best but documented these options https://bugzilla.wikimedia.org/show_bug.cgi?id=68386 [19:30:59] mhm [19:31:06] lazowik: the bug is on wikidata btw :( [19:31:27] already? [19:31:30] yep [19:31:37] mpf [19:31:41] h [19:38:34] [13ValueView] 15filbertkm created 06blacksuggestertext (+1 new commit): 02http://git.io/xyeO5g [19:38:34] 13ValueView/06blacksuggestertext 1414d2865 15aude: Fix black colored text in suggestions when activated with keydown... [19:38:39] * aude try [19:38:54] [13ValueView] 15filbertkm opened pull request #89: Fix black colored text in suggestions when activated with keydown (06master...06blacksuggestertext) 02http://git.io/vvxyBA [19:38:56] but probably need to wait for thiemo to approve or provide another solution [19:39:02] mhm [19:39:22] i also don't see an easy way to override in site css (evil anyway to do that) [19:42:46] hmmm? [19:44:04] the links might turn blue [19:47:21] [13ValueView] 15filbertkm 04force-pushed 06blacksuggestertext from 1414d2865 to 14ca1ef27: 02http://git.io/r2bh_Q [19:47:21] 13ValueView/06blacksuggestertext 14ca1ef27 15aude: Fix black colored text in suggestions when activated with keydown... [19:47:21] https://github.com/wmde/ValueView/pull/89/files [19:47:28] seems better [19:52:03] lazowik: commented in the bug [19:52:22] not a lot more i can do right now, so i will go home and check later [19:52:54] mhm [19:52:55] great [19:55:32] later [19:55:43] thanks for helping debug :) [20:06:18] np :) [20:14:57] anyone good with Lua and wikibase here? i'm trying to return the label for the current page without having to pass any arguments, but can't figure out how [20:22:57] legoktm, you strike me as a person who knows stuff like that ;) [20:23:18] hey [20:23:24] one sec [20:23:44] Jhs: have you looked at https://en.wikipedia.org/wiki/Module:Wikibase ? [20:24:33] ah, there it is! [20:24:46] i think some of the stuff there might work. thanks! [20:25:17] :) [20:25:29] https://www.mediawiki.org/wiki/Extension:Wikibase_Client/Lua looks to have better documentation [20:26:16] maybe it's just me, but for me both that documentation and the general lua documentation is close to useless :/ [20:26:43] i don't understand half the words, or, when i do, i don't understand how i can actually use stuff [20:26:55] so i learn by trying and (very very frequently) failing [20:28:56] :/ [20:34:40] i tried finding some beginners course in Lua, but all i found assumed previous programming experience... which i don't have [21:09:00] Jhs: yeah :( it is on hoo's todo list to improve the situation. it'd be extremely helpful if you could write down what exactly is bad for you atm so we can concentrate on that first [21:10:12] legoktm: could i bother you again about an updated number of editors who made their first edit on wikidata for my wikimania keynote? [21:12:11] Lydia_WMDE, what would do it for me are more examples. how is this and this thing actually used. that would go a long way [21:12:25] sure [21:12:36] Jhs: ok. any specific examples you have in mind? [21:12:39] legoktm: <3 [21:13:22] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/148499 (owner: 10L10n-bot) [21:14:40] Lydia_WMDE, for the wikibase stuff, i've finally figured it out, but what i had trouble with was (1) how do i print(return) the value of property X on a page, and (2) how do i return the label on a page [21:14:55] (for that same page, that is) [21:14:55] Jhs: ok thx [21:15:58] Lydia_WMDE: 9714 [21:16:06] legoktm: wohoooooooo [21:16:19] quite an increase [21:16:28] what was it before? [21:16:33] ^ [21:16:35] 7000 [21:16:38] :D [21:16:41] :p [21:16:46] centralauth stores timestamps, so we could probably make a graph [21:16:57] that'd be nice [21:17:10] Translate: legoktm made a graph noa! [21:17:11] :p [21:17:15] *make [21:17:15] :D [21:17:27] :< I don't really know how to turn the data into a graph [21:17:33] * Lydia_WMDE thinks JohnLewis is the best Lydia_WMDE -> world translator [21:17:47] legoktm: if you can give me the data i can make the graph [21:17:55] :p [21:18:14] is a list of timestamps of when each account was created good enough? [21:18:18] Translation: give me the data and I will get a slave to do it or offer a cookie to the dev team [21:18:38] legoktm: should do yeah - can run it through google's thingy [21:18:43] hmm forgot the name [21:18:57] Google's thing -> I'll get Denny to do some work for me [21:19:03] lol [21:19:08] no no [21:19:14] let me figure out the name [21:19:15] sec [21:19:36] fusion tables! [21:20:38] * JohnLewis signs into Google to look [21:20:59] oh I see [21:24:42] Lydia_WMDE: https://noc.wikimedia.org/~legoktm/wikidata_users_timestamps.txt [21:25:01] legoktm: thx a lot! [21:25:14] np :) [21:30:11] statements [21:58:50] is there a special page (like Special:SetDescription) for setting properties? i would like to be able to link people to, something like [[d:Special:SetProperty/Q1234087/P345]] to make them fill in the missing property easily [21:59:09] Lydia_WMDE ^^ :p [21:59:23] if there is, i can't see it on Special:Specialpages, but i do have prescription glasses [23:07:05] legoktm, i have another problem... i can't get mw.wikibase.getEntityObject() to work when a wikidata entry doesn't exist [23:07:19] it returns script error all the time instead of what i want it to retur [23:07:20] n [23:07:22] it should return nil ? [23:07:29] link to your code? [23:07:35] https://no.wikipedia.org/wiki/Modul:IMDb [23:09:02] i was able to do it with mw.wikibase.getEntity(), but since it says that is deprecated i want to use getEntityObject instead [23:09:19] hmmm [23:10:16] * legoktm tests [23:11:47] i have tried both "if not entity then" and "if entity == nil then" [23:12:03] tried both multiple times actually :P [23:12:20] https://no.wikipedia.org/w/index.php?title=Modul%3AIMDb&diff=13278410&oldid=13278406 [23:12:24] isn't that the sign of being mad, trying the same thing repeatedly and expect different results? :P [23:13:11] wow, thank you very much, legoktm !