[01:41:37] (03PS1) 10Hoo man: WIP: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) [01:47:42] (03PS2) 10Hoo man: WIP: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) [01:56:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [02:01:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [05:11:22] aude: hey are you there? [06:33:40] Is there a way to make the item screen include less whitespace? it's awfully scrolly.... [07:09:03] andre__: i'd disagree indeed ;-) it is not the same as easy, actually in our case not even close. and some of those are high priority. we just have so many important things to do that it is awesome when other people do some of them and i'd like to make it explicit which ones those are [07:24:59] is aude around? [07:36:56] (03PS1) 10Henning Snater: Sanitized entity initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 [07:47:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 (owner: 10Henning Snater) [08:36:41] (03CR) 10Tobias Gritschacher: [C: 031] "Browsertests seem fine." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [08:48:54] (03PS7) 10Henning Snater: Inject API into parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [08:50:36] Henning_WMDE: https://gerrit.wikimedia.org/r/147351 [08:50:36] (03CR) 10Henning Snater: "Added/Updated documentation and removed one level of indentation." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [08:50:54] Can you have a look and tell me how I could have done that better? :P [08:51:28] hoo: Yes, noticed the change already. Will probably have a look next. [08:51:43] :) [08:51:48] Don't be to hard on it [08:51:57] our UI code sucks hard... but who am I telling that [08:58:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [09:02:51] hoo: do you need a place holder SVG for the badges? I can create one. [09:04:36] Thiemo_WMDE: Go ahead... I actually planned to do that myself, but then the code changes took longer (and were uglier) than I planed, so I didn't come to that, yet [09:04:56] hoo: ok, will do. [09:12:36] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I'm aware this is very much WIP. Reviewing early anyway to be sure it's the right direction." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [09:13:38] hoo: we decided to always reset the badge when you start editing a site link. but this feature can be done in an other patch. just to let you know. [09:14:36] Ok... only if you change it from the UI or also if you change it via API/ special page (or even on ChangeOp level)? [09:14:39] reset? [09:14:59] aude: unset them [09:15:10] yeah let me get the bug with details [09:15:22] * aude confused [09:15:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=68155 [09:15:32] hoo: ^ [09:16:24] ah ok, so UI only if I get that bug right [09:17:23] (03CR) 10Hoo man: "re to Thiemo" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [09:17:43] Lydia_WMDE: Not going to start on that before that WIP patch got in [09:18:01] that just wouldn't make much sense [09:18:08] yeah [09:18:48] with the bug, makes more sense [09:19:13] what about with page moves on the client? [09:19:16] Thiemo_WMDE: I think it should be enough to change the color of the icon [09:19:20] keep the badge? [09:19:24] I already have some other icons from Jared [09:19:39] let me upload them so you can save work and time [09:19:42] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=63691 [09:19:51] aude: yeah [09:20:41] (03CR) 10Hoo man: "@Jeroen: I now chose to remove your -1 as you weren't able to show a way forward or provide a test yourself as you announced earlier. This" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [09:20:50] is the placeholder like the watchlist star? (when unwatched) [09:21:04] Lydia_WMDE: Well, that's a good question actually [09:21:22] I think I saw that on a beta labs machine, I think it's gone now, but not sure [09:21:26] aude: not a star but yeah [09:21:37] not a star? :/ [09:21:46] a kitten! [09:21:47] no jared does not want stars for this [09:21:50] too many stars already [09:22:28] Ok, then we should use Suns seen from a huge distance [09:22:31] * hoo runs [09:22:31] (03CR) 10Henning Snater: WIP: Link badges to Special:SetSiteLink in edit mode (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [09:22:41] heh [09:23:38] hoo: regarding https://gerrit.wikimedia.org/r/#/c/132606/, JeroenDeDauw should be back today. He was not working the last days. [09:23:52] Lydia_WMDE: hoo: should we include a hover icon for the badge placeholder, too? [09:23:56] perhaps you can ping him later.. [09:24:31] Tobi_WMDE: Well, I've left him another week after his last comment on the change [09:24:38] benestar: probably not needed [09:24:45] so I'm kind of fed up with waiting [09:25:58] (03PS1) 10Thiemo Mättig (WMDE): Optimize SVGs and add empty badge icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 [09:26:42] hoo: have a good one that works fine even for color blind people. https://gerrit.wikimedia.org/r/#/c/147400/1 [09:27:15] aude: hi, harvesting klosses's database has been finished, can you check how many new coordinates we have now? [09:27:51] Tobi_WMDE: i' [09:27:55] Amir1: the last dump is from july 5 [09:28:03] is that recent enough? [09:28:15] Tobi_WMDE: I'd like to discuss that topic with you later, perhaps. the topic of blocked reviews, i mean [09:28:17] * aude can't do right now but during the weekend maybe [09:28:23] aude: yes, it was finished yesterday [09:28:33] hmmm [09:28:35] no rush but I wanted to let you know [09:28:38] the next dump should be soon [09:28:44] yes [09:28:46] * aude curious how many we have :) [09:29:02] (03CR) 10Hoo man: "Not sure the badge looks empty enough... I would have probably choosen just a single pixel width black outline, but I'm not a designer." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [09:30:07] (03CR) 10Bene: [C: 04-1] Optimize SVGs and add empty badge icon (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [09:30:40] DanielK_WMDE: ok [09:32:29] (03CR) 10Thiemo Mättig (WMDE): WIP: Link badges to Special:SetSiteLink in edit mode (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [09:32:45] aude: Can you reply to https://bugzilla.wikimedia.org/show_bug.cgi?id=67537#c1 please? [09:33:10] Maybe we should ave two versions of ChangesList stuff: One for local recent changes and one for external [09:33:22] * have [09:34:14] don't understand [09:34:16] benestar: where can i see the images you talked about? [09:34:28] (03CR) 10Hoo man: WIP: Link badges to Special:SetSiteLink in edit mode (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [09:34:34] Thiemo_WMDE: just preparing a patch to upload the icons by jared [09:35:10] aude: Do you plan to also inject all Wikidata changes as external changes into Wikidata (which seems a little awry) [09:35:30] or will we want to work with the actual recent changes entries (which are already around) for these features [09:35:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [09:36:06] thank you for your work on badges [09:36:09] all we want (and even not convinced) is maybe show related changes on watchlist [09:36:17] for connected items [09:36:32] aude: Using which recent changes entries? [09:36:42] don't know [09:36:45] mh [09:36:53] maybe we should just not do that after all [09:37:02] would be ok w/ me [09:37:03] if someone wants to watch an item, they can just watch that item, right? [09:37:07] (03PS1) 10Bene: Add null icon provided by Jared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147404 [09:37:10] yes [09:37:11] Thiemo_WMDE: --^ [09:37:33] aude: hoo: yes [09:37:37] agreed [09:37:40] :) [09:37:44] (03CR) 10Henning Snater: [C: 04-1] "abstractedRepoApi seems to be a required option. Widget initialization should probably throw an error if abstractedRepoApi is not defined." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145279 (owner: 10Adrian Lang) [09:38:44] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/QBPDYQ [09:38:44] 13WikidataBrowserTests/06master 1443dbbed 15Tobias Gritschacher: Sleep 1 sec AFTER ajax calls finished [09:39:58] (03CR) 10Henning Snater: [C: 04-1] "AbstractedRepoApi constructor should throw an error if constructor parameter is not defined." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145280 (owner: 10Adrian Lang) [09:41:43] wait... we ahve to conflicting changes both adding different empty badges items now? [09:41:47] * two [09:43:05] (03PS2) 10Bene: Add null icon provided by Jared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147404 [09:43:37] hoo: I just uploaded Jared's icon [09:44:37] benestar: That looks even less empty than Thiemo's [09:44:44] I prefer Thiemo's badge at a sight [09:45:51] (03PS2) 10Thiemo Mättig (WMDE): Optimize SVGs and add empty badge icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 [09:46:04] (03CR) 10Thiemo Mättig (WMDE): Optimize SVGs and add empty badge icon (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [09:46:31] benestar: can you please upload a zip with all icons you have? [09:47:39] (03CR) 10Hoo man: [C: 031] Optimize SVGs and add empty badge icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [09:47:44] Thiemo_WMDE: where? [09:49:36] (03CR) 10Tobias Gritschacher: [C: 032] Inject API into parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [09:49:57] (03Merged) 10jenkins-bot: Inject API into parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [09:50:36] Lydia_WMDE: in my head, "high priority" and "needs a volunteer" heavily collide (or contradict, even). Plus why not mark every open bug report in the world as "need volunteer" then if there's so many things to do? That's how it sounds to me, at least. ;) [09:51:08] Thiemo_WMDE: you basically just dropped the circle in the middle of the icon, right? [09:52:45] Tobi_WMDE: https://travis-ci.org/wmde/ValueView/builds any idea what the hell travis is doing here? [09:52:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147404 (owner: 10Bene) [10:00:10] Thiemo_WMDE: you've mail :) [10:00:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "I already optimized the original blue icon and made my I006231c based on that. This icon here just changes the color which is not good UX" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147404 (owner: 10Bene) [10:01:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147404 (owner: 10Bene) [10:01:32] andre__: not every bug because there are quite some that i really want the team to do for various reasons or that are probably not a good idea [10:01:37] (03Abandoned) 10Bene: Add null icon provided by Jared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147404 (owner: 10Bene) [10:01:43] (03PS1) 10WikidataBuilder: New Wikidata Build - 18/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147409 [10:04:23] (03Abandoned) 10Aude: New Wikidata Build - 17/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147074 (owner: 10WikidataBuilder) [10:04:28] (03Abandoned) 10Aude: New Wikidata Build - 14/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/146043 (owner: 10WikidataBuilder) [10:10:23] (03PS2) 10Aude: Rename PropertyParserFunction class to PropertyParserFunctionRunner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147125 [10:10:25] (03PS4) 10Aude: Remove $entityId and $parser from PropertyParserFunction constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 [10:10:28] (03CR) 10Aude: Remove $entityId and $parser from PropertyParserFunction constructor params (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [10:13:24] [13ValueView] 15thiemowmde pushed 1 new commit to 06min-width: 02http://git.io/luz_WQ [10:13:24] 13ValueView/06min-width 14cdd9e3d 15Thiemo Mättig: Move styles to suggester [10:14:21] Henning_WMDE: done https://github.com/wmde/ValueView/pull/87/files [10:16:15] [13ValueView] 15snaterlicious 04deleted 06min-width at 14cdd9e3d: 02http://git.io/WqtRDQ [10:17:17] aude: Have you tested https://gerrit.wikimedia.org/r/132606 yet? [10:17:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [10:17:58] i think so [10:18:14] would want to look/try again [10:18:59] Would be great if we could finally get that merged [10:19:10] +2 ! [10:19:14] if Jeroen wants to write tests he can do that in a follow-up still [10:29:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147409 (owner: 10WikidataBuilder) [10:30:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147125 (owner: 10Aude) [10:30:51] Wooooohooooooo [10:30:54] \o/ [10:30:59] * hoo opens the champagne [10:32:36] (03CR) 10Aude: [C: 032] New Wikidata Build - 18/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147409 (owner: 10WikidataBuilder) [10:33:18] On Monday we'll have our first json dump if I didn't screw :P [10:33:32] :D [10:33:53] If I screwed I meant the Monday after that, just for the record [10:34:35] \o/ [10:34:40] awesome hoo [10:35:46] (03Merged) 10jenkins-bot: New Wikidata Build - 18/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147409 (owner: 10WikidataBuilder) [10:35:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [10:36:00] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Track redirects in EPP table (0316 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [10:49:05] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I still find the amount of code duplication a bit odd. But I'm not sure if introducing abstract base methods is helpful. Maybe not." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [10:51:18] (03PS1) 10Aude: Rename and move PropertyParserFunction code to own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 [11:02:27] hello everyone [11:02:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 (owner: 10Aude) [11:02:53] (03CR) 10Henning Snater: [C: 04-1] "Can we get that sorted out? I agree that automatically detecting the necessary z-index would be great but I can imagine the investment of " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139396 (owner: 10Thiemo Mättig (WMDE)) [11:08:33] hoo: lol [11:08:50] :) [11:12:47] Lydia_WMDE: I looked at that thing and I was like: No, that's just no it :P [11:12:57] awwwww [11:12:59] but but but [11:13:02] it's sonic! [11:13:25] the name indeed is fancy [11:25:00] Lydia_WMDE: If one adds a new sitelink, should the empty badge appear immediately (before the sitelink has been saved) [11:25:09] or do we only want to show it if the user edits existing sitelinks [11:25:12] not sure here [11:25:52] Showing it immediately might be confusing as you have to reenter the page name (as nothing has been save yet when you click the link) [11:26:55] Hello. Is anyone willing to help me understand a bit more about WikiData ? [11:27:44] (03CR) 10Daniel Kinzler: Track redirects in EPP table (0314 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [11:27:59] Aguy2014: Just ask your question(s) [11:28:08] someone will hopefully answer [11:28:25] hoo: yeah in the current situation i'd say it shouldn't show up [11:28:29] (03PS5) 10Daniel Kinzler: Track redirects in EPP table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) [11:29:01] Aguy2014: don't ask to ask, just ask. [11:29:05] hoo: Thanks. I am curious specifically about what *kinds* of data sets are desirable / intended for publication in WD. For example: [11:29:14] Lydia_WMDE: Ok, that's what I also prefer... in real life most sitelinks that have badges are on items already anyway, so I doubt this really matters much [11:29:46] Complete set of all of the State Lottery numbers and prize statistics [11:29:48] ? [11:29:53] (03PS1) 10Aude: Move parser function code for site link lookup out of static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 [11:30:15] Aguy2014: that's not the intended (current) scope of wikidata. it's not well suited for "flat" tabular data [11:30:20] (03CR) 10Addshore: "Indeed it is used by Special:Preferences but this doesnt relate to the wikidata parsing." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [11:30:45] Aguy2014: the idea of wikidata is to collect "deep" data sets about individual items. the granuarity is roughly that of wikipedia. [11:31:30] hoo: I don't think we have anything that is run by travis for the ValueView repository [11:32:06] Aguy2014: for example, instead of a list of all streets in a city, we are more interested in individual streets, when they were bould, changed, rednamed, extended, etc. [11:32:07] Tobi_WMDE: I've seen that... so why does it attempt to run some rake stuff? :P [11:32:14] there's no PHP in there and the QUnit tests in that repository are not yet made working on travis. so there should no jobs running [11:32:15] it's an addshore \o/ [11:32:29] oh halo! [11:32:39] Aguy2014: for historical people, we'd not only want to know when they were born, but who claimed which date of birth, with what certainty, stated in what publication [11:32:58] *is going to try and move the time parsing stuff into the DV/Time lib today [11:33:00] Tobi_WMDE: Yep... can we disable that? Annoying [11:33:04] hoo: hm, not sure why any travis builds got triggered. but when they are triggered I think travis does just the default thing and that is running rake.. [11:33:05] ohi addshore! [11:33:10] DanielK_WMDE: ah! Okay that helps a bit. What about the "interconnectedness" of data items ? [11:33:17] ohi DanielK_WMDE :) [11:33:20] it's addshore! [11:33:25] ohi aude ! [11:33:29] Aguy2014: what about it? [11:33:29] For example: [11:33:36] (03PS5) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) [11:33:51] * aude met people yesterday that met you in london at the wikimania thing :) [11:34:03] Aguy2014: have a look at the data model primer to get an impression of how we model "deep" data: https://meta.wikimedia.org/wiki/Wikidata/Notes/Data_model_primer [11:34:08] [13ValueView] 15thiemowmde created 06zIndex (+1 new commit): 02http://git.io/VhfjIA [11:34:08] 13ValueView/06zIndex 148814fb7 15Thiemo Mättig: Dynamically calculate suggesters z-index [11:34:14] hoo: removed the travis webservice from valueview. no clue who've added it [11:34:15] [13ValueView] 15thiemowmde opened pull request #88: Dynamically calculate suggesters z-index (06master...06zIndex) 02http://git.io/GlIKyw [11:34:17] uk chapter folks [11:34:22] ugh, wrong link, sorry [11:34:23] Tobi_WMDE: Ok, thanks :) [11:34:26] huh, the channel is busy today [11:34:32] If you had a list of deep data about corporations would WD want the linked corporations ? [11:34:33] [13ValueView] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/LVu1YQ [11:34:33] 13ValueView/06master 1445b4f94 15snaterlicious: Merge pull request #88 from wmde/zIndex... [11:34:39] [13ValueView] 15snaterlicious 04deleted 06zIndex at 148814fb7: 02http://git.io/Oimhcw [11:34:59] er list is not right, sorrt [11:35:00] sorry [11:35:37] Aguy2014: usually yes - one reason for inclusion is "structural need". e.g. if we have a couple of famous siblings, we'd also aadd data items for their parents, even if the parents are not famous, and we know little about them [11:35:38] Lydia_WMDE: Is sitelink a term we use in the UI [11:35:43] like "add badges to sitelink" [11:35:46] or how should I word that [11:36:09] hoo: no we shouldn't use that in the UI [11:36:15] feared that [11:36:17] where do you need it? [11:36:19] so what's the thing [11:36:28] Lydia_WMDE: As title for the "empty" dummy badge [11:36:30] just use link? [11:36:49] Or just "Add badges" ? [11:36:53] (03CR) 10Addshore: [C: 04-1] "To me parsing -1.10.100 as 110100 BCE just seems odd, especially as if the .s are meant to be thousand separators they are in the wrong pl" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 (owner: 10Thiemo Mättig (WMDE)) [11:36:54] that also works [11:36:54] [13ValueView] 15thiemowmde 04force-pushed 06release-062 from 14bcda05b to 14ba5f5d3: 02http://git.io/CrNCfw [11:36:54] 13ValueView/06release-062 14ba5f5d3 15Thiemo Mättig: Revert wrongly placed CSS [11:36:55] yeah [11:37:33] DanielK_WMDE: Okay. Now I have a much better understanding about what WD is trying to cover. Thank you. --- Next question: [11:38:04] [13ValueView] 15thiemowmde 04force-pushed 06release-062 from 14ba5f5d3 to 1401dfad0: 02http://git.io/CrNCfw [11:38:04] 13ValueView/06release-062 1401dfad0 15Thiemo Mättig: Revert wrongly placed CSS [11:38:54] [13ValueView] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/81_TSw [11:38:54] 13ValueView/06master 1417aed29 15snaterlicious: Merge pull request #70 from wmde/release-062... [11:39:10] (03Abandoned) 10Thiemo Mättig (WMDE): Fix z-index on Client when it uses the ooMenu suggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139396 (owner: 10Thiemo Mättig (WMDE)) [11:39:19] Are there any focused "Projects" here? For example (in my mind) a Project might be "Family tree of European Royal Families" [11:39:48] Aguy2014: There are task forces on Wikidata that work on a certain subject [11:40:15] https://www.wikidata.org/wiki/Wikidata:Task_forces [11:40:40] hoo: Cool. Thank you. [11:41:05] (03PS1) 10Aude: Move constructor code out of parser function static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 [11:42:14] Okay. I am going to go do some digging around and see if there is anything I might be able to offer some value to. Thanks for answering these simple but important questions. [11:44:10] You're welcome :) [11:44:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [11:47:12] (03PS6) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) [11:52:05] (03PS3) 10Hoo man: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) [11:52:30] (03CR) 10jenkins-bot: [V: 04-1] Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [11:52:37] (03CR) 10Hoo man: Link badges to Special:SetSiteLink in edit mode (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [11:53:26] (03PS4) 10Hoo man: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) [11:54:30] (03CR) 10Hoo man: "Addressed comments from PS2 (thanks for all the reviews). This is in a usable state now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [11:56:22] (03PS10) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [11:56:35] (03CR) 10Daniel Kinzler: "PS10 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [11:57:02] (03CR) 10Daniel Kinzler: [C: 04-1] "Entity resolution should be rewritten to use the new epp_redirect_target column" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [12:00:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [12:03:44] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147409 (owner: 10WikidataBuilder) [12:10:27] (03CR) 10Eranroz: "OK thanks. so the problem is with MonthNameUnlocalizer. MediaWiki really don't have (and probably shouldn't have) any "unlocalizer" - it i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [12:10:43] looks like site links are broken :( http://wdjenkins.wmflabs.org/ci/job/wikibase-build-browsertests-saucelabs/81/ [12:10:55] * aude can't look right now but we need to check [12:12:20] uh [12:12:23] not really possible [12:12:30] I'm just working on that and it's fine on master [12:12:43] mh [12:12:46] unable to locate element, using {:xpath=>"//table[contains(@data-wb-sitelinks-group, 'wikipedia')]/ [12:12:48] Is anyone here who works on the "Wikiproject Fictional universes" task force? If not I will ask on the Talk Page but I was wondering about creating a data set for the Dungeons and Drangons universe including the various abilities and stats for creatures and artifacts.. [12:12:51] might be that it's broken in non-exp. mode [12:13:09] * aude check beta [12:13:20] ok, please do [12:14:01] http://wikidata.beta.wmflabs.org/wiki/Q2558 [12:14:07] ReferenceError: wikibase is not defined [12:14:08] ReferenceError [12:14:15] exception thrown by wikibase.ValueViewBuilder [12:14:18] (03CR) 10Daniel Kinzler: "@Eranroz For the machine it would be very convenient, yes. For humans, not really. I for one *hate* it when I have to click through select" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [12:14:20] err Dragons :) can't seem to type today :P [12:14:25] cached page [12:14:43] (03PS5) 10Hoo man: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) [12:14:53] aude: Does it work after purging? [12:14:58] trying another page [12:15:19] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [12:15:29] works [12:15:47] okay ... later folks. [12:15:54] Aguy2014: that's a question of scope, really. i don't think we want to model all adnd creatures. while we certainly want to have Smaug. I suggest to ask on the generic project chat page [12:15:58] (03CR) 10Hoo man: "Fixed a glitch with newly added sitelinks (initially caused by the changed scope of SitePageInterface)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [12:17:07] did the html change? [12:17:12] aude: Yes [12:17:20] could be selenium tests need updating [12:17:35] Bene* changed it to add badges [12:17:41] i see [12:18:43] uh, this is bad [12:19:09] is there a neat way to find out whether we're in exp. mode from JS? [12:19:27] ah wbExperimentalFeatures [12:19:29] nice [12:19:44] DanielK_WMDE: Smaug is from a different fictional universe, the Tolkien universe. :) ... My thought was there is a growing trend in the gaming world to use computer assistance for refereeing games and having machine readable data on the universe coud be beneficial to open-source software [12:21:25] aude: Next branch needs *a lot* of testing [12:21:32] we changed so many JavaScript and UI things [12:21:40] I'm afraid stuff might break [12:21:47] the big challenge is creating a *consistent* data structure that is all encompassing [12:22:43] (03PS6) 10Hoo man: Link badges to Special:SetSiteLink in edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) [12:22:56] Aguy2014: i know it's tolkien :) my point was that we *definitly* want famous fictional creatures like that, but modelling a role playing rule set seems out of scope [12:22:58] (03CR) 10Hoo man: "Respect wbExperimentalFeatures" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [12:23:55] Aguy2014: i could very well imaging wikia offering Wikibase instances for that kind of thing in the future. People are already doing things like this at wikia (which has lots of fan and fiction wikis) on the basis of a different mediawiki extension, SMW. [12:24:17] DanielK_WMDE: ah. that is what I need to understand then. How do I determine scope? Are there guidelines for WD ? [12:24:27] Aguy2014: http://dungeons.wikia.com/wiki/Main_Page [12:24:38] aude: Hate me now, but I would strongly recommend clearing the parser cache for the next release... we changed sitelinks DOM structure to much and in to many places :( [12:24:55] Aguy2014: wikidata is still young and in flux. the scope is more or less that of wikipedia, but that's not set in stone [12:25:17] so i suggest you explain what you want to do on the project chat, and see how that goes [12:25:45] and/or start doing it, slowly, ready to engage in discussions and modify (or relocate) your project [12:26:10] Aguy2014: https://www.wikidata.org/wiki/Wikidata:Project_chat [12:26:31] DanielK_WMDE: Cool. I appreciate the advice and will follow it. Thanks again. [12:26:45] hoo: ok [12:27:08] Aguy2014: look at the adnd wiki at wikia: http://dungeons.wikia.com/wiki/SRD:Elder_Earth_Elemental [12:27:23] looks to me like they use SMD to model the data [12:27:29] err, SMW [12:27:56] [13Time] 15addshore created 06addParseAndFormat (+2 new commits): 02http://git.io/p_fsHw [12:27:56] 13Time/06addParseAndFormat 1471d8286 15addshore: Create TimeParser to parse using multiple Parsers [12:27:56] 13Time/06addParseAndFormat 147909df1 15addshore: Add basic CalendarModelParserTest [12:28:29] DanielK_WMDE: and I don't want to leave you with the impression I am some silly kid. I actually am an old semi-retired IT manager who has a fascination for data structures and simulations. [12:30:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 (owner: 10Aude) [12:30:54] Aguy2014: i learned long ago to make no such assumptions :) have fun! [12:31:52] Aguy2014: also, "silly kids" do amazing jobs here, both in software and in content... [12:36:29] DanielK_WMDE: Well, I do try to be a kid-at-heart. Just so often I find myself criticized for my love of games (which ultimately are simulations) and maybe that is just the pitfall of having a bunch of old-farts for business colleagues. ;) [12:39:10] DanielK_WMDE: It does look like someone may have already started without me... http://tools.wmflabs.org/wikidata-todo/tree.html?q=Q2607197&rp=279&lang=ru [12:39:33] (03PS2) 10Eranroz: Adding support for genitive month name (xg) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 [12:40:24] (03CR) 10Addshore: [C: 04-1] "Needs tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [12:42:19] DanielK_WMDE: whoops, wrong link. https://www.wikidata.org/wiki/Q4390702 [12:42:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [12:43:07] (03CR) 10Eranroz: "@Daniel Kinzler, I still think unlocalizer is a bit ugly, but you convinced me that for that case free text is cool ;) I didn't know Wiki" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [12:46:29] So long everybody. Thanks for helping the noob! :-) [12:52:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [12:52:48] This is the FINAL reminder to make sure you have retrieved all your data from Ubuntu One filesync, as we will be deleting all the content permanently on 31st July 2014. After that date, we will no longer be able to retrieve any of your files. [12:52:52] wrong window [12:55:56] hello eveyone [12:56:25] hi noor_wkdtusr [12:57:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [13:00:05] (03PS1) 10Aude: Introduce RendererFactory class for parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 [13:00:07] (03PS1) 10Aude: Add and improve test cases in RunnerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147430 [13:00:09] (03PS1) 10Aude: Fix naming of RunnerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147431 [13:04:39] that change stack is getting huge [13:04:46] * hoo should review [13:09:12] please do! [13:10:11] hi se4598 :D [13:10:18] hoi [13:12:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [13:12:59] (03CR) 10Thiemo Mättig (WMDE): Track redirects in EPP table (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [13:13:23] aude: hoo: I ran the browsertests on test.wikidata and I was not seeing any obvious issues there.. [13:13:33] FYI [13:13:40] Tobi_WMDE: thanks [13:13:41] Ah, great :) [13:13:44] thanks [13:13:56] as told, next build will be more dangerous [13:14:02] hoo: Tobi_WMDE: is there any type of test for the thing I -1'd way to long ago? [13:14:27] JeroenDeDauw: AFAIR it was just adding some hard coded arrays [13:14:28] so no [13:14:30] JeroenDeDauw: you mean the "in-other-projects" thing? [13:14:53] Indeed [13:15:02] there are at least no browsertests for it [13:15:23] hoo: well, how do we know they are the right arrays, and that stuff did not break due to an interface change of the hook? [13:15:46] This does concern me, and I'd like to see it addressed [13:15:54] OTOH, this stuff staying there so long i silly [13:16:15] And this thing is not managing to get very high on my prio list, we have bigger issues elsewhere [13:16:22] You could only address this by writing an integration test involving the BetaFeatures extensions [13:16:23] So I'm not totally opposed to merge [13:16:40] and that would be a lot of work for rather low-risk code [13:17:00] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/nVjUyg [13:17:00] 13WikidataBrowserTests/06master 14fd49914 15Tobias Gritschacher: Update Gemfile.lock [13:17:09] to the javascript-guys: Is this a correct/good way to use wikidata in a other extension, which is included via resource loader (beside putting the "using" in the declaration of the original module)? http://pastebin.com/raw.php?i=dfZJYMCM [13:17:38] hoo: maybe. If you want to take responsibility for it, go ahead then [13:17:49] didn't say that [13:17:53] Can I assume that wikibase is always set? [13:17:54] I didn't even test it myself [13:18:09] se4598: If you're on an entity page, probably [13:18:19] but you should still load *all* things you plan to use [13:18:47] hoo: totally random page and content type on wikibase repo wiki [13:19:05] then you need to load 'wikibase' also [13:19:15] Tobi_WMDE: is there an abraham in the office? [13:19:51] JeroenDeDauw: no, he'll back on tuesday [13:19:57] JeroenDeDauw: are you coming in today? [13:22:25] Tobi_WMDE: yeah, I'll be there in an hour [13:23:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [13:28:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [13:31:25] [13Time] 15addshore pushed 1 new commit to 06addParseAndFormat: 02http://git.io/WLid6A [13:31:25] 13Time/06addParseAndFormat 145b294e3 15addshore: Implement MonthNameUnlocalizer and tests [13:32:25] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [13:34:24] aude: How about a backport on Monday? :D [13:34:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [13:34:52] hoo: perhaps [13:34:56] ask Lydia_WMDE [13:35:09] "Exception thrown by wikibase.ValueViewBuilder" load.php:161 [13:35:10] 15:33:09.285 "ReferenceError: wikibase is not defined" [13:35:13] dependency problem :S [13:35:18] :D [13:35:31] that [13:35:53] and think thiemo fixed the blue colored entity suggestions [13:35:59] backport that [13:36:17] (03PS1) 10Hoo man: Declare that wikibase.ValueViewBuilder depends on wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147447 [13:36:17] mh [13:36:23] new ValueView release needed? [13:36:40] yes [13:36:42] >_> 30 things up for review on GH since yesterday [13:38:15] (03PS1) 10Hoo man: Declare that wikibase.ValueViewBuilder depends on wikibase [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147452 [13:38:37] JeroenDeDauw: oO [13:40:40] aude: So you say we should a new ValueView release now/ on Monday? [13:41:04] or is that in an other component [13:41:14] or ist that already fixed in ValueView 0.6.5 [13:41:59] I think 0.6.5. might already fixed that: https://github.com/wmde/ValueView/compare/0.6.4...0.6.5 [13:42:04] look at the CSS changes [13:44:07] looks like that would be ok and fix things [13:44:32] Thiemo_WMDE: Tobi_WMDE any objections ^ ? [13:44:47] (03PS1) 10Hoo man: Bump ValueView to 0.6.5 [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147468 [13:45:27] hoo: whats the current reason for you to look into valueview? [13:45:54] Thiemo_WMDE: I your CSS changes [13:46:07] aude pointed that out [13:46:11] I guess that's what she means [13:46:16] blue suggestions [13:46:37] in my opinion the blue color is NO reason for a backport. nothing is broken. nothing is unusable. it's just blue instead of black. [13:47:07] yes, valueview needs a new release because of that. but no backport. [13:47:25] it's a regression [13:47:29] We have to make a backport anyway [13:47:32] not really. [13:47:32] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [13:47:33] what do you think Lydia_WMDE ? [13:47:46] backport fix for the blue entity suggestions? [13:47:50] the dependency thing seems breaking, so I want that in before we go live [13:47:51] why "a backport anyway"? for valueview? [13:48:05] Thiemo_WMDE: No, unrelated to that [13:48:07] people will complain [13:48:17] or at least think it's odd [13:48:24] if it is a small fix i'd say backport. it is weird if we have it one way then change it and then change it again [13:48:28] we have a million things that are odd. [13:48:36] I'd say put it in [13:48:46] no breaking changes in ValueView 0.6.5 [13:49:03] so why backport a STYLE change? [13:49:12] sorry, don't get it. [13:49:22] because it is very user-visible [13:49:35] [13Time] 15addshore pushed 1 new commit to 06addParseAndFormat: 02http://git.io/huQ72w [13:49:35] 13Time/06addParseAndFormat 14cf110eb 15addshore: Add EraParser [13:50:42] backport to what branch? i don#t see the error on wikidata.org. [13:50:58] but you will on tuesday [13:50:59] Thiemo_WMDE: wmf14 is not live there yet [13:52:59] (03PS11) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [13:56:03] ValueView 0.6.5 isn't even enough [13:56:42] we need this commit: https://github.com/wmde/ValueView/commit/d927498e11f4e2b756f2a3c4211fbf29f85ca8f6 [13:56:44] meh [13:57:44] [13Time] 15addshore pushed 1 new commit to 06addParseAndFormat: 02http://git.io/OFQaEg [13:57:44] 13Time/06addParseAndFormat 14e19e7f1 15addshore: Add YearTimeParser and tests [13:57:55] hoo: cant it just be 'fixed' in the on site css for now? [13:58:07] that sounds evil [13:58:12] It's an addshore [13:58:20] hoo: that means you are +1? [13:58:32] no, I'd rather leave it ugly :P [13:58:32] hoo: evil but meh https://www.wikidata.org/w/index.php?title=MediaWiki:Common.css&diff=140266830&oldid=136909341 [13:58:33] ;p [13:58:38] its a JeroenDeDauw! [13:59:40] wait wtf [13:59:51] addshore: What an earth is that CSS fix for [14:00:03] and why was the corresponding change in ValueView reverted [14:00:08] * on earth [14:01:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147430 (owner: 10Aude) [14:01:52] -.- [14:02:19] this is where messing with site CSS leads to: No one has a clue anymore about where a style is and why we need it [14:02:50] :D [14:02:59] I guess aude will know ;p [14:03:16] for the record, Fomafix made our suggesters blue in https://gerrit.wikimedia.org/r/#/c/145772/ just a few days ago. [14:03:24] I just reverted that change because it seems we don't need it anylonger [14:03:32] if we do, someone will notice [14:04:28] Thiemo_WMDE: Why does that affect us? [14:04:36] * aude hides [14:04:48] it removed the color so all links became default blue. [14:05:01] but why does that affect our stuff [14:05:04] (03PS6) 10Daniel Kinzler: Track redirects in EPP table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) [14:05:07] do we use the same class names?! :/ [14:05:17] and about the change in valueview, please take a step back and don't revert stuff you don't fully understand. [14:05:45] Thiemo_WMDE: The revert was *your* commit [14:05:56] it's a jquery widget. sure it uses the default jquery widget class names. [14:06:28] talking about the other revert. and your "what on earth". please relax. [14:07:00] Thiemo_WMDE: we support lobe specific queries now? [14:07:04] *globe [14:07:21] (03PS12) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [14:07:38] JeroenDeDauw: no, since we don't support aueries. [14:07:38] (03PS7) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) [14:07:41] *queries [14:07:57] To clean this mess I'd suggest to just make a 0.6.6 ValueView and use that [14:08:00] no more mess then [14:08:23] I just spent half an hour looking at which versions we use where and stuff [14:08:30] henning and i just cleaned the mess. yes, please make a valueview 0.6.6 to finish the cleaning. [14:08:42] ok with me but i really don't know the status of valueview [14:09:43] Tobi_WMDE: You also ok with making a ValueView release (yes, again) [14:10:28] [13ValueView] 15thiemowmde tagged 060.6.6 at 06master: 02http://git.io/1b3o3w [14:10:59] um... release notes? [14:11:06] (03PS10) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [14:11:17] shit, forgot to update the readme. how to revert/amend a release? [14:11:37] just change it on master and you can then change the version that has the release [14:11:41] that's ugly, but works [14:12:59] (03CR) 10Daniel Kinzler: Resolve redirects in JS config variables. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [14:13:02] pffft, evvvvviiiiil weather [14:16:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147431 (owner: 10Aude) [14:17:44] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/6o5M1A [14:17:44] 13ValueView/06master 14ea22bcb 15thiemowmde: Update README.md [14:18:09] [13Time] 15addshore pushed 1 new commit to 06addParseAndFormat: 02http://git.io/GLbMhA [14:18:09] 13Time/06addParseAndFormat 14533697b 15addshore: Add YearMonthTimeParser and tests [14:18:11] Thiemo_WMDE: There's also a version constant in ValueView.php [14:18:27] (03CR) 10Hoo man: [C: 032] "Tested and looks sane." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [14:18:43] (03Merged) 10jenkins-bot: Remove $entityId and $parser from PropertyParserFunction constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [14:18:47] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/ILtxgA [14:18:47] 13ValueView/06master 146e14fdd 15thiemowmde: Update ValueView.php [14:18:53] i can not edit the stuff in the 0.6.6 tag [14:20:04] you should remove and re add the tag [14:20:31] how? [14:21:06] git tag -d 0.6.6 && git push origin :refs/tags/0.6.6 [14:21:14] then re tag where the tag should be :) [14:21:29] ??? [14:21:57] github is stupid. [14:21:59] mh, github dislikes me [14:22:08] I can do it if you want :) [14:22:09] just deleted it and retagged at mast [14:22:10] er [14:22:13] but it didn't eat it [14:22:31] still missing the 2 commits :) https://github.com/wmde/ValueView/compare/0.6.6...master [14:22:34] where is that delete button on github? [14:22:45] Thiemo_WMDE: that doesnt delete the tag, only the release [14:22:56] you have to delete the tag in git [14:22:58] same problem. how to delete stuff? [14:23:02] [13ValueView] 15mariushoch 04deleted 060.6.6 at 1417aed29: 02http://git.io/yDHwJA [14:23:04] addshore: Doh, sure [14:23:06] got it now [14:23:07] :) [14:23:10] * hoo is stupid :P [14:23:12] [13ValueView] 15mariushoch tagged 060.6.6 at 06master: 02http://git.io/1b3o3w [14:23:18] no wtf [14:23:22] bingo :) https://github.com/wmde/ValueView/compare/0.6.6...master [14:23:29] i can set a release to pre-release but there is nothing to delete one. [14:23:48] arggg! [14:23:59] Thiemo_WMDE: https://github.com/wmde/ValueView/releases/tag/0.6.6 [14:24:04] delete button on the right [14:24:11] after that you also have to delete the tag [14:24:11] next to the edit button :) [14:24:21] addshore: but github didn't seem to like that in the UI [14:24:25] WTF? [14:24:29] it still says two commits to master since [14:24:30] :P [14:24:38] changing tags is evil, I said it [14:24:40] hoo: github ui might take some time to realise what you have done :P [14:24:41] i see the button. i clicked everything but couldnt find it there. [14:24:45] hoo: indeed :P [14:25:37] ok, i still would like to know where the button to delete a TAG is hidden??? [14:25:55] (03CR) 10Hoo man: [C: 032] "Not a big fan of this name, but whatever" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147125 (owner: 10Aude) [14:26:10] Thiemo_WMDE: there isnt one [14:26:15] https://github.com/wmde/ValueView/releases/tag/0.6.6 [14:26:17] git tag -d 0.6.6 && git push origin :refs/tags/0.6.6 [14:26:19] whatever indeed :) [14:26:19] (03Merged) 10jenkins-bot: Rename PropertyParserFunction class to PropertyParserFunctionRunner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147125 (owner: 10Aude) [14:26:19] addshore: Not true [14:26:21] * aude hates naming [14:26:35] hoo: thats just deletes the github release though, the tag remains [14:26:42] addshore: Nope [14:26:45] that's the link to the tag [14:26:46] O_o [14:26:49] see the URL [14:27:02] https://github.com/wmde/ValueView/releases/tag/0.6.6#delete_release_confirm [14:27:07] no per hand git fiddling needed any longer [14:27:29] *will try next time* ;p [14:30:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147447 (owner: 10Hoo man) [14:31:11] (03CR) 10Hoo man: [C: 04-1] "Y u no rename tests?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 (owner: 10Aude) [14:34:24] (03PS2) 10Hoo man: Bump ValueView to 0.6.6 [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147468 [14:35:01] Tobi_WMDE: Can we make jenkins run two jobs of the same type in parallel? [14:35:19] it's all stuck waiting on wikibase-repo-api-tests jobs [14:36:37] [13Time] 15addshore pushed 1 new commit to 06addParseAndFormat: 02http://git.io/eHMYUg [14:36:37] 13Time/06addParseAndFormat 14aaef911 15addshore: Add DateTimeParser and tests [14:37:06] JeroenDeDauw: good news, all the time parsing is currently moving into datavalues ;p [14:37:29] guess I just need to come up with a new name for MWTimeIsoParser now [14:37:35] addshore: link? [14:37:54] oh wait, is that one of those things that was put in WB.git for no good reason? [14:39:18] JeroenDeDauw: https://github.com/DataValues/Time/compare/addParseAndFormat [14:39:41] well, it was all tied into the MW language object in places, but that is all bring removed ;p [14:39:46] well, altered :P [14:39:58] \o/ [14:42:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147452 (owner: 10Hoo man) [14:43:31] (03CR) 10Daniel Kinzler: [C: 04-1] "No tests for new functionality." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/142519 (owner: 10Eranroz) [14:43:59] (03CR) 10Thiemo Mättig (WMDE): Cleanup EntityView, SectionEditLinkGenerator and related (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [14:44:11] (03PS6) 10Thiemo Mättig (WMDE): Cleanup EntityView, SectionEditLinkGenerator and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 [14:46:22] addshore: I'll have a look at this now [14:46:33] what would everyone call the dates that are formatted such as "11 million years ago" and "1950s" etc? I guess they all all Years only, Inprecise years perhaps, InpreciseYearParser ? [14:46:40] rather than MwTimeIsoParser.. [14:46:41] addshore: why no PR yet? [14:46:51] Is this mostly done, esp structure wise? [14:47:40] (03PS2) 10Hoo man: Sanitized entity initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 (owner: 10Henning Snater) [14:48:19] (03CR) 10Hoo man: "Rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 (owner: 10Henning Snater) [14:48:49] (03CR) 10Daniel Kinzler: "I now tend towards "DataUpdateAdapter". It's basically a generic adapter that can turn any method into a DataUpdate." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [14:48:54] JeroenDeDauw: because its not gone yet :) [14:49:10] got 1 more parser to more accross and then to add them all to the array in the TimeParser class [14:49:14] *move [14:49:14] (03CR) 10Daniel Kinzler: "...or DataUpdateMethodAdapter. Or MethodAdapterDataUpdate?..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [14:49:36] yup JeroenDeDauw, most of the code is the same, just the bits around language objects have gone [14:51:04] addshore: TimeParser and BaseTimeParser naming is not good [14:51:23] AT first glance I thought the later would be abstract [14:51:33] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, thanks" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/146179 (owner: 10Thiemo Mättig (WMDE)) [14:51:40] SimpleTimeParser? :P [14:51:51] Basic? [14:52:06] -.- [14:52:12] :D [14:52:14] ValueView 0.6.6 is broken [14:52:23] >.> [14:52:38] addshore: after loking at it for 2 mins I'm still not sure what exactly they do [14:53:05] https://github.com/wmde/ValueView/commit/5e79c9245a03edd56d52e3bc51c297697b2769a7 [14:53:12] event is undefined :S [14:53:19] I even merged that... shame on me [14:53:28] well, TimeParser is more of a dispatching parser [14:53:38] DispatchingTimeParser! [14:54:08] what does simple do? [14:54:13] addshore: when i looked at it a while back, it seemed to me that it was split too much, or at least the wrong way. [14:54:22] and the basetimeparser does extremely basic parsing, i.e. the stamp form we store the date in with also a calendar model [14:54:32] then Basic sounds good [14:54:56] addshore: whatever parses the date must at the same time establish the precision. you can't rely on trailing zeros for that [14:55:13] addshore: some docs on which parsers do what part would be good [14:55:20] ... and evilsSeed strikes again [14:55:44] Right now it is hard to distinguish between parsers doing different things and those that simply are alternate implementations [14:55:44] * hoo starts to rage [14:55:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147468 (owner: 10Hoo man) [14:55:46] precision is handeled in different ways depending on the user input, i.e. the options passed to the parser, if there are no options the parser will establish the precision [14:56:26] addshore: with this naming at the very least there should be a short description for each class [14:56:49] And not just "ValueParser that parses the string representation of a time", since that applies to most of them [14:57:05] Yup :P Okay, I will finish moving this final class and then rename a few things and add descriptions [14:57:06] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/U8XqBQ [14:57:06] 13ValueView/06master 14002d019 15Marius Hoch: Don't try to use non-existing variable event... [14:57:21] Thiemo_WMDE: aude: Tobi_WMDE: http://git.io/U8XqBQ [14:57:27] shall we re-re-tag 0.6.6 ? [14:58:06] hoo: as in, create a new tag? [14:58:07] this is getting ridicules :P [14:58:25] JeroenDeDauw: Yes... we already tagged that version twice [14:58:35] which makes this a little ridicules :D [14:58:35] 0.6.6.1 ;p hah [14:58:47] 0.6.6.6? [14:58:52] :O [14:59:15] addshore: 0.6.6-wmf1 :P [15:00:31] * hoo waits for serious replies [15:02:08] [13WikibaseDataModel] 15JeroenDeDauw created 06ClaimGuid (+1 new commit): 02http://git.io/iZSVwA [15:02:08] 13WikibaseDataModel/06ClaimGuid 14661b81e 15jeroendedauw: Minor tweaks in ClaimGuid [15:03:18] [13WikibaseDataModel] 15JeroenDeDauw created 06strct (+1 new commit): 02http://git.io/WhnfNA [15:03:18] 13WikibaseDataModel/06strct 1482370eb 15jeroendedauw: Set strict mode in the test bootstrap [15:03:19] Did everybody leave yet? [15:03:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:03:51] hmm JeroenDeDauw any problem with DV/Time depending on DV/Number for use of the NumberUnlocalizer interface and stuff? [15:05:19] hoo: seems no one has a preference [15:05:19] [13ValueView] 15mariushoch 04deleted 060.6.6 at 146e14fdd: 02http://git.io/vBvunA [15:05:39] [13ValueView] 15mariushoch tagged 060.6.6 at 06master: 02http://git.io/1b3o3w [15:05:41] aude: Just re-re-tagged 0.6.6 then [15:05:43] * aude included, so re-tag is ok or whatever [15:05:46] this is getting out of hands [15:05:47] :) [15:06:04] yeah [15:06:44] [13WikibaseDataModel] 15JeroenDeDauw created 06private (+1 new commit): 02http://git.io/RJTKGw [15:06:44] 13WikibaseDataModel/06private 14517785b 15jeroendedauw: protected -> private [15:07:55] (03CR) 10Hoo man: [C: 032] "Works locally, Qunit tests pass and changes look sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 (owner: 10Henning Snater) [15:08:13] (03Merged) 10jenkins-bot: Sanitized entity initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 (owner: 10Henning Snater) [15:08:42] think I'll call it a day now... exhausted from weirdnesses and breakage :P [15:09:12] aude: Would be nice if we can get the backports live on monday [15:09:20] at least the dependency one [15:09:22] all in gerrit [15:09:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [15:10:42] [13WikibaseDataModel] 15JeroenDeDauw created 06ediff (+1 new commit): 02http://git.io/Q3rVyA [15:10:42] 13WikibaseDataModel/06ediff 1472040ed 15jeroendedauw: Update references after class got moved to new NS [15:11:17] [13WikibaseDataModel] 15JeroenDeDauw created 06unsd (+1 new commit): 02http://git.io/jZYcpw [15:11:17] 13WikibaseDataModel/06unsd 147c3005d 15jeroendedauw: Removed unused imports [15:12:02] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #129: Update references after class got moved to new NS (06master...06ediff) 02http://git.io/PT-aPg [15:14:24] JeroenDeDauw any problem with DV/Time depending on DV/Number for use of the NumberUnlocalizer interface and stuff? [15:15:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [15:17:07] addshore: does it just use the interface? [15:17:19] addshore: can you point me to where this is done? [15:17:54] JeroenDeDauw: currently at https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/parsers/MWTimeIsoParser.php#L161 [15:18:09] though naturally we are getting rid of the language object, so need something else# [15:18:23] the interface is all that is needed really [15:19:34] (03PS7) 10Thiemo Mättig (WMDE): Find better name for DataUpdateClosure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 [15:20:36] Tobi_WMDE: something wrong with wbjenkins? it just needed a full hour to run a test. [15:20:50] [travis-ci] wmde/WikibaseDataModel/ClaimGuid/661b81e : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30276785 [15:21:49] addshore: indeed, you will need some interface in the time package [15:22:21] addshore: there is no need to go reuse one that already exists. Interfaces ought to serve their users, in this case the time package [15:22:39] So making a new interface, which is meant for your new use case, is very normal [15:23:52] but I won't be able to call it a NumberUnlocalizer :P [15:24:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [15:26:16] addshore: because it is in the same NS? [15:26:22] yup :< [15:27:18] addshore: we really ought to just fix that by putting the stuff in DataValues\Time and perhaps some sub NS such as DataValues\Time\Parsers [15:27:26] Now the NS are like the old package layout, which makes no sense [15:27:51] addshore: if this is a breaking change anyway, perhaps you can do that at the same time? [15:27:56] (meaning same realease) [15:30:29] [13WikibaseDataModel] 15thiemowmde comment on pull request #125 1482370eb: Why no spaces? 02http://git.io/uuFgQA [15:30:37] [travis-ci] wmde/WikibaseDataModel/strct/82370eb : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30276873 [15:30:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [15:31:22] [13WikibaseDataModel] 15thiemowmde comment on pull request #126 14661b81e: Why not do the same in `__toString`? 02http://git.io/igtv_Q [15:34:49] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Track redirects in EPP table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [15:35:12] (03Merged) 10jenkins-bot: Track redirects in EPP table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [15:35:47] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #126 14661b81e: I did not look at __toString. You are right, it calls the getter for even less reason than this code did. 02http://git.io/Gwx_Ew [15:36:02] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/mWZqRw [15:36:02] 13WikibaseDataModel/06master 14c70a34b 15Jeroen De Dauw: Merge pull request #125 from wmde/strct... [15:36:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf14) - 10https://gerrit.wikimedia.org/r/147468 (owner: 10Hoo man) [15:36:32] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/yqgZrA [15:36:32] 13WikibaseDataModel/06master 1432ec7bc 15Jeroen De Dauw: Update bootstrap.php [15:36:47] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #125 1482370eb: Added 02http://git.io/UWzRtA [15:38:29] JeroenDeDauw: I will do, and Ill make a change to all of the other DataValues at some point changing the NSs too [15:39:53] (03CR) 10Thiemo Mättig (WMDE): Resolve redirects in JS config variables. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [15:41:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140007 (owner: 10Thiemo Mättig (WMDE)) [15:42:43] addshore: \o/ [15:42:52] addshore: in that case I'll take care of Geo [15:43:48] JeroenDeDauw: might be worth doing DV/DV and DV/Interfaces first? [15:43:56] and DV/Common [15:43:59] (03PS1) 10Aude: Split parser function rendering and snaks finding code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 [15:44:27] [13Geo] 15JeroenDeDauw closed pull request #8: Pass rawValue and expectedFormat arguments to ParseExceptions (06master...06augmentParseException) 02http://git.io/Ix68hQ [15:44:31] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Declare that wikibase.ValueViewBuilder depends on wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147447 (owner: 10Hoo man) [15:44:42] addshore: good point. will check before I do anything [15:44:47] (03Merged) 10jenkins-bot: Declare that wikibase.ValueViewBuilder depends on wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147447 (owner: 10Hoo man) [15:46:09] aude: can you see if this will not break all of the things? https://github.com/DataValues/Geo/pull/13 [15:46:29] Thiemo_WMDE: y u no rage to aude to have a look at your commit? [15:46:39] I just retriggered the tests for that one btw [15:47:13] (03PS2) 10Aude: Introduce RendererFactory class for parser function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 [15:47:15] (03PS2) 10Aude: Add and improve test cases in RunnerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147430 [15:47:17] (03PS2) 10Aude: Rename and move PropertyParserFunction code to own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 [15:47:19] (03PS2) 10Aude: Split parser function rendering and snaks finding code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 [15:47:21] (03PS2) 10Aude: Move constructor code out of parser function static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 [15:47:23] (03PS2) 10Aude: Move parser function code for site link lookup out of static method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 [15:47:26] JeroenDeDauw: Ill let you take a look at those three base packages before I do Time :) [15:47:34] *do time any more [15:50:50] (03Abandoned) 10Aude: Fix naming of RunnerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147431 (owner: 10Aude) [15:54:16] [13Geo] 15JeroenDeDauw 04force-pushed 06globe-null from 147df4d27 to 146981ea0: 02http://git.io/zftVaQ [15:54:16] 13Geo/06globe-null 146981ea0 15Thiemo Mättig: Globe default value... [15:54:24] (03PS8) 10Thiemo Mättig (WMDE): Partial support for thousands separators in DateTimeParsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 [15:55:23] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147386 (owner: 10Henning Snater) [15:58:04] what's the force push? [15:58:21] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "> thousand separators [...] are in the wrong place" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 (owner: 10Thiemo Mättig (WMDE)) [15:58:22] rebase? [15:59:29] aude: I amended the commit message, to have the CI run again [15:59:33] ok [15:59:46] Scrutinizer failed, so retriggering the tests on Tarvis did not do the trick [15:59:53] ok [16:01:02] [travis-ci] wmde/WikibaseDataModel/private/517785b : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30277327 [16:04:37] [13Geo] 15filbertkm comment on commit 146981ea0: looks reasonable but is appears to be a breaking change for api users (if they forget to specify the globe, then a default is applied)?... 02http://git.io/iyscLA [16:07:37] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/NxyB8Q [16:07:37] 13Geo/06master 148a4e482 15Jeroen De Dauw: Update Geo.php [16:07:52] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/QYkAJg [16:07:52] 13Geo/06master 1475d1e82 15Jeroen De Dauw: Update Geo.php [16:08:17] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/uOdefg [16:08:17] 13Geo/06master 140c74f11 15Jeroen De Dauw: Update README.md [16:10:09] [13Geo] 15JeroenDeDauw 04deleted 06globe-null at 146981ea0: 02http://git.io/m1jlXw [16:10:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [16:13:07] [13Geo] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/78UZ7A [16:13:07] 13Geo/06master 14b5a4d1a 15thiemowmde: Update README.md [16:15:22] [travis-ci] wmde/WikibaseDataModel/ediff/72040ed : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30277629 [16:21:59] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/JLr9Og [16:21:59] 13Geo/06master 145e95f21 15Jeroen De Dauw: Update README.md [16:22:28] (03CR) 10Thiemo Mättig (WMDE): Refactor ChangeOps class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147122 (owner: 10Thiemo Mättig (WMDE)) [16:23:35] [travis-ci] wmde/WikibaseDataModel/unsd/7c3005d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/30277673 [16:26:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [16:30:00] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Hoo, I tried a thin outline and it looks horrible because of the very small size of the icon. Instead I removed the inner circle. Bingo, i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [16:31:47] [13Common] 15JeroenDeDauw 04deleted 06since-always at 147b2c972: 02http://git.io/U1KAFA [16:33:54] omfg.... [16:34:00] the attorcity [16:34:10] addshore: you want to check out this thing https://github.com/JeroenDeDauw/articleimport [16:34:48] * JeroenDeDauw fires himself [16:35:37] [13DataValues] 15JeroenDeDauw closed pull request #5: Remove i18n compatibility shim (06master...06noI18nCompat) 02http://git.io/wWl-7Q [16:36:45] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/r8u5xQ [16:36:45] 13DataValues/06master 14e6f0971 15Jeroen De Dauw: Update DataValues.php [16:37:36] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/jQk4Jw [16:37:36] 13DataValues/06master 14772a7ea 15Jeroen De Dauw: Update bootstrap.php [16:38:20] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Tested. Works. No +2 to give the team some time to have a look. Feel free to merge." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147351 (https://bugzilla.wikimedia.org/68152) (owner: 10Hoo man) [16:38:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147429 (owner: 10Aude) [16:38:50] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/MQp9pA [16:38:50] 13DataValues/06master 14336dde4 15Jeroen De Dauw: Update composer.json [16:41:01] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/RcI1ZQ [16:41:01] 13DataValues/06master 14025ff83 15jeroendedauw: Bump to 1.0 alpha [16:41:06] (03PS3) 10Thiemo Mättig (WMDE): Add empty badge icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 [16:43:24] [13DataValues] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/Ureebw [16:43:24] 13DataValues/06master 144c241c7 15jeroendedauw: Do not use PHPUnit strict mode by default [16:45:51] addshore: what would you change NS wise in data-values/data-values? [16:48:01] JeroenDeDauw: *looks* [16:48:59] *addshore died* [16:49:12] hmm JeroenDeDauw I guess those would proabbly be okay [16:49:28] oh [16:49:37] I thought you where looking at the old repo I linked :D [16:50:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147430 (owner: 10Aude) [16:53:31] articleimport ? :P [16:53:51] *dies* [16:53:56] addshore: heeeeelp! :D [16:54:38] addshore: you have to admit, randomly calling ini_set somewhere in the code is brilliant [16:54:39] addshore: i need http://tools.wmflabs.org/wikidata-analysis/map.png in larger but i don't remember the correct filename for the larger versions [16:54:55] nyan.gif [16:54:58] :P [16:55:08] Lydia_WMDE: I believe they might be huge and massive [16:55:09] Lydia_WMDE: map.png^2 [16:55:34] addshore: nope :( [16:55:40] tried big huge large and massive [16:56:06] addshore: argh! [16:56:12] have to use _ instead of - [16:56:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147412 (owner: 10Aude) [16:56:13] *looks* [16:56:16] haha :P [16:56:17] * Lydia_WMDE grumbles [16:56:22] * addshore pats Lydia_WMDE [16:56:25] *sob* [16:56:29] whyyyyyyyy [16:56:37] also why are they not linked -.- [16:56:45] :D [16:56:47] * Lydia_WMDE will make lucie fix this [16:58:18] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/W2yRMg [16:58:18] 13Geo/06master 14acbc501 15jeroendedauw: Update PHPUnit bootstrap [16:59:58] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/5v7zPw [16:59:58] 13Geo/06master 14ce6ee60 15jeroendedauw: Update composer.json [17:01:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147500 (owner: 10Aude) [17:02:35] Lydia_WMDE: people are moaning about Wikinews P1 on WD:DEV so; go answer :p [17:03:47] JohnLewis: i will. but not before monday probably. i need to clarify some things first [17:04:01] Lydia_WMDE: k [17:07:40] addshore: meh, y phpstorm no has NS move feature? [17:07:41] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147418 (owner: 10Aude) [17:07:48] JeroenDeDauw: they do, dont they..? [17:08:04] Refactor > Move [17:08:18] :P [17:09:10] F6! [17:13:26] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147416 (owner: 10Aude) [17:18:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/119973 (owner: 10Thiemo Mättig (WMDE)) [17:22:53] addshore: yeah, but that is per class [17:22:59] And it does not up everything [17:23:10] @covers tags [17:23:22] And the names in assertInstanceOf [17:23:37] Still better than nothing tho [17:24:18] [13Geo] 15JeroenDeDauw created 06mv (+1 new commit): 02http://git.io/NlOaJQ [17:24:18] 13Geo/06mv 14721e29d 15jeroendedauw: Move classes into DataValues\Geo namespace [17:24:23] addshore: https://github.com/DataValues/Geo/pull/16 [17:24:28] [13Geo] 15JeroenDeDauw opened pull request #16: [WIP] Move classes into DataValues\Geo namespace (06master...06mv) 02http://git.io/yJL2-g [17:24:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147400 (owner: 10Thiemo Mättig (WMDE)) [18:12:39] Lydia_WMDE: hey ho :) [18:13:09] just wanted to let you know that I'm on vacation the next week and will probably not be available in IRC and on wiki [18:22:21] [13Geo] 15JeroenDeDauw 04force-pushed 06mv from 14721e29d to 1442a0c7f: 02http://git.io/qnKXXA [18:22:21] 13Geo/06mv 1442a0c7f 15jeroendedauw: Move classes into DataValues\Geo namespace [18:22:48] benestar: thanks for letting me know! and enjoy your vacation! [18:23:57] addshore: done moving [18:24:01] addshore: https://github.com/DataValues/Geo/pull/16 [18:24:44] addshore: what do you think is best for the two value classes? DataValues\Geo or DataValues\Geo\Values ? [18:25:35] [13Geo] 15JeroenDeDauw pushed 1 new commit to 06mv: 02http://git.io/HkX9Dg [18:25:35] 13Geo/06mv 14392477c 15jeroendedauw: Remove duplicate array key [18:31:54] anyone around who speaks french and can help me sort out https://www.wikidata.org/wiki/Q3261371 ? the date of birth/death is implausible [18:32:24] Lydia_WMDE, looking [18:32:31] thanks yannf :) [18:33:38] yannf: my suspicion is this is about two different people [18:33:40] yes, of course, fr.wp says 1905 [18:33:57] right but http://www.assemblee-nationale.fr/sycomore/fiche.asp?num_dept=1288 [18:34:05] which is where the dod comes from [18:34:27] likely explanation: two different people [18:34:32] but i am not sure [18:35:02] yes, of cource [18:35:13] https://fr.wikipedia.org/wiki/Louis_Brunet_(homme_politique,_1847-1905) [18:35:59] Lydia_WMDE: https://www.wikidata.org/w/index.php?title=Wikidata:Project_chat&diff=prev&oldid=145713945 - Someone wants to say something to you :p [18:36:26] JohnLewis: lol are you sure this is targetted at me? :P [18:36:47] Lydia_WMDE: Well you are the product manager of the product they are commenting at so yes :p [18:37:00] logical [18:37:08] you must be spock :D [18:37:32] Lydia_WMDE, fixed [18:37:39] yannf: <3 [18:38:03] * Lydia_WMDE goes on and fixes more implausible people :P [18:39:17] Louis BRUNET [18:39:18] (1899 - 1987) is not on WP, surpringly [18:40:41] oh yes, he is https://fr.wikipedia.org/wiki/Louis_Brunet_(homme_politique,_1899-1987) [18:45:12] btw, there is also Louis Brunet (1870-1927), also a French politician [18:47:22] -.- [18:47:34] not very creative those french politians :D [18:47:45] politicians even [18:48:07] Lydia_WMDE: Neither are these Wikimedia Deutschland folks :D [18:48:12] [assumes he spelt that right] [18:48:12] bah :P [19:41:30] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147621 (owner: 10L10n-bot) [19:57:25] hello :) [19:58:38] I think I found a bug. For the date of birth property, if I write November 1950 (month and year only), everything is ok. Now, for the months of February, August and December, if I write February 1950, it puts me 1 February 1950 [20:04:14] Lydia_WMDE: --^ [20:08:59] https://bugzilla.wikimedia.org/68233 [20:09:05] :) [20:09:27] thepwnco: deleting Help:Files for you now [20:10:41] greg-g: thanks for the link; tagged and stuff :) [20:13:23] addshore: y u no review? :( [20:13:29] https://github.com/DataValues/Geo/pull/16 [20:13:49] thepwnco: deleted now [20:15:38] [13Geo] 15addshore closed pull request #16: Move classes into DataValues\Geo namespace (06master...06mv) 02http://git.io/yJL2-g [20:15:45] [13Geo] 15addshore 04deleted 06mv at 14392477c: 02http://git.io/YLpAng [20:16:27] weeeeeeeeeeeeeee [20:20:45] Okki: I can't seem to reproduce the issues on testwikidata. [20:27:00] It's ok for me on testwikidata [20:27:34] But on https://www.wikidata.org/wiki/Q3972245 if I put date of birth, and december 1950, I've the bug [20:28:22] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #126: Minor tweaks in ClaimGuid (06master...06ClaimGuid) 02http://git.io/pa1W5g [20:28:29] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06ClaimGuid at 14661b81e: 02http://git.io/3V6Lig [20:28:53] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/JqNPcA [20:28:53] 13WikibaseDataModel/06master 14fabf4a5 15Jeroen De Dauw: Update ClaimGuid.php [20:28:53] Okki: I can't confirm it there either. [20:29:02] See my last addition to the page [20:29:03] <20WAAR1EB> [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06unsd at 147c3005d: 02http://git.io/vuvvaQ [20:29:04] <7GHAAANU9> [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/Od0SXQ [20:29:04] <7GHAAANU9> 13WikibaseDataModel/06master 14f51a4a7 15Jeroen De Dauw: Merge pull request #127 from wmde/unsd... [20:29:21] Easy reviews are easy! https://github.com/wmde/WikibaseDataModel/pulls (first two PRs) [20:29:59] JeroenDeDauw: Impossible if we can't merge :p [20:35:11] JohnLewis: my Wikidata interface is in French. If I change to English, it seems to solve the problem [20:35:27] That changes everything. [20:36:01] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/yIFQ2g [20:36:01] 13WikibaseQuery/06master 14cf57850 15jeroendedauw: Update QE version [20:39:12] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ujqHeg [20:39:12] 13WikibaseQuery/06master 1421bca89 15jeroendedauw: Update test docs [20:55:56] JohnLewis: I've another bug :) [20:55:59] JohnLewis: If I go to the website without login, I have the English interface. Now, if I use ?uselang=fr&setlang=fr in the url, everything is in French (interface and properties), but if I add "date de naissance" (date of birth) and I put a date in French (like "18 juillet 2014"), I get "The time value is malformed. The same date in English is ok. [20:57:35] Hm [21:00:01] Same problem in italian [21:00:07] https://www.wikidata.org/wiki/Q3972245?uselang=it&setlang=it [21:00:18] data di nascita and 18 luglio 2014 ... [21:16:43] [13WikibaseQuery] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/KVE31w [21:16:43] 13WikibaseQuery/06master 142a49cc6 15jeroendedauw: Update dependencies [21:40:53] Okki: maybe you can report all those issues on https://www.wikidata.org/wiki/WD:DEV ? [21:46:18] With the help of Dereckson, we made ​​two bug reports : https://bugzilla.wikimedia.org/show_bug.cgi?id=68233 and https://bugzilla.wikimedia.org/show_bug.cgi?id=68236 [21:50:33] [13WikibaseQuery] 15JeroenDeDauw created 06importcli (+1 new commit): 02http://git.io/cuzQOQ [21:50:33] 13WikibaseQuery/06importcli 14f630a0c 15jeroendedauw: Add command to the CLI to import entities into the store [21:51:03] [13WikibaseQuery] 15JeroenDeDauw opened pull request #40: Add command to the CLI to import entities into the store (06master...06importcli) 02http://git.io/wGkadg [21:54:27] [travis-ci] wmde/WikibaseQuery/importcli/f630a0c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/30309846