[00:48:05] pajz: https://www.wikidata.org/w/index.php?title=Q3875012&diff=145206372&oldid=66130665 https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Q15812131 [01:03:18] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #124 1480ee913: It's inefficient to do this with a fetter anyway. Just access the props 02http://git.io/cyn3Sg [01:04:03] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06typehints at 1480ee913: 02http://git.io/SyRXzQ [01:06:35] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #71 14c8616b2: You sure this does not cause notices when $object is null or a scalar? 02http://git.io/y59TqA [01:54:08] (03PS6) 10Aude: Restructure parser function code with more, better tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [01:56:50] (03PS7) 10Aude: Restructure parser function code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [02:00:21] (03CR) 10Aude: "replies and willing to move the code into a subdirectory / namespace, although need to think some about naming." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [02:08:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [02:11:09] (03PS8) 10Aude: Restructure parser function code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [02:18:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [02:23:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [07:36:48] (03PS9) 10Aude: Restructure parser function code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [07:42:31] (03PS10) 10Aude: Restructure parser function code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 [07:44:29] [13ValueView] 15snaterlicious created 06fixtests (+2 new commits): 02http://git.io/Klifzw [07:44:29] 13ValueView/06fixtests 148a92253 15snaterlicious: Fixed $.ui.inputExtender tests... [07:44:29] 13ValueView/06fixtests 140302de1 15snaterlicious: Fixed $.animateWithEvent tests... [07:44:51] (03CR) 10Aude: "open to suggestions, especially on naming :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [07:46:17] [13ValueView] 15snaterlicious opened pull request #86: Fixed QUnit tests (06master...06fixtests) 02http://git.io/AW9P-A [07:51:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [07:55:35] (03PS1) 10Henning Snater: Fixed tagadata tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147047 [07:55:37] (03PS1) 10Henning Snater: Improved EditableValue's event management [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 [08:00:21] [07/17/14 02:48:05] pajz: https://www.wikidata.org/w/index.php?title=Q3875012&diff=145206372&oldid=66130665 https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Q15812131 -> thank you! [08:00:43] Is "Sir" a noble title or an honorific prefix? [08:01:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [08:03:04] Josve05a> It indicates that a person is a member of a 'knightly order', but doesn't indicate a grant of nobility. [08:03:28] pajz> No problem. [08:11:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147047 (owner: 10Henning Snater) [08:17:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 (owner: 10Henning Snater) [08:22:56] (03PS1) 10Henning Snater: (hotfix) Inject API into initTermBox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147057 [08:32:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147057 (owner: 10Henning Snater) [08:35:46] um [08:35:53] autocomplete is broken yes? [09:11:03] [13WikibaseDataModel] 15thiemowmde comment on pull request #124 1480ee913: It's the most simple getter you can have. I'm pretty sure either the compiler or the optimizer/accelerator knows this and creates the same byte code anyway. I love micro optimizations, but in this case it's really pointless. 02http://git.io/oSUhug [09:25:51] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #71 14c8616b2: Yes. Just tested it again to be sure. [Manual](http://php.net/manual/en/language.operators.type.php) says: "instanceof does not throw any error if the variable being tested is not an object, it simply returns FALSE. Constants, however, are not allowed." 02http://git.io/LF9Kbw [09:47:48] (03CR) 10Thiemo Mättig (WMDE): [C: 032] (hotfix) Inject API into initTermBox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147057 (owner: 10Henning Snater) [09:48:07] (03Merged) 10jenkins-bot: (hotfix) Inject API into initTermBox [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147057 (owner: 10Henning Snater) [10:01:05] (03PS1) 10WikidataBuilder: New Wikidata Build - 17/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147074 [10:08:06] benestar|cloud: ping [10:09:29] my bot just passed it's 15M edit in Wikidata! [10:09:35] *its [10:09:51] https://www.wikidata.org/wiki/Special:CentralAuth/Dexbot [10:14:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/147074 (owner: 10WikidataBuilder) [10:20:36] benestar|cloud: I've added a new bug for linking to Special:SetSiteLink from the badge icons in the sitelink UI: https://bugzilla.wikimedia.org/show_bug.cgi?id=68152 [10:53:45] (03PS3) 10Thiemo Mättig (WMDE): Badges: Add PNG fallback and optimize SVG [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 [11:03:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [11:12:21] (03CR) 10Henning Snater: [C: 04-1] "Firefox CSS hack does not seems to be necessary. Changes in EditableSiteLink look fishy - will amend the change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [11:32:35] https://integration.wikimedia.org/ci/job/browsertests-Wikidata-wikidata.beta.wmflabs.org-linux-firefox-sauce/ [11:32:38] \o/ [11:33:08] Lydia_WMDE: we're getting closer on running our browsertests on WMF jenkins.. [11:39:08] \o/ [11:39:11] Tobi_WMDE: the branch is ready? (no new bugs?) [11:39:19] yay jenkins [11:40:11] Tobi_WMDE: If you got time, Thiemo and I would also like to see the browser tests being run on https://gerrit.wikimedia.org/r/145257 [11:40:22] (03PS23) 10Henning Snater: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [11:42:22] DanielK_WMDE: around? [11:50:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [11:51:09] (03CR) 10Henning Snater: [C: 032] Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [11:51:30] (03Merged) 10jenkins-bot: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [11:52:21] (03PS4) 10Henning Snater: Badges: Add PNG fallback and optimize SVG [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [11:57:46] aude: just got in. what's up? [11:59:43] DanielK_WMDE: I'll be in the office from Tuesday to Thursday next week, will you also be around? [11:59:51] I would like to talk about our Lua interfaces [12:00:29] Tuesday and Wednesday, yes [12:02:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [12:03:46] DanielK_WMDE: and can you review https://gerrit.wikimedia.org/r/#/c/144965/ again? [12:03:52] stuff is starting to pile up [12:04:29] (03CR) 10Henning Snater: [C: 04-1] "Yes, we need that to support IE8. But, IE9 would also use the png now. I'd rather opt for the simpler multiple backgrounds method." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [12:04:47] naming suggestions and whatnot welcome on https://gerrit.wikimedia.org/r/#/c/145572/ [12:13:05] Tobi_WMDE: \o/ [12:17:56] (03CR) 10Henning Snater: [C: 032] "OK, let's merge anyway." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [12:18:08] (03Merged) 10jenkins-bot: Badges: Add PNG fallback and optimize SVG [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [12:35:52] [13ValueView] 15thiemowmde comment on pull request #86 140302de1: The `2` here is obviously a mistake, please have a look. 02http://git.io/2CXoqg [12:45:40] (03CR) 10Daniel Kinzler: Lua: Add integration tests for the 'allowArbitraryDataAccess' setting (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [12:46:06] (03CR) 10Daniel Kinzler: [C: 031] "looks good with the follow-up, didn't verify." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144965 (https://bugzilla.wikimedia.org/67538) (owner: 10Hoo man) [12:46:19] aude: --^ [13:03:57] DanielK_WMDE: How should self::$oldAllowArbitraryDataAccess be null? [13:04:10] Could only be if phpunit screws up the way it calls stuff [13:04:20] or a child screws with calling parent::setUp [13:05:16] hoo: *you* know that it can't be null. the method that uses it doesn't have that guarantee [13:06:01] hoo: it's just good practice to be defensive. code may change, and the person who changes it may nto be you. it may not be obvious to them what other code needs to be adapted [13:06:11] it's not a big deal, my +1 still applies [13:06:14] just somethign i noticed [13:06:19] yeah, ok, I'll amend [13:06:23] can we push it then? :P [13:06:38] Stuff starts to pile especially with Katie's parser function refactor [13:07:21] hmhm... i'd be more comfortable with her merging it, since she verified. [13:07:31] but i can merge it it's urgebnt [13:09:26] it's not, but I think she wants you to merge :P [13:13:28] (03PS3) 10Hoo man: Lua: Add integration tests for the 'allowArbitraryDataAccess' setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 [13:14:26] (03CR) 10Hoo man: Lua: Add integration tests for the 'allowArbitraryDataAccess' setting (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [13:14:51] (03CR) 10Hoo man: "Addressed Daniel's comment (check the old value of the setting for null)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [13:21:07] (03CR) 10Hoo man: "> can try to split in smaller patches if that helps" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [13:23:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [13:33:16] Tobi_WMDE: Can you run the browser tests over https://gerrit.wikimedia.org/r/145257 ? [13:33:31] I played with it manually yesterday and it seems fine, but you never know [13:38:46] (03PS5) 10Hoo man: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [13:39:04] (03CR) 10Hoo man: "Manually rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [13:48:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [13:53:09] (03PS1) 10Hoo man: Wikibase RL module shouldn't depend on wikibase.templates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147104 [13:53:34] Tobi_WMDE: Thiemo_WMDE: ^ [13:53:38] Should be an easy merge [13:54:02] that's the cause for the circular dependency problems I saw with one of Adrian's patches yesterday [13:56:58] hoo: is the general direction of https://gerrit.wikimedia.org/r/#/c/145572/ ok? [13:57:07] can then try to split [14:00:07] aude: I guess it's ok, yes [14:00:34] although it makes stuff a little harder to follow then the old rather smallish class [14:00:58] hoo: will run some tests a bit later on that change [14:01:06] Great :) [14:01:06] have to test the build first a bit more [14:01:10] Yeah [14:01:35] hoo: the old classes are smallish? [14:01:43] I hope I don't break it again... Adrian's change conflict with other changes by Adrian, that's why I spend a lot of time rebasing lately [14:01:47] hoo: aude: whatever is on beta at the moment passed all the selenium tests today. [14:02:06] aude: Well 250 lines smallish :P [14:02:20] zelkof and I migrated the selenium job to the WMF jenkins today: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-wikidata.beta.wmflabs.org-linux-firefox-sauce/ [14:02:58] hoo: in mediawiki standards, perhaps [14:03:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147104 (owner: 10Hoo man) [14:03:02] Tobi_WMDE: yay! [14:03:33] aude: Well, I just say that I find it a little hard to understand the code flow in your new classes... we have renderers and handlers and... :P [14:03:40] aude: did we have a build merged today? [14:04:03] A build from today would be different from the branch yesterday [14:04:18] hoo: that's why I'm asking [14:04:19] after the cut I started merging Adrian's JS patches that were a bit more risky [14:04:28] I'm wondering what is deployed on beta currently [14:04:35] hoo: how would you do? [14:05:02] alright. today's build wasn't merged yet [14:05:36] aude: that's a tough question... my arbitrary access patch yesterday added way to much static code... I guess I would have made some kind of creator/ factor for the code that is currently static in the function [14:05:45] not sure I would have created this many classes [14:05:58] but we at least should find a better name for the handler things [14:06:10] Hi everyone, I was wondering how to get the language mappings between different wikipedia pages. This information seems to be available on Wikidata, but I can't figure out how to get a dump. The "Wiki interlanguage link records" at http://dumps.wikimedia.org/wikidatawiki/20140705/ looked promising but that seems to contain user information if I'm not mistaken. [14:06:39] Then in the #mediawiki channel someone recommended the "Interwiki link tracking records" but those seem to also contain al sorts of other links, and I don't see a way to filter out the "in other languages" links. Any thoughts? [14:07:30] hoo: probably more legacy code will be killed, so then less stuff [14:07:52] yeah [14:08:09] aude: Daniel is ok with merging the Lua patches, btw, if you want to [14:08:13] * hoo would love that [14:08:37] hoo: aude: to be on the save side this time I'm going to run the whole browser testset on test.wikidata tomorrow again [14:09:06] +1 [14:09:21] (03PS2) 10Henning Snater: Wikibase RL module shouldn't depend on wikibase.templates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147104 (owner: 10Hoo man) [14:12:22] (03PS6) 10Hoo man: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:12:48] (03CR) 10jenkins-bot: [V: 04-1] Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:12:50] woops [14:13:37] (03PS7) 10Hoo man: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:14:37] (03CR) 10Hoo man: "Rebased on top of the changes that removes the dependency on 'wikibase.templates' from 'wikibase'" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:20:39] where is jenkins https://gerrit.wikimedia.org/r/#/c/144965/ ? [14:21:40] aude: gerrit had troubles yesterday, might be that stuff got lost in the pipe? [14:21:49] I guess you can rebase to get it to run, if you want [14:26:33] * hoo facepalms hard [14:26:46] if ( defined( 'ULS_VERSION' ) ) { [14:26:46] $modules['wikibase.sites']['dependencies'] = array( 'ext.uls.mediawiki' ); [14:26:48] -.- [14:27:27] and I was about to kill resource loader :P [14:28:32] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147104 (owner: 10Hoo man) [14:30:06] hoo: so you did not have ULS installed? [14:30:18] Tobi_WMDE: I did, that was the problem [14:30:31] the code completely overwrite the deps for the wikibase.sites module [14:30:33] what? [14:30:38] thus the actual sites aren't loaded :P [14:30:40] ah, yes [14:30:41] Yeah, it's bad [14:30:47] ha! [14:31:09] so the wikibase.templates stuff wans't necessary either [14:31:17] (03PS8) 10Hoo man: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:31:21] but it's nicer anyway [14:31:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:32:04] (03CR) 10Hoo man: "Fixed insane ULS injection code... -.- m(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:32:19] Tobi_WMDE: Want to merge the wikibase.templates change? [14:33:18] I feel like I spent half of the week rebasing because of dependent changes [14:33:49] hoo: what a moment.. I'm currently testing the change by adrian you pointed me to earlier [14:33:53] *wait [14:33:58] ok [14:36:14] hoo: should I just test that specific change or the whole chain od changes? [14:36:34] Tobi_WMDE: one at a time [14:36:52] they need rebasing all the time anyway :/ [14:37:04] hoo: ok, I'm not going to run ALL the tests then.. [14:41:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:47:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [14:48:41] hoo: QUnit tests are broken. [14:48:55] would be nice to have hennings fixes in before we merge more stuff [14:48:59] https://gerrit.wikimedia.org/r/#/q/owner:%22Henning+Snater%22+status:open,n,z [14:49:11] and https://github.com/wmde/ValueView/pull/86 [14:49:27] going to have a look in a moment [14:49:41] hoo: yeah, hard to test otherwise [14:50:34] hoo: browsertests still running.. no probs so far.. fingers crossed [14:52:10] :) [14:53:07] I now realized why people keep calling me review bot... /me is doing reviews all day now basically [14:53:36] hoo: you should change your nickname [14:54:01] :D [14:54:17] I already told Adrian to get a sock puppet so that he can review his stuff on his own :D [14:55:31] whoot?? my rubymine license just expired?? [14:55:56] what's taht? An ide? [14:56:13] yeah, same as PHP storm just for ruby [14:56:20] I see [15:05:59] hoo: browsertests seem fine for https://gerrit.wikimedia.org/r/#/c/145257/ [15:06:24] but as I said, cannot verify the QUnit tests until the fixes are merged [15:06:45] Tobi_WMDE: Working on that atm [15:09:37] (03CR) 10Tobias Gritschacher: [C: 031] "Works for me and fixes the tagadata tests. Someone else should check the changes to the tagadata.js file.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147047 (owner: 10Henning Snater) [15:10:10] [13ValueView] 15mariushoch pushed 1 new commit to 06fixtests: 02http://git.io/A2kLPQ [15:10:10] 13ValueView/06fixtests 142ef61d2 15Marius Hoch: Fix jquery.animateWithEvent.tests.js test [15:10:51] Lydia_WMDE: ping [15:10:58] matanya: hey [15:11:19] github m( [15:12:34] hi Lydia_WMDE you sent out a list for featured and stuff. two comments: would be easier if it was sorted by ABC. and I didn't see hewiki there [15:12:55] (03PS9) 10Henning Snater: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [15:13:26] matanya: indeed not in there. would you mind replying to the email so i have it all in one place when we do the configuration? thank you so much! [15:13:38] sure [15:13:39] and yeah alphabetical would have been better -.- [15:15:21] Henning_WMDE: did the "2" have a special meaning here? https://github.com/wmde/ValueView/pull/86#discussion_r15053940 [15:15:23] Qunit's docs suck -.- [15:17:15] (03CR) 10Tobias Gritschacher: [C: 031] "Tests fixed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 (owner: 10Henning Snater) [15:18:02] hoo: please revert your last commit to https://github.com/wmde/ValueView/pull/86 [15:18:06] that was ok [15:18:25] Yeah, I only now realized that [15:18:31] but it also doesn't harm [15:18:38] Qunit's docs suck, btw [15:18:47] (realized that before, but forgot about it again meanwhile) [15:19:42] matanya: hewiki uses a custom script https://he.wikipedia.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:FeaturedInterwiki.js apparently [15:19:48] that's why we didn't find it [15:19:53] right [15:20:54] Tobi_WMDE: That's the thing that give the number of asserts run, right [15:21:02] yes [15:21:05] My Qunit memories start to come back [15:21:07] yikes :D [15:21:47] hoo: is that like wartime flashbacks? PTSD? [15:21:57] [13ValueView] 15mariushoch pushed 1 new commit to 06fixtests: 02http://git.io/hbVsRw [15:21:57] 13ValueView/06fixtests 14d97ccf1 15Marius Hoch: Revert "Fix jquery.animateWithEvent.tests.js test"... [15:22:14] DanielK_WMDE: A little :P They used to require that to be correct [15:22:23] but seems they made it optional since I last looked [15:22:55] and according to the super mega documentation of Qunit it's not supported at all any longer... [15:22:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [15:23:34] [13ValueView] 15snaterlicious comment on pull request #86 14d97ccf1: Specifies expected assertions (see actual QUnit code, not docs). 02http://git.io/-COfMw [15:24:27] (03CR) 10Aude: [C: 04-1] "splitting this into multiple patches" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145572 (owner: 10Aude) [15:24:44] (03PS1) 10Aude: Remove $entityId and $parser from PropertyParserFunction constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 [15:25:22] Tobi_WMDE: Henning_WMDE: Can we merge that now? I volunteer to do a 0.6.5 release after [15:25:31] * hoo wants to finally move forward with the JS stuffs [15:27:25] (03CR) 10Aude: [C: 032] "verified, looks good" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144965 (https://bugzilla.wikimedia.org/67538) (owner: 10Hoo man) [15:27:41] (03Merged) 10jenkins-bot: Lua: Allow arbitrary item access [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144965 (https://bugzilla.wikimedia.org/67538) (owner: 10Hoo man) [15:27:56] (03CR) 10Aude: [C: 032] "merge it! :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [15:28:08] (03CR) 10Hoo man: [C: 032] "Works fine now, old functions stay around for b/c (needed for user scripts and gadgets)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [15:28:13] (03Merged) 10jenkins-bot: Lua: Add integration tests for the 'allowArbitraryDataAccess' setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145261 (owner: 10Hoo man) [15:28:24] (03Merged) 10jenkins-bot: Move sites-related methods from wikibase to wikibase.sites [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143867 (owner: 10Adrian Lang) [15:29:28] hoo: yes, please merge the test fixes [15:29:39] we should not merge other JS before we can run the QUnit tests again [15:29:50] (03PS2) 10Aude: Remove $entityId and $parser from PropertyParserFunction constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 [15:29:58] Tobi_WMDE: Probably [15:30:06] [13ValueView] 15mariushoch 04deleted 06fixtests at 14d97ccf1: 02http://git.io/znJF-g [15:30:09] Approved now as they pass locally [15:30:11] Definitely :D [15:30:39] hoo: can you make the tag for valueview or should I? [15:31:01] Tobi_WMDE: I can [15:31:12] There's some other stuff in there which Thiemo wanted AFAIR [15:31:23] but only fixes so can be a minor [15:31:26] (03PS1) 10Thiemo Mättig (WMDE): Fix LabelDescriptionUniquenessValidator not working [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 [15:32:26] hoo: ok, but don't forget to update the release notes before tagging [15:32:31] hoo: Tobi_WMDE: Btw: There is also a fix for the tests here: https://github.com/wmde/WikibaseDataModelJavascript/pull/10 [15:32:37] and version in valueview.php [15:32:42] Tobi_WMDE: On that literally now [15:32:50] Henning_WMDE: ahhhhh [15:33:00] ... going to have a look at that later [15:34:40] (03PS1) 10Thiemo Mättig (WMDE): Refactor ChangeOps class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147122 [15:35:31] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/wTDmTw [15:35:31] 13ValueView/06master 140fe40c8 15Marius Hoch: Update Version and Release notes [15:36:26] [13ValueView] 15mariushoch tagged 060.6.5 at 06master: 02http://git.io/Cruq7Q [15:38:06] aude: can https://bugzilla.wikimedia.org/show_bug.cgi?id=67538 be closed? or s there something missing for LUA? [15:38:24] Can be closed [15:38:29] done [15:38:31] ok [15:38:31] close [15:38:43] (03PS3) 10Aude: Remove $entityId and $parser from PropertyParserFunction constructor params [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 [15:38:45] (03PS1) 10Aude: Rename PropertyParserFunction class to PropertyParserFunctionRunner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147125 [15:38:46] aude: We need to change the configuration or people might go crazy [15:39:02] ? [15:39:18] aude: Default setting allow arbitrary data access [15:39:22] yes [15:39:23] * allows [15:39:30] we need to switch it for Wikipedia in time [15:39:35] * Wikipedias [15:39:38] do it now, if you like [15:39:52] no harm to set a non-existing setting now [15:39:57] ok... can we set the settings before they're introduced or will SettingsArray cry? [15:40:04] ah, question answered [15:40:05] we can [15:40:13] Will do in a minute :) [15:40:15] ok [15:40:45] (03PS1) 10Hoo man: Bump ValueView to 0.6.5 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147128 [15:42:11] aude: Shall we switch it off for all wikis or allow on test? [15:42:25] or test2 [15:42:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [15:42:41] we will allow on test but don't have to do that right now [15:42:59] Ok, we can do that before the actual arbitrary access goes liv [15:43:00] probably monday, we can schedule slot to enable this + the client on test.wikidata [15:43:00] e [15:43:12] per discussion with tobi and lydia [15:43:26] ah, nice [15:43:26] to let this stuff sit and be tested more than the usual few days [15:43:43] Might be that I'm in the train during that deploy [15:44:22] though there won't be arbitrary access yet :/ [15:44:36] we can test the site links part [15:44:41] right, it's not in wmf14 [15:45:57] why are repo tests failing on client patch? [15:45:59] hoo: https://gerrit.wikimedia.org/r/#/c/147128/ should not be necessary [15:46:22] waiting for packagist it seems [15:46:35] aude: what patch? [15:46:47] aude: mh... with --prefer-source it worked for me locally [15:47:19] Tobi_WMDE: No, that's clearly the way to go... if we say that 0.6.4 is ok also composer might choose to stick with that [15:47:22] which means awry tests [15:47:27] i have follow up patchsets so it will try again [15:47:33] i think just a temporary glitch [15:47:45] https://gerrit.wikimedia.org/r/147116 [15:47:48] hoo: shouldn't it always get the highest stable version that's in the range? [15:48:10] why are we using this semantic versioning then [15:48:11] Tobi_WMDE: it can choose not to in certain conditions [15:48:17] * aude should go socialize :p [15:48:28] aude: Conference ongoing at WMDE, right? [15:48:30] then the versioning how we do is pointless [15:48:35] would be nice to have my patches reviewed so i don't get too long of a chain [15:48:41] hoo: berlin but not wmde [15:48:49] oh, I see [15:48:58] we could then rather just specify the exact version always [15:49:02] * aude socialize and might be around later [15:49:13] but nevermind [15:49:16] I'm ok with it [15:49:23] need to leave [15:49:32] Tobi_WMDE: If I understood Jeroen right, we should push it if we really want it, but maybe I didn't [15:49:38] so +2 fast? [15:50:00] (03CR) 10Tobias Gritschacher: [C: 032] Bump ValueView to 0.6.5 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147128 (owner: 10Hoo man) [15:50:17] jenkins should do the +2 verified.. ;) [15:50:19] (03Merged) 10jenkins-bot: Bump ValueView to 0.6.5 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147128 (owner: 10Hoo man) [15:50:27] or not [15:50:28] :) [15:58:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [16:00:18] aude: Should we also make a WikibaseDataModelJavascript minor release? [16:09:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 (owner: 10Thiemo Mättig (WMDE)) [16:10:13] (03PS1) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 [16:11:05] (03CR) 10Hoo man: [C: 04-1] "Please add a small comment to the change telling why we need to apply stuff to a copy in validate, I don't think that's obvious on first s" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 (owner: 10Thiemo Mättig (WMDE)) [16:12:46] (03CR) 10Hoo man: "Test case is quite nice, I like it" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 (owner: 10Thiemo Mättig (WMDE)) [16:20:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147122 (owner: 10Thiemo Mättig (WMDE)) [16:23:27] (03CR) 10Hoo man: [C: 032] "Changes look sane, tests pass locally" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147047 (owner: 10Henning Snater) [16:23:51] (03Merged) 10jenkins-bot: Fixed tagadata tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147047 (owner: 10Henning Snater) [16:24:04] (03PS2) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) [16:27:46] (03PS2) 10Hoo man: Improved EditableValue's event management [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 (owner: 10Henning Snater) [16:29:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [16:30:53] (03PS1) 10Thiemo Mättig (WMDE): [WIP] API test for label/description conflicts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147140 [16:33:18] hoo: 0.6.5 is not ready to be released... https://github.com/wmde/ValueView/issues?milestone=4 [16:34:17] Thiemo_WMDE: Move that to 0.6.6 then [16:34:21] not a critical bug, really [16:35:09] i disagree. [16:36:12] so you want to amend the release?! [16:36:54] i'm asking why this patch is not part of the release. [16:37:17] because it has a "-1" on it (or something like that, as github doesn't have -1es) [16:37:51] do you agree to the comment? because i clearly don't. [16:38:17] I don't think the changes are needed, the line is ok as is [16:38:36] "not needed" is true for about 90% of the stuff we do. [16:38:55] i find that a strange argument. [16:39:36] Thiemo_WMDE: The if is good enough as is, if you want to factor that into a help function, module or component, you can do that [16:39:40] IMO it can stay inline [16:39:48] i'm aware that nobody is using the milestone feature on github, not even jeroen. but in this case i started using it. [16:40:53] i don't want to change this patch, this would just blow up the code for no good reason. [16:41:40] this stupid change is rotting for exactly 2 weeks now and blocks every other possible improvement on the broken suggester. [16:41:44] merged [16:41:52] [13ValueView] 15mariushoch closed pull request #82: Restrict select to left click (06master...06leftclick) 02http://git.io/anGQ1Q [16:41:52] I don't care enough for Jeroen's comment [16:42:07] thanks. [16:42:43] do you want to amend 0.6.5? That's evil and ugly, but github allows release to change [16:42:49] * releases [16:44:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147125 (owner: 10Aude) [16:44:45] Tobi_WMDE: do the tests really work for you with Henning's last patch? I still see occasional failures [16:47:36] maybe it was just my cache [16:48:21] (03CR) 10Hoo man: [C: 032] "Tests pass now, changes look sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 (owner: 10Henning Snater) [16:48:40] (03Merged) 10jenkins-bot: Improved EditableValue's event management [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 (owner: 10Henning Snater) [16:49:40] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I don't really see a reason for your -1. Empty lines? No. I left them out on purpose. Comment? No. The reason for the copy is very obvious" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 (owner: 10Thiemo Mättig (WMDE)) [16:49:53] (03PS6) 10Hoo man: Inject API into parsers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [16:49:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147128 (owner: 10Hoo man) [16:55:53] (03CR) 10Hoo man: [C: 04-1] "Sorry to nitpick on naming again" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147116 (owner: 10Aude) [17:00:13] (03CR) 10Hoo man: [C: 031] "Looks sane, but I can't really test as I don't have a browser which actually shows the spinner (most just freeze until the page is fully t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/123298 (owner: 10Thiemo Mättig (WMDE)) [17:00:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [17:06:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [17:07:47] (03PS3) 10Hoo man: Optimize badge PNG images [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145426 (owner: 10Thiemo Mättig (WMDE)) [17:11:56] (03PS3) 10Daniel Kinzler: Track redirects in EPP table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) [17:12:41] (03CR) 10Hoo man: [C: 032] "Looks fine in all major browsers, thus wont harm." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145426 (owner: 10Thiemo Mättig (WMDE)) [17:12:56] (03Merged) 10jenkins-bot: Optimize badge PNG images [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145426 (owner: 10Thiemo Mättig (WMDE)) [17:14:03] (03PS3) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) [17:14:50] (03PS4) 10Daniel Kinzler: Track redirects in EPP table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) [17:14:54] (03PS4) 10Daniel Kinzler: Tests for redirect handling in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) [17:21:22] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147048 (owner: 10Henning Snater) [17:30:30] db1021 doesn't appear to be happy, see https://www.wikidata.org/w/api.php?action=query&meta=siteinfo&siprop=dbrepllag&sishowalldb= [17:30:39] I noticed because my bot stopped editing [17:30:50] multichill: Has been for a long time? [17:31:17] 19:17 first message (now 19:31) [17:31:27] (Sleeping for 120.0 seconds, 2014-07-17 19:30:07) [17:33:01] hoo: And now we can see that https://www.wikidata.org/wiki/User:SuccuBot and https://www.wikidata.org/wiki/User:EmausBot don't respect replag [17:34:30] mh [17:38:11] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147140 (owner: 10Thiemo Mättig (WMDE)) [17:42:57] [13ValueView] 15thiemowmde created 06min-width (+1 new commit): 02http://git.io/KGogBw [17:42:57] 13ValueView/06min-width 14d927498 15Thiemo Mättig: Improve suggester color and width styles [17:49:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145257 (owner: 10Adrian Lang) [17:50:04] [13ValueView] 15thiemowmde opened pull request #87: Improve suggester color and width styles (06master...06min-width) 02http://git.io/D7O9Zw [17:53:24] (03Abandoned) 10Thiemo Mättig (WMDE): Never underline menu items in suggesters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145766 (owner: 10Thiemo Mättig (WMDE)) [17:53:38] (03PS9) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [17:53:56] (03CR) 10jenkins-bot: [V: 04-1] Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [17:54:17] (03CR) 10Daniel Kinzler: [C: 04-1] "See hoo's comments on PS8." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [17:59:13] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145426 (owner: 10Thiemo Mättig (WMDE)) [18:05:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [18:11:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [18:16:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147118 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [18:22:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147137 (https://bugzilla.wikimedia.org/66582) (owner: 10Daniel Kinzler) [18:24:46] (03CR) 10Withoutaname: Refactor ChangeOps class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147122 (owner: 10Thiemo Mättig (WMDE)) [18:25:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [18:28:50] (03CR) 10Hoo man: [C: 032] "Given that the tests cover this I'm ok with the rather obscure two new lines of code." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 (owner: 10Thiemo Mättig (WMDE)) [18:29:09] (03Merged) 10jenkins-bot: Fix LabelDescriptionUniquenessValidator not working [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147120 (owner: 10Thiemo Mättig (WMDE)) [18:33:49] hey Thiemo_WMDE: I noticed you created an ActionTestCase recently [18:34:11] I wanted to let you know I've made some substantial changes to the class [18:35:32] (03CR) 10Thiemo Mättig (WMDE): Introduce wbcreateredirect API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143366 (https://bugzilla.wikimedia.org/65584) (owner: 10Daniel Kinzler) [18:39:15] Thiemo_WMDE: Here? [18:39:25] Do we already have an no-badges icon? [18:39:51] As described here https://bugzilla.wikimedia.org/show_bug.cgi?id=68152 [18:41:24] hoo: it should basically be the blue badges icon but not filled with grey outline i'd say [18:41:30] dunno if anyone made that already [18:42:15] "not filled with grey outline" huh? [18:42:38] oh, not filled with color, but a grey outline [18:42:44] yeah, that was my idea also [18:43:33] :) [18:52:10] (03CR) 10Hoo man: [C: 032] Refactor ChangeOps class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147122 (owner: 10Thiemo Mättig (WMDE)) [18:52:29] (03Merged) 10jenkins-bot: Refactor ChangeOps class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147122 (owner: 10Thiemo Mättig (WMDE)) [18:54:55] hoo did you read my comment [18:55:50] Withoutaname: Yep, but I don't think that's enough of a reason to let the change lay around [18:56:00] also I'm not to much a fan of that array casting syntax [18:57:13] kk, just wanted to be sure [18:57:21] ;) [19:52:40] "The client is the extension for the client." our documentation is awesome [20:52:03] hi, I'm quite new to wikidata (but somewhat experienced with wikipedia) [20:52:18] how can I add a new property to an object? [20:52:57] for example I'd like to add an image (according to docs P18) to a city object [20:56:15] hi hanno [20:56:20] do you still need help? [20:56:53] hoo, yes [20:57:05] I'm completely new to this and it doesn't work intuitively :-) [20:57:15] I already managed to add a language link, that was easy [20:57:28] Adding a statement is almost as easy :) [20:57:45] https://www.wikidata.org/w/index.php?title=Q14392355 <- this is my example object [20:57:54] now I think it could need an image and I have one on wm commons [20:57:59] You have an [ Add ] link just slightly above "Wikipedia pages linked to this item" [20:58:09] click on that one ;) [20:58:27] ah! [20:58:30] that was hidden [20:58:50] and for the field I just add the name on wm commons? or any prefix? [20:59:19] hanno: You will get suggestions ;) [20:59:26] just type a few letters and see [20:59:48] okido [20:59:49] thanks a lot [21:01:16] You're welcome [21:11:03] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/147302 (owner: 10L10n-bot) [21:20:10] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#133 (master - 5eb3bcf : Translation updater bot): The build has errored. [21:20:10] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/33df27e0062e...5eb3bcf6a071 [21:20:10] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/30213069 [21:23:28] uh [21:23:34] I think we should delete that repo [21:23:37] Lydia_WMDE: ^ ? [23:35:10] Lydia_WMDE: Morn. I am tempted to kill the "need-volunteer" Bugzilla keyword when migrating to Phabricator - to some extend it's the same as "easy", and if you need a volunteer for a task, the task is not on your planning list so it cannot be a high priority, right? ;) [23:35:11] Lydia_WMDE: (but assuming you disagree, we can also keep it - one project more or less is no problem and tasks can have more than one project in Phab) [23:36:04] andre__: Speaking for myself: I don't think anyone really used that to find volunteer tasks [23:36:26] I try to trick people into "easy" ones instead, yeah... [23:36:29] We more or less tagged all bugs with it which aren't in the current sprint/ will be in the next spring :P [23:36:32] * sprint [23:36:46] exclude sprint from bug list query, done? :D [23:36:48] easy is probably a better metric indeed [23:36:50] (sounds like) [23:37:19] Yeah, that might be a good idea for the "Things you can hack on" link we have on some pages [23:37:29] right now it just looks for need-volunteer bugs [23:38:28] hmm, that reminds me that I need to get the "easy bug of the week" thingy going. sigh. so many things to do :) [23:40:47] mh, it seems like we no longer use need-volunteer as often as I thought [23:41:13] but still I think we can live without it (Lydia might disagree here :P) [23:41:25] andre__> "easy bug" though not programming... https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P735#Value_type_Q202444 [23:41:56] revent: if there's no bug report about it, it's not a bug, in my simple world. ;) [23:42:47] andre__> Those are mostly where a person's "given name" is pointing at an item that's not a "given name" [23:42:56] might be. [23:43:06] is it a software bug? [23:43:14] if it's a content bug, I don't care. :) [23:43:25] and if it's a software bug, where's the bug report located? [23:43:34] andre__> No, it's a failure of people to label 'given names' as 'given name' and 'surnames' as 'surname' [23:43:42] so I don't care ;)) [23:43:48] :D [23:43:51] not a bug but PEBKAC [23:44:10] I don't care about bugs. I only care about bug reports. :D [23:44:18] (don't quote me on that) [23:44:19] andre__> Exactly... [23:44:51] andre__> Also known as an ID10-T error, lol. [23:45:16] oh, didn't know that one yet. nice :) [23:45:41] though a bit l33t... [23:46:02] andre__> In US Navy slang, a "GRE" (Gross Recruiting Error) [23:46:09] haha [23:46:37] wondering why that hasn't become a more common term in companies too already [23:46:40] Nice one :D