[08:08:34] (03PS6) 10Daniel Kinzler: Refactor EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144148 [08:16:17] good morningv :) [08:16:43] * hoo waves [08:18:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144148 (owner: 10Daniel Kinzler) [08:24:38] (03CR) 10Hoo man: [C: 04-1] "I know this hasn't been introduced here, but still I want it fixed now" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [08:33:23] (03PS2) 10Bene: Rename icons to more generic names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 [08:38:49] (03CR) 10Hoo man: [C: 04-1] "It still says "supports by default" which is misleading, as it sounds like you have to do some weird stuff to have other things supported." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [08:40:42] hoo: I don't think so [08:40:54] but I do [08:40:58] and actually you have to do some extraordinary things to support them [08:41:04] it supports all classes [08:41:13] it just delivers rules for these by default [08:41:20] imo editing the Common.css is not directly connected to configuring an extension [08:41:44] diffenrence between deliver and support in this context? [08:42:45] benestar: support -> "Only these work", deliver -> "We have fancy icons for those in our package" [08:42:56] that's what it sounds like to a user [08:43:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [08:50:52] Lydia_WMDE: FYI: https://www.wikidata.org/wiki/Wikidata:Bot_requests#Items_with_inconsistent_sitelinks [08:56:31] (03PS3) 10Bene: Rename icons to more generic names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 [09:01:28] (03CR) 10Hoo man: [C: 031] Rename icons to more generic names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [09:03:37] DanielK_WMDE_: Want to re-review https://gerrit.wikimedia.org/r/144965 and its follow-up? Or at least take of your -1 [09:05:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [09:06:41] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=55923 can we wontfix that one? I don't think we want to reimplement that stuff in Lua [09:06:50] (03PS5) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [09:06:51] values can easily be obtained from PHP if needed [09:13:34] (03PS6) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [09:14:16] (03PS6) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [09:16:51] (03PS7) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [09:17:11] hoo: --^ I removed the critical sentences from the options.wiki file [09:17:22] will have to discuss this with Lydia_WMDE sometimes later [09:17:50] will have a look in a moment [09:18:05] reviewing your special page patch nwo [09:19:46] (03CR) 10Hoo man: [V: 04-1] "[test@localhost phpunit]$ php phpunit.php ../../extensions/Wikibase/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [09:25:20] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [09:34:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [09:39:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [09:43:58] Lydia_WMDE: daily? [09:44:20] DanielK_WMDE_: coming :) [09:44:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [09:48:38] Why is Q5 human not shown when I type human ? [09:48:59] (03PS6) 10Daniel Kinzler: Resolve redirects in EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) [09:50:38] P31 is selected [09:58:21] Thiemo_WMDE: des Pudels Kern ist SqlEntityInfoBuilder::resolveRedirects in https://gerrit.wikimedia.org/r/#/c/144397/5 [09:58:30] GerardM-: we're looking [09:58:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144397 (https://bugzilla.wikimedia.org/66972) (owner: 10Daniel Kinzler) [09:59:12] DanielK_WMDE_: ok, will look at this today. please keep poking me if i'm to silent. [09:59:17] Thiemo_WMDE: would be great if you can have a look and let me know whether you can figure out how it works. it's a bit complex, as optimized bulk stuff tends to be. I didn't see a way to make it simpler... [09:59:44] ok, will do. the full review can wait until monday, i just want to make sure you understand what i'm trying to do there. [10:00:12] (03PS7) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [10:00:44] (03PS1) 10WikidataBuilder: New Wikidata Build - 11/07/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/145530 [10:01:09] hoo: tests pass now ;) [10:02:22] (03PS8) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [10:04:04] GerardM-: looks like katie found the issue. we're working on a fix [10:08:59] benestar: https://github.com/wmde/wikidata.org [10:11:26] yay github [10:11:30] thanks Lydia_WMDE [10:11:36] thanks aude [10:12:47] Lydia_WMDE: hm.. if i'm Q1, which has a reference to Q5, which is a redirect to Q8, and I hit edit on the Q5 reference... what do we want to happen? [10:13:04] or should the "edit" button be replaced by a "resolve redirect" button? [10:13:17] just something to think about. [10:13:36] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Rename icons to more generic names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [10:13:51] (03Merged) 10jenkins-bot: Rename icons to more generic names [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145425 (owner: 10Bene) [10:14:00] DanielK_WMDE_: I do not like a "resolve redirect" button... [10:14:12] rather resolve it silently [10:14:26] DanielK_WMDE_: boils down to if we are ok with redirects being left or if we want people to clean them up [10:16:07] (03PS5) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [10:16:28] i think we do [10:19:07] DanielK_WMDE_: Want to re-review https://gerrit.wikimedia.org/r/144965 and its follow-up? Or at least take of your -1 [10:22:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d9aa028 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/29683279 [10:23:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [10:25:43] (03PS3) 10Thiemo Mättig (WMDE): Fix hard limit for all TermIndex searches [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 [10:26:30] hoo: aude: https://gerrit.wikimedia.org/r/#/c/145372/ [10:27:02] (03PS8) 10Hoo man: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [10:32:48] (03CR) 10Aude: "generally looks ok, esp. for master, but would prefer a smaller patch for backport that does just what we need. (no style changes)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [10:33:59] (03PS4) 10Thiemo Mättig (WMDE): Fix hard limit for all TermIndex searches [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 [10:38:21] (03PS1) 10Thiemo Mättig (WMDE): Partly revert min vs. max hotfix [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145532 [10:39:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/145530 (owner: 10WikidataBuilder) [10:41:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [10:53:01] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [11:00:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [11:01:28] Wikidata Search Results at Telugu wikipedia (te.wikipedia.org) first appears in Telugu and then quickly changes to English. [11:05:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [11:06:50] What might be wrong? [11:10:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [11:15:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145532 (owner: 10Thiemo Mättig (WMDE)) [11:45:25] (03PS5) 10Thiemo Mättig (WMDE): Fix hard limit for all TermIndex searches [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 [11:46:17] hoo: https://gerrit.wikimedia.org/r/#/c/145532/1 [11:48:10] (03PS1) 10Hoo man: Partly revert min vs. max hotfix [extensions/Wikibase] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145546 [11:49:08] (03CR) 10Hoo man: [C: 032] "Trivial change is trivial" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145532 (owner: 10Thiemo Mättig (WMDE)) [11:49:21] (03Merged) 10jenkins-bot: Partly revert min vs. max hotfix [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145532 (owner: 10Thiemo Mättig (WMDE)) [11:52:20] (03Abandoned) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [11:56:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/8d0feed : Thiemo Mättig The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/29689948 [11:59:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [12:03:33] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "The info builder is a bit misused at the moment." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [12:04:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145546 (owner: 10Hoo man) [12:13:14] (03PS6) 10Daniel Kinzler: Resolve redirects in JS config variables. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) [12:15:07] (03CR) 10Hoo man: [C: 032] Partly revert min vs. max hotfix [extensions/Wikibase] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145546 (owner: 10Hoo man) [12:15:50] (03CR) 10Daniel Kinzler: Add a list of allowed badges to Special:SetSitelink (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [12:16:06] Thiemo_WMDE: *poke* [12:23:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145522 (https://bugzilla.wikimedia.org/66971) (owner: 10Daniel Kinzler) [12:29:05] benestar: https://git.wikimedia.org/tree/mediawiki%2Ftools%2Fcodesniffer.git ? [12:38:12] (03PS9) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [12:47:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [12:49:17] (03PS1) 10Hoo man: Update Wikibase to fix a problem with the wbsearchentities API [extensions/Wikidata] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145551 [12:59:47] (03PS1) 10Hoo man: Fix SectionEditLinkGeneratorTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 [12:59:54] Thiemo_WMDE: --^ again :P [13:00:51] [travis-ci] mariushoch/mediawiki-extensions-Wikibase/master/125aaaa : Marius Hoch The build is still failing. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/29693842 [13:02:51] (03PS1) 10Thiemo Mättig (WMDE): Badges: Add PNG fallback and optimize SVG [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 [13:03:41] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Inserts badges into the SiteLinkView (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [13:06:19] (03PS2) 10Hoo man: Fix SectionEditLinkGeneratorTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 [13:07:16] aude: https://gerrit.wikimedia.org/r/145553 [13:07:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145551 (owner: 10Hoo man) [13:09:02] (03PS1) 10Hoo man: Run test on travis in Russian also [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 [13:09:13] [travis-ci] mariushoch/mediawiki-extensions-Wikibase/master/7909e7f : Marius Hoch The build was fixed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/29695056 [13:11:49] (03CR) 10Hoo man: [C: 032] Update Wikibase to fix a problem with the wbsearchentities API [extensions/Wikidata] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145551 (owner: 10Hoo man) [13:13:36] Hey, when I add Konkani as my language (both knn or gom), I cannot add labels at wikidata, It says language not recognised. [13:14:57] tuxnani: Can you open a bug to add that to the Wikidata configuration? [13:15:04] ok [13:15:14] See also https://bugzilla.wikimedia.org/show_bug.cgi?id=59905 [13:15:25] (03Merged) 10jenkins-bot: Update Wikibase to fix a problem with the wbsearchentities API [extensions/Wikidata] (mw1.24-wmf12) - 10https://gerrit.wikimedia.org/r/145551 (owner: 10Hoo man) [13:15:36] Also, I had earlier probem where wikidata results dont show the result in that Wikipedia's language but in English. [13:16:15] tuxnani: In the search? [13:16:22] hoo: Yes [13:16:33] We will fix this later today ;) [13:17:34] hoo: Any need to file a bug on that? [13:17:37] (03CR) 10Siebrand: Add handling for UnresolvedRedirectException. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143650 (owner: 10Daniel Kinzler) [13:17:47] tuxnani: Yes, all configuration changes need a bgu [13:17:49] * bug [13:18:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 (owner: 10Hoo man) [13:19:07] (03CR) 10Thiemo Mättig (WMDE): "The backport patch is Ib68149f." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [13:25:56] (03PS1) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 [13:31:16] (03PS1) 10Hoo man: Don't hard code Item ids in EntityPerPageTableTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145561 [13:34:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145554 (owner: 10Thiemo Mättig (WMDE)) [13:36:47] (03PS2) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 [13:37:09] (03CR) 10Thiemo Mättig (WMDE): Create a badge lookup to get the titles for badges (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [13:38:49] (03CR) 10Hoo man: Create a badge lookup to get the titles for badges (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [13:38:58] (03CR) 10Hoo man: [C: 04-1] "per PS1" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [13:44:42] (03PS9) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [13:50:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 (owner: 10Hoo man) [13:50:59] (03PS1) 10Aude: Make ChangeLineFormatterTest completely independent of lang setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 [13:52:48] (03CR) 10Aude: [C: 04-1] "suggestion :)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [13:53:24] (03CR) 10Hoo man: [C: 04-1] "if ( $this->hasDebugCode() && $this->isInGerrit ) { echo -1; }" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 (owner: 10Aude) [13:54:57] (03CR) 10Hoo man: [C: 04-1] "Should we do both maybe?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [13:55:56] (03CR) 10Aude: Run test on travis in Russian also (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [14:00:00] (03PS10) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [14:01:32] (03PS2) 10Hoo man: Run test on travis in Russian and Arabian also [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 [14:02:00] (03PS2) 10Aude: Make ChangeLineFormatterTest completely independent of lang setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 [14:03:01] (03CR) 10Aude: Run test on travis in Russian and Arabian also (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [14:03:31] (03PS1) 10Thiemo Mättig (WMDE): Fix "can not" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 [14:04:03] (03PS3) 10Hoo man: Run test on travis in Russian and Arabic also [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 [14:04:14] (03CR) 10Thiemo Mättig (WMDE): Add handling for UnresolvedRedirectException. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/143650 (owner: 10Daniel Kinzler) [14:05:46] (03CR) 10Aude: [C: 04-1] "still fails in arabic :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 (owner: 10Hoo man) [14:07:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [14:10:33] (03CR) 10Aude: [C: 032] "silly me.... ran tests on wrong wikibase install. tests pass :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 (owner: 10Hoo man) [14:11:42] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [14:12:51] (03CR) 10Aude: [C: 032] "much better :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 (owner: 10Thiemo Mättig (WMDE)) [14:12:58] (03CR) 10Aude: Fix "can not" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 (owner: 10Thiemo Mättig (WMDE)) [14:13:17] (03CR) 10Aude: [C: 031] "should wait for wikidata jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 (owner: 10Thiemo Mättig (WMDE)) [14:14:31] (03CR) 10Aude: [C: 031] "will help catch more bugs" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [14:19:12] (03CR) 10Hoo man: [C: 032] "Looks sane, works locally" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [14:21:56] (03Abandoned) 10Hoo man: Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [14:25:46] (03PS3) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 [14:30:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145561 (owner: 10Hoo man) [14:30:21] Zuul / Jenkins gate is blocked [14:30:28] so changes you CR+2 will take a bit of time to landin [14:30:38] Jenkins is busy deleting files for some mediawiki-core jobs [14:32:13] oh jenkins... -.- [14:32:15] hoo: Added bug here : https://bugzilla.wikimedia.org/show_bug.cgi?id=67855 [14:33:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [14:35:45] tuxnani: Sorry, that's not a feature managed by zus+ [14:36:11] Could you please direct me to appropriate place? [14:37:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [14:38:53] tuxnani: appears to be a gadget [14:39:01] i can't find where the code is [14:39:09] https://te.wikipedia.org/wiki/%E0%B0%AE%E0%B1%80%E0%B0%A1%E0%B0%BF%E0%B0%AF%E0%B0%BE%E0%B0%B5%E0%B0%BF%E0%B0%95%E0%B1%80:Gadgets-definition [14:39:51] (03Merged) 10jenkins-bot: Fix SectionEditLinkGeneratorTest for non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145553 (owner: 10Hoo man) [14:40:04] might be related to an api bug we have [14:40:11] aude: en.wikipedia.org/w/index.php?title=MediaWiki:Wdsearch.js [14:40:13] and shall be fixing shortly [14:40:17] (03Merged) 10jenkins-bot: Fix hard limit for all TermIndex searches [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145372 (owner: 10Thiemo Mättig (WMDE)) [14:40:33] (03CR) 10Daniel Kinzler: [C: 032] Don't hard code Item ids in EntityPerPageTableTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145561 (owner: 10Hoo man) [14:41:51] should fix, i think but not 100% sure [14:45:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 (owner: 10Aude) [14:46:10] jenkins approves my patch! [14:46:14] meeeeeerge! [14:46:19] ^^ [14:49:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [14:49:59] Wow, so many commits for one "website"... [14:54:43] (03Merged) 10jenkins-bot: Don't hard code Item ids in EntityPerPageTableTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145561 (owner: 10Hoo man) [14:55:06] (03PS11) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [14:55:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [14:55:43] (03PS12) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [14:55:57] (03PS10) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [14:56:43] Thiemo_WMDE: last chance to talk about EntityInfoBuilder for today. i saw you have been really busy. perhaps send some of the reviews my way? [14:57:50] Josve05a: you see ~6 people working fulltime... i'm worried when it gets quiet :P [14:58:28] DanielK_WMDE_: when will EntityInfoBuilder be refactored? [14:58:46] I am currently using it but it would be great to know what and when things will change [15:03:47] benestar: whenever Thiemo_WMDE merged my patch :) i'll add you as a review [15:04:01] ok :) [15:04:12] benestar: https://gerrit.wikimedia.org/r/#/c/144148/ [15:11:42] (03PS11) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [15:12:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 (owner: 10Aude) [15:22:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 (owner: 10Thiemo Mättig (WMDE)) [15:27:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [15:31:27] Hi - is switching the Q IDs of two entities forbidden, frowned upon, or not really a big deal at this point? [15:31:50] Yaron: Don't do that [15:31:54] (The switch would presumably have to be done manually, by removing each page's facts and replacing them with the other.) [15:32:15] that's at very least frowned upon, if not forbidden by policy [15:32:18] anyway, it's evil [15:32:28] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [15:32:40] The issue is this page: https://www.wikidata.org/wiki/Q58 [15:32:59] The very low number for "penis" is making things awkward for at least one demo site. [15:34:14] hoo: I couldn't find anything relevant to that in the Wikidata policy pages. [15:34:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [15:35:07] Yaron: the IDs are supposed to be stable [15:35:10] so no switching [15:35:24] Can't one small exception be made? :) [15:35:34] then our identifiers are no longer stable ;-) [15:35:38] so nope [15:35:39] sorry [15:35:43] (03PS13) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [15:36:12] And there's no forum in which to request such moves, similar to Wikipedia's page moves process? [15:36:51] you can bring it up on project chat but it will be the same outcome [15:37:01] Yaron: items cannot be moved that simple [15:37:50] Well, that sucks - one person's (I'm guessing) joke inclusion on one day makes things permanently awkward. [15:39:15] (That person being Reedy, not that it's relevant.) [15:40:02] (03PS4) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 [15:40:35] (03PS14) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [15:40:44] (03PS12) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [15:41:28] Lydia_WMDE: what do you mean by "project chat"? [15:41:55] https://www.wikidata.org/wiki/Wikidata:Project_chat [15:41:58] https://www.wikidata.org/wiki/Wikidata:Project_chat [15:42:12] Alright, thanks. [15:42:13] https://www.wikidata.org/wiki/Wikidata:Project_chat [15:43:24] 3 people in a row posting the same link.... [15:44:01] Josve05a: even worse when they are sitting togehter in the same room :P [15:44:26] You are? [15:44:35] atm yeah :D [15:44:49] we got visitors in the office this week :) [15:45:04] \o/ [15:45:46] I'm waiting for Germany to win on Sunday...howabout you guys? Who are you rooting for? [15:45:59] germany obviously! :P [15:46:01] * benestar agrees [15:47:05] no wait...I'm rooting for Sweden...lol [15:48:35] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [15:51:28] * benestar gives jenkins some food [15:51:37] maybe he will speed up then [15:51:57] perhaps jenkins just needs some more love ... [15:56:06] Can someone please transfer the properties from wikidata.org to test.wikidata.org [15:56:30] testing is meaningless, if you can't create Items with properties other than "Foo" and "Bar" [16:02:01] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [16:04:23] lbenedix: which properties do you want to have there? [16:07:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [16:12:07] benestar: at least the properties used in the showcase items [16:12:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [16:17:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [16:20:40] is it possible to transfere them automatically? [16:22:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [16:27:14] lbenedix1: if somebody implements something, yes it is possible [16:27:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [16:29:23] (03CR) 10Aude: [C: 032] Fix "can not" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 (owner: 10Thiemo Mättig (WMDE)) [16:29:41] (03CR) 10Aude: [C: 032] Run test on travis in Russian and Arabic also [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [16:29:45] (03Merged) 10jenkins-bot: Fix "can not" messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145567 (owner: 10Thiemo Mättig (WMDE)) [16:29:50] (03Merged) 10jenkins-bot: Run test on travis in Russian and Arabic also [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145555 (owner: 10Hoo man) [16:31:31] (03CR) 10Hoo man: [C: 032] Make ChangeLineFormatterTest completely independent of lang setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 (owner: 10Aude) [16:31:48] (03Merged) 10jenkins-bot: Make ChangeLineFormatterTest completely independent of lang setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145564 (owner: 10Aude) [16:37:34] (03PS5) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 [16:38:09] (03PS15) 10Bene: Add a list of allowed badges to Special:SetSitelink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) [16:38:16] (03PS13) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) [16:41:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1e98186 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/29713316 [16:45:34] so there is no export/import feature? [16:47:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d8c14fb : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/29713441 [16:53:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [16:56:11] (03PS1) 10Aude: Fix SummaryFormatterTest for non-english (e.g. arabic) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145587 [16:56:28] JeroenDeDauw: can you take a look at this patch? https://gerrit.wikimedia.org/r/#/c/145560/ [16:56:41] hoo wants you or DanielK_WMDE_ to review it before merging [16:56:59] the interface mostly [16:57:29] if that'S fine, I can review the actual implementation [17:06:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145270 (https://bugzilla.wikimedia.org/61664) (owner: 10Bene) [17:08:25] JeroenDeDauw: can you please look at https://gerrit.wikimedia.org/r/#/c/132606/ [17:08:30] are you still working on it? [17:08:44] * aude like it to be unstuck [17:09:34] (03PS6) 10Bene: Create a badge lookup to get the titles for badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 [17:13:41] Thiemo_WMDE: should be able to edit and merge now [17:13:54] ok [17:14:06] ahhhhh [17:14:33] aude: ahh, I was wondering about that commit. Tpt is not here right? [17:14:38] no [17:14:54] * JeroenDeDauw assumes aude failed at the negation [17:15:11] benestar and hoo are here [17:16:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668) (owner: 10Bene) [17:19:18] (03CR) 10Jeroen De Dauw: Create a badge lookup to get the titles for badges (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [17:21:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145587 (owner: 10Aude) [17:23:06] (03CR) 10Hoo man: [C: 032] "\o/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145587 (owner: 10Aude) [17:23:55] JeroenDeDauw: can you add me as an owner to https://github.com/orgs/wmde/teams please? [17:24:01] (03Merged) 10jenkins-bot: Fix SummaryFormatterTest for non-english (e.g. arabic) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145587 (owner: 10Aude) [17:25:54] yay [17:27:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [17:31:16] benestar: hello! [17:31:22] thepwnco: hi :) [17:31:29] how goes it? [17:31:44] Lydia_WMDE: not my call, ask Abraham [17:31:53] there is a bit more traffic on our tour items :) [17:31:54] Lydia_WMDE: why though? [17:32:00] woohoo [17:32:09] there will soon be more - I'm preparing an announcement or two [17:32:10] JeroenDeDauw: i can't add needed teams to a new repo [17:33:00] I just did some user testing... on my roommate :) [17:33:04] Lydia_WMDE: repos are associated with teams, not the other way around [17:33:31] well then this way around. i can't do it ;-) [17:33:48] Lydia_WMDE: does a repo need to be added to the wikidata team? [17:33:55] yes [17:34:03] name? [17:34:08] wikidata.org [17:34:09] thepwnco: great :) I also created another tour item for the statements tour [17:34:58] oh, great! should I wait until it's implemented to post the announcement then? [17:35:43] Lydia_WMDE: added [17:35:51] JeroenDeDauw: actually I think we can use the EntityIdLabelFormatter [17:35:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/96344e5 : aude The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/29717477 [17:35:56] thx [17:36:01] however. it also loads the whole entity :/ [17:37:08] label formatter is evil [17:37:12] leaving now :( [17:37:20] cu later :) [17:37:37] aude: yeah indeed [17:37:46] I am wondering where the nice clean class I created went [17:38:00] I remember you and daniel raging about it [17:38:05] So perhaps it is gone now? [17:38:49] no idea what you're talking about [17:39:08] anyway, time to leave [17:51:46] (03CR) 10Jeroen De Dauw: [C: 04-1] Create a badge lookup to get the titles for badges (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [17:55:42] (03CR) 10Jeroen De Dauw: "I was not able to find the thing I was thinking off that takes an EntityId and gives either the label or the serialization back" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [17:56:32] aude: this was over a year ago [17:58:40] (03CR) 10Jeroen De Dauw: "I have not made progress on this. Last time I tried looking at it, the Wikibase tests where broken. Will attempt to resolve the issues in " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [18:12:29] Wait what... it's friday :0 [18:17:49] the fuuuuuuck https://travis-ci.org/wmde/WikibaseEntityStore/jobs/29720187 [19:31:05] aude: Almost done with the coordinates :-) [19:36:08] Travis is unusably sluggish in firefox. it bogs down the entire ui, sometimes for minutes. [19:36:11] what the fuck? [19:39:30] thepwnco: i think you removed too much in your last edit to the tours page? the buttons look broken for me now [19:39:32] can you check? [19:43:14] (03CR) 10Daniel Kinzler: "Please have a look at the EntityFingerprintLookup i'm proposing in I443ba86ab5 (that needs to be split up, it's just a draft atm)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145560 (owner: 10Bene) [19:43:41] heya Lydia_WMDE [19:43:50] hey DanielK_WMDE_ :) [19:43:50] did you hear anything back re hubbub? [19:43:58] nope [19:44:15] you? [19:45:24] Lydia_WMDE: Fly to the office and take the ops team hostage til they deploy. solved [19:45:36] lol [19:45:44] i am not sure that is an acceptable method :P [19:46:01] but it works! [20:08:52] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/145668 (owner: 10L10n-bot) [23:54:39] (03PS14) 10Bene: Inserts badges into the SiteLinkView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/144668 (https://bugzilla.wikimedia.org/67668)