[05:16:42] (03CR) 10Christopher Johnson (WMDE): [C: 031] Inline deprected code in deprecated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139607 (owner: 10Jeroen De Dauw) [08:59:40] Hola, I'm looking for someone in Berlin who would be able to speak about Wikidata at Hacks/Hackers next Thursday. Anyone interested? [09:32:46] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 19/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140680 (owner: 10WikidataBuilder) [09:33:16] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Just to explain: The idea of my original fake (see I1e577a54a5ed5f458cc69fdcd60c9699a367cb62) was to catch broken code as the non-existing" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) (owner: 10Aude) [09:40:25] Guest93348: be patient, folks are just slowly starting their day ;) [09:44:40] hi, I have a somewhat strange problem; I want to enter a number in a claim with the number of participants (P1132) property [09:44:43] (03CR) 10Thiemo Mättig (WMDE): "Ok, this still does catch the errors I wanted it to catch. (Yea, I know, why should it not? I just wanted to be sure.) Will +2 this if you" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140722 (https://bugzilla.wikimedia.org/65727) (owner: 10Aude) [09:44:59] when I do that on the Wikidata web interface, instead of (for example) 16 [09:45:09] I get 16+/-1 when I click on save [09:45:18] bthfan: enter it with +- 0 [09:45:19] I don't want that +/-1 there.. [09:45:22] uh ok :) [09:45:24] :) [09:45:30] is this a bug? [09:45:34] or a feature? [09:45:43] feature with some missing pieces [09:49:19] (03CR) 10Thiemo Mättig (WMDE): Improve and extend the WikibaseLuaEntityBindingsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140766 (owner: 10Hoo man) [10:00:33] (03PS1) 10WikidataBuilder: New Wikidata Build - 20/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140902 [10:05:27] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=66870 [10:10:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140902 (owner: 10WikidataBuilder) [11:15:59] DanielK_WMDE__: no problem! [11:46:35] aude: Can you add me to the "wmde" group on labs? [12:33:36] hoo: ? [12:33:40] probably not [12:57:42] aude: who can? [12:58:09] context: https://gerrit.wikimedia.org/r/140881 [13:02:40] [13puppet-wikidata-test] 15filbertkm closed pull request #3: changes to allow query to work on demo (06master...06query) 02http://git.io/d7X9Ag [13:02:52] hoo: ldap? [13:02:58] (03PS45) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [13:03:06] aude: Yeah [13:03:12] rt [13:03:36] bureaucracy :P [13:04:03] they might also want to restrict the tools to those with nda [13:04:33] description: ldap admins [13:04:33] members: [robla, reedy, demon] [13:04:42] any ops can, afaik [13:05:20] aude: Possible, yeah... I just wanted to have something in gerrit to put a bit of pressure on them :P [13:05:26] great [13:06:49] hoo: i can make a rt ticket [13:07:54] done [13:07:55] for the wmde group? Might be better to first wait for someone to formally approve the access [13:08:14] wmde group, i can approve [13:08:29] i can't actually add you though [13:09:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:09:52] all we can do is resubmit jenkins jobs though [13:11:21] matanya's https://rt.wikimedia.org/Ticket/Display.html?id=7724 is also about a similar thing [13:11:27] * aude nods [13:11:40] maybe we want a new ldap group for people with nda or so [13:11:44] i think it should be an nda group that includes non wmde people [13:11:57] that's what i think faidon wanted [13:14:10] (03CR) 10Daniel Kinzler: Introducing EntityChangeFactory. (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [13:14:38] (03PS4) 10Daniel Kinzler: Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) [13:14:52] (03PS5) 10Daniel Kinzler: Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) [13:15:08] (03PS2) 10Daniel Kinzler: Replace ChangeNotifier with ChangeNotificationChannel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) [13:15:59] (03PS2) 10Daniel Kinzler: Move notification logic into ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) [13:21:05] (03PS3) 10Daniel Kinzler: Replace ChangeNotifier with ChangeNotificationChannel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) [13:21:14] (03PS3) 10Daniel Kinzler: Move notification logic into ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) [13:25:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [13:35:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [13:36:55] (03PS4) 10Daniel Kinzler: Move notification logic into ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) [13:38:28] (03PS46) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [13:45:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [13:46:27] (03PS1) 10Aude: Fix @covers tags in WikibaseLib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140911 [13:50:04] (03CR) 10Jeroen De Dauw: [C: 032] Fix @covers tags in WikibaseLib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140911 (owner: 10Aude) [13:50:16] (03Merged) 10jenkins-bot: Fix @covers tags in WikibaseLib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140911 (owner: 10Aude) [13:53:06] (03CR) 10Daniel Kinzler: Implement redirects in ItemContent (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:53:17] JeroenDeDauw: --^ [13:53:34] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [13:53:47] bah. what now, jenkins?! [13:54:39] (03CR) 10Hoo man: "so??" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [13:55:31] rage [13:55:45] * aude should just merge it :P [13:57:31] (03CR) 10Aude: [C: 031] "looks ok and think any further changes are ok in follow up, if really needed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [13:59:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [14:02:31] (03CR) 10Daniel Kinzler: Check for redirect before calling getEntity(). (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [14:02:36] (03PS8) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [14:07:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [14:12:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [14:16:14] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Seems I totally misunderstood Daniel. His idea is to keep this option as simple as possible:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [14:16:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:17:12] (03CR) 10Daniel Kinzler: Allow creation of redirects via EntityStore. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:18:05] (03PS8) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [14:18:20] (03CR) 10jenkins-bot: [V: 04-1] Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:22:03] raaaaaaaaaaage [14:22:48] meeeeeeeeeeeeerrrrrrrrge https://gerrit.wikimedia.org/r/#/c/140733/ [14:23:14] blocking me from populating the demo system with properties [14:24:46] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140911 (owner: 10Aude) [14:25:19] * aude apply live hack to demo system [14:29:06] (03CR) 10Daniel Kinzler: [C: 032] "I don't feel very good about this, since ICOntextSource indeed doesn't defined setTitle, and requiring a RequestContext feels wrong... but" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140733 (https://bugzilla.wikimedia.org/66842) (owner: 10Aude) [14:29:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [14:29:20] (03Merged) 10jenkins-bot: Give EditEntity a valid context (RequestContext) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140733 (https://bugzilla.wikimedia.org/66842) (owner: 10Aude) [14:30:18] (03PS9) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [14:30:58] (03PS2) 10Daniel Kinzler: EntityViewPlaceholderExpander should use EntityRevisionLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140412 [14:34:29] (03PS10) 10Daniel Kinzler: Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) [14:41:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:46:53] [13WikibaseQuery] 15thiemowmde closed pull request #33: Remove silly factory (06master...06rf) 02http://git.io/D-kQtQ [14:47:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:52:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140412 (owner: 10Daniel Kinzler) [14:56:15] Could anyone try opening https://www.wikidata.org/wiki/User:Vyom25 ? I'm getting this http://i.imgur.com/1eoqiGA.png [14:56:16] (03PS1) 10Daniel Kinzler: Test diffs for redirects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140918 (https://bugzilla.wikimedia.org/65585) [14:56:40] other userpages are working normally [14:56:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [14:57:08] kondi: yeah, same here [14:57:19] but need to go now, so can't help anymore, sorry [14:57:31] np, wanted to confirm [14:58:39] (03CR) 10Thiemo Mättig (WMDE): "Why is this important? Currently no information from the EntityRevision is used. Just the Entity. So what was wrong with using the more na" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140412 (owner: 10Daniel Kinzler) [14:58:51] bah [15:03:35] he/she is including {{Special:LanguageStats}} which appears the problem [15:04:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140918 (https://bugzilla.wikimedia.org/65585) (owner: 10Daniel Kinzler) [15:06:05] aka https://bugzilla.wikimedia.org/show_bug.cgi?id=65826 most likely [15:06:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=62125 [15:07:05] probably related [15:09:01] i can't look right now but perhaps later [15:10:44] https://www.wikidata.org/w/index.php?title=User:Vyom25&oldid=62146983 is the last revision that works for me now [15:27:58] (03PS1) 10Aude: Fix @covers and @group tags in WikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140925 [15:34:27] please explain me the difference between [[Q31184|siblings]] as kinship and [[Q16979650|siblings]] as group. Isn't it the same? [15:35:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140925 (owner: 10Aude) [16:22:30] (03PS2) 10Aude: Fix @covers and @group tags in WikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140925 [16:30:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140925 (owner: 10Aude) [16:44:19] [13ValueView] 15thiemowmde created 06class-class (+1 new commit): 02http://git.io/Bo8V6Q [16:44:19] 13ValueView/06class-class 143619905 15Thiemo Mättig: Revert class name back to "valueview" [16:46:08] [13ValueView] 15thiemowmde 04force-pushed 06class-class from 143619905 to 14686a37b: 02http://git.io/ylsatA [16:46:08] 13ValueView/06class-class 14686a37b 15Thiemo Mättig: Revert class name back to "valueview" [16:51:17] [13ValueView] 15thiemowmde opened pull request #74: Revert class name back to "valueview" (06master...06class-class) 02http://git.io/fCvbmQ [17:19:55] [13ValueView] 15JeroenDeDauw comment on pull request #74 14686a37b: Looks like this thing should be 0.7, as new stuff has been added, rather than just bugfixes made. That has nothing to do with this commit itself though. 02http://git.io/-uIBaw [17:23:25] [13ValueView] 15thiemowmde comment on pull request #74 14686a37b: Feel free to either change the number or split into a 0.6.3 and a 0.7 release. I'm fine with both. 02http://git.io/Nw2ALA [17:36:11] (03PS1) 10Thiemo Mättig (WMDE): Rename wrongly named UserLanguageLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140946 [17:37:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "See If988becf57ee68147244b154f410cd8ef301620c." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140925 (owner: 10Aude) [17:38:22] (03Merged) 10jenkins-bot: Fix @covers and @group tags in WikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140925 (owner: 10Aude) [17:43:24] hey! [17:43:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140946 (owner: 10Thiemo Mättig (WMDE)) [18:45:08] (03PS1) 10Thiemo Mättig (WMDE): Clean-up EntityHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140958 [18:50:08] (03PS1) 10Thiemo Mättig (WMDE): Refactor EntityContentTest and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140960 [18:51:38] (03PS1) 10Thiemo Mättig (WMDE): Test that non-legacy JSON is not recoded [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140961 [18:57:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140958 (owner: 10Thiemo Mättig (WMDE)) [18:57:12] (03PS2) 10Thiemo Mättig (WMDE): MWException is part of the EntityContent::getEntity interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140347 [19:06:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140960 (owner: 10Thiemo Mättig (WMDE)) [19:11:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140961 (owner: 10Thiemo Mättig (WMDE)) [19:16:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140347 (owner: 10Thiemo Mättig (WMDE)) [20:00:00] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/141042 (owner: 10L10n-bot) [20:09:51] (03CR) 10Aude: [C: 032] Rename wrongly named UserLanguageLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140946 (owner: 10Thiemo Mättig (WMDE)) [20:10:07] (03Merged) 10jenkins-bot: Rename wrongly named UserLanguageLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140946 (owner: 10Thiemo Mättig (WMDE)) [20:35:42] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [20:36:01] (03Merged) 10jenkins-bot: Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [20:40:47] (03PS2) 10Thiemo Mättig (WMDE): Refactor EntityContentTest and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140960 [20:47:38] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140960 (owner: 10Thiemo Mättig (WMDE)) [20:49:41] (03PS2) 10Thiemo Mättig (WMDE): Test that non-legacy JSON is not recoded [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140961 [20:52:04] (03PS3) 10Thiemo Mättig (WMDE): Test that non-legacy JSON is not recoded [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140961 [20:57:38] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [20:57:56] (03Merged) 10jenkins-bot: Introducing EntityChangeFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140709 (https://bugzilla.wikimedia.org/65594) (owner: 10Daniel Kinzler) [21:00:23] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140961 (owner: 10Thiemo Mättig (WMDE)) [21:04:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140961 (owner: 10Thiemo Mättig (WMDE)) [21:36:33] (03CR) 10Thiemo Mättig (WMDE): "Sorry. I agree that the old ChangeNotifier class was bad. But this new approach is not better in my opinion. The most silly details from t" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [21:36:54] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "Sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [21:44:13] JeroenDeDauw: -2 https://gerrit.wikimedia.org/r/#/c/140719 [21:50:38] (03CR) 10Aude: [C: 032] Drop getFormattedIdForEntity methods from tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139968 (owner: 10Thiemo Mättig (WMDE)) [21:50:53] (03Merged) 10jenkins-bot: Drop getFormattedIdForEntity methods from tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139968 (owner: 10Thiemo Mättig (WMDE)) [21:54:46] (03CR) 10Thiemo Mättig (WMDE): "See my comments in the depending patch." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140736 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [21:57:17] JeroenDeDauw: sorry? why? [21:57:36] LOOOOOL [21:58:16] it means "i don't hate you, i'm just totally confused by this". not strictly necessary with daniel. [21:59:28] Thiemo_WMDE: it implies you have reason to be sorry [21:59:55] yes, i have. i'm blocking daniels growing row of patches. [22:03:51] (03CR) 10Jeroen De Dauw: Replace ChangeNotifier with ChangeNotificationChannel (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler) [22:09:34] !admin https://www.wikidata.org/wiki/User_talk:Kiko4564 can someone please revdel everyrevision except the last two of this/ [22:11:18] done, Mr-Potter [22:11:45] ajr: Thanks! now were could I go to request os please? [22:11:51] it was OSed [22:11:54] Mr-Potter, I did that too :) [22:12:06] good thanks! :) [22:12:09] (oversight@wikidata.org if it happens again) [22:12:41] and you're very welcome :) [22:19:52] https://www.wikidata.org/w/index.php?title=Talk%3AQ12013&diff=139222983&oldid=139222448 [22:19:58] think this needed mroe than a simple blank? [22:20:27] deleted [22:22:26] Thiemo_WMDE: easy review is easy https://gerrit.wikimedia.org/r/#/c/139607/ [22:22:42] Thiemo_WMDE: also, leaving soonish [22:23:58] last train in 00:41. [22:27:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Where is the patch that drops the method on the other side?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139607 (owner: 10Jeroen De Dauw) [22:27:21] (03Merged) 10jenkins-bot: Inline deprected code in deprecated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139607 (owner: 10Jeroen De Dauw) [22:33:23] JohnLewis: Mind a PM [22:33:34] i guess [22:34:49] ajr: Mind explaining to Mr-Potter how to contribute to Wikidata? [22:34:53] how could I help pls [22:34:57] JohnLewis: Thanks [22:39:08] or rschen7754 ^ :p [22:39:21] geez I dunno [22:39:35] I patrol through the new pages [22:39:41] and clean RfD [23:38:38] (03CR) 10Thiemo Mättig (WMDE): "After a chat with Jeroen, what about this: I will merge this along with the next patch if it's ok for you when I do a follow-up that compl" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140719 (https://bugzilla.wikimedia.org/66831) (owner: 10Daniel Kinzler)