[02:03:17] [13WikibaseDataModel] 15atdt opened pull request #120: Don't rely on assert() to bail on assertion failure (06master...06master) 02http://git.io/_oXchA [08:22:51] (03CR) 10Daniel Kinzler: Check for redirect before calling getEntity(). (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [08:23:08] (03PS6) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [08:25:45] (03CR) 10Thiemo Mättig (WMDE): "Ok, some questions are done after discussion. I marked them as done. Still some issues unfortunately." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [08:30:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [08:32:10] (03PS44) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [08:32:59] (03PS7) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [08:41:04] [travis-ci] wmde/WikibaseQueryEngine/deduplication/e9c2cc0 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/27844550 [08:42:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [08:46:59] (03CR) 10Daniel Kinzler: Allow creation of redirects via EntityStore. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [08:47:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [08:49:45] (03PS6) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [08:49:47] (03PS1) 10Thiemo Mättig (WMDE): Don't pass the User around as a parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 [08:50:12] (03PS7) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [08:52:14] (03CR) 10Daniel Kinzler: "@Thiemo: the new code is covered because it re-implements existing functionality: the undo action, which is already covered by the tests. " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140175 (owner: 10Thiemo Mättig (WMDE)) [08:53:57] (03CR) 10Daniel Kinzler: [C: 032] Cleanup SubmitEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140175 (owner: 10Thiemo Mättig (WMDE)) [08:54:11] (03Merged) 10jenkins-bot: Cleanup SubmitEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140175 (owner: 10Thiemo Mättig (WMDE)) [09:00:37] (03CR) 10Daniel Kinzler: [C: 04-1] "Several notes:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [09:01:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [09:07:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 (owner: 10Thiemo Mättig (WMDE)) [09:12:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [09:12:58] (03PS2) 10Thiemo Mättig (WMDE): Drop pointless null check [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 [09:14:31] (03PS1) 10Aude: Fix 'Wikibase\SiteLinkTable' not found error in dispatchChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140320 [09:14:51] Tobi_WMDE: ^ [09:21:57] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 17/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140076 (owner: 10WikidataBuilder) [09:22:00] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 16/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139801 (owner: 10WikidataBuilder) [09:24:43] (03PS1) 10Adrian Lang: Move JS datamodel to wikibase/data-model-javascript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140322 (https://bugzilla.wikimedia.org/66418) [09:27:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 (owner: 10Thiemo Mättig (WMDE)) [09:28:28] (03CR) 10Daniel Kinzler: Allow different sharding-formats in dumpJson (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [09:28:49] (03CR) 10Daniel Kinzler: [C: 04-1] "Unhappy with the naming of the snippet option." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [09:29:41] (03CR) 10Daniel Kinzler: "To clarify: we may want to use a snippet mode when combining dumps of different types of entities, or from different repose, etc. This has" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [09:32:35] (03CR) 10Daniel Kinzler: [C: 032] Cleanup TermBoxView a bit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139911 (owner: 10Thiemo Mättig (WMDE)) [09:32:49] (03Merged) 10jenkins-bot: Cleanup TermBoxView a bit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139911 (owner: 10Thiemo Mättig (WMDE)) [09:32:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140320 (owner: 10Aude) [09:37:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140322 (https://bugzilla.wikimedia.org/66418) (owner: 10Adrian Lang) [09:37:24] (03PS3) 10Thiemo Mättig (WMDE): Drop pointless null check and type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 [09:40:53] (03PS2) 10Thiemo Mättig (WMDE): Don't pass the User around as a parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 [09:48:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 (owner: 10Thiemo Mättig (WMDE)) [09:52:24] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 (owner: 10Thiemo Mättig (WMDE)) [10:00:31] (03PS1) 10WikidataBuilder: New Wikidata Build - 18/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140325 [10:08:06] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140322 (https://bugzilla.wikimedia.org/66418) (owner: 10Adrian Lang) [10:12:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140322 (https://bugzilla.wikimedia.org/66418) (owner: 10Adrian Lang) [10:13:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140325 (owner: 10WikidataBuilder) [10:15:29] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Almost +2, just a question." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [10:23:59] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Check for redirect before calling getEntity(). (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [10:27:31] (03CR) 10Jeroen De Dauw: [C: 032] "Yeah, this is really its own application." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140320 (owner: 10Aude) [10:29:31] Adrian_WMDE: why did you use 0.1 rather than 1.0? [10:29:37] (03CR) 10Jeroen De Dauw: [C: 032] Move JS datamodel to wikibase/data-model-javascript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140322 (https://bugzilla.wikimedia.org/66418) (owner: 10Adrian Lang) [10:29:58] (03PS6) 10Jeroen De Dauw: Deprecate EntityFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138130 [10:31:23] Adrian_WMDE: *moved, not removed? [10:34:23] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #120: Don't rely on assert() to bail on assertion failure (06master...06master) 02http://git.io/_oXchA [10:34:50] JeroenDeDauw: I thought we might try to line it up with wikibase/data-model version numbers once the JS is up to date with the PHP version [10:37:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138130 (owner: 10Jeroen De Dauw) [12:22:59] (03CR) 10Thiemo Mättig (WMDE): "Combining different dumps can't work that way. You will never end with a valid JSON blob. The first one needs an opening "[", all but the " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [12:28:06] (03CR) 10Jeroen De Dauw: [C: 04-1] "Can you mark the resolved items as done, and make it clear that you did not resolve all of them yet. I do not want to see this merged when" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [12:28:34] Lydia_WMDE: according to the mail of Magnus, the automated descriptions should work ... it does not at my end [12:31:59] (03PS4) 10Jeroen De Dauw: WIP stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 [12:32:30] Tobi_WMDE: I can haz easy review? https://gerrit.wikimedia.org/r/#/c/139607/ [12:32:58] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=66632 [12:33:26] JeroenDeDauw: guess I'll not have time to look at that today [12:33:29] my wiki is currently brken, so not right now [12:33:34] so if anybody else can [12:39:52] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [12:44:26] (03CR) 10Addshore: [C: 031] DispatchStats API: Output a ISO 8601 formatted timestamp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138306 (owner: 10Legoktm) [12:44:55] (03CR) 10Addshore: "An email / note should be sent out about this breaking change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138306 (owner: 10Legoktm) [12:45:47] (03CR) 10Jeroen De Dauw: "I don't get how this is a breaking change. Is this used in the web API?? Evil static spaghetti..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138306 (owner: 10Legoktm) [12:47:05] (03CR) 10Hoo man: [C: 032] "If no one cares, I guess this is good." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138130 (owner: 10Jeroen De Dauw) [12:47:18] (03Merged) 10jenkins-bot: Deprecate EntityFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138130 (owner: 10Jeroen De Dauw) [12:51:25] (03PS9) 10Addshore: Refacatoring MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [12:51:48] it's an addshore! [12:52:45] it's an addshore! :) [12:52:51] =o [12:52:54] oh hello! [12:53:13] hi addshore :) [12:53:19] hi aude! [12:53:22] hi hoo! [12:53:40] addshore is alive [12:53:47] oh hello JeroenDeDauw! [12:55:36] oh so much sun here :> [12:55:41] :) [12:55:59] addshore: back to the basement! [12:56:24] aude: https://www.wikidata.org/wiki/Q60 there aren't any references to reorder there AFAIS [12:56:34] hoo: within the reference [12:56:45] the snaks should be reorderable [12:57:00] (03PS1) 10Adrian Lang: Correctly resolve entityselector::search's promise [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140342 [12:57:18] i want date of publication atove publisher [12:57:21] how do i do that? [12:57:29] w/o having to remove and readd them [12:57:54] (03PS1) 10Adrian Lang: Make entityselector tests actually test user input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 [12:57:58] Ah, I see what you mean [12:58:16] (03CR) 10jenkins-bot: [V: 04-1] Make entityselector tests actually test user input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 (owner: 10Adrian Lang) [12:58:17] it's annoying if i put them in the wrong order from what i prefer [12:58:25] thought the issue was to reorder multiple references [12:58:28] nope [12:58:51] i don't know if this ever worked, but was broken since end of may at least [12:58:55] has been [13:00:58] (03PS2) 10Adrian Lang: Make entityselector tests actually test user input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 [13:03:46] Tobi_WMDE: loads of warnings at the start of our jenkins tests :O [13:04:05] about all the skins :P [13:04:12] * aude finds cirrus bug [13:04:31] (03PS1) 10Adrian Lang: Don't automatically select entity's on alias match in suggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) [13:04:39] for once, someone else's bug [13:04:54] (03CR) 10jenkins-bot: [V: 04-1] Don't automatically select entity's on alias match in suggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) (owner: 10Adrian Lang) [13:04:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [13:05:28] (03CR) 10Addshore: [C: 032] Refacatoring MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [13:05:43] (03Merged) 10jenkins-bot: Refacatoring MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130658 (owner: 10Thiemo Mättig (WMDE)) [13:07:10] (03PS2) 10Adrian Lang: Don't automatically select entity's on alias match in suggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) [13:13:15] (03PS1) 10Thiemo Mättig (WMDE): MWException is part of the EntityContent::getEntity interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140347 [13:18:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140342 (owner: 10Adrian Lang) [13:28:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 (owner: 10Adrian Lang) [13:29:28] (03PS3) 10Thiemo Mättig (WMDE): Don't pass the User around as a parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 [13:35:14] (03PS1) 10Daniel Kinzler: Hide (De)SerializerFactory on the app level. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140351 [13:35:16] (03PS1) 10Daniel Kinzler: Make internal storage format configurable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) [13:37:10] Tobi_WMDE, Lydia_WMDE: please add to sprint: https://bugzilla.wikimedia.org/show_bug.cgi?id=66784 [13:38:08] should really be in the old sprint, but... [13:40:18] hey brion! Up early? or is that just your digital ghost haunting us? [13:43:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 (owner: 10Adrian Lang) [13:43:06] *yawn* gmorning [13:51:36] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) (owner: 10Adrian Lang) [13:56:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) (owner: 10Adrian Lang) [14:01:28] (03CR) 10Aude: [C: 04-1] "see comment" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:01:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140347 (owner: 10Thiemo Mättig (WMDE)) [14:06:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 (owner: 10Thiemo Mättig (WMDE)) [14:06:40] * DanielK_WMDE_ hands brion some stroopwafel [14:07:19] (03CR) 10Thiemo Mättig (WMDE): "Looks good for me (except for what Aude found). Feel free to +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:08:23] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "+2! Just want to give the team a little time to look at this. Feel free to merge." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140351 (owner: 10Daniel Kinzler) [14:08:45] (03CR) 10Aude: "no default setting in the client?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:11:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140351 (owner: 10Daniel Kinzler) [14:15:56] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:18:06] oh noes, "An old copy of the MonoBook skin was found in your skins/ directory" ;) [14:18:13] and cologne blue [14:20:09] DELETE [14:20:09] DELETE [14:20:11] DELETE [14:20:14] :) [14:20:40] EXTERMINATE [14:22:13] Reedy: That's about how I feel atm setting up an OEM windows pc for my cousin... delete all the bloat apps -.- [14:22:18] (03PS2) 10Daniel Kinzler: Make internal storage format configurable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) [14:22:26] aude, Thiemo_WMDE --^ [14:22:31] k [14:23:24] das ist verboten! [14:23:44] aude: Was ist verboten? [14:24:01] entity serialization in the client [14:24:01] (03PS1) 10Thiemo Mättig (WMDE): Fix bits in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140369 [14:24:49] new ForbiddenSerializer [14:24:50] hehe [14:25:15] (03CR) 10Thiemo Mättig (WMDE): "Oh, this is a direct follow-up to I2490c9ca26824b5b0a312044f19efb93616f0597. Hey, Addshore! Owe you a review chocolate." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140369 (owner: 10Thiemo Mättig (WMDE)) [14:33:12] (03CR) 10Aude: [C: 04-1] "phpunit still complaining" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:34:27] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:39:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140369 (owner: 10Thiemo Mättig (WMDE)) [14:40:15] (03PS3) 10Daniel Kinzler: Make internal storage format configurable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) [14:47:28] (03CR) 10Daniel Kinzler: [C: 032] Fix bits in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140369 (owner: 10Thiemo Mättig (WMDE)) [14:47:42] (03Merged) 10jenkins-bot: Fix bits in MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140369 (owner: 10Thiemo Mättig (WMDE)) [14:48:24] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:50:55] (03PS4) 10Daniel Kinzler: Make internal storage format configurable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) [14:51:42] (03CR) 10Aude: "'internalEntitySerializerClass' => null can be added for the test jenkins is complaining about" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:52:05] (03CR) 10Aude: Make internal storage format configurable (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:52:29] (03CR) 10Aude: "comments in patch 3, but still apply" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:53:21] (03CR) 10Aude: "also, the legacy thing will fail spectacularly once we switch to data model 1.0" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [14:57:50] (03PS5) 10Daniel Kinzler: Make internal storage format configurable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) [15:00:12] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I don't fully understand the intention of the old code. But the new code looks good." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 (owner: 10Adrian Lang) [15:02:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [15:07:35] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [15:17:45] [13ValueView] 15thiemowmde created 06promise (+1 new commit): 02http://git.io/3eoczA [15:17:45] 13ValueView/06promise 14a282c05 15Thiemo Mättig: Fix incomplete promise documentation [15:18:41] [13ValueView] 15thiemowmde opened pull request #73: Fix incomplete promise documentation (06master...06promise) 02http://git.io/dDEd-g [15:21:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Trivial change, hard to understand and not correctly documented, unfortunately, see https://github.com/wmde/ValueView/pull/73" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140342 (owner: 10Adrian Lang) [15:21:37] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/GXdaAg [15:21:37] 13ValueView/06master 14c8b3c9b 15Marius Hoch: Merge pull request #73 from wmde/promise... [15:21:46] [13ValueView] 15mariushoch 04deleted 06promise at 14a282c05: 02http://git.io/89Gtog [15:22:33] (03Merged) 10jenkins-bot: Correctly resolve entityselector::search's promise [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140342 (owner: 10Adrian Lang) [15:24:54] hoo: somebody want to look at https://gerrit.wikimedia.org/r/#/c/140343/2 ? i'm just merging it otherwise. [15:25:47] Thiemo_WMDE: If it works, merge it [15:27:06] (03CR) 10Aude: [C: 032] Hide (De)SerializerFactory on the app level. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140351 (owner: 10Daniel Kinzler) [15:27:24] (03Merged) 10jenkins-bot: Hide (De)SerializerFactory on the app level. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140351 (owner: 10Daniel Kinzler) [15:29:18] (03CR) 10Aude: [C: 032] "looks good" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [15:29:56] (03Merged) 10jenkins-bot: Make internal storage format configurable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140352 (https://bugzilla.wikimedia.org/66784) (owner: 10Daniel Kinzler) [15:33:35] (03CR) 10Daniel Kinzler: "@Jeroen: One or two have open questions to you. I fixed all that seemed relevant and feasible. So, if you answer the questions, we can go " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [15:33:39] JeroenDeDauw: --^ [15:33:58] JeroenDeDauw: it would be helpful if you would identify the issues you consider blockers, btw [15:45:09] what the g**** f**** is this c****????????????? ReferenceError: evilsSeed is not defined [15:45:46] i wasted a day last week with this and still have no idea what it means. [15:47:10] 'evilsSeed' sounds like something JeroenDeDauw would have named [15:47:17] ah [15:47:18] hah [15:49:10] did i mentioned that i hate firefox? the clear cache feature is completely fucked up. [15:50:40] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Thanks to the fucked up caching in Mozilla Firefox another 30 minutes paid developers time got wasted. Great." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 (owner: 10Adrian Lang) [15:51:04] (03Merged) 10jenkins-bot: Make entityselector tests actually test user input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140343 (owner: 10Adrian Lang) [15:59:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Don't automatically select entity's on alias match in suggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) (owner: 10Adrian Lang) [15:59:33] (03Merged) 10jenkins-bot: Don't automatically select entity's on alias match in suggester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140344 (https://bugzilla.wikimedia.org/66748) (owner: 10Adrian Lang) [16:11:38] (03PS6) 10Daniel Kinzler: Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) [16:13:22] (03CR) 10Aude: [C: 04-1] Convert legacy format on export (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:16:51] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:18:57] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=66790 mh [16:21:09] hoo: hmm? [16:21:17] Lydia_WMDE: Reopen? [16:21:32] the other languages thing? [16:21:43] aude: it's a known thing? [16:21:52] not that i know [16:22:57] (03PS7) 10Daniel Kinzler: Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) [16:23:06] aude: --^ [16:23:26] hoo: hmmmm yeah if it is still happening please reopen [16:23:55] Ok, will try to verify myself first [16:24:19] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/140366/ [16:30:03] Lydia_WMDE, hoo: iirc, "nn" is somehow special. John would know... [16:30:37] i see [16:31:00] mh, it's one of these obsolete codes, right? [16:31:06] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Convert legacy format on export (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:31:08] i thought "no" was [16:31:13] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:31:15] mh [16:31:35] maybe "nn" also [16:31:36] no / nb was [16:31:38] or maybe not. not quite sure. i thought it was an alias code, but from a quick look, it doesn't seem like it is [16:31:50] Stryn: ah, that's what I was thinking of, then [16:39:20] (03CR) 10Daniel Kinzler: Convert legacy format on export (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:40:57] (03PS8) 10Daniel Kinzler: Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) [16:41:21] (03CR) 10Daniel Kinzler: "CR-1 because of pending discussion regarding regexp performance." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:49:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [16:49:29] (03PS1) 10Hoo man: Fix unit tests for non-English wikis [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/140399 [16:49:51] aude: Thiemo_WMDE: --^ easy peasy CR [16:50:52] if jenkins is happy, then looks good [16:51:34] it is :) [16:53:51] (03CR) 10Aude: [C: 032] Fix unit tests for non-English wikis [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/140399 (owner: 10Hoo man) [16:54:03] :) [16:54:16] Do we have it on our test instances now, btw? [16:55:24] after we put the entity/property suggester on, we can add it [16:55:34] * aude sorted out the queries to run on master again [16:55:47] (03Merged) 10jenkins-bot: Fix unit tests for non-English wikis [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/140399 (owner: 10Hoo man) [17:12:30] (03PS9) 10Daniel Kinzler: Convert legacy format on export [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) [17:20:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140366 (https://bugzilla.wikimedia.org/66719) (owner: 10Daniel Kinzler) [17:43:01] (03PS1) 10Daniel Kinzler: EntityViewPlaceholderExpander should use EntityRevisionLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140412 [17:43:19] (03CR) 10jenkins-bot: [V: 04-1] EntityViewPlaceholderExpander should use EntityRevisionLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140412 (owner: 10Daniel Kinzler) [17:51:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140412 (owner: 10Daniel Kinzler) [18:04:22] (03CR) 10Daniel Kinzler: [C: 031] "Seems fine to me, since the user is some kind of context info to the action. But I'd like someone else to give input on this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140318 (owner: 10Thiemo Mättig (WMDE)) [18:09:59] (03CR) 10Legoktm: "@Jeroen: Yes, it's exposed in the web API." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138306 (owner: 10Legoktm) [18:10:37] aude: Did we branch yet? [18:11:52] ok, we haven't [18:11:56] good [18:14:48] hoo: we probably are going to skip this week to ensure things are stable (e.g. the new serialization) [18:14:59] enough bugs with last deployment [18:15:13] aude: Ok, so next Tuesday is the day? [18:15:19] yes [18:16:32] btw, we also want to think about how to support users on wikidata to use lua [18:16:52] they already are using lua to access items on arbitrary pages with hacks [18:17:07] Show me the hacks [18:17:20] https://www.wikidata.org/wiki/Module:WBHacks [18:17:31] https://www.wikidata.org/wiki/Module:LoP_row [18:17:36] ah on wikidata [18:17:44] powerse the list of properties pages [18:17:47] powers* [18:17:50] that's not as bad as it would be on the WPs [18:17:58] there's another one too i think [18:18:15] which definitely will break, but should be possible to update to the new json format [18:18:34] better yet, we give them a programatic way to access entities that's not so dependent on specific format [18:18:51] don't worry about usage tracking, since it's being done already anyway [18:18:58] Well, there's a bug for making the Lua stuffs an own extension [18:19:05] yep [18:19:15] doesn't mean repo needs to be client yet (more sorting out for that, imho) [18:19:18] aude, hoo: https://www.wikidata.org/wiki/Module:Roadtable_row [18:19:26] ah [18:20:18] aude: Agreed... convince Lydia and I guess we're good to go [18:20:19] we should centralized LoP row to use WBHacks so we only need to update one module [18:20:37] i think she is convinced [18:21:00] just need this assigned [18:21:10] (03CR) 10Hoo man: [C: 032] "Good to go as branch day is only next Tuesday" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138306 (owner: 10Legoktm) [18:21:28] (03Merged) 10jenkins-bot: DispatchStats API: Output a ISO 8601 formatted timestamp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138306 (owner: 10Legoktm) [18:21:43] thanks! [18:22:05] You're welcome :) [18:22:32] aude: I can do that, after I'm done with the json stuffs [18:22:54] legoktm: Was a rather busy week so far, but I didn't forget the global rename things ;) [18:23:05] hoo: yay [18:23:05] :) [18:26:43] https://gerrit.wikimedia.org/r/139367 *grmbl* [18:26:59] that's the current json dumps blocker :/ [18:28:13] rage [18:29:15] legoktm: https://www.mediawiki.org/wiki/Wikidata_deployment#mw1.24wmf11 you might want to add your api change to that [18:29:44] ok, under "Deployment notes"? [18:29:57] or bug fixes? [18:30:25] do whatever you like... or maybe make an API breaking section and put both lines there [18:30:42] :P ok [18:44:40] legoktm: Talking about api breakage.... I have a bug open for that [18:44:59] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=66619 [18:55:22] multichill: I'm guessing that has to do with the api error message format changing [18:56:21] It's pretty damn anoying that api formats seem to change without informing downstream [18:59:17] legoktm: But do you know if it's changed and do you have a diff? [18:59:36] I think DanielK sent an email out about that? [18:59:59] http://lists.wikimedia.org/pipermail/wikidata-tech/2014-April/000473.html ha [19:01:24] A notice the lack of response [19:01:41] The wikidata technical documentation if a fucking mess [19:03:12] yeah, I can't follow what the code is supposed to return. [19:03:20] I think it should just be a normal API response. [19:24:24] hoo: aude: yes [19:24:26] :) [19:25:18] multichill: yeah we suck sometimes at notifying about api changes :( we need to get better at that [19:25:33] multichill: are you subscribed to wikidata-tech or only -l? [19:25:45] Both [19:25:49] ok good [19:26:37] Lydia_WMDE: In general the technical documentation is a mess [19:26:43] don't you use mediawiki-api-announce [19:26:56] There's a lot of pages, but not clear what is current and what is outdated [19:27:08] yeah :/ [19:27:31] Nemo_bis: ufff yet another mailing list to keep in mind. so no not yet but will try to post things there too [19:27:58] That list is really low volume and at least a trigger for us to start filing bugs [19:28:36] *nod* [19:28:53] it's not about it being too much in my inbox. just need to keep in mind to do it [19:28:58] Lydia_WMDE: So, this is a bug on a bug. The first bug is that we get random token errors [19:29:05] -tech is not as annoying as -bugs at least :p [19:29:16] The second bug is that the error output seems to have changed, crashing the bot [19:29:21] ok [19:29:45] Would be nice if someone could look into the token errors from the server side [19:30:21] At first I assumed it was because multiple bots were running at the same time (bot A gets token, bot B too, racing etc), but I only had one running [19:31:06] ok [19:32:32] (03PS1) 10Legoktm: Remove unnecessary ApiBase::getContext() call. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 [19:33:01] (03PS2) 10Legoktm: Remove unnecessary ApiBase::getContext() calls. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 [19:44:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 (owner: 10Legoktm) [19:48:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 (owner: 10Legoktm) [20:09:26] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140552 (owner: 10L10n-bot) [20:19:28] (03PS3) 10Legoktm: Remove unnecessary ApiBase::getContext() calls. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 [20:27:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 (owner: 10Legoktm) [21:25:07] (03CR) 10Hoo man: [C: 032] "I don't really see the benefit, but also it wont harm." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 (owner: 10Legoktm) [21:25:22] (03Merged) 10jenkins-bot: Remove unnecessary ApiBase::getContext() calls. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140446 (owner: 10Legoktm) [21:26:07] for some reason, it always bugs me when people use $this->getContext() on something that is a ContextSource. [21:26:30] it gives the impression that the current object does not provide those methods [21:26:54] One could argue now that Api modules shouldn't be context sources, but as long as they are that's ok [21:29:57] hi :) [21:30:35] hey lazowik :) [23:12:46] hello - is anyone around to help clarify something in the documentation for descriptions? [23:13:56] thepwnco: maybe [23:14:06] I'll take it! [23:14:40] so I am trying to decipher the section on "place the location at the end" http://www.wikidata.org/wiki/Help:Description#Place_the_location_at_the_end [23:14:55] and all is well until I get the example for Acathius of Melitene [23:15:43] Hm? [23:16:32] That seems fine to me [23:17:39] to me, it seems to contradict the guidelines for people discussed just a bit further up the page http://www.wikidata.org/wiki/Help:Description#Common_formulas [23:18:09] thepwnco: I've really gotta go now :/ Maybe some channel stalker can pick up where I left off [23:18:13] or for Lionel Messi (Argentinian footballer) under Capitalization [23:18:33] ok! I'm sure we've enticed them already with this discussion :P [23:18:41] all I have to do is wait... [23:18:46] thanks! [23:18:53] for a few years :p