[07:32:01] (03CR) 10Henning Snater: Accept array of HTML messages in tooltip JavaScript (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [08:13:19] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Almost +2. Just a question. Feel free to object." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139367 (owner: 10Hoo man) [09:21:20] (03CR) 10Thiemo Mättig (WMDE): Accept array of HTML messages in tooltip JavaScript (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138660 (https://bugzilla.wikimedia.org/66043) (owner: 10Thiemo Mättig (WMDE)) [09:30:48] (03PS37) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [09:39:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [09:43:09] hi [09:50:22] [13Geo] 15thiemowmde created 06typehints (+1 new commit): 02http://git.io/po5jRg [09:50:22] 13Geo/06typehints 14827ec30 15Thiemo Mättig: More precise type hints [09:56:50] Lydia_WMDE: https://commons.wikimedia.org/wiki/File:Wikidata_redesign_critics.png <- totally agree with that [09:57:51] hmmmm [09:58:10] How is the "discussions" thing planned to be implemented? [10:00:30] (03PS1) 10WikidataBuilder: New Wikidata Build - 17/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140076 [10:00:50] legoktm: something for later when flow is there [10:01:00] basically a view on the discussion page [10:01:03] [13Geo] 15thiemowmde opened pull request #14: More precise type hints (06master...06typehints) 02http://git.io/m3qELg [10:01:06] hmmmm [10:01:13] I'll save my thoughts on that for later then [10:01:25] hehe do tell [10:02:20] well mainly, what's the expected timeline on the UI redesign? [10:11:21] is there a ready-to-use script for retrieving Wikipedia title from an authority control number? [10:11:48] you'd probably have to use wdq [10:11:50] whym: hi, I think you can use Wikidata Query [10:11:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140076 (owner: 10WikidataBuilder) [10:11:56] :P [10:11:57] It accepts string [10:12:11] legoktm: mid-air collision :))) [10:12:52] Amir1: legoktm: thanks, I'll check it. [10:15:30] [13DataValues] 15thiemowmde created 06typehints (+1 new commit): 02http://git.io/uWYOvg [10:15:30] 13DataValues/06typehints 141413780 15Thiemo Mättig: More precise type hints [10:16:09] [13DataValues] 15thiemowmde opened pull request #7: More precise type hints (06master...06typehints) 02http://git.io/qpk1WQ [10:17:33] [13DataValues] 15mariushoch closed pull request #7: More precise type hints (06master...06typehints) 02http://git.io/qpk1WQ [10:19:41] legoktm: it'll be implemented over the course of the next 6 months i'd say [10:20:42] I don't think Flow will be ready by then. [10:21:08] I also don't think it's appropriate to put meta content (discussions on wiki) into the content [10:21:15] especially *above* content [10:21:27] I should probably write this on the wiki page... [10:23:43] https://www.wikidata.org/wiki/Wikidata:UI_redesign_input#.22Discussions.22 [10:23:49] legoktm: it's totally fine if it isn't ready by then. we'll just leave that part out [10:24:01] too easy to vandalise that talk page [10:24:19] (03PS38) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [10:24:21] (03PS2) 10Daniel Kinzler: Move serializ logic into EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 [10:24:21] or way to get nyandata into wikidata :) [10:24:55] Thiemo_WMDE: Good point about shard format vs. sharding format [10:24:57] mh [10:25:14] I think both are ok, but I should really chose ONE [10:25:27] agree. i was just wondering. [10:26:00] hi aude :) [10:26:14] Thiemo_WMDE, hoo: hm? [10:26:45] DanielK_WMDE_: do we want the thing to be name shardformat or shardingformat [10:27:02] what thing? [10:27:17] the option for not generating the [...]? [10:27:22] yeah [10:27:24] * aude waves from the train [10:27:24] i'm still for --snippet [10:27:34] aude: Where are you? [10:27:40] hey aude [10:27:42] probably near you :) [10:27:49] near frankfurt [10:28:00] Yeah, saw that yesterday... you are in my region :D [10:28:09] :D [10:30:36] aude: Deployed yesterday and we had the composer autoloader probs. again :/ [10:31:25] I fixed it by running sudo -u mwdeploy find /path/to/wikidata -exec touch {} \; and then sync-common [10:31:41] that's probably less disruptive then deleting the directory but also forces rsync to resync [10:31:53] hmmm [10:32:41] wonder how we can avoid those problems? [10:33:31] yeah [10:33:51] maybe touching stuff on tin and then running the sync-dir again might also work, but the root problem is still there [10:34:07] * JeroenDeDauw sees "get nyandata into wikidata" [10:34:17] rsync is only comparing size and change time, so that such 0-size changes can stay unnoticed [10:34:53] would be great if composer could force file size changes by using class names of different lengths for the autoloader or so [10:35:59] hoo: lolwat [10:36:07] (03CR) 10Thiemo Mättig (WMDE): Move serializ logic into EntityContentDataCodec (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [10:36:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [10:36:47] or having a --checksum option for sync-common would be aweseome... we would just need to pass that rough to rsync [10:37:09] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Move serializ logic into EntityContentDataCodec (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [10:37:36] JeroenDeDauw: Composer's autoloader quite often makes problems after deploys as it sometimes doesn't fully sync to all machines [10:37:55] like maybe one in five times one machine gets an invalidate state and starts fataling then [10:40:09] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Sorry, let's fix this in a followup. The line of dead code is dead and doesn't do anything." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [10:41:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [10:44:10] Lydia_WMDE the last stats of Wikidata are now more than a month old.. Could you see if things get moved along [10:44:26] GerardM-: mpfh a month? yes [10:45:00] http://tools.wmflabs.org/wikidata-todo/stats.php I already added a bug like a week ago [10:45:35] do you happen to have the bug number? [10:50:37] (03PS3) 10Daniel Kinzler: Move serializ. logic into EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 [10:50:50] (03CR) 10Daniel Kinzler: Move serializ. logic into EntityContentDataCodec (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [10:51:02] (03PS39) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [10:52:00] (03PS2) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [10:52:04] DanielK_WMDE_: Got a minute? [10:53:11] Lydia_WMDE: I have added you to the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=66362 [10:53:22] GerardM-: thanks :) [10:57:11] GerardM-: hi, what's wrong with this? http://dumps.wikimedia.org/wikidatawiki/20140612/ [11:04:00] Amir1: the resulting dump should be put in a specific, agreed place so that scripts like the statistics script pick it up [11:04:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [11:04:34] given that the statistics have not been updated, it has not been done [11:06:30] [13ValueView] 15adrianlang comment on pull request #59 14379125d: Yes, but the backend uses \Languages. 02http://git.io/HhXQxg [11:11:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [11:16:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [11:18:10] (03PS1) 10Adrian Lang: Remove getEditUrl from SectionEditLinkGenerator interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140088 [11:26:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140088 (owner: 10Adrian Lang) [11:26:44] [13WikibaseQuery] 15JeroenDeDauw created 06cli (+1 new commit): 02http://git.io/ohneyg [11:26:44] 13WikibaseQuery/06cli 14ab15736 15jeroendedauw: Add CLI app foundation with schema dump command [11:26:55] [13WikibaseQuery] 15JeroenDeDauw opened pull request #31: Add CLI app foundation with schema dump command (06master...06cli) 02http://git.io/flXN7w [11:30:05] [travis-ci] wmde/WikibaseQuery/cli/ab15736 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/27763688 [11:42:56] [13WikibaseQuery] 15adrianlang comment on pull request #31 14ab15736: dev-master 02http://git.io/dJRd6Q [11:43:26] [13WikibaseQuery] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/ftY1yw [11:43:26] 13WikibaseQuery/06master 14f51f146 15Adrian Lang: Merge pull request #31 from wmde/cli... [11:49:27] [13WikibaseQuery] 15JeroenDeDauw created 06clii (+1 new commit): 02http://git.io/RyVuOA [11:49:27] 13WikibaseQuery/06clii 145a23833 15jeroendedauw: Use master branch of QueryEngine and get the db platform from the connection [11:49:57] [13WikibaseQuery] 15JeroenDeDauw opened pull request #32: Use master branch of QueryEngine and get the db platform from the connection (06master...06clii) 02http://git.io/cp5rVw [11:50:58] Adrian_WMDE: https://github.com/wmde/WikibaseQuery/pull/32 [11:54:53] [travis-ci] wmde/WikibaseQuery/clii/5a23833 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/27765115 [11:55:06] [13WikibaseQuery] 15adrianlang 04deleted 06clii at 145a23833: 02http://git.io/h5iKkw [11:58:03] (03CR) 10Thiemo Mättig (WMDE): Move serializ. logic into EntityContentDataCodec (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [12:01:10] (03PS2) 10Thiemo Mättig (WMDE): Bump ValueView to version 0.6.3 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138679 [12:01:36] (03PS4) 10Daniel Kinzler: Move serializ. logic into EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 [12:01:42] (03CR) 10Thiemo Mättig (WMDE): "Daniel?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [12:03:22] (03PS3) 10Thiemo Mättig (WMDE): Find better name for DataUpdateClosure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 [12:03:33] DanielK_WMDE_: got a moment? [12:05:02] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138679 (owner: 10Thiemo Mättig (WMDE)) [12:16:17] Lydia_WMDE: hoo Tobi_WMDE i won't be around at deploy time [12:16:33] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "The code touched here needs a lot more refactoring, but not in this patch. I already started a followup and don't want it to explode even " (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [12:16:36] aude: today? [12:16:38] we're not deploying anything new ourselves but jquery.ui is being updated [12:16:41] in core [12:16:48] ok [12:16:54] be lookout for any problems [12:17:00] hopefully none [12:17:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [12:17:24] we backported / deployed one thing for this on friday [12:18:57] ok :) [12:19:02] hoo: daniel is in a meeting [12:21:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [12:27:03] meh, ok [12:53:53] (03CR) 10Thiemo Mättig (WMDE): "An other question, sorry." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [12:54:36] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=66418 [12:55:45] (03PS40) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [12:55:47] (03PS5) 10Daniel Kinzler: Move serializ. logic into EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 [12:56:55] (03PS3) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [12:59:37] (03CR) 10Thiemo Mättig (WMDE): "All PS5 did was removing an empty line. What did you do?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [13:00:16] (03PS3) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [13:08:54] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:18:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [13:22:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [13:27:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [14:05:05] [13WikibaseQuery] 15JeroenDeDauw created 06rf (+1 new commit): 02http://git.io/ohjKRg [14:05:05] 13WikibaseQuery/06rf 14ef0d39b 15jeroendedauw: Remove silly factory [14:05:25] Adrian_WMDE: ^ [14:05:30] [13WikibaseQuery] 15JeroenDeDauw opened pull request #33: Remove silly factory (06master...06rf) 02http://git.io/D-kQtQ [14:09:33] (03CR) 10Jeroen De Dauw: [C: 04-1] "Please move out the actual code into something that does not derive from Maintenance and add a test for that. Also, in case an option is a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139768 (https://bugzilla.wikimedia.org/64600) (owner: 10Legoktm) [14:12:44] [travis-ci] wmde/WikibaseQuery/rf/ef0d39b : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/27776488 [14:16:33] (03PS2) 10Jeroen De Dauw: Inline deprected code in deprecated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139607 [14:16:49] (03PS3) 10Jeroen De Dauw: WIP stop using deprecated methods in EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 [14:28:47] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139607 (owner: 10Jeroen De Dauw) [14:31:40] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139610 (owner: 10Jeroen De Dauw) [14:35:16] Lydia_WMDE: hi there - question about whether it's ok to abandon https://www.mediawiki.org/wiki/Talk:Requests_for_comment/New_sites_system The original author says he does not have time for it [14:35:19] from the talkpage: "This was a joint RFC between me and the Wiki Data team. They have implemented bits from this RFC and are using it in Wiki Data, however they did not seem interested in finishing the implementation, and I do not have the time for it." [14:37:58] sumanah: from my side yes [14:38:09] ok, I'll be marking it Abandoned. Thanks. [14:38:25] Lydia_WMDE: any other RfCs that you would like to either get approved faster, or mark as abandoned? [14:38:42] sumanah: no i think we're good atm wrt rfcs [14:38:47] cool thanks Lydia_WMDE [14:39:02] Lydia_WMDE: would welcome your thoughts on the talkpage for https://www.mediawiki.org/wiki/Requests_for_comment/Alternate_disclosure_policy [14:40:10] * sumanah looks at current status of https://www.mediawiki.org/wiki/Requests_for_comment/Wikidata_API and tries to remember/figure out whether it ought to be moved to dormant [14:45:57] Thiemo_WMDE: merge merge merge https://github.com/wmde/WikibaseQueryEngine/pull/55 [14:46:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "This chain of patches is becoming a knot. :-( You are coding to fast." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [14:46:20] (03Merged) 10jenkins-bot: Move serializ. logic into EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139855 (owner: 10Daniel Kinzler) [14:58:05] [travis-ci] wmde/WikibaseQueryEngine/unique/04c0e67 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/27779791 [14:59:21] JeroenDeDauw: just talked to Thiemo. we found a reason to keep the fungtion for getting a value hash, and also the index over entity/property/hash. it's for optimized updates, when you want to only remove the rows that were actually deleted. [14:59:42] (indead of always removing all rows for an entity, and them adding the new ones back) [15:02:40] I could not edit it says... [15:02:41] will be displayed as: [15:02:43] Exception Caught: DB connection error: Too many connections (10.64.16.26 [15:03:50] ... it has happened several times [15:04:02] GerardM-: you are making to many edits! o_O [15:05:30] btw JeroenDeDauw DanielK_WMDE_ - I don't think I've seen you comment yet on https://www.mediawiki.org/wiki/Talk:Requests_for_comment/SOA_Authentication in case you have thoughts (alternate title: "Inter-service user identification, authorization, and session management" ) [15:11:25] hey sumanah! [15:11:37] Hi :) [15:12:11] i don't know anything about the internals of oath and friends... i don't really feel qualified. but i'll have a look [15:12:18] *oauth [15:12:39] JeroenDeDauw: I do not have a bog flag and I do not flood ... so REALLY ? [15:15:24] Is it still erroring? [15:15:56] reedy it happens something like five times a day [15:17:49] GerardM-: lack of NyanCat perhaps? [15:18:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [15:18:39] no idea what NyanCat is [15:20:45] Thanks DanielK_WMDE_ [15:25:00] GerardM-: https://www.youtube.com/watch?v=wZZ7oFKsKzY [16:02:26] (03PS1) 10Thiemo Mättig (WMDE): [WIP] Clean-up IdGenerator after redirects are done [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140140 [16:03:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Sorry, I'm not convinced the new method in EntityStoreWatcher is needed. It looks like it does nothing the existing methods can't do." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [16:07:25] DanielK_WMDE__: Got a moment? [16:11:05] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140140 (owner: 10Thiemo Mättig (WMDE)) [16:30:47] The java script around selecting an item in a statement has changed and consequently the automated descriptions are gone... [16:31:07] It breaks how I can select the right Jodhpur [16:31:23] I need Q6207835 [16:31:51] it does have its statements ... PLEASE make a test scenario that proves that automated descriptions still works [16:33:03] and fail your code when it breaks essential functionality [16:40:53] [travis-ci] wmde/WikibaseQueryEngine/mv/cd07773 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/27789431 [16:46:53] (03CR) 10Thiemo Mättig (WMDE): Check for redirect before calling getEntity(). (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [16:51:57] (03PS1) 10Thiemo Mättig (WMDE): Drop pointless null check [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 [17:00:47] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140154 (owner: 10Thiemo Mättig (WMDE)) [17:03:27] DanielK_WMDE: Around now? [17:07:35] DanielK_WMDE_: please have a look at https://gerrit.wikimedia.org/r/140160 [17:08:07] question is how/ where to inject/ construct the EntityIdHtmlLinkFormatter [17:19:27] [travis-ci] wmde/WikibaseQueryEngine/mv/4999685 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/27789590 [17:44:42] Thiemo_WMDE: https://github.com/wmde/WikibaseQueryEngine/pull/57 [17:48:34] (03PS41) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [17:57:16] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:05:35] (03PS2) 10Daniel Kinzler: Re-implement undo action based on EntityContent. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 [18:06:02] Thiemo_WMDE: small but jucy: https://gerrit.wikimedia.org/r/#/c/139816/ [18:07:30] (03PS42) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [18:09:05] (03CR) 10Jeroen De Dauw: Implement redirects in ItemContent (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:09:11] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:12:11] (03PS4) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [18:12:16] (03PS4) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [18:19:40] (03CR) 10Jeroen De Dauw: Implement redirects in ItemContent (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:19:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 (owner: 10Daniel Kinzler) [18:30:24] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:36:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [18:39:01] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [18:43:28] (03CR) 10Daniel Kinzler: "following up in a moment" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:44:03] (03PS43) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [18:44:48] (03PS5) 10Daniel Kinzler: Check for redirect before calling getEntity(). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) [18:45:04] (03PS5) 10Daniel Kinzler: Allow creation of redirects via EntityStore. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) [18:46:47] (03CR) 10Aude: Implement redirects in ItemContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:48:51] (03CR) 10Daniel Kinzler: Implement redirects in ItemContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:53:04] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:53:14] (03CR) 10Aude: "nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [18:55:34] Lydia_WMDE: aude: Anyone working on new JS script screw ups? [18:55:53] hoo: which one exactly? [18:56:08] Lydia_WMDE: https://pics.ireas.org/uh.png [18:56:20] not found [18:56:55] damn [18:57:13] Lydia_WMDE: Another report here: [18:57:14] https://www.wikidata.org/wiki/Wikidata:Project_chat#Can.27t_add_link.3F [18:57:56] wtf [18:58:04] no not being worked on by anyone yet [18:58:05] can reproduce [18:58:09] yeah me too [18:58:10] ok, damn [18:58:46] maybe ask what browser and settings people are using? [18:58:47] i'll answer on project chat [18:58:57] FakirNL: we can reproduce [18:59:13] ah, okay, misread [18:59:14] hoo: will you look into it or should someone else? [18:59:17] FakirNL: :) [18:59:21] Lydia_WMDE: On it atm [18:59:26] thanks! [19:01:53] Lydia_WMDE: See it [19:02:01] \o/ [19:02:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139390 (https://bugzilla.wikimedia.org/66030) (owner: 10Daniel Kinzler) [19:02:25] when you have a fix Thiemo_WMDE can hopefully review it [19:03:11] (03PS1) 10Thiemo Mättig (WMDE): Cleanup SubmitEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140175 [19:05:01] (03CR) 10Aude: Implement redirects in ItemContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [19:11:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139830 (https://bugzilla.wikimedia.org/66073) (owner: 10Daniel Kinzler) [19:11:32] . [19:14:56] [13WikibaseDataModel] 15thiemowmde pushed 3 new commits to 06master: 02http://git.io/c02sRw [19:14:56] 13WikibaseDataModel/06master 14b878c6f 15jeroendedauw: Improve Entity::setId... [19:14:56] 13WikibaseDataModel/06master 1415c79df 15Jeroen De Dauw: Update Entity.php [19:14:56] 13WikibaseDataModel/06master 14142ee56 15thiemowmde: Merge pull request #107 from wmde/setid... [19:15:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140175 (owner: 10Thiemo Mättig (WMDE)) [19:16:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Re-implement undo action based on EntityContent. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 (owner: 10Daniel Kinzler) [19:16:27] (03Merged) 10jenkins-bot: Re-implement undo action based on EntityContent. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139816 (owner: 10Daniel Kinzler) [19:17:41] why the fuck does this work for me locally [19:18:46] Thiemo_WMDE: what you just merged adds functionality without adding any tests... [19:19:13] 6 argument method [19:19:27] Bad code with no tests [19:19:27] i noticed that, but this thing keeps blocking a whole chain of patches. [19:20:03] No reason to throw quality out of the window [19:20:08] alredy started a followup. [19:20:17] Thiemo_WMDE: thnx [19:20:37] thats not equal to ignoring quality metrics. [19:20:42] come on. [19:22:43] Thiemo_WMDE: I am telling you that I see a commit with no tests and bad code quality getting merged and that this worries me [19:23:02] sure. correct and understood. [19:23:45] Lydia_WMDE: Hah! [19:23:48] Already fixed on master [19:23:56] thank Adrian [19:23:59] -.- [19:24:24] will revert locally and verify [19:24:32] great [19:24:50] kittens [19:24:52] !nyan [19:24:53] ~=[,,_,,]:3 [19:24:53] yep [19:25:04] Lydia_WMDE: You want that deployed ASAP? [19:25:15] yes please [19:25:19] this looks really bad [19:25:20] (03PS1) 10Hoo man: Remove dead calls to autocomplete [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140180 [19:25:31] i wonder why adrian didn't bring that up today if he already fixed it [19:25:41] maybe he didn't realize it was an issue on the live site? [19:25:52] Probably [19:26:09] aude: You around? [19:26:25] she said she's not around for deployment today [19:26:26] He probably didn't realize that it takes us this long for stuff to go live [19:26:31] That's ok [19:26:37] Can do it on my own [19:26:40] ok [19:27:08] what's broken? [19:27:10] hoo: i really owe you cookies :P [19:27:14] aude: hah! [19:27:19] adding sitelinks [19:27:30] Yeah, JS stuffs [19:27:38] fix: https://gerrit.wikimedia.org/r/140180 [19:27:49] :( [19:28:08] go ahead and deploy it [19:30:39] * hoo kicks WikidataJenkins [19:31:39] WikidataJenkins learned by now how to dodge kicks from hoo [19:32:00] hoo: you know who it is going to go after first when it becomes self aware... [19:32:28] JeroenDeDauw: That's why we should migrate to something different :D [19:33:02] (03CR) 10Hoo man: [C: 032 V: 032] "JS only stuff... confident enough to ignore WikidataJenkins here" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140180 (owner: 10Hoo man) [19:33:56] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140180 (owner: 10Hoo man) [19:35:04] :) [19:35:36] aude: I guess it's enough to only push that to 9 as both test and real wikidata are on that [19:36:01] gree [19:36:03] can also do both if you prefer, but I see no need, only doubles the chance we see composer auto load problems again [19:37:16] composer still hasn't picked up the change :/ [19:38:16] now [19:38:29] * aude fighting spotty internet [19:38:49] back in ~ hour [19:39:15] see you ;) [19:39:20] (03PS1) 10Hoo man: Update Wikibase to fix editing site links [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140188 [19:39:20] k [19:39:36] (03Abandoned) 10Hoo man: Update Wikibase to fix editing site links [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140188 (owner: 10Hoo man) [19:39:40] (03PS1) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityTermLoopups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 [19:42:23] (03PS1) 10Hoo man: Update Wikibase to fix editing site links [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140190 [19:45:52] (03CR) 10Hoo man: [C: 032] Update Wikibase to fix editing site links [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140190 (owner: 10Hoo man) [19:48:58] (03Merged) 10jenkins-bot: Update Wikibase to fix editing site links [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140190 (owner: 10Hoo man) [19:54:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [19:58:04] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/140188 (owner: 10Hoo man) [20:01:53] Is there any warnings-templates to sent to vandals? [20:02:08] (03PS1) 10Thiemo Mättig (WMDE): Make LanguageFallbackChain aware of EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 [20:04:42] Lydia_WMDE: Stuff is fine again for me [20:04:45] please let the users know [20:04:52] hoo: thanks! [20:04:54] will do [20:05:02] will be around for another few minutes, then switch to the world cup [20:05:21] thepwnco: hey, sorry for my long absence [20:05:22] I had some really busy days :/ [20:05:46] benestar: that's ok! how's it going? [20:06:19] hoo: have fun ;-) [20:06:28] I have the code for testwikidata but it is really hackish... [20:06:38] so I'm not really happy with the implementation [20:07:08] the problem is that the extension wants us to define the tour before the page has been loaded [20:07:15] * finished loading [20:07:34] so we have to load everything synchronously which is quite a mess [20:07:44] eep [20:08:14] does it seem like it will work? [20:08:26] maybe I will try to fix it in the extension itself [20:08:32] but that will take some more time [20:08:53] for demo purposes I think I will install the script on wikidata itself for now [20:09:06] as long as there aren't too many editors this will create no problems [20:09:31] ok [20:09:32] however, we have to find a nicer solution but that will take some more time perhaps ... [20:10:56] like possibly ditching the extension entirely? [20:11:50] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] (mw1.24-wmf8) - 10https://gerrit.wikimedia.org/r/140190 (owner: 10Hoo man) [20:11:57] thanks, Lydia_WMDE :) [20:12:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140197 (owner: 10Thiemo Mättig (WMDE)) [20:13:17] indeed [20:16:37] ok, I will see what's available in the way of alternatives and discuss with Lydia_WMDE [20:17:02] should we wait and see how the demo goes? [20:17:47] thepwnco: yes, maybe there is also a nice way to do it in the current way [20:17:58] just need some more time... [20:18:02] as always ^^ [20:18:42] of course! Well let me know if you need help/testing [20:18:59] or if you want to discuss different workarounds [20:19:28] k :) [20:20:17] (03PS2) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityTermLoopups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 [20:21:37] sorry this has been so complicated...but I'm sure it will work out in the end. And it will be great of course [20:27:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [20:44:30] (03PS3) 10Thiemo Mättig (WMDE): [WIP] Introduce EntityTermLoopups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 [20:45:24] I just finnished adding description to these: http://tools.wmflabs.org/wikidata-terminator/?lang=en&term=Raj+Bhavan&doit=1 [20:47:47] Josve05a: yay :) [20:50:54] :D [20:52:15] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] [WIP] Introduce EntityTermLoopups (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [20:52:17] Thiemo_WMDE: leaving in 10 min [20:52:21] ok [20:52:40] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [21:00:49] (03CR) 10Thiemo Mättig (WMDE): "Please note that the class is tested in EditEntityActionTest. But I'm not sure if the new code I merged in I832bef721f481bf91375174ddecdd3" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140175 (owner: 10Thiemo Mättig (WMDE)) [21:12:17] (03CR) 10Aude: "what is a Loopup? :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/140189 (owner: 10Thiemo Mättig (WMDE)) [22:23:04] thepwnco: hey, me again [22:23:32] just cleaned up the code a bit [22:23:34] hello [22:23:41] now which tours should already go live? [22:24:43] thepwnco: by the way, the current implementation enforces a headline for each new dialogue [22:25:00] ok, I wondered about that [22:25:05] so you might replace all '''dialogue''' notes by duplicating the headline above [22:25:14] most have headlines, but some don't. We can just repeat headlines though right? [22:25:22] great, will do [22:25:24] yep, that'd be my suggestion [22:25:52] thepwnco: so you wanna have the items tour and the statements 1 tour live already, right? [22:25:57] so I think for now we have https://www.wikidata.org/wiki/Wikidata:Tours/Project_Plan_and_Content_Outline/Items (basically just slightly modifying the tour we already have) [22:26:05] and https://www.wikidata.org/wiki/Wikidata:Tours/Project_Plan_and_Content_Outline/Statements [22:26:08] that's correct! [22:26:24] I think that's good to start and then we'll see where things stand [22:26:28] I'll update the dialogues now [22:27:23] also, the tour # were left blank because presumably they will change (as more are created or clustered together) [22:27:36] would you like me to just remove them? [22:27:53] just put the header of the first page there [22:28:12] however, the headline must exist, so maybe just == Items == might fit [22:28:26] or Welcome to Tour 1 for nwo [22:28:29] *now [22:28:36] that's your decision [22:31:20] ok, Items should be ok to go [22:34:50] and Statements 1 [22:39:43] thepwnco: what should exactly be highlighted when you say "Action - highlight Q#" ? [22:40:51] I was thinking the Q# on the item page (right beside the label) [22:41:33] ah, ok [22:41:46] thepwnco: maybe tomorrow you will get some live results :) [22:41:51] it's actually under the label field instead of beside it for items missing labels though [22:41:58] woot woot! Looking forward to it [22:42:07] I fixed some technical aspects today making everything much easier [22:42:29] that's great! good job :) [22:42:29] the actual tour code will just look like this one: https://www.wikidata.org/wiki/MediaWiki:Guidedtour-tour-wikidatabasics.js [22:42:46] so it only contains highlighting information, nothing else [22:43:00] but more tomorrow ;) [22:43:11] or maybe rather on thursday ... [22:43:19] anyway, cu [22:43:40] cool, thanks so much! see you later