[05:25:59] hi [05:26:27] when you will implement wikidata at wikt? [06:03:24] Juandev: http://wikidata.org/wiki/Wikidata:Wiktionary [06:06:29] ah great page nemo:-) [08:12:23] (03PS1) 10Thiemo Mättig (WMDE): No strict change type validation on the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139084 [08:20:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139084 (owner: 10Thiemo Mättig (WMDE)) [09:08:45] (03PS2) 10Daniel Kinzler: Make EntityContentFactory rely on EntityHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 [09:11:39] (03PS4) 10Daniel Kinzler: Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 [09:11:41] (03PS23) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [09:11:54] (03CR) 10Daniel Kinzler: [C: 04-1] "incomplete" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [09:14:54] [13jenkins-job-builder-config] 15tobijat pushed 1 new commit to 06master: 02http://git.io/qtJqUg [09:14:54] 13jenkins-job-builder-config/06master 14e6e2cd4 15Tobi Gritschacher: Merge pull request #9 from wmde/adjust_browsertest_builds... [09:21:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [09:22:31] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Implement redirects in ItemContent (0312 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [09:27:36] Tobi_WMDE: darf ich dich 2min wegen deinem browsertest-lösch-patch in anspruch nehmen? [09:27:59] Thiemo_WMDE: klaro, ich komm rüber [09:28:08] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [09:29:44] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [09:37:36] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Please rename WikidataBrowserTestsOld to WikidataRSpecBrowserTests or something like that. Don't use "old" in names. Never. :-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) (owner: 10Tobias Gritschacher) [09:39:10] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Tobi says I should wait a few hours before merging this. Well." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138805 (https://bugzilla.wikimedia.org/66469) (owner: 10Tobias Gritschacher) [10:00:25] (03PS1) 10WikidataBuilder: New Wikidata Build - 12/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139088 [10:05:07] (03CR) 10Aude: "what about deleted properties? though, i realize the commit summary says items" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (https://bugzilla.wikimedia.org/65002) (owner: 10Hoo man) [10:07:40] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Make EntityContentFactory rely on EntityHandler. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [10:11:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139088 (owner: 10WikidataBuilder) [10:12:41] (03PS3) 10Thiemo Mättig (WMDE): Make EntityContentFactory rely on EntityHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [10:16:50] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 12/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139088 (owner: 10WikidataBuilder) [10:17:09] let's hope jQuery issues are fixed on beta now [10:18:27] * aude hope so! [10:19:56] (03Merged) 10jenkins-bot: New Wikidata Build - 12/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139088 (owner: 10WikidataBuilder) [10:20:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [10:26:05] Thiemo_WMDE: woh, that looks crazy: https://github.com/wmde/WikibaseQueryEngine/pull/51/files#diff-851b2ca1a3a772a427609951ed137cf1R49 [10:27:51] foreach foreach foreach foreach ? [11:13:05] (03PS7) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [11:13:16] (03PS8) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [11:23:59] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [11:27:32] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/fj0whA [11:27:32] 13WikibaseInternalSerialization/06master 149c59706 15Jeroen De Dauw: Update bootstrap.php [11:28:26] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [11:35:59] (03PS9) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [11:36:10] (03CR) 10Daniel Kinzler: [C: 031] "thanks for fixing, thiemo!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [11:36:22] hey! [11:36:27] (03PS5) 10Daniel Kinzler: Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 [11:36:49] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/139088 (owner: 10WikidataBuilder) [11:36:56] yay [11:36:59] beta fixed [11:37:04] hurray! [11:37:05] browsertests passing [11:37:36] Thiemo_WMDE: feel free to merge the changes we discussed earlier.. [11:39:01] Tobi_WMDE, JeroenDeDauw: did you ever find the issue with the tests failing for the serializer patch? [11:41:04] DanielK_WMDE_: nope [11:44:09] (03PS2) 10Thiemo Mättig (WMDE): Clean-up SqlStore::newEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138831 [11:46:20] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make EntityContentFactory rely on EntityHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [11:46:34] (03Merged) 10jenkins-bot: Make EntityContentFactory rely on EntityHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138819 (owner: 10Daniel Kinzler) [11:47:57] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [11:54:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [11:57:53] (03PS3) 10Thiemo Mättig (WMDE): Refactoring/optimizing SpecialUnconnectedPages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138100 [12:00:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138831 (owner: 10Thiemo Mättig (WMDE)) [12:06:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138100 (owner: 10Thiemo Mättig (WMDE)) [12:06:56] (03PS2) 10Thiemo Mättig (WMDE): Find better name for DataUpdateClosure [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 [12:14:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137948 (owner: 10Thiemo Mättig (WMDE)) [12:20:15] (03PS10) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [12:26:35] [13Diff] 15JeroenDeDauw 04force-pushed 062 from 147508a1f to 1439d4e6a: 02http://git.io/ueOSbw [12:26:35] 13Diff/062 146013934 15jeroendedauw: Protected to private [12:26:35] 13Diff/062 147b59921 15jeroendedauw: Remove Diff.credits.php and update version numbers to 2.0 alpha [12:26:35] 13Diff/062 14eac55e7 15jeroendedauw: Update package description [12:26:54] [13Diff] 15JeroenDeDauw comment on pull request #11 1439d4e6a: ![nyan_data](https://cloud.githubusercontent.com/assets/146040/3257493/cdb22628-f22c-11e3-880e-7fa3e8cc7cc9.gif)... 02http://git.io/nSaJIQ [12:27:55] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [12:28:55] [travis-ci] wmde/Diff#43 (2 - 39d4e6a : jeroendedauw): The build was fixed. [12:28:55] [travis-ci] Change view : https://github.com/wmde/Diff/compare/7508a1fa8534...39d4e6a5f9d2 [12:28:55] [travis-ci] Build details : http://travis-ci.org/wmde/Diff/builds/27399010 [12:29:56] Merge for moar Nyan https://github.com/wmde/Diff/pull/11 [12:46:16] DanielK_WMDE_: where is this code in which it is not possible to sanely construct an EntityDiff without being able to construct empty entities? [12:46:48] (03CR) 10Jeroen De Dauw: [C: 032] Refactoring/optimizing SpecialUnconnectedPages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138100 (owner: 10Thiemo Mättig (WMDE)) [12:48:09] (03PS2) 10Tobias Gritschacher: Get rid of old browsertest files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) [12:48:38] (03CR) 10Tobias Gritschacher: "@Thiemo: renamed the repository for the old tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) (owner: 10Tobias Gritschacher) [12:48:51] (03CR) 10Jeroen De Dauw: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [12:49:55] JeroenDeDauw: EntityChange::newFromUpdate is one that is in core. I'm creating EntityContent::getDiff in If091211c1d which will have a simmilar need. [12:50:46] JeroenDeDauw: you can write special case code to generate a diff "compared to null" - it just seems a bad idea to do that. for the same reason "anchored" linked lists are better than unanchored ones. [12:51:07] (playing with that was a nice learnign experience) [12:52:13] (03CR) 10Daniel Kinzler: Don't use services in EntityContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [12:53:50] DanielK_WMDE_: I suspect this can easily be done with 5 lines of code] [12:55:25] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [12:55:27] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) (owner: 10Tobias Gritschacher) [12:55:35] JeroenDeDauw: surprise me, then. btw, this is not the *only* reason I think "incomplete" entites are convenient (and can be made harmless). [12:55:39] (03Merged) 10jenkins-bot: Don't use services in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138827 (owner: 10Daniel Kinzler) [12:55:46] but i'm curious how you would solve this [12:55:51] (03PS24) 10Thiemo Mättig (WMDE): Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:00:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:06:41] Tobi_WMDE: i don't have enough rights there: https://github.com/wmde/WikidataBrowserTestsRSpec/pull/1 [13:07:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Get rid of old browsertest files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) (owner: 10Tobias Gritschacher) [13:07:32] (03Merged) 10jenkins-bot: Get rid of old browsertest files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138800 (https://bugzilla.wikimedia.org/66468) (owner: 10Tobias Gritschacher) [13:07:36] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move browsertests from Wikibase.git into its own repository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138805 (https://bugzilla.wikimedia.org/66469) (owner: 10Tobias Gritschacher) [13:07:59] (03Merged) 10jenkins-bot: Move browsertests from Wikibase.git into its own repository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138805 (https://bugzilla.wikimedia.org/66469) (owner: 10Tobias Gritschacher) [13:18:18] (03PS25) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [13:18:34] (03CR) 10jenkins-bot: [V: 04-1] Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:18:47] (03CR) 10Daniel Kinzler: "needs more tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:20:18] (03PS26) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [13:24:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:24:26] (03CR) 10Daniel Kinzler: [C: 032] No strict change type validation on the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139084 (owner: 10Thiemo Mättig (WMDE)) [13:24:40] (03Merged) 10jenkins-bot: No strict change type validation on the client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139084 (owner: 10Thiemo Mättig (WMDE)) [13:27:38] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [13:33:44] Thiemo_WMDE: I've added the repositories to the wikidata team now [13:33:53] so, everybody should have enough rights now [13:33:57] thx [13:46:30] [13WikibaseDataModel] 15JeroenDeDauw created 06diff (+2 new commits): 02http://git.io/SgJgtg [13:46:30] 13WikibaseDataModel/06diff 1480fedfb 15jeroendedauw: Move diff classes into their own NS [13:46:30] 13WikibaseDataModel/06diff 145d80b5c 15jeroendedauw: Move diff code out of Entity and derivatives [13:47:20] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #118: Improvements to entity diffing code (06master...06diff) 02http://git.io/nr_XsA [13:50:20] [13puppet-composer] 15filbertkm created 06gerrit (+1 new commit): 02http://git.io/ZzRpRg [13:50:20] 13puppet-composer/06gerrit 1412ab615 15aude: Use composer 1.0.0-alpha8 from gerrit [13:53:05] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06diff: 02http://git.io/RYGUlg [13:53:05] 13WikibaseDataModel/06diff 14a3483d5 15jeroendedauw: Type hint against a more narrow interface [13:55:44] (03CR) 10Thiemo Mättig (WMDE): Implement redirects in ItemContent (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:08:24] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06diff: 02http://git.io/0DMEzg [14:08:24] 13WikibaseDataModel/06diff 147e12c9c 15jeroendedauw: Add more fine grained tests for EntityDiffer [14:19:31] (03PS27) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [14:21:42] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06diff: 02http://git.io/fFOi5g [14:21:42] 13WikibaseDataModel/06diff 1404bad6f 15jeroendedauw: Add dedicated tests for ItemDiffer [14:23:02] (03CR) 10Daniel Kinzler: Implement redirects in ItemContent (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:24:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:25:54] (03PS28) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [14:28:26] redirects :3 [14:32:48] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [14:39:38] (03PS1) 10Thiemo Mättig (WMDE): Fix entity selector being invisible/partly hidden in MonoBook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139116 [14:42:40] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06diff: 02http://git.io/cYDbQg [14:42:40] 13WikibaseDataModel/06diff 14da3c58a 15jeroendedauw: Add getConstructionDiff and getDescriptionDiff to EntityDiffer [14:46:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139116 (owner: 10Thiemo Mättig (WMDE)) [15:07:55] [13WikibaseDataModel] 15brightbyte comment on commit 14da3c58a: I thought the entire point was to make Item::newEmpty() go away? 02http://git.io/UmYnYA [15:24:43] [13WikibaseDataModel] 15brightbyte comment on commit 14da3c58a: So toDiffArray() gives me somethign I can compare to an empty array, without the need to construct an entity Property. Should work. Wil need special case code pathes for calling getConstructionDiff/getDeastructionDiff where approprate (as opposed to filling in empty entities when they are null). 02http://git.io/cPkZ6g [16:16:24] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Use uncached EntityLookup during testin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138828 (owner: 10Daniel Kinzler) [16:16:33] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14da3c58a: Nope. I already mentioned several times that I do not want to force entities to have an id set. 02http://git.io/cFrp4w [16:16:40] (03Merged) 10jenkins-bot: Use uncached EntityLookup during testin [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138828 (owner: 10Daniel Kinzler) [16:17:51] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14da3c58a: You will have a different code path in either case, though it might differ where this is located 02http://git.io/I7zcHg [16:28:13] [13puppet-composer] 15filbertkm pushed 1 new commit to 06gerrit: 02http://git.io/Gv3HrA [16:28:13] 13puppet-composer/06gerrit 14fa05a51 15aude: add module for installing composer and update [16:31:45] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06desc at 14120897e: 02http://git.io/Ie7wlQ [16:34:20] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06setid from 148f08c29 to 14b878c6f: 02http://git.io/ZeqBTQ [16:34:20] 13WikibaseDataModel/06setid 14b878c6f 15jeroendedauw: Improve Entity::setId... [16:36:01] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/VvRxCg [16:36:01] 13WikibaseDataModel/06master 14fb6c63f 15jeroendedauw: Re-add description for on Special:Version... [16:41:22] (03PS11) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [16:43:44] (03PS12) 10Jeroen De Dauw: Use new serializers for entity serialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 [16:49:14] [13WikibaseQuery] 15filbertkm created 06special (+1 new commit): 02http://git.io/zufM2g [16:49:14] 13WikibaseQuery/06special 14705347f 15aude: Update use for special page... [16:49:20] rage [16:51:09] [13WikibaseQuery] 15filbertkm pushed 1 new commit to 06special: 02http://git.io/XTmd5A [16:51:09] 13WikibaseQuery/06special 14fcd5ab2 15aude: Use private instead of protected in Special:SimpleQuery... [16:51:49] [13WikibaseQuery] 15filbertkm opened pull request #29: Special (06master...06special) 02http://git.io/vix_yg [16:52:33] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [16:57:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/138821 (owner: 10Jeroen De Dauw) [17:01:32] [13WikibaseQuery] 15filbertkm pushed 1 new commit to 06special: 02http://git.io/rpIxZg [17:01:32] 13WikibaseQuery/06special 141c4430c 15aude: SimpleQuery::getResult must be protected [17:06:18] [13WikibaseQuery] 15filbertkm created 06fatal at 14705347f (+0 new commits): 02http://git.io/qOw66A [17:06:43] [13WikibaseQuery] 15filbertkm opened pull request #30: Update use for special page, fix fatal error (06master...06fatal) 02http://git.io/BJDKqg [17:07:18] [travis-ci] wmde/WikibaseQuery/special/705347f : aude The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/27422110 [17:07:28] JeroenDeDauw: DanielK_WMDE_ Thiemo_WMDE https://github.com/wmde/WikibaseQuery/pull/30 [17:11:15] [13WikibaseDataModel] 15thiemowmde comment on pull request #107 14b878c6f: It seems we are talking about different thinks. The old implementation may be deprecated, but it's gone. This is an abstract interface now. It's obviously not deprecate. Both implementations use it. 02http://git.io/aehXnA [17:15:00] [13WikibaseQuery] 15thiemowmde 04deleted 06fatal at 14705347f: 02http://git.io/aegqOw [17:15:25] [travis-ci] wmde/WikibaseQuery/special/fcd5ab2 : aude The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/27422190 [17:17:38] [13WikibaseQuery] 15thiemowmde 04force-pushed 06special from 141c4430c to 1441873df: 02http://git.io/yZ8ukQ [17:17:38] 13WikibaseQuery/06special 1441873df 15aude: Use private instead of protected in Special:SimpleQuery... [17:19:40] (03PS29) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [17:20:34] https://bugzilla.wikimedia.org/show_bug.cgi?id=66536 [17:23:27] Krinkle: access denied [17:23:42] limited to security group, I think a few wikidata members have access to it. [17:24:15] Krinkle: if it is relevant for wikidata please add me to cc. i don't have access and don't know who does [17:24:17] Krinkle: i don't think so. [17:24:24] Krinkle: me too [17:25:07] I've added daniel's wmde address to CC. It's viral. [17:26:26] [travis-ci] wmde/WikibaseQuery/special/1c4430c : aude The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/27422902 [17:27:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [17:28:03] DanielK_WMDE_: Ping greg in #wikimedia-operations, I gotta run now. [17:37:11] [travis-ci] wmde/WikibaseQuery/fatal/705347f : aude The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/27423381 [17:47:09] [13WikibaseDataModel] 15brightbyte comment on pull request #107 14b878c6f: As far as I understand, the notion of *all* Entities having a setId() method is deprecated, while we want Item and Property to indeed have such a method (but potentially not other kinds of Entity).... 02http://git.io/7dut1Q [18:46:53] (03PS30) 10Daniel Kinzler: Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) [18:48:39] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #107 14b878c6f: So with this change, this call will appear as deprecated:... 02http://git.io/Pl77JA [18:50:24] [13WikibaseQuery] 15JeroenDeDauw 04deleted 06special at 1441873df: 02http://git.io/WQ2sDg [18:54:39] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [19:39:28] (03PS31) 10Thiemo Mättig (WMDE): Implement redirects in ItemContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [19:46:43] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [19:49:53] (03CR) 10Thiemo Mättig (WMDE): "I have not the slightest idea how a patch set that I published at I0f28a2e2469f ended here. How to undo? Why does "git reset f853604e3e11"" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134379 (https://bugzilla.wikimedia.org/57744) (owner: 10Daniel Kinzler) [20:34:12] any wikidata core around? https://bugzilla.wikimedia.org/show_bug.cgi?id=66555 ... who wants to play with the content handler / TitleValue...? [20:40:21] [13WikibaseDataModel] 15thiemowmde comment on pull request #107 14b878c6f: > deprecate polymorphic calls to it.... 02http://git.io/oAnb8A [20:42:48] yurikR2: I assume it is a Wikidata-relatable bug? [20:47:20] JohnLewis, kinda - it's a core bug in contenthandler, and wikidata team is the expert in that field ;) [20:47:51] yurikR2: Ah. Well, I've CC'd wikidata-bugs. Might get some attention from the team then :) [20:48:03] JohnLewis, thx :) [20:49:27] [13WikibaseQuery] 15thiemowmde 04deleted 06qe at 1446079e0: 02http://git.io/DHSPOQ [21:46:57] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/139261 (owner: 10L10n-bot)