[00:10:06] (03PS1) 10Hoo man: Don't link deleted items, rather show a text node [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 [00:10:23] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/11c41cc : Hoo man The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26620734 [00:15:55] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (owner: 10Hoo man) [00:26:39] (03PS1) 10Hoo man: Fix DiffViewTest for languages other than English [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136953 [00:26:52] JeroenDeDauw: aude: Thiemo_WMDE: --^ In case you're just online [00:30:13] (03PS2) 10Hoo man: Don't link deleted items, rather show a text node [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (https://bugzilla.wikimedia.org/65002) [00:35:10] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136953 (owner: 10Hoo man) [00:39:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (https://bugzilla.wikimedia.org/65002) (owner: 10Hoo man) [00:44:34] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/4d874b1 : jeroendedauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26621387 [00:51:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/5ee33ca : Hoo man The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26621943 [00:57:21] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/032f76d : Hoo man The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26622671 [01:04:37] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/b14b1fd : Hoo man The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26622693 [03:48:50] any !admin available? [03:51:14] Emw: yes but only briefly [08:24:48] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Woups. Sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136953 (owner: 10Hoo man) [08:25:03] (03Merged) 10jenkins-bot: Fix DiffViewTest for languages other than English [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136953 (owner: 10Hoo man) [08:33:22] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/eef1272 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26644218 [08:53:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "The design used in existing code displays the unprefixed Item ID in black, followed by the "deleted entity" message in gray brackets. Exam" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136946 (https://bugzilla.wikimedia.org/65002) (owner: 10Hoo man) [09:01:37] (03CR) 10Aude: [C: 04-1] "generally looks good but nitpicks" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [09:18:14] [13WikibaseDataModel] 15thiemowmde comment on pull request #107 14b7d4ba4: Silent conversion? Doesn't this need to check the type? 02http://git.io/x2G8pw [09:19:22] [13WikibaseDataModel] 15thiemowmde comment on pull request #107 14b7d4ba4: Not sure but I think the style guide says to put `} elseif ( ... ) {` in one line. 02http://git.io/AQMWfw [09:19:48] (03PS1) 10Adrian Lang: $.fn.andSelf has been renamed to $.fn.addBack [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136991 [09:26:07] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136991 (owner: 10Adrian Lang) [09:42:34] [13Time] 15thiemowmde comment on pull request #18 147eceae2: A constant is a constant is a constant. I will not use this abusive pattern. This is not PHP 3. 02http://git.io/le9wZA [09:45:02] (03PS4) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [09:46:31] [13Time] 15thiemowmde comment on pull request #18 147eceae2: I agree but as I explained the simple reason is to get around the validation that's done in the TimeValue constructor. I don't want to test this here. 02http://git.io/rp7jbQ [09:48:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [10:00:31] (03PS1) 10WikidataBuilder: New Wikidata Build - 03/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/136999 [10:09:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/136999 (owner: 10WikidataBuilder) [10:17:14] (03PS5) 10Adrian Lang: Factor out generation of site links HTML into own class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 [10:19:59] (03PS1) 10Thiemo Mättig (WMDE): Add missing doc stars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137000 [10:26:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [10:29:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137000 (owner: 10Thiemo Mättig (WMDE)) [10:56:01] (03CR) 10Adrian Lang: [C: 04-1] "Restore not yet adressed -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129122 (owner: 10Adrian Lang) [11:15:21] (03CR) 10Thiemo Mättig (WMDE): "No test? :-(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136917 (owner: 10Bene) [11:19:02] [13WikibaseDataModel] 15thiemowmde comment on pull request #105 143b5f52d: Shouldn't this be a constant? Like `Property::ENTITY_TYPE`? 02http://git.io/PcE_Ig [11:20:11] [13WikibaseDataModel] 15thiemowmde comment on pull request #105 143b5f52d: Check and error message don't match. 02http://git.io/uofjOg [11:21:06] [13WikibaseDataModel] 15thiemowmde comment on pull request #105 143b5f52d: I like it more if the additional `!( ... )` brackets are used. What's a bit strange here is that you are using them inconsistently in this file. 02http://git.io/vb2Atg [11:21:15] (03PS5) 10Bene: Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) [11:21:33] (03CR) 10jenkins-bot: [V: 04-1] Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [11:22:16] [13WikibaseDataModel] 15thiemowmde comment on pull request #105 143b5f52d: Just a note, not really meant as a edit request: I like it more if the properties are in the same order as in the constructor. 02http://git.io/Q2OR7A [11:24:56] [13WikibaseDataModel] 15thiemowmde comment on pull request #105 143b5f52d: The additional `is_object` check is superfluous. 02http://git.io/3k4Y2Q [11:27:52] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [11:27:54] (03PS6) 10Bene: Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) [11:34:11] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [11:45:22] [13WikibaseQuery] 15thiemowmde comment on pull request #20 140b34b5a: But you should not pass the whole `$GLOBALS` array in. This just feels wrong. There are a billion things in this array that aren't needed. Like all the `_COOKIE`, `_SERVER` and such arrays. 02http://git.io/uZbI1Q [11:48:37] [13WikibaseQuery] 15thiemowmde comment on pull request #20 140b34b5a: This is obviously not new, just a question: What is `DIC`? 02http://git.io/UdJd8Q [11:55:41] [13WikibaseQuery] 15thiemowmde comment on pull request #20 140b34b5a: Isn't passing the whole repo around odd? 02http://git.io/PujS-Q [12:02:25] [13WikibaseQuery] 15thiemowmde comment on pull request #20 140b34b5a: So this is the only global variable you need? Why passing all `$GLOBALS` around then? 02http://git.io/iKhOFQ [12:24:09] (03PS13) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) [12:24:27] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [12:25:49] (03PS17) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) [12:26:05] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [12:26:20] hi [12:28:36] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [12:31:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [13:19:54] (03PS14) 10Thiemo Mättig (WMDE): Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [13:20:11] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [13:24:24] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [14:11:34] [13WikibaseDatabase] 15thiemowmde 04deleted 06regex-matches at 146873830: 02http://git.io/s0vn3w [14:11:44] [13WikibaseDatabase] 15thiemowmde closed pull request #39: More flexible whitespace matching in SQL parser regular expressions (06master...06regex-whitespace) 02http://git.io/SIKSYw [14:13:02] (03PS2) 10Jeroen De Dauw: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 [14:13:04] (03CR) 10Jeroen De Dauw: Move special page code out of Lib (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [14:13:08] (03PS3) 10Jeroen De Dauw: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 [14:21:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [14:25:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [16:05:56] (03CR) 10Daniel Kinzler: Introducing EntityContentDataCodec (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [16:06:33] (03PS18) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) [16:06:36] aude: addressed all your comments here https://gerrit.wikimedia.org/r/#/c/136834/ [16:06:52] (03PS15) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) [16:07:53] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [16:08:07] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [16:10:53] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [16:15:09] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [17:00:05] DanielK_WMDE__: you are aware of this right? https://gerrit.wikimedia.org/r/#/c/135776/ [17:04:10] (03PS1) 10Jeroen De Dauw: Move Repo specific test to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137037 [17:04:13] [13WikibaseQuery] 15JeroenDeDauw comment on pull request #20 140b34b5a: Dependency Injection Container 02http://git.io/QiwpAw [17:04:40] (03CR) 10Jeroen De Dauw: "This also kills one of the lasts refs to WikibaseRepo from Lib" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [17:04:50] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137037 (owner: 10Jeroen De Dauw) [17:05:34] [13WikibaseQuery] 15JeroenDeDauw comment on pull request #20 140b34b5a: This is the top level factory of Repo, which is what is needed here. Unfortunately way to many things have been stuffed in there, though that is a design problem in Repo, not here. 02http://git.io/tam6Yg [17:07:13] [13WikibaseQuery] 15JeroenDeDauw comment on pull request #20 140b34b5a: Look at the context. And think about the implications of passing this single global var. 02http://git.io/57HtwA [17:08:46] (03PS1) 10Thiemo Mättig (WMDE): Add/fix more missing/broken inline documentations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137042 [17:13:37] (03CR) 10Jeroen De Dauw: [C: 032] Add/fix more missing/broken inline documentations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137042 (owner: 10Thiemo Mättig (WMDE)) [17:13:49] (03Merged) 10jenkins-bot: Add/fix more missing/broken inline documentations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137042 (owner: 10Thiemo Mättig (WMDE)) [17:15:22] gah, so quick [17:15:42] (03CR) 10Aude: "i'm not fast enough, but see comments anyway" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137042 (owner: 10Thiemo Mättig (WMDE)) [17:15:54] Thiemo_WMDE: ^ [17:15:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137042 (owner: 10Thiemo Mättig (WMDE)) [17:16:06] want to do another follow up? :) [17:16:30] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #105 143b5f52d: That creates a dependency from PropertyValueSnak on Property, and introduces a cycle into the dependency graph. This class depends on the notion there is a type of entity that can be identified as 'property', which is fine. Also note how using a constant does not help in refactoring at all, since we cannot simply change the string id, as it is part of the public API. 02ht [17:17:02] (03CR) 10Aude: [C: 04-1] "how is this repo-specific?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137037 (owner: 10Jeroen De Dauw) [17:18:00] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #105 143b5f52d: Yet this is the better error message. You should use a PropertyId, not an EntityId, as the later is highly deprecated. 02http://git.io/cVzZFg [17:19:17] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #105 143b5f52d: Hah, good spot. I just moved this stuff around, guess one place did not have the brackets to begin with. Feel free to change in a follow up if you really care. 02http://git.io/kGiyYA [17:19:36] hey folks - I'm currently working through some ideas and content for the new Guided Tours and have a question about a particular property... [17:20:03] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #105 143b5f52d: Indeed. I did not know that when I wrote this code, which as the tag tells you, was in 0.3 :) 02http://git.io/H3fZgw [17:20:03] does anyone have a minute to talk to me about the "position held" property (p39)? [17:20:22] Hey thepwnco :) [17:20:34] hello! [17:21:40] thepwnco: One of the interns Lydia_WMDE's told me about I assume :p (I recognise the name) [17:22:05] that would be me :) [17:22:24] Nice, so what do you want to talk about? [17:22:38] so I'm looking at p39...and I'm not quite clear on this but is it only intended to be applied to people items rather than both people and position items? [17:23:15] I believe that is the idea. [17:23:16] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #107 14b7d4ba4: I've never done that, so that'd be inconsistent with the rest of DataModel (which happens to not be a MediaWiki project to begin with). 02http://git.io/-lnzfw [17:23:39] so, for example, Angela Merkel (Q567) has position held = Federal Chancellor of Germany (linking to Q4970706) [17:23:41] That joining it starting to get annoying >.> [17:23:57] thepwnco: If that is the position held, yep. [17:24:24] but then Q4970706 doesn't have a "position held by" statement [17:24:54] or any mention of Angela [17:25:02] I don't think we have a 'position held by' property. Let me look quickly. [17:25:32] (03CR) 10Jeroen De Dauw: "> how is this repo-specific?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137037 (owner: 10Jeroen De Dauw) [17:26:06] aude: mergeeeeeeeeeeeeeeeeee https://gerrit.wikimedia.org/r/#/c/136834/ [17:26:44] (03PS1) 10Thiemo Mättig (WMDE): Fix mistake introduced in I45438f5d01402c633b0966ae4c5697fa18a84202 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137046 [17:26:50] I don't think so either... I can see why this makes sense for generic positions like 'chairperson' [17:27:10] (03CR) 10Thiemo Mättig (WMDE): Add/fix more missing/broken inline documentations (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137042 (owner: 10Thiemo Mättig (WMDE)) [17:27:35] * aude eats [17:27:43] chairperson is a lovely case where we have two different properties to represent it on two different items. [17:27:58] desparately hungry [17:29:08] yeah, I guess could get messy if "held by" was misused [17:30:13] (03CR) 10Aude: [C: 032] "alright, looks sane" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137037 (owner: 10Jeroen De Dauw) [17:30:19] but for an item like "President of United States" etc I expected to see "held by" there [17:30:26] (03Merged) 10jenkins-bot: Move Repo specific test to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137037 (owner: 10Jeroen De Dauw) [17:30:53] (03PS1) 10Jeroen De Dauw: Move HttpAccept classes out of lib/utils to the package where they are used [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137048 [17:32:09] thepwnco: If you want to go into that ground, the best place to discuss it would be property proposals. [17:33:23] ok, I wondered about that. Just seeing if there was mysterious reasons for this first :) [17:33:53] Probably the same reason 90% of things are missing 'Oh wait, I didn't realise that...' :p [17:34:36] Now the reason I came online, prodding reminders about Wikiquote :p [17:34:50] ha - well, I probably won't include that part in the tour... [17:34:54] thanks for you help! [17:35:12] Welcome [17:35:28] That's pretty much all I'm here for :p [17:37:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137046 (owner: 10Thiemo Mättig (WMDE)) [17:41:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137048 (owner: 10Jeroen De Dauw) [17:58:54] (03PS3) 10Daniel Kinzler: Re-submit "Remove StoreFactory and related logic" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [17:59:11] (03CR) 10jenkins-bot: [V: 04-1] Re-submit "Remove StoreFactory and related logic" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [18:06:13] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [18:10:34] (03PS19) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) [18:14:42] (03PS16) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) [18:16:23] (03PS1) 10Jeroen De Dauw: Make namespace usage more consistent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137066 [18:16:26] (03PS1) 10Jeroen De Dauw: Reduce visibility scope [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137067 [18:18:37] aude: ping [18:19:41] aude: nvm [18:20:54] (03PS4) 10Daniel Kinzler: Re-submit "Remove StoreFactory and related logic" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [18:22:18] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [18:29:25] (03PS1) 10Jeroen De Dauw: Reduce visibility scope [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137072 [18:31:08] (03PS1) 10Jeroen De Dauw: Remove TODO [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137074 [18:32:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [18:32:58] (03PS1) 10Jeroen De Dauw: Cleanup in Chunck* classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137075 [18:42:21] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137066 (owner: 10Jeroen De Dauw) [18:49:22] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137067 (owner: 10Jeroen De Dauw) [18:55:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [18:59:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137072 (owner: 10Jeroen De Dauw) [19:03:04] Thiemo_WMDE: indeed, some deprecations make sense in this rel [19:04:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137074 (owner: 10Jeroen De Dauw) [19:08:34] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137075 (owner: 10Jeroen De Dauw) [19:12:37] (03CR) 10Hoo man: [C: 032] Cleanup in Chunck* classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137075 (owner: 10Jeroen De Dauw) [19:14:53] (03CR) 10Hoo man: [C: 032] Move HttpAccept classes out of lib/utils to the package where they are used [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137048 (owner: 10Jeroen De Dauw) [19:17:14] (03CR) 10Hoo man: [C: 032] Make namespace usage more consistent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137066 (owner: 10Jeroen De Dauw) [19:18:50] (03CR) 10Hoo man: [C: 032] Reduce visibility scope [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137067 (owner: 10Jeroen De Dauw) [19:19:04] [13WikibaseDataModel] 15JeroenDeDauw created 060.7.5-dev (+1 new commit): 02http://git.io/dtNJGA [19:19:04] 13WikibaseDataModel/060.7.5-dev 149355bbe 15jeroendedauw: Move over some of the new 1.0 features we can already use [19:19:21] thepwnco: https://github.com/wmde/WikibaseDataModel/commit/9355bbeb0fc0886958062392304a994f833ae4ce [19:19:27] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModel/commit/9355bbeb0fc0886958062392304a994f833ae4ce [19:19:53] (03CR) 10Hoo man: [C: 032] Remove TODO [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137074 (owner: 10Jeroen De Dauw) [19:21:48] (03CR) 10Hoo man: [C: 032] "We should really move this stuff into core or WikimediaMaintenance" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137072 (owner: 10Jeroen De Dauw) [19:22:30] (03CR) 10Hoo man: [C: 032] "Style-only change" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137046 (owner: 10Thiemo Mättig (WMDE)) [19:22:56] hoo: are you on the wikimedia-de-tech list? [19:23:07] JeroenDeDauw: Yus [19:23:19] hoo: well, then I already raged there about your last comment ;p [19:23:42] I wanted to do that at one point, but then something came in between and I forgot [19:24:03] hoo: where did you intend to put it? [19:24:12] Thiemo_WMDE: yay, nay? [19:24:49] JeroenDeDauw: I would have to see whether the sitematrix stuff is an extension or not... if it is, then WikimediaMaint. (if aude agress) if not, then core [19:25:28] hoo: there is a WikimediaMaint extension with all of the maintenance scripts? [19:26:33] hoo: can you provide me with a yay or nay on https://github.com/wmde/WikibaseDataModel/commit/9355bbeb0fc0886958062392304a994f833ae4ce ? [19:26:56] jeremyb_: https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance [19:26:58] * JeroenDeDauw [19:27:01] That commit pulls a bunch of new stuff from 1.0 onto the 0.7.4 tag so we can do a 0.7.5 rel with some new stuff and can already use that [19:27:09] So no new code really [19:27:29] ok... will have a look [19:27:36] hoo: yeah, guess it fits in there [19:29:05] [13WikibaseDataModel] 15thiemowmde comment on commit 149355bbe: Isn't this a breaking change that requires a +1 increase on the version number? 02http://git.io/7COvxg [19:29:54] [travis-ci] wmde/WikibaseDataModel/0.7.5-dev/9355bbe : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/26696224 [19:30:02] [13WikibaseDataModel] 15thiemowmde comment on commit 149355bbe: Same here. At least make it `return true`. 02http://git.io/6mtB4g [19:32:03] JeroenDeDauw: Those changes are ok with me... makes sense as an intermediate step before we do the big move to 1.0 [19:32:27] hoo: k, thnx for having a look [19:32:36] Let me double check wb works fine with this [19:32:56] [13WikibaseDataModel] 15thiemowmde comment on commit 149355bbe: See #109. 02http://git.io/quyaBA [19:33:43] Thiemo_WMDE: yes, indeed, breaking change [19:33:49] Strictly speaking that requires a bigger increment [19:34:00] Though we never actually used this [19:34:11] So in this case I'm just going to ignore it [19:34:28] Yeah, that's more of 0.8, than a 0.7 [19:34:31] .minor [19:34:43] but there aren't any real breaking changes [19:34:59] It is more hassle for us to make it 0.8 [19:35:35] [13WikibaseDataModel] 15thiemowmde comment on commit 149355bbe: I think it's a good idea to tag a 0.7.5 with the non-breaking additions only. See above for one or two tiny details that may be breaking changes. 02http://git.io/94smKA [19:35:40] Don't know... never did a release myself before [19:36:13] Although I guess I should really know how to do that in case we run into deployment problems which force a release to happen urgently [19:38:55] I just don't like the (again, never used before) new naming scheme add+addObject. [19:39:51] I would like to fix this in 1.0 before backporting to a 0.7.x. [19:40:16] Thiemo_WMDE: Are you ok enough with the EntityContentDataCodec for me to merge it? (I'm looking at it atm) [19:40:53] hoo: make it a +1 and let me have a last look. [19:40:56] Thiemo_WMDE: well, suggest a better name then [19:41:38] JeroenDeDauw: See https://github.com/wmde/WikibaseDataModel/issues/109 [19:42:45] Thiemo_WMDE: please submit a PR against master that fixes it then? [19:46:28] It's the same discussion again. And again to late for me (10pm) to have it. [19:51:34] [13WikibaseDataModel] 15thiemowmde comment on pull request #108 14fcffaec: Since I didn't had a chance to review this see #109. 02http://git.io/vpZaTw [19:56:54] [13WikibaseDataModel] 15thiemowmde comment on pull request #108 14fcffaec: It doesn't hurt to have this here but I still find it extremely odd. This really is the first time we are introducing this pattern. It doesn't help making the code better readable if _no_ other code uses this pattern. I will most probably -1 changes that try to use this. 02http://git.io/VaMXlQ [19:58:32] (03PS1) 10Jeroen De Dauw: Do not needlesly use copy in SiteLinkCommentCreatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137148 [20:02:22] Apparently 0.7.5 is breakig 5 tests... [20:02:25] Wonder which ones [20:03:01] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137140 (owner: 10L10n-bot) [20:07:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137148 (owner: 10Jeroen De Dauw) [20:14:51] (03CR) 10Hoo man: [C: 031] Introducing EntityContentDataCodec (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [20:15:39] (03PS1) 10Jeroen De Dauw: Fix violation of method contract in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137154 [20:17:09] (03CR) 10Hoo man: [C: 032] Do not needlesly use copy in SiteLinkCommentCreatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137148 (owner: 10Jeroen De Dauw) [20:21:42] Lydia_WMDE: piding :) [20:21:50] benestar: meeep [20:22:00] Lydia_WMDE: I need some nice icons for the badges ui [20:22:16] I think of a blue star with 5 edges [20:22:26] one filled and one only with the border [20:22:30] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137154 (owner: 10Jeroen De Dauw) [20:22:46] who is the designer in your team who created the other icons for Wikibase? [20:22:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think I found at least one unused line that would be confusing when merged." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [20:23:16] that'd be henning who is on vacation currently. but i'll send an email to the foundation's designers and CC you? [20:23:47] he's pretty responsive usually [20:24:03] ok, thanks [20:24:06] np [20:24:16] Lydia_WMDE: I think https://commons.wikimedia.org/wiki/File:Five_Pointed_Star_Solid.svg does not look that well actually ^^ [20:24:26] ewww [20:24:27] no [20:24:31] too sharp [20:25:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix violation of method contract in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137154 (owner: 10Jeroen De Dauw) [20:28:50] (03Merged) 10jenkins-bot: Fix violation of method contract in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137154 (owner: 10Jeroen De Dauw) [20:29:08] benestar|afk: done [20:29:16] (03PS1) 10Jeroen De Dauw: Create deep clones [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137159 [20:29:58] [13WikibaseDataModel] 15JeroenDeDauw created 060.8.x (+1 new commit): 02http://git.io/p0imKQ [20:29:58] 13WikibaseDataModel/060.8.x 14029333a 15jeroendedauw: Move over some of the new 1.0 features we can already use [20:30:23] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 060.7.5-dev at 149355bbe: 02http://git.io/PEWTAQ [20:32:02] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I already reviewed and merged the original submission. I can't tell if the change (see my comment) fixes the problem. Hoo?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [20:36:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137159 (owner: 10Jeroen De Dauw) [20:40:42] (03CR) 10Hoo man: [C: 032] Create deep clones [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137159 (owner: 10Jeroen De Dauw) [20:40:59] (03PS4) 10Jeroen De Dauw: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 [20:41:09] (03CR) 10Jeroen De Dauw: Move special page code out of Lib (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [20:41:24] (03CR) 10jenkins-bot: [V: 04-1] Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [20:42:51] (03PS5) 10Jeroen De Dauw: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 [20:43:46] Thiemo_WMDE: hoo: decided to go with 0.8 [20:44:01] https://github.com/wmde/WikibaseDataModel/compare/0.8.x [20:44:05] :) [20:44:06] Has another breaking change [20:44:18] 0.0.1 = bugfix, 0.1 = new feature, 1.0 = breaking change. right? [20:44:34] Thiemo_WMDE: no [20:44:40] Thiemo_WMDE: only as of 1.0 [20:44:44] Does not apply to 0.x [20:44:58] Else we'd not have been able to have any breaking change since the first rel :) [20:45:10] (03CR) 10Hoo man: [C: 04-1] Re-submit "Remove StoreFactory and related logic" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135776 (owner: 10Jeroen De Dauw) [20:45:40] * JeroenDeDauw prepares to rage to hoo and then realizes its not actually his commit [20:46:06] heh :D [20:48:34] Thiemo_WMDE: you going to submit the name change today? [20:49:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [20:52:27] (03CR) 10Hoo man: [C: 032] "Doesn't matter in netbeans, btw ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137000 (owner: 10Thiemo Mättig (WMDE)) [20:52:52] what https://twitter.com/JeroenDeDauw/statuses/473930164624044032 [20:54:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [20:54:11] (03CR) 10Hoo man: [C: 032] "No-op as andSelf is an alias to addBack" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136991 (owner: 10Adrian Lang) [20:54:46] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I still don't understand why the default format is not a setting any more. Having it where it is now just doesn't make sense to me: The ca" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [21:00:33] (03CR) 10Hoo man: "I guess the removal of the preference was to reduce complexity and to get rid of settings from lib (as we decided to no longer have settin" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (https://bugzilla.wikimedia.org/66024) (owner: 10Daniel Kinzler) [21:15:36] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Mainly lots of new tests. I assume the many empty "new Diff()" where a redirect diff is expected are prerequisites for later patches. Two " (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (https://bugzilla.wikimedia.org/66026) (owner: 10Daniel Kinzler) [21:18:40] (03CR) 10Hoo man: [C: 04-1] "Nice start... JS changes missing (eg. wikibase.ui.SiteLinksEditTool.js needs to be changed)" (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [21:22:13] (03Abandoned) 10Hoo man: DNM DNM Jenkins Test Commit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/129163 (owner: 10Addshore) [21:23:12] (03CR) 10Hoo man: "If no one objects, I'll merge this in a couple of days." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120201 (https://bugzilla.wikimedia.org/57663) (owner: 10Thiemo Mättig (WMDE)) [21:26:00] hoo: about https://gerrit.wikimedia.org/r/#/c/120201/ ... we will have a redesign anyway. feel free to merge it now. [21:26:16] henning was supposed to look at this but never said anything. he had his chance. [21:26:22] (03CR) 10Hoo man: [C: 032] Slightly enlarge Snak type (custom/unknown/no value) icons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/120201 (https://bugzilla.wikimedia.org/57663) (owner: 10Thiemo Mättig (WMDE)) [21:26:35] Thiemo_WMDE: Ok. I've per hand tested that change back then [21:26:43] :) [21:33:03] [13WikibaseDataModel] 15thiemowmde comment on pull request #107 14b7d4ba4: The interface is not deprecated. Both Item and Property should have this method, right? It's abstract now and can't be called anyway. 02http://git.io/AQFCEg [21:35:33] [13WikibaseDataModel] 15thiemowmde comment on pull request #107 14b7d4ba4: Why not simply reusing it if it's already a PropertyId? Does this make sense?... 02http://git.io/Q0R3ug [21:36:43] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #107 14b7d4ba4: Because... 02http://git.io/_92hWw [21:39:55] Lydia_WMDE: answered him, you're in CC [21:40:10] I hope you agree with my more detailed explanation ;) [21:46:54] hoo: we have spaces in en.json but tags in qqq.json? :OOO [21:46:59] *tabs [21:47:05] Yeah, I know [21:47:14] what is preferred? [21:47:20] we probably should change the qqq to spaces [21:47:23] or does that actually make sense? [21:47:27] I think people decided on spaces [21:47:41] only for json or also for PHP? [21:47:53] json, ofc. [21:49:00] mh... core also uses tabs now [21:49:05] maybe we should switch to [21:56:56] (03PS1) 10Hoo man: Change remaining i18n json files to tabs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137205 [21:59:50] (03CR) 10Krinkle: "Doesn't the next translatewiki update do this automatically?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137205 (owner: 10Hoo man) [21:59:52] (03PS7) 10Bene: DNM Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) [22:01:33] (03CR) 10Hoo man: "No, the bot doesn't dare to touch the en.json files as it seems" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137205 (owner: 10Hoo man) [22:06:53] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/137205 (owner: 10Hoo man) [22:11:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [23:16:03] (03CR) 10Danielrenfro: "Looks good to me!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136917 (owner: 10Bene)