[00:09:33] [13WikibaseDataModel] 15JeroenDeDauw created 06refequals (+1 new commit): 02http://git.io/hqvUTQ [00:09:33] 13WikibaseDataModel/06refequals 148a74d15 15jeroendedauw: Add tests for Reference::equals and fix found bug [00:11:11] [travis-ci] wmde/WikibaseDataModel/refequals/8a74d15 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/26538267 [00:14:37] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/KBXY8A [00:14:37] 13WikibaseDataModel/06master 14b9238cc 15jeroendedauw: Add missing @covers tag [00:16:45] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #104: Add tests for Reference::equals and fix found bug (06master...06refequals) 02http://git.io/9JmyoA [00:17:36] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/srTTkg [00:17:36] 13WikibaseDataModel/06master 14a4d5808 15jeroendedauw: Fix @covers tag [00:27:54] [13WikibaseDataModel] 15JeroenDeDauw created 06snak (+1 new commit): 02http://git.io/TjArNw [00:27:54] 13WikibaseDataModel/06snak 143b5f52d 15jeroendedauw: Decrease inheritance and overloading for PropertyValueSnak [00:28:55] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #105: Decrease inheritance and overloading for PropertyValueSnak (06master...06snak) 02http://git.io/q3ghtQ [00:29:10] [travis-ci] wmde/WikibaseDataModel/snak/3b5f52d : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/26538856 [03:44:32] Quick question! How many external links has the wikipedia (sum all languages), does someone know? [07:11:32] tito__: https://stats.wikimedia.org/ does [07:14:38] though en.wiki numbers are being calculated https://stats.wikimedia.org/EN/TablesDatabaseExternalLinks.htm [07:15:36] Nemo_bis: Awesome stats page, thank you :) Now let me check.. if we can found the count.. [07:16:31] the server which was updating that page for the first time in years was unplugged (literally) just 2 days before it completed the job [07:18:41] MariaDB [enwiki_p]> select count(*) from externallinks; -> 68127592 [07:18:47] Ahh RIP [07:19:11] now sum the other columns to 68 M and you're done :) [07:19:30] Wow, but that includes only the external link section, or all the links with references too? [07:20:06] all links in a page [07:21:30] An impressive number, many thanks for it :) [07:23:26] I'm still interested to know if its possible to get the "External links" count only, but well if it is difficult just forget it. [07:23:35] Oh god, RfD is getting broken. [07:24:01] "Pages where template include size is exceeded" [07:24:02] :( [07:24:34] tito__: that's definitely not possible easily; but of course you can download XML dumps, remove all the stuff between with pywikibot and then run wikistats over the XML ;) [07:25:06] or amend wikistats to do this directly [07:27:51] Thanks for the information :), I'll try to play with these XML/RDFs is really interesting [07:28:24] or make a dry run of replace.py with dummy edits to all links except those between ref and count, hmm [08:05:22] Jianhui67: Where is your request for administrator? :O [08:05:36] not yet [08:05:50] :( [08:56:12] (03PS1) 10Daniel Kinzler: Remove second/strict check for edit conflicts. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 [08:59:05] (03PS2) 10Daniel Kinzler: Remove second/strict check for edit conflicts. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 [08:59:22] (03PS3) 10Daniel Kinzler: Remove second/strict check for edit conflicts. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 [09:00:20] aude: ---^ [09:01:11] (03CR) 10Daniel Kinzler: "Relevant discussion on Wikitech-l: http://www.gossamer-threads.com/lists/wiki/wikitech/466189" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [09:07:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [09:13:39] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [09:18:10] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [09:18:30] (03PS4) 10Daniel Kinzler: Remove second/strict check for edit conflicts. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 [09:25:31] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [09:30:11] hi ! I have to import a lot of entities into my wikibase, and was wondering of what was the best approach [09:30:34] I tried naively using the web API, but it's terribly slow (around 10 entities/minute, and the entities are very simple) [09:32:47] hey guys. I created a Jenkins job that runs 'composer validate' whenever a composer.json file is proposed. That is trivial but you might want to have the job triggered on your repositories. wikitech-l mail is http://permalink.gmane.org/gmane.science.linguistics.wikipedia.technical/77632 [09:33:57] olivd: sadly. we don't have a good solution for imports at the moment. The problem is that items can't even meaningfully be imported, since IDs of referenced items and properties may be completely different on the target system [09:34:22] that may lead to id conflicts or a complete mess of plain wrong item references [09:35:22] olivd: since there is currently no way to safely/meaningfully import into wikibase, we have for now disabled XML dump based imports. so the best you can do for now is using the API (wbeditentity). [09:36:04] DanielK_WMDE_: ok [09:36:49] DanielK_WMDE_: but you say import/export in xml/rdf is on the roadmap ? [09:37:28] export, yes. import... if you can tell us how to handle id conflicts?... [09:38:11] olivd: i currently see no good way to do it. except perhaps into an empty wiki. [09:38:29] items are just not portable between wikibase data sets. they are tighly bound to the entity ids defined in the system. [09:38:45] @whom it concerns: Just noted that in the internal JSON the datatype "commonsMedia" is in camel case while all others are dash-seperated ("globe-coordinate", "wikibase-item"…). This is confusing. [09:39:07] diferrumtrioxide: Yes, that's how it is and we probably can't do much about it [09:39:10] diferrumtrioxide: yes, it's confusing and sucks. if we change it now, it will break a million things... [09:39:36] Adrian_WMDE: you are so nice about it :P [09:40:08] Maybe another reason to switch to external JSON for the dumpfiles. [09:44:45] DanielK_WMDE_: ddddddaily? :D [09:45:01] thiemo is starting the hangout [09:45:06] diferrumtrioxide: we are very close to that now. but that won't help with your issue. [09:45:12] Lydia_WMDE: coming [09:46:35] DanielK_WDME: it is in external Json that way too? [10:00:28] (03PS1) 10WikidataBuilder: New Wikidata Build - 02/06/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/136736 [10:09:09] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/136736 (owner: 10WikidataBuilder) [10:12:10] diferrumtrioxide: yes. the ids are no different. they are not decided by the serialization code but part of the model. [10:18:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix testNewFromContextForPageView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136516 (owner: 10Jeroen De Dauw) [10:19:05] (03Merged) 10jenkins-bot: Fix testNewFromContextForPageView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136516 (owner: 10Jeroen De Dauw) [10:22:12] DanielK_WMDE_: would it be feasable to introduce an alias "commons-media" and agree to use that in the future, slowly making the camel-case version obsolete and safe to remove? [10:22:56] diferrumtrioxide: if would be possible I think... the deserializer could convert it on the fly. make a feature request :) [10:24:19] DanielK_WMDE_:will do :) [10:43:26] (03CR) 10Daniel Kinzler: [C: 04-1] Provides a default to otherProjectsLinks configuration parameter (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [11:15:15] hey [11:32:23] (03CR) 10Daniel Kinzler: Introducing EntityContentDataCodec (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [11:32:57] (03PS14) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [11:33:11] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [11:33:36] (03PS9) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 [11:33:50] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [11:39:54] DanielK_WMDE_: yes there's an id problem, but there are two cases when you can manage it [11:40:01] - when it's an update (you exported the data from wikibase, process it somewhere, and want to reimport it) [11:40:42] - when you import unlinked data [11:40:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [11:45:37] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [11:57:20] (03CR) 10Daniel Kinzler: Introducing EntityContentDiff (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [12:01:49] (03PS10) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 [12:02:04] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [12:03:38] (03PS15) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [12:03:51] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [12:03:55] (03PS11) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 [12:04:09] (03CR) 10jenkins-bot: [V: 04-1] Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [12:11:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [12:15:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "As said: this should be implemented in core." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [12:16:06] (03Merged) 10jenkins-bot: Remove second/strict check for edit conflicts. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136724 (owner: 10Daniel Kinzler) [12:17:29] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [12:21:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [12:30:11] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Provides a default to otherProjectsLinks configuration parameter (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [12:31:18] (03PS16) 10Daniel Kinzler: Introducing EntityContentDataCodec [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 [12:32:12] (03PS12) 10Daniel Kinzler: Introducing EntityContentDiff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 [12:37:17] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [12:38:39] Lydia_WMDE: y u suggest I should code that? :p [12:39:28] lazowik: hehe added you to CC since you were asking for things to do and this seemed like a possible one. if you don't want to do it or can't that's perfectly fine [12:40:03] nah, ok [12:40:23] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135044 (owner: 10Daniel Kinzler) [12:40:24] I'm still on the first one [12:40:26] so this was more a "hey have a look" than "do this" :P [12:40:30] ok [12:41:00] but for that I need to read clean code [12:41:27] to become as good as JeroenDeDauw [12:41:31] :p [12:42:07] Lydia_WMDE: this merge thing seems easier though [12:42:27] I'm on a smartphone now, this could be a challange [12:50:09] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "A few tiny things, a few questions and suggestions. My -1 is not meant to block this, just to get your attention. ;-) I may be wrong or a " (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [12:51:09] :D [12:52:49] about exporting : is dumpJson.php the only way to go ? not possible through the API yet ? [12:57:22] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add type hint and use current class name in DiffChange (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136515 (owner: 10Jeroen De Dauw) [12:57:44] (03Merged) 10jenkins-bot: Add type hint and use current class name in DiffChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136515 (owner: 10Jeroen De Dauw) [13:01:34] Lydia_WMDE: nah, not doing that now :p [13:01:50] bye! [13:03:15] ;-) [13:03:15] cya [13:18:09] (03PS2) 10Thiemo Mättig (WMDE): Make EditEntityTest run hook code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135425 [13:19:13] (03CR) 10Thiemo Mättig (WMDE): Make EditEntityTest run hook code (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135425 (owner: 10Thiemo Mättig (WMDE)) [13:24:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135425 (owner: 10Thiemo Mättig (WMDE)) [13:32:06] Lydia_WMDE: see the blockers of https://bugzilla.wikimedia.org/show_bug.cgi?id=57744 [13:33:51] Lydia_WMDE (no Tobi today?): 66024 and 66026 are in review, 66028 is "doing". 66029 and 66030 are for the next sprint. [13:33:53] (03PS3) 10Thiemo Mättig (WMDE): Add test to EditEntityTest for the fix in Gerrit 135489 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 [13:33:57] 57744 remains on "doing". [13:34:03] DanielK_WMDE_: in call [13:35:06] this was just fyi [13:37:36] thx :) [13:38:13] tobi is back tomorrow [13:40:01] (03CR) 10Thiemo Mättig (WMDE): "If you -1 because you think it can be improved you should tell how you think it can be improved." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 (owner: 10Thiemo Mättig (WMDE)) [13:41:03] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 (owner: 10Thiemo Mättig (WMDE)) [13:41:11] woei! [13:53:14] (03CR) 10Adrian Lang: Cucumber tests for Special:SetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/121393 (https://bugzilla.wikimedia.org/53846) (owner: 10Aude) [14:12:23] (03PS2) 10Thiemo Mättig (WMDE): Add test for static RepoHooks::onMakeGlobalVariablesScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 [14:12:42] (03CR) 10jenkins-bot: [V: 04-1] Add test for static RepoHooks::onMakeGlobalVariablesScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [14:15:06] (03PS3) 10Thiemo Mättig (WMDE): Add test for static RepoHooks::onMakeGlobalVariablesScript [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 [14:16:19] (03CR) 10Thiemo Mättig (WMDE): "Whatever DerivativeContext is, I used it now. Thanks, Aude." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [14:20:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [14:24:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [14:26:36] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Switching to protected is a very good idea." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135802 (owner: 10Jeroen De Dauw) [14:29:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Add missing references for type hints [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136030 (owner: 10Jeroen De Dauw) [14:29:25] (03Merged) 10jenkins-bot: Add missing references for type hints [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136030 (owner: 10Jeroen De Dauw) [14:31:02] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 031] Remove unused vars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136033 (owner: 10Jeroen De Dauw) [14:31:16] (03Merged) 10jenkins-bot: Remove unused vars [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136033 (owner: 10Jeroen De Dauw) [14:36:48] DanielK_WMDE_: thanks @ bugs :) [14:55:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Tests still succeed, so what could go wrong?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136498 (owner: 10Jeroen De Dauw) [14:55:49] (03Merged) 10jenkins-bot: Remove highly deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136498 (owner: 10Jeroen De Dauw) [15:11:57] (03CR) 10Tpt: "Answers to some comments" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132606 (owner: 10Tpt) [15:13:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Looks perfectly fine." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136499 (owner: 10Jeroen De Dauw) [15:17:06] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks good to me. +1 to give Daniel and Aude time to have a quick look, if they want." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136506 (owner: 10Jeroen De Dauw) [15:27:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Wow, the old code was actually broken. It may return null but there was no null check. Now the proper EntityIdParsingException is thrown." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136511 (owner: 10Jeroen De Dauw) [15:28:05] (03Merged) 10jenkins-bot: Pull down deprecated implementation in getEntityId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136511 (owner: 10Jeroen De Dauw) [15:30:05] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Replace not needed usage of deprecated method in newFromSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136512 (owner: 10Jeroen De Dauw) [15:30:41] (03Merged) 10jenkins-bot: Replace not needed usage of deprecated method in newFromSerialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136512 (owner: 10Jeroen De Dauw) [15:33:55] (03PS2) 10Tpt: Provides a default to otherProjectsLinks configuration parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 [15:34:10] (03CR) 10jenkins-bot: [V: 04-1] Provides a default to otherProjectsLinks configuration parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [15:40:21] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [15:41:07] (03PS3) 10Tpt: Provides a default to otherProjectsLinks configuration parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 [15:42:15] (03CR) 10Tpt: "PS2: Do change requested during code review" (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [15:47:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [15:47:26] How come that there are so many spiecies that needs to be merged? [15:50:21] Josve05a because bots have run and they did not ensure linking the new articles in Wikidata [15:52:38] Like 50% of all 1.000.000 spiecies on svwp have 2 items...one with the svwp-link and one with an enwp-link... [16:04:25] I need help with two genus' if they are the same. Anyone that can help? https://en.wikipedia.org/wiki/Pseudopallene & https://sv.wikipedia.org/wiki/Pseudopallene (They have the same name, family and taxon author&year, but they have different spiecies in svwp vs enwp. [16:22:47] GerardM-: Saw the new Wikidata-game? [16:24:56] Josve05a when you are talking about species in a genus ... that can wildly vary [16:25:16] author and publication is what counts [16:25:42] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06refequals from 148a74d15 to 14627e9c3: 02http://git.io/E1S5Ww [16:25:42] 13WikibaseDataModel/06refequals 14627e9c3 15jeroendedauw: Add tests for Reference::equals and fix found bug [16:31:12] (03CR) 10Hoo man: [C: 04-1] "You could check the html output you get against a parsed version of the error message you expect. Right now this does test that html is no" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 (owner: 10Thiemo Mättig (WMDE)) [16:37:05] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Ok, got me convinced that the name EntityContentDataCodec does fit." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [16:45:48] thanks GerardM- (I was AFK) [16:46:46] sjoerd nee ik weet het nu [16:47:12] GerardM-: En. Goede ontwikkeling? [16:57:00] (03CR) 10Thiemo Mättig (WMDE): "> the point was to have wikitext parsed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 (owner: 10Thiemo Mättig (WMDE)) [16:58:33] (03CR) 10Hoo man: [C: 032] "You could have checked against the parsed error message you're expecting... but whatever" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 (owner: 10Thiemo Mättig (WMDE)) [16:58:53] (03Merged) 10jenkins-bot: Add test to EditEntityTest for the fix in Gerrit 135489 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135752 (owner: 10Thiemo Mättig (WMDE)) [17:00:34] If a person has an uncle, should P1038 (relative) be used, or is there some property for uncle? [17:01:33] sjoerd ja het is leuk [17:02:01] Josve05a the best way is have him a son of the grandfathre [17:03:01] What if the grandfather isn't notable to have a wikidata-item? [17:04:16] Never mind, it is covered under #3 on Wikidata:Notability...but if I don't know the grandfathers name? [17:04:22] GerardM-, ping. [17:05:21] When you know him, you can add him anyway ... because of the son a father can be "notable" [17:06:20] But I don't know him/his name...should I just create an empty item, with just a statement "child"? [17:06:57] Thiemo_WMDE: I can haz review for 98 and 104? https://github.com/wmde/WikibaseDataModel/pulls [17:13:10] [13WikibaseDataModel] 15JeroenDeDauw created 06hint (+1 new commit): 02http://git.io/n86dOg [17:13:10] 13WikibaseDataModel/06hint 14c1ea7c5 15jeroendedauw: Add type hints to Fingerprint... [17:18:25] [travis-ci] wmde/WikibaseDataModel/hint/c1ea7c5 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/26594571 [17:21:51] Thiemo_WMDE: how about you get a BTC wallet and pay me with BTC like a 1337 person? [17:21:53] https://www.bitstamp.net/ [17:22:13] Do you accept PayPal? [17:22:18] wow [17:22:31] Thiemo_WMDE is now classified as evil corporate faggot [17:22:33] :) [17:23:01] Thiemo_WMDE: Jens paid me for a pizza with BTC in 2012 [17:23:10] Thiemo_WMDE: guess how much this is worth now :D [17:28:50] (03PS1) 10Jeroen De Dauw: Update namespace refs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136772 [17:29:25] (03PS1) 10Jeroen De Dauw: Improve type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136773 [17:31:02] (03PS1) 10Jeroen De Dauw: Update class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136774 [17:32:05] (03PS1) 10Jeroen De Dauw: Update refs to Diff classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136775 [17:33:26] (03PS1) 10Jeroen De Dauw: Fix type hint and simplify method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136776 [17:35:40] (03PS1) 10Jeroen De Dauw: Update imports in SiteLinkCommentCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136778 [17:37:24] (03PS1) 10Jeroen De Dauw: Update SimpleSiteLink -> SiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136779 [17:37:46] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136772 (owner: 10Jeroen De Dauw) [17:38:58] (03PS1) 10Jeroen De Dauw: Remove not needed singleton call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136781 [17:44:28] (03PS1) 10Jeroen De Dauw: Remove silly test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136785 [17:46:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136773 (owner: 10Jeroen De Dauw) [17:47:34] (03PS1) 10Jeroen De Dauw: Remove unused code that can now be implemented better [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136787 [17:50:44] (03CR) 10Jeroen De Dauw: "Also see my email "Planned changes to the Entity hierarchy" that I just send to wikidata-tech. This change does not get rid of the describ" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [17:53:49] (03CR) 10Hoo man: [C: 032 V: 032] Remove unused code that can now be implemented better [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136787 (owner: 10Jeroen De Dauw) [17:54:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136774 (owner: 10Jeroen De Dauw) [17:55:20] (03CR) 10Jeroen De Dauw: [C: 04-1] Provides a default to otherProjectsLinks configuration parameter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/132613 (owner: 10Tpt) [17:55:57] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/132613/3/client/WikibaseClient.hooks.php [18:00:01] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136775 (owner: 10Jeroen De Dauw) [18:00:39] aude: please have a look at what I wrote here: https://gerrit.wikimedia.org/r/#/c/132613/3 [18:01:00] aude: you attempted to avoid the issue when writing this code though did not fully succeed [18:01:19] Also a good example of how this stuff tends to rot if you do not properly break out of the static context [18:03:42] I can't get https://www.wikidata.org/wiki/Wikidata:Tools/User_scripts#Import_statements to work. Any thoughts... [18:05:17] hey... i am interested in languages covered by wikidata. afaik, if it's about mediawiki languages, then it's what's supported by translatewiki? [18:06:42] yes and then it is what the language committee considers eligible [18:06:45] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136776 (owner: 10Jeroen De Dauw) [18:07:33] so, there is a set of languages which langcom made eligible out of wikipedias? [18:08:08] is there the list of those languages? [18:11:26] there is [18:12:56] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136778 (owner: 10Jeroen De Dauw) [18:16:42] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136779 (owner: 10Jeroen De Dauw) [18:17:42] thepwnco: hey, I have time now :) [18:19:48] JeroenDeDauw: wtf? [18:20:05] [13WikibaseDataModel] 15JeroenDeDauw created 06setid (+1 new commit): 02http://git.io/EPjKdw [18:20:05] 13WikibaseDataModel/06setid 14b7d4ba4 15jeroendedauw: Improve Entity::setId... [18:20:12] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136781 (owner: 10Jeroen De Dauw) [18:20:39] aude: wtf wtf? [18:20:47] You originally wrote that no? [18:21:13] no [18:21:34] i agree with your comment however :) [18:22:14] aude: oh indeed, was also written by tpt, my bad [18:22:46] you also tend to say to provide specific setting though [18:22:49] for the builder [18:23:03] i don't agree with that [18:23:13] prefer to provide Skin or whatnot [18:23:23] and do as much in tested code [18:23:43] benestar: hi there! Unfortunately I don't think Lydia_WMDE is around right now [18:24:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136785 (owner: 10Jeroen De Dauw) [18:24:15] thepwnco: hmm, that's weird because I have no time tomorrow and on Wednesday :/ [18:24:16] [travis-ci] wmde/WikibaseDataModel/setid/b7d4ba4 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/26599665 [18:25:30] benestar: hmm! Let me see if I can reach her. If she's not available, perhaps we can have a quick chat ourselves [18:25:42] ok :) [18:26:46] (03PS2) 10Thiemo Mättig (WMDE): Clean up ChangeOps related validation code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130083 [18:29:47] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136787 (owner: 10Jeroen De Dauw) [18:30:59] aude: err?? Not sure what you are saying. Of course one should only foreward the needed arguments. I did not look at the code closely enough to know which ones that are though [18:33:57] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130083 (owner: 10Thiemo Mättig (WMDE)) [18:34:34] JeroenDeDauw: needed arguments, as in the ones provided in the hook? [18:34:38] that's waht i would do [18:35:18] was told otherwise int he past [18:35:49] anyway, sure tpt can accommodate the suggestions [18:44:03] (03CR) 10Hoo man: [C: 032] Update SimpleSiteLink -> SiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136779 (owner: 10Jeroen De Dauw) [18:57:44] (03CR) 10Jeroen De Dauw: [C: 032] Clean up ChangeOps related validation code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/130083 (owner: 10Thiemo Mättig (WMDE)) [19:05:14] (03CR) 10Aude: [C: 04-1] "nitpick" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136776 (owner: 10Jeroen De Dauw) [19:06:07] (03CR) 10Aude: [C: 032] Remove not needed singleton call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136781 (owner: 10Jeroen De Dauw) [19:06:34] (03CR) 10Aude: [C: 032] Remove silly test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136785 (owner: 10Jeroen De Dauw) [19:06:37] (03Merged) 10jenkins-bot: Remove not needed singleton call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136781 (owner: 10Jeroen De Dauw) [19:07:04] (03Merged) 10jenkins-bot: Remove silly test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136785 (owner: 10Jeroen De Dauw) [19:47:30] Is it possible to search for items which has wikilinks to redirects? [19:52:05] GerardM- Do you know? ^ [19:56:17] no [19:56:24] not as far as I know [19:56:48] because when a redirect is created, the link should move with it [19:56:55] hmm....there must be some way... [19:57:14] I know, but I have found like 20 in the last 5 mdays in 'The Game' [19:57:26] wait... [19:58:21] That only applies if the page is 'moved' not replaced by a redirect, since it could redirect from CITY in the US, and redirect to the US. then it should not move the item. [20:04:56] wow [20:05:01] wtf [20:05:20] yay for putting classes into the top level namespace [20:05:22] >_> [20:07:15] JeroenDeDauw: where? :O [20:07:28] (03Abandoned) 10Jeroen De Dauw: Fix type hint and simplify method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136776 (owner: 10Jeroen De Dauw) [20:07:45] benestar_: lib [20:07:47] ExceptionHandler [20:07:55] omg [20:09:18] (03PS1) 10Jeroen De Dauw: Move thing only used in repo from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 [20:10:00] benestar_: ^ [20:10:14] JeroenDeDauw: \o/ [20:10:31] * benestar_ belives that JeroenDeDauw will finally kill lib [20:10:41] *believew [20:10:41] *s [20:12:02] (03PS1) 10Jeroen De Dauw: Fix type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136825 [20:12:33] benestar_: looks like I first might need to kill people that add new stuff into lib? *evil laughs* [20:12:46] ^^ [20:13:13] (03CR) 10Jeroen De Dauw: [C: 032] "Per aude https://gerrit.wikimedia.org/r/#/c/136776/1" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136825 (owner: 10Jeroen De Dauw) [20:13:27] (03Merged) 10jenkins-bot: Fix type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136825 (owner: 10Jeroen De Dauw) [20:17:48] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 (owner: 10Jeroen De Dauw) [20:18:18] (03PS1) 10Jeroen De Dauw: Cleanup in SnakConstructionService [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136826 [20:22:36] (03PS1) 10Jeroen De Dauw: Cleanup in SnakFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136827 [20:25:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136825 (owner: 10Jeroen De Dauw) [20:27:00] (03PS1) 10Jeroen De Dauw: Move ChangeNotifier from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136828 [20:31:59] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136826 (owner: 10Jeroen De Dauw) [20:35:37] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136827 (owner: 10Jeroen De Dauw) [20:39:12] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136828 (owner: 10Jeroen De Dauw) [20:53:42] (03PS1) 10Jeroen De Dauw: Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 [20:57:01] (03PS2) 10Jeroen De Dauw: Move ChangeNotifier from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136828 [20:57:05] (03CR) 10Hoo man: [C: 032 V: 032] Improve type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136773 (owner: 10Jeroen De Dauw) [21:01:27] (03CR) 10Hoo man: [C: 032] Move ChangeNotifier from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136828 (owner: 10Jeroen De Dauw) [21:01:40] (03Merged) 10jenkins-bot: Move ChangeNotifier from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136828 (owner: 10Jeroen De Dauw) [21:01:56] (03PS1) 10Jeroen De Dauw: Remove unused method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136893 [21:01:58] (03PS1) 10Jeroen De Dauw: Remove WikibaseRepo access from ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 [21:02:04] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [21:05:29] (03PS1) 10Hoo man: Remove outdated and superfluous pieces of documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136900 [21:06:15] (03PS2) 10Hoo man: Remove outdated and superfluous pieces of documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136900 [21:12:28] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136828 (owner: 10Jeroen De Dauw) [21:12:54] hoo: you removed the license files as well? [21:18:12] JeroenDeDauw: Moved them up into the root [21:18:24] one per distribution (=> repo) is enough [21:18:59] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136888 (owner: 10L10n-bot) [21:19:27] (03CR) 10Hoo man: [C: 031] Move special page code out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136834 (owner: 10Jeroen De Dauw) [21:20:37] (03CR) 10Hoo man: [C: 032] Update imports in SiteLinkCommentCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136778 (owner: 10Jeroen De Dauw) [21:22:46] (03CR) 10Hoo man: [C: 031] "Not approving as I'm not sure what Daniel planned to do with these (IMO they can stick in lib, if needed)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136824 (owner: 10Jeroen De Dauw) [21:23:30] (03CR) 10Hoo man: [C: 032] Update refs to Diff classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136775 (owner: 10Jeroen De Dauw) [21:24:43] (03CR) 10Hoo man: [C: 032] "I still dislike the removal of the inline documentation... but over here it's obvious enough, so ok with me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136826 (owner: 10Jeroen De Dauw) [21:25:49] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136893 (owner: 10Jeroen De Dauw) [21:26:51] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I will do a follow-up. Please hit me if I forgot! ;-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136103 (owner: 10Jeroen De Dauw) [21:27:02] (03CR) 10jenkins-bot: [V: 04-1] Namespace cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136103 (owner: 10Jeroen De Dauw) [21:27:28] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Remove outdated and superfluous pieces of documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136900 (owner: 10Hoo man) [21:27:30] hoo: aaaaah [21:27:32] sure [21:27:34] works for now [21:28:04] (03CR) 10Hoo man: [C: 032] "All remaining callers look sane (=> passing a PropertyId)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136827 (owner: 10Jeroen De Dauw) [21:28:11] hoo: ofc we just need to split the whole repo [21:28:47] JeroenDeDauw: Once we do that, we have to have individual COPYING files and short README.mds pointing to wikiba.se (or so) [21:29:01] WikibaseClient.git, WikibaseRepo.git, the new serialization repos, DispatchChanges.git, etc [21:29:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 (owner: 10Jeroen De Dauw) [21:30:15] If we find a decent way to manage all that in composer, I'm fine with it [21:30:24] (03PS2) 10Jeroen De Dauw: Namespace cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136103 [21:30:37] just don't want to go back to the state where I have to keep several repos up to date per hand [21:30:38] hoo: not much change from what we do now really [21:30:46] Yeah ofc [21:30:53] Actually it will get simpler [21:31:04] Since we will no longer need this silly "disable repo/client" setting [21:32:15] (03PS1) 10Jeroen De Dauw: Add constructor docs for WikibaseLuaBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136907 [21:32:31] (03CR) 10Jeroen De Dauw: [C: 032] "CR per Thiemo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136103 (owner: 10Jeroen De Dauw) [21:33:03] (03Merged) 10jenkins-bot: Namespace cleanup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136103 (owner: 10Jeroen De Dauw) [21:33:16] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/136907/ :) [21:33:52] (03CR) 10Hoo man: [C: 032 V: 032] Add constructor docs for WikibaseLuaBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136907 (owner: 10Jeroen De Dauw) [21:34:07] hahaha [21:34:11] :P [21:34:16] hoo: Thiemo_WMDE will come after you now [21:34:33] hey, my chocolate! [21:34:50] Thiemo_WMDE: just steal that of hoo, he is not in the office to prevent it anyway [21:34:58] I think I earned myself about a kilo chocolate just tonight :D [21:35:04] right. nomnom. [21:35:37] did you merged the other half of jeroens 50+ patches? ;-) [21:35:40] (03CR) 10Hoo man: [C: 032] "No callers to the removed method" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136893 (owner: 10Jeroen De Dauw) [21:35:46] Thiemo_WMDE: Still on it [21:35:47] hoo: reviewing one of Daniels changes is more work then what you reveiwed today! ;p [21:36:06] So the choc thing needs to be balanced somehow [21:36:24] Or rate limited? :D [21:37:02] JeroenDeDauw: is there a specific reason why all the resource files are in lib? [21:37:28] JeroenDeDauw: Do we no longer enforce @since tags in Wikibase? [21:37:32] it does not make that much sense to have the edit interface there... [21:37:49] (03CR) 10Thiemo Mättig (WMDE): "Please note that this removes the exception catch. Not sure if this is can cause trouble here." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136514 (owner: 10Jeroen De Dauw) [21:37:55] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136900 (owner: 10Hoo man) [21:37:57] benestar|afk: We at one point planned to have client editing [21:38:23] hoo: is this still planned? [21:38:58] benestar|afk: As part of VE maybe... for details you have to ask Lydia... but it's nothing we're currently working on [21:39:05] or will be in the near future [21:41:48] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136900 (owner: 10Hoo man) [21:42:13] (03CR) 10Hoo man: [C: 032] "Will at least catch fatals etc." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [21:44:00] (03PS1) 10Jeroen De Dauw: Fix NS of class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136909 [21:44:11] Thiemo_WMDE: can you review this one? ^ [21:44:21] I messed something up with the NS cleanup [21:44:24] Which is fixed by that one [21:44:32] JeroenDeDauw: Do we no longer enforce @since tags in Wikibase? [21:44:35] Apparently some code was not covered by test [21:44:49] hoo: only where it makes sense to have them [21:44:54] k [21:45:03] hoo: https://www.mediawiki.org/wiki/Wikibase/Coding_conventions#.40since_tags [21:46:20] (03CR) 10Hoo man: "doc." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 (owner: 10Jeroen De Dauw) [21:46:24] ok [21:46:29] (03PS1) 10Jeroen De Dauw: Move GenericEventDispatcher and DispatchingEntityStoreWatcher out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136911 [21:46:31] JeroenDeDauw: --^ [21:46:53] huh [21:47:32] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136103 (owner: 10Jeroen De Dauw) [21:47:38] hoo: sure [21:47:59] hoo: the @since... well, I'm not sure I consider the factory to be public [21:48:03] (03CR) 10Hoo man: [C: 032] Make EditEntityTest run hook code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135425 (owner: 10Thiemo Mättig (WMDE)) [21:48:20] And in any case, like we are versioning Wikibase.git, the tags have little meaning to begin with [21:48:32] Once we split the thing we can start sane versioning [21:48:39] And clearly define what the public API of a package ios [21:48:47] And then enforce the tags there [21:49:18] (03PS2) 10Jeroen De Dauw: Remove WikibaseRepo access from ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 [21:49:25] (03PS3) 10Jeroen De Dauw: Remove WikibaseRepo access from ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 [21:49:50] hoo: can you review this? https://gerrit.wikimedia.org/r/#/c/136909/ [21:50:19] (03CR) 10Hoo man: [C: 032 V: 032] Remove WikibaseRepo access from ChangeNotifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 (owner: 10Jeroen De Dauw) [21:50:25] sure [21:50:31] (03CR) 10Thiemo Mättig (WMDE): "Uh, WikidataJenkins, hello?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136909 (owner: 10Jeroen De Dauw) [21:50:45] Thiemo_WMDE: I probably DoS'd Jenkins a bit :D [21:51:17] hoo, please wait for the tests and don't +2+2, k? [21:51:31] Thiemo_WMDE: just +2 if you are fine with the change. You don't need to wait on Jenkins, it will only merge it after it verified [21:51:33] Thiemo_WMDE: Tests passed on the same change before... only comments were changes ;) [21:51:40] * changed [21:51:50] Thiemo_WMDE: +2 does not merge the tests [21:52:03] A CR+2 with failing tests later is perfectly fine [21:52:16] I'm talking about this: https://gerrit.wikimedia.org/r/#/c/136894/3 [21:52:41] Thiemo_WMDE: sure. I am talking about https://gerrit.wikimedia.org/r/#/c/136909/ [21:53:29] (03CR) 10Hoo man: [C: 032] Update class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136774 (owner: 10Jeroen De Dauw) [21:54:56] (03PS1) 10Jeroen De Dauw: Remove only usage of V4GuidGenerator from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 [21:55:26] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "This will make a lot more sense with later patches, hopefully." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136909 (owner: 10Jeroen De Dauw) [21:55:29] (03PS2) 10Hoo man: Remove only usage of V4GuidGenerator from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 (owner: 10Jeroen De Dauw) [21:55:52] (03Merged) 10jenkins-bot: Fix NS of class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136909 (owner: 10Jeroen De Dauw) [21:56:54] meh [21:57:00] Evil serialization code [21:57:02] die already [21:57:24] (03PS4) 10Bene: Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) [21:57:37] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136907 (owner: 10Jeroen De Dauw) [21:57:39] (03CR) 10jenkins-bot: [V: 04-1] Insert HTML for badges in ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [21:58:46] (03CR) 10Hoo man: [V: 04-1] "There were 2 failures:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 (owner: 10Jeroen De Dauw) [21:59:41] (03CR) 10Jeroen De Dauw: Fix NS of class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136909 (owner: 10Jeroen De Dauw) [22:00:38] hoo: huh [22:00:49] hoo: you sure the Lua failure was caused by that particular commit? [22:00:55] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136909 (owner: 10Jeroen De Dauw) [22:00:56] JeroenDeDauw: Yes! [22:01:05] hoo: so the failure is not on master? [22:01:10] no [22:01:22] Oh I see [22:01:24] meh [22:01:35] Tests should not use randomness you know :) [22:01:47] Or use production code they are not testing [22:01:47] (03PS1) 10Bene: Fixed removing all badges with Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136917 [22:01:51] Well [22:01:56] Guess this is an int test [22:02:01] So that does not fully apply [22:02:14] It's an integration test, yes [22:03:09] (03PS1) 10Jeroen De Dauw: Merge "Fix NS of class" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136918 [22:03:13] just use some randomness... eg MWCryptRand::generate( 32 ); or so [22:03:20] err [22:03:22] oops [22:03:45] (03Abandoned) 10Jeroen De Dauw: Merge "Fix NS of class" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136918 (owner: 10Jeroen De Dauw) [22:03:51] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136911 (owner: 10Jeroen De Dauw) [22:04:22] (03PS3) 10Jeroen De Dauw: Remove only usage of V4GuidGenerator from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 [22:05:22] I have to verify these per hand, as WikidataJenkins doesn't run those tests [22:08:04] (03CR) 10Hoo man: [C: 032] Right-to-left rendering for site links in diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [22:09:28] (03CR) 10Hoo man: [C: 032 V: 032] "Ran the tests manually (those don't run in WikidataJenkins)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 (owner: 10Jeroen De Dauw) [22:10:10] (03PS2) 10Jeroen De Dauw: Move GenericEventDispatcher and DispatchingEntityStoreWatcher out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136911 [22:10:40] hoo: damn, I need to create changes faster - you guys are catching up! :) [22:10:57] muhahaahha :D [22:13:03] (03CR) 10Hoo man: [C: 032] "Your commit summaries could be a bit more precise about SimpleSiteLink.... but whatever" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136772 (owner: 10Jeroen De Dauw) [22:13:05] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 (owner: 10Jeroen De Dauw) [22:19:01] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136894 (owner: 10Jeroen De Dauw) [22:24:55] (03CR) 10Daniel Kinzler: [C: 04-1] "as per Thiemo" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134373 (owner: 10Daniel Kinzler) [22:26:31] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 (owner: 10Jeroen De Dauw) [22:28:18] (03PS1) 10Jeroen De Dauw: Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136923 [22:31:13] (03PS1) 10Jeroen De Dauw: Cleanup in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 [22:32:47] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/6uwQfA [22:32:47] 13WikibaseDataModel/06master 14a38f59a 15Marius Hoch: Merge pull request #104 from wmde/refequals... [22:32:54] [13WikibaseDataModel] 15mariushoch 04deleted 06refequals at 14627e9c3: 02http://git.io/coUsmw [22:33:08] (03PS1) 10Jeroen De Dauw: Cleanup in TermSqlIndexTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136927 [22:33:43] (03PS3) 10Jeroen De Dauw: Remove unused parameters and reduce visibility scope [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135802 [22:34:37] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 (owner: 10Jeroen De Dauw) [22:36:11] (03PS1) 10Jeroen De Dauw: Remove unused referenced and stop using deprecated aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136930 [22:39:22] * hoo kicks WikidataJenkins [22:40:58] Let's see how many million errors we get against DM 1.0 now [22:44:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [22:46:23] (03CR) 10Hoo man: [C: 04-1] "Needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/124391 (https://bugzilla.wikimedia.org/58990) (owner: 10Bene) [22:49:51] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136917 (owner: 10Bene) [22:50:17] (03CR) 10Hoo man: [C: 032] Fixed removing all badges with Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136917 (owner: 10Bene) [22:52:07] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136918 (owner: 10Jeroen De Dauw) [22:56:02] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136914 (owner: 10Jeroen De Dauw) [22:57:40] [13WikibaseDataModel] 15JeroenDeDauw created 06sllist (+1 new commit): 02http://git.io/c3r9Ew [22:57:40] 13WikibaseDataModel/06sllist 14fcffaec 15jeroendedauw: Make adding of site links to a SiteLinkList more convenient [22:58:03] hoo: since Jenkins is being so slow, you can review this in the meanwhile ;p https://github.com/wmde/WikibaseDataModel/pull/98 [22:58:30] JeroenDeDauw: Already opened it :D [22:59:06] haha wtf [22:59:08] https://scrutinizer-ci.com/g/wmde/WikibaseDataModel/statistics/ [22:59:12] And suddently there where issues [22:59:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136911 (owner: 10Jeroen De Dauw) [23:00:07] [travis-ci] wmde/WikibaseDataModel/sllist/fcffaec : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/26619570 [23:01:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/ffd78bc : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26615650 [23:01:50] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136923 (owner: 10Jeroen De Dauw) [23:02:06] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/mMrrMA [23:02:06] 13WikibaseDataModel/06master 1402752d1 15Marius Hoch: Merge pull request #108 from wmde/sllist... [23:02:13] [13WikibaseDataModel] 15mariushoch 04deleted 06sllist at 14fcffaec: 02http://git.io/9zLqIw [23:02:38] hoo: but but but, that is the wrong commit! :) [23:03:31] 98 vs. 108, meh :D [23:03:41] oh, I looked at that [23:03:45] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 (owner: 10Jeroen De Dauw) [23:04:00] seems like a unit tests only usable mock to me (the implementation) [23:04:10] the interface is fine with me [23:04:14] (03PS2) 10Jeroen De Dauw: Cleanup in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 [23:04:52] hoo: the trivial implementation? yeah, you can use that as a fixture in tests [23:05:12] Though also in production code [23:05:21] If you know in advance which props will be needed... [23:06:14] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/06f8ee6 : Hoo man The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26616332 [23:07:06] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136927 (owner: 10Jeroen De Dauw) [23:07:07] * hoo wtfs hard [23:07:19] ... and my firefox frooze [23:09:20] Thiemo_WMDE you broke it!111 [23:09:22] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135802 (owner: 10Jeroen De Dauw) [23:09:42] JeroenDeDauw: Are you on that? [23:09:45] Or shall I revert [23:10:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/d4dacd8 : Hoo man The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26616425 [23:10:59] JeroenDeDauw: https://gerrit.wikimedia.org/r/136911 fixes that, right? [23:11:15] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136930 (owner: 10Jeroen De Dauw) [23:12:24] * hoo panics [23:13:06] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 (owner: 10Jeroen De Dauw) [23:13:20] (03CR) 10Hoo man: [C: 032] Move GenericEventDispatcher and DispatchingEntityStoreWatcher out of Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136911 (owner: 10Jeroen De Dauw) [23:13:36] ... now I have to rebase them all -.- [23:13:50] (03PS2) 10Hoo man: Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136923 (owner: 10Jeroen De Dauw) [23:14:35] (03PS2) 10Hoo man: Cleanup in TermSqlIndexTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136927 (owner: 10Jeroen De Dauw) [23:14:38] (03PS4) 10Hoo man: Remove unused parameters and reduce visibility scope [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135802 (owner: 10Jeroen De Dauw) [23:14:40] (03PS2) 10Hoo man: Remove unused referenced and stop using deprecated aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136930 (owner: 10Jeroen De Dauw) [23:14:43] (03PS3) 10Hoo man: Cleanup in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 (owner: 10Jeroen De Dauw) [23:16:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/de07e10 : Hoo man The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26616663 [23:16:56] why can't I no longer stop stuff on gerrit [23:19:57] * travis [23:22:33] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136923 (owner: 10Jeroen De Dauw) [23:22:42] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/79d1271 : Hoo man The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26619195 [23:23:32] (03CR) 10Hoo man: [C: 032] Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136923 (owner: 10Jeroen De Dauw) [23:30:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136927 (owner: 10Jeroen De Dauw) [23:33:59] (03CR) 10Hoo man: [C: 032] Cleanup in TermSqlIndexTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136927 (owner: 10Jeroen De Dauw) [23:35:43] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135802 (owner: 10Jeroen De Dauw) [23:39:16] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136930 (owner: 10Jeroen De Dauw) [23:43:00] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 (owner: 10Jeroen De Dauw) [23:48:03] (03CR) 10Hoo man: [C: 032] Cleanup in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136925 (owner: 10Jeroen De Dauw) [23:48:46] (03CR) 10Hoo man: [C: 032] Remove unused referenced and stop using deprecated aliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/136930 (owner: 10Jeroen De Dauw)