[00:00:40] Btw did you guys see this earlier? [00:00:42] [20:39:44] https://www.wikidata.org/wiki/Q175211 -> AKA East Francia, which is https://www.wikidata.org/wiki/Q153080 [00:00:42] [20:40:56] Looks like I can't add AKA "Kingdom of Germany" to Q175211 due to this. ("Malformed input: East Francia") [00:01:27] which property? [00:01:58] * aude suspects there might be an issue with string validation [00:03:35] aude, sorry, not sure what you're talking about. I wanted to add 'Kingdom of Germany' to Q175211's 'Also Known As' list [00:03:42] ok, alias [00:03:43] But it returns an error: Malformed input: East Francia [00:03:48] yeah, sorry [00:03:54] * aude checks [00:04:08] Now, I guess this is due to 'East Francia' having an entry of it's own - Q153080 [00:04:21] huh, worked for me [00:04:27] shoudl be unrelated [00:04:46] aude: Didn'T work for you [00:04:51] can't see your change in the history [00:04:59] :| [00:05:02] really [00:05:14] Q175211, right? [00:05:18] the string issue seems to disappear with https://gerrit.wikimedia.org/r/#/c/135498/ [00:05:26] Q175211, yeah [00:05:36] but would be unrelated to aliases [00:05:49] oh [00:05:52] * aude confused [00:06:29] can reproduce [00:06:40] yep, so can I [00:07:02] would have to do with validation, but seems unrelated to other issue [00:07:20] Okay then [00:07:51] Malformed input: xdfdfsfs [00:07:53] for string [00:08:11] mh [00:08:23] this is yet another secondary storage inconsistency thing [00:08:41] but we don't yet have a maint. script for this [00:09:22] i am randomly getting malformed input for strings [00:09:35] (seemed to get that on wikidata on friday, but couldn't confirm) [00:10:02] mh? [00:10:11] yeah [00:10:18] unrelated to aliases [00:10:26] but think there are a number of issues going on [00:11:01] the aliases thing over here clearly is a secondary storage inconsistency [00:11:10] likely [00:11:42] wtf [00:11:51] I can't remove the duplicate alias [00:13:47] huh, i seem to be submitting strings like 'fsfs\n' [00:13:50] when i press enter [00:14:10] doesn't like "value":"fsfs " also [00:14:17] * aude goes to bugzilla [00:14:38] wow, uh [00:14:47] comes from formatter [00:14:55] I just edited that page with the special page and it complained about "Regnum Teutonicum" [00:15:04] but later on I could add "Regnum Teutonicum" using the API just fine [00:15:10] ugh [00:15:38] Malformed input: Regnum Teutonicum [00:15:50] aude: https://www.wikidata.org/wiki/Special:SetAliases/Q175211 [00:15:59] Just go there and submit it... :/ [00:17:00] ok... special page bug [00:17:15] [00:17:31] If I remove that from the special page form via dev. tools the form works fine [00:18:51] . Html::input( 'remove', 'remove', 'hidden' ) [00:18:55] no idea why it's there [00:20:22] ok... now it works out of the box [00:21:05] heh https://www.wikidata.org/w/index.php?title=Q175211&diff=133921949&oldid=133921616 :P [00:21:10] aude: ^ See that diff [00:22:38] look in a sec [00:22:46] hmmm, was https://bugzilla.wikimedia.org/show_bug.cgi?id=63301 really fixed? [00:22:51] string issue happens on master [00:23:25] done on bugzilla [00:23:57] hoo: no diff? [00:23:58] aude: Might not be deployed yet [00:24:08] it's not in Wikibase, but ValueView [00:24:14] so even different cycle [00:24:24] happens on master, but suppoes if we don't have that value view in master wikibase... [00:24:30] aude: Yeah :/ Shouldn't the change ops catch such no-ops [00:27:13] "data-values/value-view": "~0.5.0", [00:27:36] seems to be the case, though imho the formatter should also take care of this [00:28:51] aude: mh... so we need to 1) make a new ValueView release and 2) update Wikibase with taht [00:28:56] is the issue huge? [00:29:01] it's annoying [00:29:18] ran into it quite a bit on friday, though not as much as the other issues [00:30:47] shall have to chat with tobi and lydia about the bugs and see what we can backport [00:31:41] Yeah [00:37:02] * aude done for today [00:37:10] +1 :) [00:37:29] * hoo will only do some more trivial code review [00:37:37] that's fine [00:37:56] * aude has worked too much overtime and is out after deployment tomorrow [00:38:06] and then travel [00:38:40] (03CR) 10Hoo man: [C: 032] Fix broken documentation in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135416 (owner: 10Thiemo Mättig (WMDE)) [00:39:00] but i do want to follow up on the lua tests [00:39:02] (03Merged) 10jenkins-bot: Fix broken documentation in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135416 (owner: 10Thiemo Mättig (WMDE)) [00:39:28] aude: Oh yes... could you do that early tomorrow or so? I really dislike having the tests broken [00:39:41] I can also do a quick fix first and you can do the bigger change after [00:40:00] we can remove the data mismatch snak [00:40:10] then we can follow up and add that [00:42:01] (03CR) 10Hoo man: [C: 04-1] "Please don't mix documentation changes with other things (even if they seem trivial like over here)." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135420 (owner: 10Thiemo Mättig (WMDE)) [00:44:27] aude: Yep :) Sounds good for tomorrow [00:45:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=65788 [00:47:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase/master/1b5cce9 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26089639 [01:03:14] (03CR) 10Aude: "removed mismatch snak for now." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [01:03:21] (03PS2) 10Aude: Update lua tests for snak error formatting changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 [01:04:23] (03PS3) 10Aude: Update lua tests for snak error formatting changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 [01:06:18] aude: Did you run the tests locally on taht? [01:06:45] yes [01:06:55] do try them yourself also to be sure [01:07:02] k [01:07:11] i setup luasandbox on friday to get all the tests to run for me [01:08:20] why did you not use the standalone version? [01:08:41] it skipped some tests [01:09:11] That's a bit weird, but nothing really to worry about [01:09:38] does jenkins run the test for the Wikidata builds [01:09:41] the lua ones, I mean [01:10:06] 1) Wikibase\Test\Scribunto_LuaWikibaseEntityLibraryTest [01:10:06] interpreter for LuaSandbox is not available [01:10:29] no idea why, but i have a place to run tests w/ sandbox [01:10:34] now* [01:10:47] Ok... but I think that was wasted time [01:10:52] jenkins, no idea [01:10:56] enough if they run on Jenkins [01:11:05] Jenkins has LuaSandbox [01:11:07] not on our jenkins and not sure about wmf jenkins [01:11:13] i see [01:11:19] but I think we manually need to set Scribunto as a req. like we did for Capiunto [01:11:26] yep [01:11:44] sandbox on ubuntu was easy to install [01:11:52] it just doesn't work on osx with 64 bit [01:12:06] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [01:12:10] aude: mh... it fails to compile? [01:12:24] something like that [01:12:29] seems a known issue [01:12:32] that's nasty [01:12:32] luajit [01:12:36] w/* [01:12:46] probably a bug or a dependency problem [01:12:54] so gave up and can easily do things on ubuntu install [01:13:13] not always worth investing time to make everything work on osx [01:13:18] ok, but I don't think it's needed... enough if htey run with sandbox on the builds [01:13:28] yeah but wanted to verify my patch [01:13:40] no skipped tests [01:14:05] aude: I've never seen a problem with Sandbox myself, so I wouldn't be to worried... it's just a different way to interact with Lua [01:14:07] for PHP [01:14:15] ok [01:14:28] as long as the tests are otherwise identical [01:14:33] * aude no idea [01:16:02] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [01:16:10] * aude ignore jenkins [01:25:52] (03CR) 10Hoo man: [C: 032] "Works locally" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [01:25:57] yay [01:26:00] now waiting for travis :) [01:26:08] ok [01:26:15] sorry i missed that before [01:26:19] (03Merged) 10jenkins-bot: Update lua tests for snak error formatting changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134981 (owner: 10Aude) [01:26:47] at least i understand the lua + tests a bit better now [01:27:17] :) [01:27:26] * aude done for real now for today [01:29:44] so am I [01:35:18] (03PS2) 10Aude: Focus snakview variation only when viewState is enabled [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135498 (https://bugzilla.wikimedia.org/64651) [01:40:01] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/26091024 passed :) [01:40:15] Wonder why it doesn't report here [01:41:15] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135498 (https://bugzilla.wikimedia.org/64651) (owner: 10Aude) [01:43:14] only failures [01:43:21] it should say the build was fixed though [01:44:16] yep [07:15:48] [13ValueView] 15adrianlang comment on pull request #56 14d5deb12: Because there is no reasonable context for a function passed in as an option. 02http://git.io/W39FFg [07:47:12] [13ValueView] 15adrianlang 04force-pushed 06getMessage from 14d5deb12 to 14a87351f: 02http://git.io/rm2oLg [07:47:12] 13ValueView/06getMessage 14a87351f 15Adrian Lang: Correct messageGetter option to MessageProvider... [08:09:57] (03CR) 10Adrian Lang: [C: 031] "Can you add a test for that?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [08:16:15] (03CR) 10Adrian Lang: [C: 032] Remove unused imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135026 (owner: 10Jeroen De Dauw) [08:16:49] (03Merged) 10jenkins-bot: Remove unused imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135026 (owner: 10Jeroen De Dauw) [08:17:33] (03CR) 10Adrian Lang: [C: 04-1] "I would prefer to have it the other way round." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135437 (owner: 10Thiemo Mättig (WMDE)) [08:19:52] (03CR) 10Adrian Lang: Optimized repo imports (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135031 (owner: 10Jeroen De Dauw) [08:21:12] hey [08:21:30] (03CR) 10Adrian Lang: [C: 032] Remove deprecated Lib/FormattingException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135440 (owner: 10Thiemo Mättig (WMDE)) [08:21:57] (03Merged) 10jenkins-bot: Remove deprecated Lib/FormattingException [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135440 (owner: 10Thiemo Mättig (WMDE)) [08:44:45] (03CR) 10Adrian Lang: [C: 032] Focus snakview variation only when viewState is enabled [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135498 (https://bugzilla.wikimedia.org/64651) (owner: 10Aude) [08:45:49] (03Merged) 10jenkins-bot: Focus snakview variation only when viewState is enabled [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135498 (https://bugzilla.wikimedia.org/64651) (owner: 10Aude) [08:48:14] (03CR) 10Thiemo Mättig (WMDE): Optimized repo imports (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135031 (owner: 10Jeroen De Dauw) [08:50:39] (03PS1) 10Thiemo Mättig (WMDE): A bit of "use" cleanup in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135528 [08:56:19] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135528 (owner: 10Thiemo Mättig (WMDE)) [09:02:14] (03CR) 10Adrian Lang: [C: 032] Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135031 (owner: 10Jeroen De Dauw) [09:02:42] (03Merged) 10jenkins-bot: Optimized repo imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135031 (owner: 10Jeroen De Dauw) [10:00:30] (03PS1) 10WikidataBuilder: New Wikidata Build - 27/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135540 [10:08:20] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135540 (owner: 10WikidataBuilder) [10:47:05] Hi [10:48:56] does someone knows which property is actual/better for definining relationships between geographical places: P131 or P150 ? [10:49:54] I know, that P150 is set in the parent place, P131 in the child [10:50:37] sometimes P131 is used, sometimes P150, sometimes both. Unnecessary redundancy? [11:16:58] !admin User:TR0LLOLOL69 is on a tear of vandalism and his contribs and username suggest he/she has no intention other than that [11:32:24] Hm, if you don't warn them they don't stop. :/ [12:03:55] sjoerddebruin: warned the user [12:04:36] Thiemo_WMDE: any chance you could look at the chain of changes leading up to https://gerrit.wikimedia.org/r/#/c/135044/ ? [12:04:53] it would good to get at least a few of them berged this sprint. [12:10:50] (03CR) 10Thiemo Mättig (WMDE): "Das ist nicht dein Ernst? Ich werde das nicht aufteilen nur um des Aufteilens willen." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135420 (owner: 10Thiemo Mättig (WMDE)) [12:12:37] Adrian_WMDE: change all of the files! [12:12:58] Thiemo_WMDE: you are posting comments in German now? [12:15:12] [13ValueView] 15JeroenDeDauw comment on pull request #51 145ea6f9d: Indenting 02http://git.io/rKlpYA [12:19:34] [13DataValuesJavascript] 15adrianlang created 06globeCoordPrecision (+1 new commit): 02http://git.io/2s1xjg [12:19:34] 13DataValuesJavascript/06globeCoordPrecision 14f2a9161 15Adrian Lang: Remove limiting of precisions for globe coordinates... [12:20:24] [13DataValuesJavascript] 15adrianlang opened pull request #39: Remove limiting of precisions for globe coordinates (06master...06globeCoordPrecision) 02http://git.io/GFP6vA [12:35:58] [13ValueView] 15adrianlang 04force-pushed 06refactorExperts from 145ea6f9d to 142502862: 02http://git.io/XLBMGw [12:35:58] 13ValueView/06refactorExperts 142502862 15Adrian Lang: Factor inputextender and content out of time and globecoordinate experts... [12:36:26] (03CR) 10Jeroen De Dauw: [C: 032] "Hoo: you are right that generally one ought to keep such things separate, esp if the code changes made might need a revert. In this case i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135420 (owner: 10Thiemo Mättig (WMDE)) [12:39:25] JeroenDeDauw: My German comment was more or less identical to your comment. ;-) [12:40:01] Thiemo_WMDE: well, good it boguht this commit to my attention [12:40:43] I'm quite convinced this kind of review, while intended well, is both counter productive quality and efficiency wise, and rather demotivational [12:41:23] Yea, I think you made this clear a few days ago. ;-) [12:57:05] Adrian_WMDE: this Sinon.js thing looks interesting - guess you introduced it into the project? [12:59:05] JeroenDeDauw: No, I didn't. It's in core [12:59:25] heh [13:01:42] Oh, but it was just added, February 2014 [13:01:47] 7884ef52f6d7f36418bbcefdf13daf437b408622 [13:02:47] * aude bets that krink-le added it [13:02:56] aude: You won [13:02:59] :) [13:03:15] wait wait wait, I got an image for that [13:03:25] lol [13:03:58] aude: https://dl.dropboxusercontent.com/u/7313450/entropy/winrar.png [13:04:32] Adrian_WMDE: so is it in 1.23? [13:05:23] (03PS2) 10Thiemo Mättig (WMDE): Right-to-left rendering for site links in diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) [13:05:27] Should be, right? [13:05:36] (03CR) 10jenkins-bot: [V: 04-1] Right-to-left rendering for site links in diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [13:06:52] JeroenDeDauw: yes [13:08:01] (03PS3) 10Thiemo Mättig (WMDE): Right-to-left rendering for site links in diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) [13:15:00] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [13:18:30] (03CR) 10WikidataJenkins: [V: 04-1] "Build Failed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [13:20:44] Tobi_WMDE: nothing in the html diff jumps out. this is really freaky. will file a bug [13:24:04] Lydia_WMDE: scary [13:24:10] indeed [13:29:30] huh? [13:29:33] * aude panics [13:30:07] oh, empty diff [13:32:14] Lydia_WMDE: https://www.wikidata.org/w/index.php?title=Q175211&diff=next&oldid=133921616 [13:32:25] that was a null edit [13:32:57] no change so the diff is ok, but odd that it is considered a new edit [13:33:28] aude: and why does it get this summary [13:34:38] dont' know, but hoo was doing something hacky (w/ special page or something) [13:39:25] (03PS1) 10Aude: Focus snakview variation only when viewState is enabled [extensions/Wikibase] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135566 (https://bugzilla.wikimedia.org/64651) [13:40:05] ok [13:45:14] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135566 (https://bugzilla.wikimedia.org/64651) (owner: 10Aude) [13:46:42] (03CR) 10Aude: [C: 032] Focus snakview variation only when viewState is enabled [extensions/Wikibase] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135566 (https://bugzilla.wikimedia.org/64651) (owner: 10Aude) [13:47:00] (03Merged) 10jenkins-bot: Focus snakview variation only when viewState is enabled [extensions/Wikibase] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135566 (https://bugzilla.wikimedia.org/64651) (owner: 10Aude) [13:48:34] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/nsPOjQ [13:48:34] 13WikibaseDataModelSerialization/06master 14b04bce5 15jeroendedauw: protected -> private [13:53:39] [13WikibaseDataModelSerialization] 15JeroenDeDauw created 06rel (+2 new commits): 02http://git.io/KAFAog [13:53:39] 13WikibaseDataModelSerialization/06rel 144633053 15jeroendedauw: Update README [13:53:39] 13WikibaseDataModelSerialization/06rel 14320c2b6 15jeroendedauw: 1.0 release [13:53:49] [13WikibaseDataModelSerialization] 15JeroenDeDauw opened pull request #64: 1.0 release (06master...06rel) 02http://git.io/Vhzgmw [13:55:51] [travis-ci] wmde/WikibaseDataModelSerialization/rel/320c2b6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/26131091 [13:56:07] Thiemo_WMDE: https://github.com/wmde/WikibaseDataModelSerialization/pull/64 [13:56:56] (03PS4) 10Thiemo Mättig (WMDE): Right-to-left rendering for site links in diff [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) [14:02:58] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134386 (https://bugzilla.wikimedia.org/36635) (owner: 10Thiemo Mättig (WMDE)) [14:04:31] Tobi_WMDE: https://github.com/wmde/WikibaseDataModelSerialization/pull/64 [14:07:20] [13WikibaseDataModelSerialization] 15tobijat pushed 1 new commit to 06master: 02http://git.io/6ar_Lw [14:07:20] 13WikibaseDataModelSerialization/06master 145fd52d7 15Tobi Gritschacher: Merge pull request #64 from wmde/rel... [14:07:40] [13WikibaseDataModelSerialization] 15tobijat 04deleted 06rel at 14320c2b6: 02http://git.io/ag5S-g [14:08:05] [13WikibaseDataModelSerialization] 15JeroenDeDauw tagged 061.0 at 14320c2b6: 02http://git.io/8WVXag [14:08:37] (03CR) 10Aude: [C: 032] New Wikidata Build - 27/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135540 (owner: 10WikidataBuilder) [14:08:54] * JeroenDeDauw goes and make a MW install :( [14:09:01] * JeroenDeDauw blames Thiemo_WMDE [14:09:08] :D [14:09:13] (03Abandoned) 10Aude: New Wikidata Build - 23/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135009 (owner: 10WikidataBuilder) [14:09:31] (03Abandoned) 10Aude: New Wikidata Build - 26/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135409 (owner: 10WikidataBuilder) [14:10:12] [travis-ci] wmde/WikibaseDataModelSerialization/master/5fd52d7 : Tobi Gritschacher The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/26132160 [14:11:40] (03Merged) 10jenkins-bot: New Wikidata Build - 27/05/2014 10:00 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135540 (owner: 10WikidataBuilder) [14:12:22] [travis-ci] wmde/WikibaseDataModelSerialization/1.0/320c2b6 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/26132216 [14:23:39] hahahaha Q149 [14:25:31] aude wins another interwebs [14:27:20] * JohnLewis feels like creating 'interwebs' on testwikidata with the property 'winner: aude' qualifier 'governing body: JeroenDeDauw' :p [14:27:57] *statement not qualifier [14:28:43] JohnLewis: testwikidata? You mean wikidata.org? [14:29:12] Wikidata has the WD:UCS policy which says no to it :'( [14:29:43] At least on testwikidata, it won't be deleted [14:30:24] UCS? hahaha [14:30:48] Whoever made that policy, violated it when doing so :D [14:32:35] (03CR) 10Hoo man: [C: 032] A bit of "use" cleanup in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135528 (owner: 10Thiemo Mättig (WMDE)) [14:32:56] (03Merged) 10jenkins-bot: A bit of "use" cleanup in UpdateRepoOnMoveJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135528 (owner: 10Thiemo Mättig (WMDE)) [14:36:13] JeroenDeDauw: https://test.wikidata.org/wiki/Q471 [14:37:17] JohnLewis: UCS makes me think http://earthseries.wikia.com/wiki/United_Civilized_States [14:37:24] That game was so epic [14:37:36] :D [14:38:26] loool [14:38:47] JohnLewis: so what is this policy about? Making a mech army? [14:38:59] I wished. [14:39:19] It's about not doing anything stupid. Which in it's self is a stupid policy but works :p [14:39:56] aude: Are beta features another extension? VectorBeta? [14:41:18] betafeatures extension [14:41:34] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06rel (+1 new commit): 02http://git.io/IV6R5A [14:41:34] 13WikibaseInternalSerialization/06rel 146558a27 15jeroendedauw: 1.0 release [14:41:56] we used it for cirrus as experimental [14:42:01] hoo: You register with a hook. The BF extension just provides the hook; the code for each BF lives in whatever extension. [14:42:27] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #28: 1.0 release (06master...06rel) 02http://git.io/r_fo0w [14:42:38] James_F: I see [14:42:41] Tobi_WMDE: https://github.com/wmde/WikibaseInternalSerialization/pull/28 [14:43:01] aude: Think I can do the reviews then. We will probably also want to update our composer.json?! [14:43:19] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCirrusSearch/f61965e27c1bc9ed55ea5327332dfeb026fca83c/includes%2FHooks.php [14:44:43] aude: is the still missing cleanup for https://bugzilla.wikimedia.org/show_bug.cgi?id=62495 documented somewhere? From just looking at the code and on gerrit I'm not sure what is actually missing.. [14:45:15] aude: I mean from looking at the bug and on gerrit it is unclear to me what is still to do.. [14:46:02] Tobi_WMDE: not yet [14:46:13] we do exception handling in snak html generator [14:46:29] i think that's not needed anymore but we need to verify [14:46:39] [travis-ci] wmde/WikibaseInternalSerialization/rel/6558a27 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/26135275 [14:46:48] if it is used, then needs same formatting [14:47:26] aude: ok, can we have this information in the bug? otherwise we'll just forget and the item stays open forever and for no reason.. [14:47:41] better just to do it [14:47:51] if it's in the sprint, we won't forget [14:48:33] we wont forget but we were wondering why it is still open and then just close it.. ;) [14:49:13] [13WikibaseInternalSerialization] 15tobijat closed pull request #28: 1.0 release (06master...06rel) 02http://git.io/r_fo0w [14:53:28] closed [15:04:23] I noticed https://tools.wmflabs.org/addshore/addbot/iwlinks/ is broken [15:07:59] Wouldn't surprise me knowing addshore. He's not even here [15:11:52] uhm [15:11:55] code leak [15:11:57] fun [15:17:56] I've sent him an email [15:20:17] hm, there are apparently 253 broken links to Q15095464 which was merged into Q7622988 (street artist) [15:24:40] [13DataValuesJavascript] 15tobijat pushed 1 new commit to 06globeCoordPrecision: 02http://git.io/fTKwNA [15:24:40] 13DataValuesJavascript/06globeCoordPrecision 14b641124 15Tobias Gritschacher: Updated release notes and version [15:26:37] (03CR) 10WikidataJenkins: "Build Failed" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/135540 (owner: 10WikidataBuilder) [15:26:46] Krenair: https://www.wikidata.org/wiki/User:BeneBot*/movelinks.js ;) [15:27:28] hoo, guess I have to suggest some admin add to this page then? [15:27:48] I can do it [15:28:03] (03CR) 10Jeroen De Dauw: [C: 031] "PHP looks fine" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135424 (owner: 10Thiemo Mättig (WMDE)) [15:28:30] I'm not 100% sure 'street artist' applies to everyone that Q15095464 did (I don't actually know what that item was) [15:29:29] oh, mh [15:30:15] (03CR) 10Jeroen De Dauw: Make EditEntityTest run hook code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135425 (owner: 10Thiemo Mättig (WMDE)) [15:30:52] [13DataValuesJavascript] 15tobijat closed pull request #39: Remove limiting of precisions for globe coordinates (06master...06globeCoordPrecision) 02http://git.io/GFP6vA [15:33:44] (03CR) 10Jeroen De Dauw: [C: 04-1] Add test for static RepoHooks::onMakeGlobalVariablesScript (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [15:42:42] [13WikibaseInternalSerialization] 15JeroenDeDauw tagged 061.0 at 06master: 02http://git.io/KGDvKg [15:45:56] https://www.wikidata.org/wiki/Q11934921 - dupe of https://www.wikidata.org/wiki/Q3844982 ? [15:50:48] (03PS1) 10Aude: New build, fix for various JS issues when saving statements [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135577 [15:53:57] (03CR) 10Thiemo Mättig (WMDE): "If you can fix PHPStorm, ok. But as it currently is we have only 8 occurrences of "extends MediaWikiTestCase" but 10 times more of "extend" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135437 (owner: 10Thiemo Mättig (WMDE)) [15:55:31] Is there a limit to the number of qualifiers that can be added to something? [15:55:51] (03CR) 10Daniel Kinzler: [C: 031] "@jeroen: please provide a way forward along with your criticism." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [15:56:07] I’m trying to add some more dates to https://www.wikidata.org/wiki/Q179 (operator→ Air Algerie) but it doesn’t let me save. [15:56:09] Krenair: Answered? :) [15:56:29] ty [15:57:13] hawke: Which date and you trying to add and to which and I'll take a look. [15:57:28] n/m, a page reload fixed it. [15:57:55] seems like adding a qualifier and then trying to add some more doesn't work right without a page reload though [15:57:57] hawke: Alright :) [16:00:05] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135577 (owner: 10Aude) [16:01:21] (03CR) 10Daniel Kinzler: [C: 031] "seems ok, but i'm a bit worried just removing any hook handlers that may already have been registered." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135425 (owner: 10Thiemo Mättig (WMDE)) [16:04:39] (03CR) 10Daniel Kinzler: [C: 031] "Yea, PHP looks fine, can't vouch for the JS. Please split that off so I can +2 :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135424 (owner: 10Thiemo Mättig (WMDE)) [16:10:35] (03CR) 10Aude: Add test for static RepoHooks::onMakeGlobalVariablesScript (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135432 (owner: 10Thiemo Mättig (WMDE)) [16:11:23] (03CR) 10Daniel Kinzler: [C: 032] Parse error messages in EditEntity::showErrorPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135489 (https://bugzilla.wikimedia.org/65782) (owner: 10Hoo man) [16:11:49] (03Merged) 10jenkins-bot: Parse error messages in EditEntity::showErrorPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135489 (https://bugzilla.wikimedia.org/65782) (owner: 10Hoo man) [16:12:20] there. [16:12:21] now. [16:12:25] someone review my stuff?... [16:13:53] (03CR) 10Hoo man: [C: 032] "Only looked at JS stuff, PHP per Daniel and Jeroen." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135424 (owner: 10Thiemo Mättig (WMDE)) [16:14:04] (03CR) 10jenkins-bot: [V: 04-1] Fix broken documentation in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135424 (owner: 10Thiemo Mättig (WMDE)) [16:15:14] (03CR) 10Aude: "the js looks ok to me, although it's not really broken documentation." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135424 (owner: 10Thiemo Mättig (WMDE)) [16:16:16] (03CR) 10Aude: [C: 032] New build, fix for various JS issues when saving statements [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135577 (owner: 10Aude) [16:19:18] (03Merged) 10jenkins-bot: New build, fix for various JS issues when saving statements [extensions/Wikidata] (mw1.24-wmf6) - 10https://gerrit.wikimedia.org/r/135577 (owner: 10Aude) [16:19:41] Is there any way to sort qualifiers by date instead of by type? [16:19:56] (or to otherwise have date ranges be sane instead of a list of start dates followed by a list of end dates) [16:20:03] no [16:20:17] there's a bug for that, although not sure priority [16:20:52] basically, my opinion is that qualifiers should not be grouped but don't know how technically difficult [16:21:00] and might wait / be considered for the new ui [16:21:25] https://bugzilla.wikimedia.org/show_bug.cgi?id=63564 [16:23:09] Thanks. [16:24:25] aude .. one qualifier is to indicate the electoral district.. sorting by electoral district is useful [16:38:36] almost feels like 'date range' should be a new data type of some kind … like 'point in time' but expanded. (I understand that that is not necessarily feasible, but…) [16:51:53] How come I can add an alias that is the same as the label? [17:02:01] Josve05a: I'd say that limiting that would be an exaggeration [17:02:04] Lydia_WMDE: ^ ? [17:02:34] lazowik: yes [17:02:36] agreed [17:10:36] (03CR) 10Hoo man: [C: 032] Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [17:10:50] (03CR) 10jenkins-bot: [V: 04-1] Remove StoreFactory and related logic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/134348 (owner: 10Daniel Kinzler) [17:11:14] oh come on -.- [17:11:40] DanielK_WMDE__: ^ want to rebase quickly? [17:48:27] Lydia_WMDE: js fixes are on test.wikidata https://test.wikidata.org/wiki/Q22 [17:48:33] works soooo much better now [17:48:54] shall be on wikidata soonish [17:49:11] \o/ [17:49:14] thx aude [17:49:16] sure [17:49:21] thanks adrian for reviewing [17:50:22] :) [17:54:51] Lydia_WMDE: I made a crucial improvement to item linked by aude [17:56:07] lazowik: :P [17:56:51] heh [17:57:55] Wikidata development team: population: 13±1 [17:57:56] <3 [17:58:00] lol :) [18:43:26] Lydia_WMDE: deployed [18:43:33] \o/ [18:43:38] https://www.mediawiki.org/wiki/Wikidata_deployment#mw1.24wmf6 are the bug fixes and new stuff, afaik [18:44:29] will have a look [18:44:30] i'll stay around ~30 minutes or so if no problems [18:44:42] thanks! :) [18:44:58] the changes are small, except term validation so [18:45:03] oh [18:45:05] 27th [18:45:13] any issues (should be none) with saving aliases, descriptions etc [18:45:18] that also means magnus can reactivate his merge tool [18:45:21] \o/ [18:45:23] :) [18:45:55] GerardM-: ^ [18:46:02] if you want to poke magnus about it [18:46:13] GerardM-: the bug in the api should be fixed now [18:46:20] hmm, there might be more things for omerge item than the bug i linked [18:46:34] he should test it though [18:47:10] no, looks like that's the patch [18:47:11] only one for merge items [18:47:22] but we were seeing in the logs a lot [18:47:33] so assume it came from magnus' tool [18:47:55] yeah [18:49:10] logs appear quiet [18:50:18] well he turned off his tool because of it [18:50:39] guess issues will only reappear once it is turned on again if the issue isn't actually fixed [18:52:32] ok [19:02:00] i'm off, but if any issues come up, email me and i can be available [19:02:57] Lydia_WMDE: ^ [19:03:06] :) [19:03:09] cya! [19:03:10] later [20:17:13] my rollback button isn't working [20:17:21] it says "edit conflict" whenever I try to use it [20:19:02] aude: ^ [20:20:04] Lydia_WMDE ^ cba to email her so I'll let you deal with it :) [20:20:54] Plus I don't have her email... so :p [20:21:40] I'll open a bug if needed just wanted to make sure it isn't a known issue [20:22:01] ajr: Open a bug if you want :) [20:22:02] ajr: yeah please open a bug. i can reproduce. will poke people [20:26:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=65831 [20:26:41] done [20:28:56] ajr: and triaged + CC'd aude [20:29:04] ty [20:31:42] Lydia_WMDE: I keep forgetting sb stuff [20:31:54] np ;-) [20:36:19] * aude panics [20:38:26] aude: Focus and remain calm. It's only rollback :p [20:39:20] heh [20:40:04] this might require danielk to look or might be related to one of his changes [20:40:17] can reproduce [20:40:58] ajr ^ [20:41:05] kk [20:42:18] (03CR) 10WikidataJenkins: "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135684 (owner: 10L10n-bot) [21:31:43] (03PS1) 10Aude: Fix rollback by re-adding baseRevIdForSaving in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135696 (https://bugzilla.wikimedia.org/65831) [21:31:54] Lydia_WMDE: ^ [21:32:05] it's super ugly, so if daniel can find a better way, i prefer that [21:32:21] + more tests [21:33:04] i don't have time at the moment to look further for nicer solution [21:33:57] (03PS2) 10Aude: Fix rollback by re-adding baseRevIdForSaving in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135696 (https://bugzilla.wikimedia.org/65831) [21:34:26] (03PS3) 10Aude: Fix rollback by re-adding baseRevIdForSaving in EntityContent [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135696 (https://bugzilla.wikimedia.org/65831) [21:39:08] aude: thanks for fixing. this is an odd issue. i'll should look into this to understand why this is an issue. [21:39:21] DanielK_WMDE__: please do [21:39:38] we need a way to pass this value to prepareSave [21:40:13] not always same as $baseRevId that is provided as method argument [21:40:30] why not? [21:40:53] aude: we need to be able to check the edit's base rev id against the current base rev... but $page has the current rev, and $baseRevId should be the edit's base rev, so comparing there should be sufficient. [21:40:57] i wonder why it isn't... [21:40:59] in rollback, apparently it's not [21:41:10] i don't have time to further investigate right now [21:41:20] right. will need to dig in and find out why [21:41:21] aude: What's baseRevId during a rollback? [21:41:25] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135696 (https://bugzilla.wikimedia.org/65831) (owner: 10Aude) [21:41:29] The revision id it wants to restore? [21:41:31] it's one lower [21:41:34] Wtf [21:41:35] hoo: probably The Wrong Number (tm) [21:41:39] probably [21:42:16] This sounds scary [21:42:20] +1 [21:42:23] aude: let's keep the ticket open and have it in the sprint. i'll add a comment [21:42:24] and broken [21:42:29] agree [21:43:03] there are probably more skeletons hidden in the closet (as we say in english) [21:43:04] more bugs [21:43:21] Leichen im Keller, in German :D [21:43:25] heh [21:43:44] We should have a integration test which does a basic rollback [21:43:51] * an [21:44:15] yep [21:46:44] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135696 (https://bugzilla.wikimedia.org/65831) (owner: 10Aude) [21:47:27] * aude off [21:50:17] (03CR) 10WikidataJenkins: [V: 032] "Build Successful" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/135696 (https://bugzilla.wikimedia.org/65831) (owner: 10Aude)